[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/889 Ok, I have found the issue. Maven doesn't create a TLS secured gremlin server for it's secure server. I changed my connection string to use a plain web socket with no TLS and the tests have run fine! ---
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user mattallenuk commented on the issue:
https://github.com/apache/tinkerpop/pull/889
@spmallette, sorry, my apologies, haven't been able to look at this much
over the last few days. Have some time planned nearer end of the week to
progress this. I have Maven working but when I run the tests I get 2 issues.
1) On DriverRemoteConnection test I get an error:
[ERROR] Could not deserialize the Traversal instance
java.lang.IllegalStateException: Could not locate method:
GraphTraversalSource.SYNTAX_ERROR()
2) On my DriverRemoteConnectionWithSaslAuthenticator test I get a timeout:
1) DriverRemoteConnectionWithSaslAuthenticator
[INFO]"before all" hook:
[INFO] Uncaught Error: socket hang up
[INFO] at TLSSocket.onHangUp (_tls_wrap.js:1124:19)
[INFO] at endReadableNT (_stream_readable.js:974:12)
[INFO] at _combinedTickCallback (internal/process/next_tick.js:80:11)
[INFO] at process._tickCallback (internal/process/next_tick.js:104:9)
My code to connect to the server is as follows:
```
exports.getSecureConnectionWithAuthenticator = function
getConnection(traversalSource) {
const authenticator = new SaslAuthenticator({ username: 'stephen',
password: 'password' });
return new DriverRemoteConnection('wss://localhost:45941/gremlin', {
traversalSource: traversalSource, authenticator: authenticator,
rejectUnauthorized: false });
};
```
Is the problem here?
---
[GitHub] tinkerpop issue #892: Tinkerpop 2007
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/892 > Long sounds fine. I don't think that `Long` by itself is good enough. As I mentioned in my comments, you can't assume you know anything about the identifier. TinkerPop has no knowledge of what it contains. It could be that a `Graph` implementation uses numbers that exceed the size of `Long` which would generate an error in your current code. > The sort algorithm I suggested is indeed a heuristic, still a better heuristic as the default String sort by Java What you have may be better for identifiers that have pure numerics, but imo, it makes sorts of strings mixed with numbers less intuitive that the default. I think that if you want your change for numbers then you need to make them both make sense. > let's go the other way and make debug/normalization easier accessible by command line. I suggest adding the debug option even in the TinkerPop Docu GraphML initial mentioning (I suggest to add this option for other formats as JSON as well). Your link in the above didn't work, but I think I know what you are referring to. I guess I don't have a problem with calling more attention to the normalization option, but I can't say that I fully follow why normalization should be so important to anyone. The only use case that I am aware of is if you were doing file comparisons/diffs on generated files - normalization would help you there, especially if you were pushing such files into source control or something similar. But, to me, that's not a common use case. I would venture to say that most people just want to "save their data" and don't really care about looking at it in any way. Do you have some other use case that makes this feature so important? You mentioned "analysis of regression tests" but I would like to hear more about that. We tend to be careful about features that don't suit wide use cases. > Sorry for the import reordering, No problem - happens all the time with all different IDEs A final point, depending on the complexity of how this sorting algorithm ends up, I think that it might be important for us to see what the performance differences are between your changes and what we had before. That's nothing that we need to have immediately as the PR is still changing, but I just wanted to let you know that it may be necessary to fully evaluate this PR. ---
[GitHub] tinkerpop issue #889: Tinkerpop 1977 - Sasl Authentication
Github user mattallenuk commented on the issue: https://github.com/apache/tinkerpop/pull/889 @spmallette, no worries. Problem no 2 is a timeout on making connection to the secure gremlin server, my plan is to try the tests on a local gremlin server that I control and then try and dig deeper into how Maven works and see if I can figure out why I cannot connect to the secure server create in the Maven build. Hopefully I'll be able to get it working! ---
[jira] [Commented] (TINKERPOP-2000) MANIFEST.MF contains invalid key
[ https://issues.apache.org/jira/browse/TINKERPOP-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547711#comment-16547711 ] stephen mallette commented on TINKERPOP-2000: - Any futher information on this one? Did you perhaps find some workaround to your problem? > MANIFEST.MF contains invalid key > > > Key: TINKERPOP-2000 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2000 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.3.3 >Reporter: Horacio Hoyos Rodriguez >Priority: Critical > > The MANIFEST.MF file for tinerpop-core contains an invalid key (line 8): > version: 3.3.3 > Some tools (like the Eclipse Bundle Recipes) check for the MANIFEST integrity > and this line causes an error. Perhaps this is the Specification-Version? > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (TINKERPOP-1999) [Java][gremlin-driver] Query to a remote server via the websocket client hangs indefinitely if the server becomes unavailable
[
https://issues.apache.org/jira/browse/TINKERPOP-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stephen mallette reopened TINKERPOP-1999:
-
Something is not right - this change is causing failures in doc generation and
certain integration tests in certain environments:
{{code}}
ERROR org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler -
Could not process the response
java.lang.IllegalStateException: Connection to server is no longer active
at
org.apache.tinkerpop.gremlin.driver.Handler$GremlinResponseHandler.channelInactive(Handler.java:210)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:219)
at
io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:219)
at
io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:219)
at
io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:219)
at
io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:379)
at
io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:344)
at
io.netty.handler.codec.http.websocketx.WebSocket08FrameDecoder.channelInactive(WebSocket08FrameDecoder.java:506)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:219)
at
io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1299)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:240)
at
io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:226)
at
io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:903)
at
io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:768)
at
io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:399)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:464)
at
io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:131)
at java.lang.Thread.run(Thread.java:748)
{{code}}
need to revisit
> [Java][gremlin-driver] Query to a remote server via the websocket client
> hangs indefinitely if the server becomes unavailable
> -
>
> Key: TINKERPOP-1999
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1999
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.3.2, 3.3.3
>Reporter: Ankesh Khandelwal
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.4.0, 3.3.4, 3.2.10
>
>
> Query to a remote server via the websocket client hangs indefinitely if the
> server becomes unavailable.
>
> Consider the code snippet below.
>
>
> {code:java}
> // Create a websocket client
> final Client client =
>
[jira] [Commented] (TINKERPOP-2000) MANIFEST.MF contains invalid key
[ https://issues.apache.org/jira/browse/TINKERPOP-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547722#comment-16547722 ] Horacio Hoyos Rodriguez commented on TINKERPOP-2000: Hi sorry for the delay. I am no expert in MANIFEST files so I can not further suggest a fix. No workaround either, this entry just breaks the "jar to osgi bundle" that is used to provide 3rd party libraries as Eclipse plugins (so you can install them and share them easily). For the moment Just had to put all the jars in my class path. But in the future I would definitely benefit from having Tinkerpop as an OSGI bundle so we can more easily distribute and install. > MANIFEST.MF contains invalid key > > > Key: TINKERPOP-2000 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2000 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.3.3 >Reporter: Horacio Hoyos Rodriguez >Priority: Critical > > The MANIFEST.MF file for tinerpop-core contains an invalid key (line 8): > version: 3.3.3 > Some tools (like the Eclipse Bundle Recipes) check for the MANIFEST integrity > and this line causes an error. Perhaps this is the Specification-Version? > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[DISCUSS] Add Graph Engine Service to listing
I think Huawei's Graph Engine Service meets the requirements for the index listing: https://groups.google.com/d/msg/gremlin-users/TEJuwsCuQcE/yjbOlmz8CwAJ I think the listing would just be taken from their description: Huawei Graph Engine Service - a fully-managed, distributed, at-scale graph query and analysis service that provides a visualized interactive analytics platform Unless there are objections in the next 72 hours, I will go ahead an get this added. Thanks
Re: [DISCUSS] Review Process
Looks good. Robert Dale On Mon, Jul 16, 2018 at 3:35 PM Stephen Mallette wrote: > Updated dev docs (but didn't publish yet) - > > https://github.com/apache/tinkerpop/commit/e1d57d6e076efbc68bbdf0fe0c121054a9d5152f > > On Fri, Jul 13, 2018 at 10:52 AM Ted Wilmes wrote: > > > That looks good, thanks Stephen. > > > > --Ted > > > > On Thu, Jul 12, 2018 at 5:23 PM Stephen Mallette > > wrote: > > > > > I'm going to quickly summarize this thread so that hopefully by Monday > we > > > have a plan to follow. > > > > > > We seem to agree that in the future we will go with the following > review > > > -the-commit (RTC) process: > > > > > > 1. Each change to TinkerPop release branches requires 3 +1s from > > committers > > > and no -1s OR > > > 2. A single +1 from a committer and a 1 week review period for > objections > > > (i.e. "cool down period") at which point we will assume a lazy > consensus > > > 3. The single +1 may come from the committer who submitted the PR in > the > > > first place > > > 4. Committers are trusted with their changes but are expected to > request > > > reviews for complex changes as necessary and not rely strictly on lazy > > > consensus > > > 5. commit-the-review (CTR) procedures remain unchanged > > > > > > If there are no final comments, I will adjust our dev documentation > > > accordingly (and then merge a bunch of PRs!) > > > > > > Thanks for everyone's participation, > > > > > > Stephen > > > > > > On Wed, Jul 11, 2018 at 6:50 AM Stephen Mallette > > > > wrote: > > > > > > > oops - Pieter, i read your post last night then replied this morning > > > > thinking I remembered everything you wrote - you actually called for > > > > different email/jira lists as well.I guess that would be helpful > to > > > > some but not others. For me personally, that would be massively > > > burdensome > > > > tbh. > > > > > > > > On Wed, Jul 11, 2018 at 6:46 AM Stephen Mallette < > spmalle...@gmail.com > > > > > > > wrote: > > > > > > > >> Thanks for everyone's thoughts - some replies, first to Jason: > > > >> > > > >> > but I agree that nagging is not a great path forward. > > > >> > > > >> Robert Dale has already expressed his sadness that my nags are going > > > away > > > >> > > > >> > It'd be great to have these examples added to the maintainer > > > >> guidelines. > > > >> > > > >> i've said as much before in different places but it's not in the dev > > > >> docs. of course, depending on how this thread ends the dev docs will > > > need > > > >> some changes in this area all around so we'll see about adding such > > > things. > > > >> > > > >> > If the contribution is a major feature or significant change, > the > > > >> expectation is that the committer realizes this and holds it open > for > > 3 > > > >> votes before committing. > > > >> > > > >> So, here's my thinking on "major feature" - if the committer had > done > > > >> things properly the "major feature" would have already had major > > > >> visibility. There would have been some form of DISCUSS thread ahead > of > > > >> time, plus a JIRA ticket with more information. If it was a "major" > > > third > > > >> party submission, a committer would not +1 and walk away but suggest > > to > > > the > > > >> third-party that we need to bring this to the attention of dev in > some > > > way. > > > >> How about this, perhaps in the DISCUSS/JiRA anyone might call for a > > > "review > > > >> of 3" (reserving of course for a -1 veto) in which case the "cooling > > > >> period" wouldn't apply and we'd need the 3 +1s from committers. > > > >> > > > >> As for Pieter: > > > >> > > > >> > Perhaps for version 4 the project should be broken up > > > >> > > > >> Maybe, though I've come to to really like our giant uber project. > > Having > > > >> everything together has so many great benefits and somehow we've > > > managed to > > > >> keep the whole thing relatively easy to build and deploy. Breaking > up > > > the > > > >> project repositories however would not allow you to really hide from > > the > > > >> expansiveness we've grown in to. This dev list would still be the > > > location > > > >> for all discussion and we'd still likely have a single JIRA instance > > so > > > I > > > >> don't see that providing much relief if you're feeling that way > > > >> unfortunately. > > > >> > > > >> > > > >> > > > >> On Tue, Jul 10, 2018 at 4:19 PM pieter gmail < > pieter.mar...@gmail.com > > > > > > >> wrote: > > > >> > > > >>> Hi, > > > >>> > > > >>> I feel like the project has become a bit too big and dispersed. A > > large > > > >>> portion of the emails, jira or otherwise are irrelevant to my > > > >>> interest/time/work. > > > >>> > > > >>> Perhaps for version 4, TinkerPop could be broken up into more > focused > > > >>> projects with their own jira/email/process management. > > > >>> > > > >>> gremlin-language > > > >>> gremlin-server > > > >>> js-driver > > > >>> python-driver > > > >>> java-driver > > > >>> .net-driver > > > >>>
