DO NOT REPLY [Bug 47840] A broken worker name is written in the log file.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47840
--- Comment #2 from Rainer Jung 2009-09-18 19:35:24
PDT ---
I think your patch doesn't help. I analyzed the problem and came up with
another solution. Would you please try the below patch and see if it fixes the
problem for you:
Index: common/jk_lb_worker.c
===
--- common/jk_lb_worker.c (revision 810065)
+++ common/jk_lb_worker.c (working copy)
@@ -840,7 +840,11 @@
}
else if (*wr.domain && !uses_domain) {
candidate = find_best_bydomain(s, p, wr.domain, states, l);
-s->route = wr.domain;
+if (candidate >= 0) {
+s->route = wr.domain;
+} else {
+s->route = NULL;
+}
}
if (candidate >= 0) {
wr = p->lb_workers[candidate];
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r816833 - /tomcat/trunk/KEYS
Author: markt Date: Sat Sep 19 00:32:38 2009 New Revision: 816833 URL: http://svn.apache.org/viewvc?rev=816833&view=rev Log: Add my new key Modified: tomcat/trunk/KEYS Modified: tomcat/trunk/KEYS URL: http://svn.apache.org/viewvc/tomcat/trunk/KEYS?rev=816833&r1=816832&r2=816833&view=diff == --- tomcat/trunk/KEYS (original) +++ tomcat/trunk/KEYS Sat Sep 19 00:32:38 2009 @@ -216,14 +216,20 @@ =O17Z -END PGP PUBLIC KEY BLOCK- -pub 1024D/33C60243 2004-09-12 Mark E D Thomas - Key fingerprint = DCFD 35E0 BF8C A734 4752 DE8B 6FB2 1E89 33C6 0243 -sig 33C60243 2004-09-12 Mark E D Thomas -sub 2048g/0BECE548 2004-09-12 -sig 33C60243 2004-09-12 Mark E D Thomas +pub 1024D/33C60243 2004-09-12 + Key fingerprint = DCFD 35E0 BF8C A734 4752 DE8B 6FB2 1E89 33C6 0243 +uid Mark E D Thomas +uid Mark E D Thomas +uid Mark E D Thomas +sub 2048g/0BECE548 2004-09-12 + +pub 4096R/2F6059E7 2009-09-18 + Key fingerprint = A9C5 DF4D 22E9 9998 D987 5A51 10C0 1C5A 2F60 59E7 +uid Mark E D Thomas +sub 4096R/5E763BEC 2009-09-18 -BEGIN PGP PUBLIC KEY BLOCK- -Version: GnuPG v1.2.1 (MingW32) +Version: GnuPG v1.4.9 (MingW32) mQGiBEFEjegRBADocGttfROvtLGrTOW3xRqZHmFWybmEaI6jmnRdN/1gGXmb3wQL rHsS3fLFIIOYLPph0Kov9q4qNq36LekShIvjMBDFoj2/wRxaUtFq81asaRZg8Mcw @@ -234,23 +240,144 @@ 7HOIBADVezl1/vny5YzdoqsDx1ByXMLi7CuMexQPllhRbdN+an+ZiJ5YP8J9rPdl NCELsCCcDKLGLjlp43XfMxsgYAPEZNG2ObjKTarhk3uGYN3aJrx7s+G+c2bu8o2n SyAFQ1iDsjS87PgSPCONA2/36ZShmv1OjLWz5Vo7hGSPcW4ZdLQiTWFyayBFIEQg -VGhvbWFzIDxtYXJrdEBhcGFjaGUub3JnPohdBBARAgAdBQJBRI3oBwsJCAcDAgoC -GQEFGwMFHgEACgkQb7IeiTPGAkOkvgCg0AcTAfe8m2ZSWkbsoqplLDsM -0+oAoNl4EjXT+T2j2z8jdUYPaA8LztJguQINBEFEjekQCAD2Qle3CH8IF3Kiutap -QvMF6PlTETlPtvFuuUs4INoBp1ajFOmPQFXz0AfGy0OplK33TGSGSfgMg71l6RfU -odNQ+PVZX9x2Uk89PY3bzpnhV5JZzf24rnRPxfx2vIPFRzBhznzJZv8V+bv9kV7H -AarTW56NoKVyOtQa8L9GAFgr5fSI/VhOSdvNILSd5JEHNmszbDgNRR0PfIizHHxb -LY7288kjwEPwpVsYjY67VYy4XTjTNP18F1dDox0YbN4zISy1Kv884bEpQBgRjXyE -pwpy1obEAxnIByl6ypUM2Zafq9AKUJsCRtMIPWakXUGfnHy9iUsiGSa6q6Jew1Xp -Mgs7AAICCACuLSE3vBSOeTMM04ezuPt4zZUp0PFQGQL3bzuZp24f18S8P3BemGAk -2V3HZYJmzmNgd4L0vIC9xyFduICFgbiV9uyzKPwHvCgQwaupFvFLGn7Q9LJ0nlaw -GN7Km13vJTG3rrT/UMKwLTk+IMEYQwUgBht6HTnBaM+UqVx/eB4PHobimt5Redz9 -CnT4DrlA0M6Oh3ePWBD69Nnhwo2AN42dX/W2KcnDe2iRNu/JEbOYsssj0e3VmHwE -mwa064TpQpw1fClyW7sf4aWOcQvcT12R0hNvRhTR1TV0pzjIMkbRPkRezhIY55AT -TIfcaZrw+Yubmmw/pp/1wIDRzHexOq9riEwEGBECAAwFAkFEjekFGwwACgkQ -b7IeiTPGAkN8ogCg4tHmgylXw4Y3ujF+J4cf2ollGa0AnRkyX8X+u/NrMi2g2xhE -vpsTbAGW -=r1gT +VGhvbWFzIDxtYXJrdEBhcGFjaGUub3JnPohGBBARAgAGBQJJEoLqAAoJEJsf2p88 +BiIx2ssAnjsjHqeIOdOQYuNjDxVIqfAQN8vaAJwLv/HLCQwTZdxOFqwt/Pf/Ae5L +6IhGBBARAgAGBQJJE0bmAAoJEJA4TZo1x+lCCH0Anj1yuBFfP+bNK+51xQhqFsSN +cB1vAKCzK5HbowxZd2MjzMU31USprksZTIhGBBARAgAGBQJJGG7wAAoJELDgGPyz +tNmL35kAniTaqQ+uSzJgX1o7Bp8BAFYoQ+o0AKCm4eD3gf06AK20FZwSck8ibIQ2 +3ohGBBARAgAGBQJJGekxAAoJEC0hq2VlRht59xoAnRcmnR1vJZsRCGcSuxKv+0nA +FrKsAJ9R7Gdc25unU6zF/UwUs7LdWTIFN4hGBBARAgAGBQJJGjZhAAoJEFuWgBDg +T5qJQLAAniDrgK53AhSBmZRGLU6HaI4jPO6jAJ4gWQWhnovMkAKqLRtc18Z1Q60N +vYhGBBARAgAGBQJJHtOZAAoJEFMmz0Afnhe7pzMAnAu/W6rzeOXe7SoMtbPF4mg/ +OycXAJoDQfqJpGoUFEjsoePDY0WOd5hI9YhGBBARAgAGBQJJVjbUAAoJELlbvT+k +PESS4lIAniLTQ0XnArkk0TCIBeSWWRL2SvWjAJ4+9XuK0Mg5Pk2454JbWxXqv0cW +i4hGBBARAgAGBQJJXgPpAAoJEA9FCiZiEL/ADcsAnAns0QDk3Iwb0X1GbhRfRHFf +GeV2AJ9+8rA4UfTtUnFMZZCEdyohyunM5YhKBBARAgAKBQJDme2qAwUDeAAKCRAM +PU85FKClKanOAKCIBOdqECQwSoSS6Bsw/j0rhhhOHQCfTCp+IgPx+uJ9YhhgKDyr +U3psooeIagQQEQIAKgIZAQUbAwUeAQUCSrQLBwULCQgHAwUVCgkICwUW +AgMBAAIXgAAKCRBvsh6JM8YCQ/3tAKDTsnK90MamPgLtqRxEDmCMu6mX7ACg5rF4 +05TH5JA7h23YfJCsC9ZTeoCIqQQQEQIAaQUCSVsZ6iAcU2FuZGVyIFRlbW1lIDxz +YW5kZXJAdGVtbWUubmV0PiIcU2FuZGVyIFRlbW1lIDxzY3RlbW1lQGFwYWNoZS5v +cmc+HhxTYW5kZXIgVGVtbWUgPHNhbmRlckBtYWMuY29tPgAKCRCyvrxAFSkkr91K +AJ93ymf/0iywAVIno5/T8/QUJSKVBgCfe4UPcLtISs3GI8mpYyjCXq35OEmJARsE +EAECAAYFAkkSbKQACgkQW+YxwZmV0krHkgf407SOW6qaU4nqHUJ5kFPWgcLcVVo2 +w4gQ1u6s+HzEXNTmvKZrOIzKJMnttyM2RDklmCwaI/lkJApyMbQoMW5UksTGVgnF +WHKyiYx03SnVNPH+QID9IhPzAvp2rLH9IQUtfu1vxvfsQQEZGNmKXUgaG0OduXTY +J+EkhaIFotOa6pLBcUuqjmbSI840IjnVV5a5wLyonDGFFJ7FbbHDecOcLzI9jmSd +mLQlgXD8XwYe8XqNknc6C4uOniDc+iuDRqzGFAMs7f8YK6C1fh3mWCjuNNQ64wvm +JqvxWinFKh6BpTBecqtXwta1Vzfa3tGKSrWCPfODAUHqXni+hhdEqMftiEYEEBEC +AAYFAkoVTuwACgkQarqkr5Czi1hBvACeLUdijz+jB9K9XGL1O5ZhPv8bEWwAoIIw +5uol5zSFoHcK1WHJI5D9CUhgtCdNYXJrIEUgRCBUaG9tYXMgPG1lZC50aG9tYXNA +dmlyZ2luLm5ldD6IYQQTEQIAIQIbAwIeAQIXgAUCSrQLFgULCQgHAwUVCgkICwUW +AgMBAAAKCRBvsh6JM8YCQ/rAAKCcgX1TjaeqTP62LIxml8Z1hL0cSQCeOZiYPXub +vNxwTWh01BOrh5oztDqIRgQQEQIABgUCSRKC6gAKCRCbH9qfPAYiMTeJAKCfTgLW +8OR8o1SY8DHu5/Lw/QyffQCfefq9NCLX99dWBqQqQhX8Ov/vt1yIRgQQEQIABgUC +SRNG5gAKCRCQOE2aNcfpQsvGAKDh7MWTZaEaEe9zBbiHiUQOtZYsSQCgqdqu199/ +TDjuXF+frwmzaZqOB3qIRgQQEQIABgUCSRnpMQAKCRAtIatlZUYbeZNCAJ9e6ogA +O4ZpKrEQHuuJnpPnDYT5fgCaAgyY2X29cnP+r79XpqngCGqKR6iIRgQQEQIAB
svn commit: r816698 - /tomcat/native/trunk/native/src/sslnetwork.c
Author: jfclere
Date: Fri Sep 18 16:15:33 2009
New Revision: 816698
URL: http://svn.apache.org/viewvc?rev=816698&view=rev
Log:
While testing with FF and a bunch of client certificates the SSL_do_handshake()
failed and need to be retrying until the certificate is choosen in the browser.
Modified:
tomcat/native/trunk/native/src/sslnetwork.c
Modified: tomcat/native/trunk/native/src/sslnetwork.c
URL:
http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslnetwork.c?rev=816698&r1=816697&r2=816698&view=diff
==
--- tomcat/native/trunk/native/src/sslnetwork.c (original)
+++ tomcat/native/trunk/native/src/sslnetwork.c Fri Sep 18 16:15:33 2009
@@ -563,6 +563,7 @@
tcn_socket_t *s = J2P(sock, tcn_socket_t *);
tcn_ssl_conn_t *con;
int retVal;
+int ecode = SSL_ERROR_WANT_READ;
UNREFERENCED_STDARGS;
TCN_ASSERT(sock != 0);
@@ -582,11 +583,30 @@
if (retVal <= 0)
return APR_EGENERAL;
+if (SSL_get_state(con->ssl) != SSL_ST_OK) {
+return APR_EGENERAL;
+}
con->ssl->state = SSL_ST_ACCEPT;
-retVal = SSL_do_handshake(con->ssl);
-if (retVal <= 0)
+ecode = SSL_ERROR_WANT_READ;
+while (ecode == SSL_ERROR_WANT_READ) {
+retVal = SSL_do_handshake(con->ssl);
+if (retVal <= 0) {
+ecode = SSL_get_error(con->ssl, retVal);
+if (ecode == SSL_ERROR_WANT_READ) {
+if (wait_for_io_or_timeout(con, ecode) != APR_SUCCESS)
+return APR_EGENERAL; /* Can't wait */
+continue; /* It should be ok now */
+}
+else
+return APR_EGENERAL;
+} else
+break;
+}
+
+if (SSL_get_state(con->ssl) != SSL_ST_OK) {
return APR_EGENERAL;
+}
return APR_SUCCESS;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r816696 - /tomcat/native/branches/1.1.x/native/src/sslnetwork.c
Author: jfclere
Date: Fri Sep 18 16:13:30 2009
New Revision: 816696
URL: http://svn.apache.org/viewvc?rev=816696&view=rev
Log:
While testing with FF and a bunch of client certificates the SSL_do_handshake()
failed and need to be retrying until the certificate is choosen in the browser.
Modified:
tomcat/native/branches/1.1.x/native/src/sslnetwork.c
Modified: tomcat/native/branches/1.1.x/native/src/sslnetwork.c
URL:
http://svn.apache.org/viewvc/tomcat/native/branches/1.1.x/native/src/sslnetwork.c?rev=816696&r1=816695&r2=816696&view=diff
==
--- tomcat/native/branches/1.1.x/native/src/sslnetwork.c (original)
+++ tomcat/native/branches/1.1.x/native/src/sslnetwork.c Fri Sep 18 16:13:30
2009
@@ -563,6 +563,7 @@
tcn_socket_t *s = J2P(sock, tcn_socket_t *);
tcn_ssl_conn_t *con;
int retVal;
+int ecode = SSL_ERROR_WANT_READ;
UNREFERENCED_STDARGS;
TCN_ASSERT(sock != 0);
@@ -582,11 +583,30 @@
if (retVal <= 0)
return APR_EGENERAL;
+if (SSL_get_state(con->ssl) != SSL_ST_OK) {
+return APR_EGENERAL;
+}
con->ssl->state = SSL_ST_ACCEPT;
-retVal = SSL_do_handshake(con->ssl);
-if (retVal <= 0)
+ecode = SSL_ERROR_WANT_READ;
+while (ecode == SSL_ERROR_WANT_READ) {
+retVal = SSL_do_handshake(con->ssl);
+if (retVal <= 0) {
+ecode = SSL_get_error(con->ssl, retVal);
+if (ecode == SSL_ERROR_WANT_READ) {
+if (wait_for_io_or_timeout(con, ecode) != APR_SUCCESS)
+return APR_EGENERAL; /* Can't wait */
+continue; /* It should be ok now */
+}
+else
+return APR_EGENERAL;
+} else
+break;
+}
+
+if (SSL_get_state(con->ssl) != SSL_ST_OK) {
return APR_EGENERAL;
+}
return APR_SUCCESS;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47867] IIS connector compiled with VS2008 crashes, when worker contains unsupported properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=47867 Rainer Jung changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Rainer Jung 2009-09-18 05:17:21 PDT --- Thanks for the analysis and patch. It has been applied to 1.2.x as revision 816596 and will be part of 1.2.29. Sorry for the inconvenience. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r816596 - in /tomcat/jk/trunk: native/common/jk_util.c xdocs/miscellaneous/changelog.xml
Author: rjung
Date: Fri Sep 18 12:16:19 2009
New Revision: 816596
URL: http://svn.apache.org/viewvc?rev=816596&view=rev
Log:
Fix BZ47867: IIS crashes during startup, when compiled with VS2008
and workers.properties contains unsupported properties.
Patch provided by Indrek Juhani
Modified:
tomcat/jk/trunk/native/common/jk_util.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Modified: tomcat/jk/trunk/native/common/jk_util.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_util.c?rev=816596&r1=816595&r2=816596&view=diff
==
--- tomcat/jk/trunk/native/common/jk_util.c (original)
+++ tomcat/jk/trunk/native/common/jk_util.c Fri Sep 18 12:16:19 2009
@@ -320,7 +320,8 @@
RETRIES_OF_WORKER,
STATUS_FAIL_OF_WORKER,
LIST_PROPERTY_NAME,
-MAINTAIN_PROPERTY_NAME
+MAINTAIN_PROPERTY_NAME,
+NULL
};
static const char *jk_level_verbs[] = {
Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=816596&r1=816595&r2=816596&view=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Fri Sep 18 12:16:19 2009
@@ -43,6 +43,12 @@
+
+47867: IIS: crash during startup, when compiled with VS2008
+and workers.properties contains unsupported properties.
+Patch provided by Indrek Juhani (rjung)
+
+
47628: IIS: Fix deadlock when restarting the Application
Pool
caused by not releasing the critical section lock.
Patch provided by Bret Prucha. (mturk)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Testing new website sync process
Henri Yandell wrote: > Did this go through Mark? No. It fell off my radar. I'll try and get back to it. I'll let floks know in advance before I change anything. > Where do I commit the Taglibs site? At the minute, the ideal would be as part of: http://svn.apache.org/repos/asf/tomcat/site/trunk/ I don't know how well that would fit in with how the tag libs site is generated currently. If that won't work, do whatever you think is reasonable. We can always refine/adjust later. Mark > > Hen > > On Thu, Sep 3, 2009 at 3:59 AM, Mark Thomas wrote: >> Folks, >> >> As part of the response to the recent compromise of ASF servers [1] the >> infrastructure team are introducing a new way to sync web sites from svn >> and are looking for PMS to volunteer to test the new process. >> >> I'd like to volunteer the Tomcat website. Any objections? I'm happy to >> take on fixing any teething problems. >> >> The advantage is that commits to svn will be reflected on the live site >> within a few seconds. >> >> If we want we can also have a staging site tomcat.staging.a.o where we >> could preview stuff [2] >> >> My own view is that a staging site isn't necessary. Our site is simple. >> We can test locally before committing and with commits affecting the >> live site within a few seconds, fixing any snafus should be easy. >> >> Cheers, >> >> Mark >> >> [1] http://blogs.apache.org/infra/ >> >> [2] This require a separate svn location to sync from. Something like: >> http://svn.apache.org/repos/asf/tomcat/site/branches/live >> would sync to >> http://tomcat.apache.org/ >> and >> http://svn.apache.org/repos/asf/tomcat/site/trunk >> would sync to >> http://tomcat.staging.apache.org/ >> and we would have to svn merge changes from trunk to live. >> >> >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47867] New: IIS connector compiled with VS2008 crashes, when worker contains unsupported properties
https://issues.apache.org/bugzilla/show_bug.cgi?id=47867 Summary: IIS connector compiled with VS2008 crashes, when worker contains unsupported properties Product: Tomcat Connectors Version: 1.2.26 Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: minor Priority: P2 Component: Common AssignedTo: dev@tomcat.apache.org ReportedBy: indrek.juh...@voipster.com Created an attachment (id=24289) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24289) Patch terminates native/common/jk_util.c:supported_properties array with NULL The 1.2.26 was re-compiled with VS2008. The workers file contained accidentally a worker property introduced by 1.2.27. The IIS connector crashes during initialization with memory access error. The problem is, that native/common/jk_util.c:supported_properties array does not end with NULL. In case of wrong property, the pointer will go out of bounds in native/common/jk_util.c:jk_is_valid_property function. The officail binary release DLL of 1.2.26 from Apache will print: [error] jk_map.c (403): The attribute 'worker.gw1.ping_mode' is not supported - please check the documentation for the supported attributes. and does not cause crash. This could be because VC++ 6.0 (which is used for official binary builds as I understand) uses different memory alignment/layout or something else. Anyway, I think it is safer not to permit run pointer out of array and explicitly mark the end of list with NULL. Proposed fix is attached as patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47866] New: NullPointerException in embedded tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=47866
Summary: NullPointerException in embedded tomcat
Product: Tomcat 7
Version: unspecified
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P3
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: david_s...@hotmail.com
It seems that the WebappClassLoader was stopped?
{noformat}
Caused by: java.lang.NullPointerException
at
org.apache.catalina.loader.WebappClassLoader.findResources(WebappClassLoader.java:994)
at java.lang.ClassLoader.getResources(ClassLoader.java:1016)
{noformat}
All I did was launch a server add a context and then ask it to load a resource
from its classpath. It's a bit more complicated than that, so I'll try and
narrow it down if needed.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
