date:20110310

[Tomcat Wiki] Update of FindPage by David

2011-03-10 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The FindPage page has been changed by David.
http://wiki.apache.org/tomcat/FindPage?action=diffrev1=4rev2=5

--

   * WordIndex: a list of all words that are part of page title (thus, a list 
of the concepts in a wiki)
   * WikiSandBox: feel free to change this page and experiment with editing
  
- Here's a title search.  Try something like ''manager'':
+ Here's a title search.  Try something like ''Web host'':
  
   TitleSearch
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Tomcat Wiki] Update of webhost by David

2011-03-10 Thread Apache Wiki

Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The webhost page has been changed by David.
The comment on this change is: Best US and UK webhost.
http://wiki.apache.org/tomcat/webhost

--

New page:
= Infrenion Networks =
 * US Shared Web Hosting
 * UK Shared Web Hosting
 * US Reseller Web Hosting
 * UK Reseller Web Hosting
 * US VPS Servers
 * UK VPS Servers
 * US Dedicated Servers
 * UK Dedicated Servers
 * SSL Certificates

Sign up anually and get free hosting for 2 months http://www.infrenion.com/

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

FindPage reverted to revision 4 on Tomcat Wiki

2011-03-10 Thread Apache Wiki

Dear wiki user,

You have subscribed to a wiki page Tomcat Wiki for change notification.

The page FindPage has been reverted to revision 4 by KonstantinKolinko.
The comment on this change is: Undo spam.
http://wiki.apache.org/tomcat/FindPage?action=diffrev1=5rev2=6

--

   * WordIndex: a list of all words that are part of page title (thus, a list 
of the concepts in a wiki)
   * WikiSandBox: feel free to change this page and experiment with editing
  
- Here's a title search.  Try something like ''Web host'':
+ Here's a title search.  Try something like ''manager'':
  
   TitleSearch
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Page webhost deleted from Tomcat Wiki

2011-03-10 Thread Apache Wiki

Dear wiki user,

You have subscribed to a wiki page Tomcat Wiki for change notification.

The page webhost has been deleted by KonstantinKolinko.
The comment on this change is: Remove spam.
http://wiki.apache.org/tomcat/webhost

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080152 - /tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties

2011-03-10 Thread kfujino

Author: kfujino
Date: Thu Mar 10 08:31:51 2011
New Revision: 1080152

URL: http://svn.apache.org/viewvc?rev=1080152view=rev
Log:
correct message key

Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=1080152r1=1080151r2=1080152view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Thu Mar 
10 08:31:51 2011
@@ -45,7 +45,7 @@ applicationFilterConfig.jmxRegisterFail=
 applicationFilterConfig.jmxUnregister=JMX de-registration complete for filter 
of type [{0}] and name [{1}]
 applicationFilterConfig.jmxUnregisterFail=JMX de-registration failed for 
filter of type [{0}] and name [{1}]
 applicationFilterRegistration.nullInitParam=Unable to set initialisation 
parameter for filter due to null name and/or value. Name [{0}], Value [{1}]
-applicationFilterRegistration.nullInitParam=Unable to set initialisation 
parameters for filter due to null name and/or value. Name [{0}], Value [{1}]
+applicationFilterRegistration.nullInitParams=Unable to set initialisation 
parameters for filter due to null name and/or value. Name [{0}], Value [{1}]
 applicationRequest.badParent=Cannot locate parent Request implementation
 applicationRequest.badRequest=Request is not a 
javax.servlet.ServletRequestWrapper
 applicationResponse.badParent=Cannot locate parent Response implementation



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50700] Context parameters are being overridden with parameters from the web application deployment descriptor

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50700

n.beekman n.beek...@o3spaces.com changed:

   What|Removed |Added

 CC||n.beek...@o3spaces.com

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080169 - /tomcat/trunk/webapps/docs/changelog.xml

2011-03-10 Thread kkolinko

Author: kkolinko
Date: Thu Mar 10 10:07:43 2011
New Revision: 1080169

URL: http://svn.apache.org/viewvc?rev=1080169view=rev
Log:
Correct a typo

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1080169r1=1080168r2=1080169view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Mar 10 10:07:43 2011
@@ -93,7 +93,7 @@
   fix
 Fix issues that prevented asynchronous servlets from working when used
 with the HTTP APR connector on platforms that support TCP_DEFER_ACCEPT.
-(martk)
+(markt)
   /fix
 /changelog
   /subsection



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1080040 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

2011-03-10 Thread Konstantin Kolinko

Something is wrong with this commit:

the new SocketWithOptionsProcessor#status field is always null.

It is assigned by the constructor and is never changed afterwards.
The constructor is called as new SocketWithOptionsProcessor(wrapper,
null), always passing null for the value.


 +(martk)
I already corrected the above typo.

Best regards,
Konstantin Kolinko

2011/3/10  ma...@apache.org:
 Author: markt
 Date: Wed Mar  9 22:36:55 2011
 New Revision: 1080040

 URL: http://svn.apache.org/viewvc?rev=1080040view=rev
 Log:
 Fix Async with APR and TCP_DEFER_ACCEPT

 Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
    tomcat/trunk/webapps/docs/changelog.xml

 Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
 URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1080040r1=1080039r2=1080040view=diff
 ==
 --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
 +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Wed Mar  9 
 22:36:55 2011
 @@ -760,7 +760,8 @@ public class AprEndpoint extends Abstrac
             if (running) {
                 SocketWrapperLong wrapper =
                     new SocketWrapperLong(Long.valueOf(socket));
 -                getExecutor().execute(new 
 SocketWithOptionsProcessor(wrapper));
 +                getExecutor().execute(
 +                        new SocketWithOptionsProcessor(wrapper, null));
             }
         } catch (RejectedExecutionException x) {
             log.warn(Socket processing request was rejected for:+socket,x);
 @@ -1641,9 +1642,13 @@ public class AprEndpoint extends Abstrac
     protected class SocketWithOptionsProcessor implements Runnable {

         protected SocketWrapperLong socket = null;
 +        protected SocketStatus status = null;
 +

 -        public SocketWithOptionsProcessor(SocketWrapperLong socket) {
 +        public SocketWithOptionsProcessor(SocketWrapperLong socket,
 +                SocketStatus status) {
             this.socket = socket;
 +            this.status = status;
         }

         @Override
 @@ -1660,17 +1665,30 @@ public class AprEndpoint extends Abstrac
                     }
                 } else {
                     // Process the request from this socket
 -                    if (!setSocketOptions(socket.getSocket().longValue())
 -                            || handler.process(socket) == 
 Handler.SocketState.CLOSED) {
 +                    if (!setSocketOptions(socket.getSocket().longValue())) {
                         // Close socket and pool
                         destroySocket(socket.getSocket().longValue());
                         socket = null;
                     }
 +                    // Process the request from this socket
 +                    Handler.SocketState state = 
 (status==null)?handler.process(socket):handler.asyncDispatch(socket, status);
 +                    if (state == Handler.SocketState.CLOSED) {
 +                        // Close socket and pool
 +                        destroySocket(socket.getSocket().longValue());
 +                        socket = null;
 +                    } else if (state == Handler.SocketState.LONG) {
 +                        socket.access();
 +                        if (socket.async) {
 +                            waitingRequests.add(socket);
 +                        }
 +                    } else if (state == Handler.SocketState.ASYNC_END) {
 +                        socket.access();
 +                        SocketProcessor proc = new SocketProcessor(socket, 
 SocketStatus.OPEN);
 +                        getExecutor().execute(proc);
 +                    }
                 }
             }
 -
         }
 -
     }



 Modified: tomcat/trunk/webapps/docs/changelog.xml
 URL: 
 http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1080040r1=1080039r2=1080040view=diff
 ==
 --- tomcat/trunk/webapps/docs/changelog.xml (original)
 +++ tomcat/trunk/webapps/docs/changelog.xml Wed Mar  9 22:36:55 2011
 @@ -90,6 +90,11 @@
         bug48208/bug: Allow the configuration of a custom trust manager 
 for
         use in CLIENT-CERT authentication. (markt)
       /add
 +      fix
 +        Fix issues that prevented asynchronous servlets from working when 
 used
 +        with the HTTP APR connector on platforms that support 
 TCP_DEFER_ACCEPT.
 +        (martk)
 +      /fix
     /changelog
   /subsection
   subsection name=Jasper



 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For

Re: svn commit: r1080040 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

2011-03-10 Thread Mark Thomas

On 10/03/2011 10:27, Konstantin Kolinko wrote:
 Something is wrong with this commit:
 
 the new SocketWithOptionsProcessor#status field is always null.
 
 It is assigned by the constructor and is never changed afterwards.
 The constructor is called as new SocketWithOptionsProcessor(wrapper,
 null), always passing null for the value.

That is me copying and pasting from SocketProcessor. Since the status is
always null, the code can be simplified. Once the status is non-null it
will switch to using the SocketProcessor. I'll make the changes shortly.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080173 - /tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 10:34:09 2011
New Revision: 1080173

URL: http://svn.apache.org/viewvc?rev=1080173view=rev
Log:
status is always null, so simplify

Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1080173r1=1080172r2=1080173view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Thu Mar 10 
10:34:09 2011
@@ -760,8 +760,7 @@ public class AprEndpoint extends Abstrac
 if (running) {
 SocketWrapperLong wrapper =
 new SocketWrapperLong(Long.valueOf(socket));
-getExecutor().execute(
-new SocketWithOptionsProcessor(wrapper, null));
+getExecutor().execute(new SocketWithOptionsProcessor(wrapper));
 }
 } catch (RejectedExecutionException x) {
 log.warn(Socket processing request was rejected for:+socket,x);
@@ -1642,13 +1641,10 @@ public class AprEndpoint extends Abstrac
 protected class SocketWithOptionsProcessor implements Runnable {
 
 protected SocketWrapperLong socket = null;
-protected SocketStatus status = null;
 
 
-public SocketWithOptionsProcessor(SocketWrapperLong socket,
-SocketStatus status) {
+public SocketWithOptionsProcessor(SocketWrapperLong socket) {
 this.socket = socket;
-this.status = status;
 }
 
 @Override
@@ -1671,7 +1667,7 @@ public class AprEndpoint extends Abstrac
 socket = null;
 }
 // Process the request from this socket
-Handler.SocketState state = 
(status==null)?handler.process(socket):handler.asyncDispatch(socket, status);
+Handler.SocketState state = handler.process(socket);
 if (state == Handler.SocketState.CLOSED) {
 // Close socket and pool
 destroySocket(socket.getSocket().longValue());
@@ -1683,7 +1679,8 @@ public class AprEndpoint extends Abstrac
 }
 } else if (state == Handler.SocketState.ASYNC_END) {
 socket.access();
-SocketProcessor proc = new SocketProcessor(socket, 
SocketStatus.OPEN);
+SocketProcessor proc =
+new SocketProcessor(socket, SocketStatus.OPEN);
 getExecutor().execute(proc);
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50904] cannot configure manager as per documentation

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50904

--- Comment #2 from Konstantin Kolinko knst.koli...@gmail.com 2011-03-10 
05:36:10 EST ---
(In reply to comment #0)
 If I try to open http://localhost:8080/manager/list, I get a 403 Access Denied
 error.  

The above URL is not a part of the GUI, but is used by tools. To access it the
manager-script role is needed. (And you will lose the CSRF protection).

The human-friendly interface starts with
http://localhost:8080/manager/html

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1080040 - in /tomcat/trunk: java/org/apache/tomcat/util/net/AprEndpoint.java webapps/docs/changelog.xml

2011-03-10 Thread jean-frederic clere


On 03/09/2011 11:38 PM, Mark Thomas wrote:

On 09/03/2011 22:36, ma...@apache.org wrote:

Author: markt
Date: Wed Mar  9 22:36:55 2011
New Revision: 1080040

URL: http://svn.apache.org/viewvc?rev=1080040view=rev
Log:
Fix Async with APR and TCP_DEFER_ACCEPT


Who ever it was that reported async unit test failures (Rainer?) that I
blamed on the APR/native code, I apologise. It was indeed all my fault.


Ok I will go for tc-native release now.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49038] Crash in tcnative

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=49038

--- Comment #7 from jfclere jfcl...@gmail.com 2011-03-10 06:00:53 EST ---
Probably something like:
+++
Index: java/org/apache/coyote/http11/Http11AprProcessor.java
===
--- java/org/apache/coyote/http11/Http11AprProcessor.java   (revision 1601)
+++ java/org/apache/coyote/http11/Http11AprProcessor.java   (working copy)
@@ -1027,6 +1027,13 @@
  */
 public void action(ActionCode actionCode, Object param) {

+if (!endpoint.isRunning()) {
+if (log.isDebugEnabled()) {
+log.debug(action  + actionCode.getCode() +
+   attempted on closed endpoint);
+}
+socket = 0;
+}
 if (actionCode == ActionCode.ACTION_COMMIT) {
 // Commit current response

+++
Could prevent the problem. The real issue is that pause() / stop() doesn't test
that there are running requests

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50883] StackOverflowError

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50883

Ashish dashashishku...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50883] StackOverflowError

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50883

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||INVALID

--- Comment #5 from Mark Thomas ma...@apache.org 2011-03-10 06:06:22 EST ---
The users list is the place to seek help.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 48655] Active multipart downloads prevent tomcat shutdown.

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=48655

jfclere jfcl...@gmail.com changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from jfclere jfcl...@gmail.com 2011-03-10 06:07:24 EST ---
Which tool are you using?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 49795] Crash in Socket.destroy

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=49795

jfclere jfcl...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #6 from jfclere jfcl...@gmail.com 2011-03-10 06:09:11 EST ---
Fix in TC6 code.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080182 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_11: ./ build.properties.default modules/

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 11:10:19 2011
New Revision: 1080182

URL: http://svn.apache.org/viewvc?rev=1080182view=rev
Log:
Tagging 7.0.11

Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_11/   (props changed)
  - copied from r1080180, tomcat/trunk/
Removed:
tomcat/tc7.0.x/tags/TOMCAT_7_0_11/modules/
Modified:
tomcat/tc7.0.x/tags/TOMCAT_7_0_11/build.properties.default

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_11/
--
--- svn:ignore (added)
+++ svn:ignore Thu Mar 10 11:10:19 2011
@@ -0,0 +1,5 @@
+.*
+output
+build.properties
+work
+logs

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_11/
--
svn:mergeinfo = /tomcat/tc6.0.x/trunk:742915

Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_11/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/build.properties.default?rev=1080182r1=1080180r2=1080182view=diff
==
--- tomcat/tc7.0.x/tags/TOMCAT_7_0_11/build.properties.default (original)
+++ tomcat/tc7.0.x/tags/TOMCAT_7_0_11/build.properties.default Thu Mar 10 
11:10:19 2011
@@ -29,7 +29,7 @@ version.major=7
 version.minor=0
 version.build=11
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Build control flags -
 # Note enabling validation uses Checkstyle which is LGPL licensed



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080183 - /tomcat/trunk/build.properties.default

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 11:11:38 2011
New Revision: 1080183

URL: http://svn.apache.org/viewvc?rev=1080183view=rev
Log:
Ready for next release

Modified:
tomcat/trunk/build.properties.default

Modified: tomcat/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1080183r1=1080182r2=1080183view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Thu Mar 10 11:11:38 2011
@@ -27,7 +27,7 @@
 # - Version Control Flags -
 version.major=7
 version.minor=0
-version.build=11
+version.build=12
 version.patch=0
 version.suffix=-dev
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 7.0.11

2011-03-10 Thread Mark Thomas

The proposed Apache Tomcat 7.0.11 release is now available for voting.

It can be obtained from:
http://people.apache.org/~markt/dev/tomcat-7/v7.0.11/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/

The proposed 7.0.11 release is:

[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 7.0.11 Alpha
[ ] Beta   - go ahead and release as 7.0.11 Beta
[ ] Stable - go ahead and release as 7.0.11 Stable

Cheers,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: STATUS.txt reviews

2011-03-10 Thread Konstantin Kolinko

2011/3/3 Mark Thomas ma...@apache.org:
 On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote:
 I wanted to throw out an idea of an alternative or complementary way to
 handle our STATUS.txt files, and this solution can apply to our CTR
 branches as well.
 The solution would be http://www.reviewboard.org/
 If there is an interest, I can spend some time configuring an instance
 for one of our branches and we can give it a test run and see if we like
 it.

 Any takers?

 If you go down that route, use the reviewboard instance provided by ASF
 infra.

 I am currently neutral on this. I can see the benefits of reviewboard
 but I like that by keeping things simple I can easily work off-line.


There is a problem with out trunk/tc7 that there are patches that are
work-in-progress or are hard to apply and would benefit from review.

The current approach is using Bugzilla, but
1) there is no such list of ready-for-review items, like the STATUS
file, and they may fell off the radar
2) it is hard to review them there, because you will need separate
step to download the patch, and then comment in the text field or
whatever

If reviewboard can solve the above, it would be fine.
From descriptions it looks that it is suited for pre-commit reviews. I
have no experience with it, though.

Thus I suggest to try it for our trunk.

For the RTC branches though I think it is not a replacement for the
STATUS. Maybe with more experience I will change my mind, but as of
now the STATUS is more traceable and formal.  I do not mind about
links to reviewboard being mentioned in STATUS, like we mention the
patches on people or message threads.


The links to ASF reviewboard:
https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
https://reviews.apache.org/

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50854] Additional catalina.policy entries for when Security Manager enabled, for session display functionality

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50854

--- Comment #2 from Mark Thomas ma...@apache.org 2011-03-10 07:16:26 EST ---
Created an attachment (id=26758)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26758)
Patch for tc6.0.x

Issue 1 can not occur in 6.0.x - the relevant changes were never pack-ported
from 7.0.x

Patch that covers issue 2 is attached and has been proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080197 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 12:17:28 2011
New Revision: 1080197

URL: http://svn.apache.org/viewvc?rev=1080197view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1080197r1=1080196r2=1080197view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 10 12:17:28 2011
@@ -158,3 +158,9 @@ PATCHES PROPOSED TO BACKPORT:
   Based on a patch by Luciana Moreira.
   +1: markt
   -1:
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50854
+  Allow shared manager app when running under a security manager
+  https://issues.apache.org/bugzilla/attachment.cgi?id=26758
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat7 Missing SVN EOL-style on 2 test files

2011-03-10 Thread sebb

svn ps svn:eol-style native test/org/apache/tomcat/util/net/TestCustomSsl.java
svn ps svn:eol-style native
test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080200 - in /tomcat/trunk/test/org/apache/tomcat/util/net: TestCustomSsl.java jsse/TesterBug50640SslImpl.java

2011-03-10 Thread kkolinko

Author: kkolinko
Date: Thu Mar 10 12:27:05 2011
New Revision: 1080200

URL: http://svn.apache.org/viewvc?rev=1080200view=rev
Log:
svn:eol-style, as noted by sebb

Modified:
tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java   (props 
changed)

tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java   
(props changed)

Propchange: tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java
--
svn:eol-style = native

Propchange: 
tomcat/trunk/test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat7 Missing SVN EOL-style on 2 test files

2011-03-10 Thread Konstantin Kolinko

2011/3/10 sebb seb...@gmail.com:
 svn ps svn:eol-style native test/org/apache/tomcat/util/net/TestCustomSsl.java
 svn ps svn:eol-style native
 test/org/apache/tomcat/util/net/jsse/TesterBug50640SslImpl.java

Done.  Thank you.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat7 - invalid keywords on some files

2011-03-10 Thread sebb

Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/SimpleElementValue.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java:
Author Date Id Revision
Invalid keyword for
TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java:
Author Date Id Revision

The quotes should be removed, because Author and Revision are not keywords.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080203 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-03-10 Thread kkolinko

Author: kkolinko
Date: Thu Mar 10 12:43:33 2011
New Revision: 1080203

URL: http://svn.apache.org/viewvc?rev=1080203view=rev
Log:
vote

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1080203r1=1080202r2=1080203view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 10 12:43:33 2011
@@ -162,5 +162,12 @@ PATCHES PROPOSED TO BACKPORT:
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50854
   Allow shared manager app when running under a security manager
   https://issues.apache.org/bugzilla/attachment.cgi?id=26758
-  +1: markt
+  +1: markt, kkolinko
   -1:
+kkolinko: This is not a default configuration, but a well-used one, so I
+agree that it is OK to enable those permissions by default. Note, that
+1) I think it would be nice to s/${catalina.home}/${catalina.base}/
+for the /examples webapps at the end of the file, as done by r881432
+Those are comments, so looks like CTR.
+2) The policy file is cited by security-manager-howto.xml. That
+document should be updated accordingly.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50394] InternalAprInputBuffer.fill() doesn't deal correctly with EOF

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50394

jfclere jfcl...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID

--- Comment #1 from jfclere jfcl...@gmail.com 2011-03-10 07:43:44 EST ---
The code in org/apache/coyote/http11/InternalAprInputBuffer is:
+++
nRead = Socket.recvbb(socket, 0, buf.length - lastValid);
if (nRead  0) {
bbuf.limit(nRead);
bbuf.get(buf, pos, nRead);
lastValid = pos + nRead;
} else {
if ((-nRead) == Status.ETIMEDOUT || (-nRead) == Status.TIMEUP)
{
throw new
SocketTimeoutException(sm.getString(iib.failedread));
} else {
throw new IOException(sm.getString(iib.failedread));
}
}
+++
So returning 0 won't help.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.11

2011-03-10 Thread sebb

On 10 March 2011 12:03, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 7.0.11 release is now available for voting.

 It can be obtained from:
 http://people.apache.org/~markt/dev/tomcat-7/v7.0.11/

The packaging of apache-tomcat-7.0.11-embed.tar.gz and
apache-tomcat-7.0.11-embed.zip are different.
The zip file has the contents in the top-level directory, whereas the
tar file puts everything in the subdirectory
apache-tomcat-7.0.11-embed
For all other zips, there is a top-level directory.

Is this difference intentional?
[Obviously not a blocker]

The README.html file mentions bin/extras, but does not mention bin/embed
Also - perhaps list the bin/extras entries alphabetically?

 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/

Looks OK apart from trivial issues already reported.

 The proposed 7.0.11 release is:

 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 7.0.11 Alpha
 [ ] Beta   - go ahead and release as 7.0.11 Beta
 [ ] Stable - go ahead and release as 7.0.11 Stable

 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat7 - invalid keywords on some files

2011-03-10 Thread Konstantin Kolinko

2011/3/10 sebb seb...@gmail.com:
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/SimpleElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java:
    Author Date Id Revision


IIRC, those were svn cp 'ed from the BCEL project. So the originals
are likely to have the same issue.

My impression/experience is that current svn clients validate the
svn:keywords property and wouldn't allow assigning such a value.

 The quotes should be removed, because Author and Revision are not keywords.


Without the quotes they are.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat7 - invalid keywords on some files

2011-03-10 Thread sebb

On 10 March 2011 12:49, Konstantin Kolinko knst.koli...@gmail.com wrote:
 2011/3/10 sebb seb...@gmail.com:
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/SimpleElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnclosingMethod.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/LocalVariableTypeTable.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/EnumElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ArrayElementValue.java:
    Author Date Id Revision
 Invalid keyword for
 TOMCAT_7_0_11/java/org/apache/tomcat/util/bcel/classfile/ClassElementValue.java:
    Author Date Id Revision


 IIRC, those were svn cp 'ed from the BCEL project. So the originals
 are likely to have the same issue.

I can fix those.

 My impression/experience is that current svn clients validate the
 svn:keywords property and wouldn't allow assigning such a value.

Not so - I had exactly the same issue recently.
I cannot remember if I used Subclipse or SVN command-line, but somehow
managed to add the quotes.

 The quotes should be removed, because Author and Revision are not keywords.


 Without the quotes they are.

Indeed.

 Best regards,
 Konstantin Kolinko

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080211 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 13:15:43 2011
New Revision: 1080211

URL: http://svn.apache.org/viewvc?rev=1080211view=rev
Log:
Proposal

Modified:
tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1080211r1=1080210r2=1080211view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Mar 10 13:15:43 2011
@@ -171,3 +171,9 @@ PATCHES PROPOSED TO BACKPORT:
 Those are comments, so looks like CTR.
 2) The policy file is cited by security-manager-howto.xml. That
 document should be updated accordingly.
+
+* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50895
+  Don't initialize classes during compilation
+  http://svn.apache.org/viewvc?rev=1079801view=rev
+  +1: markt
+  -1:



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50895] JSP compiler initializes classes during compile which can result in failures

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50895

--- Comment #7 from Mark Thomas ma...@apache.org 2011-03-10 08:21:38 EST ---
Proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080224 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 13:52:41 2011
New Revision: 1080224

URL: http://svn.apache.org/viewvc?rev=1080224view=rev
Log:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50700
Ensure that the override attribute of context parameters is correctly followed.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Mar 10 13:52:41 2011
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 
,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1072042

DO NOT REPLY [Bug 50700] Context parameters are being overridden with parameters from the web application deployment descriptor

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50700

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #7 from Mark Thomas ma...@apache.org 2011-03-10 08:52:53 EST ---
Fixed in 6.0.x and will be included in 6.0.33 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread Jim Jagielski

Verified... This seems enough, imo, to warrant a Broken...

On Mar 10, 2011, at 12:09 AM, Keiichi Fujino wrote:

 2011/3/4 Filip Hanik - Dev Lists devli...@hanik.com:
 Source and Binary Packages
 http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/
 
 Tag
 http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/
 
 Documentation
 http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html
 
 The proposed 1.1.0.1 release is:
 
 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 1.1.0.1 Alpha
 [ ] Beta   - go ahead and release as 1.1.0.1 Beta
 [X] Stable - go ahead and release as 1.1.0.1 Stable
 
 I tested jdbc-pool with simple applications.
 And it works well.
 
 However, when setting removeAbandoned=true, NPE is thrown out.
 It seems to occur when the Abandoned processing and SQL execution
 processing are executed at the same time.
 The synchronization of the Pool-Cleaner thread might not work
 correctly though I am not checking the code.
 
 The following are logs.
 =localhost.2011-03-10.log
 Mar 10, 2011 1:24:23 PM org.apache.catalina.core.StandardWrapperValve invoke
 SEVERE: Servlet.service() for servlet [jdbc] in context with path
 [/test] threw exception
 java.lang.NullPointerException
at 
 org.apache.tomcat.jdbc.pool.ProxyConnection.invoke(ProxyConnection.java:125)
at $Proxy9.prepareStatement(Unknown Source)
at jdbc_pool.JDBCPoolServlet.doGet(JDBCPoolServlet.java:32)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at 
 org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
at 
 org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at 
 org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
at 
 org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:164)
at 
 org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
at 
 org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
at 
 org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:562)
at 
 org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at 
 org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:394)
at 
 org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:243)
at 
 org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:188)
at 
 org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
at 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
 =
 
 -- 
 Keiichi.Fujino
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080226 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ant/ webapps/docs/

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 13:57:55 2011
New Revision: 1080226

URL: http://svn.apache.org/viewvc?rev=1080226view=rev
Log:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Add URL encoding where missing to parameters in URLs presented by Ant tasks to 
the Manager application.
Based on a patch by Stephane Bailliez.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/JMXGetTask.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/JMXQueryTask.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/JMXSetTask.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/ResourcesTask.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ant/UndeployTask.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Mar 10 13:57:55 2011
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 
,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1070609,1072042

DO NOT REPLY [Bug 28852] failonerror attribute on Ant tasks

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=28852

--- Comment #5 from Mark Thomas ma...@apache.org 2011-03-10 08:58:12 EST ---
Fixed in 6.0.x and will be included in 6.0.33 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080229 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/authenticator/AuthenticatorBase.java webapps/docs/changelog.xml

2011-03-10 Thread markt

Author: markt
Date: Thu Mar 10 14:02:50 2011
New Revision: 1080229

URL: http://svn.apache.org/viewvc?rev=1080229view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50855
Fix NPE on HttpServletRequest.logout() when debug logging is enabled.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt

tomcat/tc6.0.x/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Mar 10 14:02:50 2011
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77
 
0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901
 
39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,944409,944416,945231,945808,945835,945841,946686
 
,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1070609,1072042,1075458

DO NOT REPLY [Bug 50855] NullPointerException thrown in AuthenticatorBase.register method for null principal

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50855

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED

--- Comment #2 from Mark Thomas ma...@apache.org 2011-03-10 09:03:16 EST ---
This has been fixed in trunk and will be included in 6.0.33 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50910] New: improper error message on incorrect context path specification

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50910

   Summary: improper error message on incorrect context path
specification
   Product: Tomcat 7
   Version: 7.0.8
  Platform: PC
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: cla...@renegat.net


When specified from within the server.xml file, the Context element appears to
expect the following syntax for its Path attribute:

  /location

If the leading '/' is omitted, the log shows lots of:

   Failed to process JAR [jar:jndi:/...lib.jar!/null] for TLD files

which isn't very explicit...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50910] improper error message on incorrect context path specification

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50910

Claude Brisson cla...@renegat.net changed:

   What|Removed |Added

 CC||cla...@renegat.net

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50911] New: Quieten NSIS so errors and warnings can be seen

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50911

   Summary: Quieten NSIS so errors and warnings can be seen
   Product: Tomcat 7
   Version: 7.0.10
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Packaging
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org


Created an attachment (id=26759)
 -- (https://issues.apache.org/bugzilla/attachment.cgi?id=26759)
Patch to add /V2 flag

The NSIS phase currently generates so much output it is all but impossible to
detect any warnings.

Using the switch /V2 restricts output to warnings and errors only.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50911] Quieten NSIS so errors and warnings can be seen

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50911

--- Comment #1 from Sebb s...@apache.org 2011-03-10 09:59:56 EST ---
FYI: with the patch in place, output looks like:

 [exec] MakeNSIS v2.46 - Copyright 1995-2009 Contributors
 [exec] See the file COPYING for license details.
 [exec] Credits can be found in the Users Manual.
 [exec]
 [exec] Command line defined: NSISDIR=/usr/share/java/nsis-2.46
 [exec] --
 [exec] NSIS String Functions Header File 1.09 - Copyright 2004 Diego Pedroso
 [exec] --
 [exec]  (D:\usr\share\java\nsis-2.46\Include\StrFunc.nsh:52)
 [exec] $ {StrRep} - Copyright 2004 Diego Pedroso - Based on functions by
Hendri Adriaens (macro:STRFUNC_FUNC:11)
 [exec] $ {StrRep} $0 $0  amp; (macro:FUNCTION_STRING_StrRep_Call:3)
 [exec] $ {StrRep} $0 $0  quot; (macro:FUNCTION_STRING_StrRep_Call:3)
 [exec] $ {StrRep} $0 $0  lt; (macro:FUNCTION_STRING_StrRep_Call:3)
 [exec] $ {StrRep} $0 $0  gt; (macro:FUNCTION_STRING_StrRep_Call:3)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread Filip Hanik - Dev Lists


On 3/10/2011 6:57 AM, Jim Jagielski wrote:

Verified... This seems enough, imo, to warrant a Broken...

not sure how this is broken :)
The connection has been cancelled ie, removed for being abandoned. So you should not be able to use it anymore. There is a question if 
this should return a SQL exception instead of a NPE


Filip



On Mar 10, 2011, at 12:09 AM, Keiichi Fujino wrote:


2011/3/4 Filip Hanik - Dev Listsdevli...@hanik.com:

Source and Binary Packages
http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/

Tag
http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/

Documentation
http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html

The proposed 1.1.0.1 release is:

[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 1.1.0.1 Alpha
[ ] Beta   - go ahead and release as 1.1.0.1 Beta
[X] Stable - go ahead and release as 1.1.0.1 Stable

I tested jdbc-pool with simple applications.
And it works well.

However, when setting removeAbandoned=true, NPE is thrown out.
It seems to occur when the Abandoned processing and SQL execution
processing are executed at the same time.
The synchronization of the Pool-Cleaner thread might not work
correctly though I am not checking the code.

The following are logs.
=localhost.2011-03-10.log
Mar 10, 2011 1:24:23 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [jdbc] in context with path
[/test] threw exception
java.lang.NullPointerException
at 
org.apache.tomcat.jdbc.pool.ProxyConnection.invoke(ProxyConnection.java:125)
at $Proxy9.prepareStatement(Unknown Source)
at jdbc_pool.JDBCPoolServlet.doGet(JDBCPoolServlet.java:32)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:164)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:562)
at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:394)
at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:243)
at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:188)
at 
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:302)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:619)
=

--
Keiichi.Fujino

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1204 / Virus Database: 1497/3496 - Release Date: 03/10/11






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: STATUS.txt reviews

2011-03-10 Thread Filip Hanik - Dev Lists


https://issues.apache.org/jira/browse/INFRA-3507

Filip

On 3/10/2011 5:12 AM, Konstantin Kolinko wrote:

2011/3/3 Mark Thomasma...@apache.org:

On 02/03/2011 20:57, Filip Hanik - Dev Lists wrote:

I wanted to throw out an idea of an alternative or complementary way to
handle our STATUS.txt files, and this solution can apply to our CTR
branches as well.
The solution would be http://www.reviewboard.org/
If there is an interest, I can spend some time configuring an instance
for one of our branches and we can give it a test run and see if we like
it.

Any takers?

If you go down that route, use the reviewboard instance provided by ASF
infra.

I am currently neutral on this. I can see the benefits of reviewboard
but I like that by keeping things simple I can easily work off-line.


There is a problem with out trunk/tc7 that there are patches that are
work-in-progress or are hard to apply and would benefit from review.

The current approach is using Bugzilla, but
1) there is no such list of ready-for-review items, like the STATUS
file, and they may fell off the radar
2) it is hard to review them there, because you will need separate
step to download the patch, and then comment in the text field or
whatever

If reviewboard can solve the above, it would be fine.
 From descriptions it looks that it is suited for pre-commit reviews. I
have no experience with it, though.

Thus I suggest to try it for our trunk.

For the RTC branches though I think it is not a replacement for the
STATUS. Maybe with more experience I will change my mind, but as of
now the STATUS is more traceable and formal.  I do not mind about
links to reviewboard being mentioned in STATUS, like we mention the
patches on people or message threads.


The links to ASF reviewboard:
https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
https://reviews.apache.org/

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
No virus found in this message.
Checked by AVG - www.avg.com
Version: 10.0.1204 / Virus Database: 1497/3496 - Release Date: 03/10/11





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 50906] Chunked encoding not terminated with native library

2011-03-10 Thread bugzilla

https://issues.apache.org/bugzilla/show_bug.cgi?id=50906

--- Comment #1 from Chris ch...@blaze.io 2011-03-10 12:50:01 EST ---
I'm including some additional info that I'd posted to the mailing list:

- I'm running with nginx in front of tomcat
- The 60 second timeout is happening in nginx and not tomcat
- Regardless of whether or not I'm using libtcnative, I don't see the
terminating 0\r\n\r\n being sent by tomcat to nginx
- When not using libtcnative, the connection is closed after writing the
response; there's a FIN, in addition to ACK on the last TCP packet from tomcat.
Nginx seems to use this to infer the end of the response and add the
0\r\n\r\n to the reply sent to the client.
- When using libtcnative, there is no FIN on the last TCP ACK packet, and the
connection stays open. One minute later nginx times out waiting for the
response to complete and adds the 0\r\n\r\n to the response to the client.
- I notice that if I use curl to make a request directly to tomcat (instead of
going through nginx), then I do see the terminating 0\r\n\r\n. I still see a
difference in that tomcat disconnects immediately after the reply when not
using the native library.

Later I said...:
I've narrowed this down even further.

 As I mentioned below, the 0\r\n\r\n was not being sent to nginx, although it
was being sent to curl. The difference was that nginx was doing a GET HTTP/1.0,
while curl was using HTTP/1.1. If I configure curl to use HTTP/1.0 then I get
the same result: no 0\r\n\r\n is sent.

So, to summarize:
- GET HTTP/1.0 results in no terminating 0\r\n\r\n for the chunked response,
regardless of whether libtcnative is being used.
- The difference when using libtcnative is that the connection isn't terminated
after the response is sent.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread Filip Hanik - Dev Lists


On 3/9/2011 11:57 PM, Eiji Takahashi wrote:

Hi developers.

I encountered the same issue, too.
I got following exception.

an exception is expected if the connection has been abandoned.
it's tricky, one can always throw a SQLException, which leads to a problem, what if a method is called that does not throw SQLException. we 
can check for this as well


best
Filip



-
java.lang.NullPointerException
 at 
org.apache.tomcat.jdbc.pool.interceptor.StatementCache$CachedStatement.closeInvoked(StatementCache.java:224)
 at 
org.apache.tomcat.jdbc.pool.interceptor.StatementDecoratorInterceptor$StatementProxy.invoke(StatementDecoratorInterceptor.java:226)
 at $Proxy1.close(Unknown Source)
 at test.PoolTestServlet.doPost(PoolTestServlet.java:30)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
 at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:306)
 at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
 at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
 at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161)
 at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
 at 
org.apache.catalina.ha.tcp.ReplicationValve.invoke(ReplicationValve.java:354)
 at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:108)
 at 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:558)
 at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
 at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:379)
 at 
org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:283)
 at 
org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:209)
 at 
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1671)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 at java.lang.Thread.run(Thread.java:662)
---
When the busy connection reaches abandoned time-out, PoolCleaner calls
ConnectionPool#abandon() for this connection.
And, reset all Interceptors that is relevant to this connection. In
the case of StatementCache, null is set to cacheSize and pcon.
As a result, when CachedStatement.closeInvoked is executed,
cacheSize.get() causes NPE.
I think that other Interceptors also have same issue.

I thought several solutions for this issue.
(1) Prevent NPE at each Interceptors.
(2) Create new interceptor for handling NPE, and set this interceptor
to top of interceptor chain.
 -  In this interceptor, change RuntimeException to SQLException.

I think that (2) is better than (1), because (2) doesn't depend on
design of each Interceptors.


On Thu, Mar 10, 2011 at 2:09 PM, Keiichi Fujinokfuj...@apache.org  wrote:

2011/3/4 Filip Hanik - Dev Listsdevli...@hanik.com:

Source and Binary Packages
http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/

Tag
http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/

Documentation
http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html

The proposed 1.1.0.1 release is:

[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 1.1.0.1 Alpha
[ ] Beta   - go ahead and release as 1.1.0.1 Beta
[X] Stable - go ahead and release as 1.1.0.1 Stable

I tested jdbc-pool with simple applications.
And it works well.

However, when setting removeAbandoned=true, NPE is thrown out.
It seems to occur when the Abandoned processing and SQL execution
processing are executed at the same time.
The synchronization of the Pool-Cleaner thread might not work
correctly though I am not checking the code.

The following are logs.
=localhost.2011-03-10.log
Mar 10, 2011 1:24:23 PM org.apache.catalina.core.StandardWrapperValve invoke
SEVERE: Servlet.service() for servlet [jdbc] in context with path
[/test] threw exception
java.lang.NullPointerException
at 
org.apache.tomcat.jdbc.pool.ProxyConnection.invoke(ProxyConnection.java:125)
at $Proxy9.prepareStatement(Unknown Source)
at jdbc_pool.JDBCPoolServlet.doGet(JDBCPoolServlet.java:32)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
at

Re: [VOTE] Release Apache Tomcat 7.0.11

2011-03-10 Thread Mark Thomas

On 10/03/2011 12:03, Mark Thomas wrote:
 The proposed Apache Tomcat 7.0.11 release is now available for voting.
 
 It can be obtained from:
 http://people.apache.org/~markt/dev/tomcat-7/v7.0.11/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/
 
 The proposed 7.0.11 release is:
 
 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 7.0.11 Alpha
 [ ] Beta   - go ahead and release as 7.0.11 Beta
 [X] Stable - go ahead and release as 7.0.11 Stable

Unit tests pass
Servlet TCK passes (excluding tests currently being challenged) with the
security manager enabled for:
- HTTP BIO
- HTTP NIO
- HTTP APR
- AJP BIO
- AJP APR

The JSP TCK passed with a security manager enabled

The EL TCK passed with a security manager enabled

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.11

2011-03-10 Thread Konstantin Kolinko

2011/3/10 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 7.0.11 release is now available for voting.

 It can be obtained from:
 http://people.apache.org/~markt/dev/tomcat-7/v7.0.11/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_11/

 The proposed 7.0.11 release is:

 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 7.0.11 Alpha
 [ ] Beta   - go ahead and release as 7.0.11 Beta
 [x] Stable - go ahead and release as 7.0.11 Stable


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080413 - in /tomcat: tc6.0.x/trunk/webapps/docs/changelog.xml trunk/webapps/docs/changelog.xml

2011-03-10 Thread kkolinko

Author: kkolinko
Date: Fri Mar 11 00:39:25 2011
New Revision: 1080413

URL: http://svn.apache.org/viewvc?rev=1080413view=rev
Log:
A pair of typos

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1080413r1=1080412r2=1080413view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Mar 11 00:39:25 2011
@@ -49,7 +49,7 @@
   fix
 bug28852/bug: Add URL encoding where missing to parameters in URLs
 presented by Ant tasks to the Manager application. Based on a patch by
-Stephane Bailliez. (mark) 
+Stephane Bailliez. (markt) 
   /fix
   fix
 bug50189/bug: Once the application has finished writing to the

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1080413r1=1080412r2=1080413view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Fri Mar 11 00:39:25 2011
@@ -80,7 +80,7 @@
   /fix
   fix
 Calling codestop()/code and then codedestroy()/code on a
-connector in correctly triggered an exception. (markt)
+connector incorrectly triggered an exception. (markt)
   /fix
 /changelog
   /subsection



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1080415 - in /tomcat/trunk/res: welcome.bin.html welcome.main.html

2011-03-10 Thread kkolinko

Author: kkolinko
Date: Fri Mar 11 00:57:25 2011
New Revision: 1080415

URL: http://svn.apache.org/viewvc?rev=1080415view=rev
Log:
Followup to r1079781
s//amp;/ in HTML files

HTML allows both variants, but let's be more strict.

Modified:
tomcat/trunk/res/welcome.bin.html
tomcat/trunk/res/welcome.main.html

Modified: tomcat/trunk/res/welcome.bin.html
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/welcome.bin.html?rev=1080415r1=1080414r2=1080415view=diff
==
--- tomcat/trunk/res/welcome.bin.html (original)
+++ tomcat/trunk/res/welcome.bin.html Fri Mar 11 00:57:25 2011
@@ -72,7 +72,7 @@ RELEASE-NOTES and the RUNNING.txt file i
 /dl/dd
 dtbbin/extras//b/dt
 dddl
-  dttomcat-juli-adapters.jar  tomcat-juli.jar/dt
+  dttomcat-juli-adapters.jar amp; tomcat-juli.jar/dt
 ddFull commons-logging implementation. See the a
 
href=http://tomcat.apache.org/tomcat-@VERSION_MAJOR_MINOR@-doc/logging.html;
 logging documentation/a for more information./dd

Modified: tomcat/trunk/res/welcome.main.html
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/welcome.main.html?rev=1080415r1=1080414r2=1080415view=diff
==
--- tomcat/trunk/res/welcome.main.html (original)
+++ tomcat/trunk/res/welcome.main.html Fri Mar 11 00:57:25 2011
@@ -72,7 +72,7 @@ RELEASE-NOTES and the RUNNING.txt file i
 /dl/dd
 dtbbin/extras//b/dt
 dddl
-  dttomcat-juli-adapters.jar  tomcat-juli.jar/dt
+  dttomcat-juli-adapters.jar amp; tomcat-juli.jar/dt
 ddFull commons-logging implementation. See the a
 
href=http://tomcat.apache.org/tomcat-@VERSION_MAJOR_MINOR@-doc/logging.html;
 logging documentation/a for more information./dd



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release jdbc-pool 1.1.0.1

2011-03-10 Thread sebb

On 10 March 2011 18:50, Filip Hanik - Dev Lists devli...@hanik.com wrote:
 On 3/9/2011 11:57 PM, Eiji Takahashi wrote:

 Hi developers.

 I encountered the same issue, too.
 I got following exception.

 an exception is expected if the connection has been abandoned.
 it's tricky, one can always throw a SQLException, which leads to a problem,
 what if a method is called that does not throw SQLException. we can check
 for this as well

Letting the JVM generate an NPE does not immediately alert the user to
the cause of the problem.

Why not throw IllegalStateException with a suitable message?

 best
 Filip


 -
 java.lang.NullPointerException
         at
 org.apache.tomcat.jdbc.pool.interceptor.StatementCache$CachedStatement.closeInvoked(StatementCache.java:224)
         at
 org.apache.tomcat.jdbc.pool.interceptor.StatementDecoratorInterceptor$StatementProxy.invoke(StatementDecoratorInterceptor.java:226)
         at $Proxy1.close(Unknown Source)
         at test.PoolTestServlet.doPost(PoolTestServlet.java:30)
         at javax.servlet.http.HttpServlet.service(HttpServlet.java:641)
         at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
         at
 org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:306)
         at
 org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
         at
 org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
         at
 org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:161)
         at
 org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
         at
 org.apache.catalina.ha.tcp.ReplicationValve.invoke(ReplicationValve.java:354)
         at
 org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:108)
         at
 org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:558)
         at
 org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
         at
 org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:379)
         at
 org.apache.coyote.ajp.AjpAprProcessor.process(AjpAprProcessor.java:283)
         at
 org.apache.coyote.ajp.AjpAprProtocol$AjpConnectionHandler.process(AjpAprProtocol.java:209)
         at
 org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1671)
         at
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
         at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
         at java.lang.Thread.run(Thread.java:662)
 ---
 When the busy connection reaches abandoned time-out, PoolCleaner calls
 ConnectionPool#abandon() for this connection.
 And, reset all Interceptors that is relevant to this connection. In
 the case of StatementCache, null is set to cacheSize and pcon.
 As a result, when CachedStatement.closeInvoked is executed,
 cacheSize.get() causes NPE.
 I think that other Interceptors also have same issue.

 I thought several solutions for this issue.
 (1) Prevent NPE at each Interceptors.
 (2) Create new interceptor for handling NPE, and set this interceptor
 to top of interceptor chain.
     -  In this interceptor, change RuntimeException to SQLException.

 I think that (2) is better than (1), because (2) doesn't depend on
 design of each Interceptors.


 On Thu, Mar 10, 2011 at 2:09 PM, Keiichi Fujinokfuj...@apache.org
  wrote:

 2011/3/4 Filip Hanik - Dev Listsdevli...@hanik.com:

 Source and Binary Packages
 http://people.apache.org/~fhanik/jdbc-pool/v1.1.0.1/

 Tag
 http://svn.apache.org/repos/asf/tomcat/tags/JDBC_POOL_1_1_0_1/

 Documentation
 http://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html

 The proposed 1.1.0.1 release is:

 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 1.1.0.1 Alpha
 [ ] Beta   - go ahead and release as 1.1.0.1 Beta
 [X] Stable - go ahead and release as 1.1.0.1 Stable

 I tested jdbc-pool with simple applications.
 And it works well.

 However, when setting removeAbandoned=true, NPE is thrown out.
 It seems to occur when the Abandoned processing and SQL execution
 processing are executed at the same time.
 The synchronization of the Pool-Cleaner thread might not work
 correctly though I am not checking the code.

 The following are logs.
 =localhost.2011-03-10.log
 Mar 10, 2011 1:24:23 PM org.apache.catalina.core.StandardWrapperValve
 invoke
 SEVERE: Servlet.service() for servlet [jdbc] in context with path
 [/test] threw exception
 java.lang.NullPointerException
    at
 org.apache.tomcat.jdbc.pool.ProxyConnection.invoke(ProxyConnection.java:125)
    at $Proxy9.prepareStatement(Unknown Source)
    at jdbc_pool.JDBCPoolServlet.doGet(JDBCPoolServlet.java:32)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
    at

54 matches

Mail list logo