svn commit: r1104696 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kfujino Date: Wed May 18 06:27:44 2011 New Revision: 1104696 URL: http://svn.apache.org/viewvc?rev=1104696view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1104696r1=1104695r2=1104696view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 18 06:27:44 2011 @@ -182,24 +182,24 @@ PATCHES PROPOSED TO BACKPORT: Throw an exception and do not start the APR connector if it is configured for SSL and an invalid value is provided for SSLProtocol. http://svn.apache.org/viewvc?view=revisionrevision=1094089 - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 Fix deploy for HTML Manager app that was broken when CSRF prevention was added Patch provided by Alexis Hassler. https://issues.apache.org/bugzilla/attachment.cgi?id=26957action=diff - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51119 Add JAAS authentication support to the JmxRemoteLifecycleListener Patch provided by Neil Laurance http://svn.apache.org/viewvc?rev=1099586view=rev - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: * Fix SSLValve so it returns key size as an Integer rather than a String http://svn.apache.org/viewvc?rev=1100822view=rev - +1: markt, kkolinko + +1: markt, kkolinko, kfujino -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51217] New: getServletContext().getRealPath(/) returns null.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51217 Bug #: 51217 Summary: getServletContext().getRealPath(/) returns null. Product: Tomcat 7 Version: 7.0.14 Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P2 Component: Servlet JSP API AssignedTo: dev@tomcat.apache.org ReportedBy: daniel.strassenb...@gmx.net Classification: Unclassified getServletContext().getRealPath(/) returns null. I know this method is deprecated but it changed its behavior so our webapp does not start due to a NPE. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124211 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties webapps/docs/changelog.xml
Author: markt Date: Wed May 18 12:12:16 2011 New Revision: 1124211 URL: http://svn.apache.org/viewvc?rev=1124211view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51073 Throw an exception and do not start the APR connector if it is configured for SSL and an invalid value is provided for SSLProtocol. Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed May 18 12:12:16 2011 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,943112,944409,944416,945231,945808,945835,945841 ,946686,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1069824,1070420,1070609,1072042,1075458,1076212,1078412,1079801,1081334,1088460,1099772,1099789,1100145,1101094,1101144
DO NOT REPLY [Bug 51073] Misconfigured SSLProtocol with an AprEndpoint silently falls back to ALL
https://issues.apache.org/bugzilla/show_bug.cgi?id=51073 --- Comment #2 from Mark Thomas ma...@apache.org 2011-05-18 12:12:19 UTC --- Fixed in 6.0.x and will be included in 6.0.33 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124220 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/manager/HTMLManagerServlet.java webapps/docs/changelog.xml
Author: markt
Date: Wed May 18 12:35:40 2011
New Revision: 1124220
URL: http://svn.apache.org/viewvc?rev=1124220view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51147
Fix deploy for HTML Manager app that was broken when CSRF prevention was added
Patch provided by Alexis Hassler.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1124220r1=1124219r2=1124220view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed May 18 12:35:40 2011
@@ -178,13 +178,6 @@ PATCHES PROPOSED TO BACKPORT:
+1: markt
-1:
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51147
- Fix deploy for HTML Manager app that was broken when CSRF prevention was
added
- Patch provided by Alexis Hassler.
- https://issues.apache.org/bugzilla/attachment.cgi?id=26957action=diff
- +1: markt, kkolinko, kfujino
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51119
Add JAAS authentication support to the JmxRemoteLifecycleListener
Patch provided by Neil Laurance
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1124220r1=1124219r2=1124220view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
Wed May 18 12:35:40 2011
@@ -1114,7 +1114,7 @@ public final class HTMLManagerServlet ex
/tr\n +
tr\n +
td colspan=\2\\n +
-form method=\get\ action=\{2}\\n +
+form method=\post\ action=\{2}\\n +
table cellspacing=\0\ cellpadding=\3\\n +
tr\n +
td class=\row-right\\n +
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1124220r1=1124219r2=1124220view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed May 18 12:35:40 2011
@@ -152,6 +152,10 @@
than maintaining a copy of its content. (kkolinko)
/update
fix
+bug51147/bug: Fix deployment via HTML Manager that was broken by
+addition of CRSF protection. Patch provided by Alexis Hassler. (markt)
+ /fix
+ fix
bug51156/bug: Ensure session expiration option is available in
Manager application was running web applications that were defined in
server.xml. (markt)
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Mark Thomas ma...@apache.org 2011-05-18 12:36:26 UTC --- Fixed in 6.0.x and will be included in 6.0.33 onwards. Thanks for the patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124225 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java webapps/docs/changelog.xml
Author: markt Date: Wed May 18 12:41:42 2011 New Revision: 1124225 URL: http://svn.apache.org/viewvc?rev=1124225view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51119 Add JAAS authentication support to the JmxRemoteLifecycleListener Patch provided by Neil Laurance Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed May 18 12:41:42 2011 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,943112,944409,944416,945231,945808,945835,945841 ,946686,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1069824,1070420,1070609,1072042,1075458,1076212,1078412,1079801,1081334,1088460,1094089,1099772,1099789,1100145,1101094,1101144
DO NOT REPLY [Bug 51119] extras - JmxRemoteLifecycleListener does not support JAAS based authentication and authorisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=51119 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-18 12:41:26 UTC --- Fixed in 6.0.x and will be included in 6.0.33 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51147] Deploy from Manager fail in 403
https://issues.apache.org/bugzilla/show_bug.cgi?id=51147 --- Comment #9 from Alexis Hassler alexis.hass...@sewatech.fr 2011-05-18 12:44:56 UTC --- You're welcome. I'm glad with my small contrib. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124238 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/valves/SSLValve.java webapps/docs/changelog.xml
Author: markt Date: Wed May 18 12:56:54 2011 New Revision: 1124238 URL: http://svn.apache.org/viewvc?rev=1124238view=rev Log: Fix SSLValve so it returns key size as an Integer rather than a String Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/SSLValve.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed May 18 12:56:54 2011 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,666232,673796,673820,677910,683969,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,713953,714002,718360,719119,719124,719602,719626,719628,720046,720069,721040,721286,721708,721886,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,746425,747834,747863,748344,750258,750291,750921,751286-751287,751289,751295,752323,753039,757335,757774,758249,758365,758596,758616,758664,759074,761601,762868,762929,762936-762937,763166,763183,763193,763228,763262,763298,763302,763325,763599,763611,763654,763681,763706,764985,764997,765662,768335,769979,770716,77 0809,770876,772872,776921,776924,776935,776945,777464,777466,777576,777625,778379,778523-778524,781528,781779,782145,782791,783316,783696,783724,783756,783762,783766,783863,783934,784453,784602,784614,785381,785688,785768,785859,786468,786487,786490,786496,786667,787627,787770,787985,789389,790405,791041,791184,791194,791224,791243,791326,791328,791789,792740,793372,793757,793882,793981,794082,794673,794822,795043,795152,795210,795457,795466,797168,797425,797596,797607,802727,802940,804462,804544,804734,805153,809131,809603,810916,810977,812125,812137,812432,813001,813013,813866,814180,814708,814876,815972,816252,817442,817822,819339,819361,820110,820132,820874,820954,821397,828196,828201,828210,828225,828759,830378-830379,830999,831106,831774,831785,831828,831850,831860,832214,832218,833121,833545,834047,835036,835336,836405,881396,881412,883130,883134,883146,883165,883177,883362,883565,884341,885038,885231,885241,885260,885901,885991,886019,888072,889363,889606,889716,8901 39,890265,890349-890350,890417,891185-891187,891583,892198,892341,892415,892464,892555,892812,892814,892817,892843,892887,893321,893493,894580,894586,894805,894831,895013,895045,895057,895191,895392,895703,896370,896384,897380-897381,897776,898126,898256,898468,898527,898555,898558,898718,898836,898906,899284,899348,899420,899653,899769-899770,899783,899788,899792,899916,899918-899919,899935,899949,903916,905020,905151,905722,905728,905735,907311,907513,907538,907652,907819,907825,907864,908002,908721,908754,908759,909097,909206,909212,909525,909636,909869,909875,909887,910266,910370,910442,910471,910485,910974,915226,915737,915861,916097,916141,916157,916170,917598,917633,918093,918489,918594,918684,918787,918792,918799,918803,918885,919851,919914,920025,920055,920298,920449,920596,920824,920840,921444,922010,926716,927062,927621,928482,928695,928732,928798,931709,932357,932967,935105,935983,939491,939551,940064,941356,941463,943112,944409,944416,945231,945808,945835,945841 ,946686,948057,950164,950596,950614,950851,950905,951615,953434,954435,955648,955655,956832,957130,957830,958192,960701,961948,962865,962872,962881,962900,963106,963865,963868,964614,966177-966178,966292,966692,966863,981815,988448,991837,993042,1001955,1002185,1002263,1002274,1002349,1002359,1002362,1002481,1002514,1003461,1003481,1003488,1003556,1003572,1003581,1003861,1004393,1004409,1004415,1004868-1004869,1004912,1005452,1005467,1005647,1005802,1022120,1022134,1022323,1022415,1022606,1022623,1024224,1024251,1026042,1026784,1026912,1026920,1029767,1033415,1033448,1033842,1033897,1037715,1037794,1037887,1037924,1038041,1042022,1042029,1042447,1042452,1042494,1044944,1044987,1050249,1055055,1055236,1055458,1055975,1056264,1056828,1056889,1059881,1061412,1061442,1061446,1062398,1064652,1066244,1067039,1067139,1069824,1070420,1070609,1072042,1075458,1076212,1078412,1079801,1081334,1088460,1094089,1099586,1099772,1099789,1100145,1101094,1101144
[PROPOSAL] Move to svnpubsub for /dist/tomcat
All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51217] getServletContext().getRealPath(/) returns null.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51217 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WORKSFORME --- Comment #1 from Mark Thomas ma...@apache.org 2011-05-18 13:43:38 UTC --- A simple test case works for me with the latest Tomcat 7.0.x source. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
2011/5/18 Mark Thomas ma...@apache.org:
All,
We have the option to move to svnpubsub for managing our releases.
Rather than copying artefacts to people.a.o and then waiting for rsync
(every around 2 hours) we would commit the artefacts to svn and a commit
hook would update the /dist/tomcat area on the www servers immediately.
If folks would like to go this route, I am happy to do the work on our
end to migrate /dist/tomcat to svnpubsub.
1. In what repository will the artifacts go?
IIRC, there is some additional repository. I think it wouldn't be good
to have them in /repos/asf/
2. You will have to upload Javadocs.
With svn 1.6 I used an Ant snippet similar to the following to remove all files,
but leave the directories structure intact:
[[[
delete defaultexcludes=false
fileset dir=${path}
exclude name=**/.svn /
include name=**/* /
/fileset
/delete
]]]
After that I would copy the new files over the old structure and commit them.
With svn 1.7 that would be easier, because It does not have .svn subdirectories.
I am already using svn 1.7 (TortoiseSVN nightly builds) for two weeks
and am quite happy with them. There is a thread at dev@subversion that
the first alpha/beta for 1.7.0 is tentatively scheduled on June 1.
3. Will we migrate our website to the new CMS?
https://blogs.apache.org/infra/entry/the_asf_cms
Have you thought whether you proposal will facilitate such migration,
or impede it?
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
On 18/05/2011 15:06, Konstantin Kolinko wrote: 2011/5/18 Mark Thomas ma...@apache.org: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo 2. You will have to upload Javadocs. Huh? We are talking about www.a.o/dist, not the Tomcat website. 3. Will we migrate our website to the new CMS? https://blogs.apache.org/infra/entry/the_asf_cms That is a separate issue. Have you thought whether you proposal will facilitate such migration, or impede it? It makes no difference. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
+1 sounds good Filip On 5/18/2011 7:38 AM, Mark Thomas wrote: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1321 / Virus Database: 1500/3643 - Release Date: 05/17/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
2011/5/18 Mark Thomas ma...@apache.org: 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo 2. You will have to upload Javadocs. Huh? We are talking about www.a.o/dist, not the Tomcat website. OK. +1 then. Does it change anything for archive.apache.org? Probably not, as I think it is replicated from live www.a.o, but it might be worth checking once your changes are implemented. Will the commit messages be forwarded to the mailing list? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
+1 On Wed, May 18, 2011 at 9:38 AM, Mark Thomas ma...@apache.org wrote: We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub.
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
+1 On 05/18/2011 03:38 PM, Mark Thomas wrote: If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51220] New: Add system property that makes it possible for jsp pages with the extends page directive to take advantage of tag pooling
https://issues.apache.org/bugzilla/show_bug.cgi?id=51220 Bug #: 51220 Summary: Add system property that makes it possible for jsp pages with the extends page directive to take advantage of tag pooling Product: Tomcat 6 Version: 6.0.32 Platform: PC OS/Version: Linux Status: NEW Severity: enhancement Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: dmik...@vmware.com Classification: Unclassified Created attachment 27022 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27022 Patch file I would like to propose that a system property be added which would allow a JSP page that uses the extends page directive to take advantage of tag pooling. Patch file included. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51185] Performance : DataSourceProxy#createPool should use more fine grained synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=51185 Philippe Mouawad p.moua...@ubik-ingenierie.com changed: What|Removed |Added Attachment #26984|0 |1 is obsolete|| --- Comment #3 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-18 16:22:27 UTC --- Created attachment 27023 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27023 Fix to synchro issue This patch cancels the previous one which was bugged. Philippe -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212 Philippe Mouawad p.moua...@ubik-ingenierie.com changed: What|Removed |Added Attachment #27017|0 |1 is obsolete|| --- Comment #1 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-18 16:31:05 UTC --- Created attachment 27024 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27024 Fix to synchro issue Previous patch was bugged -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
On 5/18/2011 9:22 AM, Mark Thomas wrote: On 18/05/2011 15:06, Konstantin Kolinko wrote: 2011/5/18 Mark Thomas ma...@apache.org: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo https://dist.apache.org/repos/dist/... dev and release, with tomcat as a new tree under each. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51185] Performance : DataSourceProxy#createPool should use more fine grained synchronisation
https://issues.apache.org/bugzilla/show_bug.cgi?id=51185 Philippe Mouawad p.moua...@ubik-ingenierie.com changed: What|Removed |Added Attachment #27023|0 |1 is obsolete|| --- Comment #4 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-18 16:34:19 UTC --- Created attachment 27025 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27025 Real fix Sorry I messed up with another bug. Philippe Mouawad http://www.ubik-ingenierie.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212 --- Comment #2 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-18 16:35:14 UTC --- Note that there is still an issue where nbrInvocations is equals to 0. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124340 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java
Author: markt
Date: Wed May 18 17:16:26 2011
New Revision: 1124340
URL: http://svn.apache.org/viewvc?rev=1124340view=rev
Log:
If an error status is set during async processing, don't drop the connection
and let the async processing handle it
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java?rev=1124340r1=1124339r2=1124340view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java Wed May
18 17:16:26 2011
@@ -311,7 +311,8 @@ public class Http11AprProcessor extends
// committed, so we can't try and set headers.
if(keepAlive !error) { // Avoid checking twice.
error = response.getErrorException() != null ||
-statusDropsConnection(response.getStatus());
+(!isAsync()
+statusDropsConnection(response.getStatus()));
}
} catch (InterruptedIOException e) {
error = true;
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java?rev=1124340r1=1124339r2=1124340view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java Wed May
18 17:16:26 2011
@@ -401,7 +401,8 @@ public class Http11NioProcessor extends
// committed, so we can't try and set headers.
if(keepAlive !error) { // Avoid checking twice.
error = response.getErrorException() != null ||
-statusDropsConnection(response.getStatus());
+(!isAsync()
+statusDropsConnection(response.getStatus()));
}
// Comet support
SelectionKey key =
socket.getIOChannel().keyFor(socket.getPoller().getSelector());
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java?rev=1124340r1=1124339r2=1124340view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java Wed May 18
17:16:26 2011
@@ -322,7 +322,8 @@ public class Http11Processor extends Abs
// committed, so we can't try and set headers.
if(keepAlive !error) { // Avoid checking twice.
error = response.getErrorException() != null ||
-statusDropsConnection(response.getStatus());
+(!isAsync()
+statusDropsConnection(response.getStatus()));
}
} catch (InterruptedIOException e) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124342 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java test/org/apache/catalina/core/TestAsyncContextImpl.java webapps/docs/changelog.xml
Author: markt
Date: Wed May 18 17:25:28 2011
New Revision: 1124342
URL: http://svn.apache.org/viewvc?rev=1124342view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51197
Fix possible dropped connection when sendError or sendRedirst are used during
async processing.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1124342r1=1124341r2=1124342view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Wed May
18 17:25:28 2011
@@ -277,6 +277,9 @@ public class CoyoteAdapter implements Ad
if (ctxt != null) {
ctxt.fireRequestDestroyEvent(request);
}
+// Lift any suspension (e.g. if sendError() was used by an
async
+// request
+response.setSuspended(false);
}
if (status==SocketStatus.TIMEOUT) {
Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1124342r1=1124341r2=1124342view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Wed
May 18 17:25:28 2011
@@ -49,6 +49,8 @@ public class TestAsyncContextImpl extend
private static final long REQUEST_TIME = 500;
// Timeout thread (where used) checks for timeout every second
private static final long TIMEOUT_MARGIN = 1000;
+// Default timeout for these tests
+private static final long TIMEOUT = 3000;
public void testBug49528() throws Exception {
// Setup Tomcat instance
@@ -1112,4 +1114,74 @@ public class TestAsyncContextImpl extend
}
+public void testBug51197() throws Exception {
+// Setup Tomcat instance
+Tomcat tomcat = getTomcatInstance();
+
+// Must have a real docBase - just use temp
+File docBase = new File(System.getProperty(java.io.tmpdir));
+
+Context ctx = tomcat.addContext(, docBase.getAbsolutePath());
+
+AsyncErrorServlet asyncErrorServlet =
+new AsyncErrorServlet(HttpServletResponse.SC_BAD_REQUEST);
+Wrapper wrapper =
+Tomcat.addServlet(ctx, asyncErrorServlet, asyncErrorServlet);
+wrapper.setAsyncSupported(true);
+ctx.addServletMapping(/asyncErrorServlet, asyncErrorServlet);
+
+TesterAccessLogValve alv = new TesterAccessLogValve();
+ctx.getPipeline().addValve(alv);
+
+tomcat.start();
+
+StringBuilder url = new StringBuilder(48);
+url.append(http://localhost:;);
+url.append(getPort());
+url.append(/asyncErrorServlet);
+
+int rc = getUrl(url.toString(), new ByteChunk(), null);
+
+assertEquals(HttpServletResponse.SC_BAD_REQUEST, rc);
+
+// Without this test may complete before access log has a chance to log
+// the request
+Thread.sleep(REQUEST_TIME);
+
+// Check the access log
+validateAccessLog(alv, 1, HttpServletResponse.SC_BAD_REQUEST, TIMEOUT,
+TIMEOUT + TIMEOUT_MARGIN + REQUEST_TIME);
+
+}
+
+private static class AsyncErrorServlet extends HttpServlet {
+
+private static final long serialVersionUID = 1L;
+
+private int status = 200;
+
+public AsyncErrorServlet(int status) {
+this.status = status;
+}
+
+@Override
+protected void doGet(HttpServletRequest req, HttpServletResponse resp)
+throws ServletException, IOException {
+
+final AsyncContext actxt = req.startAsync();
+actxt.setTimeout(TIMEOUT);
+actxt.start(new Runnable() {
+@Override
+public void run() {
+try {
+((HttpServletResponse) actxt.getResponse()).sendError(
+status);
+} catch (IOException e) {
+// Ignore
+}
+}
+});
+}
+}
+
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1124342r1=1124341r2=1124342view=diff
DO NOT REPLY [Bug 51197] sendError/sendRedirect don't work with AsyncContext
https://issues.apache.org/bugzilla/show_bug.cgi?id=51197 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas ma...@apache.org 2011-05-18 17:25:38 UTC --- Thanks for the report. This has been fixed in 7.0.x and will be included in 7.0.15 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #3 from Mark Thomas ma...@apache.org 2011-05-18 17:38:13 UTC --- The code referenced above from logback is not licensed in a way that allows it to be used in an ALv2 work in source form. The gc leaks functionality already includes a warning that it may report false positives and that a profiler should be used to determine if there really is a leak. I'd be happy to review an appropriate licensed proposed patch. Without a proposed patch and given the above I am leaning towards closing this as WONTFIX. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124352 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
Author: fhanik
Date: Wed May 18 17:46:01 2011
New Revision: 1124352
URL: http://svn.apache.org/viewvc?rev=1124352view=rev
Log:
make fields volatile
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
Modified:
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java?rev=1124352r1=1124351r2=1124352view=diff
==
---
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
(original)
+++
tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java
Wed May 18 17:46:01 2011
@@ -255,15 +255,15 @@ public class SlowQueryReport extends Abs
};
private final String query;
-private int nrOfInvocations;
-private long maxInvocationTime = Long.MIN_VALUE;
-private long maxInvocationDate;
-private long minInvocationTime = Long.MAX_VALUE;
-private long minInvocationDate;
-private long totalInvocationTime;
-private long failures;
-private int prepareCount;
-private long prepareTime;
+private volatile int nrOfInvocations;
+private volatile long maxInvocationTime = Long.MIN_VALUE;
+private volatile long maxInvocationDate;
+private volatile long minInvocationTime = Long.MAX_VALUE;
+private volatile long minInvocationDate;
+private volatile long totalInvocationTime;
+private volatile long failures;
+private volatile int prepareCount;
+private volatile long prepareTime;
private volatile long lastInvocation = 0;
public static String[] getFieldNames() {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51212] QueryStats has synchornisation issues
https://issues.apache.org/bugzilla/show_bug.cgi?id=51212 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Filip Hanik fha...@apache.org 2011-05-18 17:46:16 UTC --- Fixed in r1124352 no need for atomic, it's a stats collector. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51221] New: Wrong spelling in Spanish locale
https://issues.apache.org/bugzilla/show_bug.cgi?id=51221 Bug #: 51221 Summary: Wrong spelling in Spanish locale Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: enhancement Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: unratito+...@gmail.com Classification: Unclassified There's a property in java/org/apache/tomcat/util/http/res/LocalStrings_es.properties that says: sc.302=Movido tempor\u00e1lmente And it should say: sc.302=Movido temporalmente The word temporalmente does not have an accent, as it can be checked in: http://buscon.rae.es/draeI/SrvltConsulta?TIPO_BUS=3LEMA=temporalmente More information about why this is usually mispelled can be found in: http://buscon.rae.es/dpdI/SrvltGUIBusDPD?lema=tilde2#42 Kind regards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
+1 to Marks proposal. Shot additional answer to Konstantin inline. On 18.05.2011 16:43, Konstantin Kolinko wrote: Will the commit messages be forwarded to the mailing list? At least the web server project does it like that. For an example see http://marc.info/?l=apache-cvsm=130509208030121w=2 regards, Rainer 0xEE8E0DD5.asc Description: application/pgp-keys - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124474 - /tomcat/jk/trunk/native/common/jk_connect.c
Author: timw
Date: Thu May 19 00:15:59 2011
New Revision: 1124474
URL: http://svn.apache.org/viewvc?rev=1124474view=rev
Log:
https://issues.apache.org/bugzilla/show_bug.cgi?id=50839
Cap the lingering bytes read when shutting down an AJP socket at 32k to prevent
CPU spikes reading very large response bodies when a client aborts.
Also reduce the total linger time to 2s by default.
Modified:
tomcat/jk/trunk/native/common/jk_connect.c
Modified: tomcat/jk/trunk/native/common/jk_connect.c
URL:
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_connect.c?rev=1124474r1=1124473r2=1124474view=diff
==
--- tomcat/jk/trunk/native/common/jk_connect.c (original)
+++ tomcat/jk/trunk/native/common/jk_connect.c Thu May 19 00:15:59 2011
@@ -672,9 +672,14 @@ int jk_close_socket(jk_sock_t sd, jk_log
}
#ifndef MAX_SECS_TO_LINGER
-#define MAX_SECS_TO_LINGER 30
+#define MAX_SECS_TO_LINGER 2
+#endif
+#define MS_TO_LINGER 500
+#define MS_TO_LINGER_LAST 2
+
+#ifndef MAX_LINGER_BYTES
+#define MAX_LINGER_BYTES 32768
#endif
-#define SECONDS_TO_LINGER 2
#ifndef SHUT_WR
#ifdef SD_SEND
@@ -710,7 +715,7 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
int rd = 0;
int rp = 0;
int save_errno;
-int timeout = SECONDS_TO_LINGER * 1000;
+int timeout = MS_TO_LINGER;
time_t start = time(NULL);
JK_TRACE_ENTER(l);
@@ -741,6 +746,7 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
}
do {
+rp = 0;
if (jk_is_input_event(sd, timeout, l)) {
/* Do a restartable read on the socket
* draining out all the data currently in the socket buffer.
@@ -772,11 +778,10 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
}
rd += rp;
if (rp sizeof(dummy)) {
-if (timeout SECONDS_TO_LINGER) {
-/* Try once again with 1000 times smaller timeout
- * In our case 2 msec.
- */
-timeout = SECONDS_TO_LINGER;
+if (timeout MS_TO_LINGER_LAST) {
+/* Try one last time with a short timeout
+*/
+timeout = MS_TO_LINGER_LAST;
continue;
}
/* We have read less then size of buffer
@@ -800,8 +805,8 @@ int jk_shutdown_socket(jk_sock_t sd, jk_
shutdown(sd, SHUT_RD);
break;
}
-timeout = SECONDS_TO_LINGER * 1000;
-} while (difftime(time(NULL), start) MAX_SECS_TO_LINGER);
+timeout = MS_TO_LINGER;
+} while ((rd MAX_LINGER_BYTES) (difftime(time(NULL), start)
MAX_SECS_TO_LINGER));
rc = jk_close_socket(sd, l);
if (JK_IS_DEBUG_LEVEL(l))
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
+1 2011/5/18 Mark Thomas ma...@apache.org: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Keiichi.Fujino - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1124476 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
Author: timw Date: Thu May 19 00:20:25 2011 New Revision: 1124476 URL: http://svn.apache.org/viewvc?rev=1124476view=rev Log: Updating changelog for bug #50839 Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1124476r1=1124475r2=1124476view=diff == --- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original) +++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Thu May 19 00:20:25 2011 @@ -44,6 +44,12 @@ br / subsection name=Native changelog + fix +bug50839/bug: Cap the lingering bytes that will be read +when shutting down an AJP socket at 32k to prevent CPU spikes +in the web server when a client aborts on a large response body. +Also reduce total linger time to 2s.(timw) + /fix update Docs: Improve load balancer documentation. (rjung) /update - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 50839] Closing connection on the client side (browser) during unfinished transmission result in 100% CPU slike for 30 sec during socket shutdownd in jk_connect.c
https://issues.apache.org/bugzilla/show_bug.cgi?id=50839 Tim Whittington t...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #8 from Tim Whittington t...@apache.org 2011-05-19 00:23:12 UTC --- I've changed the socket shutdown to limit the amount of lingering bytes (which in an AJP scenario == the remaining response body) to 32k and force a socket shutdown once that limit is reached. I've also shortened the initial poll timeout and reduced the total linger time to 2s to reduce use of web server resources during socket shutdown. Changes will be in 1.2.32 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
