DO NOT REPLY [Bug 51253] New: use_server_errors for status 401 does not forward WWW-Authenticate
https://issues.apache.org/bugzilla/show_bug.cgi?id=51253 Bug #: 51253 Summary: use_server_errors for status 401 does not forward WWW-Authenticate Product: Tomcat Connectors Version: 1.2.31 Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P2 Component: isapi AssignedTo: dev@tomcat.apache.org ReportedBy: rainer.j...@kippdata.de Classification: Unclassified When using server generated error pages (use_server_errors) and status code is 401, we need to forward the original WWW-Authenticate header to the client. For example mod_proxy does it that way. I fixed the problem in r1126561 for mod_jk / Apache. I didn't yet fix it completely for IIS. There is a new TODO in jk_isapi_plugin.c, see start_response(). If anyone likes to fix it for ISAPI, there is already parts of the fix in start_response(), but the missing part is described in the following TODO around line 960: TODO: we need to save a copy of header_values[h] for later reuse in write_error_message() which is called later on form HttpExtensionProc because of use_server_error_pages. Actually I didn't verify the problem for ISAPI, so that might be a good first step. Regards, Rainer -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1126968 - in /tomcat/site/trunk: docs/legal.html xdocs/legal.xml
Author: markt Date: Tue May 24 10:29:49 2011 New Revision: 1126968 URL: http://svn.apache.org/viewvc?rev=1126968view=rev Log: Clarify the language around permitted product names. Modified: tomcat/site/trunk/docs/legal.html tomcat/site/trunk/xdocs/legal.xml Modified: tomcat/site/trunk/docs/legal.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/legal.html?rev=1126968r1=1126967r2=1126968view=diff == --- tomcat/site/trunk/docs/legal.html (original) +++ tomcat/site/trunk/docs/legal.html Tue May 24 10:29:49 2011 @@ -307,8 +307,8 @@ Version 2.0 (current)/a. without the permission of the Apache Tomcat PMC./li liIf you use the words Tomcat or Apache in your product name then you must call your product ... for Apache Tomcat or -... for Tomcat. You may not call your product -Apache ... or Tomcat /li +... for Tomcat. No other form of product name that includes +Tomcat or Apache is permitted./li /ul /p /blockquote /p Modified: tomcat/site/trunk/xdocs/legal.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/legal.xml?rev=1126968r1=1126967r2=1126968view=diff == --- tomcat/site/trunk/xdocs/legal.xml (original) +++ tomcat/site/trunk/xdocs/legal.xml Tue May 24 10:29:49 2011 @@ -60,8 +60,8 @@ Version 2.0 (current)/a. without the permission of the Apache Tomcat PMC./li liIf you use the words Tomcat or Apache in your product name then you must call your product ...#160;for Apache Tomcat or -...#160;for Tomcat. You may not call your product -Apache#160;... or Tomcat#160;/li +...#160;for Tomcat. No other form of product name that includes +Tomcat or Apache is permitted./li /ul /p /section /body - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #6 from Joern Huxhorn jhuxh...@googlemail.com 2011-05-24 11:09:57 UTC --- I disagree. The cleanup performed in the code is merely to prevent a *false* memory leak warning. A real leak does, in fact, not exist. This is the reason why I put it directly before the execution of System.gc() in the Find Leaks function. Since Find Leaks isn't supposed to be executed in a production environment, I don't think that any further optimization (suggestion in 2.) makes sense. It would probably make sense if this code would indeed be added to the normal undeploy procedure but I really don't think that this is necessary or advisable. The idea is to prevent false memory leak warnings so that real ones aren't ignored if they occur. See http://en.wikipedia.org/wiki/The_Boy_Who_Cried_Wolf ;) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #7 from Christopher Schultz ch...@christopherschultz.net 2011-05-24 13:59:07 UTC --- Joern, (In reply to comment #6) The cleanup performed in the code is merely to prevent a *false* memory leak warning. A real leak does, in fact, not exist. This is the reason why I put it directly before the execution of System.gc() in the Find Leaks function. One could argue that a memory leak does, in fact, exist: just because the references will be /eventually/ collected doesn't mean that they won't loiter for quite a long time... unless the GC is getting seriously low on memory, those objects will stick in memory, and so, likely, will the WebappClassLoader, and all of the java.lang.Class objects it manages. I agree with Mark that this feature is best placed into WebappClassLoader and run during it's disposal sequence. Since Find Leaks isn't supposed to be executed in a production environment, I don't think that any further optimization (suggestion in 2.) makes sense. If this will be used in WebappClassLoader, such optimizations should obviously be made. It would probably make sense if this code would indeed be added to the normal undeploy procedure but I really don't think that this is necessary or advisable. This could be implemented as a utility method accessible to both pieces of code, and called directly during a find leaks operation... I would have to look at the find leaks feature to see if that would even be necessary... my sense is that the WCL is disposed before the leaks are detected, so I don't think any changes to the manager app would need to be made. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
LocalXA patch proposition
Hello, I have implemented for Ofbiz a port of DBCP Local XA feature that uses Tomcat JDBC Pool. I would like to contribute this feature to Tomcat JDBC Pool because it seems to me the right place, is it something that interests the project. It would introduce the following compilation dependency: - JTA 1.1 Thank you Regards Philippe
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #8 from Joern Huxhorn jhuxh...@googlemail.com 2011-05-24 14:35:17 UTC --- (In reply to comment #7) Joern, (In reply to comment #6) The cleanup performed in the code is merely to prevent a *false* memory leak warning. A real leak does, in fact, not exist. This is the reason why I put it directly before the execution of System.gc() in the Find Leaks function. One could argue that a memory leak does, in fact, exist: just because the references will be /eventually/ collected doesn't mean that they won't loiter for quite a long time... unless the GC is getting seriously low on memory, those objects will stick in memory, and so, likely, will the WebappClassLoader, and all of the java.lang.Class objects it manages. I agree with Mark that this feature is best placed into WebappClassLoader and run during it's disposal sequence. Alright, I agree that it's better to get rid of a WebappClassLoader as soon as possible instead of waiting for a hard gc caused by low memory. Since Find Leaks isn't supposed to be executed in a production environment, I don't think that any further optimization (suggestion in 2.) makes sense. If this will be used in WebappClassLoader, such optimizations should obviously be made. It's actually pretty hard to implement those optimizations. The keys used in those maps are two static internal classes of ObjectStreamClass. FieldReflectorKey is private and WeakClassKey is package-private. Performing a selective cleanup would involve serious complexity an reflection magic, including lots of assumptions about internal behavior in the hope that it won't change... I'd leave it like it is right now to prevent errors caused by this. My current implementation will simply do nothing if localDescs reflectors are not available or not instances of class ConcurrentHashMap. I don't think that the performance impact is a big thing but I haven't done any benchmarks, either. You should remember that this is exactly what would happen naturally if the memory of the JVM is running low. We are just getting rid of SoftReferences. This would be a problem if performed continuously but doing so once during undeploy shouldn't interfere with other webapps that much. It would probably make sense if this code would indeed be added to the normal undeploy procedure but I really don't think that this is necessary or advisable. This could be implemented as a utility method accessible to both pieces of code, and called directly during a find leaks operation... I would have to look at the find leaks feature to see if that would even be necessary... my sense is that the WCL is disposed before the leaks are detected, so I don't think any changes to the manager app would need to be made. I don't have enough know-how about the way Tomcat functionality is structured. So I just assume you are right. The manager app would likely stay untouched since Find leaks simply checks if the WebappClassLoader has been unloaded properly, if I remember correctly. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1127122 - in /tomcat/trunk: java/org/apache/catalina/ant/ java/org/apache/catalina/manager/ webapps/docs/
Author: markt
Date: Tue May 24 16:04:08 2011
New Revision: 1127122
URL: http://svn.apache.org/viewvc?rev=1127122view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51226
Add a findleaks Ant task for the Manager app.
Based on a patch by Eiji Takahashi
Added:
tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java (with props)
Modified:
tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java
tomcat/trunk/webapps/docs/manager-howto.xml
Added: tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java?rev=1127122view=auto
==
--- tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java (added)
+++ tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java Tue May 24
16:04:08 2011
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the License); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.ant;
+
+import org.apache.tools.ant.BuildException;
+
+/**
+ * Ant task that implements the code/findleaks/code command, supported by
+ * the Tomcat manager application.
+ */
+public class FindLeaksTask extends AbstractCatalinaTask {
+
+private boolean statusLine = true;
+
+/**
+ * Sets the statusLine parameter that controls if the response includes a
+ * status line or not.
+ */
+public void setStatusLine(boolean statusLine) {
+this.statusLine = statusLine;
+}
+
+/**
+ * Returns the statusLine parameter that controls if the response includes
a
+ * status line or not.
+ */
+public boolean getStatusLine() {
+return statusLine;
+}
+
+/**
+ * Execute the requested operation.
+ *
+ * @exception BuildException if an error occurs
+ */
+@Override
+public void execute() throws BuildException {
+
+super.execute();
+execute(/findleaks?statusLine= + Boolean.toString(statusLine));
+}
+
+}
Propchange: tomcat/trunk/java/org/apache/catalina/ant/FindLeaksTask.java
--
svn:eol-style = native
Modified: tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java?rev=1127122r1=1127121r2=1127122view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java Tue
May 24 16:04:08 2011
@@ -772,11 +772,16 @@ public final class HTMLManagerServlet ex
StringWriter stringWriter = new StringWriter();
PrintWriter printWriter = new PrintWriter(stringWriter);
-super.findleaks(printWriter, smClient);
+super.findleaks(false, printWriter, smClient);
-if (stringWriter.getBuffer().length() 0) {
-msg.append(smClient.getString(htmlManagerServlet.findleaksList));
-msg.append(stringWriter.toString());
+String writerText = stringWriter.toString();
+
+if (writerText.length() 0) {
+if (!writerText.startsWith(FAIL -)) {
+msg.append(smClient.getString(
+htmlManagerServlet.findleaksList));
+}
+msg.append(writerText);
} else {
msg.append(smClient.getString(htmlManagerServlet.findleaksNone));
}
Modified: tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties?rev=1127122r1=1127121r2=1127122view=diff
==
--- tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/manager/LocalStrings.properties Tue
May 24 16:04:08 2011
@@ -75,6
DO NOT REPLY [Bug 51226] [Patch] to add FindLeaks ant task
https://issues.apache.org/bugzilla/show_bug.cgi?id=51226 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Mark Thomas ma...@apache.org 2011-05-24 16:05:16 UTC --- Thanks for the updated patch. I have applied it with the following changes to 7.0.x and it will be included in 7.0.15 onwards. - renamed query parameter to statusLine for consistency - made statusLine configurable in Ant task - added a status response if no leaking apps were found - added some documentation Thanks again for the patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
On 18/05/2011 17:33, William A. Rowe Jr. wrote: On 5/18/2011 9:22 AM, Mark Thomas wrote: On 18/05/2011 15:06, Konstantin Kolinko wrote: 2011/5/18 Mark Thomas ma...@apache.org: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit hook would update the /dist/tomcat area on the www servers immediately. If folks would like to go this route, I am happy to do the work on our end to migrate /dist/tomcat to svnpubsub. 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo https://dist.apache.org/repos/dist/... dev and release, with tomcat as a new tree under each. Ah. I had forgotten our dev dist dir. This is currently: http://tomcat.apache.org/dev/dist/ Given the age of the items there, I propose that the contents of that dir are not retained when we move to svnpusub for dist. Assuming no objections, I'll progress this with infra in the next week or so. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1127149 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue May 24 17:17:07 2011 New Revision: 1127149 URL: http://svn.apache.org/viewvc?rev=1127149view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1127149r1=1127148r2=1127149view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 24 17:17:07 2011 @@ -186,3 +186,11 @@ PATCHES PROPOSED TO BACKPORT: http://svn.apache.org/viewvc?rev=1124757view=rev (fixes copy/paste error) +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 + Make Tomcat more robust if an OOME occurs. Yes, after an OOME all bets are off + but this patch appears to help some users and the description of a + 'recoverable' OOME in the bug is a plausible one. + http://svn.apache.org/viewvc?rev=1099575view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1127150 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue May 24 17:18:19 2011 New Revision: 1127150 URL: http://svn.apache.org/viewvc?rev=1127150view=rev Log: Add attribution. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1127150r1=1127149r2=1127150view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 24 17:18:19 2011 @@ -191,6 +191,7 @@ PATCHES PROPOSED TO BACKPORT: Make Tomcat more robust if an OOME occurs. Yes, after an OOME all bets are off but this patch appears to help some users and the description of a 'recoverable' OOME in the bug is a plausible one. + Patch provided by Ramiro http://svn.apache.org/viewvc?rev=1099575view=rev +1: markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51124] ArrayIndexOutOfBoundsException after setting org.apache.jasper.runtime.BodyContentImpl.LIMIT_BUFFER=true
https://issues.apache.org/bugzilla/show_bug.cgi?id=51124 --- Comment #8 from Mark Thomas ma...@apache.org 2011-05-24 17:18:55 UTC --- Thanks for the feedback. I have proposed the patch for 6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: LocalXA patch proposition
hi Philippe, open a bugzilla item https://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Modules Add your patch there, and I will happily take a look thanks for contributing Filip On 5/24/2011 8:31 AM, Philippe Mouawad wrote: Hello, I have implemented for Ofbiz a port of DBCP Local XA feature that uses Tomcat JDBC Pool. I would like to contribute this feature to Tomcat JDBC Pool because it seems to me the right place, is it something that interests the project. It would introduce the following compilation dependency: - JTA 1.1 Thank you Regards Philippe - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1375 / Virus Database: 1509/3655 - Release Date: 05/23/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
2011/5/24 Mark Thomas ma...@apache.org: 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo https://dist.apache.org/repos/dist/... dev and release, with tomcat as a new tree under each. Ah. I had forgotten our dev dist dir. This is currently: http://tomcat.apache.org/dev/dist/ Given the age of the items there, I propose that the contents of that dir are not retained when we move to svnpusub for dist. Those are not released files. +1 to remove them at any moment. I see there some Maven files there, including 6.0.32. http://tomcat.apache.org/dev/dist/m2-repository/ I think (as 6.0.32 should already be elsewhere) the subdirectories inside of m2-repository can be removed and recreated when preparing 6.0.33 release (if they are needed e.g. as a staging area). Anyway, the current scope is dist at www.apache.org, which does not interfere with the area on tomcat.apache.org. Assuming no objections, I'll progress this with infra in the next week or so. Good. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51195] Find leaks reports a false positive memory/classloader leak
https://issues.apache.org/bugzilla/show_bug.cgi?id=51195 --- Comment #9 from Sylvain Laurent slaur...@apache.org 2011-05-24 20:17:19 UTC --- just my 2cts : I'm leaning towards Joern point of view, that cleaning the ObjectStreamClass cache should be done during the Find Leaks action rather than when stopping the webapp. This way we do not impact other webapps when stopping one. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat
On 24/05/2011 20:24, Konstantin Kolinko wrote: 2011/5/24 Mark Thomas ma...@apache.org: 1. In what repository will the artifacts go? IIRC, there is some additional repository. I think it wouldn't be good to have them in /repos/asf/ There is a separate /dist repo https://dist.apache.org/repos/dist/... dev and release, with tomcat as a new tree under each. Ah. I had forgotten our dev dist dir. This is currently: http://tomcat.apache.org/dev/dist/ Given the age of the items there, I propose that the contents of that dir are not retained when we move to svnpusub for dist. Those are not released files. +1 to remove them at any moment. I see there some Maven files there, including 6.0.32. http://tomcat.apache.org/dev/dist/m2-repository/ I think (as 6.0.32 should already be elsewhere) the subdirectories inside of m2-repository can be removed and recreated when preparing 6.0.33 release (if they are needed e.g. as a staging area). Anyway, the current scope is dist at www.apache.org, which does not interfere with the area on tomcat.apache.org. Sort of. The normal usage pattern for svnpubsub for /dist is that tomcat.apache.org/dev/dist and www.apache.org/dist/tomcat both move at the same time. Hence my proposal that when we move we drop whatever is currently in tomcat.apache.org/dev/dist Mark Assuming no objections, I'll progress this with infra in the next week or so. Good. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51259] New: Local XA feature
https://issues.apache.org/bugzilla/show_bug.cgi?id=51259 Bug #: 51259 Summary: Local XA feature Product: Tomcat Modules Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: p.moua...@ubik-ingenierie.com Classification: Unclassified Hello, As proposed by Philip Hanik on mailing list, I open the bug. I have implemented for Ofbiz a port of DBCP Local XA feature that uses Tomcat JDBC Pool. I would like to contribute this feature to Tomcat JDBC Pool because it seems to me the right place. It would introduce the following compilation dependency:JTA 1.1 Philippe http://www.ubik-ingenierie.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51259] Local XA feature
https://issues.apache.org/bugzilla/show_bug.cgi?id=51259 --- Comment #1 from Philippe Mouawad p.moua...@ubik-ingenierie.com 2011-05-24 20:24:56 UTC --- Created attachment 27054 -- https://issues.apache.org/bugzilla/attachment.cgi?id=27054 The implementation AS for now patch requires a JDK6 compilation because of DelegatingConnection. I think this will maybe an issue for you. If you see a way to improve this, I will be happy to implement it. Regards Philippe -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51259] Local XA feature
https://issues.apache.org/bugzilla/show_bug.cgi?id=51259 Philippe Mouawad p.moua...@ubik-ingenierie.com changed: What|Removed |Added CC||p.mouawad@ubik-ingenierie.c ||om -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: LocalXA patch proposition
Hi Philip, I opened bug 51259https://issues.apache.org/bugzilla/show_bug.cgi?id=51259 . Thank you Regards Philippe On Tue, May 24, 2011 at 7:55 PM, Filip Hanik - Dev Lists devli...@hanik.com wrote: hi Philippe, open a bugzilla item https://issues.apache.org/bugzilla/enter_bug.cgi?product=Tomcat%20Modules Add your patch there, and I will happily take a look thanks for contributing Filip On 5/24/2011 8:31 AM, Philippe Mouawad wrote: Hello, I have implemented for Ofbiz a port of DBCP Local XA feature that uses Tomcat JDBC Pool. I would like to contribute this feature to Tomcat JDBC Pool because it seems to me the right place, is it something that interests the project. It would introduce the following compilation dependency: - JTA 1.1 Thank you Regards Philippe - No virus found in this message. Checked by AVG - www.avg.com Version: 10.0.1375 / Virus Database: 1509/3655 - Release Date: 05/23/11 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Cordialement. Philippe Mouawad. Ubik-Ingénierie
DO NOT REPLY [Bug 51259] Local XA feature
https://issues.apache.org/bugzilla/show_bug.cgi?id=51259 Filip Hanik fha...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #2 from Filip Hanik fha...@apache.org 2011-05-24 20:51:08 UTC --- Hi Philippe, take some time and study the implementation. we don't implement any java.sql interfaces, there is no need to. we use proxies instead. that way we don't tie ourselves to an implementation. the only interface we do implement is the javax.sql.DataSource, but we do it in such a way that it will compile on all versions. The patch you proposed is not aligned with the style of jdbc-pool, but with the style of dbcp. we don't wrap layers of java.sql.Connection, we just implement interceptors. This patch, would break that portion of it. So I'm marking wontfix, so you can submit a better patch. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51260] New: ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable
https://issues.apache.org/bugzilla/show_bug.cgi?id=51260
Bug #: 51260
Summary: ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable
Product: Tomcat 7
Version: 7.0.14
Platform: PC
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: dchecko...@gmail.com
Classification: Unclassified
Because of a logical condition ordering issue in ServerCookie.java, setting
ALLOW_HTTP_SEPARATORS_IN_V0=true does not work 100% of the time.
Here's a patch:
Index: java/org/apache/tomcat/util/http/ServerCookie.java
===
--- java/org/apache/tomcat/util/http/ServerCookie.java (revision 1127279)
+++ java/org/apache/tomcat/util/http/ServerCookie.java (working copy)
@@ -289,10 +289,8 @@
buf.append('');
buf.append(escapeDoubleQuotes(value,1,value.length()-1));
buf.append('');
-} else if (CookieSupport.isHttpToken(value)
-!CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0 ||
-CookieSupport.isV0Token(value)
-CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0) {
+} else if ((!CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0
CookieSupport.isHttpToken(value)) ||
+ (CookieSupport.ALLOW_HTTP_SEPARATORS_IN_V0
CookieSupport.isV0Token(value))) {
buf.append('');
buf.append(escapeDoubleQuotes(value,0,value.length()));
buf.append('');
(added some parentheses in there as per tongue-in-cheek discussion on tomcat
users list)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51260] ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable
https://issues.apache.org/bugzilla/show_bug.cgi?id=51260 --- Comment #1 from Dan Checkoway dchecko...@gmail.com 2011-05-24 21:39:55 UTC --- BTW, I forgot to mention a key piece of info...the code works as is, but the problem occurs when isHttpToken-isHttpSeparator throws an exception when it encounters a control character. If ALLOW_HTTP_SEPARATORS_IN_V0 is set to true, that code should never get invoked in the first place (at least not imho). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51260] ALLOW_HTTP_SEPARATORS_IN_V0 not 100% reliable
https://issues.apache.org/bugzilla/show_bug.cgi?id=51260 Dan Checkoway dchecko...@gmail.com changed: What|Removed |Added CC||dchecko...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml
Author: schultz Date: Tue May 24 22:02:27 2011 New Revision: 1127315 URL: http://svn.apache.org/viewvc?rev=1127315view=rev Log: Added detailed information about what SSL variables will be sent to Tomcat when JkExtractSSL is enabled. Modified: tomcat/jk/trunk/xdocs/reference/apache.xml Modified: tomcat/jk/trunk/xdocs/reference/apache.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/reference/apache.xml?rev=1127315r1=1127314r2=1127315view=diff == --- tomcat/jk/trunk/xdocs/reference/apache.xml (original) +++ tomcat/jk/trunk/xdocs/reference/apache.xml Tue May 24 22:02:27 2011 @@ -271,7 +271,48 @@ The default value is On. In order to make SSL data available for mod_jk in Apache, you need to set codeSSLOptions +StdEnvVars/code. For the certificate information you also need to add codeSSLOptions +ExportCertData/code. -/p/attribute +/p +p + Specifically, mod_jk will export the following environment variables from + Apache httpd to Tomcat under these request attributes as per the + Servlet Specification 3.0, section 3.8: +/p +table + trthEnv Var/ththRequest Attribute Name/ththType/ththExample/th/tr + tr +tdSSL_CIPHERbr/(or codeJkKEYSIZEIndicator/code)/td +tdjavax.servlet.request.cipher_suite/td +tdjava.lang.String/td +tdDHE-RSA-AES256-SHA/td + /tr + tr +tdSSL_CIPHER_USEKEYSIZEbr/(or codeJkKEYSIZEIndicator/code)/td +tdjavax.servlet.request.key_size/td +tdjava.lang.Integer/td +td256/td + /tr + tr +tdSSL_SESSION_IDbr/(or codeJkSESSIONIndicator/code)/td +tdjavax.servlet.request.ssl_session/td +tdjava.lang.String/td +td905...32E (a hex string)/td + /tr + tr +tdSSL_CLIENT_CERT_CHAIN_in/ibr/(or codeJkCERTCHAINPrefix/codein/i)/td +tdjavax.servlet.request.X509Certificate/td +tdjava.security.X509Certificate[]/td +td(A chain of certs in ascending order of trust, the first one being +ths client's certificate, the second being the signer of that +certificate, and so on)/td + /tr +/table +p + For all other SSL-related variables, use codeJkEnvVar/code for each + variable you want. Please note that, like codeJkEnvVar/code, these + variables are available from the request ibattributes/b/i, not as + environment variables or as request headers. +/p +/attribute attribute name=JkHTTPSIndicator required=falsep Name of the Apache environment variable that contains SSL indication. br/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml
All, I'm not sure what the policy is on documentation changes and back-porting to already-released versions of mod_jk, but this clarifies how mod_jk works and would be beneficial to have on the web site without having to wait for a new release of mod_jk. Is there a good way to do that, or should we just wait for a new release? Thanks, -chris On 5/24/2011 6:02 PM, schu...@apache.org wrote: Author: schultz Date: Tue May 24 22:02:27 2011 New Revision: 1127315 URL: http://svn.apache.org/viewvc?rev=1127315view=rev Log: Added detailed information about what SSL variables will be sent to Tomcat when JkExtractSSL is enabled. Modified: tomcat/jk/trunk/xdocs/reference/apache.xml Modified: tomcat/jk/trunk/xdocs/reference/apache.xml URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/reference/apache.xml?rev=1127315r1=1127314r2=1127315view=diff == --- tomcat/jk/trunk/xdocs/reference/apache.xml (original) +++ tomcat/jk/trunk/xdocs/reference/apache.xml Tue May 24 22:02:27 2011 @@ -271,7 +271,48 @@ The default value is On. In order to make SSL data available for mod_jk in Apache, you need to set codeSSLOptions +StdEnvVars/code. For the certificate information you also need to add codeSSLOptions +ExportCertData/code. -/p/attribute +/p +p + Specifically, mod_jk will export the following environment variables from + Apache httpd to Tomcat under these request attributes as per the + Servlet Specification 3.0, section 3.8: +/p +table + trthEnv Var/ththRequest Attribute Name/ththType/ththExample/th/tr + tr +tdSSL_CIPHERbr/(or codeJkKEYSIZEIndicator/code)/td +tdjavax.servlet.request.cipher_suite/td +tdjava.lang.String/td +tdDHE-RSA-AES256-SHA/td + /tr + tr +tdSSL_CIPHER_USEKEYSIZEbr/(or codeJkKEYSIZEIndicator/code)/td +tdjavax.servlet.request.key_size/td +tdjava.lang.Integer/td +td256/td + /tr + tr +tdSSL_SESSION_IDbr/(or codeJkSESSIONIndicator/code)/td +tdjavax.servlet.request.ssl_session/td +tdjava.lang.String/td +td905...32E (a hex string)/td + /tr + tr +tdSSL_CLIENT_CERT_CHAIN_in/ibr/(or codeJkCERTCHAINPrefix/codein/i)/td +tdjavax.servlet.request.X509Certificate/td +tdjava.security.X509Certificate[]/td +td(A chain of certs in ascending order of trust, the first one being +ths client's certificate, the second being the signer of that +certificate, and so on)/td + /tr +/table +p + For all other SSL-related variables, use codeJkEnvVar/code for each + variable you want. Please note that, like codeJkEnvVar/code, these + variables are available from the request ibattributes/b/i, not as + environment variables or as request headers. +/p +/attribute attribute name=JkHTTPSIndicator required=falsep Name of the Apache environment variable that contains SSL indication. br/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org signature.asc Description: OpenPGP digital signature
DO NOT REPLY [Bug 43968] [patch] support ipv6 with mod_jk
https://issues.apache.org/bugzilla/show_bug.cgi?id=43968 forfelicity hysunny2...@gmail.com changed: What|Removed |Added CC||hysunny2...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 51261] New: JK cannt support ipv6
https://issues.apache.org/bugzilla/show_bug.cgi?id=51261 Bug #: 51261 Summary: JK cannt support ipv6 Product: Tomcat Connectors Version: 1.2.30 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: mod_jk AssignedTo: dev@tomcat.apache.org ReportedBy: hysunny2...@gmail.com Classification: Unclassified Dear all: When I used jk_mod to connect Tomcat5 and Apache2,it logged that as the following: [Sat May 08 12:15:40 2010] [3412:3312] [debug] jk_ajp_common.c (2512): worker tomcat1 contact is '2001:da8:207:5338:224:1dff:fe86:46da:7009' [Sat May 08 12:15:40 2010] [3412:3312] [error] jk_ajp_common.c (2526): worker tomcat1 can't resolve tomcat address 2001:da8:207:5338:224:1dff:fe86:46da I saw this ploblem in bug:43968, and i tied to change the source(1.2.27v) but i found that the original code and the the source(1.2.27v) are not equal.Such as jk_connect.c:jk_open_socket. Thanks. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
