svn commit: r1215115 - /tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java
Author: markt Date: Fri Dec 16 13:11:31 2011 New Revision: 1215115 URL: http://svn.apache.org/viewvc?rev=1215115view=rev Log: Correct test Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java?rev=1215115r1=1215114r2=1215115view=diff == --- tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java (original) +++ tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java Fri Dec 16 13:11:31 2011 @@ -307,7 +307,7 @@ public class TestParser extends TomcatBa String result = res.toString(); // Beware of the differences between escaping in JSP attributes and // in Java Strings -assertEcho(result, 00 - \\% % \\%); +assertEcho(result, 00 - \\% % %); } /** Assertion for text printed by tags:echo */ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215118 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestParser.java webapp-3.0/bug52335.jsp
Author: markt Date: Fri Dec 16 13:12:23 2011 New Revision: 1215118 URL: http://svn.apache.org/viewvc?rev=1215118view=rev Log: Extend the test case Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java tomcat/trunk/test/webapp-3.0/bug52335.jsp Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java?rev=1215118r1=1215117r2=1215118view=diff == --- tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java (original) +++ tomcat/trunk/test/org/apache/jasper/compiler/TestParser.java Fri Dec 16 13:12:23 2011 @@ -308,6 +308,8 @@ public class TestParser extends TomcatBa // Beware of the differences between escaping in JSP attributes and // in Java Strings assertEcho(result, 00 - \\% % %); +assertEcho(result, 01 - b%/b); +assertEcho(result, 02 - pFoo/p%); } /** Assertion for text printed by tags:echo */ Modified: tomcat/trunk/test/webapp-3.0/bug52335.jsp URL: http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0/bug52335.jsp?rev=1215118r1=1215117r2=1215118view=diff == --- tomcat/trunk/test/webapp-3.0/bug52335.jsp (original) +++ tomcat/trunk/test/webapp-3.0/bug52335.jsp Fri Dec 16 13:12:23 2011 @@ -14,11 +14,13 @@ See the License for the specific language governing permissions and limitations under the License. --% -%@ page isELIgnored=true % +%@ taglib prefix=tags tagdir=/WEB-INF/tags % html headtitleBug 52335 test case/title/head body p00 - \% \\% \%/p +p01 - b\%/b/p +p02 - tags:echo echo=Foo /\%/p /body /html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215119 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Author: markt
Date: Fri Dec 16 13:13:00 2011
New Revision: 1215119
URL: http://svn.apache.org/viewvc?rev=1215119view=rev
Log:
Revert fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=52335
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=1215119r1=1215118r2=1215119view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Fri Dec 16
13:13:00 2011
@@ -1297,33 +1297,8 @@ class Parser implements TagConstants {
while (reader.hasMoreInput()) {
ch = reader.nextChar();
if (ch == '') {
-// Check for \%
-ch = reader.nextChar();
-if (ch == -1) {
-reader.pushChar();
-break;
-} else if (ch == '\\') {
-ch = reader.nextChar();
-if (ch == -1) {
-reader.pushChar();
-reader.pushChar();
-break;
-} else if (ch == '%') {
-ttext.write('');
-ttext.write('\\');
-ttext.write('%');
-continue;
-} else {
-reader.pushChar();
-reader.pushChar();
-reader.pushChar();
-break;
-}
-} else {
-reader.pushChar();
-reader.pushChar();
-break;
-}
+reader.pushChar();
+break;
} else if ((ch == '$' || ch == '#') !pageInfo.isELIgnored()) {
if (!reader.hasMoreInput()) {
ttext.write(ch);
@@ -1343,9 +1318,9 @@ class Parser implements TagConstants {
break;
}
char next = (char) reader.peekChar();
-// Looking for \$ or \# when EL is being used
-if ((next == '$' || next == '#')
-!pageInfo.isELIgnored()) {
+// Looking for \% or \$ or \#
+if (next == '%' || ((next == '$' || next == '#')
+!pageInfo.isELIgnored())) {
ch = reader.nextChar();
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215121 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Author: markt
Date: Fri Dec 16 13:13:36 2011
New Revision: 1215121
URL: http://svn.apache.org/viewvc?rev=1215121view=rev
Log:
Better fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=52335
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Parser.java?rev=1215121r1=1215120r2=1215121view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Parser.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Parser.java Fri Dec 16
13:13:36 2011
@@ -1295,6 +1295,7 @@ class Parser implements TagConstants {
}
while (reader.hasMoreInput()) {
+int prev = ch;
ch = reader.nextChar();
if (ch == '') {
reader.pushChar();
@@ -1319,8 +1320,9 @@ class Parser implements TagConstants {
}
char next = (char) reader.peekChar();
// Looking for \% or \$ or \#
-if (next == '%' || ((next == '$' || next == '#')
-!pageInfo.isELIgnored())) {
+if ((prev == '' next == '%') ||
+((next == '$' || next == '#')
+!pageInfo.isELIgnored())) {
ch = reader.nextChar();
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215122 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp
Author: markt Date: Fri Dec 16 13:14:50 2011 New Revision: 1215122 URL: http://svn.apache.org/viewvc?rev=1215122view=rev Log: Correct fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Parser.java tomcat/tc7.0.x/trunk/test/org/apache/jasper/compiler/TestParser.java tomcat/tc7.0.x/trunk/test/webapp-3.0/bug52335.jsp Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Fri Dec 16 13:14:50 2011 @@ -1 +1 @@ -/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096 ,1173241,1173256,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175798,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178684,1178721,1179268,1179274,1180261,1180865,1180891,1180894,1180907,1181028,1181123,1181125,1181136,1181291,1181743,1182796,1183078,1183105,1183142,1183328,1183339-1183340,1183492-1183494,1183605,1184917,1184919,1185018,1185020,1185200,1185588,1185626,1185756,1185758,1186011,1186042-1186045,1186104,1186123,1186137,1186153,1186254,1186257,1186377-1186379,1186479-1186480,1186712,1186743,1186750,1186763,1186890-1186892,1186894,1186949,1187018,1187027-1187028,1187381,1187 753,1187755,1187775,1187801,1187806,1187809,1187827,1188301,1188303-1188305,1188399,1188822,1188930-1188931,1189116,1189129,1189183,1189240,1189256,1189386,1189413-1189414,1189477,1189685,1189805,1189857,1189864,1189882,1190034,1190185,1190279,1190339,1190371,1190388-1190389,1190474,1190481,1194915,1195222-1195223,1195531,1195899,1195905,1195943,1195949,1195953,1195955,1195965,1195968,1196175,1196212,1196223,1196304-1196305,1196735,1196825,1196827,1197158,1197261,1197263,1197299-1197300,1197305,1197339-1197340,1197343,1197382,1197386-1197387,1197480,1197578,1198497,1198528,1198552,1198602,1198604,1198607,1198622,1198640,1198696,1198707,1199418,1199432,1199436,1199513,1199529,1199980,116,1200056,1200089,1200106-1200107,1200263,1200316,1200320,1200398-1200399,1200445-1200446,1200555,1200627,1200696,1200725,1200937,1200941,1201069,1201087,1201180,1201235-1201237,1201508,1201521,1201542,1201545-1201546,1201548,1201555-1201556,1201568,1201576,1201608,1201921-1201922,1201931,1 202035,1202039,1202271,1202565,1202578,1202705,1202828,1202860,1203047-1203052,1203078,1203091,1203253,1203278,1204182,1204856,1204867,1204936,1204938,1204982,1205033,1205065,1205082,1205097,1205112,1206200,1207692,1208046,1208073,1208096,1208114,1208145,1208772,1209194,1209277-1209278,1209686-1209731,1210894,1212091,1212095,1212099,1212118,1213469,1213906,1214853,1214855,1214864
svn commit: r1215124 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 13:15:36 2011 New Revision: 1215124 URL: http://svn.apache.org/viewvc?rev=1215124view=rev Log: Update proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1215124r1=1215123r2=1215124view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 16 13:15:36 2011 @@ -139,7 +139,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. - http://svn.apache.org/viewvc?rev=1214855view=rev + http://svn.apache.org/viewvc?rev=1215121view=rev +1: markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215125 - /tomcat/tc5.5.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 13:15:59 2011 New Revision: 1215125 URL: http://svn.apache.org/viewvc?rev=1215125view=rev Log: Update proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1215125r1=1215124r2=1215125view=diff == --- tomcat/tc5.5.x/trunk/STATUS.txt (original) +++ tomcat/tc5.5.x/trunk/STATUS.txt Fri Dec 16 13:15:59 2011 @@ -113,6 +113,6 @@ PATCHES PROPOSED TO BACKPORT: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. - http://svn.apache.org/viewvc?rev=1214855view=rev + http://svn.apache.org/viewvc?rev=1215121view=rev +1: markt -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1214855 - in /tomcat/trunk: java/org/apache/jasper/compiler/Parser.java test/org/apache/jasper/compiler/TestParser.java test/webapp-3.0/bug52335.jsp
On 15/12/2011 23:22, ma...@apache.org wrote: Konstantin Kolinko knst.koli...@gmail.com wrote: 1. The test fix is wrong. \% should print % 2. Note // Output the first character comment in parseTemplateText(). That is special handling of the first character. My understanding of the code before this change is that the loop in parseTemplateText() always breaks when '' is encountered. I think that when that '' is not start of a tag and similar, then parseTemplateText() is just called again. On this second call the '' will be the first character and that is why it is handled specially before the loop. (That is just from code review. I have not tried to debug it yet). snip/ Yep, brain not fully engaged when I made that change. I'll try and look at this again tomorrow. Feel free to revert my fix in the meantime. Should be fixed properly now. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Reporter: Morten Haraldsen Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
[ https://issues.apache.org/jira/browse/MTOMCAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170976#comment-13170976 ] Morten Haraldsen commented on MTOMCAT-109: -- This is effectively blocking usage of this plugin for application relying on Comet connections (Does not scale with blocking I/O) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Reporter: Morten Haraldsen Original Estimate: 1h Remaining Estimate: 1h Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brad Giaccio updated MTOMCAT-108: - Attachment: https.patch I've tested this patch on Mac OSX 10.6.8, Fedora Core 16, and Redhat Linux 5.4 It handles, httpPort not being set so only https starts up it adds 3 options to the startup -keyAlias -clientAuth It checks for the 6 -Djavax.net.ssl properties for setting up key and trust stores I also added PasswordUtil to allow the passwords to be obfuscated (a security requirement for some systems is no passwords in clear text ... I know obfuscation is like closing your front door and hoping know one uses the peep hole). I've confirmed function as best I can with and without http turned on and with and without clientAuth. It appears to be working correctly. THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Attachments: https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MTOMCAT-108: - Fix Version/s: 2.0 THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Updated] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
[ https://issues.apache.org/jira/browse/MTOMCAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MTOMCAT-109: - Affects Version/s: 2.0 Fix Version/s: 2.0 Assignee: Olivier Lamy need a new parameter for that. protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Affects Versions: 2.0 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 Original Estimate: 1h Remaining Estimate: 1h Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
[ https://issues.apache.org/jira/browse/MTOMCAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170995#comment-13170995 ] Olivier Lamy commented on MTOMCAT-109: -- do you prefer something configurable tru cli when running your jar or something in the mojo which build the jar ? (perso I prefer 2) ) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Affects Versions: 2.0 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 Original Estimate: 1h Remaining Estimate: 1h Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13170996#comment-13170996 ] Olivier Lamy commented on MTOMCAT-108: -- @Brad looks a good patch. Note the maven plugin use the maven code formatting: http://maven.apache.org/developers/conventions/code.html THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215161 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 14:50:23 2011 New Revision: 1215161 URL: http://svn.apache.org/viewvc?rev=1215161view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1215161r1=1215160r2=1215161view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 16 14:50:23 2011 @@ -132,7 +132,7 @@ PATCHES PROPOSED TO BACKPORT: * Fix the maven stuff for the maven repo. Before it does't find tomcat-juli.jar and the wagon-ssh was a broken old version. http://people.apache.org/~jfclere/patches/maven.patch.29 - +1: jfclere, kkolinko + +1: jfclere, kkolinko, markt -1: kkolinko: In description of jarFileDir attribute: s/if not same as artifactId/if not same as tomcat.lib.path/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215162 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 14:51:58 2011 New Revision: 1215162 URL: http://svn.apache.org/viewvc?rev=1215162view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1215162r1=1215161r2=1215162view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 16 14:51:58 2011 @@ -126,7 +126,7 @@ PATCHES PROPOSED TO BACKPORT: * Update Commons Daemon to 1.0.8 Change is trivial so no patch provided - +1: mturk + +1: mturk, markt -1: * Fix the maven stuff for the maven repo. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215167 - in /tomcat/tc6.0.x/trunk: res/maven/mvn-pub.xml webapps/docs/changelog.xml
Author: markt
Date: Fri Dec 16 14:55:15 2011
New Revision: 1215167
URL: http://svn.apache.org/viewvc?rev=1215167view=rev
Log:
Fix the publishing side of
https://issues.apache.org/bugzilla/show_bug.cgi?id=52124
Modified:
tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml?rev=1215167r1=1215166r2=1215167view=diff
==
--- tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml Fri Dec 16 14:55:15 2011
@@ -65,7 +65,7 @@
pathelement location=${basedir}/maven-artifact-ant-2.0.4-dep.jar /
/classpath
/typedef
-artifact:install-provider artifactId=wagon-ssh version=1.0-beta-2/
+artifact:install-provider artifactId=wagon-ssh version=1.0-beta-6/
/target
target name=maven-deploy depends=init-maven
@@ -120,9 +120,10 @@
macrodef name=doMavenDeploy
attribute name=artifactId/
attribute name=jarFileName default=@{artifactId}.jar
description=only need to be specified if not same as artifactId/
+attribute name=jarFileDir default=${tomcat.lib.path}
description=only need to be specified if not same as artifactId/
sequential
antcall target=maven-deploy
-param name=file value=${tomcat.lib.path}/@{jarFileName}/
+param name=file value=@{jarFileDir}/@{jarFileName}/
param name=groupId value=org.apache.tomcat/
param name=artifactId value=@{artifactId}/
param name=pom value=${tomcat.pom.path}/@{artifactId}.pom/
@@ -135,7 +136,7 @@
doMavenDeploy artifactId=servlet-api/ !--Deploy Servlet api--
doMavenDeploy artifactId=el-api/ !--Deploy expression lanaguage api--
doMavenDeploy artifactId=jsp-api/ !--Deploy JSP api--
-doMavenDeploy artifactId=juli jarFileName=tomcat-juli.jar/
!--Deploy JULI--
+doMavenDeploy artifactId=juli jarFileName=tomcat-juli.jar
jarFileDir=${tomcat.bin.path}/ !--Deploy JULI--
doMavenDeploy artifactId=tribes jarFileName=catalina-tribes.jar/
!--Deploy Tribes--
doMavenDeploy artifactId=jasper-el/ !--Deploy Jasper EL--
doMavenDeploy artifactId=coyote jarFileName=tomcat-coyote.jar/
!--Deploy Coyote--
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1215167r1=1215166r2=1215167view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Dec 16 14:55:15 2011
@@ -52,6 +52,14 @@
/fix
/changelog
/subsection
+ subsection name=Other
+changelog
+ fix
+bug52124/bug: Ensure Maven publishing process retains metadata for
+previous releases. (jfclere)
+ /fix
+/changelog
+ /subsection
/section
section name=Tomcat 6.0.34 (jfclere) rtext=not released
subsection name=Catalina
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Move to Nexus with no community discussion. WTF?
It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. Right now, I am a few mouse clicks away from requesting that the infrastructure team revert this change. Mark [1] https://issues.apache.org/jira/browse/INFRA-4162 [2] http://www.apache.org/dev/publishing-maven-artifacts.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52124] Tomcat Maven metadata only includes the latest release
https://issues.apache.org/bugzilla/show_bug.cgi?id=52124 --- Comment #3 from Mark Thomas ma...@apache.org 2011-12-16 15:23:33 UTC --- Patch applied. Leaving this open as the historical metadata needs to be fixed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215179 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 15:24:16 2011 New Revision: 1215179 URL: http://svn.apache.org/viewvc?rev=1215179view=rev Log: Remove applied patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1215179r1=1215178r2=1215179view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 16 15:24:16 2011 @@ -129,14 +129,6 @@ PATCHES PROPOSED TO BACKPORT: +1: mturk, markt -1: -* Fix the maven stuff for the maven repo. - Before it does't find tomcat-juli.jar and the wagon-ssh was a broken old version. - http://people.apache.org/~jfclere/patches/maven.patch.29 - +1: jfclere, kkolinko, markt - -1: - kkolinko: In description of jarFileDir attribute: -s/if not same as artifactId/if not same as tomcat.lib.path/ - * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=52335 Only handle \% and not \% as escaped in template text. http://svn.apache.org/viewvc?rev=1215121view=rev - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1215181 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Fri Dec 16 15:25:02 2011 New Revision: 1215181 URL: http://svn.apache.org/viewvc?rev=1215181view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1215181r1=1215180r2=1215181view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Dec 16 15:25:02 2011 @@ -114,7 +114,7 @@ PATCHES PROPOSED TO BACKPORT: Fix ClassCastException in Alias added for existing host via JMX http://svn.apache.org/viewvc?rev=1204856view=rev (without tests; it is r1204860 in TC7) - +1: kkolinko + +1: kkolinko, markt -1: * Do not throw IllegalArgumentException from parseParameters() call when - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 12/16/2011 04:20 PM, Mark Thomas wrote: It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. I understood it only affects the release process... If that is wrong that I screwed it, Sorry Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 16/12/2011 15:43, jean-frederic clere wrote: On 12/16/2011 04:20 PM, Mark Thomas wrote: It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. I understood it only affects the release process... So what? Releasing software is why this community exists. Any changes to that process need to be agreed by the community first. If that is wrong that I screwed it, Sorry Before this change, we could release artefacts to Maven Central. After this change, we are unable to release artefacts to Maven Central since that part of the release process now needs re-writing. That is not acceptable. If there were an security issue that required an immediate release Maven users at best would get the artefacts late or at worst not at all. An apology is a good start but the stuff you have just broken needs fixing. At the moment, I see two possible fixes. 1. Update the release scripts so we can release artefacts to Maven using the new process. 2. Revert the change to use Nexus and return to scp+rsync. If you don't do 1. (pretty much immediately), I intend to request that the infra team does 2. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
Please Mark calm down. Being possible to deploy to Nexus does not mean that the project is configured to do that. To enable this, you need to configure the needed POM metadata (SCM, website) and let the master POM of Tomcat be child of the Apache Master pom. Even if you have done this steps, if you are not using the Maven release plugin, it does not work. AFAICT you should be able to (temporarily, for good) deploy to people.a.o. Antonio P.S. Your project is a mess to be a Maven project. If you *really* want to move to Maven you need to do a major reconstruction of the directory structure. 2011/12/16 Mark Thomas ma...@apache.org On 16/12/2011 15:43, jean-frederic clere wrote: On 12/16/2011 04:20 PM, Mark Thomas wrote: It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. I understood it only affects the release process... So what? Releasing software is why this community exists. Any changes to that process need to be agreed by the community first. If that is wrong that I screwed it, Sorry Before this change, we could release artefacts to Maven Central. After this change, we are unable to release artefacts to Maven Central since that part of the release process now needs re-writing. That is not acceptable. If there were an security issue that required an immediate release Maven users at best would get the artefacts late or at worst not at all. An apology is a good start but the stuff you have just broken needs fixing. At the moment, I see two possible fixes. 1. Update the release scripts so we can release artefacts to Maven using the new process. 2. Revert the change to use Nexus and return to scp+rsync. If you don't do 1. (pretty much immediately), I intend to request that the infra team does 2. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52271] ArrayIndexOutOfBoundsException in CompositeELResolver.add
https://issues.apache.org/bugzilla/show_bug.cgi?id=52271 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #1 from Mark Thomas ma...@apache.org 2011-12-16 16:08:27 UTC --- CompositeELResolver is not thread-safe during init. It sounds as if MyFaces is trying to configure the same CompositeELResolver instance from multiple threads. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Being possible to deploy to Nexus does not mean that the project is configured to do that. Exactly. Tomcat has been using scp+rsync via people.a.o for several years. That process has been broken by the switch to Nexus. To enable this, you need to configure the needed POM metadata (SCM, website) and let the master POM of Tomcat be child of the Apache Master pom. Even if you have done this steps, if you are not using the Maven release plugin, it does not work. AFAICT you should be able to (temporarily, for good) deploy to people.a.o. The whole point is that we can no longer release via people.a.o because of the switch to Nexus. It has been made quite clear that a project can use either Nexus or people.a.o but not both. For Tomcat to use Nexus, the Tomcat release scripts need to be updated and they have not been. Antonio P.S. Your project is a mess to be a Maven project. If you *really* want to move to Maven you need to do a major reconstruction of the directory structure. There are no plans to move Tomcat to use Maven for building. This is purely about providing the Tomcat JARs as Maven artefacts in Maven Central for others to use as they wish. Mark 2011/12/16 Mark Thomas ma...@apache.org On 16/12/2011 15:43, jean-frederic clere wrote: On 12/16/2011 04:20 PM, Mark Thomas wrote: It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. I understood it only affects the release process... So what? Releasing software is why this community exists. Any changes to that process need to be agreed by the community first. If that is wrong that I screwed it, Sorry Before this change, we could release artefacts to Maven Central. After this change, we are unable to release artefacts to Maven Central since that part of the release process now needs re-writing. That is not acceptable. If there were an security issue that required an immediate release Maven users at best would get the artefacts late or at worst not at all. An apology is a good start but the stuff you have just broken needs fixing. At the moment, I see two possible fixes. 1. Update the release scripts so we can release artefacts to Maven using the new process. 2. Revert the change to use Nexus and return to scp+rsync. If you don't do 1. (pretty much immediately), I intend to request that the infra team does 2. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of LocalBadContent by ChuckCaldarale
Dear Wiki user, You have subscribed to a wiki page or wiki category on Tomcat Wiki for change notification. The LocalBadContent page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diffrev1=38rev2=39 Comment: spam prevention masterjin\.com mathsolutions\.50webs\.com mnsp\.cn + myeurowatches\.com mystreyguy nekoo\.cn nofaxpayday - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 16/12/2011 16:15, Mark Thomas wrote: On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Being possible to deploy to Nexus does not mean that the project is configured to do that. Exactly. Tomcat has been using scp+rsync via people.a.o for several years. That process has been broken by the switch to Nexus. Jean-Frederic has informed me (via private e-mail) that he intends to fix this tomorrow. Despite that this change has already been made, I would like to see a discussion on whether or not switching to Nexus is in the best interests of the Tomcat project. I'll start a separate thread for that. Mark To enable this, you need to configure the needed POM metadata (SCM, website) and let the master POM of Tomcat be child of the Apache Master pom. Even if you have done this steps, if you are not using the Maven release plugin, it does not work. AFAICT you should be able to (temporarily, for good) deploy to people.a.o. The whole point is that we can no longer release via people.a.o because of the switch to Nexus. It has been made quite clear that a project can use either Nexus or people.a.o but not both. For Tomcat to use Nexus, the Tomcat release scripts need to be updated and they have not been. Antonio P.S. Your project is a mess to be a Maven project. If you *really* want to move to Maven you need to do a major reconstruction of the directory structure. There are no plans to move Tomcat to use Maven for building. This is purely about providing the Tomcat JARs as Maven artefacts in Maven Central for others to use as they wish. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 16 December 2011 16:15, Mark Thomas ma...@apache.org wrote: On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Being possible to deploy to Nexus does not mean that the project is configured to do that. Exactly. Tomcat has been using scp+rsync via people.a.o for several years. That process has been broken by the switch to Nexus. To enable this, you need to configure the needed POM metadata (SCM, website) and let the master POM of Tomcat be child of the Apache Master pom. Even if you have done this steps, if you are not using the Maven release plugin, it does not work. AFAICT you should be able to (temporarily, for good) deploy to people.a.o. The whole point is that we can no longer release via people.a.o because of the switch to Nexus. It has been made quite clear that a project can use either Nexus or people.a.o but not both. For Tomcat to use Nexus, the Tomcat release scripts need to be updated and they have not been. That's not how Nexus is being used in Commons - but I don't know what has been set up here, so perhaps the following is not applicable: Nexus (as used by Commons/HttpClient) intercepts uploads to the Maven distribution repo on people. Instead of Maven artifacts being automatically synched with Maven Central, Nexus stores them in a staging repo. This must be checked and closed to new updates; it's then available to the general public to as part of the VOTE. If the vote succeeds, the staging repo can be released, otherwise it is dropped. Once released, the artifacts make their way to Maven Central as before. Nexus does *not* change the process for non-Maven artifacts (which are the main Tomcat release mechanism). However once enabled for a project, the protection on the maven distribution repo is changed so only Nexus can update it. The benefit is that it is impossible to accidentally release Maven artifacts using mvn deploy or whatever; and there is staging area which can be used for votes. It also checks sigs and generates hashes if necessary. It guarantees that the voted on artifacts are the ones that are released. The disadvantage is that one has to login to Nexus twice: to close the staging area, and then to release or drop it at the end of the vote. But this does not change how non-Maven artifacts are released. Antonio P.S. Your project is a mess to be a Maven project. If you *really* want to move to Maven you need to do a major reconstruction of the directory structure. There are no plans to move Tomcat to use Maven for building. This is purely about providing the Tomcat JARs as Maven artefacts in Maven Central for others to use as they wish. Mark 2011/12/16 Mark Thomas ma...@apache.org On 16/12/2011 15:43, jean-frederic clere wrote: On 12/16/2011 04:20 PM, Mark Thomas wrote: It appears that Maven artefact publishing has been moved from people.a.o (that all the release scripts are written to use) to using Nexus. See [1] I have a number of issues with this: 1. There was zero discussion of this on the dev list. 2. Maven publishing for snapshots, release candidates and releases is now broken as the release scripts have not been updated as it appears is required. [2] Jean-Frederic, please explain ASAP what on earth is going on here. Decisions such as this must happen on list *before* they are actioned. I understood it only affects the release process... So what? Releasing software is why this community exists. Any changes to that process need to be agreed by the community first. If that is wrong that I screwed it, Sorry Before this change, we could release artefacts to Maven Central. After this change, we are unable to release artefacts to Maven Central since that part of the release process now needs re-writing. That is not acceptable. If there were an security issue that required an immediate release Maven users at best would get the artefacts late or at worst not at all. An apology is a good start but the stuff you have just broken needs fixing. At the moment, I see two possible fixes. 1. Update the release scripts so we can release artefacts to Maven using the new process. 2. Revert the change to use Nexus and return to scp+rsync. If you don't do 1. (pretty much immediately), I intend to request that the infra team does 2. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail:
Re: Move to Nexus with no community discussion. WTF?
On 16/12/2011 19:38, sebb wrote: On 16 December 2011 16:15, Mark Thomas ma...@apache.org wrote: On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Being possible to deploy to Nexus does not mean that the project is configured to do that. Exactly. Tomcat has been using scp+rsync via people.a.o for several years. That process has been broken by the switch to Nexus. To enable this, you need to configure the needed POM metadata (SCM, website) and let the master POM of Tomcat be child of the Apache Master pom. Even if you have done this steps, if you are not using the Maven release plugin, it does not work. AFAICT you should be able to (temporarily, for good) deploy to people.a.o. The whole point is that we can no longer release via people.a.o because of the switch to Nexus. It has been made quite clear that a project can use either Nexus or people.a.o but not both. For Tomcat to use Nexus, the Tomcat release scripts need to be updated and they have not been. That's not how Nexus is being used in Commons - but I don't know what has been set up here, so perhaps the following is not applicable: It isn't. We are talking about the release process for Maven artefacts. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Publishing process for JARs for Maven Central
All, There are currently two options for publishing JARs to Maven Central: 1. scp+rsync via people.a.o 2. Nexus Personally, my only requirements are: a) that the JARs reach Maven Central b) publishing is as simple as running a single script I don't particularly care about the details. As long as all I have to do is run a script and the JARs end up in Maven Central I'm happy. I know option 1 works and I assume 2 will work the same way. Therefore I have no preference for either approach. Does anyone else have any requirements / views that would suggest one approach is better than the other? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
2011/12/16 Mark Thomas ma...@apache.org On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Mark, everything's right, good boy :-D First of all, did you try to release something and it went wrong? If not, remember that changes might be rolled back at any time (though, sincerely, I don't see why, especially if you did not see a problem). And anyway, your attitude against Jean Frederic is unacceptable, in this cases you should remind that: * Apache is a community driven foundation, not a private firm that will lose money if the build does not work. * I think that you should recall the basic rules of personal relationship. Jean Frederic is a person, attacking him this way is *bad*. He probably made a mistake, however there are many ways to tell things, most of them are kind. Best regards Antonio
[jira] [Commented] (MTOMCAT-108) THe httpsPort flag starts another http thread not an https thread
[ https://issues.apache.org/jira/browse/MTOMCAT-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13171218#comment-13171218 ] Olivier Lamy commented on MTOMCAT-108: -- btw regarding this obfuscate stuff I wonder how it's secured as the deobfuscate method is open source :-) THe httpsPort flag starts another http thread not an https thread - Key: MTOMCAT-108 URL: https://issues.apache.org/jira/browse/MTOMCAT-108 Project: Apache Tomcat Maven Plugin Issue Type: Bug Components: tomcat7 Affects Versions: 2.0 Environment: MAc OSX 10.6.8 Reporter: Keith Corbin Assignee: Olivier Lamy Fix For: 2.0 Attachments: https.patch WHen you run the executable war the httpsPort flag starts an http protocol listener thread on the port listed not an https protocol listener. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Publishing process for JARs for Maven Central
On 12/16/2011 08:56 PM, Mark Thomas wrote: All, I know option 1 works ... Does anyone else have any requirements / views that would suggest one approach is better than the other? If it ain't broken don't fix it. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Nexus with no community discussion. WTF?
On 16/12/2011 20:21, Antonio Petrelli wrote: 2011/12/16 Mark Thomas ma...@apache.org On 16/12/2011 16:06, Antonio Petrelli wrote: Please Mark calm down. No, I will not calm down. The release process has been changed without prior discussion and on top of that it is now broken for Maven artefacts. That is not acceptable. Mark, everything's right, No it isn't. If everything was alright, there would have been no need to start this thread. good boy :-D I'm going to ignore that patronizing remark. First of all, did you try to release something and it went wrong? No I didn't. However, as a member of the ASF infrastructure team I know enough about how Nexus is configured to know that due to [1] releasing Maven artefacts via scp+rsync using people.a.o is now blocked. All of the Tomcat build scripts are written to release JARs files to Maven Central via scp+rsync via people.a.o. Because of the switch to Nexus, the publishing to Maven Central part of the build process is currently broken. If not, remember that changes might be rolled back at any time (though, sincerely, I don't see why, especially if you did not see a problem). This is not a simple change to a build script in svn. Ultimately anything can be reverted but reverting the switch to Nexus looks to be non-trivial. As an example, the entire tomcat section of the repo on people.a.o has been removed and would have to be reconstructed. That is far more work than a simple svn revert. I am sure that other changes have also been made. I do not know how much reverting all of them may entail. To re-iterate I do see a problem. The build scripts are all written to use scp+rsync via people.a.o but releases via that route is now blocked. The good news is that Jean-Frederic has indicated via private e-mail that he will be fixing the build scripts to use Nexus tomorrow. I would like to see him confirm that on this list but I have no reason to doubt his word. A quick read of [2] suggests that it should be do-able in that timeframe. And anyway, your attitude against Jean Frederic is unacceptable, in this cases you should remind that: There we disagree. I think that Jean-Frederic's decision to go ahead with [1] without community discussion was the wrong decision. That the release of Tomcat artefacts to Maven Central is now broken makes things worse. * Apache is a community driven foundation, Exactly. Which is why one individual making technical decisions that affect a project's release process without prior community discussion is wrong. To repeat what has been said many times before at the ASF If it didn't happen on the mailing list then it didn't happen and there was no discussion of this change on the mailing list. If the discussion had taken place on the dev list, the issues around the current build scripts would have been identified and addressed and, for example, we could have co-ordinated the switch to Nexus with the necessary changes to the build scripts. And if we hadn't identified the issues then this would be a community screw-up that we could all share responsibility for. You'll note that I have started a separate thread to discuss the relative merits of Nexus vs scp+rsync. If you are aware of anything that would indicate one is a better choice than the other for Tomcat then please do contribute to that thread. not a private firm that will lose money if the build does not work. I agree this has nothing to do with money. It has everything to do with community. Part of the Tomcat community relies on obtaining the Tomcat JARs from Maven Central. Based on how quickly questions get asked if I forget to run the Maven artefacts part of the release process once a Tomcat 7 release vote has passed, I would guess that a sizable part of our community depends on those JARs. A direct consequence of this change is that we are currently unable to make releases to that part of our community. Currently we have no plans for a release but it only takes one critical security vulnerability report to change that. * I think that you should recall the basic rules of personal relationship. Jean Frederic is a person, attacking him this way is *bad*. If someone screws up, I am going to call them on it. If I screw-up (and I do regularly - check the archives for the long list of stuff I have managed to break over the years) I expect to get called on it. Doing things without any on-list discussion is a huge no-no at the ASF. I would agree my response was a strong one but I wouldn't characterise it as a personal attack (Jean-Frederic if you read any of my comments were read that way I apologise - that wasn't my intention). He probably made a mistake, however there are many ways to tell things, most of them are kind. Everything is relative. I would say this thread was pretty mild compared to others I have seen both on this list an elsewhere at the ASF. Could it have been milder? Sure. But when I see such a fundamental part of The Apache Way
svn commit: r1215319 - in /tomcat/tc6.0.x/trunk: res/maven/mvn-pub.xml webapps/docs/changelog.xml
Author: kkolinko
Date: Fri Dec 16 22:25:18 2011
New Revision: 1215319
URL: http://svn.apache.org/viewvc?rev=1215319view=rev
Log:
Followup to r1215167
Fix copy-pasted description
Correct changelog entry
a) It is in 6.0.36
b) Mention https://issues.apache.org/bugzilla/show_bug.cgi?id=49402
The juli publishing bug fixed by this commit was introduced by r762906 in April
2009
Modified:
tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml?rev=1215319r1=1215318r2=1215319view=diff
==
--- tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml Fri Dec 16 22:25:18 2011
@@ -120,7 +120,7 @@
macrodef name=doMavenDeploy
attribute name=artifactId/
attribute name=jarFileName default=@{artifactId}.jar
description=only need to be specified if not same as artifactId/
-attribute name=jarFileDir default=${tomcat.lib.path}
description=only need to be specified if not same as artifactId/
+attribute name=jarFileDir default=${tomcat.lib.path}
description=only need to be specified if not same as tomcat.lib.path/
sequential
antcall target=maven-deploy
param name=file value=@{jarFileDir}/@{jarFileName}/
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1215319r1=1215318r2=1215319view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Dec 16 22:25:18 2011
@@ -43,20 +43,23 @@
!-- Section names:
General, Catalina, Coyote, Jasper, Cluster, Webapps, Other
--
-section name=Tomcat 6.0.35 (jfclere) rtext=released 2011-12-05
- subsection name=Catalina
+section name=Tomcat 6.0.36 (jfclere) rtext=
+ subsection name=Other
changelog
fix
-Fix regression in decoding of parameters that contain spaces.
-Patch by Willem Fibbe. (kkolinko)
+bug49402/bug, bug52124/bug: Fix Maven publishing script:
+make sure it finds tomcat-juli.jar and use later version of
+wagon-ssh. (jfclere)
/fix
/changelog
/subsection
- subsection name=Other
+/section
+section name=Tomcat 6.0.35 (jfclere) rtext=released 2011-12-05
+ subsection name=Catalina
changelog
fix
-bug52124/bug: Ensure Maven publishing process retains metadata for
-previous releases. (jfclere)
+Fix regression in decoding of parameters that contain spaces.
+Patch by Willem Fibbe. (kkolinko)
/fix
/changelog
/subsection
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52124] Tomcat Maven metadata only includes the latest release
https://issues.apache.org/bugzilla/show_bug.cgi?id=52124 --- Comment #4 from Konstantin Kolinko knst.koli...@gmail.com 2011-12-16 22:35:55 UTC --- The http://repo1.maven.org/maven2/org/apache/tomcat/catalina/maven-metadata.xml file mentioned in MVNCENTRAL-139 as of now lists 6.0.33 and 6.0.35 only. It is odd that it has version6.0.33/version The /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/tomcat/ is empty, catalina subdirectory is removed. Is it because of https://issues.apache.org/jira/browse/INFRA-4162 aka move to Nexus? So there is no more an easy way to fix that maven-metadata file? If one wants to publish to Nexus, the mvn-pub.xml script has to be updated once again, and the POMs must be changed to use Apache POM as a parent? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Publishing process for JARs for Maven Central
On Fri, Dec 16, 2011 at 2:56 PM, Mark Thomas ma...@apache.org wrote: All, There are currently two options for publishing JARs to Maven Central: 1. scp+rsync via people.a.o 2. Nexus I don't have a strong preference between them. Is there a difference between the two approaches in how fast the JARs are available for download? Yoav Personally, my only requirements are: a) that the JARs reach Maven Central b) publishing is as simple as running a single script I don't particularly care about the details. As long as all I have to do is run a script and the JARs end up in Maven Central I'm happy. I know option 1 works and I assume 2 will work the same way. Therefore I have no preference for either approach. Does anyone else have any requirements / views that would suggest one approach is better than the other? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52124] Tomcat Maven metadata only includes the latest release
https://issues.apache.org/bugzilla/show_bug.cgi?id=52124 --- Comment #5 from Sebb s...@apache.org 2011-12-17 00:19:45 UTC --- (In reply to comment #4) The http://repo1.maven.org/maven2/org/apache/tomcat/catalina/maven-metadata.xml file mentioned in MVNCENTRAL-139 as of now lists 6.0.33 and 6.0.35 only. It is odd that it has version6.0.33/version The /www/people.apache.org/repo/m2-ibiblio-rsync-repository/org/apache/tomcat/ is empty, catalina subdirectory is removed. Is it because of https://issues.apache.org/jira/browse/INFRA-4162 aka move to Nexus? So there is no more an easy way to fix that maven-metadata file? If one wants to publish to Nexus, the mvn-pub.xml script has to be updated once again, and the POMs must be changed to use Apache POM as a parent? Nexus takes care of updating the metadata. [It also checks that the sig uses a public key.] -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Publishing process for JARs for Maven Central
On 16 December 2011 23:45, Yoav Shapira yo...@apache.org wrote: On Fri, Dec 16, 2011 at 2:56 PM, Mark Thomas ma...@apache.org wrote: All, There are currently two options for publishing JARs to Maven Central: 1. scp+rsync via people.a.o 2. Nexus I don't have a strong preference between them. Is there a difference between the two approaches in how fast the JARs are available for download? AFAIK it's the same. AIUI the artifacts are still deployed to the same distribution area. Nexus copies them across when the RM releases the staging repo, rather than the RM doing the copy directly. BTW, Nexus takes care of maintaining the Maven metadata. It also checks that the signature is valid and uses a public key (I think this is done on Close) I think it also creates hashes if required. See http://www.apache.org/dev/publishing-maven-artifacts.html and linked docs for some more info on Nexus. Yoav Personally, my only requirements are: a) that the JARs reach Maven Central b) publishing is as simple as running a single script I don't particularly care about the details. As long as all I have to do is run a script and the JARs end up in Maven Central I'm happy. I know option 1 works and I assume 2 will work the same way. Therefore I have no preference for either approach. Does anyone else have any requirements / views that would suggest one approach is better than the other? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 mins 30 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-17122011.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17122011-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-17122011-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-17122011.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/worksp ace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-17122011.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.
Re: Publishing process for JARs for Maven Central
On 12/16/11 12:56 PM, Mark Thomas wrote: All, There are currently two options for publishing JARs to Maven Central: 1. scp+rsync via people.a.o 2. Nexus Personally, my only requirements are: a) that the JARs reach Maven Central b) publishing is as simple as running a single script I would be very interested to know if anyone has figured out a way to fully script Nexus. AFAIK, Nexus requires that you use the GUI and also (sic) store credentials in a plaintext file. Maybe someone has figured out a way around this. I would be very interested to learn this so we can improve the not-quite-functional process that we have been fumbling with in Commons [1]. FWIW, my NSHO is that if you have a working script that produces good artifacts that can be scpd to central, there is no reason to bring in proprietary software, plaintext credential files or GUI steps. Phil [1] http://wiki.apache.org/commons/UsingNexus I don't particularly care about the details. As long as all I have to do is run a script and the JARs end up in Maven Central I'm happy. I know option 1 works and I assume 2 will work the same way. Therefore I have no preference for either approach. Does anyone else have any requirements / views that would suggest one approach is better than the other? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
