Re: Publishing process for JARs for Maven Central
On 12/17/2011 07:55 PM, Mark Thomas wrote: Personally, I am of the view If it ain't broke, don't fix it. If there was something we would gain by switching to Maven then I'd be interested but given we have an established build process with Ant that a number of committers are familiar with and that I'm not aware of any benefits of moving to Maven then I don't see any compelling reason to switch. Using Maven would allow us to remove build.properties.default and download task that information would go in pom.xml. We can cut Tomcat in module more easily. The other thing is that Maven seems a more active project that Ant so we new feature easy and most IDE allow to import Maven project in IDE workspace. The problem of Maven is that we have to change the structure of our repository I think that the only problem. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Move to Maven? (WAS: Re: Publishing process for JARs for Maven Central)
On 12/17/2011 09:24 PM, Antonio Petrelli wrote: As requested here is a proposal to move to Maven. I simply cannot understand why some folks have almost religious fascination with Maven. I know many projects that have move from Ant to Maven and are now either switched back or gone to some other solution like Gradle or are in the active process of seeking the alternative. I won't support such a transition at this moment. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1220360 - in /tomcat/tc7.0.x/trunk/res/maven: README.txt mvn-pub.xml mvn.properties.default
Author: jfclere
Date: Sun Dec 18 10:10:33 2011
New Revision: 1220360
URL: http://svn.apache.org/viewvc?rev=1220360view=rev
Log:
Fix the deploy-release task to use nexus.
Added:
tomcat/tc7.0.x/trunk/res/maven/README.txt
Modified:
tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml
tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default
Added: tomcat/tc7.0.x/trunk/res/maven/README.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/README.txt?rev=1220360view=auto
==
--- tomcat/tc7.0.x/trunk/res/maven/README.txt (added)
+++ tomcat/tc7.0.x/trunk/res/maven/README.txt Sun Dec 18 10:10:33 2011
@@ -0,0 +1,25 @@
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the License); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an AS IS BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+
+$Id$
+
+To release do the following:
+1 - copy mvn.properties.default to mvn.propertie and adjust it.
+2 - ant -f mvn-pub.xml deploy-release
+that step creates a staging in
https://repository.apache.org/index.html#stagingRepositories
+3 - test it and do the vote process
+4 - in https://repository.apache.org/index.html#stagingRepositories close it
and then promote it.
Modified: tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml?rev=1220360r1=1220359r2=1220360view=diff
==
--- tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/tc7.0.x/trunk/res/maven/mvn-pub.xml Sun Dec 18 10:10:33 2011
@@ -32,6 +32,8 @@
tomcat.pom.path - the path to the POM files
For passwordless upload you'll also need to set
+ maven.username- YOUR APACHE LDAP USERNAME (ASF ID normally).
+ maven.password- YOUR APACHE LDAP PASSWORD
maven.scp.username- Your ASF ID
maven.scp.privateKey - Path to your exported ssh key
@@ -60,6 +62,35 @@
artifact:install-provider artifactId=wagon-ssh version=1.0-beta-2/
/target
+ target name=maven-deploy-nexus depends=init-maven if=nexus.set
+!--deploy it in nexus --
+artifact:deploy file=${file}
+pom file=${pom}.tmp/
+remoteRepository url=${maven.repo.url} layout=default
+ authentication username=${maven.username}
password=${maven.password}/
+/remoteRepository
+attach file=${file}.asc type=jar.asc/
+attach file=${src} classifier=sources type=jar/
+attach file=${src}.asc classifier=sources type=jar.asc/
+attach file=${pom}.asc type=pom.asc/
+/artifact:deploy
+ /target
+
+ target name=maven-deploy-other depends=init-maven unless=nexus.set
+!--deploy it in nexus --
+artifact:deploy file=${file}
+pom file=${pom}.tmp/
+remoteRepository url=${maven.repo.url} layout=default
+ authentication username=${maven.scp.username}
privateKey=${maven.scp.privateKey} passphrase=${maven.scp.passphrase}/
+ authentication username=${maven.username}
password=${maven.password}/
+/remoteRepository
+attach file=${file}.asc type=jar.asc/
+attach file=${src} classifier=sources type=jar/
+attach file=${src}.asc classifier=sources type=jar.asc/
+attach file=${pom}.asc type=pom.asc/
+/artifact:deploy
+ /target
+
target name=maven-deploy depends=init-maven
!--cleanup--
delete file=${pom}.tmp/
@@ -100,16 +131,16 @@
/exec
!--deploy it--
-artifact:deploy file=${file}
-pom file=${pom}.tmp/
-remoteRepository url=${maven.repo.url} layout=default
- authentication username=${maven.scp.username}
privateKey=${maven.scp.privateKey} passphrase=${maven.scp.passphrase}/
-/remoteRepository
-attach file=${file}.asc type=jar.asc/
-attach file=${src} classifier=sources type=jar/
-attach file=${src}.asc classifier=sources type=jar.asc/
-attach file=${pom}.asc type=pom.asc/
-/artifact:deploy
+antcall target=maven-deploy-nexus
+param name=file value=${file}/
+param name=pom value=${pom}/
+param name=src value=${src}/
+
svn commit: r1220361 - /tomcat/tc7.0.x/trunk/res/maven/README.txt
Author: jfclere Date: Sun Dec 18 10:18:14 2011 New Revision: 1220361 URL: http://svn.apache.org/viewvc?rev=1220361view=rev Log: Add missing property. Modified: tomcat/tc7.0.x/trunk/res/maven/README.txt (props changed) Propchange: tomcat/tc7.0.x/trunk/res/maven/README.txt -- svn:keywords = Id - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1220362 - in /tomcat/tc6.0.x/trunk/res/maven: README.txt mvn-pub.xml
Author: jfclere Date: Sun Dec 18 10:35:39 2011 New Revision: 1220362 URL: http://svn.apache.org/viewvc?rev=1220362view=rev Log: Arrange docs. Modified: tomcat/tc6.0.x/trunk/res/maven/README.txt (contents, props changed) tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml Modified: tomcat/tc6.0.x/trunk/res/maven/README.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/README.txt?rev=1220362r1=1220361r2=1220362view=diff == --- tomcat/tc6.0.x/trunk/res/maven/README.txt (original) +++ tomcat/tc6.0.x/trunk/res/maven/README.txt Sun Dec 18 10:35:39 2011 @@ -1,3 +1,21 @@ + + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the License); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an AS IS BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + + +$Id$ To release do the following: 1 - copy mvn.properties.default to mvn.propertie and adjust it. 2 - ant -f mvn-pub.xml deploy-release Propchange: tomcat/tc6.0.x/trunk/res/maven/README.txt -- svn:keywords = Id Modified: tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml?rev=1220362r1=1220361r2=1220362view=diff == --- tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml (original) +++ tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml Sun Dec 18 10:35:39 2011 @@ -35,14 +35,11 @@ tomcat.pom.path - the path to the POM files All these can be defined by mvn.properties (and defaults are in mvn.properties.default) - To do password less upload, you can modify either - $MAVE_HOME/conf/settings.xml or ~/.m2/settings.xml and add this snippet -server - idapache.snapshots/id - usernameyourusername/username - privateKey/home/yourusername/.ssh/id_rsa/privateKey - passphrase/passphrase -/server + To do password less upload, you'll also need to set + maven.username- YOUR APACHE LDAP USERNAME (ASF ID normally). + maven.password- YOUR APACHE LDAP PASSWORD + maven.scp.username- Your ASF ID + maven.scp.privateKey - Path to your exported ssh key To get a private key to work on Windows, I followed these steps 1. on a linux box execute 'ssh-keygen -t rsa' - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1215557 - in /tomcat/tc6.0.x/trunk/res/maven: README.txt mvn-pub.xml mvn.properties.default
On 12/17/2011 11:05 PM, Konstantin Kolinko wrote:
2011/12/17jfcl...@apache.org:
Author: jfclere
Date: Sat Dec 17 19:02:31 2011
New Revision: 1215557
URL: http://svn.apache.org/viewvc?rev=1215557view=rev
Log:
Fix the deploy-release task.
Once done you should have an entry in
https://repository.apache.org/index.html#stagingRepositories
Check it and click Close.
Once the release is voted just click Release.
If any wrong just click Drop.
Added:
tomcat/tc6.0.x/trunk/res/maven/README.txt
Modified:
tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default
Added: tomcat/tc6.0.x/trunk/res/maven/README.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/res/maven/README.txt?rev=1215557view=auto
==
--- tomcat/tc6.0.x/trunk/res/maven/README.txt (added)
+++ tomcat/tc6.0.x/trunk/res/maven/README.txt Sat Dec 17 19:02:31 2011
@@ -0,0 +1,6 @@
+To release do the following:
+1 - copy mvn.properties.default to mvn.propertie and adjust it.
+2 - ant -f mvn-pub.xml deploy-release
+that step creates a staging in
https://repository.apache.org/index.html#stagingRepositories
+3 - test it and do the vote process
+4 - in https://repository.apache.org/index.html#stagingRepositories close it
and then promote it.
Note that
1) there is also a big comment at the top of mvn-pub.xml.
I have arranged it.
2) ASL header is needed? Nobody checks it in 6.0 but in thunk
checkstyle would complain on such a file, I think.
Fixed.
Modified: tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml
(...)
Looks good.
--- tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc6.0.x/trunk/res/maven/mvn.properties.default Sat Dec 17 19:02:31
2011
@@ -23,6 +23,8 @@
tomcat.version=6.0.20
Can update the above sometime :)
#Maven properties
+maven.username=!-- YOUR APACHE LDAP USERNAME --
+maven.password=!-- YOUR APACHE LDAP PASSWORD --
Regarding plaintext passwords in config files:
There is simple workaround: useinput Ant task.
1. Remove maven.password from maven.properties.default
2. Add
input addproperty=maven.password message=Your LDAP password for
${maven.user} /
Probably that goes into init-maven so that it executes only once.
As docs say
[[[
Since Apache Ant 1.6,input will not prompt for input if a property
should be set by the task that has already been set in the project
(and the task wouldn't have any effect).
]]]
I will for trunk to do it ;-)
Cheers
Jean-Frederic
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp-src.jar. -DEBUG- Dependency on commons-daemon exists, no need to add for property commons-daemon.native.src.tgz. -DEBUG- Dependency on commons-daemon exists, no need to add for property tomcat-native.tar.gz. -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property tomcat-dbcp.home. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/build/logs The following work was performed: http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build) Work ended in a state of : Failed Elapsed: 18 mins 40 secs Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-18122011.jar -Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-18122011-native-src.tar.gz -Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-18122011-native-src.tar.gz -Dexamples.sources.skip=true -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps -Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-18122011.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/worksp ace/commons-dbcp-1.x -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-18122011.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7. 0.x/tomcat-deps/tomcat-dbcp-18122011.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-18122011.jar:/srv/gump/public/workspace/junit/dist/junit-18122011.jar
Re: Publishing process for JARs for Maven Central
On 12/17/11 11:42 AM, Antonio Petrelli wrote: 2011/12/17 Mark Thomas ma...@apache.org On 17/12/2011 18:35, Antonio Petrelli wrote: 2011/12/17 Mark Thomas ma...@apache.org On 17/12/2011 18:14, Antonio Petrelli wrote: Ok then interprete my words as: now you can use a staging repository. This way, artifacts may be tested *before* they are released. The scp+rsync process also has a staging repository (and using that did not cause any meta-data issues). The JARs are the standard Tomcat JARs. The Maven release process just adds the metadata files and moves the JARs + metadata around. Since the JARs are already tested as part of the Tomcat release process, we never had a need to use the staging repository and I don't see that changing. There is also a snapshot repository and we did use that early on in the Tomcat 7 development process (before the first release) mainly because one user who was doing a lot of testing was using Maven and the snapshot repository was the easiest way to get them the latest build. We stopped using the snapshot repository some time ago. I can't remember if it was after the first release or after the first stable release. Ok then using Nexus makes sense only if you are going to use Maven for all the release process (it's a matter of two commands and a Nexus stage promotion). I think that now you should change the subject into: why should you switch to pure Maven build process? :-D (Joking, but not too much) Yeah, that isn't going to happen :) I've seen way to much pain and grief with Maven on the Commons list to ever want to even think about converting the Tomcat build process to Maven. Commons? That's strange, they are only libraries. Probably they never had cringe-mode-off / a Maven wizard like me cringe-mode-on /. We have several maven committers on the PMC and have been using maven since the 1.x days. One thing we have learned is that maven builds require regular care and feeding. We are on version 23 of the Commons Parent pom. One statistic that I have often thought would be interesting to look at is how much time (maybe proxied by number of metadata commits) is spent maintaining maven vs Ant builds. I wonder if on net maven saves time? The tomcat Ant build has been relatively stable compared to the maven projects I know. Could be I am wrong, but I bet tomcat has overall spent less time fussing with its build than the average ASF maven project. In Commons, our success getting to periods of stability (we are between stable points now) has depended on having multiple deeply maven-knowledgeable people prepared to do the work to keep component builds up to date with maven, ASF/Sonatype infrastructure and plugin changes. If there are several tomcat committers willing to step up to do this, then I am sure you can get it to work. Otherwise, you are likely better off staying with Ant. Phil Seriously, if I have the time, I could fork Tomcat 7 from GitHub to try if I can change this situation. I already did it for Velocity (using SVN). The only difficulty is the website. Antonio - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52353] New: Possibility of unsynchronized concurrent access to field org.apache.catalina.tribes.group.ChannelInterceptorBase.next
https://issues.apache.org/bugzilla/show_bug.cgi?id=52353
Bug #: 52353
Summary: Possibility of unsynchronized concurrent access to
field
org.apache.catalina.tribes.group.ChannelInterceptorBa
se.next
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: reprogram...@gmail.com
Classification: Unclassified
Method org.apache.catalina.tribes.group.ChannelInterceptorBase.getNext() is
reachable from method
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run(),
which implements the run method of a Runnable class. The following is a
sequence of method calls from MessageDispatchInterceptor.run() to
ChannelInterceptorBase.getNext():
1.
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run()
2.
org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.sendAsyncData(LinkObject)
3.
org.apache.catalina.tribes.group.ChannelInterceptorBase.sendMessage(Member[],
ChannelMessage, InterceptorPayload)
4. org.apache.catalina.tribes.group.ChannelInterceptorBase.getNext()
Similarly,
org.apache.catalina.tribes.group.ChannelInterceptorBase.setNext(ChannelInterceptor)
may be called from
org.apache.catalina.tribes.demos.CoordinationDemo.cmdStart(...).new Thread()
{...}.run(), which implements the run method of a Thread. The following is
a sequence of method calls that shows the possibility of invoking
ChannelInterceptorBase.setNext(ChannelInterceptor) from a Thread:
1. org.apache.catalina.tribes.demos.CoordinationDemo.cmdStart(...).new Thread()
{...}.run()
2. org.apache.catalina.tribes.demos.CoordinationDemo.Status.start()
3. org.apache.catalina.tribes.demos.CoordinationDemo.Status.createChannel()
4.
org.apache.catalina.tribes.group.GroupChannel.addInterceptor(ChannelInterceptor)
5.
org.apache.catalina.tribes.group.ChannelInterceptorBase.setNext(ChannelInterceptor)
Since field org.apache.catalina.tribes.group.ChannelInterceptorBase.next may
get accessed concurrently, it should get properly synchronized.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52353] Possibility of unsynchronized concurrent access to field org.apache.catalina.tribes.group.ChannelInterceptorBase.next
https://issues.apache.org/bugzilla/show_bug.cgi?id=52353 Mohsen Vakilian reprogram...@gmail.com changed: What|Removed |Added CC||reprogram...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52354] New: Protect concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354 Bug #: 52354 Summary: Protect concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQue ue.inRemove Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: reprogram...@gmail.com Classification: Unclassified Field org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove may be read and written in parallel. Thus, accesses to it should be synchronized. The following is a sequence of method calls from the run method of a class that implements Runnable to a method that accesses FastQueue.inRemove without proper synchronization. 1. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run() 2. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.removeFromQueue() 3. org.apache.catalina.tribes.transport.bio.util.FastQueue.remove() Field FastQueue.inRemove is declared at http://svn.apache.org/repos/asf/!svn/bc/1220560/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52354] Protect concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQueue.inRemove
https://issues.apache.org/bugzilla/show_bug.cgi?id=52354 Mohsen Vakilian reprogram...@gmail.com changed: What|Removed |Added CC||reprogram...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52355] New: Synchronize possible concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQueue.checkLock.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52355 Bug #: 52355 Summary: Synchronize possible concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQue ue.checkLock. Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: reprogram...@gmail.com Classification: Unclassified Class org.apache.catalina.tribes.transport.bio.util.FastQueue is used in parallel contexts that originate from method org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run(). 1. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.run() 2. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.sendAsyncData(LinkObject) 3. org.apache.catalina.tribes.group.ChannelInterceptorBase.sendMessage(Member[], ChannelMessage, InterceptorPayload) 4. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.sendMessage(Member[], ChannelMessage, InterceptorPayload) 5. org.apache.catalina.tribes.group.interceptors.MessageDispatchInterceptor.addToQueue(ChannelMessage, Member[], InterceptorPayload) 6. org.apache.catalina.tribes.transport.bio.util.FastQueue.FastQueue() Two public methods of FastQueue, namely org.apache.catalina.tribes.transport.bio.util.FastQueue.isCheckLock() and org.apache.catalina.tribes.transport.bio.util.FastQueue.setCheckLock(boolean) access the field org.apache.catalina.tribes.transport.bio.util.FastQueue.checkLock without proper synchronization. Fortunately, these two methods, i.e. FastQueue.isCheckLock() and FastQueue.setCheckLock(boolean), are currently used. So, there is only a potential data race on FastQueue.checkLock. To prevent such a data race in future, I suggest that either accesses to FastQueue.checkLock get properly syncrhonized or the unused public methods FastQueue.isCheckLock() and FastQueue.setCheckLock(boolean) be removed. Field FastQueue.checkLock is declared at http://svn.apache.org/repos/asf/!svn/bc/1220560/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52355] Synchronize possible concurrent accesses to field org.apache.catalina.tribes.transport.bio.util.FastQueue.checkLock.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52355 Mohsen Vakilian reprogram...@gmail.com changed: What|Removed |Added CC||reprogram...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of PoweredBy by marcoschmidt
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The PoweredBy page has been changed by marcoschmidt:
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=392rev2=393
=== iPoint Portal ===
{{http://www.ipointportal.com/iPoint/schemes/c2b2/logo1.gif}}
[[http://www.ipointportal.com|The Open Source Collaborative Portal]] - iPoint
Portal is an Open Source Collaborative Portal which is compatible with JSR168
and runs on Tomcat.
+ === iTanum Webdesign ===
+ {{http://www.itanum.com/images/logo.jpg}} iTanum -
[[http://www.itanum.com|Webdesign]] delivers all Content Management solutions
and Web business applications on Tomcat.
+
=== Jakarta Slide ===
{{http://jakarta.apache.org/slide/images/Slide.gif}}
[[http://jakarta.apache.org/slide/index.html|Slide]] is an open-source content
repository that can serve as the basis for a content management system.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52356] New: Prevent potential data races on org.apache.catalina.tribes.transport.bio.util.FastQueue.size.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52356 Bug #: 52356 Summary: Prevent potential data races on org.apache.catalina.tribes.transport.bio.util.FastQue ue.size. Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: reprogram...@gmail.com Classification: Unclassified Even though accesses to org.apache.catalina.tribes.transport.bio.util.FastQueue.size are synchronized inside org.apache.catalina.tribes.transport.bio.util.FastQueue.add(ChannelMessage, Member[], InterceptorPayload) and org.apache.catalina.tribes.transport.bio.util.FastQueue.remove(), the read access in org.apache.catalina.tribes.transport.bio.util.FastQueue.getSize() is not properly synchronized and thus can lead to a race condition. However, org.apache.catalina.tribes.transport.bio.util.FastQueue.getSize() is not used, so this bug never manifests. Nevertheless, we suggest that Tomcat developers either remove org.apache.catalina.tribes.transport.bio.util.FastQueue.getSize() or make it access the shared field safely. Field org.apache.catalina.tribes.transport.bio.util.FastQueue.size is declared at http://svn.apache.org/repos/asf/!svn/bc/1220560/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/FastQueue.java. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 52356] Prevent potential data races on org.apache.catalina.tribes.transport.bio.util.FastQueue.size.
https://issues.apache.org/bugzilla/show_bug.cgi?id=52356 Mohsen Vakilian reprogram...@gmail.com changed: What|Removed |Added CC||reprogram...@gmail.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Commented] (MTOMCAT-109) protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured
[ https://issues.apache.org/jira/browse/MTOMCAT-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13172073#comment-13172073 ] Morten Haraldsen commented on MTOMCAT-109: -- I think (at least for now) using a mojo option is perfectly fine protocolorg.apache.coyote.http11.Http11NioProtocol/protocol not honoured Key: MTOMCAT-109 URL: https://issues.apache.org/jira/browse/MTOMCAT-109 Project: Apache Tomcat Maven Plugin Issue Type: Bug Affects Versions: 2.0 Reporter: Morten Haraldsen Assignee: Olivier Lamy Fix For: 2.0 Original Estimate: 1h Remaining Estimate: 1h Tomcat7Runner.java Line 146: Connector connector = new Connector( HTTP/1.1 ); Make it possible to use NIO connector, through protocol option so that connector is initialized using something like: Connector connector = new Connector( org.apache.coyote.http11.Http11NioProtocol ); -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[jira] [Created] (MTOMCAT-110) Support Slf4j bridge logger
Support Slf4j bridge logger --- Key: MTOMCAT-110 URL: https://issues.apache.org/jira/browse/MTOMCAT-110 Project: Apache Tomcat Maven Plugin Issue Type: New Feature Reporter: Morten Haraldsen As a lot of web-applications use slf4j for logging, it would be nice if you could support this as a Mojo parameter, like loggingslf4j/logging This should trigger something like: java.util.logging.LogManager.getLogManager().reset(); SLF4JBridgeHandler.install(); (requires org.slf4j:jul-to-slf4j on the classpath) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
