[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122

--- Comment #5 from jbal...@akamai.com ---
I successfully rested with this fix. I verified that I no longer received the
error message.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-8-trunk

2018-06-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1339

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1832968
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2018-06-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3342

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1832963
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62391] Unable to Install Windows Service with Server JRE

2018-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62391

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Mark Thomas  ---
Fixed in:
- trunk for 9.0.9 onwards
- 8.5.x for 8.5.32 onwards
- 8.0.x for 8.0.53 onwards
- 7.0.x for 7.0.89 onwards

I removed all references to javaw.exe from the scripts. I also checked for
references anywhere else in the source code. There were none.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832969 - in /tomcat/tc7.0.x/trunk: ./ bin/service.bat bin/setclasspath.bat webapps/docs/changelog.xml

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:22:45 2018
New Revision: 1832969

URL: http://svn.apache.org/viewvc?rev=1832969=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62391
Remove references to javaw.exe as this file is not required by Tomcat and the 
references prevent the use of the Server JRE.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/bin/service.bat
tomcat/tc7.0.x/trunk/bin/setclasspath.bat
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 19:22:45 2018
@@ -1,3 +1,3 @@
-/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 

svn commit: r1832968 - in /tomcat/tc8.0.x/trunk: ./ bin/service.bat bin/setclasspath.bat webapps/docs/changelog.xml

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:21:06 2018
New Revision: 1832968

URL: http://svn.apache.org/viewvc?rev=1832968=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62391
Remove references to javaw.exe as this file is not required by Tomcat and the 
references prevent the use of the Server JRE.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/bin/service.bat
tomcat/tc8.0.x/trunk/bin/setclasspath.bat
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 19:21:06 2018
@@ -1,2 +1,2 @@
-/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042,1831557,1831569,1832269,1832271,1832693
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1832967 - in /tomcat/tc8.5.x/trunk: ./ bin/service.bat bin/setclasspath.bat webapps/docs/changelog.xml

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:20:12 2018
New Revision: 1832967

URL: http://svn.apache.org/viewvc?rev=1832967=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62391
Remove references to javaw.exe as this file is not required by Tomcat and the 
references prevent the use of the Server JRE.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/bin/service.bat
tomcat/tc8.5.x/trunk/bin/setclasspath.bat
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 19:20:12 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 

svn commit: r1832966 - /tomcat/trunk/webapps/docs/changelog.xml

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:19:42 2018
New Revision: 1832966

URL: http://svn.apache.org/viewvc?rev=1832966=rev
Log:
Typo

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832966=1832965=1832966=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jun  5 19:19:42 2018
@@ -292,7 +292,7 @@
   
   
 62391: Remove references to javaw.exe as this
-file is not required by Tomcat and the references prevent the use if 
the
+file is not required by Tomcat and the references prevent the use of 
the
 Server JRE. (markt)
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832965 - in /tomcat/trunk: bin/service.bat bin/setclasspath.bat webapps/docs/changelog.xml

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:14:42 2018
New Revision: 1832965

URL: http://svn.apache.org/viewvc?rev=1832965=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62391
Remove references to javaw.exe as this file is not required by Tomcat and the 
references prevent the use if the Server JRE.

Modified:
tomcat/trunk/bin/service.bat
tomcat/trunk/bin/setclasspath.bat
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/bin/service.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/service.bat?rev=1832965=1832964=1832965=diff
==
--- tomcat/trunk/bin/service.bat (original)
+++ tomcat/trunk/bin/service.bat Tue Jun  5 19:14:42 2018
@@ -52,19 +52,16 @@ echo Service will try to guess them from
 goto okJavaHome
 :gotJreHome
 if not exist "%JRE_HOME%\bin\java.exe" goto noJavaHome
-if not exist "%JRE_HOME%\bin\javaw.exe" goto noJavaHome
 goto okJavaHome
 :gotJdkHome
 if not exist "%JAVA_HOME%\bin\javac.exe" goto noJavaHome
 rem Java 9 has a different directory structure
 if exist "%JAVA_HOME%\jre\bin\java.exe" goto preJava9Layout
 if not exist "%JAVA_HOME%\bin\java.exe" goto noJavaHome
-if not exist "%JAVA_HOME%\bin\javaw.exe" goto noJavaHome
 if not "%JRE_HOME%" == "" goto okJavaHome
 set "JRE_HOME=%JAVA_HOME%"
 goto okJavaHome
 :preJava9Layout
-if not exist "%JAVA_HOME%\jre\bin\javaw.exe" goto noJavaHome
 if not "%JRE_HOME%" == "" goto okJavaHome
 set "JRE_HOME=%JAVA_HOME%\jre"
 goto okJavaHome

Modified: tomcat/trunk/bin/setclasspath.bat
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/setclasspath.bat?rev=1832965=1832964=1832965=diff
==
--- tomcat/trunk/bin/setclasspath.bat (original)
+++ tomcat/trunk/bin/setclasspath.bat Tue Jun  5 19:14:42 2018
@@ -36,7 +36,6 @@ goto exit
 rem Check if we have a usable JDK
 if "%JAVA_HOME%" == "" goto noJavaHome
 if not exist "%JAVA_HOME%\bin\java.exe" goto noJavaHome
-if not exist "%JAVA_HOME%\bin\javaw.exe" goto noJavaHome
 if not exist "%JAVA_HOME%\bin\jdb.exe" goto noJavaHome
 if not exist "%JAVA_HOME%\bin\javac.exe" goto noJavaHome
 set "JRE_HOME=%JAVA_HOME%"
@@ -55,7 +54,6 @@ set "JRE_HOME=%JAVA_HOME%"
 :gotJreHome
 rem Check if we have a usable JRE
 if not exist "%JRE_HOME%\bin\java.exe" goto noJreHome
-if not exist "%JRE_HOME%\bin\javaw.exe" goto noJreHome
 goto okJava
 
 :noJreHome

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832965=1832964=1832965=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jun  5 19:14:42 2018
@@ -290,6 +290,11 @@
   
 52381: Add OSGi metadata to JAR files, (markt)
   
+  
+62391: Remove references to javaw.exe as this
+file is not required by Tomcat and the references prevent the use if 
the
+Server JRE. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-trunk

2018-06-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3341

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1832961
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832963 - in /tomcat/trunk: java/org/apache/juli/ test/org/apache/catalina/authenticator/ test/org/apache/catalina/connector/ test/org/apache/catalina/core/ test/org/apache/catalina/nonbl

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 19:04:01 2018
New Revision: 1832963

URL: http://svn.apache.org/viewvc?rev=1832963=rev
Log:
SpotBugs: Make fields static

Modified:
tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java
tomcat/trunk/java/org/apache/juli/FileHandler.java
tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAuthParser.java
tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java
tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java

tomcat/trunk/test/org/apache/catalina/session/TestPersistentManagerIntegration.java

Modified: tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java?rev=1832963=1832962=1832963=diff
==
--- tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java (original)
+++ tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java Tue Jun  5 19:04:01 
2018
@@ -147,7 +147,6 @@ public class AsyncFileHandler extends Fi
 }
 
 protected static class LoggerThread extends Thread {
-protected final boolean run = true;
 public LoggerThread() {
 this.setDaemon(true);
 this.setName("AsyncFileHandlerWriter-" + 
System.identityHashCode(this));
@@ -155,7 +154,7 @@ public class AsyncFileHandler extends Fi
 
 @Override
 public void run() {
-while (run) {
+while (true) {
 try {
 LogEntry entry = queue.poll(LOGGER_SLEEP_TIME, 
TimeUnit.MILLISECONDS);
 if (entry != null) {

Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/FileHandler.java?rev=1832963=1832962=1832963=diff
==
--- tomcat/trunk/java/org/apache/juli/FileHandler.java (original)
+++ tomcat/trunk/java/org/apache/juli/FileHandler.java Tue Jun  5 19:04:01 2018
@@ -99,10 +99,10 @@ public class FileHandler extends Handler
 
 private static final ExecutorService DELETE_FILES_SERVICE =
 Executors.newSingleThreadExecutor(new ThreadFactory() {
+private static final String NAME_PREFIX = 
"FileHandlerLogFilesCleaner-";
 private final boolean isSecurityEnabled;
 private final ThreadGroup group;
 private final AtomicInteger threadNumber = new 
AtomicInteger(1);
-private final String namePrefix = 
"FileHandlerLogFilesCleaner-";
 
 {
 SecurityManager s = System.getSecurityManager();
@@ -131,7 +131,7 @@ public class FileHandler extends Handler
 
.setContextClassLoader(getClass().getClassLoader());
 }
 Thread t = new Thread(group, r,
-namePrefix + threadNumber.getAndIncrement());
+NAME_PREFIX + threadNumber.getAndIncrement());
 t.setDaemon(true);
 return t;
 } finally {

Modified: 
tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAuthParser.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAuthParser.java?rev=1832963=1832962=1832963=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAuthParser.java 
(original)
+++ 
tomcat/trunk/test/org/apache/catalina/authenticator/TestBasicAuthParser.java 
Tue Jun  5 19:04:01 2018
@@ -465,9 +465,8 @@ public class TestBasicAuthParser {
  */
 private static final class BasicAuthHeader {
 
-private  final String HTTP_AUTH = "authorization: ";
-private  final byte[] HEADER =
-HTTP_AUTH.getBytes(StandardCharsets.ISO_8859_1);
+private static final byte[] HEADER =
+"authorization: ".getBytes(StandardCharsets.ISO_8859_1);
 private ByteChunk authHeader;
 private int initialOffset = 0;
 

Modified: 
tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java?rev=1832963=1832962=1832963=diff
==
--- 
tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java 
(original)
+++ 
tomcat/trunk/test/org/apache/catalina/connector/TestResponsePerformance.java 
Tue Jun  5 19:04:01 2018
@@ -26,7 +26,7 @@ import org.apache.tomcat.unittest.Tester
 
 public class TestResponsePerformance extends LoggingBaseTest {
 
-private final int 

svn commit: r1832961 - /tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 18:49:14 2018
New Revision: 1832961

URL: http://svn.apache.org/viewvc?rev=1832961=rev
Log:
SpotBugs: Inner class should be static

Modified:
tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java?rev=1832961=1832960=1832961=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AbstractAccessLogValve.java 
Tue Jun  5 18:49:14 2018
@@ -809,7 +809,7 @@ public abstract class AbstractAccessLogV
 /**
  * write local IP address - %A
  */
-protected class LocalAddrElement implements AccessLogElement {
+protected static class LocalAddrElement implements AccessLogElement {
 
 private final String localAddrValue;
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832959 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/tomcat/websocket/TestWsPingPongMessages.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 18:32:27 2018
New Revision: 1832959

URL: http://svn.apache.org/viewvc?rev=1832959=rev
Log:
SpotBugs: Use of new String(String)

Modified:
tomcat/trunk/res/findbugs/filter-false-positives.xml
tomcat/trunk/test/org/apache/tomcat/websocket/TestWsPingPongMessages.java

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1832959=1832958=1832959=diff
==
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Tue Jun  5 18:32:27 
2018
@@ -179,6 +179,12 @@
 
   
   
+
+
+
+
+  
+  
 
 
 

Modified: 
tomcat/trunk/test/org/apache/tomcat/websocket/TestWsPingPongMessages.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/websocket/TestWsPingPongMessages.java?rev=1832959=1832958=1832959=diff
==
--- tomcat/trunk/test/org/apache/tomcat/websocket/TestWsPingPongMessages.java 
(original)
+++ tomcat/trunk/test/org/apache/tomcat/websocket/TestWsPingPongMessages.java 
Tue Jun  5 18:32:27 2018
@@ -40,8 +40,7 @@ import org.apache.tomcat.websocket.Teste
 
 public class TestWsPingPongMessages extends WebSocketBaseTest {
 
-ByteBuffer applicationData =
-ByteBuffer.wrap(new 
String("mydata").getBytes(StandardCharsets.UTF_8));
+ByteBuffer applicationData = 
ByteBuffer.wrap("mydata".getBytes(StandardCharsets.UTF_8));
 
 @Test
 public void testPingPongMessages() throws Exception {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat 8.0 EOL has announced. When EOL of 8.5 is expected?

2018-06-05 Thread Ignat Alexeyenko
Hi Mark!

Thanks for the quick and detailed response - that makes things much easier
to plan on our end.

Cheers,
Ignat Alexeyenko
Atlassian

On Tue, Jun 5, 2018 at 5:32 PM, Mark Thomas  wrote:

> On 05/06/18 14:58, Ignat Alexeyenko wrote:
> > Hello, everyone!
> >
> > Just found out today that Tomcat 8.0 reaches end of life this months.
> Could
> > you please advice on approximate timeframe for how long 8.5 version is
> > going to be supported, so we could plan our upgrades.
>
> There is currently no planned EOL date for 8.5.x.
>
> The Tomcat community currently supports (at least) 3 versions in
> parallel. As of 1 July 2018 those versions will be:
> 7.0.x
> 8.5.x
> 9.0.x
>
> We have also stated that we will give at least 12 months notice of the
> EOL of any release line.
>
> EOL for 7.0.x will depend on the timescales for Tomcat 10.
>
> Major Tomcat versions have been aligned with releases of the Java EE
> specification. With the move of Java EE to Jakarta EE at the Eclipse
> Foundation, the future plans and timescales for all components are
> uncertain.
>
> My best guess at this point is that major versions of Tomcat will follow
> releases of the Servlet specification. There is currently no timescale
> for the next release of the Servlet specification. December 2018 has
> been mentioned as a tentative date for the next release but the schedule
> that was part of has already slipped so it looks unlikely.
>
> At this point I don't see EOL for Tomcat 7.0.x being announced before 31
> December 2018 meaning EOL for 7.0.x would not be until at least 31
> December 2019. Those are the earliest possible dates. A slip of at least
> 6 to 12 months would not surprise me.
>
> At this point, dates for 8.5.x EOL are impossible to predict with any
> more accuracy than "several years" after 7.0.x EOL.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


svn commit: r1832958 - in /tomcat/trunk/java/org/apache/catalina: core/ApplicationFilterConfig.java filters/CorsFilter.java filters/RemoteIpFilter.java filters/RequestDumperFilter.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 17:56:22 2018
New Revision: 1832958

URL: http://svn.apache.org/viewvc?rev=1832958=rev
Log:
Making Log instances non-static triggered a few SpotBugs warnings around 
Serialization. Fix them.

Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/trunk/java/org/apache/catalina/filters/RequestDumperFilter.java

Modified: 
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java?rev=1832958=1832957=1832958=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java Tue 
Jun  5 17:56:22 2018
@@ -14,11 +14,11 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
 package org.apache.catalina.core;
 
 
+import java.io.IOException;
+import java.io.ObjectInputStream;
 import java.io.Serializable;
 import java.util.Collections;
 import java.util.Enumeration;
@@ -61,7 +61,7 @@ public final class ApplicationFilterConf
 static final StringManager sm =
 StringManager.getManager(Constants.Package);
 
-private final Log log = LogFactory.getLog(ApplicationFilterConfig.class); 
// must not be static
+private transient Log log = 
LogFactory.getLog(ApplicationFilterConfig.class); // must not be static
 
 /**
  * Empty String collection to serve as the basis for empty enumerations.
@@ -403,4 +403,14 @@ public final class ApplicationFilterConf
 }
 
 }
+
+
+/*
+ * Log objects are not Serializable.
+ */
+private void readObject(ObjectInputStream ois) throws 
ClassNotFoundException, IOException {
+ois.defaultReadObject();
+log = LogFactory.getLog(ApplicationFilterConfig.class);
+}
+
 }

Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java?rev=1832958=1832957=1832958=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java Tue Jun  5 
17:56:22 2018
@@ -17,6 +17,7 @@
 package org.apache.catalina.filters;
 
 import java.io.IOException;
+import java.io.ObjectInputStream;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.util.Arrays;
@@ -79,9 +80,10 @@ import org.apache.tomcat.util.res.String
 public class CorsFilter extends GenericFilter {
 
 private static final long serialVersionUID = 1L;
-private final Log log = LogFactory.getLog(CorsFilter.class); // must not 
be static
 private static final StringManager sm = 
StringManager.getManager(CorsFilter.class);
 
+private transient Log log = LogFactory.getLog(CorsFilter.class); // must 
not be static
+
 
 /**
  * A {@link Collection} of origins consisting of zero or more origins that
@@ -909,7 +911,19 @@ public class CorsFilter extends GenericF
 }
 
 
+/*
+ * Log objects are not Serializable but this Filter is because it extends
+ * GenericFilter. Tomcat won't serialize a Filter but in case something 
else
+ * does...
+ */
+private void readObject(ObjectInputStream ois) throws 
ClassNotFoundException, IOException {
+ois.defaultReadObject();
+log = LogFactory.getLog(CorsFilter.class);
+}
+
+
 // -- CORS Response Headers
+
 /**
  * The Access-Control-Allow-Origin header indicates whether a resource can
  * be shared based by returning the value of the Origin request header in

Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java?rev=1832958=1832957=1832958=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Tue Jun  
5 17:56:22 2018
@@ -17,6 +17,7 @@
 package org.apache.catalina.filters;
 
 import java.io.IOException;
+import java.io.ObjectInputStream;
 import java.text.DateFormat;
 import java.text.ParseException;
 import java.text.SimpleDateFormat;
@@ -656,7 +657,7 @@ public class RemoteIpFilter extends Gene
 
 // Log must be non-static as loggers are created per class-loader and this
 // Filter may be used in multiple class loaders
-private final Log log = 

Re: Tomcat 8.0 EOL has announced. When EOL of 8.5 is expected?

2018-06-05 Thread Mark Thomas
On 05/06/18 14:58, Ignat Alexeyenko wrote:
> Hello, everyone!
> 
> Just found out today that Tomcat 8.0 reaches end of life this months. Could
> you please advice on approximate timeframe for how long 8.5 version is
> going to be supported, so we could plan our upgrades.

There is currently no planned EOL date for 8.5.x.

The Tomcat community currently supports (at least) 3 versions in
parallel. As of 1 July 2018 those versions will be:
7.0.x
8.5.x
9.0.x

We have also stated that we will give at least 12 months notice of the
EOL of any release line.

EOL for 7.0.x will depend on the timescales for Tomcat 10.

Major Tomcat versions have been aligned with releases of the Java EE
specification. With the move of Java EE to Jakarta EE at the Eclipse
Foundation, the future plans and timescales for all components are
uncertain.

My best guess at this point is that major versions of Tomcat will follow
releases of the Servlet specification. There is currently no timescale
for the next release of the Servlet specification. December 2018 has
been mentioned as a tentative date for the next release but the schedule
that was part of has already slipped so it looks unlikely.

At this point I don't see EOL for Tomcat 7.0.x being announced before 31
December 2018 meaning EOL for 7.0.x would not be until at least 31
December 2019. Those are the earliest possible dates. A slip of at least
6 to 12 months would not surprise me.

At this point, dates for 8.5.x EOL are impossible to predict with any
more accuracy than "several years" after 7.0.x EOL.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Tomcat 8.0 EOL has announced. When EOL of 8.5 is expected?

2018-06-05 Thread Ignat Alexeyenko
Hello, everyone!

Just found out today that Tomcat 8.0 reaches end of life this months. Could
you please advice on approximate timeframe for how long 8.5 version is
going to be supported, so we could plan our upgrades.

Thanks!

P.S.: I wasn't able to find the question on the website, so a minor
suggestion from me is to update the docs to have the info.

Cheers,
Ignat Alexeyenko
Atlassian


Re: svn commit: r1832936 - /tomcat/native/trunk/native/src/sslutils.c

2018-06-05 Thread Mark Thomas
On 05/06/18 13:55, jfcl...@apache.org wrote:
> Author: jfclere
> Date: Tue Jun  5 12:55:05 2018
> New Revision: 1832936
> 
> URL: http://svn.apache.org/viewvc?rev=1832936=rev
> Log:
> ssl_ocsp_request() sets the error correctly already.
> 
> Modified:
> tomcat/native/trunk/native/src/sslutils.c
> 
> Modified: tomcat/native/trunk/native/src/sslutils.c
> URL: 
> http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslutils.c?rev=1832936=1832935=1832936=diff
> ==
> --- tomcat/native/trunk/native/src/sslutils.c (original)
> +++ tomcat/native/trunk/native/src/sslutils.c Tue Jun  5 12:55:05 2018
> @@ -532,7 +532,7 @@ static int ssl_verify_OCSP(int ok, X509_
>  break;
>  case OCSP_STATUS_UNKNOWN:
>  /* correct error code for application errors? */
> -X509_STORE_CTX_set_error(ctx, 
> X509_V_ERR_APPLICATION_VERIFICATION);
> +// X509_STORE_CTX_set_error(ctx, 
> X509_V_ERR_APPLICATION_VERIFICATION);

Better to remove these two lines and replace with a comment along the
lines of the log message above?

Mark


>  break;
>  }
>  }
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832936 - /tomcat/native/trunk/native/src/sslutils.c

2018-06-05 Thread jfclere
Author: jfclere
Date: Tue Jun  5 12:55:05 2018
New Revision: 1832936

URL: http://svn.apache.org/viewvc?rev=1832936=rev
Log:
ssl_ocsp_request() sets the error correctly already.

Modified:
tomcat/native/trunk/native/src/sslutils.c

Modified: tomcat/native/trunk/native/src/sslutils.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslutils.c?rev=1832936=1832935=1832936=diff
==
--- tomcat/native/trunk/native/src/sslutils.c (original)
+++ tomcat/native/trunk/native/src/sslutils.c Tue Jun  5 12:55:05 2018
@@ -532,7 +532,7 @@ static int ssl_verify_OCSP(int ok, X509_
 break;
 case OCSP_STATUS_UNKNOWN:
 /* correct error code for application errors? */
-X509_STORE_CTX_set_error(ctx, X509_V_ERR_APPLICATION_VERIFICATION);
+// X509_STORE_CTX_set_error(ctx, 
X509_V_ERR_APPLICATION_VERIFICATION);
 break;
 }
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-8-trunk

2018-06-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-8-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1338

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-8-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.0.x/trunk] 1832927
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62376] PropertyNotFoundException since 8.5.25

2018-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62376

--- Comment #3 from Mark Thomas  ---
Without a test case that demonstrates this issue, this bug report is going to
be resolved as INVALID based on the analysis in comment #1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832928 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 09:42:30 2018
New Revision: 1832928

URL: http://svn.apache.org/viewvc?rev=1832928=rev
Log:
Include ::1 as well as 0:0:0:0:0:0:0:1 in the internal proxy list as APR 
returns ::1 rather than 0:0:0:0:0:0:0:1.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/RemoteIpValve.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 09:42:30 2018
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 
725974,1726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,1739821,1739981,1740513,1740726,1741019,1741162,1741217,1743647,1743681,1744152,1744272,1746732,1746750,1752739,1754615,1755886,1756018,1758563,1759565,1761686,1762173,1762206,1766280,1767507-1767508,1767653,1767656,1769267,1772949,1773521,1773527,1774104,1777015,1777213,1779330,1783151,1784188,1784966,1785670,1786846,1788260,1788999,1789140,1789402,1791529,1791559,1795291,1796906,1797523,1799214,1800998-1800999,1801003,1801007-1801008,1801017,1801020,1802808,180281
 

svn commit: r1832927 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 09:41:50 2018
New Revision: 1832927

URL: http://svn.apache.org/viewvc?rev=1832927=rev
Log:
Include ::1 as well as 0:0:0:0:0:0:0:1 in the internal proxy list as APR 
returns ::1 rather than 0:0:0:0:0:0:0:1.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/valves/RemoteIpValve.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 09:41:50 2018
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719,1779898,1782037,1782240,1782386-1782387,1785669,1786845,1788249,1788324,1788905,1789216,1789335,1791528,1791558,1796697-1796698,1797521,1798543,1799162,1800143,1801693,1802805,1806799,1807079-1807080,1808880,1809831,1812093,1812143,1812145,1812319,1814975,1815945,1815956,1820207,1822186,1823164,1823497,1824960,1826872-1826873,1827862,1829310,1829777,1829796,1829935,1830215,1830991,1831042,1831557,1831569,1832269,1832271,1832693
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 

svn commit: r1832926 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 09:41:34 2018
New Revision: 1832926

URL: http://svn.apache.org/viewvc?rev=1832926=rev
Log:
Include ::1 as well as 0:0:0:0:0:0:0:1 in the internal proxy list as APR 
returns ::1 rather than 0:0:0:0:0:0:0:1.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/valves/RemoteIpValve.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun  5 09:41:34 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 

svn commit: r1832925 - in /tomcat/trunk/java/org/apache/catalina: filters/RemoteIpFilter.java valves/RemoteIpValve.java

2018-06-05 Thread markt
Author: markt
Date: Tue Jun  5 09:41:05 2018
New Revision: 1832925

URL: http://svn.apache.org/viewvc?rev=1832925=rev
Log:
Include ::1 as well as 0:0:0:0:0:0:0:1 in the internal proxy list as APR 
returns ::1 rather than 0:0:0:0:0:0:0:1.

Modified:
tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java

Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java?rev=1832925=1832924=1832925=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Tue Jun  
5 09:41:05 2018
@@ -115,7 +115,7 @@ import org.apache.juli.logging.LogFactor
  * 169\.254\.\d{1,3}\.\d{1,3}|127\.\d{1,3}\.\d{1,3}\.\d{1,3}|
  * 172\.1[6-9]{1}\.\d{1,3}\.\d{1,3}|172\.2[0-9]{1}\.\d{1,3}\.\d{1,3}|
  * 172\.3[0-1]{1}\.\d{1,3}\.\d{1,3}|
- * 0:0:0:0:0:0:0:1
+ * 0:0:0:0:0:0:0:1|::1
  * 
  * By default, 10/8, 192.168/16, 169.254/16, 127/8, 172.16/12, and 
0:0:0:0:0:0:0:1 are allowed.
  * 
@@ -727,7 +727,7 @@ public class RemoteIpFilter extends Gene
 "172\\.1[6-9]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
 "172\\.2[0-9]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
 "172\\.3[0-1]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
-"0:0:0:0:0:0:0:1");
+"0:0:0:0:0:0:0:1|::1");
 
 /**
  * @see #setProtocolHeader(String)

Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?rev=1832925=1832924=1832925=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java Tue Jun  5 
09:41:05 2018
@@ -94,7 +94,7 @@ import org.apache.tomcat.util.http.MimeH
  * 169\.254\.\d{1,3}\.\d{1,3}|127\.\d{1,3}\.\d{1,3}\.\d{1,3}|
  * 172\.1[6-9]{1}\.\d{1,3}\.\d{1,3}|172\.2[0-9]{1}\.\d{1,3}\.\d{1,3}|
  * 172\.3[0-1]{1}\.\d{1,3}\.\d{1,3}|
- * 0:0:0:0:0:0:0:1
+ * 0:0:0:0:0:0:0:1|::1
  * 
  * By default, 10/8, 192.168/16, 169.254/16, 127/8, 172.16/12, and ::1 are 
allowed.
  * 
@@ -415,7 +415,7 @@ public class RemoteIpValve extends Valve
 "172\\.1[6-9]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
 "172\\.2[0-9]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
 "172\\.3[0-1]{1}\\.\\d{1,3}\\.\\d{1,3}|" +
-"0:0:0:0:0:0:0:1");
+"0:0:0:0:0:0:0:1|::1");
 
 /**
  * @see #setProtocolHeader(String)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn commit: r1832863 - /tomcat/native/trunk/native/src/sslutils.c

2018-06-05 Thread jean-frederic clere
On 04/06/18 18:02, jfcl...@apache.org wrote:
> +++ tomcat/native/trunk/native/src/sslutils.c Mon Jun  4 16:02:26 2018
> @@ -532,7 +532,7 @@ static int ssl_verify_OCSP(int ok, X509_
>  break;
>  case OCSP_STATUS_UNKNOWN:
>  /* correct error code for application errors? */
> -// X509_STORE_CTX_set_error(ctx, 
> X509_V_ERR_APPLICATION_VERIFICATION);
> +X509_STORE_CTX_set_error(ctx, 
> X509_V_ERR_APPLICATION_VERIFICATION);
>  break;
>  }
>  }

Oops that is bad I need to review again...

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832914 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java webapps/docs/changelog.xml

2018-06-05 Thread kfujino
Author: kfujino
Date: Tue Jun  5 07:32:13 2018
New Revision: 1832914

URL: http://svn.apache.org/viewvc?rev=1832914=rev
Log:
When sending the GET_ALL_SESSIONS message, make sure that sends with 
asynchronous option in order to avoid ack timeout.
Waiting to receive the ALL_SESSION_DATA message should be done with 
waitForSendAllSessions instead of ACK.

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1832914=1832913=1832914=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaManager.java Tue Jun  
5 07:32:13 2018
@@ -747,7 +747,7 @@ public class DeltaManager extends Cluste
 synchronized(receivedMessageQueue) {
  receiverQueue = true ;
 }
-cluster.send(msg, mbr);
+cluster.send(msg, mbr, Channel.SEND_OPTIONS_ASYNCHRONOUS);
 if (log.isInfoEnabled())
 log.info(sm.getString("deltaManager.waitForSessionState",
 getName(), mbr, 
Integer.valueOf(getStateTransferTimeout(;

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1832914=1832913=1832914=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Tue Jun  5 07:32:13 2018
@@ -238,6 +238,12 @@
   
 Add the method to send a message with a specified sendOptions. 
(kfujino)
   
+  
+When sending the GET_ALL_SESSIONS message, make sure that
+sends with asynchronous option in order to avoid ack timeout. Waiting 
to
+receive the ALL_SESSION_DATA message should be done with
+waitForSendAllSessions instead of ACK. (kfujino)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1832911 - /tomcat/native/trunk/native/src/ssl.c

2018-06-05 Thread jfclere
Author: jfclere
Date: Tue Jun  5 06:06:06 2018
New Revision: 1832911

URL: http://svn.apache.org/viewvc?rev=1832911=rev
Log:
Adjust the code like httpd one. Possible fix for PR#62122

Modified:
tomcat/native/trunk/native/src/ssl.c

Modified: tomcat/native/trunk/native/src/ssl.c
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/ssl.c?rev=1832911=1832910=1832911=diff
==
--- tomcat/native/trunk/native/src/ssl.c (original)
+++ tomcat/native/trunk/native/src/ssl.c Tue Jun  5 06:06:06 2018
@@ -364,8 +364,10 @@ static apr_status_t ssl_init_cleanup(voi
 ENGINE_cleanup();
 #endif
 #if OPENSSL_VERSION_NUMBER >= 0x1000200fL
+#ifndef OPENSSL_NO_COMP
 SSL_COMP_free_compression_methods();
 #endif
+#endif
 CRYPTO_cleanup_all_ex_data();
 #if OPENSSL_VERSION_NUMBER < 0x1010L || defined(LIBRESSL_VERSION_NUMBER)
 ERR_remove_thread_state(NULL);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62122] undefined symbol: SSL_COMP_free_compression_methods

2018-06-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62122

--- Comment #4 from jfclere  ---
I think the problen is fixed by r1832911.
Could you please retest?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org