Tag Tomcat 7

2018-11-07 Thread Violeta Georgieva
Hi,

I'm planning to tag Tomcat 7 later today.
If you want to include something please reply here.

Regards,
Violeta


Re: L10n / I18n

2018-11-07 Thread Emmanuel Bourg
Le 07/11/2018 à 23:36, Mark Thomas a écrit :

> WDYT?

What about simplifying the issue by dropping the translations of the
internal messages and retaining only the user facing messages (things
like HTTP error messages that can appear in a normal request) ?

I think it's worth considering because:
- The target audience of Tomcat is mainly developers and administrators
which are used to read English text.
- The coverage of the translations is rather low.
- Maintaining the translations, the quality and the consistency is
difficult and time consuming.
- Sometimes the translation of the technical terms are a bit unusual and
not as clear as the English counterpart. For example in French it isn't
obvious that "gestionnaire de protocole" relates to ProtocolHandler
which is an internal Tomcat concept. Other translations are even funny
like "enrobeur de conteneur" for "wrapper container" (a pastry concept
applied to a freight container?). This issue is so common with the
French translation that many messages carry the English terms in
parentheses to clarify the meaning.

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846086 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 23:14:00 2018
New Revision: 1846086

URL: http://svn.apache.org/viewvc?rev=1846086=rev
Log:
Add release date

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1846086=1846085=1846086=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Wed Nov  7 23:14:00 2018
@@ -59,7 +59,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r30754 - /dev/tomcat/tomcat-8/v8.5.35/ /release/tomcat/tomcat-8/v8.5.35/

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 23:13:11 2018
New Revision: 30754

Log:
Release Apache Tomcat 8.5.35

Added:
release/tomcat/tomcat-8/v8.5.35/
  - copied from r30753, dev/tomcat/tomcat-8/v8.5.35/
Removed:
dev/tomcat/tomcat-8/v8.5.35/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat 9.0.13

2018-11-07 Thread Mark Thomas
Just adding [RESULT] to the subject for the benefit of the archives.

Mark


On 07/11/2018 23:04, Mark Thomas wrote:
> The following votes were cast:
> 
> Binding:
> +1: remm, markt, violetagg, csutherl, fschumacher
> 
> Non-binding:
> +1: isapir, rmannibucau
> 
> The vote therefore passes.
> 
> Thank you to everyone who contributed to this release.
> 
> Mark
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][RESULT] Release Apache Tomcat 8.5.35

2018-11-07 Thread Mark Thomas
The following votes were cast:

Binding:
+1: schultz, remm, fschumacher, violetagg, ebourg

Non-binding:
+1: isapir

The vote therefore passes.

Thanks to everyone who contributed towards this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r30753 - /dev/tomcat/tomcat-9/v9.0.13/ /release/tomcat/tomcat-9/v9.0.13/

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 23:05:45 2018
New Revision: 30753

Log:
Release Apache Tomcat 9.0.13

Added:
release/tomcat/tomcat-9/v9.0.13/
  - copied from r30752, dev/tomcat/tomcat-9/v9.0.13/
Removed:
dev/tomcat/tomcat-9/v9.0.13/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846085 - /tomcat/trunk/webapps/docs/changelog.xml

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 23:05:14 2018
New Revision: 1846085

URL: http://svn.apache.org/viewvc?rev=1846085=rev
Log:
Add release date

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846085=1846084=1846085=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Nov  7 23:05:14 2018
@@ -67,7 +67,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-07 Thread Mark Thomas
The following votes were cast:

Binding:
+1: remm, markt, violetagg, csutherl, fschumacher

Non-binding:
+1: isapir, rmannibucau

The vote therefore passes.

Thank you to everyone who contributed to this release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846084 - in /tomcat/trunk: build.xml conf/catalina.properties res/maven/mvn-pub.xml res/maven/tomcat-i18n-de.pom webapps/docs/changelog.xml

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 22:59:14 2018
New Revision: 1846084

URL: http://svn.apache.org/viewvc?rev=1846084=rev
Log:
Include the available German translations in the standard Tomcat distribution.

Added:
tomcat/trunk/res/maven/tomcat-i18n-de.pom   (with props)
Modified:
tomcat/trunk/build.xml
tomcat/trunk/conf/catalina.properties
tomcat/trunk/res/maven/mvn-pub.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1846084=1846083=1846084=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Wed Nov  7 22:59:14 2018
@@ -902,6 +902,16 @@
   addOSGi="true" />
 
 
+
+  
+
+  
+  
+  
+
 
   

Modified: tomcat/trunk/conf/catalina.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/catalina.properties?rev=1846084=1846083=1846084=diff
==
--- tomcat/trunk/conf/catalina.properties (original)
+++ tomcat/trunk/conf/catalina.properties Wed Nov  7 22:59:14 2018
@@ -172,6 +172,7 @@ tagsoup-*.jar,\
 tomcat-api.jar,\
 tomcat-coyote.jar,\
 tomcat-dbcp.jar,\
+tomcat-i18n-de.jar,\
 tomcat-i18n-en.jar,\
 tomcat-i18n-es.jar,\
 tomcat-i18n-fr.jar,\

Modified: tomcat/trunk/res/maven/mvn-pub.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn-pub.xml?rev=1846084=1846083=1846084=diff
==
--- tomcat/trunk/res/maven/mvn-pub.xml (original)
+++ tomcat/trunk/res/maven/mvn-pub.xml Wed Nov  7 22:59:14 2018
@@ -438,6 +438,7 @@
 
 
 
+
 
 
 

Added: tomcat/trunk/res/maven/tomcat-i18n-de.pom
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/maven/tomcat-i18n-de.pom?rev=1846084=auto
==
--- tomcat/trunk/res/maven/tomcat-i18n-de.pom (added)
+++ tomcat/trunk/res/maven/tomcat-i18n-de.pom Wed Nov  7 22:59:14 2018
@@ -0,0 +1,32 @@
+
+
+
+  4.0.0
+  org.apache.tomcat
+  tomcat-i18n-de
+  @MAVEN.DEPLOY.VERSION@
+  Russian translations
+  https://tomcat.apache.org/
+  
+
+  Apache License, Version 2.0
+  http://www.apache.org/licenses/LICENSE-2.0.txt
+  repo
+
+  
+

Propchange: tomcat/trunk/res/maven/tomcat-i18n-de.pom
--
svn:eol-style = native

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846084=1846083=1846084=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Nov  7 22:59:14 2018
@@ -60,6 +60,10 @@
 Fix storeconfig for the cluster encryption interceptor key attribute.
 (remm)
   
+  
+Include German translations for the Manager application in the standard
+Tomcat distribution. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



L10n / I18n

2018-11-07 Thread Mark Thomas
Hi,

After looking at bug 62843, I got thinking about tools to help manage
translations from contributors. Something that would show the key, the
original value and the translated value side by side.

I looked at Pootle but that was more run it yourself. My preference was
for something that was hosted. I then looked at POEditor (poeditor.com)
and that seemed to fit the bill.

It seems that these tools all expect a single file per language (at leat
the two I have looked at so far do) so I wrote some code to merge the
LocalString.properties files into a single file per language (I prefixed
the keys with the package name to ensure they remained unique).

Having uploaded these, the tool identified ~20 keys that existed in
translations but not in the original. Hence the handful of commits this
afternoon cleaning those up.

What we are left with is the following:

French 18%
German  2%
Japanese   21%
Portuguese  1%
Russian 8%
Spanish42%

(% is the number of keys translated into that language)

POEditor offer free unlimited plans for OSI approved licensed software
(that includes Tomcat).

What I would like to do is announce this on the users list and invite
contributors to start adding translations - potentially for new languages.

However, there is a catch. How to get the translations back into Tomcat?
I'll need to write some more code to do this - that isn't an issue. The
issue is that retaining the current comments and ordering in the
translated files would be a LOT of work. It would be a lot easier if I
could just write the keys out in alphabetical order with each block
(determined by the key value up to the first period) separated by a
blank line. Would that be acceptable?

If it is, I'll clean the English files up by hand so that the comments
are retained for those files.

WDYT?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846079 - in /tomcat/trunk/java/org/apache: coyote/http11/LocalStrings_es.properties tomcat/util/net/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 21:04:56 2018
New Revision: 1846079

URL: http://svn.apache.org/viewvc?rev=1846079=rev
Log:
Move string to correct package and rename

Modified:
tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties

Modified: tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties?rev=1846079=1846078=1846079=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/coyote/http11/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 21:04:56 2018
@@ -20,7 +20,6 @@ http11processor.request.process = Error
 http11processor.request.finish = Error acabando requerimiento
 http11processor.response.finish = Error acabando respuesta
 http11processor.socket.info = Excepción obteniendo información de conector
-http11processor.socket.sslreneg = Excepción renegociando la conexión SSL
 iib.eof.error = Inesperado Fin De Archivo (EOF) leído en el enchufe (socket)
 iib.requestheadertoolarge.error = La cabecera del requerimiento es demasido 
grande
 iib.invalidmethod = Carácter inválido (CR o LF) hallado en el nombre del método

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties?rev=1846079=1846078=1846079=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 21:04:56 2018
@@ -37,3 +37,5 @@ endpoint.apr.invalidSslProtocol = Se ha
 
 jsse.invalid_truststore_password = La clave del almacén de confianza 
suministrada no se pudo usar para desbloquear y/o validar el almacén de 
confianza. Reintentando acceder el almacén de confianza con una clave nula que 
se saltará la validación.
 jsse.keystore_load_failed = No pude cargar almacén de claves de tipo [{0}] con 
ruta [{1}] debido a [{2}]
+
+socket.sslreneg = Excepción renegociando la conexión SSL



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846078 - in /tomcat/trunk/java: javax/servlet/http/LocalStrings_es.properties javax/servlet/http/LocalStrings_fr.properties javax/servlet/http/LocalStrings_ja.properties org/apache/tomca

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 21:02:12 2018
New Revision: 1846078

URL: http://svn.apache.org/viewvc?rev=1846078=rev
Log:
Remove values that are no longer used

Modified:
tomcat/trunk/java/javax/servlet/http/LocalStrings_es.properties
tomcat/trunk/java/javax/servlet/http/LocalStrings_fr.properties
tomcat/trunk/java/javax/servlet/http/LocalStrings_ja.properties
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties

Modified: tomcat/trunk/java/javax/servlet/http/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/LocalStrings_es.properties?rev=1846078=1846077=1846078=diff
==
--- tomcat/trunk/java/javax/servlet/http/LocalStrings_es.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/javax/servlet/http/LocalStrings_es.properties [UTF-8] Wed 
Nov  7 21:02:12 2018
@@ -15,7 +15,6 @@
 
 err.cookie_name_is_token = El nombre de Cookie [{0}] es una palabra reservada
 err.cookie_name_blank = El nombre del Cookie no puede ser nulo o de longitud 
cero
-err.io.negativelength = Longitud Negativa en el metodo write
 err.io.short_read = Lectura Corta
 http.method_not_implemented = El Metodo [{0}] no esta implementado por este 
servlet para esta URI
 http.method_get_not_supported = El Metodo HTTP GET no está soportado por esta 
URL

Modified: tomcat/trunk/java/javax/servlet/http/LocalStrings_fr.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/LocalStrings_fr.properties?rev=1846078=1846077=1846078=diff
==
--- tomcat/trunk/java/javax/servlet/http/LocalStrings_fr.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/javax/servlet/http/LocalStrings_fr.properties [UTF-8] Wed 
Nov  7 21:02:12 2018
@@ -17,7 +17,6 @@
 # Localized for Locale fr_FR
 
 err.cookie_name_is_token=Le nom de cookie [{0}] est un "token" réservé
-err.io.negativelength=Taille négative donnée dans la méthode "write"
 err.io.short_read=Lecture partielle
 
 http.method_not_implemented=Le méthode [{0}] n''est pas définie dans la RFC 
2068 et n''est pas supportée par l''API Servlet

Modified: tomcat/trunk/java/javax/servlet/http/LocalStrings_ja.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/LocalStrings_ja.properties?rev=1846078=1846077=1846078=diff
==
--- tomcat/trunk/java/javax/servlet/http/LocalStrings_ja.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/javax/servlet/http/LocalStrings_ja.properties [UTF-8] Wed 
Nov  7 21:02:12 2018
@@ -17,7 +17,6 @@
 # Localized for Locale ja_JP
 
 err.cookie_name_is_token=クッキー名 [{0}] は予約済のトークンです。
-err.io.negativelength=writeメソッドに負の長さが指定されました。
 err.io.short_read=読み込みがすぐに終わりました。
 
 http.method_not_implemented=メソッド [{0}] はRFC 
2068には定義されておらず、サーブレットAPIではサポートされません。

Modified: 
tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties?rev=1846078=1846077=1846078=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 21:02:12 2018
@@ -29,7 +29,6 @@ endpoint.poll.error = Error inesperado d
 endpoint.process.fail = Error reservando procesador de conector
 endpoint.sendfile.error = Error inesperado de envío de fichero
 endpoint.sendfile.addfail = Fallo en Sednfile: [{0}] [{1}]
-endpoint.warn.noInsecureReneg = La renegociación segura no está soportada por 
la biblioteca SSL [{0}]
 endpoint.warn.unlockAcceptorFailed = El hilo aceptador [{0}] falló al 
desbloquear. Forzando apagado de enchufe (socket).
 endpoint.debug.channelCloseFail = No puede cerrar el canal
 endpoint.debug.socketCloseFail = No pude cerrar el enchufe (socket)



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846077 - /tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 20:54:01 2018
New Revision: 1846077

URL: http://svn.apache.org/viewvc?rev=1846077=rev
Log:
Correct typo in name

Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties?rev=1846077=1846076=1846077=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 20:54:01 2018
@@ -152,4 +152,4 @@ threadLocalLeakPreventionListener.lifecy
 threadLocalLeakPreventionListener.containerEvent.error = Excepción procesando 
evento de contenedor [{0}]
 defaultInstanceManager.restrictedServletsResource = No se ha hallado el 
fichero de propiedades restringidas de servlets
 defaultInstanceManager.restrictedFiltersResource = No se ha hallado el fichero 
de propiedades restringidas de filtros
-defaultInstanceManager.restrictedListenersResources = No se ha hallado el 
fichero de propiedades restringidas de escuchadores
+defaultInstanceManager.restrictedListenersResource = No se ha hallado el 
fichero de propiedades restringidas de escuchadores



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846076 - /tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 20:48:40 2018
New Revision: 1846076

URL: http://svn.apache.org/viewvc?rev=1846076=rev
Log:
Remove value that is no longer used

Modified:
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties

Modified: 
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties?rev=1846076=1846075=1846076=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 20:48:40 2018
@@ -45,7 +45,6 @@ coyoteRequest.parseParameters = Excepci�
 coyoteRequest.postTooLarge = No se analizaron los parámetros porque la medida 
de los datos enviados era demasiado grande. Usa el atributo maxPostSize del 
conector para resolver esto en caso de que la aplicación debiera de aceptar 
POSTs más grandes.
 coyoteRequest.chunkedPostTooLarge = No se han analizado los parámetros porque 
la medida de los datos enviados meiante "post" era demasiado grande. Debido a 
que este requerimiento es una parte del original, no puede ser procesado. 
Utiliza el atributo "maxPostSize" del conector para resolver esta situación, en 
caso de que la aplicación deba de aceptar POSTs mayores.
 coyoteRequest.alreadyAuthenticated = Este requerimiento ya ha sido autenticado
-coyoteRequest.noLoginConfig = No se ha configurado mecanismo de autenticación 
para este contexto
 coyoteRequest.authenticate.ise = No puedo llamar a authenticate() tras haberse 
acometido la respuesta
 coyoteRequest.uploadLocationInvalid = No es válida la localización [{0}] de 
carga temporal
 coyoteRequest.sessionEndAccessFail = Excepción disparada acabando acceso a 
sesión mientras se reciclaba el requerimiento



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846075 - in /tomcat/trunk/java/org/apache/jasper/resources: LocalStrings_es.properties LocalStrings_fr.properties LocalStrings_ja.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 20:46:26 2018
New Revision: 1846075

URL: http://svn.apache.org/viewvc?rev=1846075=rev
Log:
Fix typo in name

Modified:
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties

Modified: 
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties?rev=1846075=1846074=1846075=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 20:46:26 2018
@@ -333,7 +333,7 @@ jsp.error.xml.closeQuoteMissingInXMLDecl
 jsp.error.multiple.jsp = No puedo tener múltiples especificaciones de
 jsp.error.jspoutput.conflict = jsp:output: ilegal tener ocurrencias 
múltiples de [{0}] con diferentes valores (viejo: [{1}], nuevo: [{2}])
 jsp.error.jspoutput.doctypenamesystem = jsp:output: atributos 
'doctype-root-element' y 'doctype-system' deben de aparecer juntos
-jsp.error.jspoutput.doctypepulicsystem = jsp:output: atributo 
'doctype-system' debe de aparecer si aparece atributo 'doctype-public'
+jsp.error.jspoutput.doctypepublicsystem = jsp:output: atributo 
'doctype-system' debe de aparecer si aparece atributo 'doctype-public'
 jsp.error.jspoutput.nonemptybody = jsp:output no debe de tener un 
cuerpo
 jsp.error.jspoutput.invalidUse = jsp:output no se debe de usar en 
sintáxis estándar
 jsp.error.attributes.not.allowed = [{0}] no debe de tener atributos

Modified: 
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties?rev=1846075=1846074=1846075=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_fr.properties 
[UTF-8] Wed Nov  7 20:46:26 2018
@@ -223,7 +223,7 @@ jsp.error.attributes.not.allowed = [{0}]
 #jsp.error.prefix.refined=
 #jsp.error.jspoutput.conflict=
 #jsp.error.jspoutput.doctypenamesystem=
-#jsp.error.jspoutput.doctypepulicsystem=
+#jsp.error.jspoutput.doctypepublicsystem=
 #jsp.error.jspoutput.nonemptybody=
 #jsp.error.jspoutput.invalidUse=
 #jsp.error.invalid.bean=

Modified: 
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties?rev=1846075=1846074=1846075=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings_ja.properties 
[UTF-8] Wed Nov  7 20:46:26 2018
@@ -297,7 +297,7 @@ jsp.error.xml.closeQuoteMissingInXMLDecl
 jsp.error.multiple.jsp = 複数の仕様を満たすことはできません
 jsp.error.jspoutput.conflict=jsp:output: [{0}]に異なる値を複数回指定するのは無効です (旧: 
[{1}], 新: [{2}])
 jsp.error.jspoutput.doctypenamesystem=jsp:output: 
'doctype-root-element' 及び 'doctype-system' 属性は同時に指定しなければいけません
-jsp.error.jspoutput.doctypepulicsystem=jsp:output: 
'doctype-public'属性を指定する場合は、'doctype-system' 属性も指定しなければいけません
+jsp.error.jspoutput.doctypepublicsystem=jsp:output: 
'doctype-public'属性を指定する場合は、'doctype-system' 属性も指定しなければいけません
 jsp.error.jspoutput.nonemptybody=jsp:output ボディを持ってはいけません
 jsp.error.jspoutput.invalidUse=jsp:output 標準構文の中で使用してはいけません
 jsp.error.attributes.not.allowed = [{0}] は属性を持つことはできません



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846074 - /tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 20:46:10 2018
New Revision: 1846074

URL: http://svn.apache.org/viewvc?rev=1846074=rev
Log:
Remove value that is no longer used

Modified:
tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties

Modified: tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties?rev=1846074=1846073=1846074=diff
==
--- tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/org/apache/coyote/ajp/LocalStrings_es.properties [UTF-8] 
Wed Nov  7 20:46:10 2018
@@ -13,7 +13,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-ajpprotocol.proto.error = Error leyendo requerimiento, ignorado
 ajpprocessor.failedread = Fallo en lectura de Conector
 ajpprocessor.failedsend = No pude enviar mensaje AJP
 ajpprocessor.header.error = Fallo en análisis de mensaje de cabecera



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846073 - in /tomcat/trunk/java/org/apache/catalina/tribes/transport: LocalStrings_es.properties bio/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 20:41:15 2018
New Revision: 1846073

URL: http://svn.apache.org/viewvc?rev=1846073=rev
Log:
Move translations to correct location.
Spotted while working on utility to export l10n files to external translation 
service.

Added:

tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties
   (with props)
Modified:

tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties?rev=1846073=1846072=1846073=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties
 [UTF-8] (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/LocalStrings_es.properties
 [UTF-8] Wed Nov  7 20:41:15 2018
@@ -13,12 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-bioSender.ack.eof = EOF alcanzado en puerto local [{0}:{1,number,integer}]
-bioSender.ack.missing = No puedo leer reconocimiento desde 
[{0}:{1,number,integer}] en {2,number,integer} ms. Desconectando conector e 
intentando otra vez.
-bioSender.ack.wrong = Falta ACK correcto tras 10 bytes leídos en puerto local 
[{0}:{1,number,integer}]
-bioSender.closeSocket = El remitente cerró el conector con 
[{0}:{1,number,integer}] (contador de cierre {2,number,integer})
-bioSender.disconnect = Remitente desconectado de [{0}:{1,number,integer}] 
(contador de desconexión {2,number,integer})
-bioSender.openSocket = Remitente abrió conector con [{0}:{1,number,integer}] 
(contador de apertura {2,number,integer})
-bioSender.openSocket.failure = ¡No pude abrir conector de remitente 
[{0}:{1,number,integer}]! (contador de fallo de apertura {2,number,integer})
-bioSender.send.again = Enviar datos de nuevo a [{0}:{1,number,integer}]
 PooledSender.senderDisconnectFail = No pude desconectar al remitente

Added: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties?rev=1846073=auto
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties
 (added)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties
 Wed Nov  7 20:41:15 2018
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+bioSender.ack.eof = EOF alcanzado en puerto local [{0}:{1,number,integer}]
+bioSender.ack.missing = No puedo leer reconocimiento desde 
[{0}:{1,number,integer}] en {2,number,integer} ms. Desconectando conector e 
intentando otra vez.
+bioSender.ack.wrong = Falta ACK correcto tras 10 bytes leídos en puerto local 
[{0}:{1,number,integer}]
+bioSender.closeSocket = El remitente cerró el conector con 
[{0}:{1,number,integer}] (contador de cierre {2,number,integer})
+bioSender.disconnect = Remitente desconectado de [{0}:{1,number,integer}] 
(contador de desconexión {2,number,integer})
+bioSender.openSocket = Remitente abrió conector con [{0}:{1,number,integer}] 
(contador de apertura {2,number,integer})
+bioSender.openSocket.failure = ¡No pude abrir conector de remitente 
[{0}:{1,number,integer}]! (contador de fallo de apertura {2,number,integer})
+bioSender.send.again = Enviar datos de nuevo a [{0}:{1,number,integer}]

Propchange: 
tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/LocalStrings_es.properties
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846058 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java webapps/docs/changelog.xml

2018-11-07 Thread remm
Author: remm
Date: Wed Nov  7 16:45:48 2018
New Revision: 1846058

URL: http://svn.apache.org/viewvc?rev=1846058=rev
Log:
Storeconfig needs a get/set with a plain type and supports channel 
interceptors, so keep a string value around.

Modified:

tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java?rev=1846058=1846057=1846058=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 (original)
+++ 
tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java
 Wed Nov  7 16:45:48 2018
@@ -58,6 +58,7 @@ public class EncryptInterceptor extends
 private String providerName;
 private String encryptionAlgorithm = DEFAULT_ENCRYPTION_ALGORITHM;
 private byte[] encryptionKeyBytes;
+private String encryptionKeyString;
 
 private Cipher encryptionCipher;
 private Cipher decryptionCipher;
@@ -196,6 +197,7 @@ public class EncryptInterceptor extends
  * @param keyBytes The encryption key.
  */
 public void setEncryptionKey(String keyBytes) {
+this.encryptionKeyString = keyBytes;
 if (null == keyBytes) {
 setEncryptionKey((byte[])null);
 } else {
@@ -222,6 +224,14 @@ public class EncryptInterceptor extends
 return encryptionKeyBytes;
 }
 
+public String getEncryptionKeyString() {
+return encryptionKeyString;
+}
+
+public void setEncryptionKeyString(String encryptionKeyString) {
+setEncryptionKey(encryptionKeyString);
+}
+
 /**
  * Sets the JCA provider name used for cryptographic activities.
  *

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846058=1846057=1846058=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Nov  7 16:45:48 2018
@@ -56,6 +56,10 @@
 The default Servlet should not override a previously set content-type.
 (remm)
   
+  
+Fix storeconfig for the cluster encryption interceptor key attribute.
+(remm)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62892] New: Memory leak when performing client certificate validation with OCSP

2018-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62892

Bug ID: 62892
   Summary: Memory leak when performing client certificate
validation with OCSP
   Product: Tomcat Native
   Version: 1.2.17
  Hardware: PC
OS: Linux
Status: NEW
  Severity: critical
  Priority: P2
 Component: Library
  Assignee: dev@tomcat.apache.org
  Reporter: sander.bensc...@42.nl
  Target Milestone: ---

Created attachment 36251
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36251=edit
Figures 1 & 2

We are using the Tomcat APR connector in our application to perform
client-certificate validation with OCSP checks. We've noticed a gradual
increase in the memory consumed by the Java process until the system runs out
of memory and the OOM-killer we configured kills and restarts the process.

The application we created is queried often (every second by two simultaneous
clients). We have tested this with two types of client certificates from two
different root CA's: PKIoverheid (the root certificate of the Dutch national
government) and Comodo certificates, both containing OCSP urls. We first
noticed the problem with the PKIoverheid certificates, which are larger in size
than the Comodo certificates. In figure 1, showing the available server memory,
you can see that using these larger PKIoverheid certificates the server runs
out of memory every 2,5 - 3 hours. Afterwards we tried the same thing with
smaller Comodo certificates (see figure 2) which has the same result but takes
a longer time (15 hours).

When we turned off the client certificate validation by either commenting out
the call to X509_verify_cert in OpenSSL (which in turn calls Tomcat Native's
SSL_callback_SSL_verify that performs the OCSP checks) or setting
SSLVerifyClient to "none" and clientAuth to "false" in the APR connector the
server did not run out of memory and the graph of available memory flatlines.

I have tested this with the Apache Native Library v1.2.17, Tomcat v9.0.12, APR
v1.5.2 and JDK v1.8.0_181 running on an Ubuntu 16.04.5 server. On the JBoss
jira I spotted a similar issue where somebody used different versions but had
the same problem: https://issues.jboss.org/browse/JWS-1140.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Threads

2018-11-07 Thread Rémy Maucherat
On Wed, Nov 7, 2018 at 12:17 AM Rémy Maucherat  wrote:

> On Tue, Nov 6, 2018 at 6:39 PM Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
>> > , and the javadoc says: If any execution of the task encounters an
>> > exception, subsequent executions are suppressed.
>> >
>> > So you think adding back the scheduling after a problem is better
>> > ?
>>
>> Yes, I think so. The container should protect itself from
>> applications, and this is a case where a misbehaving application can
>> break the correct operation of the container.
>>
>
> Ok, so it's harder, there's no API for it. I'll try to find a good
> solution.
>

Done for ContainerBase, it now uses another scheduled task to check the
state of the first one and looks clean IMO (a lot better as if there was
similar code attempting the same thing pre refactoring). It's probably
difficult to try to make the added code generic (it may need to check for
conditions, may use a different scheduling, etc) although I still might
attempt it at some point (although not as significant as this one, the
other scheduled tasks in Tomcat would be better off with a "raise dead"
capability).

Rémy


svn commit: r1846029 - in /tomcat/trunk/java/org/apache/catalina: connector/LocalStrings_es.properties mapper/LocalStrings_es.properties

2018-11-07 Thread markt
Author: markt
Date: Wed Nov  7 14:19:01 2018
New Revision: 1846029

URL: http://svn.apache.org/viewvc?rev=1846029=rev
Log:
Move translations to correct location.
Spotted while working on utility to export l10n files to external translation 
service.

Added:
tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties   
(with props)
Modified:
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties

Modified: 
tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties?rev=1846029=1846028=1846029=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties 
[UTF-8] (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/LocalStrings_es.properties 
[UTF-8] Wed Nov  7 14:19:01 2018
@@ -51,8 +51,5 @@ coyoteRequest.uploadLocationInvalid = No
 coyoteRequest.sessionEndAccessFail = Excepción disparada acabando acceso a 
sesión mientras se reciclaba el requerimiento
 requestFacade.nullRequest = El objeto de requerimiento ha sido reciclado y ya 
no está asociado con esta fachada
 responseFacade.nullResponse = El objeto de respuesta ha sido reciclado y ya no 
está asociado con esta fachada
-mapperListener.unknownDefaultHost = Máquina por defecto desconocida: [{0}] 
para el conector [{1}]
-mapperListener.registerHost = Registrar máquina [{0}] en dominio [{1}] para el 
conector [{2}]
-mapperListener.unregisterHost = Desregistrar máquina [{0}] en dominio [{1}] 
para el conector [{2}]
 
 inputBuffer.streamClosed = Flujo cerrado

Added: tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties?rev=1846029=auto
==
--- tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties 
(added)
+++ tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties Wed 
Nov  7 14:19:01 2018
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+mapperListener.unknownDefaultHost = Máquina por defecto desconocida: [{0}] 
para el conector [{1}]
+mapperListener.registerHost = Registrar máquina [{0}] en dominio [{1}] para 
el conector [{2}]
+mapperListener.unregisterHost = Desregistrar máquina [{0}] en dominio [{1}] 
para el conector [{2}]

Propchange: 
tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings_es.properties
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Emmanuel,

On 11/7/18 08:09, Emmanuel Bourg wrote:
> Le 07/11/2018 à 10:28, Konstantin Kolinko a écrit :
> 
>> If I cannot do something with a batch script, I write a shell
>> (bash) script and run it with git-bash from Git for Windows.
> 
> There is also that thing named Ant that was designed to replace
> batch and shell scripts to build Java projects on any platform ;)

I'm struggling to find a way for ant to download both itself and the
JDK on which it needs to run. :)

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvi5YoACgkQHPApP6U8
pFis/xAAxoGTBh+F3HOyuBOeUOvgavcL1YmdJ8cSmz5l42r8buH37zJMyadxQmWs
pOQUCU5hb+G5YFrjGruVzlCplZcDP6igyxb0xFqmBFvA/TlseRlXAYfzqLsU4alS
Drp9uKD+464Ebiwg1fPdQ0kuPmQk8kMEW18X/6a8Q7ltYy+EIAxAZg2pBn8mLYcN
lr/LalSvTWqfsIrp1SYxpp38W39W8ZZ/lMHfrGdme68nrS+mdEIQEKR+G6G2ss8e
MmH70sMRTVmFHHWIR1kt9Ob3qmkh6n25coPgPOHguUx4dIdOrqL/C387KgiAtFOV
HSlpvKAAb4ruF61RkLPUmnc4WM6bTQOsvJsxwpsv4+jcvCFzo1XthT94LsOONB7j
+8Ry1V+QTC3VPPwm4OdNKwy4+kj/NjdQJ/dAEPAvUsFQoVW527Ut6CIz+bTnCs/E
PNdCxA9dplg3QaBZo1RziB9cZkKLgLPcXwfZSppfxbCh5QeEmYP0xnZPFCji6Z/P
FiVwM+/ZI4HMN5b9hZ0Ut44ruxY2l+72iLN8LnZ+TvPgpZll6+snnkM6yBFVKFVD
DvWoYZ1oWeJVj7LGtEZhL//uKP+Em2oNQvSPb/+vKRbbvBBDlRrslsZ4brLS/KZB
3cUphwvpVrs0c5fJcS0EjKpRNXWYXn/f+IkWaiwzuXufuOXh1L8=
=Ys2n
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Emmanuel Bourg
Le 07/11/2018 à 10:28, Konstantin Kolinko a écrit :

> If I cannot do something with a batch script, I write a shell (bash)
> script and run it with git-bash from Git for Windows.

There is also that thing named Ant that was designed to replace batch
and shell scripts to build Java projects on any platform ;)

Emmanuel Bourg

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Chuck,

On 11/6/18 22:40, Caldarale, Charles R wrote:
>> From: Christopher Schultz [mailto:ch...@christopherschultz.net] 
>> Subject: Release script for Tomcat 8.5.x
> 
>> It's downloading everything it needs (except Java... grr
>> Oracle), exporting from svn, etc.
> 
>> The Process says to use the latest release of the minimum Java
>> version supported by the release. For 8.5.x, that means Java 7,
>> but Java 7 has been EOL'd. So... should I grab an old Java 7 JDK
>> for building the release, or should I use the latest supported
>> version, which is Java 8?
> 
> What about using the reference implementations available at
> jdk.java.net (e.g., https://jdk.java.net/java-se-ri/7)?  These are
> GPLv2, so shouldn't have the licensing problems the current Oracle
> ones do.

Thanks for the reference. I was trying to find an OpenJDK but ...
those seem to be tough to find for the old versions.

It looks like you still need to accept a license agreement, so
automated downloads might be irritating to trigger. I'll see what I
can do.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvi490ACgkQHPApP6U8
pFhvqRAAsO7/fAhPXDX/evmwgIjgxvgpvFLYBsJY4fqzbPpNa5JVvlZWsepzV7vq
S3tNl90fXqF9js/hzEPN96UgEdX1/CG2cCuM1qc03qYimPzAfKVqxHz5PVJGHn+b
LIbEluZisVJqgXPEYjU1sKX3QF/NyiVAp5UGxad10LpjlmBTDwORpOAy5DR7jr30
2w3UTfE4cKAL/3zhmeEgHM7roAnLSWKVa7PzlnmJezbKHKGUKaG6eN85vCCkIiUK
IrjjZ0wtQUJ/zBlV0XC06uGG6SzQC462lVbIfabkDgddt62w1jSLg0xQhcNgBvZM
P07FoobOE0z06VAauoIc1b0cDI5Tq3dPGmHZ6KA2B7h1CsCFnALeXTPeFKOAg9Lh
+XqXW1jbnWCBtVcRDP+I86Drmvtu8+8SwyvAVkt/aM8zt0gKgBLaxS8ALsFe719s
eeUdd3VEWg0KDzvxy5Qdn0tsKCa9qh1n5B8HSfNzZPEgPdguBY1dxWI/jVqlKncj
si38bhCKRDLWDIACzGAIuS/bvjrl6ZqmPhJgCgY8Vs7J9dPnlc1NLiwDbUm/Q9h0
Ttsl2kD4p5/25hHr75hS3z8R9MRPahWSS49/gfaZpxSq391hcGzvNFr3HUN5qQPU
vexF0iQLfkcHsrnc/woNtGz4VbErGOHSMTvlKe6JatmWnUSdq/g=
=SOPs
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Konstantin,

On 11/7/18 04:28, Konstantin Kolinko wrote:
> ср, 7 нояб. 2018 г. в 1:50, Christopher Schultz
> :
>> All,
>> 
>> I've been working this afternoon on a Powershell script to do
>> pretty much everything for a release. I chose Powershell because
>> (a) I will have to operate on Windows for releases until I get
>> NSIS working elsewhere and (b) batch scripts are The Worst.
> 
> FYI: If I cannot do something with a batch script, I write a shell
> (bash) script and run it with git-bash from Git for Windows.
> 
> Git for Windows comes bundled with many GNU utilities. 
> https://github.com/git-for-windows/git/releases/
> 
> (If Tomcat is migrated to Git someday, you are likely to use Git
> for Windows on that machine anyway).

The nice thing about Powershell is that it has a utility built-in that
can download stuff using HTTP. A two-line Powershell script can be
copy/pasted from a web page and it can bootstrap itself from there.

For *NIX, one of curl/wget is usually already available. (Wow, you can
also download with recent versions of bash -
https://unix.stackexchange.com/a/83927/68318).

But on Windows, without Powershell you'll have to first download
something (e.g. git-for-windows) and then run a script that uses those
utilities.

I would prefer to use sh universally because (a) I'm more familiar and
(b) I find it more powerful in general -- assuming the various
semi-standard utilities are available. So perhaps I'll revise the
Powershell script so that it's just a bootstrap tool for getting
things ready for git-bash to take over.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlvi41EACgkQHPApP6U8
pFgUBg/9FmPS3oOXUwoZcIHhQafuF5qFdoJ6yqcf8M8Sj6f0Hx7/VgfahXRtM3Sj
MjWQ5r+u37fYy1GEsfBBbYzf28i/RjW+8w7DAUsZNmVH8rIsDoOYMjQz/Dr98hHs
L1rf4Uoa9iM3XfVoa6qyOHDyUjyeiqNwI3opeKv8HyH9VbRb4iDMcsbn6YXbPm62
PmsIjX/+ZcjbHJ0oygAIYYzbNGbdrMwTL0r+RDGew8tV3IHQTWsGsD5SYDBVeSPn
ERX8My+PaCNY/p5WtPGhiS8bhhugOCwNbGeLtnInCuAJTWzxX4KPS1xsYb61uTYl
bzFbWQtSamSPve7U03clSW8S0mFPtOYnNlTk6hoha3CAxGwbNns8+2mo8CGVGUJQ
uACG9lkbCytBple8ayt+3iiGD/mdsWLack95bDs5BA8TM3e584xEKnWYJpdi538X
Lhx2fu7yUBjzOs7IxP/KA2UACQqeVV2rGKkFdAImOnV6AaLk7CxwWY66l3HFJRyN
JWMUuwlg6+96oE9Jil/1L4JV0m8B2UU1xLTiysbEx3pj2Be5LL9fKkAzda04Xlf/
Yf8I6i4bFWojj5mA2ZD6Mf3uWsZPZFnOAK01BkxSb+GUntbxC/xWaMocbwNUWptA
akO78GubLADM0o6WYngrlXmK7GwCrLv3lPEMWH8wkRFZwV0GXUk=
=KjkJ
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Konstantin Kolinko
ср, 7 нояб. 2018 г. в 1:50, Christopher Schultz :
> All,
>
> I've been working this afternoon on a Powershell script to do pretty
> much everything for a release. I chose Powershell because (a) I will
> have to operate on Windows for releases until I get NSIS working
> elsewhere and (b) batch scripts are The Worst.

FYI:
If I cannot do something with a batch script, I write a shell (bash)
script and run it with git-bash from Git for Windows.

Git for Windows comes bundled with many GNU utilities.
https://github.com/git-for-windows/git/releases/

(If Tomcat is migrated to Git someday, you are likely to use Git for
Windows on that machine anyway).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tomcat 7.0.91 : Issue with Kerberos Authentication

2018-11-07 Thread Mark Thomas
On 05/11/2018 12:24, Vipul Mehta wrote:
> We have upgraded from tomcat version 7.0.84 to 7.0.91.
> Users authenticate with our web app service using Kerberos logged in user
> credential. After upgrade, login started to fail.
> 
> It was because of this change due to which the modified method started
> returning null:
> 
> https://github.com/apache/tomcat70/commit/7b7b5932b6618d13042732c77a4e19ea89b432e3#diff-6fec32edbbb606fe1d1888c99d74e665
> 
> 
> User principal was KerberosPrincipal and the class was not specified in
> userClassNames in JAAS config of web application for tomcat. So, I added
> 'KerberosPrincipal' class in JAAS configuration.
> 
> =>
> "org.apache.catalina.realm.GenericPrincipal,javax.security.auth.kerberos.KerberosPrincipal"
> 
> 
> Now we are facing new issue. The principal being returned by
> JAASRealm->createPrincipal() is KerberosPrincipal and not
> GenericUserPrincipal which breaks our code.
> 
> KerberosPrincipal does not have delegated credential.
> 
> 
> On debugging i found that, in JAASRealm->authenticate() method,
> loginContext.getSubject() returns server's subject and not client's. So,
> later in createPrincipal() call username is client's username but subject
> belongs to server. Is this an issue ?

I've spun up the VMs I use for testing this and checked Tomcat 7.0.88
(the last version before the change above) and 7.0.x. The environment is
configured as per
http://tomcat.apache.org/tomcat-7.0-doc/windows-auth-howto.html and uses
the JNDI Realm.

Both work as expected with no configuration changes required.

It isn't clear from the original post how the JAAS Realm has been
configured. At present this looks like a configuration issue which means
the users list is the place to follow this up. You'll need to provide
enough information for the problem to be replicated.

Mark



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Release script for Tomcat 8.5.x

2018-11-07 Thread Mark Thomas
On 06/11/2018 22:50, Christopher Schultz wrote:



> The Process says to use the latest release of the minimum Java version
> supported by the release. For 8.5.x, that means Java 7, but Java 7 has
> been EOL'd. So... should I grab an old Java 7 JDK for building the
> release, or should I use the latest supported version, which is Java 8?

Personally, I always use Java 7. I do so as a final safety check that no
Java 8 or later specific code or dependency managed to sneak into the build.

I don't think it is essential to use Java 7 but I would strongly
recommend that any release manager builds with the latest (publicly
available) release of the minimum Java version supported by the release.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org