[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-test-nio2 (in module tomcat-8.5.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-test-nio2 has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 46 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.5.x-test-nio2 : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-8.5.x/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-8.5.x/output/test-tmp-NIO2/logs -WARNING- No directory [/srv/gump/public/workspace/tomcat-8.5.x/output/test-tmp-NIO2/logs] The following work was performed: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-test-nio2/gump_work/build_tomcat-8.5.x_tomcat-tc8.5.x-test-nio2.html Work Name: build_tomcat-8.5.x_tomcat-tc8.5.x-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 18 mins 50 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.5.x/true -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-8.5.x/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.1.1/dest-20190316/bin/openssl -Dexe cute.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-8.5.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.5.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-8.5.x/output/bu
Re: Default Number of Test Threads
Chris,
On Fri, Mar 15, 2019 at 4:56 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Igal,
>
> On 3/15/19 16:45, Igal Sapir wrote:
> >
> > I looked deeper into build.xml and I found some interesting
> > information and a simple solution for my issue. In build.xml we
> > have the following:
> >
> > > file="build.properties"/> > file="build.properties.default"/>
> >
> > So I can place my settings for test.threads in ~/build.properties.
> >
> > The current order of precedence, however, gives
> > ${user.home}/build.properties a higher priority than the one at
> > {tomcat}/build.properties.
> >
> > That is wrong IMHO and should be the other way around, i.e.
> > {tomcat}/build.properties should
> > override${user.home}/build.properties . I would like to change
> > that order if everyone agrees.
>
> I do not agree. The local configuration (~/build.properties) should
> override the default configuration (build.properties). That's why it's
> called "local configuration".
>
> Besides, if you implement your proposed switch, then you will be
> UNABLE to use ~/build.properties to customize this configuration that
> you don't like.
>
Perhaps I'm missing something, but I think that the term "Local" is
ambiguous here, so I will avoid using it to prevent confusion. We have
(applied in order):
1) Project Default Config.: {tomcat}/build.properties.default
2) Instance Config: {tomcat}/build.properties
3) System Config..: {user.home}/build.properties
Tomcat only ships with the Project Default Config file. The other two are
optional and can be created by the user.
Suppose that I usually want to run tests with 8 threads. I can set
`test.threads=8` in the System Config file and each time I download a new
version of Tomcat I simply run `ant test` in the directory of that
instance. It will run with 8 threads, resolving my original issue here.
But, if now I download a version and want to run only that one with 4
threads (a more likely scenario would be to set different versions or paths
for OpenSSL), I can not simply set the new value for the Instance
Configuration, {tomcat}/build.properties, to affect only that instance -- I
have to modify the System Config, which will change the settings for all
other instances.
The way I see it, the System Config is Default for the system, and each
instance should be able to specify its own Instance Configuration which
will override both the Project's Defaults and the System Defaults. My
proposal is therefore that the order of applying the settings will be:
1) Project Default Config.: {tomcat}/build.properties.default
2) System Config..: {user.home}/build.properties
3) Instance Config: {tomcat}/build.properties
That way I do not need to add an Instance Config anywhere unless a specific
instance requires unique settings. I can set my System Config
(~/build.properties) with the values that I normally use, and only override
them with an Instance Config, i.e. {tomcat}/build.properties where needed.
What am I missing?
Thanks,
Igal
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 25 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20190316.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu blic/workspace/apache-commons/logging/target/commons-logging-20190316.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20190316.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-trunk/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle [checkstyle] Running Checkstyle 8.19-SNAPSHOT on 3847 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/build.xml:497: Line matches the illegal pattern '\s+$'. [RegexpSingleline] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/build.xml:1532:3: File contains tab characters (this is the first instance). [FileTabCharacter] BUILD FAILED /srv/gump/public/workspace/tomcat-trunk/build.xml:556: Got 2 errors and 0 warnings. Total time: 25 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2019031607, vmgump-vm3.apache.org:vmgump:2019031607 Gump E-mail Identifier (unique within run) #8. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc8.5.x-validate (in module tomcat-8.5.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.5.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 46 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.5.x-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-validate/gump_work/build_tomcat-8.5.x_tomcat-tc8.5.x-validate.html Work Name: build_tomcat-8.5.x_tomcat-tc8.5.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 21 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-8.5.x/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-8.5.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20190316.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu blic/workspace/apache-commons/logging/target/commons-logging-20190316.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20190316.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-8.5.x/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-8.5.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.5.x/output/build/temp compile-prepare: download-validate: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar setproxy: downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-8.5.x/output/res/checkstyle [checkstyle] Running Checkstyle 8.19-SNAPSHOT on 3243 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.5.x/build.xml:511: Line matches the illegal pattern '\s+$'. [RegexpSingleline] BUILD FAILED /srv/gump/public/workspace/tomcat-8.5.x/build.xml:558: Got 1 errors and 0 warnings. Total time: 21 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-validate/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-8.5.x/tomcat-tc8.5.x-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2019031607, vmgump-vm3.apache.org:vmgump:2019031607 Gump E-mail Identifier (unique within run) #7. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc7.0.x-validate has an issue affecting its community
integration.
This issue affects 1 projects,
and has been outstanding for 55 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java
Servlet 3.0,
...
Full details are available at:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-DEBUG- Dependency on checkstyle exists, no need to add for property
checkstyle.jar.
-INFO- Failed with reason build failed
The following work was performed:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 sec
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar
-Dexecute.validate=true validate
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH:
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20190316.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu
blic/workspace/apache-commons/logging/target/commons-logging-20190316.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20190316.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar
-
Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml
build-prepare:
[delete] Deleting directory
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-7.0.x/output/build/temp
compile-prepare:
download-validate:
proxyflags:
setproxy:
testexist:
[echo] Testing for
/srv/gump/public/workspace/checkstyle/target/checkstyle-8.19-SNAPSHOT.jar
downloadfile:
validate:
[mkdir] Created dir:
/srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle
BUILD FAILED
/srv/gump/public/workspace/tomcat-7.0.x/build.xml:546: Unable to create Root
Module: config {res/checkstyle/checkstyle.xml}, classpath {null}.
Total time: 0 seconds
-
To subscribe to this information via syndicated feeds:
- RSS: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml
- Atom:
http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml
== Gump Tracking Only ===
Produced by Apache Gump(TM) version 2.3.
Gump Run 2019031607, vmgump-vm3.apache.org:vmgump:2019031607
Gump E-mail Identifier (unique within run) #6.
--
Apache Gump
http://gump.apache.org/ [Instance: vmgump-vm3]
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-dbcp (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-dbcp has an issue affecting its community integration. This issue affects 8 projects, and has been outstanding for 55 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - forrest-test : Apache Forrest software is a publishing framework that trans... - forrest-test-basic : Apache Forrest software is a publishing framework that trans... - forrest-test-deploy-plugins : Apache Forrest software is a publishing framework that trans... - tomcat-tc7.0.x : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-dbcp : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-test-apr : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-test-bio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... - tomcat-tc7.0.x-test-nio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-dbcp/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Made directory [/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps] -INFO- Failed with reason build failed -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-dbcp/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-dbcp.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-dbcp (Type: Build) Work ended in a state of : Failed Elapsed: Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x -Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20190316.jar -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps build-tomcat-dbcp [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/jta-spec1_0_1/jta-spec1_0_1.jar - Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml BUILD FAILED Target "build-tomcat-dbcp" does not exist in the project "Tomcat 7.0". Total time: 0 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-dbcp/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-dbcp/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2019031607, vmgump-vm3.apache.org:vmgump:2019031607 Gump E-mail Identifier (unique within run) #2. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Default Number of Test Threads
Chris, On Fri, Mar 15, 2019 at 4:53 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > > I think you are on Windows (?),. but maybe you could use this script: > > https://github.com/ChristopherSchultz/apache-tomcat-stuff/tree/master/bi > n > > (look for test-tomcat-release.sh) > > That script builds a custom build.properties and then runs everything. > It could trivially add a threads setting to build.properties. > Thanks! I use both Windows and Linux, but I can see some gems in that script that I can adopt. Best, Igal
Re: Default Number of Test Threads
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Igal,
On 3/15/19 16:45, Igal Sapir wrote:
> On Fri, Mar 15, 2019 at 9:45 AM Konstantin Kolinko
> wrote:
>
>> чт, 14 мар. 2019 г. в 22:26, Igal Sapir :
>> What is the use case? People verifying a release? CI
>> servers that may have different hardware?
>>
>
> The idea was more for testing new releases. On my laptop setting
> test.threads to 8 completes in about 10 minutes, while the default
> 1 thread takes more than 1 hour.
>
> I looked deeper into build.xml and I found some interesting
> information and a simple solution for my issue. In build.xml we
> have the following:
>
> file="build.properties"/> file="build.properties.default"/>
>
> So I can place my settings for test.threads in ~/build.properties.
>
> The current order of precedence, however, gives
> ${user.home}/build.properties a higher priority than the one at
> {tomcat}/build.properties.
>
> That is wrong IMHO and should be the other way around, i.e.
> {tomcat}/build.properties should
> override${user.home}/build.properties . I would like to change
> that order if everyone agrees.
I do not agree. The local configuration (~/build.properties) should
override the default configuration (build.properties). That's why it's
called "local configuration".
Besides, if you implement your proposed switch, then you will be
UNABLE to use ~/build.properties to customize this configuration that
you don't like.
> I added an ant target, echoproperties [1], which outputs the
> merged properties so it's easy to see the final values.
You can also add -debug to the command-line and get the properties.
- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlyMO7QACgkQHPApP6U8
pFiElQ//YAxkI061TxrzcCb+Mht4/qJ7xMUQ4uVOY4/BGMehHqMjwudlOEB0jtjl
1HaDVjyiMiIgKq8Ss1y1g5I9aNzxA8+Uq+Efj82GmT4UVloSHpClhJAiO3+BUM2w
HsWdpwFyNFjjy0e/nt01yoCIl4NumKCFZ+AM6sSt/PVhI9gJ0JOx64PZeyZyjHjU
1X7oo4brjUgrw9ulzPfEHByjpHAfxD8SinGV1QKVToggVrDR3mrUrUtlkVDWOsj4
S6vJyM2W5tz4+AP+hi/EG0ck+ZlMwpw2x6K6i38CglaoFeKPQeQJWdPk+wPpJl4t
ZkmdnxFlDFRvIlir/Xn5zswkURZFMjGqJhfplqhN/dQ4B2ICuYth/wnX/HBXBjkd
NEHNtnLgtKMVobu8u1Hd76S/EhfDuVOlA3FaAp0n+67a90Pnboo0Ih5/fKl8ADXI
+yR7Dc8ZumhNfAZFSi3QNeasP3zXNYHVRNOSKEMtxhWyaVODB/EkMdDo3c6Lxh23
BzBJ6gI0Hzx/n5dos35QKGHZlZCE2yng4VFJ6rBWRG529nq0QL9npvkEWWciKn6d
GaLEJ1nsfZfui1jGBeYWBtQV33qEpTBxDu9tGXt8cD1ECtT7IgzmmmWCcE8VqGTE
z5Twj3PS+AYW98aHfKmItwI5mUTgib6Cwjb4k88JxwRQY2+9JEQ=
=hZhA
-END PGP SIGNATURE-
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Default Number of Test Threads
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Igal, On 3/14/19 16:29, Igal Sapir wrote: > On 3/14/2019 12:51 PM, Mark Thomas wrote: >> On 14/03/2019 19:26, Igal Sapir wrote: >>> Does test.threads default to 1 for a reason? >> Mostly historical. The tests weren't originally designed to run >> in parallel. >> >>> If there is no objection, I would like to set the default to >>> the number of available CPU Threads. It looks like that can be >>> done with a custom Ant task which should be fairly simple to >>> implement. >> I over-ride it locally so I'm not going to be directly affected. >> >> A custom Ant task seems a little over-engineered compared to >> setting a property in build.properties. > > I override it in build.properties as well, but I find myself doing > it each time I download the sources for testing a tagged version, > or at least copy the file from one version to another. If you're > doing it in your dev directory and simply added "build.properties" > to .gitignore then you are not affected by this. I think you are on Windows (?),. but maybe you could use this script: https://github.com/ChristopherSchultz/apache-tomcat-stuff/tree/master/bi n (look for test-tomcat-release.sh) That script builds a custom build.properties and then runs everything. It could trivially add a threads setting to build.properties. - -chris -BEGIN PGP SIGNATURE- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlyMOxQACgkQHPApP6U8 pFjofBAAy1UKpHmO8eWUUrkvWpcQR0na3b9skAjrQjIe1kOojTvjuDfESxQtkXRJ CRgwOl7ztpmxveStBErW8+OFLgovh/ilrL9Yxc3RNelJ7Z3Pmv87DevEJDt9VmNR 3q5JL6yx7EOLLTkXA+Z/PfbHmOXA6BN/wwI4d60x89tRqpSuWhE6BxFvRHxCfFOV hUeMlAfeWZwXcCsoXwaj9CwMb16X3GbSPMvj+3EcFM51GV5gnJHwVsyA9PFTRIZR 2WPOM9As8Lms3fayiFR8K3DlA3N1H94fA9oyGlQUXeq6qXBxYjLTh8ayUSEJFpkx N0P+DzqU0ydMAgHMeP1sumf85T7FZ3BNSTBUONgGYgUoIThi+RXy6/6OoUi2xgR2 ZdkdQBX7i1KqNIk3aua7zke58g9oDCVV/T/6k7CamhiGR13fDZAZ3SBZiDdReLxm /OTp0YoNG+jOhiQ8yOL2aVBCvQdvJW4i8f5agYnfciL+S8z9xgUuvRvsHoVBHhgg 2kifiDJ30MN4SE0iQDGZUDdSD3RZu0GMCP0Zp6nXRioIDo94285a94/qUgm+Vjdm ZfbghLrNtziXqBiUZoD1qkVVFygJnO2uM1Yl9Bnl2WdcmGLE+ukMeMqzGYk8ScM6 /y36CnkCjtULfm7TcVkSaNUU/EzjUKljwdvp0FVAN9mrYdA2JEw= =iiK4 -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Wiki migration
On 15/03/2019 18:32, Mark Thomas wrote: > On 15/03/2019 18:05, Konstantin Kolinko wrote: >> пт, 15 мар. 2019 г. в 20:07, Mark Thomas : >>> >>> All, >>> >>> I am going to attempt the wiki migration. Given it is last thing on a >>> Friday, it will either work perfectly or be a complete disaster. I have >>> a backup of our Confluence Space in case it is the latter. >>> >>> If it works, I'll update the links on the website after the migration. >> >> I do not like it! > > Moin is being shutdown in less than three months. The choice is when we > migrate, not if we migrate. > >> 1. All links will be broken, including ones >> a) in e-mail archives >> b) on other sites, like stackoverflow > > That is going to be the case whatever we migrate to. It wouldn't be too > hard to put redirects in place. We can talk to infra about that. The old > pages will stay in place too so we have time. We just need to make the > old pages read-only. The migration is complete. We have a couple of options: 1. Make moin read-only at this point and start tidying up the pages that were migrated Confluence 2. Leave moin as, treat this migration as a test. Review what was migrated and do the real migration at a later point. 3. Something else. I'm going to move all the migrated pages under a 'Migrated' page so it is clear what is what. Mark > >> 2. Links used by Confluence are not pretty, with all those '+'s >> >> 3. It does to integrate well with e-mail. >> >> As currently, it is not configured to echo changes to the dev@ mailing list, >> and if done so it cannot send plaintext e-mails. > > That issue is 50% confluence (it marks the changes email as bulk with no > option to change that) and 50% ezmlm (it automatically drops bulk > email). That problem should be solvable. I'll pester infra about that one. > >> 4. Proprietary close-source software. > > As are GitHub and GitLab... > > We have already started moving some pages to Confluence manually. > >> Are there other ways? >> >> E.g. >> 1) static web site, managed via git pub-sub > > Not an option. You'd need to be a committer to use it. > >> 2) GitHub wiki pages? >> 3) GitLab wiki pages? >> >> There also exists the following project, >> http://jspwiki.apache.org/ >> if we talk about "our own dog food". > > Infra has chosen Confluence. If we want to run jspwiki on our own VM > that is an option but it needs *long term* volunteers to maintain the > VM. Experience elsewhere in the ASF is that that usually doesn't work. > > Mark > >> >> >> Best regards, >> Konstantin Kolinko >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 58338] BasicDataSourceFactory uses wrong attribute name
https://bz.apache.org/bugzilla/show_bug.cgi?id=58338 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Mark Thomas --- Fixed in: - 7.0.x for 7.0.94 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix broken Javadoc
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new c86cca2 Fix broken Javadoc
c86cca2 is described below
commit c86cca2d31f827a335bb1414af17bb68737c3043
Author: Mark Thomas
AuthorDate: Fri Mar 15 23:16:57 2019 +
Fix broken Javadoc
---
.../apache/catalina/connector/MapperListener.java | 2 +-
.../core/JreMemoryLeakPreventionListener.java | 2 +-
java/org/apache/catalina/core/StandardContext.java | 10 +++---
.../catalina/filters/CsrfPreventionFilter.java | 1 -
.../apache/catalina/servlets/WebdavServlet.java| 3 +-
java/org/apache/jasper/compiler/ELParser.java | 21 ++-
java/org/apache/jasper/compiler/JspReader.java | 42 +++---
.../apache/jasper/compiler/ParserController.java | 37 +--
8 files changed, 56 insertions(+), 62 deletions(-)
diff --git a/java/org/apache/catalina/connector/MapperListener.java
b/java/org/apache/catalina/connector/MapperListener.java
index 2bf89de..5b0e9f9 100644
--- a/java/org/apache/catalina/connector/MapperListener.java
+++ b/java/org/apache/catalina/connector/MapperListener.java
@@ -459,7 +459,7 @@ public class MapperListener extends LifecycleMBeanBase
*
* @param context
* @param wrapper
- * @param list
+ * @param wrappers
*/
private void prepareWrapperMappingInfo(Context context, Wrapper wrapper,
List wrappers) {
diff --git a/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
b/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
index 2d2b75b..62b2278 100644
--- a/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
+++ b/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
@@ -165,7 +165,7 @@ public class JreMemoryLeakPreventionListener implements
LifecycleListener {
/**
* Protect against resources being read for JAR files and, as a
side-effect,
* the JAR file becoming locked. Note this disables caching for all
- * {@link URLConnection}s, regardless of type. Defaults to
+ * {@link java.net.URLConnection}s, regardless of type. Defaults to
* true.
*/
private boolean urlCacheProtection = true;
diff --git a/java/org/apache/catalina/core/StandardContext.java
b/java/org/apache/catalina/core/StandardContext.java
index d158e76..85a6147 100644
--- a/java/org/apache/catalina/core/StandardContext.java
+++ b/java/org/apache/catalina/core/StandardContext.java
@@ -867,10 +867,12 @@ public class StandardContext extends ContainerBase
/**
* If an HttpClient keep-alive timer thread has been started by this web
* application and is still running, should Tomcat change the context class
- * loader from the current {@link WebappClassLoaderBase} to
- * {@link WebappClassLoaderBase#parent} to prevent a memory leak? Note that
- * the keep-alive timer thread will stop on its own once the keep-alives
all
- * expire however, on a busy system that might not happen for some time.
+ * loader from the current
+ * {@link org.apache.catalina.loader.WebappClassLoaderBase} to
+ * {@link org.apache.catalina.loader.WebappClassLoaderBase#parent} to
+ * prevent a memory leak? Note that the keep-alive timer thread will stop
on
+ * its own once the keep-alives all expire however, on a busy system that
+ * might not happen for some time.
*/
private boolean clearReferencesHttpClientKeepAliveThread = true;
diff --git a/java/org/apache/catalina/filters/CsrfPreventionFilter.java
b/java/org/apache/catalina/filters/CsrfPreventionFilter.java
index c688213..c518535 100644
--- a/java/org/apache/catalina/filters/CsrfPreventionFilter.java
+++ b/java/org/apache/catalina/filters/CsrfPreventionFilter.java
@@ -173,7 +173,6 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
* Return the specified URL with the nonce added to the query string.
*
* @param url URL to be modified
- * @param nonce The nonce to add
*/
private String addNonce(String url) {
diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java
b/java/org/apache/catalina/servlets/WebdavServlet.java
index 3d95a8e..0a5df26 100644
--- a/java/org/apache/catalina/servlets/WebdavServlet.java
+++ b/java/org/apache/catalina/servlets/WebdavServlet.java
@@ -2081,7 +2081,6 @@ public class WebdavServlet extends DefaultServlet {
* Propfind helper method.
*
* @param req The servlet request
- * @param resources Resources object associated with this context
* @param generatedXML XML response to the Propfind request
* @param path Path of the current resource
* @param type Propfind type
@@ -2365,7 +2364,7 @@ public class WebdavServlet extends DefaultServlet {
[tomcat] branch 7.0.x updated (45b611d -> 959795c)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 45b611d Added ant taget echoproperties for easier troubleshooting new d8cf161 Import DBCP and Pool source into 7.0.x source tree new efb9b32 Update to latest Commons Pool 1.5.x new a674456 Update to latest Commons DBCP 1.4.x new 2fd7094 Update copy of Commons Pool to 1.6.x to add generics new 3818142 Add missing @Override markers new c36fdb4 Remove svn keywords new 985bb58 Javadoc fixes new 93367fa Fix Javadoc broken by fork new 569500d Fix broken Javadoc new fbbd77e Fix unnecessary cast new f6394d8 Remove redundant interface definitions new 959795c Update changelog The 11900 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default | 18 - build.xml | 116 +- .../apache/tomcat/dbcp/dbcp/AbandonedConfig.java | 171 ++ .../tomcat/dbcp/dbcp/AbandonedObjectPool.java | 168 ++ .../apache/tomcat/dbcp/dbcp/AbandonedTrace.java| 231 ++ .../apache/tomcat/dbcp/dbcp/BasicDataSource.java | 1791 + .../tomcat/dbcp/dbcp/BasicDataSourceFactory.java | 384 +++ .../apache/tomcat/dbcp/dbcp/ConnectionFactory.java | 36 + .../dbcp/dbcp/DataSourceConnectionFactory.java | 52 + .../org/apache/tomcat/dbcp/dbcp/DbcpException.java | 114 + .../dbcp/dbcp/DelegatingCallableStatement.java | 777 ++ .../tomcat/dbcp/dbcp/DelegatingConnection.java | 740 ++ .../dbcp/dbcp/DelegatingDatabaseMetaData.java | 1385 ++ .../dbcp/dbcp/DelegatingPreparedStatement.java | 485 .../tomcat/dbcp/dbcp/DelegatingResultSet.java | 1274 + .../tomcat/dbcp/dbcp/DelegatingStatement.java | 532 .../tomcat/dbcp/dbcp/DriverConnectionFactory.java | 49 + .../dbcp/dbcp/DriverManagerConnectionFactory.java | 86 + .../dbcp/dbcp/PoolableCallableStatement.java | 128 + .../tomcat/dbcp/dbcp/PoolableConnection.java | 125 + .../dbcp/dbcp/PoolableConnectionFactory.java | 746 ++ .../dbcp/dbcp/PoolablePreparedStatement.java | 144 + .../apache/tomcat/dbcp/dbcp/PoolingConnection.java | 471 .../apache/tomcat/dbcp/dbcp/PoolingDataSource.java | 489 .../org/apache/tomcat/dbcp/dbcp/PoolingDriver.java | 546 .../tomcat/dbcp/dbcp/SQLNestedException.java | 46 + .../dbcp/dbcp/cpdsadapter/ConnectionImpl.java | 229 ++ .../dbcp/dbcp/cpdsadapter/DriverAdapterCPDS.java | 729 + .../cpdsadapter/PoolablePreparedStatementStub.java | 56 + .../dbcp/cpdsadapter/PooledConnectionImpl.java | 652 + .../dbcp/datasources/CPDSConnectionFactory.java| 353 +++ .../dbcp/datasources/InstanceKeyDataSource.java| 897 +++ .../dbcp/datasources/InstanceKeyObjectFactory.java | 247 ++ .../datasources/KeyedCPDSConnectionFactory.java| 346 +++ .../dbcp/datasources/PerUserPoolDataSource.java| 568 .../datasources/PerUserPoolDataSourceFactory.java | 102 + .../tomcat/dbcp/dbcp/datasources/PoolKey.java | 66 + .../dbcp/datasources/PooledConnectionAndInfo.java | 64 + .../dbcp/datasources/PooledConnectionManager.java | 54 + .../dbcp/datasources/SharedPoolDataSource.java | 277 ++ .../datasources/SharedPoolDataSourceFactory.java | 61 + .../tomcat/dbcp/dbcp/datasources/UserPassKey.java | 102 + .../apache/tomcat/dbcp/jocl/ConstructorUtil.java | 97 + .../tomcat/dbcp/jocl/JOCLContentHandler.java | 801 ++ .../tomcat/dbcp/pool/BaseKeyedObjectPool.java | 177 ++ .../dbcp/pool/BaseKeyedPoolableObjectFactory.java | 101 + .../apache/tomcat/dbcp/pool/BaseObjectPool.java| 154 ++ .../dbcp/pool/BasePoolableObjectFactory.java | 80 + .../apache/tomcat/dbcp/pool/KeyedObjectPool.java | 232 ++ .../tomcat/dbcp/pool/KeyedObjectPoolFactory.java | 38 + .../dbcp/pool/KeyedPoolableObjectFactory.java | 141 + java/org/apache/tomcat/dbcp/pool/ObjectPool.java | 192 ++ .../apache/tomcat/dbcp/pool/ObjectPoolFactory.java | 37 + java/org/apache/tomcat/dbcp/pool/PoolUtils.java| 2579 ++ .../tomcat/dbcp/pool/PoolableObjectFactory.java| 139 + .../dbcp/pool/impl/CursorableLinkedList.java | 1556 +++ .../tomcat/dbcp/pool/impl/EvictionTimer.java | 132 + .../dbcp/pool/impl/GenericKeyedObjectPool.java | 2781 .../pool/impl/GenericKeyedObjectPoolFactory.java | 473 .../tomcat/dbcp/pool/impl/GenericObjectPool.java | 2127 +++ .../dbcp/pool/impl/GenericObjectPoolFactory.java | 459
buildbot success in on tomcat-85-trunk
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1706 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' triggered this build Build Source Stamp: [branch 8.5.x] b7967503cde9fb523eb398174ac312256a98a169 Blamelist: Igal Sapir Build succeeded! Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Wiki migration
On 3/15/2019 11:32 AM, Mark Thomas wrote: There also exists the following project, http://jspwiki.apache.org/ if we talk about "our own dog food". Infra has chosen Confluence. If we want to run jspwiki on our own VM that is an option but it needs *long term* volunteers to maintain the VM. Experience elsewhere in the ASF is that that usually doesn't work. I'm neither for nor against this option, but I am looking for ways to contribute more so if we go that route I'd be happy to volunteer for that ongoing task. Best, Igal - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: buildbot failure in on tomcat-trunk
Is there a known issue with BuildBot? [concat] Testsuites with failed tests: [concat] TEST-org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt I don't believe that my commit, adding an ant target [1], is related. 8.5 also failed, but with another unit test: [concat] Testsuites with failed tests: [concat] TEST-org.apache.catalina.connector.TestCoyoteOutputStream.NIO2.txt Thanks, Igal [1] https://github.com/apache/tomcat/commit/8a2f41bed80a On 3/15/2019 2:01 PM, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4143 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 8a2f41bed80a96bd6d711594ea8b6b7f0f1451da Blamelist: Igal Sapir BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4143 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 8a2f41bed80a96bd6d711594ea8b6b7f0f1451da Blamelist: Igal Sapir BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Added ant taget echoproperties for easier troubleshooting
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b796750 Added ant taget echoproperties for easier troubleshooting b796750 is described below commit b7967503cde9fb523eb398174ac312256a98a169 Author: Igal Sapir AuthorDate: Fri Mar 15 13:56:26 2019 -0700 Added ant taget echoproperties for easier troubleshooting --- build.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/build.xml b/build.xml index 8f5f5c5..c1cfc61 100644 --- a/build.xml +++ b/build.xml @@ -504,6 +504,11 @@ + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Added ant taget echoproperties for easier troubleshooting
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 45b611d Added ant taget echoproperties for easier troubleshooting 45b611d is described below commit 45b611d25258630f652d06c1331e794653c0ae83 Author: Igal Sapir AuthorDate: Fri Mar 15 13:55:56 2019 -0700 Added ant taget echoproperties for easier troubleshooting --- build.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/build.xml b/build.xml index 381a081..c6e768e 100644 --- a/build.xml +++ b/build.xml @@ -493,6 +493,11 @@ + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Default Number of Test Threads
On Fri, Mar 15, 2019 at 9:45 AM Konstantin Kolinko
wrote:
> чт, 14 мар. 2019 г. в 22:26, Igal Sapir :
>
> What is the use case? People verifying a release? CI servers that may
> have different hardware?
>
The idea was more for testing new releases. On my laptop setting
test.threads to 8 completes in about 10 minutes, while the default 1 thread
takes more than 1 hour.
I looked deeper into build.xml and I found some interesting information and
a simple solution for my issue. In build.xml we have the following:
So I can place my settings for test.threads in ~/build.properties.
The current order of precedence, however, gives
${user.home}/build.properties a higher priority than the one at
{tomcat}/build.properties.
That is wrong IMHO and should be the other way around, i.e.
{tomcat}/build.properties should override${user.home}/build.properties . I
would like to change that order if everyone agrees.
I added an ant target, echoproperties [1], which outputs the merged
properties so it's easy to see the final values.
Best,
Igal
[1] https://github.com/apache/tomcat/commit/8a2f41bed80a
[tomcat] branch master updated: Added ant taget echoproperties for easier troubleshooting
This is an automated email from the ASF dual-hosted git repository. isapir pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8a2f41b Added ant taget echoproperties for easier troubleshooting 8a2f41b is described below commit 8a2f41bed80a96bd6d711594ea8b6b7f0f1451da Author: Igal Sapir AuthorDate: Fri Mar 15 13:35:58 2019 -0700 Added ant taget echoproperties for easier troubleshooting --- build.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/build.xml b/build.xml index cd2d006..c97a945 100644 --- a/build.xml +++ b/build.xml @@ -490,6 +490,11 @@ + + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Wiki migration
On 15/03/2019 18:05, Konstantin Kolinko wrote: > пт, 15 мар. 2019 г. в 20:07, Mark Thomas : >> >> All, >> >> I am going to attempt the wiki migration. Given it is last thing on a >> Friday, it will either work perfectly or be a complete disaster. I have >> a backup of our Confluence Space in case it is the latter. >> >> If it works, I'll update the links on the website after the migration. > > I do not like it! Moin is being shutdown in less than three months. The choice is when we migrate, not if we migrate. > 1. All links will be broken, including ones > a) in e-mail archives > b) on other sites, like stackoverflow That is going to be the case whatever we migrate to. It wouldn't be too hard to put redirects in place. We can talk to infra about that. The old pages will stay in place too so we have time. We just need to make the old pages read-only. > 2. Links used by Confluence are not pretty, with all those '+'s > > 3. It does to integrate well with e-mail. > > As currently, it is not configured to echo changes to the dev@ mailing list, > and if done so it cannot send plaintext e-mails. That issue is 50% confluence (it marks the changes email as bulk with no option to change that) and 50% ezmlm (it automatically drops bulk email). That problem should be solvable. I'll pester infra about that one. > 4. Proprietary close-source software. As are GitHub and GitLab... We have already started moving some pages to Confluence manually. > Are there other ways? > > E.g. > 1) static web site, managed via git pub-sub Not an option. You'd need to be a committer to use it. > 2) GitHub wiki pages? > 3) GitLab wiki pages? > > There also exists the following project, > http://jspwiki.apache.org/ > if we talk about "our own dog food". Infra has chosen Confluence. If we want to run jspwiki on our own VM that is an option but it needs *long term* volunteers to maintain the VM. Experience elsewhere in the ASF is that that usually doesn't work. Mark > > > Best regards, > Konstantin Kolinko > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling
toby1984 commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473394845 Thanks for taking the time to look at my changes! I totally missed the code dealing with dynamic reconfiguration through JMX. I changed my code to keep the old behaviour (pool cleaner is only started when timeBetweenEvictionRunsMillis > 0) and added documentation to maxAge pointing out that the age of idle connections will only be checked if both maxAge and timeBetweenEvictionRunsMillis are set. I also adjusted ConnectionPool#checkPoolConfiguration() to set timeBetweenEvictionRunsMillis=maxAge in case that timeBetweenEvictionRunsMillis>maxAge (because otherwise the maxAge cannot be guaranteed). setMaxAge() now calls both checkPoolConfiguration() and a new poolCleanerAttributeUpdated() method where I moved all the duplicated "start/stop pool cleaner if necessary" code to. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Wiki migration
пт, 15 мар. 2019 г. в 20:07, Mark Thomas : > > All, > > I am going to attempt the wiki migration. Given it is last thing on a > Friday, it will either work perfectly or be a complete disaster. I have > a backup of our Confluence Space in case it is the latter. > > If it works, I'll update the links on the website after the migration. I do not like it! 1. All links will be broken, including ones a) in e-mail archives b) on other sites, like stackoverflow 2. Links used by Confluence are not pretty, with all those '+'s 3. It does to integrate well with e-mail. As currently, it is not configured to echo changes to the dev@ mailing list, and if done so it cannot send plaintext e-mails. 4. Proprietary close-source software. Are there other ways? E.g. 1) static web site, managed via git pub-sub 2) GitHub wiki pages? 3) GitLab wiki pages? There also exists the following project, http://jspwiki.apache.org/ if we talk about "our own dog food". Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Wiki migration
All, I am going to attempt the wiki migration. Given it is last thing on a Friday, it will either work perfectly or be a complete disaster. I have a backup of our Confluence Space in case it is the latter. If it works, I'll update the links on the website after the migration. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63251] [JDK-8194653] Deadlock in FileSystems.getDefault on catalina startup
https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Mark Thomas --- Thanks for the report and the stack trace showing the problem. Fixed in: - master for 9.0.18 onwards - 8.5.x for 8.5.40 onwards - 7.0.x for 7.0.94 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Default Number of Test Threads
чт, 14 мар. 2019 г. в 22:26, Igal Sapir : > > Does test.threads default to 1 for a reason? > > If there is no objection, I would like to set the default to the number > of available CPU Threads. It looks like that can be done with a custom > Ant task which should be fairly simple to implement. It depends on the actual implementation, and do not forget to document the setting in RUNNING.txt. What is the use case? People verifying a release? CI servers that may have different hardware? 1) Personally, I'll be bothered by this, as I do other things on my PC while the tests are running. It is not much, as I always have a custom build.properties file with a "base.path" setting, but it has to be documented properly. 2) If additional logging is enabled (e.g. access logs), things will be messy if several tests run in parallel. 3) If someone explicitly runs a specific test, things will be messy if several tests run in parallel. I think that JUnit runs several test classes in parallel, but not different tests from the same test class. (Maybe it is configurable). 4) IIRC, coverage tests need to run in single thread. We have a separate configuration at Buildbot to run the coverage tests once a day (scheduled by time). I do not remember whether that configuration is explicitly configured with thread count of 1. It may be that the other configurations a configured with an explicit count of threads, but this one has not been configured. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Add test only targets
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new db5a7f6 Add test only targets
db5a7f6 is described below
commit db5a7f6535f63c89be9ceff076f2566aac394a46
Author: remm
AuthorDate: Fri Mar 15 16:52:02 2019 +0100
Add test only targets
---
build.xml | 53 +
1 file changed, 53 insertions(+)
diff --git a/build.xml b/build.xml
index 54507d1..cd2d006 100644
--- a/build.xml
+++ b/build.xml
@@ -1493,18 +1493,65 @@
+
+
+
+
+
+
+
+
+
+
+
+
+ Testsuites with skipped tests:${line.separator}
+ ${toString:test.result.skippedtests}
+
+
+
+
+
+
+
+ Testsuites with failed tests:${line.separator}
+ ${toString:test.result.failedtests}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
@@ -1512,6 +1559,12 @@
extension=".APR" />
+
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot failure in on tomcat-85-trunk
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1705 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' triggered this build Build Source Stamp: [branch 8.5.x] 644779a17ec8a82268238b6f3e0fbfae014b Blamelist: Mark Thomas ,remm BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Fix regular read taking over async reads
On Fri, Mar 15, 2019 at 3:19 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: > new 004fe8b Fix regular read taking over async reads > 004fe8b is described below > > commit 004fe8bbab588b97b61f0bb03726deb379d0227b > Author: remm > AuthorDate: Fri Mar 15 15:19:13 2019 +0100 > > Fix regular read taking over async reads > > A call to registerReadInterest with the right timing could cause a > regular read to occur, preventing the use of vectored IO. This is > exhibited in the very elusive client timeout failure seen on CI, for > example here in build #4128: > > https://ci.apache.org/projects/tomcat/tomcat9/logs/4128/TEST-org.apache.coyote.http2.TestHttp2Section_6_7.NIO2.txt I have been using the cpulimit tool on Linux to be able to reproduce this one and then figure out the right "speed" to do it reliably and be able to debug it. I'm still seeing NIO2 failures that don't occur with NIO, but they seem to be caused by "legitimate" IO server side timeouts. Everything can happen very slowly with cpulimit and it's possible the read patterns are different between the two. I will continue to investigate though. Rémy
[tomcat] branch 8.5.x updated: Fix regular read taking over async reads
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 644779a Fix regular read taking over async reads
644779a is described below
commit 644779a17ec8a82268238b6f3e0fbfae014b
Author: remm
AuthorDate: Fri Mar 15 15:19:13 2019 +0100
Fix regular read taking over async reads
A call to registerReadInterest with the right timing could cause a
regular read to occur, preventing the use of vectored IO. This is
exhibited in the very elusive client timeout failure seen on CI, for
example here in build #4128:
https://ci.apache.org/projects/tomcat/tomcat9/logs/4128/TEST-org.apache.coyote.http2.TestHttp2Section_6_7.NIO2.txt
---
java/org/apache/tomcat/util/net/Nio2Endpoint.java | 2 ++
webapps/docs/changelog.xml| 8
2 files changed, 10 insertions(+)
diff --git a/java/org/apache/tomcat/util/net/Nio2Endpoint.java
b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
index fd19475..dcd9bb9 100644
--- a/java/org/apache/tomcat/util/net/Nio2Endpoint.java
+++ b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
@@ -958,6 +958,8 @@ public class Nio2Endpoint extends
AbstractJsseEndpoint {
if (timeout == -1) {
timeout = toNio2Timeout(getReadTimeout());
}
+// Disable any regular read notifications caused by
registerReadInterest
+readNotify = true;
if (block != BlockingMode.NON_BLOCK) {
try {
if (!readPending.tryAcquire(timeout, unit)) {
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5c2eb41..79c2636 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -76,6 +76,14 @@
+
+
+
+Fix bad interaction between NIO2 async read API and the regular read.
+(remm)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated (ab9eb21 -> e122477)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from ab9eb21 Expand the SSI documentation new ba568c4 Clean-up. No functional change. new e122477 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 JDK-8194653 The 11887 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/juli/logging/LogFactory.java | 93 ++-- webapps/docs/changelog.xml | 5 ++ 2 files changed, 67 insertions(+), 31 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Fix regular read taking over async reads
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 004fe8b Fix regular read taking over async reads 004fe8b is described below commit 004fe8bbab588b97b61f0bb03726deb379d0227b Author: remm AuthorDate: Fri Mar 15 15:19:13 2019 +0100 Fix regular read taking over async reads A call to registerReadInterest with the right timing could cause a regular read to occur, preventing the use of vectored IO. This is exhibited in the very elusive client timeout failure seen on CI, for example here in build #4128: https://ci.apache.org/projects/tomcat/tomcat9/logs/4128/TEST-org.apache.coyote.http2.TestHttp2Section_6_7.NIO2.txt --- java/org/apache/tomcat/util/net/Nio2Endpoint.java | 2 ++ webapps/docs/changelog.xml| 8 2 files changed, 10 insertions(+) diff --git a/java/org/apache/tomcat/util/net/Nio2Endpoint.java b/java/org/apache/tomcat/util/net/Nio2Endpoint.java index edfd10e..c49c209 100644 --- a/java/org/apache/tomcat/util/net/Nio2Endpoint.java +++ b/java/org/apache/tomcat/util/net/Nio2Endpoint.java @@ -984,6 +984,8 @@ public class Nio2Endpoint extends AbstractJsseEndpoint + + + +Fix bad interaction between NIO2 async read API and the regular read. +(remm) + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 JDK-8194653
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new c0995c6 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251
JDK-8194653
c0995c6 is described below
commit c0995c62f65e2f62d4e9f3c169a4b7445d3df792
Author: Mark Thomas
AuthorDate: Fri Mar 15 13:55:35 2019 +
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 JDK-8194653
Implement a work-around for a known JRE bug
(https://bugs.openjdk.java.net/browse/JDK-8194653) that may cause a
dead-lock when Tomcat starts.
---
java/org/apache/juli/logging/LogFactory.java | 14 ++
webapps/docs/changelog.xml | 5 +
2 files changed, 19 insertions(+)
diff --git a/java/org/apache/juli/logging/LogFactory.java
b/java/org/apache/juli/logging/LogFactory.java
index 6717610..e080f69 100644
--- a/java/org/apache/juli/logging/LogFactory.java
+++ b/java/org/apache/juli/logging/LogFactory.java
@@ -18,6 +18,7 @@ package org.apache.juli.logging;
import java.lang.reflect.Constructor;
import java.lang.reflect.InvocationTargetException;
+import java.nio.file.FileSystems;
import java.util.ServiceLoader;
import java.util.logging.LogManager;
@@ -71,6 +72,19 @@ public class LogFactory {
* Private constructor that is not available for public use.
*/
private LogFactory() {
+/*
+ * Work-around known a JRE bug.
+ * https://bugs.openjdk.java.net/browse/JDK-8194653
+ *
+ * Pre-load the default file system. No performance impact as we need
to
+ * load the default file system anyway. Just do it earlier to avoid the
+ * potential deadlock.
+ *
+ * This can be removed once the oldest JRE supported by Tomcat includes
+ * a fix.
+ */
+FileSystems.getDefault();
+
// Look via a ServiceLoader for a Log implementation that has a
// constructor taking the String name.
ServiceLoader logLoader = ServiceLoader.load(Log.class);
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index b7cede3..5c2eb41 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -69,6 +69,11 @@
target, return a file size of - rather than
1k. (markt)
+
+63251: Implement a work-around for a known JRE bug (https://bugs.openjdk.java.net/browse/JDK-8194653;>JDK-8194653)
+that may cause a dead-lock when Tomcat starts. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 JDK-8194653
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 6defc87 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251
JDK-8194653
6defc87 is described below
commit 6defc879f55b3c8b9013b111efb90ee6668f8ec7
Author: Mark Thomas
AuthorDate: Fri Mar 15 13:55:35 2019 +
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63251 JDK-8194653
Implement a work-around for a known JRE bug
(https://bugs.openjdk.java.net/browse/JDK-8194653) that may cause a
dead-lock when Tomcat starts.
---
java/org/apache/juli/logging/LogFactory.java | 14 ++
webapps/docs/changelog.xml | 5 +
2 files changed, 19 insertions(+)
diff --git a/java/org/apache/juli/logging/LogFactory.java
b/java/org/apache/juli/logging/LogFactory.java
index 3be213f..3cd4562 100644
--- a/java/org/apache/juli/logging/LogFactory.java
+++ b/java/org/apache/juli/logging/LogFactory.java
@@ -17,6 +17,7 @@
package org.apache.juli.logging;
import java.lang.reflect.Constructor;
+import java.nio.file.FileSystems;
import java.util.ServiceLoader;
import java.util.logging.LogManager;
@@ -70,6 +71,19 @@ public class LogFactory {
* Private constructor that is not available for public use.
*/
private LogFactory() {
+/*
+ * Work-around known a JRE bug.
+ * https://bugs.openjdk.java.net/browse/JDK-8194653
+ *
+ * Pre-load the default file system. No performance impact as we need
to
+ * load the default file system anyway. Just do it earlier to avoid the
+ * potential deadlock.
+ *
+ * This can be removed once the oldest JRE supported by Tomcat includes
+ * a fix.
+ */
+FileSystems.getDefault();
+
// Look via a ServiceLoader for a Log implementation that has a
// constructor taking the String name.
ServiceLoader logLoader = ServiceLoader.load(Log.class);
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index c410f52..ecfb116 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -69,6 +69,11 @@
target, return a file size of - rather than
1k. (markt)
+
+63251: Implement a work-around for a known JRE bug (https://bugs.openjdk.java.net/browse/JDK-8194653;>JDK-8194653)
+that may cause a dead-lock when Tomcat starts. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Simplify code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 9e9f28e Simplify code
9e9f28e is described below
commit 9e9f28efceee78dd928966a87d9aa73326d8fc3f
Author: Mark Thomas
AuthorDate: Fri Mar 15 13:29:04 2019 +
Simplify code
---
java/org/apache/tomcat/util/buf/B2CConverter.java | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/util/buf/B2CConverter.java
b/java/org/apache/tomcat/util/buf/B2CConverter.java
index 2dd63c0..9d72234 100644
--- a/java/org/apache/tomcat/util/buf/B2CConverter.java
+++ b/java/org/apache/tomcat/util/buf/B2CConverter.java
@@ -37,11 +37,8 @@ public class B2CConverter {
private static final StringManager sm =
StringManager.getManager(Constants.Package);
-private static final CharsetCache charsetCache;
+private static final CharsetCache charsetCache = new CharsetCache();
-static {
-charsetCache = new CharsetCache();
-}
// Protected so unit tests can use it
protected static final int LEFTOVER_SIZE = 9;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Simplify code
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new bd6eefa Simplify code
bd6eefa is described below
commit bd6eefaa22c7804a63c517935ae54660919829f7
Author: Mark Thomas
AuthorDate: Fri Mar 15 13:29:04 2019 +
Simplify code
---
java/org/apache/tomcat/util/buf/B2CConverter.java | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/util/buf/B2CConverter.java
b/java/org/apache/tomcat/util/buf/B2CConverter.java
index 0d3afd7..532c209 100644
--- a/java/org/apache/tomcat/util/buf/B2CConverter.java
+++ b/java/org/apache/tomcat/util/buf/B2CConverter.java
@@ -36,11 +36,8 @@ public class B2CConverter {
private static final StringManager sm =
StringManager.getManager(B2CConverter.class);
-private static final CharsetCache charsetCache;
+private static final CharsetCache charsetCache = new CharsetCache();
-static {
-charsetCache = new CharsetCache();
-}
// Protected so unit tests can use it
protected static final int LEFTOVER_SIZE = 9;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1855581 - in /tomcat/site/trunk: docs/res/images/poeditor.svg docs/tools.html xdocs/res/images/poeditor.svg xdocs/tools.xml
Author: markt Date: Fri Mar 15 12:19:03 2019 New Revision: 1855581 URL: http://svn.apache.org/viewvc?rev=1855581=rev Log: tools += POEditor Added: tomcat/site/trunk/docs/res/images/poeditor.svg (with props) tomcat/site/trunk/xdocs/res/images/poeditor.svg (with props) Modified: tomcat/site/trunk/docs/tools.html tomcat/site/trunk/xdocs/tools.xml Added: tomcat/site/trunk/docs/res/images/poeditor.svg URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/res/images/poeditor.svg?rev=1855581=auto == --- tomcat/site/trunk/docs/res/images/poeditor.svg (added) +++ tomcat/site/trunk/docs/res/images/poeditor.svg Fri Mar 15 12:19:03 2019 @@ -0,0 +1 @@ +http://www.w3.org/2000/svg; width="582.223" height="152" viewBox="0 0 582.22266 152">< path d="M126.978 89.023C118.108 97.893 106.62 102.547 95 103V53.3l31.978-31.978c18.696 18.695 18.696 49.006 0 67.7M95 38V14.228c6.228.337 12.38 2.35 17.722 6.05z" fill="#404953"/> \ No newline at end of file Propchange: tomcat/site/trunk/docs/res/images/poeditor.svg -- svn:eol-style = native Modified: tomcat/site/trunk/docs/tools.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tools.html?rev=1855581=1855580=1855581=diff == --- tomcat/site/trunk/docs/tools.html (original) +++ tomcat/site/trunk/docs/tools.html Fri Mar 15 12:19:03 2019 @@ -1,390 +1,420 @@ - - - - - -Apache Tomcat - Developer Tools - - - - - - - - - -http://tomcat.apache.org/;> - -Apache Tomcat - - -https://www.apache.org/foundation/contributing.html; target="_blank" class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" alt="Support Apache">http://www.apache.org/; target="_blank" class="pull-left"> - - - - - - - -https://www.google.com/search; method="get"> - -GO - - - - -Apache Tomcat - - -Home - - -Taglibs - - -Maven Plugin - - - - -Download - - -Which version? - - -https://tomcat.apache.org/download-90.cgi;>Tomcat 9 - - -https://tomcat.apache.org/download-80.cgi;>Tomcat 8 - - -https://tomcat.apache.org/download-70.cgi;>Tomcat 7 - - -https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors - - -https://tomcat.apache.org/download-native.cgi;>Tomcat Native - - -https://tomcat.apache.org/download-taglibs.cgi;>Taglibs - - -https://archive.apache.org/dist/tomcat/;>Archives - - - - -Documentation - -
[Bug 63184] SSI documentation is incomplete
https://bz.apache.org/bugzilla/show_bug.cgi?id=63184 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Mark Thomas --- Fixed in: - master for 9.0.18 onwards - 8.5.x for 8.5.40 onwards - 7.0.x for 7.0.94 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #138: Expanding SSI documentation (bug # 63184)
markt-asf closed pull request #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#issuecomment-473248983 Applied manually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated (3a97c8c -> ab9eb21)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 3a97c8c Remove duplicated comments new 5eaade5 Improve SSI fsize output for invalid files new ab9eb21 Expand the SSI documentation The 11885 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/catalina/ssi/SSIFsize.java | 4 ++- webapps/docs/changelog.xml | 14 webapps/docs/ssi-howto.xml | 58 +- 3 files changed, 67 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated (9f04cf0 -> c12b271)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 9f04cf0 Remove duplicated comments new dbdf7e2 Improve SSI fsize output for invalid files new c12b271 Expand the SSI documentation The 19103 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/catalina/ssi/SSIFsize.java | 4 ++- webapps/docs/changelog.xml | 14 webapps/docs/ssi-howto.xml | 58 +- 3 files changed, 67 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (3617dbb -> 7774a2b)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 3617dbb Merge pull request #148 from samslow/master new 1a7c45b Improve SSI fsize output for invalid files new 7774a2b Expand the SSI documentation The 20641 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: java/org/apache/catalina/ssi/SSIFsize.java | 4 ++- webapps/docs/changelog.xml | 14 webapps/docs/ssi-howto.xml | 58 +- 3 files changed, 67 insertions(+), 9 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184)
markt-asf commented on issue #138: Expanding SSI documentation (bug # 63184) URL: https://github.com/apache/tomcat/pull/138#issuecomment-473210613 Looks like you merged in changes from trunk rather than rebasing your PR and doing a forced push. I'll see if I can unpick this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 55559] UserDatabaseRealm enhacement: may use local JNDI
On 15/03/2019 04:34, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=9 > > --- Comment #4 from isabelladom --- I have disabled this idiot's account and deleted all their comments. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.17
2019年3月14日(木) 3:23 Mark Thomas : > The proposed Apache Tomcat 9.0.17 release is now available for voting. > > The major changes compared to the 9.0.16 release are: > > - The APR/Native connector now supports both OpenSSL and JSSE TLS > configuration syntax (NIO and NIO2 already support this) > > - Various improvements to NIO2 > > - Various fixes for HTTP/2 push requests > > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.17/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1205/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.17 > 25d7c99e8c44a41a08ba85ccaba3cfec6af9c801 > > The proposed 9.0.17 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.17 > > +1 Tested on some test application (enable session replication). > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Keiichi.Fujino
[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473180351 Personally, the primary factor in starting PoolCleaner should be timeBetweenEvictionRunsMillis. Same as removeAbandoned / testWhileIdle / minEvictableIdleTimeMillis. If we want to reconnect to an idle connection, We should set both maxAge and timeBetweenEvictionRunsMillis. (JMX)ConnectionPool provides the feature to restart PoolCleaner when attributes related to PoolCleaner are changed. If maxAge is changed, you should restart PoolCleaner. see:org.apache.tomcat.jdbc.pool.jmx.ConnectionPool This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling
KeiichiFujino commented on issue #140: jdbc-pool: Improve maxAge handling URL: https://github.com/apache/tomcat/pull/140#issuecomment-473176479 > I fixed the missing calls to PooledConnection#validate(int). Thanks. > Looking at the code it seems that the timestamp should only be updated when user-initiated (like borrow or return) operations are executed on the PooledConnection, not when (possibly internal) operations are executed on the underlying JDBC Connection - right ? That's right. There is no need to call PooledConnection#setTimestamp(long) when reconnecting an idle connection. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
