date:20190320

[GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2019-03-20 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk has an issue affecting its community integration.
This issue affects 4 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk :  Tomcat 9.x, a web server implementing the Java Servlet 
4.0,
...
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -DEBUG- Dependency on junit exists, no need to add for property junit.jar.
 -INFO- Made directory [/srv/gump/public/workspace/tomcat-trunk/tomcat-deps]
 -INFO- Failed with reason build failed
 -DEBUG- Extracted fallback artifacts from Gump Repository



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html
Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build)
Work ended in a state of : Failed
Elapsed: 21 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar 
-Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/classes:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar:/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar:/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar:/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar:/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar:/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar:/srv/gu
 mp/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar
-
testexist:
 [echo] Testing  for 
/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar

setproxy:

downloadfile:

testexist:
 [echo] Testing  for /srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar

setproxy:

downloadfile:

build-prepare:
   [delete] Deleting directory 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
[mkdir] Created dir: 
/srv/gump/public/workspace/tomcat-trunk/output/build/temp

compile-prepare:

download-validate:

validate:

compile:
[javac] Compiling 1706 source files to 
/srv/gump/public/workspace/tomcat-trunk/output/classes
[javac] Support for javac --release has been added in Java9 ignoring it
[javac] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:326:
 error: cannot find symbol
[javac]  CompilerOptions.VERSION_11);
[javac] ^
[javac]   symbol:   variable VERSION_11
[javac]   location: class CompilerOptions
[javac] 
/srv/gump/public/workspace/tomcat-trunk/java/org/apache/jasper/compiler/JDTCompiler.java:387:
 error: cannot find symbol
[javac] CompilerOptions.VERSION_11);
[javac]^
[javac]   symbol:

Re: Wiki migration

2019-03-20 Thread Tim Funk

Thanks! I've done the following
- Created a page called "Parent page for Trash"
- Moved all user pages and many spam pages under that page (drag/drop a lot
faster than clicking page then choose delete from options)
- Put most FAQ pages under FAQ parent and removed FAQ from most page names
- Did basic formatting cleanup and very minimal content removal for
inaccurate information
- Moved FAQ out of the "Migrated Content folder"


Next todo's
- Either create a top level how to and move more pages under it. Or put
them under a HowTo in the FAQ hierarchy. This should cleanup quite a few
pages out of the Migrated Content folder
- Go back trough the FAQs and decide what to do with many of the dated
tomcat 5/6 references.
- Determine how to fix many of the broken mailing list links.
- Try to determine where any remaining Migrated Content pages go.





On Sun, Mar 17, 2019 at 4:12 PM Mark Thomas  wrote:

> It was a permission issue. I've just fixed that.
>
> Mark
>
>
> On 17/03/2019 20:02, Tim Funk wrote:
> > Hmm ...
> >
> > Either I don't have permissions to make edits, or I need read a
> tutorial. I
> > was going to delete some obvious spam pages which were migrated and then
> > start moving other questionable pages to a sandbox to be debated later.
> >
> > I signed up via my apache email address.
> >
> > -Tim
> >
>

Tomcat 7, Checkstyle and Gump

2019-03-20 Thread Mark Thomas

Something is going to have to give:

Tomcat 7.0.x needs to build with Java 6.
 - The last version of Checkstyle to run on Java 6 is 6.1.1

Gump uses the latest snapshot build of checkstyle
 - currently 8.19-SNAPSHOT

Checkstyle 6.1.1 expects cacheFile to be configured under the TreeWalker

Checkstyle moved cacheFile to Checker in 6.16 as a breaking change

Checkstyle finally cacheFile from TreeWalker a few days ago

Checkstyle fails if the configuration is invalid.

I can't see a way to have the build work with Checkstyle when building
locally with Java 6 and on Gump.

Currently validate works on Gump but fails locally.

I was thinking about running the validate task with Checkstyle 6.16 or
later under Java 7 but I don't see an obvious way to do that. It is
probably possible via an exec task or similar.

Any suggestions?

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63274] small typo in changelog.xml

2019-03-20 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63274

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 OS||All

--- Comment #1 from Mark Thomas  ---
Thanks.

Fixed in:
- master for 9.0.18 onwards
- 8.5.x for 8.5.40 onwards
- 7.0.x for 7.0.94 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new ff6ea71  https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
ff6ea71 is described below

commit ff6ea71552275e08c5e2a93260af03fccab330d0
Author: Mark Thomas 
AuthorDate: Wed Mar 20 22:25:38 2019 +

https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e491b0b..33b3d3e 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -65,7 +65,7 @@
 63206: Add a new attribute to Context -
 createUploadTargets which, if true enables
 Tomcat to create the temporary upload location used by a Servlet if the
-location specified by the Servlet does not already exist. The deafult
+location specified by the Servlet does not already exist. The default
 value is false. (markt)
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 9810766  https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
9810766 is described below

commit 981076657e31ccf21bad717ee0e1a9d561360006
Author: Mark Thomas 
AuthorDate: Wed Mar 20 22:24:54 2019 +

https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bc2a16f..e3e2029 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -154,7 +154,7 @@
 63206: Add a new attribute to Context -
 createUploadTargets which, if true enables
 Tomcat to create the temporary upload location used by a Servlet if the
-location specified by the Servlet does not already exist. The deafult
+location specified by the Servlet does not already exist. The default
 value is false. (markt)
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new d731707  https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
d731707 is described below

commit d731707a80bd21a3af8fefdf0c817237a53442e8
Author: Mark Thomas 
AuthorDate: Wed Mar 20 22:23:00 2019 +

https://bz.apache.org/bugzilla/show_bug.cgi?id=63274 Fix typo
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index cc52aa9..8eb14b0 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -144,7 +144,7 @@
 63206: Add a new attribute to Context -
 createUploadTargets which, if true enables
 Tomcat to create the temporary upload location used by a Servlet if the
-location specified by the Servlet does not already exist. The deafult
+location specified by the Servlet does not already exist. The default
 value is false. (markt)
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix JarScanner for Java9 onwards

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 1d05f3f  Fix JarScanner for Java9 onwards
1d05f3f is described below

commit 1d05f3f5d73a50e817e987f43c6c829d521732b1
Author: Mark Thomas 
AuthorDate: Wed Mar 20 22:19:16 2019 +

Fix JarScanner for Java9 onwards

Ensure that the JarScanner correctly tests whether JARs found on the
class path should be skipped when running on Java 9 or later.
---
 java/org/apache/tomcat/util/scan/StandardJarScanner.java | 10 +-
 webapps/docs/changelog.xml   |  4 
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/java/org/apache/tomcat/util/scan/StandardJarScanner.java 
b/java/org/apache/tomcat/util/scan/StandardJarScanner.java
index 696d618..b27f40b 100644
--- a/java/org/apache/tomcat/util/scan/StandardJarScanner.java
+++ b/java/org/apache/tomcat/util/scan/StandardJarScanner.java
@@ -259,9 +259,17 @@ public class StandardJarScanner implements JarScanner {
 // Process URLs
 for (URL url : urls) {
 if (!processedURLs.contains(url)) {
+// Avoid duplicates
+processedURLs.add(url);
+
+// Extract the jarName if there is one to be found
+String jarName = getJarName(url);
+if (jarName != null && Matcher.matchName(ignoredJars, 
jarName)) {
+continue;
+}
+
 try {
 process(callback, url);
-processedURLs.add(url);
 } catch (IOException ioe) {
 log.warn(sm.getString("jarScan.classloaderFail",url), 
ioe);
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 1750e84..e491b0b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -111,6 +111,10 @@
 
href="https://bugs.openjdk.java.net/browse/JDK-8194653;>JDK-8194653)
 that may cause a dead-lock when Tomcat starts. (markt)
   
+  
+Ensure that the JarScanner correctly tests whether JARs found on the
+class path should be skipped when running on Java 9 or later. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63274] New: small typo in changelog.xml

2019-03-20 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=63274

Bug ID: 63274
   Summary: small typo in changelog.xml
   Product: Tomcat 7
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: usma...@ieml.ru
  Target Milestone: ---

Hello! Just a quick note that a current changelog.xml for active tomcat
branches(master,8.5 and  7.0 in github) contains a small typo in the
description of a fix for bug 63206 in Catalina subsection 
the word default is misspelled as deafult
https://github.com/apache/tomcat/blob/8.5.x/webapps/docs/changelog.xml line 157

https://github.com/apache/tomcat/blob/master/webapps/docs/changelog.xml line
147

https://github.com/apache/tomcat/blob/7.0.x/webapps/docs/changelog.xml line  68

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Update version numbers

2019-03-20 Thread remm

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new e3b41e3  Update version numbers
e3b41e3 is described below

commit e3b41e3b6aacf660115abeed88b1b5227eb577bd
Author: remm 
AuthorDate: Wed Mar 20 23:08:23 2019 +0100

Update version numbers
---
 res/tomcat-maven/Dockerfile | 2 +-
 res/tomcat-maven/pom.xml| 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/res/tomcat-maven/Dockerfile b/res/tomcat-maven/Dockerfile
index 2e5f0fa..8796dc0 100644
--- a/res/tomcat-maven/Dockerfile
+++ b/res/tomcat-maven/Dockerfile
@@ -47,7 +47,7 @@ RUN mkdir /opt
 # EXPOSE $jolokiaport
 
 # Optional: Add Prometheus agent for JMX monitoring
-# RUN mkdir /opt/prometheus && wget 
http://central.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.10/jmx_prometheus_javaagent-0.10.jar
 -O /opt/prometheus/prometheus.jar && wget 
https://raw.githubusercontent.com/prometheus/jmx_exporter/master/example_configs/tomcat.yml
 -O conf/prometheus.yaml
+# RUN mkdir /opt/prometheus && wget 
http://central.maven.org/maven2/io/prometheus/jmx/jmx_prometheus_javaagent/0.11.0/jmx_prometheus_javaagent-0.11.0.jar
 -O /opt/prometheus/prometheus.jar && wget 
https://raw.githubusercontent.com/prometheus/jmx_exporter/master/example_configs/tomcat.yml
 -O conf/prometheus.yaml
 # ARG prometheusport=9404
 # ENV 
JAVA_OPTS="-javaagent:/opt/prometheus/prometheus.jar=$prometheusport:conf/prometheus.yaml
 ${JAVA_OPTS}"
 # EXPOSE $prometheusport
diff --git a/res/tomcat-maven/pom.xml b/res/tomcat-maven/pom.xml
index 9036134..7630803 100644
--- a/res/tomcat-maven/pom.xml
+++ b/res/tomcat-maven/pom.xml
@@ -29,7 +29,7 @@
 
 UTF-8
 org.apache.catalina.startup.Tomcat
-9.0.16
+9.0.17
 
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat Website Redesign

2019-03-20 Thread Igal Sapir


On 3/20/2019 10:49 AM, Mark Thomas wrote:

On 20/03/2019 16:01, Igal Sapir wrote:

  The way I see it we have the following options ATM:

a) Do nothing, i.e. keep the website as-is [1] for now

b) I can address the issues that were brought up and fix them for the
current proposed design [2]

c) I can propose a new design with a vertical menu bar instead of a
horizontal one

d) Someone else can propose a design and I will implement it with
HTML5/CSS/JavaScript

e) Someone else can do the whole thing

IMO option (a) is not good because the site is very outdated and not
mobile friendly.  Many users nowadays view sites on their phones and/or
tablets, which a modern design can address.

I'd be happy to hear your thoughts.

As you are the one doing the work I'll support whichever option you
prefer (although I'll note I'm not a big fan of option a)


Thanks, Mark!

I personally prefer option b which will also be the fastest to complete 
at this point, but I know that Konstantin and IIRC Rémy didn't like the 
horizontal navbar so I proposed the other options.


Igal




Mark



Best,

Igal

[1] http://tomcat.apache.org/
[2] http://people.apache.org/~isapir/mockups/tomcat-site/



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat Website Redesign

2019-03-20 Thread Mark Thomas

On 20/03/2019 16:01, Igal Sapir wrote:
> Hi all,
> 
> As you probably know I have been working on a redesign of the Tomcat
> website but it's a bit of a challenge to come up with a design that
> everyone likes.  The way I see it we have the following options ATM:
> 
> a) Do nothing, i.e. keep the website as-is [1] for now
> 
> b) I can address the issues that were brought up and fix them for the
> current proposed design [2]
> 
> c) I can propose a new design with a vertical menu bar instead of a
> horizontal one
> 
> d) Someone else can propose a design and I will implement it with
> HTML5/CSS/JavaScript
> 
> e) Someone else can do the whole thing
> 
> IMO option (a) is not good because the site is very outdated and not
> mobile friendly.  Many users nowadays view sites on their phones and/or
> tablets, which a modern design can address.
> 
> I'd be happy to hear your thoughts.

As you are the one doing the work I'll support whichever option you
prefer (although I'll note I'm not a big fan of option a)

Mark


> 
> Best,
> 
> Igal
> 
> [1] http://tomcat.apache.org/
> [2] http://people.apache.org/~isapir/mockups/tomcat-site/
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat Website Redesign

2019-03-20 Thread Igal Sapir


Hi all,

As you probably know I have been working on a redesign of the Tomcat 
website but it's a bit of a challenge to come up with a design that 
everyone likes.  The way I see it we have the following options ATM:


a) Do nothing, i.e. keep the website as-is [1] for now

b) I can address the issues that were brought up and fix them for the 
current proposed design [2]


c) I can propose a new design with a vertical menu bar instead of a 
horizontal one


d) Someone else can propose a design and I will implement it with 
HTML5/CSS/JavaScript


e) Someone else can do the whole thing

IMO option (a) is not good because the site is very outdated and not 
mobile friendly.  Many users nowadays view sites on their phones and/or 
tablets, which a modern design can address.


I'd be happy to hear your thoughts.

Best,

Igal

[1] http://tomcat.apache.org/
[2] http://people.apache.org/~isapir/mockups/tomcat-site/



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Becoming graalvm friendly?

2019-03-20 Thread Romain Manni-Bucau

Le mer. 20 mars 2019 à 15:06, Rémy Maucherat  a écrit :

> On Tue, Mar 19, 2019 at 4:52 PM Romain Manni-Bucau 
> wrote:
>
> > Hi Rémy, well there are two topics here:
> >
> > 1. how to run tomcat without all that JMX stuff - in Meecrowave for
> > instance we deactivate it by default since in 80% of the usages it is not
> > used - so I think it is a valid option to make it easily deactivable and
> if
> > done well enough it would be easy to "subtrate" the code through svm
> (from
> > graal project) which enable to kind of monkey patch an app (so it should
> be
> > very localized otherwise the maintenance is just hell)
> >
>
> JMX does all the Tomcat monitoring (JVM + container), including also the
> monitoring in cloud environments (with Jolokia and Prometheus). So it is
> difficult for me to understand why it's a such good idea for users to
> remove it. It's quite a bit of work too.
>

Most of the time monitoring is done through a custom exporter in practise
based on other impl - sigar, library integration like
hibernate/eclipselinks ones, metrics, microprofile etc... -  and JMX is not
then used - not judging it is good, bad, lack of knowledge or not, just
saying what i see.
Now I'm happy if JMX is made graal compatible. From what I saw, mainly the
MBeanServer and Notifier (through the hierarchy it goes until that point in
the JVM in standard mbeans) are blocking the compilation. I'm pretty sure
these parts of Tomcat can be extracted in a particular class and then
substrated which would make it graal compatible probably.



>
>
> > 2. graalvm will get more and more support for these parts but I guess
> > tomcat could be less coupled to JMX - in terms of code path - which would
> > also solve the issue.
> >
> > Finally on the url handler part, it is plain useless in native mode so
> > being able to move that URL.setXXX in a static class we would substrate
> by
> > a noop can be worth it too.
> >
> > Hope it makes some sense.
> >
>
> Rémy
>
> >
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn  | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
> >
> > Le mar. 19 mars 2019 à 16:38, Rémy Maucherat  a écrit :
> >
> > > On Sun, Mar 10, 2019 at 6:24 PM Romain Manni-Bucau <
> > rmannibu...@gmail.com>
> > > wrote:
> > >
> > > > Hi guys,
> > > >
> > > > Anyone got a look to graalvm native-image tool?
> > > > Tomcat does not work OOTB due to its JMX wide usage - all is not
> > > > implemented in graalvm native scope. That said most of this code is
> not
> > > > really used by Tomcat and can be dropped while keeping Tomcat - at
> > least
> > > > embedded - running. The other hit issue is the URL handler usage.
> > > >
> > > > So concretely - and without entering into the details at that early
> > > stage,
> > > > ensuring TomcatURLStreamHandlerFactory does not use URL custom
> factory
> > > > registration (constructor) and Registry/MBeanUtils don't rely on
> > > > MBeanServer loading directly would be a first step to be able native
> > > > images. To test it I @Substitute them with substrate API but it
> > requires
> > > to
> > > > fork some part of Tomcat which is not desired at all on my side.
> > > >
> > > > This is just the first step since, if you want to keep all features,
> > you
> > > > will need to create a json with the reflection metadata for some
> > features
> > > > but at least these two "changes" would enable to run native-image
> > > > successfully.
> > > >
> > > > Overall this mail does not intend to speak of "fix" yet but only
> mainly
> > > > intend to ask two questions:
> > > >
> > > > 1. any existing status on graalvm native image support I would have
> > > missed?
> > > > 2. any will to work in that direction in the community? (graalvm is
> > still
> > > > very young and lack several features to really embrace java ecosystem
> > so
> > > > can be fair to say "later")
> > > >
> > >
> > > Well, the said features are quite useful/nice/etc, and I haven't been
> > > looking at native images. Any real concrete plan to improve things
> > without
> > > removing useful items ?
> > >
> > > Rémy
> > >
> >
>

Re: Tomcat 7, DBCP 1.x and generics

2019-03-20 Thread Igal Sapir


On 3/19/2019 6:34 AM, Mark Thomas wrote:

On 19/03/2019 04:04, Igal Sapir wrote:

On 3/18/2019 1:28 PM, Mark Thomas wrote:

All,

I started to work on cleaning up the DBCP generics warnings in 7.0.x 
before I remembered what "fun" it was when I did this for DBCP2. 
While some of it is straight-forward, some of it requires some 
refactoring. From memory, the refactoring did fix a few bugs along 
the way.


Given that the changes aren't trivial, I wanted to get some feedback 
from the community as to the best approach here. Options include:


a) No nothing

b) Fix the trivial generics

c) Fix all the generics including any necessary refactoring


I actually enjoy refactoring code so I'd be happy to help with (b) or 
(c) if either is chosen.


Thanks. I'll leave the thread open for a few days to see what folks 
think.


I have a lot of the trivial fixes sat in a local branch so it will be 
the 'fun' ones that will need to be completed.


Sounds good.

Working on tasks like that will make me more familiar with the source 
code and prepare me for tackling bigger issues in the future, so it can 
be beneficial beyond just completing the tasks.


Best,

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated (c863fea9 -> e56a692)

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.


from c863fea9 Update changelog for write pending refactoring
 new 980137b  Update JDT to 4.10
 new 6b979ea  Add support for Java 10 as the source/target for JSP 
compilation
 new e56a692  Correct previous commit (Java 11 support, not Java 10)

The 20658 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 build.properties.default| 12 ++--
 java/org/apache/jasper/compiler/JDTCompiler.java|  8 
 res/ide-support/eclipse/eclipse.classpath   |  2 +-
 res/ide-support/idea/tomcat.iml |  2 +-
 res/ide-support/netbeans/nb-tomcat-build.properties |  2 +-
 res/ide-support/netbeans/project.xml|  2 +-
 res/maven/tomcat-embed-jasper.pom   |  2 +-
 res/maven/tomcat-jasper.pom |  2 +-
 webapps/docs/changelog.xml  | 15 +++
 9 files changed, 35 insertions(+), 12 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

tcollignon commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474878836
 
 
   Ok I have add 11 and 12, I wait for your commit, and I will update this with 
just 12 if necessary
   
   thx


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

markt-asf commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474873975
 
 
   I actually just done this for Java 11. Could you do the same for Java 12?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Add support for Java 11 as the source/target for JSP compilation

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 733633a  Add support for Java 11 as the source/target for JSP 
compilation
733633a is described below

commit 733633aebd756614e48023062fff09ee1ed3e58d
Author: Mark Thomas 
AuthorDate: Wed Mar 20 15:07:11 2019 +

Add support for Java 11 as the source/target for JSP compilation
---
 java/org/apache/jasper/compiler/JDTCompiler.java | 9 +
 webapps/docs/changelog.xml   | 8 
 2 files changed, 17 insertions(+)

diff --git a/java/org/apache/jasper/compiler/JDTCompiler.java 
b/java/org/apache/jasper/compiler/JDTCompiler.java
index ecfd0a8..5f1d07a 100644
--- a/java/org/apache/jasper/compiler/JDTCompiler.java
+++ b/java/org/apache/jasper/compiler/JDTCompiler.java
@@ -379,6 +379,10 @@ public class JDTCompiler extends 
org.apache.jasper.compiler.Compiler {
 // Constant not available in latest ECJ version that runs on
 // Java 7
 settings.put(CompilerOptions.OPTION_Source, "10");
+} else if(opt.equals("11")) {
+// Constant not available in latest ECJ version that runs on
+// Java 7
+settings.put(CompilerOptions.OPTION_Source, "11");
 } else {
 log.warn("Unknown source VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_Source,
@@ -435,6 +439,11 @@ public class JDTCompiler extends 
org.apache.jasper.compiler.Compiler {
 // Java 7
 settings.put(CompilerOptions.OPTION_TargetPlatform, "10");
 settings.put(CompilerOptions.OPTION_Compliance, "10");
+} else if(opt.equals("11")) {
+// Constant not available in latest ECJ version that runs on
+// Java 7
+settings.put(CompilerOptions.OPTION_TargetPlatform, "11");
+settings.put(CompilerOptions.OPTION_Compliance, "11");
 } else {
 log.warn("Unknown target VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_TargetPlatform,
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e812a97..1750e84 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -127,6 +127,14 @@
   
 
   
+  
+
+  
+Add support for specifying Java 11 (with the value 11) as
+the compiler source and/or compiler target for JSP compilation. (markt)
+  
+
+  
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Add support for Java 11 as the source/target for JSP compilation

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new a8b43c4  Add support for Java 11 as the source/target for JSP 
compilation
a8b43c4 is described below

commit a8b43c40dabd98c0c3f375a307ea09c9007cedb7
Author: Mark Thomas 
AuthorDate: Wed Mar 20 15:05:05 2019 +

Add support for Java 11 as the source/target for JSP compilation
---
 java/org/apache/jasper/compiler/JDTCompiler.java | 9 +
 webapps/docs/changelog.xml   | 8 
 2 files changed, 17 insertions(+)

diff --git a/java/org/apache/jasper/compiler/JDTCompiler.java 
b/java/org/apache/jasper/compiler/JDTCompiler.java
index 9947152..6e20eed 100644
--- a/java/org/apache/jasper/compiler/JDTCompiler.java
+++ b/java/org/apache/jasper/compiler/JDTCompiler.java
@@ -348,6 +348,10 @@ public class JDTCompiler extends 
org.apache.jasper.compiler.Compiler {
 // Constant not available in latest ECJ version that runs on
 // Java 7
 settings.put(CompilerOptions.OPTION_Source, "10");
+} else if(opt.equals("11")) {
+// Constant not available in latest ECJ version that runs on
+// Java 7
+settings.put(CompilerOptions.OPTION_Source, "11");
 } else {
 log.warn("Unknown source VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_Source,
@@ -404,6 +408,11 @@ public class JDTCompiler extends 
org.apache.jasper.compiler.Compiler {
 // Java 7
 settings.put(CompilerOptions.OPTION_TargetPlatform, "10");
 settings.put(CompilerOptions.OPTION_Compliance, "10");
+} else if(opt.equals("11")) {
+// Constant not available in latest ECJ version that runs on
+// Java 7
+settings.put(CompilerOptions.OPTION_TargetPlatform, "11");
+settings.put(CompilerOptions.OPTION_Compliance, "11");
 } else {
 log.warn("Unknown target VM " + opt + " ignored.");
 settings.put(CompilerOptions.OPTION_TargetPlatform,
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 71dcec4..bc2a16f 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -87,6 +87,14 @@
   
 
   
+  
+
+  
+Add support for specifying Java 11 (with the value 11) as
+the compiler source and/or compiler target for JSP compilation. (markt)
+  
+
+  
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

tcollignon commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474872724
 
 
   Ok sorry I didn't understand the first comment
   
   So I will update the PR like you said
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

markt-asf commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474861978
 
 
   What I meant was:
   - we should check for ECJ updates (I'm doing that now)
   - we should replicate the way Java 10 support is handled in Tomcat 7 in all 
Tomcat versions when ECJ doesn't have the necessary constants for the newer 
Java versions. If you wanted to update your PR along those lines that would be 
great.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Add note that 4.6.3 is the latest version for official builds

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new fb6b98a  Add note that 4.6.3 is the latest version for official builds
fb6b98a is described below

commit fb6b98afacff307ef0624efb35ee8dca2e1c1451
Author: Mark Thomas 
AuthorDate: Wed Mar 20 14:34:54 2019 +

Add note that 4.6.3 is the latest version for official builds
---
 build.properties.default | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/build.properties.default b/build.properties.default
index 102981f..30593a2 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -124,6 +124,9 @@ 
wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
 # - Eclipse JDT, version 4.5.1 or later -#
 # See https://wiki.apache.org/tomcat/JDTCoreBatchCompiler before updating
 #
+# 4.6.3 is the latest release that runs on Java 7
+# Later versions can be used but the official builds need to use 4.6.3
+#
 # Checksum is from "SHA512 Checksums for 4.6.3" link at
 # http://archive.eclipse.org/eclipse/downloads/drops4/R-4.6.3-201703010400/
 # 
http://archive.eclipse.org/eclipse/downloads/drops4/R-4.6.3-201703010400/checksum/eclipse-4.6.3-SUMSSHA512


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Add note that JDT 4.4.2 is the latest version for official builds

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 0e3a2ed  Add note that JDT 4.4.2 is the latest version for official 
builds
0e3a2ed is described below

commit 0e3a2ed0dbaee258024ae5726f7cd659bced9ac6
Author: Mark Thomas 
AuthorDate: Wed Mar 20 14:34:03 2019 +

Add note that JDT 4.4.2 is the latest version for official builds
---
 build.properties.default | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/build.properties.default b/build.properties.default
index 439cb71..9eaa9af 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -153,7 +153,8 @@ 
wsdl4j-lib.loc=${base-maven.loc}/wsdl4j/wsdl4j/${wsdl4j-lib.version}/wsdl4j-${ws
 wsdl4j-lib.jar=${wsdl4j-lib.home}/wsdl4j-${wsdl4j-lib.version}.jar
 
 # - Eclipse JDT, version 4.4 or later -#
-# See https://wiki.apache.org/tomcat/JDTCoreBatchCompiler before updating
+# 4.4.2 is the latest release that runs on Java 6
+# Later versions can be used but the official builds need to use 4.4.2
 jdt.version=4.4.2
 jdt.release=R-4.4.2-201502041700
 jdt.checksum.enabled=true


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Becoming graalvm friendly?

2019-03-20 Thread Rémy Maucherat

On Tue, Mar 19, 2019 at 4:52 PM Romain Manni-Bucau 
wrote:

> Hi Rémy, well there are two topics here:
>
> 1. how to run tomcat without all that JMX stuff - in Meecrowave for
> instance we deactivate it by default since in 80% of the usages it is not
> used - so I think it is a valid option to make it easily deactivable and if
> done well enough it would be easy to "subtrate" the code through svm (from
> graal project) which enable to kind of monkey patch an app (so it should be
> very localized otherwise the maintenance is just hell)
>

JMX does all the Tomcat monitoring (JVM + container), including also the
monitoring in cloud environments (with Jolokia and Prometheus). So it is
difficult for me to understand why it's a such good idea for users to
remove it. It's quite a bit of work too.


> 2. graalvm will get more and more support for these parts but I guess
> tomcat could be less coupled to JMX - in terms of code path - which would
> also solve the issue.
>
> Finally on the url handler part, it is plain useless in native mode so
> being able to move that URL.setXXX in a static class we would substrate by
> a noop can be worth it too.
>
> Hope it makes some sense.
>

Rémy

>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github <
> https://github.com/rmannibucau> |
> LinkedIn  | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mar. 19 mars 2019 à 16:38, Rémy Maucherat  a écrit :
>
> > On Sun, Mar 10, 2019 at 6:24 PM Romain Manni-Bucau <
> rmannibu...@gmail.com>
> > wrote:
> >
> > > Hi guys,
> > >
> > > Anyone got a look to graalvm native-image tool?
> > > Tomcat does not work OOTB due to its JMX wide usage - all is not
> > > implemented in graalvm native scope. That said most of this code is not
> > > really used by Tomcat and can be dropped while keeping Tomcat - at
> least
> > > embedded - running. The other hit issue is the URL handler usage.
> > >
> > > So concretely - and without entering into the details at that early
> > stage,
> > > ensuring TomcatURLStreamHandlerFactory does not use URL custom factory
> > > registration (constructor) and Registry/MBeanUtils don't rely on
> > > MBeanServer loading directly would be a first step to be able native
> > > images. To test it I @Substitute them with substrate API but it
> requires
> > to
> > > fork some part of Tomcat which is not desired at all on my side.
> > >
> > > This is just the first step since, if you want to keep all features,
> you
> > > will need to create a json with the reflection metadata for some
> features
> > > but at least these two "changes" would enable to run native-image
> > > successfully.
> > >
> > > Overall this mail does not intend to speak of "fix" yet but only mainly
> > > intend to ask two questions:
> > >
> > > 1. any existing status on graalvm native image support I would have
> > missed?
> > > 2. any will to work in that direction in the community? (graalvm is
> still
> > > very young and lack several features to really embrace java ecosystem
> so
> > > can be fair to say "later")
> > >
> >
> > Well, the said features are quite useful/nice/etc, and I haven't been
> > looking at native images. Any real concrete plan to improve things
> without
> > removing useful items ?
> >
> > Rémy
> >
>

[GitHub] [tomcat] tcollignon commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

tcollignon commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474831606
 
 
   Thx for your anwser
   So I will wait for ECJ right ? 
   Or maybe I can try to add options to Java 11 in ECJ ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] markt-asf commented on issue #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

markt-asf commented on issue #150: Add compiler source and target support for 
all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150#issuecomment-474829632
 
 
   We want to keep the allowed values to the valid ones. 7.0.x has the right 
sort of code in place for Java 10 support. We should replicate that. We should 
also check for ECJ updates - keeping in mind the minimum Java versions of reach 
Tomcat release.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[ANN] Apache Tomcat 8.5.39 available

2019-03-20 Thread Mark Thomas

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.5.39.

Apache Tomcat 8 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and Java Authentication Service Provider Interface for
Containers technologies.

Apache Tomcat 8.5.x replaces 8.0.x and includes new features pulled
forward from the 9.0.x branch. The notable changes since 8.5.38 include:

- The APR/Native connector now supports both OpenSSL and JSSE TLS
  configuration syntax (NIO and NIO2 already support this)

- Various improvements to NIO2

- Various fixes for HTTP/2 push requests

- Refactor error handling so that errors that occur early in request
  processing are handled by the application's error handling where the
  application can be identified


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.5-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 7.x and 8.0.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[ANN] Apache Tomcat 8.5.39 available

2019-03-20 Thread Mark Thomas

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.5.39.

Apache Tomcat 8 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and Java Authentication Service Provider Interface for
Containers technologies.

Apache Tomcat 8.5.x replaces 8.0.x and includes new features pulled
forward from the 9.0.x branch. The notable changes since 8.5.38 include:

- The APR/Native connector now supports both OpenSSL and JSSE TLS
  configuration syntax (NIO and NIO2 already support this)

- Various improvements to NIO2

- Various fixes for HTTP/2 push requests

- Refactor error handling so that errors that occur early in request
  processing are handled by the application's error handling where the
  application can be identified


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.5-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 7.x and 8.0.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r33094 - /release/tomcat/tomcat-8/v8.5.38/

2019-03-20 Thread markt

Author: markt
Date: Wed Mar 20 11:05:44 2019
New Revision: 33094

Log:
Drop 8.5.38 from mirrors

Removed:
release/tomcat/tomcat-8/v8.5.38/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1855896 [5/5] - in /tomcat/site/trunk: ./ docs/ xdocs/

2019-03-20 Thread markt

Modified: tomcat/site/trunk/docs/oldnews.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews.html?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/oldnews.html (original)
+++ tomcat/site/trunk/docs/oldnews.html Wed Mar 20 11:02:22 2019
@@ -1,319 +1,364 @@
 
 
-
-
-
-
-
-Apache Tomcat - Old news!
-
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/;>
-
-Apache Tomcat
-
-
-https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search; 
method="get">
-
-GO
-
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi;>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi;>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi;>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors
-
-
-https://tomcat.apache.org/download-native.cgi;>Tomcat Native
-
-
-https://tomcat.apache.org/download-taglibs.cgi;>Taglibs
-
-
-https://archive.apache.org/dist/tomcat/;>Archives
-
-
-
-
-Documentation
-
-
-Tomcat 9.0
-
-
-Tomcat 8.5
-
-
-Tomcat 7.0
-
-
-Tomcat 
Connectors
-
-
-Tomcat 
Native
-
-
-https://wiki.apache.org/tomcat/FrontPage;>Wiki
-
-
-Migration Guide
-
-
-Presentations
-
-
-
-

svn commit: r1855896 [1/5] - in /tomcat/site/trunk: ./ docs/ xdocs/

2019-03-20 Thread markt

Author: markt
Date: Wed Mar 20 11:02:22 2019
New Revision: 1855896

URL: http://svn.apache.org/viewvc?rev=1855896=rev
Log:
Update site for 8.5.39 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/docs/oldnews-2011.html
tomcat/site/trunk/docs/oldnews-2015.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-85.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Wed Mar 20 11:02:22 2019
@@ -37,7 +37,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 # - Tomcat versions -
 tomcat70=7.0.93
-tomcat85=8.5.38
+tomcat85=8.5.39
 tomcat90=9.0.17
 
 # - Download destination -

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Wed Mar 20 11:02:22 2019
@@ -67,15 +67,8 @@
 
   
 Latest Stable 8.5.x Release
-2018-09-10
-8.5.38
-  
-
-
-  
-Latest Stable 8.0.x Release
-2018-07-05
-8.0.53
+2019-03-19
+8.5.39
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Wed Mar 20 11:02:22 2019
@@ -1,242 +1,237 @@
 
 
-
-
-
-
-
-Apache Tomcat - Apache Tomcat 8 Software Downloads
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/;>
-
-Apache Tomcat
-
-
-https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search; 
method="get">
-
-GO
-
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi;>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi;>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi;>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors
-

svn commit: r1855896 [2/5] - in /tomcat/site/trunk: ./ docs/ xdocs/

2019-03-20 Thread markt

Modified: tomcat/site/trunk/docs/migration-85.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-85.html?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/migration-85.html (original)
+++ tomcat/site/trunk/docs/migration-85.html Wed Mar 20 11:02:22 2019
@@ -1,378 +1,381 @@
 
 
-
-
-
-
-
-Apache Tomcat - Migration Guide - Tomcat 8.5.x
-
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/;>
-
-Apache Tomcat
-
-
-https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search; 
method="get">
-
-GO
-
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi;>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi;>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi;>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors
-
-
-https://tomcat.apache.org/download-native.cgi;>Tomcat Native
-
-
-https://tomcat.apache.org/download-taglibs.cgi;>Taglibs
-
-
-https://archive.apache.org/dist/tomcat/;>Archives
-
-
-
-
-Documentation
-
-
-Tomcat 9.0
-
-
-Tomcat 8.5
-
-
-Tomcat 7.0
-
-
-Tomcat 
Connectors
-
-
-Tomcat 
Native
-
-
-https://wiki.apache.org/tomcat/FrontPage;>Wiki
-
-
-Migration Guide
-
-
-Presentations
-
-

svn commit: r1855896 [3/5] - in /tomcat/site/trunk: ./ docs/ xdocs/

2019-03-20 Thread markt

Modified: tomcat/site/trunk/docs/oldnews-2011.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2011.html?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/oldnews-2011.html (original)
+++ tomcat/site/trunk/docs/oldnews-2011.html Wed Mar 20 11:02:22 2019
@@ -1,813 +1,778 @@
 
 
-
-
-
-
-
-Apache Tomcat - Old news! - 2011
-
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/;>
-
-Apache Tomcat
-
-
-https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search; 
method="get">
-
-GO
-
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi;>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi;>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi;>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors
-
-
-https://tomcat.apache.org/download-native.cgi;>Tomcat Native
-
-
-https://tomcat.apache.org/download-taglibs.cgi;>Taglibs
-
-
-https://archive.apache.org/dist/tomcat/;>Archives
-
-
-
-
-Documentation
-
-
-Tomcat 9.0
-
-
-Tomcat 8.5
-
-
-Tomcat 7.0
-
-
-Tomcat 
Connectors
-
-
-Tomcat 
Native
-
-
-https://wiki.apache.org/tomcat/FrontPage;>Wiki
-
-
-Migration Guide
-
-
-Presentations
-
-
-

svn commit: r1855896 [4/5] - in /tomcat/site/trunk: ./ docs/ xdocs/

2019-03-20 Thread markt

Modified: tomcat/site/trunk/docs/oldnews-2015.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2015.html?rev=1855896=1855895=1855896=diff
==
--- tomcat/site/trunk/docs/oldnews-2015.html (original)
+++ tomcat/site/trunk/docs/oldnews-2015.html Wed Mar 20 11:02:22 2019
@@ -1,1260 +1,1239 @@
 
 
-
-
-
-
-
-Apache Tomcat - Old news!
-
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/;>
-
-Apache Tomcat
-
-
-https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search; 
method="get">
-
-GO
-
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi;>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi;>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi;>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi;>Tomcat Connectors
-
-
-https://tomcat.apache.org/download-native.cgi;>Tomcat Native
-
-
-https://tomcat.apache.org/download-taglibs.cgi;>Taglibs
-
-
-https://archive.apache.org/dist/tomcat/;>Archives
-
-
-
-
-Documentation
-
-
-Tomcat 9.0
-
-
-Tomcat 8.5
-
-
-Tomcat 7.0
-
-
-Tomcat 
Connectors
-
-
-Tomcat 
Native
-
-
-https://wiki.apache.org/tomcat/FrontPage;>Wiki
-
-
-Migration Guide
-
-
-Presentations
-
-
-

svn commit: r1855895 - in /tomcat/site/trunk/docs/tomcat-8.5-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

2019-03-20 Thread markt

Author: markt
Date: Wed Mar 20 10:48:38 2019
New Revision: 1855895

URL: http://svn.apache.org/viewvc?rev=1855895=rev
Log:
Update docs for 8.5.39 release


[This commit notification would consist of 72 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1855893 - /tomcat/site/trunk/docs/oldnews-2018.html

2019-03-20 Thread markt

Author: markt
Date: Wed Mar 20 10:33:49 2019
New Revision: 1855893

URL: http://svn.apache.org/viewvc?rev=1855893=rev
Log:
Add missing file

Added:
tomcat/site/trunk/docs/oldnews-2018.html   (with props)

Added: tomcat/site/trunk/docs/oldnews-2018.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2018.html?rev=1855893=auto
==
--- tomcat/site/trunk/docs/oldnews-2018.html (added)
+++ tomcat/site/trunk/docs/oldnews-2018.html Wed Mar 20 10:33:49 2019
@@ -0,0 +1,1555 @@
+
+
+
+
+
+
+
+Apache Tomcat - Old news!
+
+
+
+
+
+
+
+
+
+http://tomcat.apache.org/;>
+Apache Tomcat
+
+
+https://www.apache.org/foundation/contributing.html; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png; class="support-asf" 
alt="Support Apache">http://www.apache.org/; target="_blank" 
class="pull-left">
+
+
+
+
+
+
+
+https://www.google.com/search; method="get">
+
+GO
+
+
+
+
+Apache Tomcat
+
+
+Home
+
+
+Taglibs
+
+
+Maven Plugin
+
+
+
+
+Download
+
+
+Which version?
+
+
+https://tomcat.apache.org/download-90.cgi;>Tomcat 9
+
+
+https://tomcat.apache.org/download-80.cgi;>Tomcat 8
+
+
+https://tomcat.apache.org/download-70.cgi;>Tomcat 7
+
+
+https://tomcat.apache.org/download-connectors.cgi;>Tomcat 
Connectors
+
+
+https://tomcat.apache.org/download-native.cgi;>Tomcat Native
+
+
+https://tomcat.apache.org/download-taglibs.cgi;>Taglibs
+
+
+https://archive.apache.org/dist/tomcat/;>Archives
+
+
+
+
+Documentation
+
+
+Tomcat 9.0
+
+
+Tomcat 8.5
+
+
+Tomcat 7.0
+
+
+Tomcat Connectors
+
+
+Tomcat Native
+
+
+https://wiki.apache.org/tomcat/FrontPage;>Wiki
+
+
+Migration Guide
+
+
+Presentations
+
+
+
+
+Problems?
+
+
+Security Reports
+
+
+Find help
+
+
+https://wiki.apache.org/tomcat/FAQ;>FAQ
+
+
+Mailing Lists
+
+
+Bug Database
+
+
+IRC
+
+
+
+
+Get Involved
+
+
+Overview
+
+
+Source code
+
+
+Buildbot
+
+
+Tools
+
+
+
+
+Media
+
+
+https://twitter.com/theapachetomcat;>Twitter
+
+
+https://www.youtube.com/c/ApacheTomcatOfficial;>YouTube
+
+
+https://blogs.apache.org/tomcat/;>Blog
+
+
+
+
+Misc
+
+
+Who We Are
+
+
+https://www.redbubble.com/people/comdev/works/30885254-apache-tomcat;>Swag
+
+
+Heritage
+
+
+http://www.apache.org;>Apache Home
+
+
+Resources
+
+
+Contact
+
+
+Legal
+
+
+https://www.apache.org/foundation/contributing.html;>Support 
Apache
+
+
+https://www.apache.org/foundation/sponsorship.html;>Sponsorship
+
+
+http://www.apache.org/foundation/thanks.html;>Thanks
+
+
+http://www.apache.org/licenses/;>License
+
+
+
+
+
+
+
+
+Content
+Older news
+
+
+Announcements from previous years can be found here:
+
+
+  
+
+year 2019
+
+  
+year 2018
+  
+
+year 2017
+
+  
+
+year 2016
+
+  
+
+year 2015
+
+  
+
+year 2014
+
+  
+
+year 2013
+
+  
+
+year 2012
+
+  
+
+year 2011
+
+  
+
+year 2010
+
+
+
+
+
+
+2018-12-18 Tomcat 8.5.37 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 8.5.37
+of Apache Tomcat. Apache Tomcat 8.5.x replaces 8.0.x and includes new features
+pulled forward from Tomcat 9.0.x. The minimum Java version and implemented
+specification versions remain unchanged. The notable changes compared
+to 8.5.35 include:
+
+
+
+Implement the requirements of section 8.2.2 2.c of the Servlet 
specification
+and prevent a web application from deploying if it has fragments with
+duplicate names and is configured to use relative ordering of
+fragments.
+
+The default Servlet no longer overrides a previously set content-type.
+
+Update the packaged version of the Tomcat Native Library to 1.2.19 to pick
+up the latest Windows binaries built with APR 1.6.5 and OpenSSL 
1.1.1a.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 8.5
+changelog.
+
+
+
+
+
+https://tomcat.apache.org/download-80.cgi;>Download
+
+
+
+
+
+2018-12-12 Tomcat 9.0.14 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 9.0.14
+of Apache Tomcat. The notable changes compared to 9.0.13 include:
+
+
+
+Significant expansion of localisation support with the addition of 
Brazilian
+Portuguese, Korean and Chinese (simplified) as well as the expansion of
+coverage for existing languages.
+
+Refactor back ground processing and various independent thread pools to use
+a common executor.
+
+Update the packaged version of the Tomcat Native Library to 1.2.19 to pick
+up the latest Windows binaries built with APR 1.6.5 and OpenSSL 
1.1.1a.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 9
+changelog.
+
+
+
+
+
+https://tomcat.apache.org/download-90.cgi;>Download
+
+
+
+
+
+2018-12-04 Tomcat Native 1.2.19 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 1.2.19 of
+Tomcat Native. The notable changes since 1.2.18 include:
+
+
+
+  
+Fixed memory leaks when using OCSP checks.
+  
+Windows binaries built with APR

[GitHub] [tomcat] tcollignon opened a new pull request #150: Add compiler source and target support for all Java versions over 10

2019-03-20 Thread GitBox

tcollignon opened a new pull request #150: Add compiler source and target 
support for all Java versions over 10
URL: https://github.com/apache/tomcat/pull/150
 
 
   Hi,
   
   I maintain the maven plugin to compile JSP : 
https://github.com/leonardehrenfried/jspc-maven-plugin
   
   We have receive an issue when someone trying to compile JSP with Java 11 (to 
obtain target jsp class in Java 11 bytecode) see 
https://github.com/leonardehrenfried/jspc-maven-plugin/issues/39
   
   I have look at the JDTCompiler source code and it appear that it handle only 
Java 10.
   
   So I propose this modifications : 
   
   - If compiler source or target is set, and value is not known by ECJ 
constant, we even set this directly and not fallback to Java 1.8.
   Java move faster now, and probably ECJ will not move as faster.
   - If compiler source or target is not set, we fallback to Java 1.8 as 
previous
   
   WDYT ?
   
   Thanks you all


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Move the cache file definition to the correct location

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new ef256db  Move the cache file definition to the correct location
ef256db is described below

commit ef256dbcad90a45834d62fe648b3b390e52c1695
Author: Mark Thomas 
AuthorDate: Wed Mar 20 10:24:47 2019 +

Move the cache file definition to the correct location
---
 res/checkstyle/javax-checkstyle.xml | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/res/checkstyle/javax-checkstyle.xml 
b/res/checkstyle/javax-checkstyle.xml
index 2197c6a..08501f9 100644
--- a/res/checkstyle/javax-checkstyle.xml
+++ b/res/checkstyle/javax-checkstyle.xml
@@ -23,13 +23,13 @@
   
   
 
+  
+  
+
   
 
   
-
-
-
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Move the cache file definition to the correct location

2019-03-20 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 3ea5360  Move the cache file definition to the correct location
3ea5360 is described below

commit 3ea53604dd2d65acb4dcd313b813e80b28aed9fb
Author: Mark Thomas 
AuthorDate: Wed Mar 20 10:23:55 2019 +

Move the cache file definition to the correct location
---
 res/checkstyle/org-checkstyle.xml | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/res/checkstyle/org-checkstyle.xml 
b/res/checkstyle/org-checkstyle.xml
index f087c39..cd31f0a 100644
--- a/res/checkstyle/org-checkstyle.xml
+++ b/res/checkstyle/org-checkstyle.xml
@@ -23,13 +23,13 @@
   
   
 
+  
+  
+
   
 
   
-
-
-
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 51447] Session type changes from Backup to Primary

2019-03-20 Thread Mark Thomas

On 20/03/2019 01:44, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=51447
> 
> --- Comment #2 from minianna1234567  ---

Another day, another idiot, another account disabled and associated
comments deleted.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Refactor write notifications

2019-03-20 Thread remm

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 85c2e8c  Refactor write notifications
85c2e8c is described below

commit 85c2e8c8b9ee81b9292cada33d0185df56a2a278
Author: remm 
AuthorDate: Wed Mar 20 10:54:49 2019 +0100

Refactor write notifications

Use the model from read notifications, and simplify (normally nesting
shouldn't be an issue, the code should ensure one notification when the
write ends, and avoid any until the next write at least), to attempt to
fix leftover very rare CI failure on TestCoyoteOutputStream. One
possible issue right now is the write semaphore release, so it needs
some testing.
---
 java/org/apache/tomcat/util/net/Nio2Endpoint.java | 71 ---
 webapps/docs/changelog.xml|  3 +
 2 files changed, 40 insertions(+), 34 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/Nio2Endpoint.java 
b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
index dcd9bb9..992063f 100644
--- a/java/org/apache/tomcat/util/net/Nio2Endpoint.java
+++ b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
@@ -38,7 +38,6 @@ import java.util.concurrent.Future;
 import java.util.concurrent.Semaphore;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import javax.net.ssl.SSLEngine;
 import javax.net.ssl.SSLSession;
@@ -443,14 +442,6 @@ public class Nio2Endpoint extends 
AbstractJsseEndpoint {
 
 public static class Nio2SocketWrapper extends 
SocketWrapperBase {
 
-private static final ThreadLocal 
nestedWriteCompletionCount =
-new ThreadLocal() {
-@Override
-protected AtomicInteger initialValue() {
-return new AtomicInteger(0);
-}
-};
-
 private SendfileData sendfileData = null;
 
 private final CompletionHandler 
readCompletionHandler;
@@ -599,37 +590,38 @@ public class Nio2Endpoint extends 
AbstractJsseEndpoint {
 @Override
 public void completed(Integer nBytes, ByteBuffer attachment) {
 writeNotify = false;
+boolean notify = false;
 synchronized (writeCompletionHandler) {
 if (nBytes.intValue() < 0) {
 failed(new 
EOFException(sm.getString("iob.failedwrite")), attachment);
 } else if (!nonBlockingWriteBuffer.isEmpty()) {
-nestedWriteCompletionCount.get().incrementAndGet();
 // Continue writing data using a gathering write
 ByteBuffer[] array = 
nonBlockingWriteBuffer.toArray(attachment);
 getSocket().write(array, 0, array.length,
 toNio2Timeout(getWriteTimeout()), 
TimeUnit.MILLISECONDS,
 array, gatheringWriteCompletionHandler);
-nestedWriteCompletionCount.get().decrementAndGet();
 } else if (attachment.hasRemaining()) {
 // Regular write
-nestedWriteCompletionCount.get().incrementAndGet();
 getSocket().write(attachment, 
toNio2Timeout(getWriteTimeout()),
 TimeUnit.MILLISECONDS, attachment, 
writeCompletionHandler);
-nestedWriteCompletionCount.get().decrementAndGet();
 } else {
 // All data has been written
-if (writeInterest) {
-writeInterest = false;
+if (writeInterest && !Nio2Endpoint.isInline()) {
 writeNotify = true;
+// Set extra flag so that write nesting does 
not cause multiple notifications
+notify = true;
+} else {
+// Release here since there will be no
+// notify/dispatch to do the release.
+writePending.release();
 }
-writePending.release();
+writeInterest = false;
 }
 }
-if (writeNotify && nestedWriteCompletionCount.get().get() 
== 0) {
-endpoint.processSocket(Nio2SocketWrapper.this, 
SocketEvent.OPEN_WRITE, Nio2Endpoint.isInline());
+if (notify) {
+endpoint.processSocket(Nio2SocketWrapper.this, 
SocketEvent.OPEN_WRITE,

Release Announcement: General Availability of Java 12 / JDK 12

2019-03-20 Thread Rory O'Donnell


  Hi Mark,

*1) Release Announcement: General Availability of Java 12 / JDK 12 [1] *

 * JDK 12, the reference implementation of Java 12, is now Generally
   Available.
 * GPL-licensed OpenJDK builds from Oracle are available here:
   https://jdk.java.net/12

This release includes the following  eight features:

 * JEP 189: Shenandoah: A Low-Pause-Time Garbage Collector (Experimental)
 * JEP 230: Microbenchmark Suite
 * JEP 334: JVM Constants API
 * JEP 340: One AArch64 Port, Not Two
 * JEP 341: Default CDS Archives
 * JEP 344: Abortable Mixed Collections for G1
 * JEP 346: Promptly Return Unused Committed Memory from G1
 * JEP 325: Switch Expressions (Preview)
   

Thanks to everyone who contributed JDK 12, whether by creating features 
or enhancements, logging  bugs, or downloading and testing the 
early-access builds.


*2) JDK 13 EA build 12, under both the GPL and Oracle EA licenses, is 
now available at **http://jdk.java.net/13**.*


 * Proposed - Schedule for JDK 13 [2]
 o 2019/06/13 Rampdown Phase One
 o 2019/07/18 Rampdown Phase Two
 o 2019/08/08 Initial Release Candidate
 o 2019/08/22 Final Release Candidate
 o 2019/09/17 General Availability
 * Recent Bug fixes of Interest
 o Build 9:
 + 8214719: Deprecate -Xverify:none option
 + 8216360: Deprecate -XX:CompilationPolicyChoice
 o Build 10:
 + 8218995: Deprecate the -XX:FailOverToOldVerifier option
 o Build 12 : 8160247: Mark deprecated javax.security.cert APIs
   with forRemoval=true
 + 8220050: Deprecate -XX:-ThreadLocalHandshakes
 + Apache Lucene Reported - 8219448: split-if update_uses
   accesses stale idom data
 * Changes in this build [3]

Rgds,Rory

[1] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002718.html
[2] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002716.html
[3] Changes 
 
in this build



--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

43 matches

Mail list logo