Re: [Bug 65138] New: Call Girls in Hyderabad

2021-02-11 Thread Felix Schumacher


Am 12.02.21 um 06:48 schrieb bugzi...@apache.org:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=65138
>
User has been blocked and spam deleted.

Felix


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65138] Call Girls in Hyderabad

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65138

Azat  changed:

   What|Removed |Added

 Resolution|--- |CLOSED
 OS||All
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65138] New: Call Girls in Hyderabad

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65138

Bug ID: 65138
   Summary: Call Girls in Hyderabad
   Product: Taglibs
   Version: nightly
  Hardware: HP
Status: NEW
  Severity: regression
  Priority: P2
 Component: Cache  Taglib
  Assignee: dev@tomcat.apache.org
  Reporter: hyderabadgir...@gmail.com
  Target Milestone: ---

Have you ever imagined having fun with a foreign import? Your imagination has
finally gotten wings with the help of Hyderabad escort. They provide high
profile foreigners to their privileged customers in the city of pearls. Thus,
no need to travel abroad to have fun with busty foreign girls. for more info
visit here:- https://www.hyderabadgirls.net/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jbampton opened a new pull request #405: docs: fix spelling

2021-02-11 Thread GitBox


jbampton opened a new pull request #405:
URL: https://github.com/apache/tomcat/pull/405


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jbampton commented on a change in pull request #361: feat(CI): add a GitHub action to lint the Markdown and YAML files.

2021-02-11 Thread GitBox


jbampton commented on a change in pull request #361:
URL: https://github.com/apache/tomcat/pull/361#discussion_r574856124



##
File path: .github/workflows/lint.yml
##
@@ -0,0 +1,36 @@
+#Licensed under the Apache License, Version 2.0 (the "License");
+#you may not use this file except in compliance with the License.
+#You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+#Unless required by applicable law or agreed to in writing, software
+#distributed under the License is distributed on an "AS IS" BASIS,
+#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#See the License for the specific language governing permissions and
+#limitations under the License.
+
+name: Lint
+
+on:
+  push:
+branches:
+  - master
+  pull_request:
+branches:
+  - master

Review comment:
   Linters should probably only rull on pull request to speed up build 
times.  
   Linting is a more minor test etc.

##
File path: .github/workflows/lint.yml
##
@@ -0,0 +1,36 @@
+#Licensed under the Apache License, Version 2.0 (the "License");
+#you may not use this file except in compliance with the License.
+#You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+#Unless required by applicable law or agreed to in writing, software
+#distributed under the License is distributed on an "AS IS" BASIS,
+#WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#See the License for the specific language governing permissions and
+#limitations under the License.
+
+name: Lint
+
+on:
+  push:
+branches:
+  - master
+  pull_request:
+branches:
+  - master
+
+jobs:
+  lint:
+name: 粒 Markdown and YAML
+runs-on: ubuntu-latest
+steps:
+  - uses: actions/checkout@v2
+  - name: yaml-lint
+uses: ibiqlik/action-yamllint@v3

Review comment:
   YAML Lint is not certified by GitHub. It is provided by a third-party 
and is governed by separate terms of service, privacy policy, and support 
documentation.  The new ASF rules mean we can't use third party scripts for 
GitHub Actions.  https://github.com/marketplace/actions/yaml-lint
   
   This YAML check with `yamllint` can be refactored to run on the official 
Python GitHub action by installing and running yamllint with pip.
   
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

2021-02-11 Thread Mark Thomas
On 11/02/2021 17:47, Mark Thomas wrote:
> The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
> available for voting.
> 
> The significant changes since 0.1.0 are:
> 
> - Various fixes to the packages that are and are not converted
> 
> - A new option to process zip archives in memory to support zip files
>   that use options that are incompatible with a streaming approach
> 
> - A new option to exclude files from transformation
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/
> 
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1299/
> 
> The tag is:
> https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
> 041e256e92078cd3b16a9adcd77faf257e3a5c88
> 
> The proposed 0.2.0 release is:
> 
> [ ] -1: Broken. Do not release because...
> [X] +1: Acceptable. Go ahead and release.

Tested with my local changes that add migration to Tomcat 10. A WAR
built from the Tomcat 9 examples works happily (Servlets, JSPs,
WebSocket) on Tomcat 10.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Apache Tomcat migration tool for Jakarta EE 0.2.0

2021-02-11 Thread Mark Thomas
The proposed Apache Tomcat migration tool for Jakarta EE 0.2.0 is now
available for voting.

The significant changes since 0.1.0 are:

- Various fixes to the packages that are and are not converted

- A new option to process zip archives in memory to support zip files
  that use options that are incompatible with a streaming approach

- A new option to exclude files from transformation

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.2.0/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1299/

The tag is:
https://github.com/apache/tomcat-jakartaee-migration/tree/0.2.0
041e256e92078cd3b16a9adcd77faf257e3a5c88

The proposed 0.2.0 release is:

[ ] -1: Broken. Do not release because...
[ ] +1: Acceptable. Go ahead and release.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r46044 - in /dev/tomcat/jakartaee-migration/v0.2.0: ./ binaries/ source/

2021-02-11 Thread markt
Author: markt
Date: Thu Feb 11 17:46:27 2021
New Revision: 46044

Log:
Upload Tomcat Migration Tool for Jakarta EE 0.2.0 for voting

Added:
dev/tomcat/jakartaee-migration/v0.2.0/
dev/tomcat/jakartaee-migration/v0.2.0/binaries/

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz
   (with props)

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.asc

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.sha512

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip
   (with props)

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip.asc

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip.sha512

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-shaded.jar
   (with props)

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-shaded.jar.asc

dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-shaded.jar.sha512
dev/tomcat/jakartaee-migration/v0.2.0/source/

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.tar.gz
   (with props)

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.tar.gz.asc

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.tar.gz.sha512

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.zip  
 (with props)

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.zip.asc

dev/tomcat/jakartaee-migration/v0.2.0/source/jakartaee-migration-0.2.0-src.zip.sha512

Added: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz
==
Binary file - no diff available.

Propchange: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz
--
svn:mime-type = application/x-gzip

Added: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.asc
==
--- 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.asc
 (added)
+++ 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.asc
 Thu Feb 11 17:46:27 2021
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Comment: GPGTools - http://gpgtools.org
+
+iQIzBAABCgAdFiEEqcXfTSLpmZjZh1pREMAcWi9gWecFAmAlamwACgkQEMAcWi9g
+Wefacw/6AkX023iCnx7TPBCOYoB7SoPN/D3FuUKtfLIMGhhMOv85emHh6pPO6FOo
+W8NPezsfB/WwvXHT9Laokokx6x92/eQy4Db1VdFlsyp8zKTdRs8jo5ZPpPgoc5T4
+xDT5NnvV2Wyfe4bdEsg5VDUucQSI5ElzPKFqHEK6qj1oTISAtp1Z+DzvsL32/TyE
+ntCCRskaow4wykjGIUp5SztA+xG/PZpi2yfYdGRe73cjonRzoSlRoob72i5Uot18
+2tvoYKRM5fXSfaoHBbbPISG1g08Rma7s9G08dNhBp7wlzqqMPqy74jlkJN0rgpAR
+wgXxgC5+687A43gwewsUByProBPAaCi7bBl+h77w5Xa8zhzuYgs6VFvdpI2ED7Tz
+/oN8g8lonqNo/sLiLPssPipzijsgaXbB2v7MI8mYDe9qe7Fj4xTs4HuLuH84EvUV
+pnFstw8ApTjYuD/ShZSLiUaMIF99sdjUW7KkbFzT6hFMsnJGF8rZqgpqmMnMPh1y
+B41DNc7yFdACGrO7yXZan97QIjWcEGGaWqUeRNR1r8A0YAqdCRlGv7iBXVueDsYj
+SdZZjceYiJ0wumfvvsWMCNbOodZ/EdPB7NH9xJ26tWZs3MOUd1U2cURNy3KgbhK/
+z/lIW2fNhOY46qlfhy2fySSC87hENU9VYddmr1Q43bjURUuG8Yc=
+=xW0X
+-END PGP SIGNATURE-

Added: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.sha512
==
--- 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.sha512
 (added)
+++ 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.tar.gz.sha512
 Thu Feb 11 17:46:27 2021
@@ -0,0 +1 @@
+065faedbf3d6f9e0984b5ef95507e13d8e7b4ef76d2c9c430d1fb5e5b8b97e46758f10744d42354e5979d274c88449efb2374c02406bb127e166bb471303d9cb
 *jakartaee-migration-0.2.0-bin.tar.gz
\ No newline at end of file

Added: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip.asc
==
--- 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip.asc
 (added)
+++ 
dev/tomcat/jakartaee-migration/v0.2.0/binaries/jakartaee-migration-0.2.0-bin.zip.asc
 Thu Feb 11 17:46:27 2021
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Comment: GPGTools - http://gpgtools.org
+

[tomcat-jakartaee-migration] branch master updated: [maven-release-plugin] prepare for next development iteration

2021-02-11 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/master by this push:
 new da25e27  [maven-release-plugin] prepare for next development iteration
da25e27 is described below

commit da25e27f8f9e967d4c198cafd72f00c18ae4171d
Author: Mark Thomas 
AuthorDate: Thu Feb 11 17:34:08 2021 +

[maven-release-plugin] prepare for next development iteration
---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 2cc45ab..e791908 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,7 +27,7 @@
   org.apache.tomcat
   jakartaee-migration
   Apache Tomcat Migration Tool for Jakarta EE
-  0.2.0
+  0.2.1-SNAPSHOT
  
   
 This tool is a work in progress.
@@ -103,7 +103,7 @@
 
scm:git:https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
 
scm:git:https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
 
https://gitbox.apache.org/repos/asf?p=tomcat-jakartaee-migration.git
-0.2.0
+HEAD
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat-jakartaee-migration] annotated tag 0.2.0 created (now f5a17c4)

2021-02-11 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to annotated tag 0.2.0
in repository 
https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.


  at f5a17c4  (tag)
 tagging 041e256e92078cd3b16a9adcd77faf257e3a5c88 (commit)
 replaces 0.1.0
  by Mark Thomas
  on Thu Feb 11 17:34:02 2021 +

- Log -
[maven-release-plugin] copy for tag 0.2.0
---

No new revisions were added by this update.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat-jakartaee-migration] branch master updated: [maven-release-plugin] prepare release 0.2.0

2021-02-11 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/master by this push:
 new 041e256  [maven-release-plugin] prepare release 0.2.0
041e256 is described below

commit 041e256e92078cd3b16a9adcd77faf257e3a5c88
Author: Mark Thomas 
AuthorDate: Thu Feb 11 17:33:33 2021 +

[maven-release-plugin] prepare release 0.2.0
---
 pom.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pom.xml b/pom.xml
index 203e001..2cc45ab 100644
--- a/pom.xml
+++ b/pom.xml
@@ -27,7 +27,7 @@
   org.apache.tomcat
   jakartaee-migration
   Apache Tomcat Migration Tool for Jakarta EE
-  0.2.0-SNAPSHOT
+  0.2.0
  
   
 This tool is a work in progress.
@@ -103,7 +103,7 @@
 
scm:git:https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
 
scm:git:https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
 
https://gitbox.apache.org/repos/asf?p=tomcat-jakartaee-migration.git
-HEAD
+0.2.0
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65131] OpenSSLEngine errors on a connection affect other connections

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65131

--- Comment #3 from frraj...@cisco.com ---
I have reproduced the problem with tomcat version 9.0.43:


Feb 11, 2021 11:49:43 AM org.apache.catalina.core.AprLifecycleListener
lifecycleEvent
INFO: Loaded Apache Tomcat Native library [1.2.26] using APR version [1.4.8].
Feb 11, 2021 11:49:43 AM org.apache.catalina.core.AprLifecycleListener
lifecycleEvent
INFO: APR capabilities: IPv6 [true], sendfile [true], accept filters [false],
random [true].
Feb 11, 2021 11:49:43 AM org.apache.catalina.core.AprLifecycleListener
lifecycleEvent
INFO: APR/OpenSSL configuration: useAprConnector [false], useOpenSSL [true]
Feb 11, 2021 11:49:43 AM org.apache.catalina.core.AprLifecycleListener
initializeSSL
INFO: OpenSSL successfully initialized [OpenSSL 1.0.2u  20 Dec 2019]




Feb 11, 2021 12:05:01 PM org.apache.tomcat.util.net.openssl.OpenSSLEngine
checkLastError
FINE: OpenSSL error: [336462231] message: [error:140E0197:SSL
routines:SSL_shutdown:shutdown while in init]
Feb 11, 2021 12:05:01 PM org.apache.coyote.http11.Http11Processor service
FINE: Error parsing HTTP request header
javax.net.ssl.SSLException: error:140E0197:SSL routines:SSL_shutdown:shutdown
while in init
at
org.apache.tomcat.util.net.openssl.OpenSSLEngine.checkLastError(OpenSSLEngine.java:951)
at
org.apache.tomcat.util.net.openssl.OpenSSLEngine.pendingReadableBytesInSSL(OpenSSLEngine.java:636)
at
org.apache.tomcat.util.net.openssl.OpenSSLEngine.unwrap(OpenSSLEngine.java:558)
at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:629)
at
org.apache.tomcat.util.net.SecureNioChannel.read(SecureNioChannel.java:637)
at
org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.fillReadBuffer(NioEndpoint.java:1320)
at
org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.read(NioEndpoint.java:1232)
at
org.apache.coyote.http11.Http11InputBuffer.fill(Http11InputBuffer.java:791)
at
org.apache.coyote.http11.Http11InputBuffer.parseRequestLine(Http11InputBuffer.java:359)
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:261)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65)
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:887)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1684)
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at
com.broadsoft.xsp.platform.InstrumentedExecutor$Tracker.run(InstrumentedExecutor.java:413)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat-jakartaee-migration] branch master updated: Relocate dependencies in shaded JAR to avoid clashes when integrating

2021-02-11 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/master by this push:
 new 9df8b4a  Relocate dependencies in shaded JAR to avoid clashes when 
integrating
9df8b4a is described below

commit 9df8b4ab6cb4e4d747c88eeb4b64d96bbc6ec52f
Author: Mark Thomas 
AuthorDate: Thu Feb 11 17:06:40 2021 +

Relocate dependencies in shaded JAR to avoid clashes when integrating
---
 CHANGES.md |  1 +
 pom.xml| 10 ++
 2 files changed, 11 insertions(+)

diff --git a/CHANGES.md b/CHANGES.md
index baeffb2..928496d 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -26,6 +26,7 @@
 - Fix [#3](https://github.com/apache/tomcat-jakartaee-migration/issues/3). Add 
support for excluding files from conversion. (markt)
 - Fix handling of classes with more than 32768 entries in the constant pool. 
(markt)
 - Exclude `javax.xml.stream` and `javax.xml.XMLConstants` from the EE profile. 
(markt)
+- Relocate dependencies under the `org.apache.tomcat.jakartaee` package to 
avoid clashes when integrating the shaded jar. (markt)
 
 ## 0.1.0
 
diff --git a/pom.xml b/pom.xml
index c619b54..203e001 100644
--- a/pom.xml
+++ b/pom.xml
@@ -273,6 +273,16 @@
   
 
   
+  
+
+  org.apache.commons
+  
org.apache.tomcat.jakartaee.commons
+
+
+  org.apache.bcel
+  
org.apache.tomcat.jakartaee.bcel
+
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65137] Invalid chunk encoding in the tomcat answer

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65137

barm...@adobe.com changed:

   What|Removed |Added

Version|8.5.x-trunk |8.5.63

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65137] New: Invalid chunk encoding in the tomcat answer

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65137

Bug ID: 65137
   Summary: Invalid chunk encoding in the tomcat answer
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: barm...@adobe.com
  Target Milestone: 

Hi,

When tomcat is sending a huge answer (which is thus chunk encoded), the answer
may become invalid at some point if the client reads this answer slowly.

STR:
- create a small jsp that output a lot of data:
<%
StringBuilder s = new StringBuilder();
for( int i = 0; i < 630; i++ )
//for( int i = 0; i < 630; i++ )
{
  s.append("line ");
  s.append(i);
  s.append("\n");
}
out.println(s.toString());
%>
- start tomcat (default config)
- get the answer with a limited bandwith (no issue otherwise): curl
--limit-rate 70k http://localhost:8080/test.jsp -o /dev/null
- after some time (around 2-3min), an error is raised by curl:
curl: (56) Malformed encoding found in chunked-encoding

Regarding the network capture for this issue, it seems that tomcat restart the
sending of a chunk while the same chunk was being sent (and was nearly
finished). The next chunk seems to be sent correctly (but the answer is no
longer valid at this point).

I can reproduce on Tomcat 9 too (but not on tomcat 7). I can reproduce on
debian 10 (with the default openjdk 11) and debian 9 (with the default openjdk
8).

Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat-jakartaee-migration] branch master updated: Add ClassFileTransformer hook

2021-02-11 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git


The following commit(s) were added to refs/heads/master by this push:
 new a6b2607  Add ClassFileTransformer hook
a6b2607 is described below

commit a6b260792435f458b1b90d1bc70bb5c0ac266e0f
Author: remm 
AuthorDate: Thu Feb 11 17:00:48 2021 +0100

Add ClassFileTransformer hook

For possible experimentations inside the WebappClassLoader.
---
 .../apache/tomcat/jakartaee/ClassConverter.java| 23 +-
 1 file changed, 22 insertions(+), 1 deletion(-)

diff --git a/src/main/java/org/apache/tomcat/jakartaee/ClassConverter.java 
b/src/main/java/org/apache/tomcat/jakartaee/ClassConverter.java
index 1b15652..0173f71 100644
--- a/src/main/java/org/apache/tomcat/jakartaee/ClassConverter.java
+++ b/src/main/java/org/apache/tomcat/jakartaee/ClassConverter.java
@@ -16,9 +16,14 @@
  */
 package org.apache.tomcat.jakartaee;
 
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
+import java.lang.instrument.ClassFileTransformer;
+import java.lang.instrument.IllegalClassFormatException;
+import java.security.ProtectionDomain;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 
@@ -27,7 +32,7 @@ import org.apache.bcel.classfile.Constant;
 import org.apache.bcel.classfile.ConstantUtf8;
 import org.apache.bcel.classfile.JavaClass;
 
-public class ClassConverter implements Converter {
+public class ClassConverter implements Converter, ClassFileTransformer {
 
 private static final Logger logger = 
Logger.getLogger(ClassConverter.class.getCanonicalName());
 private static final StringManager sm = 
StringManager.getManager(ClassConverter.class);
@@ -74,4 +79,20 @@ public class ClassConverter implements Converter {
 
 javaClass.dump(dest);
 }
+
+
+@Override
+public byte[] transform(ClassLoader loader, String className,
+Class classBeingRedefined, ProtectionDomain protectionDomain,
+byte[] classfileBuffer) throws IllegalClassFormatException {
+ByteArrayInputStream inputStream = new 
ByteArrayInputStream(classfileBuffer);
+ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
+try {
+convert(className, inputStream, outputStream, 
EESpecProfile.TOMCAT);
+} catch (IOException e) {
+throw new IllegalClassFormatException(e.getLocalizedMessage());
+}
+return outputStream.toByteArray();
+}
+
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-11 Thread Rémy Maucherat
On Thu, Feb 11, 2021 at 3:47 PM Mark Thomas  wrote:

> On 11/02/2021 14:39, Rémy Maucherat wrote:
> > On Thu, Feb 11, 2021 at 12:08 PM Mark Thomas  wrote:
> >
> >> On 10/02/2021 17:27, Raymond Auge wrote:
> >>> missing requirement
> >>> [org.apache.servicemix.bundles.spring-beans [6](R 6.0)]
> >>> osgi.wiring.package; (osgi.wiring.package=jakarta.inject)]
> >>>
> >>> Is the jakarta.inject package exported by someone (in the framework)?
> >>>
> >>> I'm not sure how JIRA sets up it's OSGi runtime.
> >>
> >> Thanks. That was one of my working theories. It is helpful to have it
> >> confirmed.
> >>
> >> I have spent some more time on this today without success. As far as I
> >> can tell, I have converted every reference to javax.inject to jakarta
> >> .inject but I am obviously missing something but I can't figure out
> >> what. I think I am going to leave this for now.
> >>
> >> I'll start on the 0.2.0 release shortly and then plan to think some more
> >> about integration of this tool with Tomcat 10.
> >>
> >
> > +1 for the release.
> > If we're talking about its integration, I can help and/or do it.
>
> Thanks for the offer. I have the deployment approach about 95% complete
> ;). Maybe look at the runtime approach so we can compare?
>

I don't think the runtime option is a good plan for static resources. It
would be "ok" for classes which would avoid the JAR repackaging troubles,
however.

I'll add the ClassFileTransformer hook to ClassConverter before your
release, for experimentation with our WebappClassLoader. This won't convert
classloader resources though (URLClassLoader.getResourceAsStream).

Rémy


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-11 Thread Mark Thomas
On 11/02/2021 14:39, Rémy Maucherat wrote:
> On Thu, Feb 11, 2021 at 12:08 PM Mark Thomas  wrote:
> 
>> On 10/02/2021 17:27, Raymond Auge wrote:
>>> missing requirement
>>> [org.apache.servicemix.bundles.spring-beans [6](R 6.0)]
>>> osgi.wiring.package; (osgi.wiring.package=jakarta.inject)]
>>>
>>> Is the jakarta.inject package exported by someone (in the framework)?
>>>
>>> I'm not sure how JIRA sets up it's OSGi runtime.
>>
>> Thanks. That was one of my working theories. It is helpful to have it
>> confirmed.
>>
>> I have spent some more time on this today without success. As far as I
>> can tell, I have converted every reference to javax.inject to jakarta
>> .inject but I am obviously missing something but I can't figure out
>> what. I think I am going to leave this for now.
>>
>> I'll start on the 0.2.0 release shortly and then plan to think some more
>> about integration of this tool with Tomcat 10.
>>
> 
> +1 for the release.
> If we're talking about its integration, I can help and/or do it.

Thanks for the offer. I have the deployment approach about 95% complete
;). Maybe look at the runtime approach so we can compare?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-11 Thread Rémy Maucherat
On Thu, Feb 11, 2021 at 12:08 PM Mark Thomas  wrote:

> On 10/02/2021 17:27, Raymond Auge wrote:
> > missing requirement
> > [org.apache.servicemix.bundles.spring-beans [6](R 6.0)]
> > osgi.wiring.package; (osgi.wiring.package=jakarta.inject)]
> >
> > Is the jakarta.inject package exported by someone (in the framework)?
> >
> > I'm not sure how JIRA sets up it's OSGi runtime.
>
> Thanks. That was one of my working theories. It is helpful to have it
> confirmed.
>
> I have spent some more time on this today without success. As far as I
> can tell, I have converted every reference to javax.inject to jakarta
> .inject but I am obviously missing something but I can't figure out
> what. I think I am going to leave this for now.
>
> I'll start on the 0.2.0 release shortly and then plan to think some more
> about integration of this tool with Tomcat 10.
>

+1 for the release.
If we're talking about its integration, I can help and/or do it.

Rémy


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 65136] Parallel deploy speedup with /manager/text servlet not possible because of synchronized method ManagerServlet.deploy()

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65136

--- Comment #4 from Remy Maucherat  ---
The improvement will be in Tomcat 10.0.3, 9.0.44 and 8.5.64.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65136] Parallel deploy speedup with /manager/text servlet not possible because of synchronized method ManagerServlet.deploy()

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65136

--- Comment #3 from Manuel Dominguez Sarmiento  ---
Thanks Remy, I now see that Mark has been already working on this and committed
7 patches to resolve this issue. I see that these commits were made right after
the release of 9.0.43 (Feb. 1st while 9.0.43 was release on Jan. 28th)

I assume these fixes will be available on 9.0.44 right? I'm unsure whether they
were just applies to the 10.x or backported to the 9.x branch as well.

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65136] Parallel deploy speedup with /manager/text servlet not possible because of synchronized method ManagerServlet.deploy()

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65136

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
   Severity|normal  |enhancement

--- Comment #2 from Remy Maucherat  ---
https://github.com/apache/tomcat/commit/ee6069392752f930c64e160a6a08a9904ffea008

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65136] Parallel deploy speedup with /manager/text servlet not possible because of synchronized method ManagerServlet.deploy()

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65136

--- Comment #1 from Manuel Dominguez Sarmiento  ---
Comments from Mark Thomas on the Tomcat User List dated January 7th 2021:

"Some svn archaeology uncovered this commit comment:

"Known issue: locking occurs on an uploaded WAR, for reasons which
  elude me right now."

The method level sync looks like an attempt to ensure that there aren't
parallel attempts to deploy a web application to the same path. I can't
think of any other reason. But locking on, essentially, the virtual
host, seems overly broad. A lock on the deployment path would be sufficient.

There are also calls to isServiced(), addServiced() and removeServiced()
which look to be trying to do the same thing which have their own issues
(not atomic, uses a List rather than a Set).

We do need to ensure that we don't get parallel attempts to service the
same web application. There is scope for all sorts of bad things to
happen if that is possible.

Overall, I think this can be fixed but it looks like some API changes
are going to be required which makes things a little more complicated.

It would be worth you opening a Bugzilla issue for this to make sure it
doesn't get forgotten about. The issues with the unsynchronized
deployment methods are sufficient - in my view - to class this as a bug
rather than an enhancement.

Mark"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65136] New: Parallel deploy speedup with /manager/text servlet not possible because of synchronized method ManagerServlet.deploy()

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65136

Bug ID: 65136
   Summary: Parallel deploy speedup with /manager/text servlet not
possible because of synchronized method
ManagerServlet.deploy()
   Product: Tomcat 9
   Version: 9.0.x
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Manager
  Assignee: dev@tomcat.apache.org
  Reporter: m...@renxo.com
  Target Milestone: -

Hi, our system consists on about 80+ webapps on different servers.
Multiple webapps are deployed per Tomcat server remotely using the
manager and host-manager webapps.

This has been working fine for years, however some servers now have 5+
webapps and they are taking a long time to start. We invoke the deploy
command on the manager webapp in parallel for each webapp, in order to
attempt a reduction in total server startup time. However the speedup is
very modest. The servers have powerful Xeon multi-core servers so a
parallel speedup should be possible.

Looking at the source code for
org.apache.catalina.manager.ManagerServlet we see that the following
method is synchronized which would explain the behaviour we are seeing:
protected synchronized void deploy
(PrintWriter writer, String config, ContextName cn,
 String tag, boolean update, HttpServletRequest request,
 StringManager smClient) {

Is there any real reason why this needs to be synchronized? Tomcat can
deploy webapps in parallel when backgroundProcessorDelay is set to a
positive number, but this is not useful when remotely deploying webapps
using the manager webapp.

Any ideas? Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat-jakartaee-migration] branch master updated: Fix bug. Constant pool size is defined as u2

2021-02-11 Thread Mark Thomas
On 10/02/2021 17:27, Raymond Auge wrote:
> missing requirement
> [org.apache.servicemix.bundles.spring-beans [6](R 6.0)]
> osgi.wiring.package; (osgi.wiring.package=jakarta.inject)]
> 
> Is the jakarta.inject package exported by someone (in the framework)?
> 
> I'm not sure how JIRA sets up it's OSGi runtime.

Thanks. That was one of my working theories. It is helpful to have it
confirmed.

I have spent some more time on this today without success. As far as I
can tell, I have converted every reference to javax.inject to jakarta
.inject but I am obviously missing something but I can't figure out
what. I think I am going to leave this for now.

I'll start on the 0.2.0 release shortly and then plan to think some more
about integration of this tool with Tomcat 10.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Remove useless private static method

2021-02-11 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new dbbcb66  Remove useless private static method
dbbcb66 is described below

commit dbbcb662750159f798f5a64766bb2daf432f536c
Author: remm 
AuthorDate: Thu Feb 11 11:19:13 2021 +0100

Remove useless private static method
---
 java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java 
b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
index cdd0617..27dbb80 100644
--- a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
+++ b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
@@ -251,7 +251,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 src.limit(pos + len);
 
@@ -291,7 +291,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 buf.put(src);
 
@@ -330,7 +330,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 final int len = Math.min(MAX_ENCRYPTED_PACKET_LENGTH, limit - pos);
 final ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int sslRead = SSL.readFromSSL(ssl, addr, len);
 if (sslRead > 0) {
@@ -364,7 +364,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 final ByteBuffer buf = ByteBuffer.allocateDirect(pending);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int bioRead = SSL.readFromBIO(networkBIO, addr, pending);
 if (bioRead > 0) {
@@ -966,11 +966,6 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 SSL.getLastErrorNumber();
 }
 
-
-private static long memoryAddress(ByteBuffer buf) {
-return Buffer.address(buf);
-}
-
 private SSLEngineResult.Status getEngineStatus() {
 return engineClosed ? SSLEngineResult.Status.CLOSED : 
SSLEngineResult.Status.OK;
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Remove useless private static method

2021-02-11 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new f735eb8  Remove useless private static method
f735eb8 is described below

commit f735eb896936ceca15a12a9b291259d0bb0d5246
Author: remm 
AuthorDate: Thu Feb 11 11:19:13 2021 +0100

Remove useless private static method
---
 java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java 
b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
index cdd0617..27dbb80 100644
--- a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
+++ b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
@@ -251,7 +251,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 src.limit(pos + len);
 
@@ -291,7 +291,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 buf.put(src);
 
@@ -330,7 +330,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 final int len = Math.min(MAX_ENCRYPTED_PACKET_LENGTH, limit - pos);
 final ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int sslRead = SSL.readFromSSL(ssl, addr, len);
 if (sslRead > 0) {
@@ -364,7 +364,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 final ByteBuffer buf = ByteBuffer.allocateDirect(pending);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int bioRead = SSL.readFromBIO(networkBIO, addr, pending);
 if (bioRead > 0) {
@@ -966,11 +966,6 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 SSL.getLastErrorNumber();
 }
 
-
-private static long memoryAddress(ByteBuffer buf) {
-return Buffer.address(buf);
-}
-
 private SSLEngineResult.Status getEngineStatus() {
 return engineClosed ? SSLEngineResult.Status.CLOSED : 
SSLEngineResult.Status.OK;
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Remove useless private static method

2021-02-11 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new d5e342d  Remove useless private static method
d5e342d is described below

commit d5e342d056b04ffba8ab5ad4e1dd63ffa50956de
Author: remm 
AuthorDate: Thu Feb 11 11:19:13 2021 +0100

Remove useless private static method
---
 java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java | 13 -
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java 
b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
index cdd0617..27dbb80 100644
--- a/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
+++ b/java/org/apache/tomcat/util/net/openssl/OpenSSLEngine.java
@@ -251,7 +251,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 src.limit(pos + len);
 
@@ -291,7 +291,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 buf.put(src);
 
@@ -330,7 +330,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 final int len = Math.min(MAX_ENCRYPTED_PACKET_LENGTH, limit - pos);
 final ByteBuffer buf = ByteBuffer.allocateDirect(len);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int sslRead = SSL.readFromSSL(ssl, addr, len);
 if (sslRead > 0) {
@@ -364,7 +364,7 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 } else {
 final ByteBuffer buf = ByteBuffer.allocateDirect(pending);
 try {
-final long addr = memoryAddress(buf);
+final long addr = Buffer.address(buf);
 
 final int bioRead = SSL.readFromBIO(networkBIO, addr, pending);
 if (bioRead > 0) {
@@ -966,11 +966,6 @@ public final class OpenSSLEngine extends SSLEngine 
implements SSLUtil.ProtocolIn
 SSL.getLastErrorNumber();
 }
 
-
-private static long memoryAddress(ByteBuffer buf) {
-return Buffer.address(buf);
-}
-
 private SSLEngineResult.Status getEngineStatus() {
 return engineClosed ? SSLEngineResult.Status.CLOSED : 
SSLEngineResult.Status.OK;
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 65131] OpenSSLEngine errors on a connection affect other connections

2021-02-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65131

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #2 from Remy Maucherat  ---
I cannot reproduce the issue, please test with the most recent 9.0 release.

Since this better matches the OpenSSL documentation, I am ok conceptually to
modify clearLastError to do:
while (SSL.getLastErrorNumber() != SSL.SSL_ERROR_NONE);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org