Re: Punishing bad clients with delays

[Igal @ Lucee.org]

Chris,

On 5/14/2019 12:15 PM, Christopher Schultz wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

All,

bump

It's hard to see anything with all the commit messages :)

On 5/9/19 12:52, Christopher Schultz wrote:

All,

What are the options we might have to "punish" an HTTP client that
we don't like for some reason?

Specifically, I'd like to be able to write a servlet that ties-up
the response to the client for a while for some bad behavior. For
example, maybe lots of authentication attempts or some other
criteria. Maybe even just a single bad authentication attempt.


How do you identify the bad actor on subsequent requests?  By its IP 
address?



I'm thinking of something along these lines:

public void doGet(...) {

...

if(shouldPunishClient(...)) { request.setAttribute("delay-client",
Boolean.TRUE); return; }

... }

Or maybe even specify a time-out.

Then, Tomcat observes that the servlet or filter wants to put the
response into the penalty box and, instead of flushing the
response and (possibly) closing the connection, it just sits-around
for a while, keeping the connection open.


Wouldn't that punish Tomcat by keeping the connection open?  Open the 
door for DDoS attacks?


I would think that a better way to do it is to flush and close the 
request immediately, and then block the IP address for X seconds.



The poller usually waits for data to become available on either end
of the connection and pushes the bytes. How complicated would it be
to put connections into a queue where they wait some amount of
time before being flushed/closed/returned to the connection pool?
In this case, the only stimulus for taking action is the passage of
time, not arrival of data on a stream.

Any thoughts about how this could be done?


You mean as part of the NIO implementation?


Clearly, a simple Thread.sleep() would do the trick in terms of
just making the client wait, but the point would be to make the
client wait without a performance impact on the server.


If you really want to punish a client then send back a "302 
http://aol.com; ;-)


Best,

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat Site Redesign

[Igal @ Lucee.org]

All,

On 3/7/2019 3:22 AM, Konstantin Kolinko wrote:


пн, 4 мар. 2019 г. в 09:02, Igal Sapir :

I have uploaded the Tomcat site redesign to a temporary location for review:
http://people.apache.org/~isapir/mockups/tomcat-site/

1. Overall: Thank you for your effort, but I do not like it. At all.


The effort to redesign the website was prompted by conversations with 
team members at TomcatCon in Montreal.


If there is consensus in the team for keeping the layout with a vertical 
menu on the left then I can redesign that.


Best,

Igal






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [ANN] New committer: Igal Sapir

[Igal @ Lucee.org]

On 5/25/2018 3:38 AM, Felix Schumacher wrote:
> Congrats,
>  Felix
>
> Am 24. Mai 2018 21:09:06 MESZ schrieb Mark Thomas :
>> On behalf of the Tomcat committers I am pleased to announce that
>> Igal Sapir (isapir) has been voted in as a new Tomcat committer.

Thank you all!

It is an honor to be part of the Tomcat team.  I look forward to 
contributing to the project.


Best,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Violeta,

On 1/26/2018 9:57 AM, Violeta Georgieva wrote:

I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
Regards,
Violeta

- MacOS High Sierra
-
https://github.com/violetagg/tomcat-website-screenshots/tree/master/r1822283
- no cache
- the version is provided with every screenshot


This patch should fix the issue on MacOS:
https://github.com/isapir/tomcat-site/commit/286454b

Also, can anyone confirm if they can still see the menu in Print? And if 
so, on what platform/browser?  I can not reproduce that.


Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/26/2018 5:16 AM, Violeta Georgieva wrote:

2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :

It looks OK now, after I regenerated the docs - r1822283 .
Right.  I do not patch the generated files, only the source ones, so 
docs must be regenerated after each patch.



I still see odd "OK" button on Chrome and Safari, only Firefox is ok.
Regards,
Violeta
What OS are you running?  Can you please provide the full versions of 
the browsers?  Also, please ensure that

https://tomcat.apache.org/res/css/tomcat.css is not cached.


2018-01-26 14:40 GMT+02:00 Konstantin Kolinko :

Print view is yet to be fixed.
I provided the patch for the more urgent things since the site is live, 
so I did not cover everything in that patch.


The Print looked fine on Chrome ( see previous printout at 
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf 
), but I checked now on Firefox and I see what you mean.  Not sure why 
that happens but I'll fix it.


Best,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/25/2018 1:04 PM, Konstantin Kolinko wrote:

2018-01-25 20:06 GMT+03:00 Igal @ Lucee.org <i...@lucee.org>:

Thank you for sharing your screenshots.  I am not sure why that happened but
I will fix it.

The first thing that comes to mind is a cached CSS file, so I will rename
the file to make sure that that's not a factor.  It's a bit challenging that
I can't reproduce it on my system, but I will check on my Fedora laptop too.

That Firefox is run with a separate profile that I use for testing -
it has caching disabled.

Comparing eu/us mirrors, both are the same,
http://tomcat.eu.apache.org/
http://tomcat.us.apache.org/

What happens when you zoom out?

Looking for active css rules on the input element,

.searchbox input[type="search"], .searchbox button {
 height: 25px;
}

Why a "type" selector is here? Can it be more simple?
It can be just #query, as this input has an id.
Styling by ID instead of a class has other implications, primarily 
specificity [1], which makes projects styling harder to maintain.  I am 
unaware of any browser that has issue with that selector.  If there is 
then I can modify it.



Why the height is in pixels, not in font units?

There is a css rule for height (quoted above),  but there is no rule
for width of this input field.
(When size attribute not specified it should default to size="20", and
width depends on the actual font).
The width here came from the parent container.  I was unaware of any 
issues as all 4 browsers (Chrome, Firefox, Edge, IE11) that I tested on 
rendered it correctly in my testing.


I will fix the known issues and submit a new patch.

Thank you,


Igal

[1] https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

On 1/25/2018 1:48 AM, Violeta Georgieva wrote:

2018-01-24 21:05 GMT+02:00 Igal @ Lucee.org <i...@lucee.org>:

Perhaps a better phrasing would be:

"Note, that Tomcat Documentation is provided on this site and is searchable (see 
links and search box at the left)."
Given that I can not make the change myself and the git patches take an extra 
step, it would be easier for any committer to update it without a patch from me 
at this point.

I did that + added info for all Tomcat version that we support.

Regards,
Violeta


Awesome, thanks!


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Violeta, Konstantin,

On 1/25/2018 3:57 AM, Konstantin Kolinko wrote:

2018-01-25 10:00 GMT+03:00 Violeta Georgieva :

Here is what I see with Chrome, Firefox and Safari
https://github.com/violetagg/tomcat-website-screenshots

Regards,
Violeta

Here are mine screenshots:
https://github.com/kkolinko/tomcat_screenshots_2018


Thank you for sharing your screenshots.  I am not sure why that happened 
but I will fix it.


The first thing that comes to mind is a cached CSS file, so I will 
rename the file to make sure that that's not a factor.  It's a bit 
challenging that I can't reproduce it on my system, but I will check on 
my Fedora laptop too.


Best,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Konstantin,

I'd be happy to make all the necessary corections.

On 1/24/2018 2:44 AM, Konstantin Kolinko wrote:

1. The "print view" of the page is important. One should be able to
print it. Especially the documentation.

I think that menu and search box were not visible when printing, but
one has to check.
IIRC the menu and search box were not visible when printing earlier 
either.  The print view is very similar to the way it.  Is there any 
important information that is missing?  See my print out at 
https://github.com/isapir/tomcat-site/releases/download/0.1/Apache.Tomcat.-.Welcome.pdf



2. The "GO" button on the search box looks off, misaligned.

What browser are you using?  See screenshots at
https://user-images.githubusercontent.com/885907/35351078-b1cece0e-00f4-11e8-9d4d-6305d7ef4545.png
https://user-images.githubusercontent.com/885907/35351182-fd2f6048-00f4-11e8-8b73-1a005145a85a.png


3. We would have to update some documentation.

http://tomcat.apache.org/lists.html#tomcat-users
"2. Note, that Tomcat Documentation is provided on this site (see the
links at the left) and is searchable (see an input box above)."

Perhaps a better phrasing would be:

"Note, that Tomcat Documentation is provided on this site and is 
searchable (see links and search box at the left)."


Given that I can not make the change myself and the git patches take an 
extra step, it would be easier for any committer to update it without a 
patch from me at this point.



4. Accessibility. Is it possible to operate the site without having a mouse?

If menu is closed, I cannot access the hamburger button with keyboard
(e.g. pressing tab), cannot open it.  And the text on the main page
does not provide other ways to access those parts of the site.

Sure, I will work on that.

Best,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website for tomcat.apache.org

[Igal @ Lucee.org]

Mark,

On 1/24/2018 1:43 AM, Mark Thomas wrote:

Looks great. Patch applied many thanks.

Thank you.  I appreciate the feedback.


I don't suppose you are interested in making similar changes to the
documentation web applications (the content gets copied to the web-site)
and/or updating the Tomcat 7 docs to match the style of the others?

I'm happy to contribute to the Tomcat project in any way that I can.

To clarify, you are referring to these sites, right?
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/
http://svn.apache.org/repos/asf/tomcat/tc***.x/trunk/webapps/docs/

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Responsive Website

[Igal @ Lucee.org]

On 12/23/2017 1:22 PM, Mark Thomas wrote:

On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <i...@lucee.org> 
wrote:

Actually I have a question already.  I see the site's SVN at
http://svn.apache.org/repos/asf/tomcat/site/trunk/

Is there a git mirror for it or should I grab the sources from SVN?

Just svn. That part of the repo isn't mirror to git.


According to 
http://svn.apache.org/repos/asf/tomcat/site/trunk/README.txt I need 
"jk-xdocs native-xdocs", but these directories are empty.  Can I remove 
them in my patches?  I want to clean up some stuff as I go through it.


I will also update the README.txt accordingly.


Igal


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website

[Igal @ Lucee.org]

On 12/23/2017 1:22 PM, Mark Thomas wrote:

On 23 December 2017 18:39:33 GMT+00:00, "Igal @ Lucee.org" <i...@lucee.org> 
wrote:

I see the site's SVN at
http://svn.apache.org/repos/asf/tomcat/site/trunk/

Is there a git mirror for it or should I grab the sources from SVN?

Just svn. That part of the repo isn't mirror to git.


Got it, thanks.


Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>

Re: Responsive Website

[Igal @ Lucee.org]

On 12/23/2017 4:36 AM, Mark Thomas wrote:

Ping the list if you have any questions.


Actually I have a question already.  I see the site's SVN at 
http://svn.apache.org/repos/asf/tomcat/site/trunk/


Is there a git mirror for it or should I grab the sources from SVN?


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website

[Igal @ Lucee.org]

On 12/23/2017 4:36 AM, Mark Thomas wrote:

Ping the list if you have any questions.


Awesome.  I'll start working on that then.


Igal


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Responsive Website

[Igal @ Lucee.org]

Chris,

On 12/19/2017 11:21 AM, Christopher Schultz wrote:

Smaller patches/PRs are more likely to be applied than huge ones.
Maybe start with a few small but useful patches to get things going?

Remember that the website is built using XSLT so don't edit the HTML
files directly, but rather have a look at the .xsl files and perhaps
the XML files if you need to modify the content directly.


While I understand the logic here, I'm not sure that it's feasible to do 
it in chunks, because the changes need to be made "atomically" so to speak.


Most of the changes will be in the CSS stylesheet, with some minor 
changes in the HTML.


I realize that it is built from XML files.


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Stuck at BUILDING.txt - (3) Building Tomcat @VERSION_MAJOR_MINOR@

[Igal @ Lucee.org]

On 10/16/2017 2:47 AM, Mark Thomas wrote:

On 15/10/17 20:09, Igal @ Lucee.org wrote:

On 10/15/2017 12:06 PM, Kapil Kumar wrote:

Does that mean I could skip this part!

If you didn't make any changes that can break Tomcat then you can skip
that part, yes.

It can be hard to judge when it is a good idea to run tests and/or which
tests to run - especially for someone new to the code base.


True.  I was basing this on the assumption that the OP has not made any 
changes at all,
which he later confirmed.  I should have kept my statement as "If you 
didn't make any changes.".





It is worth ensuring you run the validate target after any changes as
that will pick up a lot of the trivial formatting issues that can make
patches more work to integrate. Also, don't forget to update the
documentation if necessary and to add an entry to the changelog.


I actually realized yesterday that even changes to the documentation can 
break the build,

when I forgot to close a `` which caused the XML to be malformed.

Best,

Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>

Re: Stuck at BUILDING.txt - (3) Building Tomcat @VERSION_MAJOR_MINOR@

[Igal @ Lucee.org]

On 10/15/2017 12:06 PM, Kapil Kumar wrote:

Thanks, got you. Plain text emails only.

Does that mean I could skip this part!


If you didn't make any changes that can break Tomcat then you can skip 
that part, yes.


If you made changes that might have broken something, then this part 
will test many known issues and alert you if something was "broken", 
i.e. not working as expected due to your changes.


Regards,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: [ANN] Apache Tomcat 9.0.1 available

[Igal @ Lucee.org]

On 10/3/2017 3:55 AM, Mark Thomas wrote:

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 9.0.1 (beta).
Shouldn't version 9.0.1 be marked as "beta" on 
https://tomcat.apache.org/download-90.cgi ?  I would expect it to look 
like the Maven versioning, i.e. 9.0.1-BETA.


The download page gives the impression that this is a stable version.

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: [Bug 61615] Haked mr.B45T4RD

[Igal @ Lucee.org]

Can anyone ban this idiot from BZ/mailing-lists/etc.?

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Development Tasks

[Igal @ Lucee.org]

Hi Coty,

On 10/2/2017 9:13 AM, Coty Sutherland wrote:

Have you taken a look at the CONTRIBUTING guide in the repo?
https://github.com/apache/tomcat/blob/trunk/CONTRIBUTING.md If it's
insufficient, let us know and we can update it. Right now it only
suggests looking at Beginner bugs, so we definitely need to expand
that (there are only three bugs currently flagged as Beginner). I'll
keep an eye out for other suggestions and add them as we go along
since there seems to be a few requests for getting started material
open at the moment.


I have looked at it an managed to contribute a little in the past.

I was unaware of the new link to the Beginner issues fitler though, so 
that's a good addition.  I will look into the ones that are currently 
labeled as such.


It'd be great if some more issues will be marked as 
Beginner/Intermediate though as many of us want to contribute.


Best,


Igal Sapir

Lucee Core Developer
Lucee.org 

Development Tasks (was: Need mentor)

[Igal @ Lucee.org]

Hi Mark (et al.),

On 10/2/2017 3:46 AM, Mark Thomas wrote:

Once you built a local Tomcat instance and confirmed it is working, we
can point you towards some development tasks to get you started.


I would also like to be pointed at some development tasks if possible.

Thank you,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: [GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

[Igal @ Lucee.org]

To the administrator of these automated emails,

On 9/22/2017 9:54 PM, Bill Barker wrote:

To whom it may engage...
 
This is an automated request, but not an unsolicited one. For

more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.


I don't mind these automated emails since I willingly and consciously 
subscribed to this mailing list, but can you please update the time on 
your machine?


The time of these emails is set to several hours in the future and so 
these emails are always at the top when sorted by "most recent first", 
making me (and others, I'm sure) miss newer emails because it looks like 
these are the latest ones.


Thank you,


Igal Sapir




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Security warning (minor) on Tomcat site when using HTTPS

[Igal @ Lucee.org]

On 8/3/2017 10:29 AM, Christopher Schultz wrote:

I'd like to fix this issue, and there are two possible approaches:

1. Always use HTTPS: just change the link protocol to https://
Always use HTTPS seems like the right way to me.  What's the downside?  
Latency on the first request?


TBH, best practice is to make all requests to http://tomcat.apache.org/ 
to redirect to https://tomcat.apache.org/ so if you do that you do not 
have to worry about protocol-relative URLs because they will always be 
https.  My $0.02.


Igal Sapir
Lucee Core Developer
Lucee.org 

Semantic Versioning

[Igal @ Lucee.org]

Hi everyone,

I have recently realized that Tomcat does not follow Semantic 
Versioning, and even minor upgrades can break existing setups.


Most users today expect Semantic Versioning, which specifies the 
following (from [1]):


Given a version number MAJOR.MINOR.PATCH, increment the:

1. MAJOR version when you make incompatible API changes,
2. MINOR version when you add functionality in a backwards-compatible
   manner, and
3. PATCH version when you make backwards-compatible bug fixes.

Additional labels for pre-release and build metadata are available as 
extensions to the MAJOR.MINOR.PATCH format.


I think that it's important to adopt such a policy, so that minor 
updates are easier to do, e.g. updating only the /lib directory without 
worrying about the /bin or other directories.


[1] http://semver.org/

Thank you,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: RFE idea: Add port offset system property to Tomcat

[Igal @ Lucee.org]

Hi,

On 6/9/2017 9:47 AM, Mark Thomas wrote:

On 09/06/2017 17:34, Romain Manni-Bucau wrote:

@Mark: guess you are thinking to server.xml?

Yes.


then it would have placeholder
support so still a system property somehow no?

It would have placeholder support (as do all attributes in server.xml)
so yes, system properties could be used - with a small edit to
server.xml. It would have to be on Server.


If you open a ticket and think that it's appropriate, please tag it as 
"Beginner".


Thanks,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: package trailers does not exist

[Igal @ Lucee.org]

On 6/9/2017 1:46 AM, Mark Thomas wrote:

On 08/06/17 22:59, Igal @ Lucee.org wrote:

When I set the `test` directory as a Test root dir in IntelliJ IDEA, I
get errors like:

E:\Workspace\git\tomcat\test\org\apache\coyote\http2\TestStream.java
Error:(33, 16) java: package trailers does not exist

Can anyone tell me where `trailers` is coming from?

The examples web application.


Thanks, Mark!

I added webapps/examples/WEB-INF/classes as a "Test Sources Root" and 
now it works.



Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

package trailers does not exist

[Igal @ Lucee.org]

When I set the `test` directory as a Test root dir in IntelliJ IDEA, I 
get errors like:


E:\Workspace\git\tomcat\test\org\apache\coyote\http2\TestStream.java
Error:(33, 16) java: package trailers does not exist
Error:(90, 49) java: cannot find symbol
  symbol:   class ResponseTrailers
  location: class org.apache.coyote.http2.TestStream

https://github.com/apache/tomcat/blob/trunk/test/org/apache/coyote/http2/TestStream.java#L33

Can anyone tell me where `trailers` is coming from?

Thanks,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Manager applications and the Security Manager

[Igal @ Lucee.org]

Coty,

On 6/2/2017 11:15 AM, Coty Sutherland wrote:

If you guys think this is a bug I can file a BZ and fix it :D Or, mark
it as "Beginner" since it's trivial.


If it's trivial then please mark it as a Beginner if you open a ticket.  
It will give new contributors like myself a chance to get better 
acquainted with the Tomcat code base, and allow you to take care of 
things that require more experience.


Best,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Things that we can do to increase contributor involvement?

[Igal @ Lucee.org]

Chris,

On 6/1/2017 11:16 AM, Christopher Schultz wrote:

Just remember that everyone here is a volunteer, and it takes much
longer to review/test a patch/PR than it does to e.g. reply to a message
on a mailing list. We all have our primary jobs and our families and
both of those take priority over volunteering for the ASF and its
communities.


I'm not sure if you read my first email in this thread (reading emails 
is also very time consuming, I know), but I made it very clear there 
that I am aware of these factors and that I set my expectations 
accordingly.  I wouldn't have even mentioned my PR at this point if it 
weren't for Coty's email which started this thread.


I believe that my perspective represents most new contributors, and not 
only my own personal views, and that's the reason I posted it.



We always say "patches are always welcome" but, you're right, if the
patches sit unreviewed for a long time, it's tough to feel like your
contributions are valued.


I have been contributing to various open source projects for the better 
part of a decade now.  Unfortunately, in the beginning, I had submitted 
large PRs a few times, that contained a lot of work.  That work was not 
reviewed in a timely manner, and at some point the code base has changed 
so much that it was un-mergeable anymore, leading to loss of time and 
effort.


I have learned since to submit smaller and cleaner patches, so that they 
are easier to review.  But still, if they are not reviewed in a timely 
manner there is: 1) a risk of them becoming unmergable due to changes in 
the code base; and 2) discouragement of the submitter from doing more work.



-chris


If that really is your name...  Christopher Schultz signs his messages 
with a PGP signature ;)


Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Things that we can do to increase contributor involvement?

[Igal @ Lucee.org]

On 6/1/2017 5:05 AM, Coty Sutherland wrote:


Just for future reference, when you submit a PR it's easiest to review
if you squash all of the commits into one rather than multiple
commits.


Perhaps that's a mentality difference between SVN users and git users.  
In git it is common to do as in voting: commit early and commit often ( 
https://en.wikipedia.org/wiki/Vote_early_and_vote_often ).


But there is a very simple solution for that -- rather than check the 
individual commits, check the "Files changed" tab in github, in this 
case https://github.com/apache/tomcat/pull/56/files (notice `files` 
added to endpoint, but clicking the tab would take you there directly).


That shows the cumulative changes of all of the commits.

I try to make my PRs as easy as possible to review.

On 6/1/2017 6:29 AM, Mark Thomas wrote:

There is generally a large difference in responsiveness between bugs and 
enhancement requests. Most of the open PRs have been reviewed and are waiting 
for feedback. The others are enhancement requests which typically remain open 
until there is sufficient interest in implementing them.


Understandable, but please bear in mind that new contributors can not 
usually start with complicated bugs.  The new "Newbie / Stater / 
Beginner" keyword that you added to BZ was a great idea (h/t Chris), but 
if "Beginner" issues will not be reviewed due to lack of interest, then 
new contributors are very unlikely to submit any PRs after that first 
one that will not be addressed.


If Tomcat wants new contributors (and it should!), then a better 
feedback loop is required.


I, for one, am excited to contribute more to the project.  I've already 
received some feedback from Violeta about my PR since I sent my last 
email, and updated the PR accordingly.  I'm not sure if this thread had 
triggered the review or not, but AFAIC this is good progress :)



Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Things that we can do to increase contributor involvement?

[Igal @ Lucee.org]

Hi all,

On 5/31/2017 1:12 AM, Mark Thomas wrote:

On 31/05/17 04:07, Coty Sutherland wrote:

I've been thinking about things that we could do for Tomcat to help
bring in new contributors and to be more appealing to new developers.

https://helpwanted.apache.org/


I would like to offer the perspective of the "new contributor" here.  I, 
for one, would love to contribute and be more involved with the Tomcat 
project, and I believe that thanks to Tomcat's popularity there are many 
out there just like me.


As a new contributor, the most important thing is to get some feedback.  
The "worst" thing from a new contributor's perspective is that he/she 
will put much time into work that will never be looked at, and all that 
time will go to waste.


We understand that not all contributions will be accepted, and that they 
must adhere to the standards set by the project.  We also realize that 
this is open source, and that the people who review the submission are 
usually volunteers who do the best they can in the time that they can 
afford to contribute to the project.


We still need, however, to get some feedback on our submitted work in a 
timely manner before we can try again, or submit some other work.


Take for example the PRs on Github (sorry, but SVN feels like the 1980s 
-- great time for partying, not so much for writing code -- and I know, 
ironically the SVN project started in 2000, but I digress):

https://github.com/apache/tomcat/pulls

Anyway, there are PRs there from a few months ago, all the way to a 
couple of years ago.  The really old ones should be closed IMO, and 
suggest to the contributors to submit again if the issue(s) are still 
valid.  The newer ones should be evaluated and feedback should be given 
to the contributors  You already "found" new contributors -- better 
spend some time "cultivating" them than look for new ones who might end 
up stuck in that same situation.


The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 -- is 
from me, and it's only been a few days, so normally I wouldn't have said 
anything at this point because it hasn't been "long enough" since I 
submitted it.  But then I saw this email and it made perfect sense for 
me to chime in.


It was very important for me to keep my PR as small and simple as 
possible, so that it's easy to review and accept or reject.  But there 
is no feedback whatsoever.  I usually have more time to contribute on 
the weekends, so if I'll get some feedback soon, I will hopefully be 
able to implement whatever changes necessary on the weekend.  If not, 
then another week goes by.


Anyway, I really am not complaining here.  Just providing a perspective 
from "the other side".


All the best, and keep up the good work!


Igal


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [251E0E7D839A] PC Treasures - Running Tomcat in an IDE

[Igal @ Lucee.org]

On 5/30/2017 10:16 AM, Mark Thomas wrote:

On 30/05/2017 17:19, Caldarale, Charles R wrote:

It's not common and also not acceptable.

I'm on it. I'll make sure they are unsubscribed from all ASF lists and
banned from this one.


Thank you!

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [251E0E7D839A] PC Treasures - Running Tomcat in an IDE

[Igal @ Lucee.org]

Is the below a common thing on the Tomcat Dev list or is this just spam?

On 5/30/2017 8:24 AM, PCT Customer Service wrote:

Hi Igal @ Lucee.org,

Thanks for getting in touch with us.

Hello,

Please contact Premier PC Support by calling 844-814-5544 or you can visit 
http://mydeviceadvice.com/supportmefirst/ and select the "Request Support" icon 
in the top right corner to enter an online session with a representative. The technicians 
at Premier will be happy to assist you.

If you have any questions, do not hesitate to contact us.


--
Tonya R
Customer Service Center

PC Treasures, LLC
3720 Lapeer Rd
Auburn Hills, MI 48326
248.236.0061
www.pctreasures.com



-
Previous Message:


I am trying to run Tomcat in IntelliJ IDEA.  I have set up the project
and ...

-

Would you like to give feedback?
http://mydeviceadvice.com/livezilla/feedback.php?tid=MjU1NjM0

[251E0E7D839A]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Running Tomcat in an IDE

[Igal @ Lucee.org]

Hi,

On 5/29/2017 9:38 AM, Violeta Georgieva wrote:

Actually you can:
1. Generate eclipse artifacts with "ant ide-eclipse"
2. When you create a project in IntelliJ IDEA you can choose "Import
Project" -> Choose directory where eclipse artifacts are located -> "Import
project from external model" -> "Eclipse"


Cool.  I was not aware of the ide-eclipse and ide-netbeans targets.

For now I got it to work by simply changing the Working directory, but 
it's good to know in case I need to set it up again in the future.


Thanks again,

Igal Sapir
Lucee Core Developer
Lucee.org 

Re: Running Tomcat in an IDE

[Igal @ Lucee.org]

Konstantin,

On 5/29/2017 5:06 AM, Konstantin Kolinko wrote:

2017-05-28 23:14 GMT+03:00 Igal @ Lucee.org <i...@lucee.org>:

Is this a classpath issue or am I simply missing some environment arguments
or system properties?

WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists:
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists:
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists:
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists:
[false], isDirectory: [false], canRead: [false]

The above lines!

My guess is that you are trying to run the source code of Tomcat as is
without building it first.

Read BUILDING.txt,
The built version will be in output/build


I did read and followed the instructions in BUILDING.txt, but your 
advice clarified for me where the problem was.


In IntelliJ IDEA, I had to set the Working directory to "output/build", 
and now I don't get those errors.


Thank you,

Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>

Re: Running Tomcat in an IDE

[Igal @ Lucee.org]

Hi Violeta,

On 5/29/2017 12:44 AM, Violeta Georgieva wrote:

Hi

2017-05-28 23:14 GMT+03:00 Igal @ Lucee.org <i...@lucee.org>:

I am trying to run Tomcat in IntelliJ IDEA.  I have set up the project

Can you tell us how did you import it and also run it?


Since I'm working with IntelliJ IDEA, there is no way to explicitly 
"import" an Eclipse or an Ant project, I:


1) opened the code directory in IDEA
2) marked "tomcat/java" as a sources directory.
3) added a "compile-lib" directory with dependencies required for the 
source code: ant, ecj, jaxrpc, wsdl4j

4) ran `ant deploy` to build runtime dependencies

Thank you,


Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Running Tomcat in an IDE

[Igal @ Lucee.org]

I am trying to run Tomcat in IntelliJ IDEA.  I have set up the project 
and am able to build it and run it, but then I get runtime errors, e.g. 
ClassNotFound (stack traces below).


Is this a classpath issue or am I simply missing some environment 
arguments or system properties?


Thanks!

C:\Apps\Java\jdk1.8.0_131\bin\java 
-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:54658,suspend=y,server=n 
-Dfile.encoding=UTF-8 -classpath 
"C:\Apps\Java\jdk1.8.0_131\jre\lib\charsets.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\deploy.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\access-bridge-64.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\cldrdata.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\dnsns.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\jaccess.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\jfxrt.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\localedata.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\nashorn.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\sunec.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\sunjce_provider.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\sunmscapi.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\sunpkcs11.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\ext\zipfs.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\javaws.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\jce.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\jfr.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\jfxswt.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\jsse.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\management-agent.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\plugin.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\resources.jar;C:\Apps\Java\jdk1.8.0_131\jre\lib\rt.jar;E:\Workspace\git\tomcat-idea\out\production\tomcat;E:\Workspace\git\tomcat-idea\lib\ant-1.9.9.jar;E:\Workspace\git\tomcat-idea\lib\ecj-4.6.3.jar;E:\Workspace\git\tomcat-idea\lib\wsdl4j-1.6.2.jar;E:\Workspace\git\tomcat-idea\lib\geronimo-spec-jaxrpc-1.1-rc4.jar;C:\Program 
Files (x86)\JetBrains\IntelliJ IDEA Community Edition 
2017.1\lib\idea_rt.jar" org.apache.catalina.startup.Bootstrap

Connected to the target VM, address: '127.0.0.1:54658', transport: 'socket'
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory 
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists: 
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory 
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists: 
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory 
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists: 
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:52:17 PM org.apache.catalina.startup.ClassLoaderFactory 
validateFile
WARNING: Problem with directory [E:\Workspace\git\tomcat\lib], exists: 
[false], isDirectory: [false], canRead: [false]
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Server version:Apache Tomcat/@VERSION@
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Server built:  @VERSION_BUILT@
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Server number: @VERSION_NUMBER@
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: OS Name:   Windows 10
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: OS Version:10.0
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Architecture:  amd64
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Java Home: C:\Apps\Java\jdk1.8.0_131\jre
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: JVM Version:   1.8.0_131-b11
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: JVM Vendor:Oracle Corporation
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: CATALINA_BASE: E:\Workspace\git\tomcat
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: CATALINA_HOME: E:\Workspace\git\tomcat
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log
INFO: Command line argument: 
-agentlib:jdwp=transport=dt_socket,address=127.0.0.1:54658,suspend=y,server=n
May 28, 2017 12:58:44 PM 
org.apache.catalina.startup.VersionLoggerListener log

INFO: Command line argument: -Dfile.encoding=UTF-8
May 28, 2017 12:58:44 PM org.apache.catalina.core.AprLifecycleListener 
lifecycleEvent
INFO: The APR based Apache Tomcat Native library which allows optimal 
performance in production environments was not found on the 
java.library.path: 

Re: Need a BZ keyword for "this bug can be done by a newbie"

[Igal @ Lucee.org]

On 5/26/2017 1:46 PM, Christopher Schultz wrote:

I thought there was a BZ keyword for this, but there isn't. I've just
created an enhancement in BZ[1] that should be left for someone looking
to submit a small patch, and I'd like to attach such a keyword to this bug.


The Tomcat version of "So easy... even a caveman can do it"?

I'd definitely "subscribe" to tickets with that keyword.  I've been 
wanting to contribute to Tomcat for some time now.


If everyone else is busy with other things then I can start by tackling 
ticket 61127 and submit a patch.



Igal

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org