[GitHub] tomcat pull request #130: Add two spaces (nbsp) in front of the Undeploy but...

2018-11-01 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/130


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #130: Add two spaces (nbsp) in front of the Undeploy but...

2018-10-31 Thread ljader
GitHub user ljader opened a pull request:

https://github.com/apache/tomcat/pull/130

Add two spaces (nbsp) in front of the Undeploy button

Since there is no JavaScript in the Manager HTML,
I decided to visually separate the Undeploy button from the rest of the 
buttons.

This is to "prevent" **missclicks** on the Reload button,
which ends with the Undeploy being clicked.

(there is no Bugzilla ticket for this - I've created this to get your 
opinion on this.)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ljader/tomcat trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tomcat/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit a775d89f16563de3959189baa6b74acfd6696419
Author: Lukasz Jader 
Date:   2018-11-01T00:12:12Z

Add two spaces (nbsp) in front of the Undeploy button

This is to "prevent" missclicks on the Reload button,
which ends with the Undeploy being clicked.




---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org