Re: [VOTE] Release Apache Tomcat Native 2.0.4
> On May 31, 2023, at 04:58, Mark Thomas wrote: > > The key differences of version 2.0.4 compared to 2.0.3 are: > > - The windows binaries in this release have been built with OpenSSL > 3.0.9 and APR 1.7.4 > > The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but can be > used with earlier versions as long as the APR/native connector is not used. > > The proposed release artifacts can be found at [1], > and the build was done using tag [2]. > > The Apache Tomcat Native 2.0.4 release is > [X] Stable, go ahead and release > [ ] Broken because of ... +1 Han > > Thanks, > > Mark > > > [1] > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.4 > [2] > https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=2f080011a624527420c202331c0eb4880c7cc035 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
On Tue, May 30, 2023 at 10:58 PM Mark Thomas wrote: > > The key differences of version 2.0.4 compared to 2.0.3 are: > > - The windows binaries in this release have been built with OpenSSL >3.0.9 and APR 1.7.4 > > The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but > can be used with earlier versions as long as the APR/native connector is > not used. > > The proposed release artifacts can be found at [1], > and the build was done using tag [2]. > > The Apache Tomcat Native 2.0.4 release is > [X] Stable, go ahead and release > [ ] Broken because of ... Rémy > Thanks, > > Mark > > > [1] > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.4 > [2] > https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=2f080011a624527420c202331c0eb4880c7cc035 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
On 31/05/2023 14:38, Christopher Schultz wrote: Mark, Thanks for RMing On 5/30/23 16:58, Mark Thomas wrote: The key differences of version 2.0.4 compared to 2.0.3 are: - The windows binaries in this release have been built with OpenSSL 3.0.9 and APR 1.7.4 The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but can be used with earlier versions as long as the APR/native connector is not used. The proposed release artifacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 2.0.4 release is [ ] Stable, go ahead and release [ ] Broken because of ... +1 for stable release. Understanding that the only change was the new Windows statically-linked binaries... the native code builds with some deprecation warnings and Java unit tests pass on x86-84 MacOS using clang 12.0.5. Should we try to clean-up those deprecation warnings? I know it's probably another few miles of #IFDEFs... I think it is "just" a case of going through and updating the code to use the newer 3.0.x API rather than the 1.1.1 API. Haven't found the time to do it yet... Some notes: 1. Tomcat builds automatically download dependencies, while the Java tests require a separate "ant download". I think the tcnative build should also have the automatic dependency download that the Tomcat build does. Seems reasonable. 2. There is a native "check" target in the Makefile which fails because the "test" directory does not exist. Creating that directory and re-running "make check" fails because "check" isn't found as a make target (which is a little weird). What are the expectations here? No idea. I don't think I have every used that. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
Mark, Thanks for RMing On 5/30/23 16:58, Mark Thomas wrote: The key differences of version 2.0.4 compared to 2.0.3 are: - The windows binaries in this release have been built with OpenSSL 3.0.9 and APR 1.7.4 The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but can be used with earlier versions as long as the APR/native connector is not used. The proposed release artifacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 2.0.4 release is [ ] Stable, go ahead and release [ ] Broken because of ... +1 for stable release. Understanding that the only change was the new Windows statically-linked binaries... the native code builds with some deprecation warnings and Java unit tests pass on x86-84 MacOS using clang 12.0.5. Should we try to clean-up those deprecation warnings? I know it's probably another few miles of #IFDEFs... Some notes: 1. Tomcat builds automatically download dependencies, while the Java tests require a separate "ant download". I think the tcnative build should also have the automatic dependency download that the Tomcat build does. 2. There is a native "check" target in the Makefile which fails because the "test" directory does not exist. Creating that directory and re-running "make check" fails because "check" isn't found as a make target (which is a little weird). What are the expectations here? -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
On 30/05/2023 21:58, Mark Thomas wrote: The Apache Tomcat Native 2.0.4 release is [X] Stable, go ahead and release [ ] Broken because of ... Tested using: - Windows binaries with 11.0.x on Windows - Built OpenSSL 3.0.9 and Native 2.0.4 on Ubuntu and tested with 11.0.x All tests passed. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
On 31/05/2023 07:38, Igal Sapir wrote: I get compilation errors, but possibly because I don't have the most recent libs? Running on Ubuntu, the package manager shows the following versions as the most recent: ❯ sudo apt install libapr1-dev libssl-dev Reading package lists... Done Building dependency tree... Done Reading state information... Done libapr1-dev is already the newest version (1.7.0-8ubuntu0.22.04.1). libssl-dev is already the newest version (3.0.2-0ubuntu1.10). 0 upgraded, 0 newly installed, 0 to remove and 8 not upgraded. The compilation output ends with the following: /bin/bash /workspace/build/tomcat/apr-1.7.0/build-1/libtool --silent --mode=link --tag=CC gcc -g -O2 -pthread -DHAVE_CONFIG_ H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DTCNATIVE_LINUX -I./include -I/opt/java/zulu11.54.23-ca-jdk11.0.14-linux_x64/ include -I/opt/java/zulu11.54.23-ca-jdk11.0.14-linux_x64/include/linux -I/workspace/src/openssl/include -I/workspace/build/tom cat/apr-1.7.0/include/apr-1 -version-info 0:4:0-o libtcnative-2.la -rpath /workspace/build/tomcat/tomcat-native/tomcat-na tive-2.0.4/lib src/bb.lo src/error.lo src/jnilib.lo src/pool.lo src/ssl.lo src/sslconf.lo src/sslcontext.lo src/sslutils.lo -L/ workspace/src/openssl/lib -Wl,-rpath,/workspace/src/openssl/lib -lssl -lcrypto /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.l a -luuid -lrt -lcrypt -lpthread -ldl libtool: warning: library '/workspace/build/tomcat/apr-1.7.0/lib/libapr-1.la' was moved. /usr/bin/ld: /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.a(procsup.o): warning: relocation against `stdout@@GLIBC_2.2.5' in read-only section `.text' /usr/bin/ld: /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.a(proc_mutex.o): relocation R_X86_64_PC32 against symbol `apr_proc_ mutex_cleanup' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status make[1]: *** [Makefile:71: libtcnative-2.la] Error 1 make[1]: Leaving directory '/workspace/src/tomcat/tomcat-native/tomcat-native-2.0.4-src/native' make: *** [/workspace/src/tomcat/tomcat-native/tomcat-native-2.0.4-src/native/build/ rules.mk:118: all-recursive] Error 1 Any thoughts? Hmm, it works for me on Ubuntu with the same APR and OpenSSL packages. It looks like the build is finding a different version of libtool. My build uses /usr/share/apr-1.0/build/libtool Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat Native 2.0.4
Mark, On Tue, May 30, 2023 at 1:58 PM Mark Thomas wrote: > The key differences of version 2.0.4 compared to 2.0.3 are: > > - The windows binaries in this release have been built with OpenSSL >3.0.9 and APR 1.7.4 > > The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but > can be used with earlier versions as long as the APR/native connector is > not used. > > The proposed release artifacts can be found at [1], > and the build was done using tag [2]. > > The Apache Tomcat Native 2.0.4 release is > [ ] Stable, go ahead and release > [ ] Broken because of ... > I get compilation errors, but possibly because I don't have the most recent libs? Running on Ubuntu, the package manager shows the following versions as the most recent: ❯ sudo apt install libapr1-dev libssl-dev Reading package lists... Done Building dependency tree... Done Reading state information... Done libapr1-dev is already the newest version (1.7.0-8ubuntu0.22.04.1). libssl-dev is already the newest version (3.0.2-0ubuntu1.10). 0 upgraded, 0 newly installed, 0 to remove and 8 not upgraded. The compilation output ends with the following: /bin/bash /workspace/build/tomcat/apr-1.7.0/build-1/libtool --silent --mode=link --tag=CC gcc -g -O2 -pthread -DHAVE_CONFIG_ H -DLINUX -D_REENTRANT -D_GNU_SOURCE -g -O2 -DTCNATIVE_LINUX -I./include -I/opt/java/zulu11.54.23-ca-jdk11.0.14-linux_x64/ include -I/opt/java/zulu11.54.23-ca-jdk11.0.14-linux_x64/include/linux -I/workspace/src/openssl/include -I/workspace/build/tom cat/apr-1.7.0/include/apr-1 -version-info 0:4:0-o libtcnative-2.la -rpath /workspace/build/tomcat/tomcat-native/tomcat-na tive-2.0.4/lib src/bb.lo src/error.lo src/jnilib.lo src/pool.lo src/ssl.lo src/sslconf.lo src/sslcontext.lo src/sslutils.lo -L/ workspace/src/openssl/lib -Wl,-rpath,/workspace/src/openssl/lib -lssl -lcrypto /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.l a -luuid -lrt -lcrypt -lpthread -ldl libtool: warning: library '/workspace/build/tomcat/apr-1.7.0/lib/libapr-1.la' was moved. /usr/bin/ld: /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.a(procsup.o): warning: relocation against `stdout@@GLIBC_2.2.5' in read-only section `.text' /usr/bin/ld: /workspace/build/tomcat/apr-1.7.0/lib/libapr-1.a(proc_mutex.o): relocation R_X86_64_PC32 against symbol `apr_proc_ mutex_cleanup' can not be used when making a shared object; recompile with -fPIC /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status make[1]: *** [Makefile:71: libtcnative-2.la] Error 1 make[1]: Leaving directory '/workspace/src/tomcat/tomcat-native/tomcat-native-2.0.4-src/native' make: *** [/workspace/src/tomcat/tomcat-native/tomcat-native-2.0.4-src/native/build/ rules.mk:118: all-recursive] Error 1 Any thoughts? Igal > > Thanks, > > Mark > > > [1] > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.4 > [2] > > https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=2f080011a624527420c202331c0eb4880c7cc035 > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[VOTE] Release Apache Tomcat Native 2.0.4
The key differences of version 2.0.4 compared to 2.0.3 are: - The windows binaries in this release have been built with OpenSSL 3.0.9 and APR 1.7.4 The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but can be used with earlier versions as long as the APR/native connector is not used. The proposed release artifacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 2.0.4 release is [ ] Stable, go ahead and release [ ] Broken because of ... Thanks, Mark [1] https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/2.0.4 [2] https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=2f080011a624527420c202331c0eb4880c7cc035 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
