Re: Implementing web.xml default-context-path
On Wed, May 5, 2021 at 2:42 PM Jean-Louis MONTEIRO wrote: > Thanks for the feedback. > > Actually I was not looking for Mark or the Tomcat community to change their > minds. But for some guidance on how to hack something to get this test > to pass. > > I've been able to do it in TomEE which was the goal. > Now, I'm totally with you guys. If this is in your opinion a bad use case > with a bad specification solution, we should challenge the feature and then > the test. > The feature is optional, so it's "fine" with me. It allows suggesting a path to map the webapp, like Jira saying it should be mapped to /jira because "why not". This is pointless in practice, but since it's optional, there's nothing to do and I'm fine with it. The problem is then only the TCK testing for a mandatory optional feature. Good news on you working around it. Rémy > > Le mer. 5 mai 2021 à 11:22, Romain Manni-Bucau a > écrit : > > > Le mer. 5 mai 2021 à 11:19, Mark Thomas a écrit : > > > > > On 05/05/2021 09:58, Rémy Maucherat wrote: > > > > On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO < > jeano...@gmail.com > > > > > > > wrote: > > > > > > > >> Hi, > > > >> > > > >> Still working on getting TomEE certified for Jakarta EE 9.1 > > > >> We are using latest Tomcat 10.x and we indeed see now only one > failure > > > as > > > >> described here > > > >> > > > >> https://cwiki.apache.org/confluence/display/TOMCAT/Servlet+TCK+5.0 > > > >> > > > >> I understand this is not really a critical thing to be certified for > > > >> Tomcat. > > > >> And I also understand this is not something the community agrees on. > > > >> > > > >> But I'd like, for the sake of getting TomEE certified, to pass this > > test > > > >> and therefore I'm looking at a way to patch it on our side. > > > >> > > > >> Would you be able to help in giving pointers on how to do it? > > > >> > > > >> Any help is appreciated at this point. > > > >> > > > > > > > > We already talked about this (bad) "feature" quite a bit in the past. > > > > Unless there's a big surprise: > > > > - This needs intrusive and annoying change to the deployer > > > > - The benefit to actual users seems to be zero > > > > - The feature is optional > > > > As a result, I doubt Mark will change his mind [I am not enthusiastic > > > > either] and I still don't understand how it is a mandatory TCK test. > > > > > > +1 allowing this feature opens up a huge mess of deployment edge cases > > > that the Tomcat deployment process was designed very carefully to > avoid. > > > > > > > So ... I think you can come up with a hack instead: a Catalina > listener > > > > could be added to the Context, then it could configure the rewrite > > valve > > > to > > > > do the url mapping. It should be enough to make this work. > > > > > > Another option would be to challenge the TCK test on the grounds the > > > spec allows containers to override any default-context-path setting but > > > the TCK assumes this isn't going to happen (in Tomcat it will always > > > happen). > > > > > > > +1 to challenge this test, if there is a consensus it is wrong no point > to > > keep it year after year IMHO. > > > > > > > > > > Mark > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > -- > Jean-Louis >
Re: Implementing web.xml default-context-path
Thanks for the feedback. Actually I was not looking for Mark or the Tomcat community to change their minds. But for some guidance on how to hack something to get this test to pass. I've been able to do it in TomEE which was the goal. Now, I'm totally with you guys. If this is in your opinion a bad use case with a bad specification solution, we should challenge the feature and then the test. Le mer. 5 mai 2021 à 11:22, Romain Manni-Bucau a écrit : > Le mer. 5 mai 2021 à 11:19, Mark Thomas a écrit : > > > On 05/05/2021 09:58, Rémy Maucherat wrote: > > > On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO > > > > wrote: > > > > > >> Hi, > > >> > > >> Still working on getting TomEE certified for Jakarta EE 9.1 > > >> We are using latest Tomcat 10.x and we indeed see now only one failure > > as > > >> described here > > >> > > >> https://cwiki.apache.org/confluence/display/TOMCAT/Servlet+TCK+5.0 > > >> > > >> I understand this is not really a critical thing to be certified for > > >> Tomcat. > > >> And I also understand this is not something the community agrees on. > > >> > > >> But I'd like, for the sake of getting TomEE certified, to pass this > test > > >> and therefore I'm looking at a way to patch it on our side. > > >> > > >> Would you be able to help in giving pointers on how to do it? > > >> > > >> Any help is appreciated at this point. > > >> > > > > > > We already talked about this (bad) "feature" quite a bit in the past. > > > Unless there's a big surprise: > > > - This needs intrusive and annoying change to the deployer > > > - The benefit to actual users seems to be zero > > > - The feature is optional > > > As a result, I doubt Mark will change his mind [I am not enthusiastic > > > either] and I still don't understand how it is a mandatory TCK test. > > > > +1 allowing this feature opens up a huge mess of deployment edge cases > > that the Tomcat deployment process was designed very carefully to avoid. > > > > > So ... I think you can come up with a hack instead: a Catalina listener > > > could be added to the Context, then it could configure the rewrite > valve > > to > > > do the url mapping. It should be enough to make this work. > > > > Another option would be to challenge the TCK test on the grounds the > > spec allows containers to override any default-context-path setting but > > the TCK assumes this isn't going to happen (in Tomcat it will always > > happen). > > > > +1 to challenge this test, if there is a consensus it is wrong no point to > keep it year after year IMHO. > > > > > > Mark > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > -- Jean-Louis
Re: Implementing web.xml default-context-path
Le mer. 5 mai 2021 à 11:19, Mark Thomas a écrit : > On 05/05/2021 09:58, Rémy Maucherat wrote: > > On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO > > wrote: > > > >> Hi, > >> > >> Still working on getting TomEE certified for Jakarta EE 9.1 > >> We are using latest Tomcat 10.x and we indeed see now only one failure > as > >> described here > >> > >> https://cwiki.apache.org/confluence/display/TOMCAT/Servlet+TCK+5.0 > >> > >> I understand this is not really a critical thing to be certified for > >> Tomcat. > >> And I also understand this is not something the community agrees on. > >> > >> But I'd like, for the sake of getting TomEE certified, to pass this test > >> and therefore I'm looking at a way to patch it on our side. > >> > >> Would you be able to help in giving pointers on how to do it? > >> > >> Any help is appreciated at this point. > >> > > > > We already talked about this (bad) "feature" quite a bit in the past. > > Unless there's a big surprise: > > - This needs intrusive and annoying change to the deployer > > - The benefit to actual users seems to be zero > > - The feature is optional > > As a result, I doubt Mark will change his mind [I am not enthusiastic > > either] and I still don't understand how it is a mandatory TCK test. > > +1 allowing this feature opens up a huge mess of deployment edge cases > that the Tomcat deployment process was designed very carefully to avoid. > > > So ... I think you can come up with a hack instead: a Catalina listener > > could be added to the Context, then it could configure the rewrite valve > to > > do the url mapping. It should be enough to make this work. > > Another option would be to challenge the TCK test on the grounds the > spec allows containers to override any default-context-path setting but > the TCK assumes this isn't going to happen (in Tomcat it will always > happen). > +1 to challenge this test, if there is a consensus it is wrong no point to keep it year after year IMHO. > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: Implementing web.xml default-context-path
On 05/05/2021 09:58, Rémy Maucherat wrote: On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO wrote: Hi, Still working on getting TomEE certified for Jakarta EE 9.1 We are using latest Tomcat 10.x and we indeed see now only one failure as described here https://cwiki.apache.org/confluence/display/TOMCAT/Servlet+TCK+5.0 I understand this is not really a critical thing to be certified for Tomcat. And I also understand this is not something the community agrees on. But I'd like, for the sake of getting TomEE certified, to pass this test and therefore I'm looking at a way to patch it on our side. Would you be able to help in giving pointers on how to do it? Any help is appreciated at this point. We already talked about this (bad) "feature" quite a bit in the past. Unless there's a big surprise: - This needs intrusive and annoying change to the deployer - The benefit to actual users seems to be zero - The feature is optional As a result, I doubt Mark will change his mind [I am not enthusiastic either] and I still don't understand how it is a mandatory TCK test. +1 allowing this feature opens up a huge mess of deployment edge cases that the Tomcat deployment process was designed very carefully to avoid. So ... I think you can come up with a hack instead: a Catalina listener could be added to the Context, then it could configure the rewrite valve to do the url mapping. It should be enough to make this work. Another option would be to challenge the TCK test on the grounds the spec allows containers to override any default-context-path setting but the TCK assumes this isn't going to happen (in Tomcat it will always happen). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Implementing web.xml default-context-path
On Sun, May 2, 2021 at 3:17 PM Jean-Louis MONTEIRO wrote: > Hi, > > Still working on getting TomEE certified for Jakarta EE 9.1 > We are using latest Tomcat 10.x and we indeed see now only one failure as > described here > > https://cwiki.apache.org/confluence/display/TOMCAT/Servlet+TCK+5.0 > > I understand this is not really a critical thing to be certified for > Tomcat. > And I also understand this is not something the community agrees on. > > But I'd like, for the sake of getting TomEE certified, to pass this test > and therefore I'm looking at a way to patch it on our side. > > Would you be able to help in giving pointers on how to do it? > > Any help is appreciated at this point. > We already talked about this (bad) "feature" quite a bit in the past. Unless there's a big surprise: - This needs intrusive and annoying change to the deployer - The benefit to actual users seems to be zero - The feature is optional As a result, I doubt Mark will change his mind [I am not enthusiastic either] and I still don't understand how it is a mandatory TCK test. So ... I think you can come up with a hack instead: a Catalina listener could be added to the Context, then it could configure the rewrite valve to do the url mapping. It should be enough to make this work. Rémy > > > -- > Jean-Louis >
