Re: Default resources for Java EE 7.
Le 6 août 2017 14:12, "Daniel Cunha" a écrit : Hi Romain, Well, I see that: Https://github.com/apache/tomee/blob/master/tomee/tomee- common/src/main/java/org/apache/tomee/installer/Installer.java#L729 So, do we forget the '\ n' on the previous line? It seems that this is already expected to be true by default. So make sense we have that: https://github.com/apache/tomee/pull/102/files#diff- 77912d8fbbbfd389a1d3cbb339561e3cR369 IMHO. No, in standalone it was set to match the spec but it covers ~1% of the real world usage (remove tests, remove base/home instances etc...) so think we are good with current defaults. We can surely enhance Comp merging when there is no webapp - you second addDefault diff - bit this is unrelated to default resources, more to jndi shared namespace handling outside webapps. Hi Jon, I updated tests for this one: https://github.com/apache/tomee/pull/103 On Sun, Aug 6, 2017 at 8:46 AM, Daniel Cunha wrote: > Hi Romain, > > well, I get it. But If you don't want the defaults resources then I'll set > the flag to false. The server should always start with default resource > IMHO. > > On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau > wrote: > >> Hi Daniel >> >> The side note here is: having them by default was intended cause it breaks >> tomee deeply in term of resource matching and user existing config. Idea >> was to set the flag if you want ee7 behavior to stay backward compat (and >> this solution is fine for a EE container). >> >> >> >> >> Le 6 août 2017 02:06, "Daniel Cunha" a écrit : >> >> > Hi folks, >> > >> > I started some works with concurrency API and got some troubles with >> > default resources, let me know what do you think about my PRs: >> > >> > https://github.com/apache/tomee/pull/102 >> > https://github.com/apache/tomee/pull/103 >> > >> > >> > Best regard. >> > -- >> > Daniel Cunha >> > https://twitter.com/dvlc_ >> > >> > > > > -- > Daniel Cunha > https://twitter.com/dvlc_ > -- Daniel Cunha https://twitter.com/dvlc_
Re: Default resources for Java EE 7.
Hi Romain, Well, I see that: Https://github.com/apache/tomee/blob/master/tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java#L729 So, do we forget the '\ n' on the previous line? It seems that this is already expected to be true by default. So make sense we have that: https://github.com/apache/tomee/pull/102/files#diff-77912d8fbbbfd389a1d3cbb339561e3cR369 IMHO. Hi Jon, I updated tests for this one: https://github.com/apache/tomee/pull/103 On Sun, Aug 6, 2017 at 8:46 AM, Daniel Cunha wrote: > Hi Romain, > > well, I get it. But If you don't want the defaults resources then I'll set > the flag to false. The server should always start with default resource > IMHO. > > On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau > wrote: > >> Hi Daniel >> >> The side note here is: having them by default was intended cause it breaks >> tomee deeply in term of resource matching and user existing config. Idea >> was to set the flag if you want ee7 behavior to stay backward compat (and >> this solution is fine for a EE container). >> >> >> >> >> Le 6 août 2017 02:06, "Daniel Cunha" a écrit : >> >> > Hi folks, >> > >> > I started some works with concurrency API and got some troubles with >> > default resources, let me know what do you think about my PRs: >> > >> > https://github.com/apache/tomee/pull/102 >> > https://github.com/apache/tomee/pull/103 >> > >> > >> > Best regard. >> > -- >> > Daniel Cunha >> > https://twitter.com/dvlc_ >> > >> > > > > -- > Daniel Cunha > https://twitter.com/dvlc_ > -- Daniel Cunha https://twitter.com/dvlc_
Re: Default resources for Java EE 7.
Hi Romain, well, I get it. But If you don't want the defaults resources then I'll set the flag to false. The server should always start with default resource IMHO. On Sun, Aug 6, 2017 at 4:35 AM, Romain Manni-Bucau wrote: > Hi Daniel > > The side note here is: having them by default was intended cause it breaks > tomee deeply in term of resource matching and user existing config. Idea > was to set the flag if you want ee7 behavior to stay backward compat (and > this solution is fine for a EE container). > > > > > Le 6 août 2017 02:06, "Daniel Cunha" a écrit : > > > Hi folks, > > > > I started some works with concurrency API and got some troubles with > > default resources, let me know what do you think about my PRs: > > > > https://github.com/apache/tomee/pull/102 > > https://github.com/apache/tomee/pull/103 > > > > > > Best regard. > > -- > > Daniel Cunha > > https://twitter.com/dvlc_ > > > -- Daniel Cunha https://twitter.com/dvlc_
[GitHub] tomee pull request #103: TOMEE-2110 - DefaultContextService missing like def...
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/103 TOMEE-2110 - DefaultContextService missing like default resource. You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee TOMEE-2110 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomee/pull/103.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #103 commit 26b9185ac376e93c74b26454306b41659fd3b2d8 Author: Daniel Cunha (soro) Date: 2017-08-06T00:03:42Z TOMEE-2110 - DefaultContextService missing like default resource. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tomee pull request #102: TOMEE-2109 - Default Resource should always be load...
GitHub user danielsoro opened a pull request: https://github.com/apache/tomee/pull/102 TOMEE-2109 - Default Resource should always be loaded by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsoro/tomee TOMEE-2109 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomee/pull/102.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #102 commit bb1f2a7d00dd6171c656b374badffd9f79156ed3 Author: Daniel Cunha (soro) Date: 2017-08-05T23:44:35Z TOMEE-2109 - Default Resource should always be loaded by default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: Default resources for Java EE 7.
Hi Daniel The side note here is: having them by default was intended cause it breaks tomee deeply in term of resource matching and user existing config. Idea was to set the flag if you want ee7 behavior to stay backward compat (and this solution is fine for a EE container). Le 6 août 2017 02:06, "Daniel Cunha" a écrit : > Hi folks, > > I started some works with concurrency API and got some troubles with > default resources, let me know what do you think about my PRs: > > https://github.com/apache/tomee/pull/102 > https://github.com/apache/tomee/pull/103 > > > Best regard. > -- > Daniel Cunha > https://twitter.com/dvlc_ >
Re: Default resources for Java EE 7.
Can you add a test? Other than that, they should be good. Thanks Jon On 6 Aug 2017 1:06 am, "Daniel Cunha" wrote: Hi folks, I started some works with concurrency API and got some troubles with default resources, let me know what do you think about my PRs: https://github.com/apache/tomee/pull/102 https://github.com/apache/tomee/pull/103 Best regard. -- Daniel Cunha https://twitter.com/dvlc_
