Re: Adds getModuleId method as a fallback when getJarLocation is null at
That is from container. [INFO] [INFO] --- maven-install-plugin:2.5.2:install (default-install) @ openejb-junit --- [INFO] Installing /home/otaviojava/Environment/code/workspace-tomitribe-support/tomee/container/openejb-junit/target/openejb-junit-8.0.0-SNAPSHOT.jar to /home/otaviojava/.m2/repository/org/apache/tomee/openejb-junit/8.0.0-SNAPSHOT/openejb-junit-8.0.0-SNAPSHOT.jar [INFO] Installing /home/otaviojava/Environment/code/workspace-tomitribe-support/tomee/container/openejb-junit/pom.xml to /home/otaviojava/.m2/repository/org/apache/tomee/openejb-junit/8.0.0-SNAPSHOT/openejb-junit-8.0.0-SNAPSHOT.pom [INFO] [INFO] Reactor Summary for OpenEJB :: Container 8.0.0-SNAPSHOT: [INFO] [INFO] OpenEJB :: Container ... SUCCESS [ 0.904 s] [INFO] OpenEJB :: Container :: MBean Annotation API ... SUCCESS [ 0.895 s] [INFO] OpenEJB :: Container :: API SUCCESS [ 0.338 s] [INFO] OpenEJB :: Container :: JPA Integration SUCCESS [ 0.753 s] [INFO] OpenEJB :: Container :: Loader . SUCCESS [ 17.958 s] [INFO] OpenEJB :: Container :: Java Agent . SUCCESS [ 0.171 s] [INFO] OpenEJB :: Container :: Java EE SUCCESS [ 15.407 s] [INFO] OpenEJB :: Container :: Java EE Accessors .. SUCCESS [ 4.121 s] [INFO] OpenEJB :: Container :: Core ... SUCCESS [19:15 min] [INFO] OpenEJB :: Container :: JUnit .. SUCCESS [ 26.725 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 20:23 min [INFO] Finished at: 2018-12-13T09:21:30-02:00 [INFO] On Thu, Dec 13, 2018 at 9:36 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Ah ok, I was running a build first. > So Should I leave it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, Dec 13, 2018 at 12:10 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Looks like that was a popular one :) > > > > On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < > > jonathan.gallim...@gmail.com> wrote: > > > > > Awesome, thank you! Merged. > > > > > > Jon > > > > > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > > > osant...@tomitribe.com> wrote: > > > > > >> It PR adds the getModuleId method as a fallback when getJarLocation is > > >> null > > >> at CmpJpaConversion, this way it keeps the desired behavior and fixes > > the > > >> when the getJarLocation is null such as the CheckMissingClassTest. > > >> > > >> https://github.com/apache/tomee/pull/274 > > >> > > > > > >
Re: Adds getModuleId method as a fallback when getJarLocation is null at
Running a build here too. If stuff breaks, we can revert it. Cheers Jon On Thu, Dec 13, 2018 at 11:36 AM Jean-Louis Monteiro < jlmonte...@tomitribe.com> wrote: > Ah ok, I was running a build first. > So Should I leave it? > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Thu, Dec 13, 2018 at 12:10 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Looks like that was a popular one :) > > > > On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < > > jonathan.gallim...@gmail.com> wrote: > > > > > Awesome, thank you! Merged. > > > > > > Jon > > > > > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > > > osant...@tomitribe.com> wrote: > > > > > >> It PR adds the getModuleId method as a fallback when getJarLocation is > > >> null > > >> at CmpJpaConversion, this way it keeps the desired behavior and fixes > > the > > >> when the getJarLocation is null such as the CheckMissingClassTest. > > >> > > >> https://github.com/apache/tomee/pull/274 > > >> > > > > > >
Re: Adds getModuleId method as a fallback when getJarLocation is null at
Ah ok, I was running a build first. So Should I leave it? -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 12:10 PM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Looks like that was a popular one :) > > On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > > Awesome, thank you! Merged. > > > > Jon > > > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > > osant...@tomitribe.com> wrote: > > > >> It PR adds the getModuleId method as a fallback when getJarLocation is > >> null > >> at CmpJpaConversion, this way it keeps the desired behavior and fixes > the > >> when the getJarLocation is null such as the CheckMissingClassTest. > >> > >> https://github.com/apache/tomee/pull/274 > >> > > >
Re: Adds getModuleId method as a fallback when getJarLocation is null at
Looks like that was a popular one :) On Thu, Dec 13, 2018 at 11:09 AM Jonathan Gallimore < jonathan.gallim...@gmail.com> wrote: > Awesome, thank you! Merged. > > Jon > > On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < > osant...@tomitribe.com> wrote: > >> It PR adds the getModuleId method as a fallback when getJarLocation is >> null >> at CmpJpaConversion, this way it keeps the desired behavior and fixes the >> when the getJarLocation is null such as the CheckMissingClassTest. >> >> https://github.com/apache/tomee/pull/274 >> >
Re: Adds getModuleId method as a fallback when getJarLocation is null at
Awesome, thank you! Merged. Jon On Thu, Dec 13, 2018 at 10:56 AM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > It PR adds the getModuleId method as a fallback when getJarLocation is null > at CmpJpaConversion, this way it keeps the desired behavior and fixes the > when the getJarLocation is null such as the CheckMissingClassTest. > > https://github.com/apache/tomee/pull/274 >
Re: Adds getModuleId method as a fallback when getJarLocation is null at
I was looking at it. I'll check it out and give it a try and a full build. Thanks -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Dec 13, 2018 at 11:56 AM Otávio Gonçalves de Santana < osant...@tomitribe.com> wrote: > It PR adds the getModuleId method as a fallback when getJarLocation is null > at CmpJpaConversion, this way it keeps the desired behavior and fixes the > when the getJarLocation is null such as the CheckMissingClassTest. > > https://github.com/apache/tomee/pull/274 >
