Re: [VOTE] Release Velocity Engine version 2.4.1

[Greg Huber]

It passes all my tests, and works great.  Thanks.

On 18/02/2024 12:45, Michael Osipov wrote:

Hi,

Release notes: 
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310104=12354231


Staging repo:
https://repository.apache.org/content/repositories/orgapachevelocity-1043/ 

https://repository.apache.org/content/repositories/orgapachevelocity-1043/org/apache/velocity/velocity-engine-parent/2.4.1/velocity-engine-parent-2.4.1-source-release.zip 



Source release checksum(s):
velocity-engine-parent-2.4.1-source-release.zip
sha512: 
140854cf8e2a1f315b954d8be8c56f0087a13ec647065ecdea3594d2cb0099414fede608a2a9392f15beb04e6fb89b220710d0032b9bd734113e6bf578550187


Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

WARNING: Illegal reflective access

[Greg Huber]

Hello,

I see this in my compile on java 11.


WARNING: An illegal reflective access operation has occurred WARNING: 
Illegal reflective access by 
org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl 
(file:~.m2/repository/org/apache/velocity/velocity-engine-core/2.3/velocity-engine-core-2.3.jar) 
to method com.sun.tools.javac.code.Symbol$MethodSymbol.getReturnType() 
WARNING: Please consider reporting this to the maintainers of 
org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl 
WARNING: Use --illegal-access=warn to enable warnings of further illegal 
reflective access operations WARNING: All illegal access operations will 
be denied in a future release.


I guess this is already known?


Cheers Greg




-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Re: [VOTE] Engine 2.3 RC1 Release quality

[Greg Huber]

Just for the velocity-engine-core-2.3.jar, works ok for me.

[x] General Availability (GA)

Cheers



Not sure if its my setup but I get for

$ git clone --branch velocity-master-4 
https://github.com/apache/velocity-master.git

$ cd velocity-master
$ mvn install


[INFO] Scanning for projects...
[INFO] 


[INFO] BUILD FAILURE
[INFO] 


[INFO] Total time:  0.094 s
[INFO] Finished at: 2021-03-01T16:15:34Z
[INFO] 

[ERROR] The goal you specified requires a project to execute but there 
is no POM in this directory 
(/home/devbox/downloads/test/velocity-master). Please verify you invoked 
Maven from the correct directory. -> [Help 1]

[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the 
-e switch.

[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, 
please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException


>>pwd
>> /home/devbox/downloads/test/velocity-master

On 01/03/2021 16:06, Claude Brisson wrote:

The Velocity Engine 2.3 RC1 is available since February 27.

Main changes in this release:

+ New spring-velocity-support module, containing Spring framework 
Velocity Engine integration classes.
+ Security fix: let SecureUberspector block methods on ClassLoader and 
subclasses.


Release notes:

* 
https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.3/release-notes.html


Distribution:

 * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.3/

Maven 2 staging repository:

 * 
https://repository.apache.org/content/repositories/orgapachevelocity-1036


Documentation:

* http://velocity.apache.org/engine/2.3/

Sources:

 * https://github.com/apache/velocity-engine/releases/tag/2.3-RC1

Please note than when evaluating this module, you will need to also 
install velocity-master version 4 to your local maven repository, with 
commands like:


$ git clone --branch velocity-master-4 
https://github.com/apache/velocity-master.git

$ cd velocity-master
$ mvn install

If you have had a chance to review the test build, please respond with 
a vote on its quality:



 [ ] Leave at test build
 [ ] Alpha
 [ ] Beta
 [ ] General Availability (GA)




-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Re: [ANNOUCE] Velocity Engine 2.3 test build available

[Greg Huber]

Previously I have used the below for maven, now I get

[ERROR] Failed to execute goal on project events: Could not resolve 
dependencies for project my.war: Failed to collect dependencies at 
org.apache.velocity:velocity-engine-core:jar:2.3: Failed to read 
artifact descriptor for 
org.apache.velocity:velocity-engine-core:jar:2.3: Could not find 
artifact org.apache.velocity:velocity-master:pom:4 in velocity.snapshots 
(https://repository.apache.org/content/repositories/orgapachevelocity-1036/) 
-> [Help 1]



            velocity.snapshots
            ASF Maven 2 Snapshot
https://repository.apache.org/content/repositories/orgapachevelocity-1036/
            
                true
                always
                warn
            
            
                true
                always
                warn
            



            org.apache.velocity
velocity-engine-core
            2.3



Any ideas, I have removed the .m2 velocity folder before the build.


On 27/02/2021 13:13, Claude Brisson wrote:

The test build of Velocity Engine 2.3 RC1 is available.

No determination as to the quality ('alpha,' 'beta,' or 'GA') of 
Velocity Engine 2.3 RC1 has been made, and at this time it is simply a 
"test build". We welcome any comments you may have, and will take all 
feedback into account if a quality vote is called for this build.


Release notes:

* 
https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.3/release-notes.html 



Distribution:

 * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.3/

Maven 2 staging repository:

 * 
https://repository.apache.org/content/repositories/orgapachevelocity-1036


Documentation:

* http://velocity.apache.org/engine/2.3/

Sources:

 * https://gitbox.apache.org/repos/asf?p=velocity-engine.git
 * https://github.com/apache/velocity-engine

A vote regarding the quality of this test build will be initiated soon.


-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
For additional commands, e-mail: dev-h...@velocity.apache.org

Re: [ANNOUNCE] Velocity Engine 2.2 RC6 test build available

[Greg Huber]

Works well for me now.  Thanks.

On Thu, 30 Jan 2020 at 01:05, Claude Brisson 
wrote:

> The test build of Velocity Engine 2.2 RC6 is available.
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> Velocity Engine 2.2 has been made, and at this time it is simply a "test
> build". We welcome any comments you may have, and will take all feedback
> into account if a quality vote is called for this build.
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/release-notes.html
>
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1034/
>
> Documentation:
>
> * https://velocity.apache.org/engine/2.2/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.2/
>
> Release Candidates History:
>
>   * RC1 Initial RC
>
>   * RC2
>   - added BigInteger and BigDecimal implicit conversions
>   - [VELOCITY-923] fixed a parser regression for `$foo||`
>   - [VELOCITY-904] fixed two corner case bugs for the
> velocimacro.arguments.preserve_literals backward compatibility flag
>   - fixed engine and dependency versions in README and mention the
> parser customization feature in the *building* section
>   - nicified README links
>   - upgraded surfire plugin version from 2.19.1 to 2.22.1
>   - upgraded maven-jar-plugin from 3.1.1 to 3.2.2
>   - added version 1.2 for extra-enforcer-rules
>   - upgraded maven-javadoc-plugin from 3.1.0 to 3.1.1
>   - upgraded findbugs-maven-plugin from 3.0.4 to 3.0.5
>   - upgraded maven-release-plugin from *unspecified* to 3.0.0-M1
>   - added a new templatized static class
> org.apache.velocity.runtime.VelocityEngineVersion.java
>   - use the File Separator control character to mark the end of stream
> for the parser (instead of the zero-width space char)
>   - reviewed packaging of engine examples (refreshed content, plus made
> them as a standalone zip file with readme, shell scripts, dependencies
> and examples sources rather than a meaningless standalone pom next to a
> jar without explanations...)
>
> * RC3
>   - [VELOCITY-904] fixed yet another corner case bugs for the
> velocimacro.arguments.preserve_literals backward compatibility flag
>   - upgraded SLF4J from 1.7.28 to 1.7.30
>
> * RC4
>   - [VELOCITY-904] fixed a regression introduced in RC3
>
> * RC5
>   - [VELOCITY-924] fixed cache collision between an object and its class
>   - Javadoc fixes in parser genereted classes
>   - [VELOCITY-925] fixed BC whitespace gobbling for macro call without
> parentheses
>   - [VELOCITY-926] fixed regression: Macro arguments names cannot
> collide with external references names
>   - upgraded junit from 4.12 to 4.13
>
> * RC6
> - [VELOCITY-926] fixed side effects by deprecating
> velocimacro.arguments.preserve_literals config flag in favor of
> velocimacro.enable_bc_mode, which (besides preserving arguments
> literals) uses global context values as defaults for missing macro
> arguments without explicit defaults (as did 1.7)
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.2 RC5 test build available

[Greg Huber]

Hello,

Checking this, I have an error where it does not render a parameter
(generic variable) correctly ie $type:

#showAutocomplete("$search/entry", '1', $name, 'query', false)

#macro(showAutocomplete $sUrl $source $name $type $links)
...
data: {
  sUrl: "$sUrl",
  source: "$source",
  #if($name) name: "$name",#end
  $type: input.val()
}


Expected:
sUrl: "/homepage/search/entry",
source: "1",
name: "homepage",
query: input.val()

Actual:
sUrl: "/homepage/search/entry",
source: "1",
name: "homepage",
$type: input.val()

$type is used extensively as a generic variable, so maybe there is some
clash somewhere?  Also if I rename the variable, for example $type1, it
seems to work.

I Also went back to 2.1 to check and it works as expected.

Cheers Greg

On Fri, 24 Jan 2020 at 11:21, Claude Brisson 
wrote:

> The test build of Velocity Engine 2.2 RC5 is available.
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> Velocity Engine 2.2 has been made, and at this time it is simply a "test
> build". We welcome any comments you may have, and will take all feedback
> into account if a quality vote is called for this build.
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/release-notes.html
>
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1033/
>
> Documentation:
>
> * https://velocity.apache.org/engine/2.2/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.2/
>
> Release Candidates History:
>
>   * RC1 Initial RC
>
>   * RC2
>   - added BigInteger and BigDecimal implicit conversions
>   - [VELOCITY-923] fixed a parser regression for `$foo||`
>   - [VELOCITY-904] fixed two corner case bugs for the
> velocimacro.arguments.preserve_literals backward compatibility flag
>   - fixed engine and dependency versions in README and mention the
> parser customization feature in the *building* section
>   - nicified README links
>   - upgraded surfire plugin version from 2.19.1 to 2.22.1
>   - upgraded maven-jar-plugin from 3.1.1 to 3.2.2
>   - added version 1.2 for extra-enforcer-rules
>   - upgraded maven-javadoc-plugin from 3.1.0 to 3.1.1
>   - upgraded findbugs-maven-plugin from 3.0.4 to 3.0.5
>   - upgraded maven-release-plugin from *unspecified* to 3.0.0-M1
>   - added a new templatized static class
> org.apache.velocity.runtime.VelocityEngineVersion.java
>   - use the File Separator control character to mark the end of stream
> for the parser (instead of the zero-width space char)
>   - reviewed packaging of engine examples (refreshed content, plus made
> them as a standalone zip file with readme, shell scripts, dependencies
> and examples sources rather than a meaningless standalone pom next to a
> jar without explanations...)
>
> * RC3
>   - [VELOCITY-904] fixed yet another corner case bugs for the
> velocimacro.arguments.preserve_literals backward compatibility flag
>   - upgraded SLF4J from 1.7.28 to 1.7.30
>
> * RC4
>   - [VELOCITY-904] fixed a regression introduced in RC3
>
> * RC5
>   - [VELOCITY-924] fixed cache collision between an object and its class
>   - Javadoc fixes in parser genereted classes
>   - [VELOCITY-925] fixed BC whitespace gobbling for macro call without
> parentheses
>   - [VELOCITY-926] fixed regression: Macro arguments names cannot
> collide with external references names
>   - upgraded junit from 4.12 to 4.13
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] Engine 2.2 RC1 Release quality

[Greg Huber]

Works great for me.

[ ] Leave at test build
 [ ] Alpha
 [ ] Beta
 [x] General Availability (GA) nb

Thanks.

On Fri, 20 Sep 2019 at 13:33, Claude Brisson 
wrote:

> The Velocity Engine 2.2 RC1 is available since September 8.
>
> Main changes in this release:
>
>   - New 1.7 backward compatibility flags to mimic 1.7.x
> InvalidReferenceHandler behavior.
>   - New runtime.log.track_locations debugging configuration flag which
> displays the VTL stack trace in the logs in cases of errors, and
> populates slf4j MDC tags about position in VTL templates.
>   - New example of how to build a customized VTL parser where the '#',
> '$', '*' and '@' characters can be replaced by alternate characters.
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/release-notes.html
>
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1029
>
> Documentation:
>
> * http://velocity.apache.org/engine/2.2/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.2/
>
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>   [ ] Leave at test build
>   [ ] Alpha
>   [ ] Beta
>   [ ] General Availability (GA)
>
>--
>Claude
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUCE] Velocity Engine 2.2 test build available

[Greg Huber]

Works well for me.  Thanks.

On Sun, 8 Sep 2019 at 18:46, Claude Brisson 
wrote:

> The test build of Velocity Engine 2.2 RC1 is available.
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> Velocity Engine 2.2 RC1 has been made, and at this time it is simply a
> "test build". We welcome any comments you may have, and will take all
> feedback into account if a quality vote is called for this build.
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/release-notes.html
>
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.2/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1029/
>
> Documentation:
>
> * http://velocity.apache.org/engine/2.2/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.2/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
>--
>Claude
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] Engine 2.1 RC3 Release quality

[Greg Huber]

Texen, yes.   I use it in my build, so I have a local version.

...I missed this had been created already

org.apache.velocity.runtime.RuntimeConstants
String RESOURCE_LOADERS = "resource.loaders";

Cheers Greg


On Wed, 20 Mar 2019 at 09:22, Claude Brisson 
wrote:

> You mean Texen? Well, this subproject has been archived, since no one is
> maintaining it anymore.
>
> It shouldn't be too hard to patch it the day Engine 3.0 drops reprecated
> config names, though.
>
> On 20/03/2019 09:39, Greg Huber wrote:
> > I was just upgrading my local taxen task and it uses
> > VelocityEngine.RESOURCE_LOADER with a value of resource.loader
> > Maybe this need to be upgraded? >> resource.loaders as I get a message
> when
> > running the command.
> > [WARNING] configuration key 'resource.loader' has been deprecated in
> favor
> > of 'resource.loaders'
> >
> >
> >
> > On Wed, 20 Mar 2019 at 00:43, Claude Brisson  >
> > wrote:
> >
> >> The Velocity Engine 2.1 RC3 is available since March 15.
> >>
> >> Main changes:
> >>
> >>* Velocity Engine 2.1 now requires JDK 1.8+
> >>* Two more backward compatibility flags with 1.7: hyphens in
> >> identifiers and macros literal arguments handling
> >>* New VTL syntax: default values for references: ${name|'John Doe'} -
> >> the right part can be any valid VTL expression
> >>* New VTL syntax: empty loops block for #foreach directive:
> >> #foreach(...) ... #else ... #end
> >>* Configuration keys refactoring (with backward compatibility
> handling)
> >>
> >> Release notes:
> >>
> >> *
> >>
> >>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
> >>
> >> Distribution:
> >>
> >>*
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
> >>
> >> Maven 2 staging repository:
> >>
> >>*
> >>
> https://repository.apache.org/content/repositories/orgapachevelocity-1027
> >>
> >> Documentation:
> >>
> >> * http://velocity.apache.org/engine/2.1/
> >>
> >> Sources:
> >>
> >>* https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
> >>
> >>
> >> If you have had a chance to review the test build, please respond with a
> >> vote on its quality:
> >>
> >>[ ] Leave at test build
> >>[ ] Alpha
> >>[ ] Beta
> >>[ ] General Availability (GA)
> >>
> >> --
> >> Claude
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] Engine 2.1 RC3 Release quality

[Greg Huber]

I was just upgrading my local taxen task and it uses
VelocityEngine.RESOURCE_LOADER with a value of resource.loader
Maybe this need to be upgraded? >> resource.loaders as I get a message when
running the command.
[WARNING] configuration key 'resource.loader' has been deprecated in favor
of 'resource.loaders'



On Wed, 20 Mar 2019 at 00:43, Claude Brisson 
wrote:

> The Velocity Engine 2.1 RC3 is available since March 15.
>
> Main changes:
>
>   * Velocity Engine 2.1 now requires JDK 1.8+
>   * Two more backward compatibility flags with 1.7: hyphens in
> identifiers and macros literal arguments handling
>   * New VTL syntax: default values for references: ${name|'John Doe'} -
> the right part can be any valid VTL expression
>   * New VTL syntax: empty loops block for #foreach directive:
> #foreach(...) ... #else ... #end
>   * Configuration keys refactoring (with backward compatibility handling)
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1027
>
> Documentation:
>
> * http://velocity.apache.org/engine/2.1/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
>
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>   [ ] Leave at test build
>   [ ] Alpha
>   [ ] Beta
>   [ ] General Availability (GA)
>
>--
>Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] Engine 2.1 RC3 Release quality

[Greg Huber]

Thanks for your effort, works great for me.

[x] General Availability (GA)

On Wed, 20 Mar 2019 at 00:43, Claude Brisson 
wrote:

> The Velocity Engine 2.1 RC3 is available since March 15.
>
> Main changes:
>
>   * Velocity Engine 2.1 now requires JDK 1.8+
>   * Two more backward compatibility flags with 1.7: hyphens in
> identifiers and macros literal arguments handling
>   * New VTL syntax: default values for references: ${name|'John Doe'} -
> the right part can be any valid VTL expression
>   * New VTL syntax: empty loops block for #foreach directive:
> #foreach(...) ... #else ... #end
>   * Configuration keys refactoring (with backward compatibility handling)
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1027
>
> Documentation:
>
> * http://velocity.apache.org/engine/2.1/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
>
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>   [ ] Leave at test build
>   [ ] Alpha
>   [ ] Beta
>   [ ] General Availability (GA)
>
>--
>Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available

[Greg Huber]

If I change in class org.apache.velocity.util.DeprecationAwareExtProperties

protected static Logger logger = LoggerFactory.getLogger("deprecation");

to
protected static Logger logger =
LoggerFactory.getLogger(DeprecationAwareExtProperties.class);

It now logs correctly:

2019-03-15 08:53:10,076 WARN
org.apache.velocity.util.DeprecationAwareExtProperties
DeprecationAwareExtProperties:warnDeprecated - configuration key '
my.resource.loader.public.name' has been deprecated in favor of '
resource.loader.my.public.name'

##
Don't have a log entry for "deprecation".
log4j2.xml




Can this be updated so it works without any changes?

Cheers Greg

On Thu, 14 Mar 2019 at 19:35, Claude Brisson 
wrote:

> Those logs are emitted quite early in the webapp initialization. So
> chances are the logger is initialized afterwards.
>
> If you are using the webapp-slf4j-logger to forwards slf4j logs towards
> tomcat, be sure to:
>
>   - use the latest version (1.4)
>
> - put this at the very beginning of your web.xml file:
>
>
> com.republicate.slf4j.impl.ServletContextLoggerListener
>
>
>
>
> so that the logger is initialized first.
>
> I'll document that.
>
> If that didn't work, did you check that there wasn't an older
> velocity-engine-core jar in the classpath?
>
> On 14/03/2019 17:42, Greg Huber wrote:
> > Tomcat logs (would be the most useful).  I know the logging works because
> > if there is an invalid #if I get a log message.
> >
> > On Thu, 14 Mar 2019 at 16:31, Claude Brisson  >
> > wrote:
> >
> >> I would say yes, since most test cases still use the deprecated
> properties.
> >>
> >> One of the test cases explicitly checks for the warning in the logs,
> >> which should be something like:
> >>
> >>   [warn] configuration key 'webapp.resource.loader.description' has
> >> been deprecated in favor of 'resource.loader.webapp.description'
> >>
> >> Which logs are you talking about? Yours or maven's? Most test cases logs
> >> aren't visible in maven output.
> >>
> >>
> >> Claude
> >>
> >> On 14/03/2019 10:56, Greg Huber wrote:
> >>> Is there any way to check if the depreciated properties logging is
> >>> working?  I would have thought I would see some messages in the logs:
> >>>
> >>> eg for my
> >>> resource.loader = webapp, 
> >>>
> >>> my 2.0:
> >>> webapp.resource.loader.description=Webapp Resource Loader
> >>>
> >>> 2.1 property name:
> >>> resource.loader..
> >>>
> >>> Cheers Greg
> >>>
> >>> On Mon, 11 Mar 2019 at 12:28, Claude Brisson
>  >>>
> >>> wrote:
> >>>
> >>>> The test build of Velocity Engine 2.1 RC2 is available.
> >>>>
> >>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> >>>> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a
> >>>> "test build". We welcome any comments you may have, and will take all
> >>>> feedback into account if a quality vote is called for this build.
> >>>>
> >>>> Release notes:
> >>>>
> >>>> *
> >>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
> >>>>
> >>>> Distribution:
> >>>>
> >>>> *
> >> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
> >>>> Maven 2 staging repository:
> >>>>
> >>>> *
> >>>>
> >>
> https://repository.apache.org/content/repositories/orgapachevelocity-1026/
> >>>> Documentation:
> >>>>
> >>>> * http://velocity.apache.org/engine/2.1/
> >>>>
> >>>> Sources:
> >>>>
> >>>> * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
> >>>>
> >>>>
> >>>>  --
> >>>>  Claude
> >>>>
> >>>>
> >>>>
> >>>> -
> >>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >>>> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>>>
> >>>>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available

[Greg Huber]

...logging..nightmare...I should already be logging with SLF4J, adding the
listener I now get in catalina.out and still no log messages.

SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in
[jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/log4j-slf4j-impl-2.11.2.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in
[jar:file:/home/ghuber/git/events/events/src/main/webapp/WEB-INF/lib/webapp-slf4j-logger-1.4.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an
explanation.
SLF4J: Actual binding is of type
[org.apache.logging.slf4j.Log4jLoggerFactory]

Looking at the source which class would be doing the depreciation logging?
I can check to see why its not logging.

On Thu, 14 Mar 2019 at 19:35, Claude Brisson 
wrote:

> Those logs are emitted quite early in the webapp initialization. So
> chances are the logger is initialized afterwards.
>
> If you are using the webapp-slf4j-logger to forwards slf4j logs towards
> tomcat, be sure to:
>
>   - use the latest version (1.4)
>
> - put this at the very beginning of your web.xml file:
>
>
> com.republicate.slf4j.impl.ServletContextLoggerListener
>
>
>
>
> so that the logger is initialized first.
>
> I'll document that.
>
> If that didn't work, did you check that there wasn't an older
> velocity-engine-core jar in the classpath?
>
> On 14/03/2019 17:42, Greg Huber wrote:
> > Tomcat logs (would be the most useful).  I know the logging works because
> > if there is an invalid #if I get a log message.
> >
> > On Thu, 14 Mar 2019 at 16:31, Claude Brisson  >
> > wrote:
> >
> >> I would say yes, since most test cases still use the deprecated
> properties.
> >>
> >> One of the test cases explicitly checks for the warning in the logs,
> >> which should be something like:
> >>
> >>   [warn] configuration key 'webapp.resource.loader.description' has
> >> been deprecated in favor of 'resource.loader.webapp.description'
> >>
> >> Which logs are you talking about? Yours or maven's? Most test cases logs
> >> aren't visible in maven output.
> >>
> >>
> >> Claude
> >>
> >> On 14/03/2019 10:56, Greg Huber wrote:
> >>> Is there any way to check if the depreciated properties logging is
> >>> working?  I would have thought I would see some messages in the logs:
> >>>
> >>> eg for my
> >>> resource.loader = webapp, 
> >>>
> >>> my 2.0:
> >>> webapp.resource.loader.description=Webapp Resource Loader
> >>>
> >>> 2.1 property name:
> >>> resource.loader..
> >>>
> >>> Cheers Greg
> >>>
> >>> On Mon, 11 Mar 2019 at 12:28, Claude Brisson
>  >>>
> >>> wrote:
> >>>
> >>>> The test build of Velocity Engine 2.1 RC2 is available.
> >>>>
> >>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> >>>> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a
> >>>> "test build". We welcome any comments you may have, and will take all
> >>>> feedback into account if a quality vote is called for this build.
> >>>>
> >>>> Release notes:
> >>>>
> >>>> *
> >>>>
> >>>>
> >>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
> >>>>
> >>>> Distribution:
> >>>>
> >>>> *
> >> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
> >>>> Maven 2 staging repository:
> >>>>
> >>>> *
> >>>>
> >>
> https://repository.apache.org/content/repositories/orgapachevelocity-1026/
> >>>> Documentation:
> >>>>
> >>>> * http://velocity.apache.org/engine/2.1/
> >>>>
> >>>> Sources:
> >>>>
> >>>> * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
> >>>>
> >>>>
> >>>>  --
> >>>>  Claude
> >>>>
> >>>>
> >>>>
> >>>> -
> >>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >>>> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>>>
> >>>>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available

[Greg Huber]

Tomcat logs (would be the most useful).  I know the logging works because
if there is an invalid #if I get a log message.

On Thu, 14 Mar 2019 at 16:31, Claude Brisson 
wrote:

> I would say yes, since most test cases still use the deprecated properties.
>
> One of the test cases explicitly checks for the warning in the logs,
> which should be something like:
>
>  [warn] configuration key 'webapp.resource.loader.description' has
> been deprecated in favor of 'resource.loader.webapp.description'
>
> Which logs are you talking about? Yours or maven's? Most test cases logs
> aren't visible in maven output.
>
>
>    Claude
>
> On 14/03/2019 10:56, Greg Huber wrote:
> > Is there any way to check if the depreciated properties logging is
> > working?  I would have thought I would see some messages in the logs:
> >
> > eg for my
> > resource.loader = webapp, 
> >
> > my 2.0:
> > webapp.resource.loader.description=Webapp Resource Loader
> >
> > 2.1 property name:
> > resource.loader..
> >
> > Cheers Greg
> >
> > On Mon, 11 Mar 2019 at 12:28, Claude Brisson  >
> > wrote:
> >
> >> The test build of Velocity Engine 2.1 RC2 is available.
> >>
> >> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> >> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a
> >> "test build". We welcome any comments you may have, and will take all
> >> feedback into account if a quality vote is called for this build.
> >>
> >> Release notes:
> >>
> >> *
> >>
> >>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
> >>
> >>
> >> Distribution:
> >>
> >>*
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
> >>
> >> Maven 2 staging repository:
> >>
> >>*
> >>
> https://repository.apache.org/content/repositories/orgapachevelocity-1026/
> >>
> >> Documentation:
> >>
> >> * http://velocity.apache.org/engine/2.1/
> >>
> >> Sources:
> >>
> >>* https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
> >>
> >>
> >> --
> >> Claude
> >>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> >> For additional commands, e-mail: dev-h...@velocity.apache.org
> >>
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.1 RC2 test build available

[Greg Huber]

Is there any way to check if the depreciated properties logging is
working?  I would have thought I would see some messages in the logs:

eg for my
resource.loader = webapp, 

my 2.0:
webapp.resource.loader.description=Webapp Resource Loader

2.1 property name:
resource.loader..

Cheers Greg

On Mon, 11 Mar 2019 at 12:28, Claude Brisson 
wrote:

> The test build of Velocity Engine 2.1 RC2 is available.
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
> Velocity Engine 2.1 RC2 has been made, and at this time it is simply a
> "test build". We welcome any comments you may have, and will take all
> feedback into account if a quality vote is called for this build.
>
> Release notes:
>
> *
>
> https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/release-notes.html
>
>
> Distribution:
>
>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.1/
>
> Maven 2 staging repository:
>
>   *
> https://repository.apache.org/content/repositories/orgapachevelocity-1026/
>
> Documentation:
>
> * http://velocity.apache.org/engine/2.1/
>
> Sources:
>
>   * https://svn.apache.org/repos/asf/velocity/engine/tags/2.1/
>
>
>--
>Claude
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [jira] [Resolved] (VELTOOLS-169) Upgrade commons-collections compile dependency to v3.2.2 or v4.1

[Greg Huber]

Claude,

Thanks for the updates, btw the depreciated TexenTask also uses the
ExtendedProperties, I tried to use the o.a.v.util.ExtProperties suggested
here, but it does not work for some reason, I switched to
org.apache.commons.configuration2.PropertiesConfiguration which does work.

its basically just a swap with method .load changed to .read

File fullPath = getProject().resolveFile(sources[i]);

// ExtendedProperties source = new ExtendedProperties();
PropertiesConfiguration source = new PropertiesConfiguration();

// source.load(new FileInputStream(fullPath));
source.read(new FileReader((fullPath)));


org.apache.commons
commons-configuration2
2.2


Cheers Greg

On 24 June 2018 at 02:36, Claude Brisson (JIRA) 
wrote:

>
>  [ https://issues.apache.org/jira/browse/VELTOOLS-169?page=
> com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Claude Brisson resolved VELTOOLS-169.
> -
>Resolution: Fixed
>  Assignee: Claude Brisson
> Fix Version/s: 3.0
>
> trunk got rid of commons-collections by replacing ExtendedProperties by
> o.a.v.util.ExtProperties
>
> > Upgrade commons-collections compile dependency to v3.2.2 or v4.1
> > 
> >
> > Key: VELTOOLS-169
> > URL: https://issues.apache.org/jira/browse/VELTOOLS-169
> > Project: Velocity Tools
> >  Issue Type: Bug
> >  Components: Build
> >Affects Versions: 2.0
> >Reporter: Mark Symons
> >Assignee: Claude Brisson
> >Priority: Critical
> > Fix For: 3.0
> >
> >
> > Upgrade commons-collections to v3.2.2 or v4.1 or later to mitigate level
> 9 threat.
> > Old name: commons-collections:commons-collections
> > Current name: org.apache.commons:commons-collections4
> > Velocity Tools v2.0 uses commons-collections:commons-collections v3.2
> > commons-collections4 v4.1 includes the critical security fix
> COLLECTIONS-580.  Quoting from v4.1 release notes:
> > {quote}
> > Serialization support for unsafe classes in the functor package has been
> removed completely as this can be exploited for remote code execution
> attacks. Classes considered to be unsafe are:
> > CloneTransformer
> > ForClosure
> > InstantiateFactory
> > InstantiateTransformer
> > InvokerTransformer
> > PrototypeCloneFactory
> > PrototypeSerializationFactory
> > WhileClosure.
> > {quote}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [jira] [Commented] (VELOCITY-891) Upgrade to v2.0 causes parser failures

[Greg Huber]

Have you tried

{{#set ($JQId = '#' + $Utils.getJQuerySelector($SparklineElementId))}}

eg

#set ($ok = '#' + 'ok')

$ok then outputs #ok



#set ($ok = "#" + 'ok')

gives
Failed to parse String literal at
2f336dfc-5fee-4e00-a58d-1b5a54729690:standard[line 1, column 13]
org.apache.velocity.exception.ParseErrorException



On 30 May 2018 at 15:09, Steve O'Hara (JIRA)  wrote:

>
> [ https://issues.apache.org/jira/browse/VELOCITY-891?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=16495207#comment-16495207 ]
>
> Steve O'Hara commented on VELOCITY-891:
> ---
>
> Added the stack trace to the description.
>
> > Upgrade to v2.0 causes parser failures
> > --
> >
> > Key: VELOCITY-891
> > URL: https://issues.apache.org/jira/browse/VELOCITY-891
> > Project: Velocity
> >  Issue Type: Bug
> >  Components: Engine
> >Affects Versions: 2.0
> >Reporter: Steve O'Hara
> >Priority: Major
> >
> > We are upgrading from v1.7 to v2.0 but have come across a problem almost
> immediately.
> > Our templates can contain a lot of Javascript with references to things
> that begin with the '#' character e.g. Kendo JS templates. These used to be
> ignored by 1.7 but now they are causing parser failures as follows;
> > {{#set ($JQId = "#" + $Utils.getJQuerySelector($SparklineElementId))}}
> > {{org.apache.velocity.exception.ParseErrorException: Failed to parse
> String literal}}
> > It is complaining about the {{"#"}}
> > I can't find any directive that switches this off or a way to circumvent
> it.
> > A workaround is to replace the '#' with {{$HASH}} but we have thousands
> of these and no way of fixing the end-user commited templates.
> > {code:java}
> > 2018-05-30 15:07:30 ERROR context.ContextLoader - Context initialization
> failed
> > org.springframework.beans.factory.BeanCreationException: Error creating
> bean with name 'velocityConfig' defined in ServletContext resource
> [/WEB-INF/applicationContext.xml]: Invocation of init method failed;
> nested exception is org.apache.velocity.exception.VelocityException:
> Velocimacro: Error using VM library: ../macros/macros-forms.vm
> >   at org.springframework.beans.factory.support.
> AbstractAutowireCapableBeanFactory.initializeBean(
> AbstractAutowireCapableBeanFactory.java:1514)
> >   at org.springframework.beans.factory.support.
> AbstractAutowireCapableBeanFactory.doCreateBean(
> AbstractAutowireCapableBeanFactory.java:519)
> >   at org.springframework.beans.factory.support.
> AbstractAutowireCapableBeanFactory.createBean(
> AbstractAutowireCapableBeanFactory.java:456)
> >   at org.springframework.beans.factory.support.
> AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:293)
> >   at org.springframework.beans.factory.support.
> DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.
> java:223)
> >   at org.springframework.beans.factory.support.
> AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:290)
> >   at org.springframework.beans.factory.support.
> AbstractBeanFactory.getBean(AbstractBeanFactory.java:191)
> >   at org.springframework.beans.factory.support.
> DefaultListableBeanFactory.preInstantiateSingletons(
> DefaultListableBeanFactory.java:638)
> >   at org.springframework.context.support.AbstractApplicationContext.
> finishBeanFactoryInitialization(AbstractApplicationContext.java:942)
> >   at org.springframework.context.support.AbstractApplicationContext.
> refresh(AbstractApplicationContext.java:482)
> >   at org.springframework.web.context.ContextLoader.
> configureAndRefreshWebApplicationContext(ContextLoader.java:410)
> >   at org.springframework.web.context.ContextLoader.
> initWebApplicationContext(ContextLoader.java:306)
> >   at org.springframework.web.context.ContextLoaderListener.
> contextInitialized(ContextLoaderListener.java:112)
> >   at com._4ng.web.servlet.Initialisation.contextInitialized(
> Initialisation.java:175)
> >   at org.apache.catalina.core.StandardContext.listenerStart(
> StandardContext.java:4745)
> >   at org.apache.catalina.core.StandardContext.startInternal(
> StandardContext.java:5207)
> >   at org.apache.catalina.util.LifecycleBase.start(
> LifecycleBase.java:150)
> > 30-May-2018 15:07:30.618 SEVERE [null Initialisation]
> org.apache.catalina.core.StandardContext.startInternal One or more
> listeners failed to start. Full details will be found in the appropriate
> container log file
> >   at org.apache.catalina.core.ContainerBase.addChildInternal(
> ContainerBase.java:752)
> > 30-May-2018 15:07:30.621 SEVERE [null Initialisation]
> org.apache.catalina.core.StandardContext.startInternal Context [] startup
> failed due to previous errors
> >   at org.apache.catalina.core.ContainerBase.addChild(
> ContainerBase.java:728)
> >   at 

Re: [VOTE] Engine 2.0 RC9 Release quality

[Greg Huber]

Works great for me.  Thanks.

[x] General Availability (GA)

On 29 July 2017 at 00:00, Claude Brisson  wrote:

> The Velocity Engine 2.0 RC9 is available.
>
> Main change since the RC8 is a full review of the DataSourceResourceLoader.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1020
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>  [ ] Leave at test build
>  [ ] Alpha
>  [ ] Beta
>  [ ] General Availability (GA)
>
>   Claude
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [RESULT] [VOTE] Engine 2.0 RC8 Release quality

[Greg Huber]

Maybe bump commons-lang3 to 3.6?  Just released in June.

Cheers Greg

On 18 June 2017 at 22:13, Claude Brisson  wrote:

> I should be able to find the time, yes.
>
>   Claude
>
>
> On 18/06/2017 10:46, Michael Osipov wrote:
>
>> Am 2017-06-17 um 11:46 schrieb Claude Brisson:
>>
>>> Result:
>>>
>>> Two binding votes and two non-binding votes for GA.
>>>
>>> While at least two PMCs did express their will to vote, a user raised an
>>> issue about the DataSourceResourceLoader [1] before they do so.
>>>
>>> So let's hit the road again for another RC.
>>>
>>>   Claude
>>>
>>> [1] https://issues.apache.org/jira/browse/VELOCITY-880
>>>
>>
>> Salut Claude,
>>
>> unfortunately I wasn't able to perform any tests and I won't have access
>> to those database instances before the end of the month. Were you able to
>> test anything?
>>
>> Michael
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [VOTE] Engine 2.0 RC8 Release quality

[Greg Huber]

 Works well for me.  Thanks.

 [ ] Leave at test build
 [ ] Alpha
 [ ] Beta
 [x] General Availability (GA)

+1 (nb)

On 1 May 2017 at 17:50, Claude Brisson  wrote:

> The Velocity Engine 2.0 RC8 is available.
>
> Main change since the RC6 is a rewrite of the methods disambiguation
> algorithm. RC7 needed a bugfix and didn't reach the vote.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1019
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>  [ ] Leave at test build
>  [ ] Alpha
>  [ ] Beta
>  [ ] General Availability (GA)
>
>
> Everyone who has tested the build is invited to vote. Votes by PMC members
> are considered binding. A vote passes if there are at least three binding
> +1s and more +1s than -1s.
>
>
>
>   Claude
>
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC8 test build available

[Greg Huber]

Great thanks.  The generated source looks correct.

Cheers Greg

On 27 April 2017 at 14:44, Claude Brisson <cla...@renegat.net> wrote:

> Glad to hear it's a feature, not a bug...
>
> Almost all methods. org.apache.velocity.util.StringUtils now only
> contains several variants of the formatFileString() method, which should
> not be used by Texe.
>
> On 27/04/2017 14:40, Greg Huber wrote:
>
>> Claude,
>>
>> I think I have managed to resolve it.  Most of the methods in
>> org.apache.velocity.util.StringUtils have been removed. Which texen
>> relies
>> on for parsing the vm files via the context.
>>
>> I updated the texen.properties variable to use the commons StringUtils
>> instead.
>>
>> ie
>>
>> #context.objects.strings=org.apache.velocity.util.StringUtils
>> context.objects.strings=org.apache.commons.lang3.StringUtils
>>
>> So far it looks OK.  Were all of the string methods replaced by the
>> commons
>> version?
>>
>> Cheers Greg
>>
>>
>> On 27 April 2017 at 13:29, Claude Brisson <cla...@renegat.net> wrote:
>>
>> Thanks.
>>>
>>> The old release candidate builds are available from the development
>>> distribution svn history.
>>>
>>> You can get the revision for a specific RC with:
>>>
>>>  svn log https://dist.apache.org/repos/
>>> dist/dev/velocity/velocity-eng
>>> ine/2.0
>>>
>>> and then, you would typically download a specific RC with:
>>>
>>>  svn export https://dist.apache.org/repos/
>>> dist/dev/velocity/velocity-engine/2.0/velocity-engine-core-2.0.jar@19088
>>>
>>> here, for instance, 19088 corresponds to the RC7.
>>>
>>>
>>> On 27/04/2017 12:31, Greg Huber wrote:
>>>
>>> Well, I found a version dated 16th November 2016, which does work so its
>>>> not my setup.
>>>>
>>>> Will try and debug the ant process for any errors.
>>>>
>>>> On 14 April 2017 at 11:41, Claude Brisson <cla...@renegat.net> wrote:
>>>>
>>>> A new test build of Velocity Engine 2.0 is available (RC8).
>>>>
>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>>> Velocity
>>>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>>>> We
>>>>> welcome any comments you may have, and will take all feedback into
>>>>> account
>>>>> if a quality vote is called for this build.
>>>>>
>>>>> Release notes:
>>>>>
>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>> ine/2.0/release-notes.html
>>>>>
>>>>> Distribution:
>>>>>
>>>>>* https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>> ine/2.0/
>>>>>
>>>>> Maven 2 staging repository:
>>>>>
>>>>>* https://repository.apache.org/content/repositories/orgapache
>>>>> velocity-1019/
>>>>>
>>>>> A vote regarding the quality of this test build will be initiated
>>>>> within
>>>>> the next couple of days.
>>>>>
>>>>> Release Candidates changelog:
>>>>>
>>>>> RC1: initial candidate
>>>>> RC2: bugfixes
>>>>> RC3: review SLF4J Logger names (instead of a single logger named
>>>>> "Velocity", have a hierarchy of loggers with a base of
>>>>> 'org.apache.velocity')
>>>>> RC4: minor fixes
>>>>> RC5:
>>>>>  * the default encoding is now UTF-8 (and not the platform default)
>>>>>  * commons-collections is not any more a compilation dependency
>>>>>  * commons-lang3 dependency is not any more shaded
>>>>>  * the configuration API doesn't reference ExtProperties
>>>>>  * the events API has been optimized and reviewed: all events do
>>>>> receive
>>>>> the current Context
>>>>>  * there has been a few optimizations in ASTStringLiteral rendering
>>>>> RC6: mostly code cleaning and build process optimization ; assembly
>>>>> module has been dropped
>>>>> RC7: still a lot of core cleanups and reviews, plus:
>>>>>  * new strategy for reference boolean evaluation
>>>>>  * allow expressions inside [ ] : $foo[$bar + 1]
>>>>> RC8: vararg methods bugfix
>>>>>
>>>>> Regards,
>>>>>
>>>>> Claude
>>>>>
>>>>>
>>>>> -
>>>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>>>
>>>>>
>>>>>
>>>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>
>>>
>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC8 test build available

[Greg Huber]

Claude,

I think I have managed to resolve it.  Most of the methods in
org.apache.velocity.util.StringUtils have been removed. Which texen relies
on for parsing the vm files via the context.

I updated the texen.properties variable to use the commons StringUtils
instead.

ie

#context.objects.strings=org.apache.velocity.util.StringUtils
context.objects.strings=org.apache.commons.lang3.StringUtils

So far it looks OK.  Were all of the string methods replaced by the commons
version?

Cheers Greg


On 27 April 2017 at 13:29, Claude Brisson <cla...@renegat.net> wrote:

> Thanks.
>
> The old release candidate builds are available from the development
> distribution svn history.
>
> You can get the revision for a specific RC with:
>
> svn log https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0
>
> and then, you would typically download a specific RC with:
>
> svn export https://dist.apache.org/repos/
> dist/dev/velocity/velocity-engine/2.0/velocity-engine-core-2.0.jar@19088
>
> here, for instance, 19088 corresponds to the RC7.
>
>
> On 27/04/2017 12:31, Greg Huber wrote:
>
>> Well, I found a version dated 16th November 2016, which does work so its
>> not my setup.
>>
>> Will try and debug the ant process for any errors.
>>
>> On 14 April 2017 at 11:41, Claude Brisson <cla...@renegat.net> wrote:
>>
>> A new test build of Velocity Engine 2.0 is available (RC8).
>>>
>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>> We
>>> welcome any comments you may have, and will take all feedback into
>>> account
>>> if a quality vote is called for this build.
>>>
>>> Release notes:
>>>
>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>> ine/2.0/release-notes.html
>>>
>>> Distribution:
>>>
>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>>>
>>> Maven 2 staging repository:
>>>
>>>   * https://repository.apache.org/content/repositories/orgapache
>>> velocity-1019/
>>>
>>> A vote regarding the quality of this test build will be initiated within
>>> the next couple of days.
>>>
>>> Release Candidates changelog:
>>>
>>>RC1: initial candidate
>>>RC2: bugfixes
>>>RC3: review SLF4J Logger names (instead of a single logger named
>>> "Velocity", have a hierarchy of loggers with a base of
>>> 'org.apache.velocity')
>>>RC4: minor fixes
>>>RC5:
>>> * the default encoding is now UTF-8 (and not the platform default)
>>> * commons-collections is not any more a compilation dependency
>>> * commons-lang3 dependency is not any more shaded
>>> * the configuration API doesn't reference ExtProperties
>>> * the events API has been optimized and reviewed: all events do
>>> receive
>>> the current Context
>>> * there has been a few optimizations in ASTStringLiteral rendering
>>>RC6: mostly code cleaning and build process optimization ; assembly
>>> module has been dropped
>>>RC7: still a lot of core cleanups and reviews, plus:
>>> * new strategy for reference boolean evaluation
>>> * allow expressions inside [ ] : $foo[$bar + 1]
>>>RC8: vararg methods bugfix
>>>
>>> Regards,
>>>
>>>Claude
>>>
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>
>>>
>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC8 test build available

[Greg Huber]

Well, I found a version dated 16th November 2016, which does work so its
not my setup.

Will try and debug the ant process for any errors.

On 14 April 2017 at 11:41, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC8).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1019/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
>   RC6: mostly code cleaning and build process optimization ; assembly
> module has been dropped
>   RC7: still a lot of core cleanups and reviews, plus:
>* new strategy for reference boolean evaluation
>* allow expressions inside [ ] : $foo[$bar + 1]
>   RC8: vararg methods bugfix
>
> Regards,
>
>   Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC8 test build available

[Greg Huber]

I have noticed now that my bespoke taxen generator does not produce any
output.  Also there are no errors generated.

Is it possible to back to previous snapshots (rc1) to see if the problem
exists?

There seems to be only the lasted release in the repo.

https://repository.apache.org/content/repositories/orgapachevelocity-/

Cheers Greg

On 14 April 2017 at 11:41, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC8).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1019/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
>   RC6: mostly code cleaning and build process optimization ; assembly
> module has been dropped
>   RC7: still a lot of core cleanups and reviews, plus:
>* new strategy for reference boolean evaluation
>* allow expressions inside [ ] : $foo[$bar + 1]
>   RC8: vararg methods bugfix
>
> Regards,
>
>   Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC8 test build available

[Greg Huber]

Works great for me +1.

Cheers Greg

On 14 April 2017 at 11:41, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC8).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1019/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
>   RC6: mostly code cleaning and build process optimization ; assembly
> module has been dropped
>   RC7: still a lot of core cleanups and reviews, plus:
>* new strategy for reference boolean evaluation
>* allow expressions inside [ ] : $foo[$bar + 1]
>   RC8: vararg methods bugfix
>
> Regards,
>
>   Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC7 test build available

[Greg Huber]

Works well for me.  Thanks.

On 9 April 2017 at 00:19, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC7).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1018/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
>   RC6: mostly code cleaning and build process optimization ; assembly
> module has been dropped
>   RC7: still a lot of core cleanups and reviews, plus:
>* new strategy for reference boolean evaluation
>* allow expressions inside [ ] : $foo[$bar + 1]
>
>
> Regards,
>
>   Claude
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC6 test build available

[Greg Huber]

Ahh java, now seems so many different ways of doing the same thing
Just importing a file, I also have standard utils.

The path is the tricky one now, without testing it.

value = FileUtils.readFileToString(new File(
getProject().resolveFile(value)
.getCanonicalPath()),
UTF_8);

Path thePath = FileSystems.getDefault().getPath(
getProject().resolveFile(value)
.getCanonicalPath());

value = new String(Files.readAllBytes(thePath),
StandardCharsets.UTF_8);



On 26 January 2017 at 15:48, Claude Brisson <cla...@renegat.net> wrote:

> Oh, and Michael Osipov suggested a much easier way:
>
> import java.nio.Files;
> import java.nio.charset.StandardCharsets;
> 
> String contents = new String(Files.readAllBytes(path),
> StandardCharsets.UTF_8);
>
>
>   Claude
>
> On 26/01/2017 15:42, Claude Brisson wrote:
>
>> Hi Greg.
>>
>> Just include the commons-io library [1], then do:
>>
>> import org.apache.commons.io.FileUtils;
>> 
>> String content = FiileUtils.readFileToString(new File(filename),
>> Charset.UTF_8);
>>
>> The charset parameter is optional but recommended. Adapt it to your
>> needs, of course.
>>
>> [1] https://mvnrepository.com/artifact/commons-io/commons-io/2.5
>>
>>
>>   Claude
>>
>> On 26/01/2017 14:52, Greg Huber wrote:
>>
>>> Hello,
>>>
>>> I use the taxen task, and now have a local copy as its no longer
>>> supported.
>>>
>>> What would be an equivalent to .fileContentsToString(..) as its now
>>> missing?
>>>
>>> org.apache.velocity.util.StringUtils
>>>
>>> value = StringUtils.fileContentsToString(
>>> getProject().resolveFile(value)
>>> .getCanonicalPath());
>>>
>>> Cheers Greg
>>>
>>>
>>>
>>> On 26 January 2017 at 03:39, Claude Brisson <cla...@renegat.net> wrote:
>>>
>>> A new test build of Velocity Engine 2.0 is available (RC6).
>>>>
>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>> Velocity
>>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>>> We
>>>> welcome any comments you may have, and will take all feedback into
>>>> account
>>>> if a quality vote is called for this build.
>>>>
>>>> Release notes:
>>>>
>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/release-notes.html
>>>>
>>>> Distribution:
>>>>
>>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/
>>>>
>>>> Maven 2 staging repository:
>>>>
>>>>   * https://repository.apache.org/content/repositories/orgapache
>>>> velocity-1016/
>>>>
>>>> A vote regarding the quality of this test build will be initiated within
>>>> the next couple of days.
>>>>
>>>> Release Candidates changelog:
>>>>RC1: initial candidate
>>>>RC2: bugfixes
>>>>RC3: review SLF4J Logger names (instead of a single logger named
>>>> "Velocity", have a hierarchy of loggers with a base of
>>>> 'org.apache.velocity')
>>>>RC4: minor fixes
>>>>RC5:
>>>> * the default encoding is now UTF-8 (and not the platform default)
>>>> * commons-collections is not any more a compilation dependency
>>>> * commons-lang3 dependency is not any more shaded
>>>> * the configuration API doesn't reference ExtProperties
>>>> * the events API has been optimized and reviewed: all events do
>>>> receive
>>>> the current Context
>>>> * there has been a few optimizations in ASTStringLiteral rendering
>>>> RC6: mostly code cleaning and build process optimization ; assembly
>>>> module
>>>> has been dropped
>>>>
>>>>
>>>> Regards,
>>>>
>>>>Claude
>>>>
>>>>
>>>>
>>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 RC6 test build available

[Greg Huber]

Hello,

I use the taxen task, and now have a local copy as its no longer supported.

What would be an equivalent to .fileContentsToString(..) as its now missing?

org.apache.velocity.util.StringUtils

value = StringUtils.fileContentsToString(
getProject().resolveFile(value)
.getCanonicalPath());

Cheers Greg



On 26 January 2017 at 03:39, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC6).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1016/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
> RC6: mostly code cleaning and build process optimization ; assembly module
> has been dropped
>
>
> Regards,
>
>   Claude
>
>
>

Re: [VOTE] Engine 2.0 RC5 Release quality

[Greg Huber]

[ ] Leave at test build
[ ] Alpha
[ ] Beta
[x] General Availability (GA)

+1 works great for me.  Thanks.

On 16 January 2017 at 14:02, Claude Brisson  wrote:

> The Velocity Engine 2.0 RC5 is available.
>
> Main changes since the RC4:
>
>  * the default encoding is now UTF-8 (and not the platform default)
>  * commons-collections is not any more a compilation dependency
>  * commons-lang3 dependency is not any more shaded
>  * the configuration API doesn't use ExtProperties anymore
>  * the events API has been reviewed: all events do receive the current
> Context as argument
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1015
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>  [ ] Leave at test build
>  [ ] Alpha
>  [ ] Beta
>  [ ] General Availability (GA)
>
>
> Everyone who has tested the build is invited to vote. Votes by PMC members
> are considered binding. A vote passes if there are at least three binding
> +1s and more +1s than -1s.
>
>
>
>   Claude
>
>
>

Re: Reloading resources adding new macros

[Greg Huber]

After some more testing it does reload, except it does not remove the old
macro names and methods.  I guess it does not store where the macros
originated, so it appends new ones?  I cannot remember the exact reason why
I started stopping & restarting, maybe I was changing the signature and it
was not picking up the correct version.

I should have checked it more before asking the question.

Cheers Greg

On 5 January 2017 at 16:28, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Greg,
>
> On 1/4/17 11:40 AM, Greg Huber wrote:
> >> Velocity version?
> >
> > The latest version ie 2.0.
> >
> >> When you say you "shut down the container (tomcat)", >can you be more
> > specific? Do you bounce the >application, or do you >terminate Tomcat and
> > the JVM, >etc.?
> >
> > Terminate tomcat shutdown.sh and then restart it.
>
> If you terminate the JVM and the new instance doesn't pick up your
> changes, then something is terribly wrong. You must be loading files
> from a place you didn't expect, or something similar.
>
> >> Did you write your own WebappResourceLoader (and if >so, why)?
> >
> > Its a bit application so I do have my own version.
> >
> > I did read on a list that it was an issue.  Think Nathan
> > answered the post???
> >
> > Maybe I have missed something in the code?
> >
> >
> > public class WebappResourceLoader extends ResourceLoader {
>
> Why not use the WebappResourceLoader provided by Velocity Tools?
>
> -chris
>
>

Re: Reloading resources adding new macros

[Greg Huber]

.it does not remove macros names, will keep this in mind next time I do
template work and work out exactly why I need to restart (if I still have
to do it at all).

Cheers Greg

On 4 January 2017 at 17:34, Michael Osipov <micha...@apache.org> wrote:

> Am 2017-01-04 um 14:43 schrieb Greg Huber:
>
>> The was one issue that has been around for ages, and I am not sure if it
>> is
>> possible to fix it.
>>
>> If I have added a new macro into a velocity template file loaded via a
>> resource loader, I have to shut down the container (tomcat) and restart
>> for
>> it to be picked up.  I will allow the contents of the macro to be changed
>> but not a new macro.  I did try to see if I could fix it but without much
>> success.
>>
>> my velocity.properties :
>> ..
>> webapp.resource.loader.description=Webapp Resource Loader
>> webapp.resource.loader.class=rendering.velocity.WebappResourceLoader
>> webapp.resource.loader.cache=true
>> webapp.resource.loader.path=/WEB-INF/velocity,/WEB-INF/veloc
>> ity/templates,/WEB-INF/velocity/templates/feeds,/WEB-INF/
>> velocity/templates/emails
>> ...
>>
>> If you are now familiar with the code you might be in a better position to
>> see why I have to shut down for it to be picked up.
>>
>
> This could be your issue: http://stackoverflow.com/a/8656527/696632
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: Reloading resources adding new macros

[Greg Huber]

Sorry, I have looked at this again and it does now reload correctly with
the new macros without the restart.  Please ignore my previous emails!!

Cheers Greg.

On 4 January 2017 at 17:34, Michael Osipov <micha...@apache.org> wrote:

> Am 2017-01-04 um 14:43 schrieb Greg Huber:
>
>> The was one issue that has been around for ages, and I am not sure if it
>> is
>> possible to fix it.
>>
>> If I have added a new macro into a velocity template file loaded via a
>> resource loader, I have to shut down the container (tomcat) and restart
>> for
>> it to be picked up.  I will allow the contents of the macro to be changed
>> but not a new macro.  I did try to see if I could fix it but without much
>> success.
>>
>> my velocity.properties :
>> ..
>> webapp.resource.loader.description=Webapp Resource Loader
>> webapp.resource.loader.class=rendering.velocity.WebappResourceLoader
>> webapp.resource.loader.cache=true
>> webapp.resource.loader.path=/WEB-INF/velocity,/WEB-INF/veloc
>> ity/templates,/WEB-INF/velocity/templates/feeds,/WEB-INF/
>> velocity/templates/emails
>> ...
>>
>> If you are now familiar with the code you might be in a better position to
>> see why I have to shut down for it to be picked up.
>>
>
> This could be your issue: http://stackoverflow.com/a/8656527/696632
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: Reloading resources adding new macros

[Greg Huber]

If someone could point me in the right direction on where it reloads the
macro names in the code, I could have a look myself at fixing it.

Cheer Greg

On 4 January 2017 at 17:34, Michael Osipov <micha...@apache.org> wrote:

> Am 2017-01-04 um 14:43 schrieb Greg Huber:
>
>> The was one issue that has been around for ages, and I am not sure if it
>> is
>> possible to fix it.
>>
>> If I have added a new macro into a velocity template file loaded via a
>> resource loader, I have to shut down the container (tomcat) and restart
>> for
>> it to be picked up.  I will allow the contents of the macro to be changed
>> but not a new macro.  I did try to see if I could fix it but without much
>> success.
>>
>> my velocity.properties :
>> ..
>> webapp.resource.loader.description=Webapp Resource Loader
>> webapp.resource.loader.class=rendering.velocity.WebappResourceLoader
>> webapp.resource.loader.cache=true
>> webapp.resource.loader.path=/WEB-INF/velocity,/WEB-INF/veloc
>> ity/templates,/WEB-INF/velocity/templates/feeds,/WEB-INF/
>> velocity/templates/emails
>> ...
>>
>> If you are now familiar with the code you might be in a better position to
>> see why I have to shut down for it to be picked up.
>>
>
> This could be your issue: http://stackoverflow.com/a/8656527/696632
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: Reloading resources adding new macros

[Greg Huber]

>This could be your issue: http://stackoverflow.com/a/8656527/696632

It picks up the changes to the contents of the template macros ok, so its
unlikely to be the tomcat cache.  It won't pick up the new macros.  I
though it might be a list/array that stores the names that needs to be
cleared/reset when the macro is reloaded, but it looked much more
complicated.

Cheers Greg

On 4 January 2017 at 17:34, Michael Osipov <micha...@apache.org> wrote:

> Am 2017-01-04 um 14:43 schrieb Greg Huber:
>
>> The was one issue that has been around for ages, and I am not sure if it
>> is
>> possible to fix it.
>>
>> If I have added a new macro into a velocity template file loaded via a
>> resource loader, I have to shut down the container (tomcat) and restart
>> for
>> it to be picked up.  I will allow the contents of the macro to be changed
>> but not a new macro.  I did try to see if I could fix it but without much
>> success.
>>
>> my velocity.properties :
>> ..
>> webapp.resource.loader.description=Webapp Resource Loader
>> webapp.resource.loader.class=rendering.velocity.WebappResourceLoader
>> webapp.resource.loader.cache=true
>> webapp.resource.loader.path=/WEB-INF/velocity,/WEB-INF/veloc
>> ity/templates,/WEB-INF/velocity/templates/feeds,/WEB-INF/
>> velocity/templates/emails
>> ...
>>
>> If you are now familiar with the code you might be in a better position to
>> see why I have to shut down for it to be picked up.
>>
>
> This could be your issue: http://stackoverflow.com/a/8656527/696632
>
> Michael
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: Reloading resources adding new macros

[Greg Huber]

(NullPointerException npe) {
// no servletContext was set, whine about it!
throw npe;
} catch (Exception e) {
// only save the first one for later throwing
if (exception == null) {
if (log.isDebugEnabled()) {
log.debug("WebappResourceLoader: Could not load
"
+ path, e);
}
exception = e;
}
}
}
}

// If we never found the template
if (result == null) {
String msg = "WebappResourceLoader: Resource '" + name
+ "' not found on class path.";

// convert to a general Velocity ResourceNotFoundException
if (exception == null) {
throw new ResourceNotFoundException(msg);
} else {
msg += "  Due to: " + exception;
throw new ResourceNotFoundException(msg, exception);
}
}

return new BufferedReader(new InputStreamReader(result));
}

/**
 * Gets the cached file.
 *
 * @param rootPath
 *the root path
 * @param fileName
 *the file name
 *
 * @return the cached file
 */
private File getCachedFile(String rootPath, String fileName) {

// We do this when we cache a resource, so do it again to ensure a
match
while (fileName.startsWith("/")) {
fileName = fileName.substring(1);
}

String savedPath = (String) templatePaths.get(fileName);

// names are :
// loading events_macros.vm etc will not have the type so only
check for
// one.
String[] split = fileName.split(":", 2);
return new File(rootPath + savedPath, split[0]);

}

/**
 * Checks to see if a resource has been deleted, moved or modified. When
 * using the resource.loader.cache=true option
 *
 * @param resource
 *Resource The resource to check for modification
 *
 * @return boolean True if the resource has been modified
 */
public boolean isSourceModified(Resource resource) {

String rootPath = servletContext.getRealPath("/");
if (rootPath == null) {
// RootPath is null if the servlet container cannot translate
the
// virtual path to a real path for any reason (such as when the
// content is being made available from a .war archive)
return false;
}

// first, try getting the previously found file
String fileName = resource.getName();
File cachedFile = getCachedFile(rootPath, fileName);
if (!cachedFile.exists()) {
// then the source has been moved and/or deleted
return true;
}

/*
 * Check to see if the file can now be found elsewhere before it is
 * found in the previously saved path
 */
File currentFile = null;
for (int i = 0; i < paths.length; i++) {
currentFile = new File(rootPath + paths[i], fileName);
if (currentFile.canRead()) {
// stop at the first resource found (just like in
// getResourceStream())
break;
}
}

// If the current is the cached and it is readable
if (cachedFile.equals(currentFile) && cachedFile.canRead()) {
// then (and only then) do we compare the last modified values
return (cachedFile.lastModified() !=
resource.getLastModified());
} else {
// We found a new file for the resource or the resource is no
longer
// readable.
return true;
}
}

/**
 * Checks to see when a resource was last modified
 *
 * @param resource
 *Resource the resource to check
 *
 * @return long The time when the resource was last modified or 0 if the
 * file can't be read
 */
public long getLastModified(Resource resource) {

String rootPath = servletContext.getRealPath("/");
if (rootPath == null) {
// RootPath is null if the servlet container cannot translate
the
// virtual path to a real path for any reason (such as when the
// content is being made available from a .war archive)
return 0;
}

File cachedFile = getCachedFile(rootPath, resource.getName());
if (cachedFile.canRead()) {
return cachedFile.lastModified();
} else {
return 0;
}

}

}

On 4 January 2017 at 16:04, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Greg,
>
> On 1/4/17 8:43 AM, Greg Hub

Reloading resources adding new macros

[Greg Huber]

The was one issue that has been around for ages, and I am not sure if it is
possible to fix it.

If I have added a new macro into a velocity template file loaded via a
resource loader, I have to shut down the container (tomcat) and restart for
it to be picked up.  I will allow the contents of the macro to be changed
but not a new macro.  I did try to see if I could fix it but without much
success.

my velocity.properties :
..
webapp.resource.loader.description=Webapp Resource Loader
webapp.resource.loader.class=rendering.velocity.WebappResourceLoader
webapp.resource.loader.cache=true
webapp.resource.loader.path=/WEB-INF/velocity,/WEB-INF/velocity/templates,/WEB-INF/velocity/templates/feeds,/WEB-INF/velocity/templates/emails
...

If you are now familiar with the code you might be in a better position to
see why I have to shut down for it to be picked up.

Cheers Greg

Re: [ANNOUNCE] Velocity Engine 2.0 RC5 test build available

[Greg Huber]

For this rc5 is says

org.apache.velocity.runtime.resource.loader.ResourceLoader2;

does not exist and ResourceLoader says its depreciated?

Cheers Greg

On 3 January 2017 at 23:43, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available (RC5).
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1015/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
> Release Candidates changelog:
>   RC1: initial candidate
>   RC2: bugfixes
>   RC3: review SLF4J Logger names (instead of a single logger named
> "Velocity", have a hierarchy of loggers with a base of
> 'org.apache.velocity')
>   RC4: minor fixes
>   RC5:
>* the default encoding is now UTF-8 (and not the platform default)
>* commons-collections is not any more a compilation dependency
>* commons-lang3 dependency is not any more shaded
>* the configuration API doesn't reference ExtProperties
>* the events API has been optimized and reviewed: all events do receive
> the current Context
>* there has been a few optimizations in ASTStringLiteral rendering
>
>
> Regards,
>
>   Claude
>
>
>

Re: [VOTE] 2.0 Release Quality

[Greg Huber]

Thanks, works great for me.

[x] General Availability (GA)

+1 non binding.


On 16 November 2016 at 11:51, Claude Brisson  wrote:

> The Velocity Engine 2.0 RC3 test build has been available since the 12th,
> and the RC4 (which only contains trivial fixes) has just been published.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1013
>
> If you have had a chance to review the test build, please respond with a
> vote on its quality:
>
>  [ ] Leave at test build
>  [ ] Alpha
>  [ ] Beta
>  [ ] General Availability (GA)
>
> Everyone who has tested the RC3 or the RC4 is invited to vote. Votes by
> PMC members are considered binding. A vote passes if there are at least
> three binding +1s and more +1s than -1s.
>
>
>   Claude
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: TexenTask

[Greg Huber]

I have tested it and it seems to work.  Some depreciated stuff which
converts easily.

I need this for my build to work, what are the chances this could
maintained again?  Originally this was part of the velocity jar so many
builds may be using it.  I have looked at other maven plugins but nothing
would work for me, so I will need to create my own version going forward by
including the source locally.

Cheers

On 12 November 2016 at 20:49, Claude Brisson <cla...@renegat.net> wrote:

> Texen is unmaintained. But it is still available from Velocity download
> page http://velocity.apache.org/download.cgi
>
> You may need to recompile it, but there are good chances that it sill
> works with Velocity 2.0.
>
>
>   Claude
>
>
> On 12/11/2016 12:38, Greg Huber wrote:
>
>> In my build I use velocity (ant) to generate some scripts and now its
>> failing as the org.apache.velocity.texen.ant.TexenTask is missing.
>>
>>
>> > classpathref="texen_path" />
>>
>>
>> Have or can these been added to another package?
>>
>>
>> Cheers
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

TexenTask

[Greg Huber]

In my build I use velocity (ant) to generate some scripts and now its
failing as the org.apache.velocity.texen.ant.TexenTask is missing.





Have or can these been added to another package?


Cheers

Re: Logging configuration

[Greg Huber]

Doing only casual debugging,  as long as its intuitive to set the debugging
name="foobar" name without having to dip into the code sounds great.  The
package name is however the easiest to remember as its from the class you
are trying to debug (using attached source jar).

Thanks

On 11 November 2016 at 11:07, Claude Brisson <cla...@renegat.net> wrote:

> And also velocity.rendering for every rendering error (including
> introspector/uberspector). So here's the new list:
>
>  - velocity for the app/runtime/singleton
>  - velocity.event for the event cartridge
>  - velocity.directive, and velocity.directive.[directivename]
>  - velocity.parser
>  - velocity.loader and velocity.loader.[loadername]
>  - velocity.macro
>  - velocity.rendering (rendering errors other than directive ones,
> introspector/uberspector)
>
> Ah, and allso:
>  - velocity.scripting for the JSR223 scripting module
>
>
> plus:
>  - velocity.tools
>  - velocity.tools.[key]
>
>
>
> On 11/11/2016 11:14, Claude Brisson wrote:
>
>> Why not, but it should be done right now to take advantage of the major
>> version change.
>>
>> I checked quickly, and it seems like all logging backends build the
>> loggers hierarchy using namespaces separated with dots, which can be class
>> names by convention but it is not at all necessary.
>>
>> I'd rather not use class names, because the logical hierarchy of modules
>> is not always reflected by the factual class hierarchy, and because
>> "org.apache.velocity.app.Velocity" is obviously redundant and verbose.
>> Not to mention "org.apache.velocity.runtime.r
>> esource.util.StringResourceRepositoryImpl"... Plus, we can have some
>> logger names reflect runtime objects as directives and loaders.
>>
>> Now, to the modules themselves: we could have:
>>
>>  - velocity for the app/runtime/singleton
>>  - velocity.event for the event cartridge
>>  - velocity.directive, and velocity.directive.[directivename]
>>  - velocity.parser
>>  - velocity.loader and velocity.loader.[loadername]
>>  - velocity.macro
>>
>> Do you see something else?
>>
>> Also, for the tools, we can have velocity.tools for the framework and
>> velocity.tools.[toolskey] instead of the tools class (which allows custom
>> user tools to enter our hierarchy).
>>
>> Thoughts?
>>
>>   Claude
>>
>>
>> On 10/11/2016 17:18, Mike Kienenberger wrote:
>>
>>> +1 to using several appropriate functional names if we are picking
>>> loggers by String rather than by Class.
>>>
>>> On Thu, Nov 10, 2016 at 11:11 AM, Claude Brisson <cla...@renegat.net>
>>> wrote:
>>>
>>>> On 10/11/2016 15:56, Greg Huber wrote:
>>>>
>>>> Yes it does when I use name="Velocity"
>>>>>
>>>>> But as you are using the runtime instance logger its either on or off
>>>>> for
>>>>> the whole package.  Using a per class I think enables more filtering as
>>>>> you
>>>>> can name="org.apache.velocity.app" level="DEBUG" purely for this
>>>>> package
>>>>> and name="org.apache.velocity" level="WARN" for everything else.
>>>>>
>>>>
>>>> The reasons we only have one logger are mainly historical. It would
>>>> certainly be more pertinent to have at least one logger per module,
>>>> loading,
>>>> introspection, etc...
>>>>
>>>> But I you can filter the log file (in eclipse) so it makes no
>>>>> difference.
>>>>>
>>>>>
>>>>> Thanks for the velocity upgrade!  Thought it was not being maintained
>>>>> any
>>>>> more.
>>>>>
>>>>
>>>> Well, we're kinda resurrecting...
>>>>
>>>>
>>>>Claude
>>>>
>>>>
>>>>
>>>> -
>>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>>
>>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>
>>>
>>>
>>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: Logging configuration

[Greg Huber]

Yes it does when I use name="Velocity"

But as you are using the runtime instance logger its either on or off for
the whole package.  Using a per class I think enables more filtering as you
can name="org.apache.velocity.app" level="DEBUG" purely for this package
and name="org.apache.velocity" level="WARN" for everything else.

But I you can filter the log file (in eclipse) so it makes no difference.


Thanks for the velocity upgrade!  Thought it was not being maintained any
more.

Cheers Greg

On 10 November 2016 at 14:13, Claude Brisson <cla...@renegat.net> wrote:

> Any module anywhere can get a logger using one of the two static methods:
>
> Logger org.slf4j.LoggerFactory.getLogger(String loggerName)
>
> Logger org.slf4j.LoggerFactory.getLogger(Class targetClass)
>
> Calling one or the other is a matter of taste. It does not *have* to be
> the same logger anywhere in the application, each module can use its own
> logger. The parameter is generally used as a log line prefix, and can also
> be used to do a fine tuning of which modules can log at which log level,
> something we haven't taken advantage so far in Velocity (apart for the
> Tools themselves).
>
> I chose to use the first variant for sobriety (to avoid each log line
> contain the whole package name), but it s not necessarily a definitive
> choice. At least, it should be better documented.
>
> Does your logging work properly with this configuration?
>
>   Claude
>
>
> On 10/11/2016 11:12, Greg Huber wrote:
>
>> The name needs to be exactly Velocity which is not what I had expected,
>> usually its the package name format ie org.apache.velocity.
>>
>> 
>>  
>> 
>>
>> the docs suggest its org.apache.velocity.app.Velocity
>>
>> This seems to be set in RuntimeInstance:
>>
>> private Logger log = LoggerFactory.getLogger("Velocity");
>>
>>
>> Then I do not use slf4j so not sure how it should be configured ie per
>> package.
>>
>> Cheers Greg
>>
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Logging configuration

[Greg Huber]

The name needs to be exactly Velocity which is not what I had expected,
usually its the package name format ie org.apache.velocity.





the docs suggest its org.apache.velocity.app.Velocity

This seems to be set in RuntimeInstance:

private Logger log = LoggerFactory.getLogger("Velocity");


Then I do not use slf4j so not sure how it should be configured ie per
package.

Cheers Greg

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

[Greg Huber]

Claude,

I have tested the fix and it now works, thanks.

##

One thing now is I cannot get the log into debug mode.  I use
commons-logging with log4j and the log4j-slf4j-impl as a bridge.


   



Other jars that use slf4j will log to debug ok.

The notes mention runtime.log.instance= maybe I need to set something here?







On 9 November 2016 at 22:40, Claude Brisson <cla...@renegat.net> wrote:

> Thanks Nathan!
>
> Greg, the bug is fixed. But I'll wait at least 48h for potential more
> feedback (thanks, by the way!) before submitting a new release candidate.
>
> If you want to test the corrected version before, you can grab the latest
> snapshot here:
>
> https://repository.apache.org/content/repositories/snapshots
> /org/apache/velocity/velocity-engine-core/2.0-SNAPSHOT/
> velocity-engine-core-2.0-20161109.221234-5.jar
>
> (with the usual signatures in .sha1 and .md5 files).
>
>   Claude
>
>
> On 09/11/2016 18:45, Nathan Bubna wrote:
>
>> Gah, really wish i had time to help. Keep up the great work, Claude!
>>
>> On Wed, Nov 9, 2016 at 9:06 AM, Claude Brisson <cla...@renegat.net>
>> wrote:
>>
>> Ok, I reproduced it. It happens when the method is overloaded with a
>>> variant that takes no argument.
>>>
>>> Guess there will be a third release candidate...
>>>
>>>
>>>
>>> On 09/11/2016 17:44, Greg Huber wrote:
>>>
>>> It seems to be returning the wrong class name in ClassUtils
>>>>
>>>>method = node.getRuntimeServices().getUberspect().getMethod(o,
>>>> methodName,
>>>> params,
>>>>  new Info(node.getTemplateName(), node.getLine(),
>>>> node.getColumn()));
>>>>
>>>> It is returning a method name of .thumbResource() rather than
>>>> .thumbResource(String, String) and then further down the java reflection
>>>> throws the java.lang.IllegalArgumentException exception.
>>>>
>>>>
>>>> On 9 November 2016 at 16:09, Claude Brisson <cla...@renegat.net> wrote:
>>>>
>>>> I cannot reproduce it.
>>>>
>>>>> Is the thumbResource() method overloaded?
>>>>>
>>>>> Do you have the full stacktrace?
>>>>>
>>>>>
>>>>> On 09/11/2016 16:50, Greg Huber wrote:
>>>>>
>>>>> Hello,
>>>>>
>>>>>> I am getting an error when a parameter on a method name is null, it
>>>>>> says
>>>>>> "wrong number of arguments at"
>>>>>>
>>>>>> eg :
>>>>>>
>>>>>> $entry.filePath == null
>>>>>>
>>>>>> $myPojo.thumbResource($entry.name, $entry.filePath)
>>>>>>
>>>>>> I get an exception :
>>>>>>
>>>>>> java.lang.IllegalArgumentException: wrong number of arguments at..
>>>>>>
>>>>>>
>>>>>>
>>>>>> public String thumbResource(String name, String filePath) {
>>>>>>...
>>>>>> }
>>>>>>
>>>>>> I have tried to debug it but it seems to originate in the ASTMethod
>>>>>> class.
>>>>>> If i change the variable to be blanks it works ok.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 9 November 2016 at 14:50, Claude Brisson <cla...@renegat.net>
>>>>>> wrote:
>>>>>>
>>>>>> A new test build of Velocity Engine 2.0 is available.
>>>>>>
>>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>>>>> Velocity
>>>>>>> Engine 2.0 has been made, and at this time it is simply a "test
>>>>>>> build".
>>>>>>> We
>>>>>>> welcome any comments you may have, and will take all feedback into
>>>>>>> account
>>>>>>> if a quality vote is called for this build.
>>>>>>>
>>>>>>> Release notes:
>>>>>>>
>>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>>>> ine/2.0/release-notes.html
>>>>>>>
>>>>>>> Dist

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

[Greg Huber]

OK, I narrowed it down to org.apache.velocity.util.introspection.ClassMap
building its cache key, but since you can reproduce it I will give up now
and test the next release! :)

Thanks

On 9 November 2016 at 17:06, Claude Brisson <cla...@renegat.net> wrote:

> Ok, I reproduced it. It happens when the method is overloaded with a
> variant that takes no argument.
>
> Guess there will be a third release candidate...
>
>
> On 09/11/2016 17:44, Greg Huber wrote:
>
>> It seems to be returning the wrong class name in ClassUtils
>>
>>   method = node.getRuntimeServices().getUberspect().getMethod(o,
>> methodName,
>> params,
>> new Info(node.getTemplateName(), node.getLine(),
>> node.getColumn()));
>>
>> It is returning a method name of .thumbResource() rather than
>> .thumbResource(String, String) and then further down the java reflection
>> throws the java.lang.IllegalArgumentException exception.
>>
>>
>> On 9 November 2016 at 16:09, Claude Brisson <cla...@renegat.net> wrote:
>>
>> I cannot reproduce it.
>>>
>>> Is the thumbResource() method overloaded?
>>>
>>> Do you have the full stacktrace?
>>>
>>>
>>> On 09/11/2016 16:50, Greg Huber wrote:
>>>
>>> Hello,
>>>>
>>>> I am getting an error when a parameter on a method name is null, it says
>>>> "wrong number of arguments at"
>>>>
>>>> eg :
>>>>
>>>> $entry.filePath == null
>>>>
>>>> $myPojo.thumbResource($entry.name, $entry.filePath)
>>>>
>>>> I get an exception :
>>>>
>>>> java.lang.IllegalArgumentException: wrong number of arguments at..
>>>>
>>>>
>>>>
>>>> public String thumbResource(String name, String filePath) {
>>>>   ...
>>>> }
>>>>
>>>> I have tried to debug it but it seems to originate in the ASTMethod
>>>> class.
>>>> If i change the variable to be blanks it works ok.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On 9 November 2016 at 14:50, Claude Brisson <cla...@renegat.net> wrote:
>>>>
>>>> A new test build of Velocity Engine 2.0 is available.
>>>>
>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>>> Velocity
>>>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>>>> We
>>>>> welcome any comments you may have, and will take all feedback into
>>>>> account
>>>>> if a quality vote is called for this build.
>>>>>
>>>>> Release notes:
>>>>>
>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>> ine/2.0/release-notes.html
>>>>>
>>>>> Distribution:
>>>>>
>>>>>* https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>> ine/2.0/
>>>>>
>>>>> Maven 2 staging repository:
>>>>>
>>>>>* https://repository.apache.org/content/repositories/orgapache
>>>>> velocity-1011/
>>>>>
>>>>> A vote regarding the quality of this test build will be initiated
>>>>> within
>>>>> the next couple of days.
>>>>>
>>>>>
>>>>> Regards,
>>>>>
>>>>> Claude
>>>>>
>>>>>
>>>>> On 07/11/2016 11:06, Claude Brisson wrote:
>>>>>
>>>>> The test build of Velocity Engine 2.0 is available.
>>>>>
>>>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>>>> Velocity
>>>>>> Engine 2.0 has been made, and at this time it is simply a "test
>>>>>> build".
>>>>>> We
>>>>>> welcome any comments you may have, and will take all feedback into
>>>>>> account
>>>>>> if a quality vote is called for this build.
>>>>>>
>>>>>> Release notes:
>>>>>>
>>>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>>> ine/2.0/release-notes.html
>>>>>>
>>>>>> Distribution:
>>>>>>
>>>>>>* https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>>>> ine/2.0/
>>>>>>
>>>>>> Maven 2 staging repository:
>>>>>>
>>>>>>* https://repository.apache.org/content/repositories/orgapache
>>>>>> velocity-1010/
>>>>>>
>>>>>> A vote regarding the quality of this test build will be initiated
>>>>>> within
>>>>>> the next couple of days.
>>>>>>
>>>>>>
>>>>>> Regards,
>>>>>>
>>>>>> Claude
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
>>> For additional commands, e-mail: dev-h...@velocity.apache.org
>>>
>>>
>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

[Greg Huber]

It seems to be returning the wrong class name in ClassUtils

 method = node.getRuntimeServices().getUberspect().getMethod(o, methodName,
params,
   new Info(node.getTemplateName(), node.getLine(),
node.getColumn()));

It is returning a method name of .thumbResource() rather than
.thumbResource(String, String) and then further down the java reflection
throws the java.lang.IllegalArgumentException exception.


On 9 November 2016 at 16:09, Claude Brisson <cla...@renegat.net> wrote:

> I cannot reproduce it.
>
> Is the thumbResource() method overloaded?
>
> Do you have the full stacktrace?
>
>
> On 09/11/2016 16:50, Greg Huber wrote:
>
>> Hello,
>>
>> I am getting an error when a parameter on a method name is null, it says
>> "wrong number of arguments at"
>>
>> eg :
>>
>> $entry.filePath == null
>>
>> $myPojo.thumbResource($entry.name, $entry.filePath)
>>
>> I get an exception :
>>
>> java.lang.IllegalArgumentException: wrong number of arguments at..
>>
>>
>>
>> public String thumbResource(String name, String filePath) {
>>  ...
>> }
>>
>> I have tried to debug it but it seems to originate in the ASTMethod class.
>> If i change the variable to be blanks it works ok.
>>
>>
>>
>>
>>
>>
>>
>>
>> On 9 November 2016 at 14:50, Claude Brisson <cla...@renegat.net> wrote:
>>
>> A new test build of Velocity Engine 2.0 is available.
>>>
>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>> We
>>> welcome any comments you may have, and will take all feedback into
>>> account
>>> if a quality vote is called for this build.
>>>
>>> Release notes:
>>>
>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>> ine/2.0/release-notes.html
>>>
>>> Distribution:
>>>
>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>>>
>>> Maven 2 staging repository:
>>>
>>>   * https://repository.apache.org/content/repositories/orgapache
>>> velocity-1011/
>>>
>>> A vote regarding the quality of this test build will be initiated within
>>> the next couple of days.
>>>
>>>
>>> Regards,
>>>
>>>Claude
>>>
>>>
>>> On 07/11/2016 11:06, Claude Brisson wrote:
>>>
>>> The test build of Velocity Engine 2.0 is available.
>>>>
>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>> Velocity
>>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>>> We
>>>> welcome any comments you may have, and will take all feedback into
>>>> account
>>>> if a quality vote is called for this build.
>>>>
>>>> Release notes:
>>>>
>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/release-notes.html
>>>>
>>>> Distribution:
>>>>
>>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/
>>>>
>>>> Maven 2 staging repository:
>>>>
>>>>   * https://repository.apache.org/content/repositories/orgapache
>>>> velocity-1010/
>>>>
>>>> A vote regarding the quality of this test build will be initiated within
>>>> the next couple of days.
>>>>
>>>>
>>>> Regards,
>>>>
>>>>Claude
>>>>
>>>>
>>>>
>>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

[Greg Huber]

I have a template with a pojo in the context with a method called

thumbResource(String, String)

When I parse the template with an null for the second parameter

$myPojo.thumbResource(main, null)

it throws the exception.

Debugging it in eclipse is just says :

java.lang.IllegalArgumentException: wrong number of arguments


It is thrown in the method.invoke method below  ASTMethod.java

try
{
/*
 *  get the returned object.  It may be null, and that is
 *  valid for something declared with a void return type.
 *  Since the caller is expecting something to be returned,
 *  as long as things are peachy, we can return an empty
 *  String so ASTReference() correctly figures out that
 *  all is well.
 */

Object obj = method.invoke(o, params);

if (obj == null)
{
if( method.getReturnType() == Void.TYPE)
{
return "";
}
}

return obj;
}
catch( InvocationTargetException ite )
{
return handleInvocationException(o, context,
ite.getTargetException());
}

/** Can also be thrown by method invocation **/
catch( IllegalArgumentException t )
{
return handleInvocationException(o, context, t);
}


I will try to debug it further.

Thanks

On 9 November 2016 at 16:09, Claude Brisson <cla...@renegat.net> wrote:

> I cannot reproduce it.
>
> Is the thumbResource() method overloaded?
>
> Do you have the full stacktrace?
>
>
> On 09/11/2016 16:50, Greg Huber wrote:
>
>> Hello,
>>
>> I am getting an error when a parameter on a method name is null, it says
>> "wrong number of arguments at"
>>
>> eg :
>>
>> $entry.filePath == null
>>
>> $myPojo.thumbResource($entry.name, $entry.filePath)
>>
>> I get an exception :
>>
>> java.lang.IllegalArgumentException: wrong number of arguments at..
>>
>>
>>
>> public String thumbResource(String name, String filePath) {
>>  ...
>> }
>>
>> I have tried to debug it but it seems to originate in the ASTMethod class.
>> If i change the variable to be blanks it works ok.
>>
>>
>>
>>
>>
>>
>>
>>
>> On 9 November 2016 at 14:50, Claude Brisson <cla...@renegat.net> wrote:
>>
>> A new test build of Velocity Engine 2.0 is available.
>>>
>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>> We
>>> welcome any comments you may have, and will take all feedback into
>>> account
>>> if a quality vote is called for this build.
>>>
>>> Release notes:
>>>
>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>> ine/2.0/release-notes.html
>>>
>>> Distribution:
>>>
>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>>>
>>> Maven 2 staging repository:
>>>
>>>   * https://repository.apache.org/content/repositories/orgapache
>>> velocity-1011/
>>>
>>> A vote regarding the quality of this test build will be initiated within
>>> the next couple of days.
>>>
>>>
>>> Regards,
>>>
>>>Claude
>>>
>>>
>>> On 07/11/2016 11:06, Claude Brisson wrote:
>>>
>>> The test build of Velocity Engine 2.0 is available.
>>>>
>>>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of
>>>> Velocity
>>>> Engine 2.0 has been made, and at this time it is simply a "test build".
>>>> We
>>>> welcome any comments you may have, and will take all feedback into
>>>> account
>>>> if a quality vote is called for this build.
>>>>
>>>> Release notes:
>>>>
>>>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/release-notes.html
>>>>
>>>> Distribution:
>>>>
>>>>   * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>>>> ine/2.0/
>>>>
>>>> Maven 2 staging repository:
>>>>
>>>>   * https://repository.apache.org/content/repositories/orgapache
>>>> velocity-1010/
>>>>
>>>> A vote regarding the quality of this test build will be initiated within
>>>> the next couple of days.
>>>>
>>>>
>>>> Regards,
>>>>
>>>>Claude
>>>>
>>>>
>>>>
>>>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@velocity.apache.org
> For additional commands, e-mail: dev-h...@velocity.apache.org
>
>

Re: [ANNOUNCE] Velocity Engine 2.0 test build available

[Greg Huber]

Hello,

I am getting an error when a parameter on a method name is null, it says
"wrong number of arguments at"

eg :

$entry.filePath == null

$myPojo.thumbResource($entry.name, $entry.filePath)

I get an exception :

java.lang.IllegalArgumentException: wrong number of arguments at..



public String thumbResource(String name, String filePath) {
...
}

I have tried to debug it but it seems to originate in the ASTMethod class.
If i change the variable to be blanks it works ok.








On 9 November 2016 at 14:50, Claude Brisson  wrote:

> A new test build of Velocity Engine 2.0 is available.
>
> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
> Engine 2.0 has been made, and at this time it is simply a "test build". We
> welcome any comments you may have, and will take all feedback into account
> if a quality vote is called for this build.
>
> Release notes:
>
> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
> ine/2.0/release-notes.html
>
> Distribution:
>
>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>
> Maven 2 staging repository:
>
>  * https://repository.apache.org/content/repositories/orgapache
> velocity-1011/
>
> A vote regarding the quality of this test build will be initiated within
> the next couple of days.
>
>
> Regards,
>
>   Claude
>
>
> On 07/11/2016 11:06, Claude Brisson wrote:
>
>>
>> The test build of Velocity Engine 2.0 is available.
>>
>> No determination as to the quality ('alpha,' 'beta,' or 'GA') of Velocity
>> Engine 2.0 has been made, and at this time it is simply a "test build". We
>> welcome any comments you may have, and will take all feedback into account
>> if a quality vote is called for this build.
>>
>> Release notes:
>>
>> * https://dist.apache.org/repos/dist/dev/velocity/velocity-eng
>> ine/2.0/release-notes.html
>>
>> Distribution:
>>
>>  * https://dist.apache.org/repos/dist/dev/velocity/velocity-engine/2.0/
>>
>> Maven 2 staging repository:
>>
>>  * https://repository.apache.org/content/repositories/orgapache
>> velocity-1010/
>>
>> A vote regarding the quality of this test build will be initiated within
>> the next couple of days.
>>
>>
>> Regards,
>>
>>   Claude
>>
>>
>>