[GitHub] lucky-chen opened a new pull request #1443: [WEEX-571][iOS]peformance record, fix createInstance time in snandbox
lucky-chen opened a new pull request #1443: [WEEX-571][iOS]peformance record, fix createInstance time in snandbox URL: https://github.com/apache/incubator-weex/pull/1443 three case of create instance - normal - sandbox - devtool This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-571) [iOS] performance record , fix createInstance time in snadbox
peihan created WEEX-571: --- Summary: [iOS] performance record , fix createInstance time in snadbox Key: WEEX-571 URL: https://issues.apache.org/jira/browse/WEEX-571 Project: Weex Issue Type: Bug Components: iOS Reporter: peihan Assignee: XuYouyang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-570) add ut to track component and module register status
[ https://issues.apache.org/jira/browse/WEEX-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581976#comment-16581976 ] ASF GitHub Bot commented on WEEX-570: - weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442#issuecomment-413428510 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add ut to track component and module register status > > > Key: WEEX-570 > URL: https://issues.apache.org/jira/browse/WEEX-570 > Project: Weex > Issue Type: Improvement > Components: Android >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add ut to track component and module register status -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details
weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442#issuecomment-413428510 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-570) add ut to track component and module register status
[ https://issues.apache.org/jira/browse/WEEX-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581975#comment-16581975 ] ASF GitHub Bot commented on WEEX-570: - weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442#issuecomment-413428510 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add ut to track component and module register status > > > Key: WEEX-570 > URL: https://issues.apache.org/jira/browse/WEEX-570 > Project: Weex > Issue Type: Improvement > Components: Android >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add ut to track component and module register status -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details
weex-bot edited a comment on issue #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442#issuecomment-413428510 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1442: [WEEX-570][Android] add ut details
weex-bot commented on issue #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442#issuecomment-413428510 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-570) add ut to track component and module register status
[ https://issues.apache.org/jira/browse/WEEX-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581970#comment-16581970 ] ASF GitHub Bot commented on WEEX-570: - Darin726 opened a new pull request #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442 https://issues.apache.org/jira/browse/WEEX-570 [WEEX-570][Android] add ut details add ut to track component and module register status Bug: WEEX-570 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add ut to track component and module register status > > > Key: WEEX-570 > URL: https://issues.apache.org/jira/browse/WEEX-570 > Project: Weex > Issue Type: Improvement > Components: Android >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add ut to track component and module register status -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Darin726 opened a new pull request #1442: [WEEX-570][Android] add ut details
Darin726 opened a new pull request #1442: [WEEX-570][Android] add ut details URL: https://github.com/apache/incubator-weex/pull/1442 https://issues.apache.org/jira/browse/WEEX-570 [WEEX-570][Android] add ut details add ut to track component and module register status Bug: WEEX-570 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-570) add ut to track component and module register status
Yayun Dong created WEEX-570: --- Summary: add ut to track component and module register status Key: WEEX-570 URL: https://issues.apache.org/jira/browse/WEEX-570 Project: Weex Issue Type: Improvement Components: Android Reporter: Yayun Dong Assignee: YorkShen Fix For: 0.18 add ut to track component and module register status -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581938#comment-16581938 ] ASF GitHub Bot commented on WEEX-569: - weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report
weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581935#comment-16581935 ] ASF GitHub Bot commented on WEEX-569: - weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Protocol/WXApmProtocol.h does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581934#comment-16581934 ] ASF GitHub Bot commented on WEEX-569: - weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report
weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Protocol/WXApmProtocol.h does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report
weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kIdJoEy opened a new issue #1441: Android端，Refresh和v-if同时使用，当条件不渲染refresh后，再重新渲染无法渲染
kIdJoEy opened a new issue #1441: Android端，Refresh和v-if同时使用，当条件不渲染refresh后，再重新渲染无法渲染 URL: https://github.com/apache/incubator-weex/issues/1441 ## Description Android端，Refresh和v-if同时使用，当条件不渲染refresh后，再重新渲染无法渲染 ## Environment Weex Version:0.18.2.88 Device Mode:OC105 ## Broken Example http://dotwe.org/挂了，我贴code吧= = ## Steps to Reproduce [pullRefresh.txt](https://github.com/apache/incubator-weex/files/2292374/pullRefresh.txt) [shareFootprint.txt](https://github.com/apache/incubator-weex/files/2292375/shareFootprint.txt) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581925#comment-16581925 ] ASF GitHub Bot commented on WEEX-569: - weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report
weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581922#comment-16581922 ] ASF GitHub Bot commented on WEEX-569: - weex-bot commented on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Fails :no_entry_sign: Code file ios/sdk/WeexSDK/Sources/Protocol/WXApmProtocol.h does not have the copyright header. Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report
weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581924#comment-16581924 ] ASF GitHub Bot commented on WEEX-569: - weex-bot edited a comment on issue #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440#issuecomment-413418453 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-569) [iOS] fix degrade_error not report
[ https://issues.apache.org/jira/browse/WEEX-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581919#comment-16581919 ] ASF GitHub Bot commented on WEEX-569: - lucky-chen opened a new pull request #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440 - fix degrade_error not report , by modify `WXSDKInstance.m` - add `NET` case in `WXErrorCodeGroup` - report error msg when degrade_error This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [iOS] fix degrade_error not report > --- > > Key: WEEX-569 > URL: https://issues.apache.org/jira/browse/WEEX-569 > Project: Weex > Issue Type: Bug > Components: iOS >Reporter: peihan >Assignee: XuYouyang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] lucky-chen opened a new pull request #1440: [WEEX-569][iOS] fix degrade_error not report
lucky-chen opened a new pull request #1440: [WEEX-569][iOS] fix degrade_error not report URL: https://github.com/apache/incubator-weex/pull/1440 - fix degrade_error not report , by modify `WXSDKInstance.m` - add `NET` case in `WXErrorCodeGroup` - report error msg when degrade_error This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-569) [iOS] fix degrade_error not report
peihan created WEEX-569: --- Summary: [iOS] fix degrade_error not report Key: WEEX-569 URL: https://issues.apache.org/jira/browse/WEEX-569 Project: Weex Issue Type: Bug Components: iOS Reporter: peihan Assignee: XuYouyang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581896#comment-16581896
]
ASF GitHub Bot commented on WEEX-566:
-
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210468815
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +268,22 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+Closeable w = null;
+try {
+ if(!versionFile.exists())
+versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
Review comment:
Move `fileWriter` out of the try clause and close the `fileWriter` in
finally would be better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add jsb version file to make jsb can update
> ---
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
>Affects Versions: 0.19
>Reporter: Yayun Dong
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210468815
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +268,22 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+Closeable w = null;
+try {
+ if(!versionFile.exists())
+versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
Review comment:
Move `fileWriter` out of the try clause and close the `fileWriter` in
finally would be better.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581892#comment-16581892 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581890#comment-16581890 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581888#comment-16581888 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581889#comment-16581889 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
[
https://issues.apache.org/jira/browse/WEEX-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581878#comment-16581878
]
ASF GitHub Bot commented on WEEX-568:
-
YorkShen closed pull request #1439: [WEEX-568][Android]Add Scan Delay Interface
For AutoScanConfigRegister
URL: https://github.com/apache/incubator-weex/pull/1439
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
index 597fb4d89b..b8b5805f88 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
@@ -26,6 +26,7 @@
import com.alibaba.fastjson.JSONObject;
import com.taobao.weex.WXEnvironment;
import com.taobao.weex.WXSDKEngine;
+import com.taobao.weex.WXSDKManager;
import com.taobao.weex.bridge.JavascriptInvokable;
import com.taobao.weex.utils.WXFileUtils;
import com.taobao.weex.utils.WXLogUtils;
@@ -39,6 +40,7 @@
public class AutoScanConfigRegister {
+private static long scanDelay = 0;
public static final String TAG = "WeexScanConfigRegister";
@@ -61,7 +63,20 @@ public static void preLoad(JavascriptInvokable invokable){
* auto scan config files and do auto config from files, none need center
register
* */
public static void doScanConfig(){
- Thread thread = new Thread(new Runnable() {
+if(scanDelay > 0){
+WXSDKManager.getInstance().getWXRenderManager().postOnUiThread(new
Runnable() {
+@Override
+public void run() {
+doScanConfigAsync();
+}
+}, scanDelay);
+}else{
+doScanConfigAsync();
+}
+}
+
+public static void doScanConfigAsync(){
+Thread thread = new Thread(new Runnable() {
@Override
public void run() {
doScanConfigSync();
@@ -77,8 +92,8 @@ public void run() {
}
}
});
- thread.setName("AutoScanConfigRegister");
- thread.start();
+thread.setName("AutoScanConfigRegister");
+thread.start();
}
private static void doScanConfigSync(){
@@ -146,4 +161,7 @@ private static void doScanConfigSync(){
}
}
+public static void setScanDelay(long scanDelay) {
+AutoScanConfigRegister.scanDelay = scanDelay;
+}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Scan Delay Interface For AutoScanConfigRegister
> ---
>
> Key: WEEX-568
> URL: https://issues.apache.org/jira/browse/WEEX-568
> Project: Weex
> Issue Type: Bug
>Reporter: codefurture
>Assignee: codefurture
>Priority: Major
>
> Add Scan Delay Interface For AutoScanConfigRegister
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] YorkShen closed pull request #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister
YorkShen closed pull request #1439: [WEEX-568][Android]Add Scan Delay Interface
For AutoScanConfigRegister
URL: https://github.com/apache/incubator-weex/pull/1439
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
index 597fb4d89b..b8b5805f88 100644
---
a/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
+++
b/android/sdk/src/main/java/com/taobao/weex/ui/config/AutoScanConfigRegister.java
@@ -26,6 +26,7 @@
import com.alibaba.fastjson.JSONObject;
import com.taobao.weex.WXEnvironment;
import com.taobao.weex.WXSDKEngine;
+import com.taobao.weex.WXSDKManager;
import com.taobao.weex.bridge.JavascriptInvokable;
import com.taobao.weex.utils.WXFileUtils;
import com.taobao.weex.utils.WXLogUtils;
@@ -39,6 +40,7 @@
public class AutoScanConfigRegister {
+private static long scanDelay = 0;
public static final String TAG = "WeexScanConfigRegister";
@@ -61,7 +63,20 @@ public static void preLoad(JavascriptInvokable invokable){
* auto scan config files and do auto config from files, none need center
register
* */
public static void doScanConfig(){
- Thread thread = new Thread(new Runnable() {
+if(scanDelay > 0){
+WXSDKManager.getInstance().getWXRenderManager().postOnUiThread(new
Runnable() {
+@Override
+public void run() {
+doScanConfigAsync();
+}
+}, scanDelay);
+}else{
+doScanConfigAsync();
+}
+}
+
+public static void doScanConfigAsync(){
+Thread thread = new Thread(new Runnable() {
@Override
public void run() {
doScanConfigSync();
@@ -77,8 +92,8 @@ public void run() {
}
}
});
- thread.setName("AutoScanConfigRegister");
- thread.start();
+thread.setName("AutoScanConfigRegister");
+thread.start();
}
private static void doScanConfigSync(){
@@ -146,4 +161,7 @@ private static void doScanConfigSync(){
}
}
+public static void setScanDelay(long scanDelay) {
+AutoScanConfigRegister.scanDelay = scanDelay;
+}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
[ https://issues.apache.org/jira/browse/WEEX-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581875#comment-16581875 ] ASF GitHub Bot commented on WEEX-568: - weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Scan Delay Interface For AutoScanConfigRegister > --- > > Key: WEEX-568 > URL: https://issues.apache.org/jira/browse/WEEX-568 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: codefurture >Priority: Major > > Add Scan Delay Interface For AutoScanConfigRegister -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister
weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
[ https://issues.apache.org/jira/browse/WEEX-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581874#comment-16581874 ] ASF GitHub Bot commented on WEEX-568: - weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Scan Delay Interface For AutoScanConfigRegister > --- > > Key: WEEX-568 > URL: https://issues.apache.org/jira/browse/WEEX-568 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: codefurture >Priority: Major > > Add Scan Delay Interface For AutoScanConfigRegister -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot commented on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister
weex-bot commented on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister
weex-bot edited a comment on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
[ https://issues.apache.org/jira/browse/WEEX-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581873#comment-16581873 ] ASF GitHub Bot commented on WEEX-568: - weex-bot commented on issue #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439#issuecomment-413409803 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Scan Delay Interface For AutoScanConfigRegister > --- > > Key: WEEX-568 > URL: https://issues.apache.org/jira/browse/WEEX-568 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: codefurture >Priority: Major > > Add Scan Delay Interface For AutoScanConfigRegister -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
[ https://issues.apache.org/jira/browse/WEEX-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581872#comment-16581872 ] ASF GitHub Bot commented on WEEX-568: - gubaojian opened a new pull request #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439 [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Scan Delay Interface For AutoScanConfigRegister > --- > > Key: WEEX-568 > URL: https://issues.apache.org/jira/browse/WEEX-568 > Project: Weex > Issue Type: Bug >Reporter: codefurture >Assignee: codefurture >Priority: Major > > Add Scan Delay Interface For AutoScanConfigRegister -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] gubaojian opened a new pull request #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister
gubaojian opened a new pull request #1439: [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister URL: https://github.com/apache/incubator-weex/pull/1439 [WEEX-568][Android]Add Scan Delay Interface For AutoScanConfigRegister This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (WEEX-548) Weex devtool can not debug recycle list
[ https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qz closed WEEX-548. --- > Weex devtool can not debug recycle list > > > Key: WEEX-548 > URL: https://issues.apache.org/jira/browse/WEEX-548 > Project: Weex > Issue Type: Bug >Reporter: qz >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (WEEX-497) IOS 编译demo
[
https://issues.apache.org/jira/browse/WEEX-497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
qz closed WEEX-497.
---
Resolution: Fixed
> IOS 编译demo
> --
>
> Key: WEEX-497
> URL: https://issues.apache.org/jira/browse/WEEX-497
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Environment: mac 10.13.4
>Reporter: logan
>Assignee: xingZhang
>Priority: Blocker
> Attachments: {3DD126A7-6D36-B24E-C701-101B70682C6D}.png
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> IOS编译 WeexDemo 的时候报
> ld: library not found for -lSDWebImage
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
>
> 我已经使用pod 安装了依赖库
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-497) IOS 编译demo
[
https://issues.apache.org/jira/browse/WEEX-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581871#comment-16581871
]
qz commented on WEEX-497:
-
Hey, please use pod update to update your pods.
> IOS 编译demo
> --
>
> Key: WEEX-497
> URL: https://issues.apache.org/jira/browse/WEEX-497
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Environment: mac 10.13.4
>Reporter: logan
>Assignee: xingZhang
>Priority: Blocker
> Attachments: {3DD126A7-6D36-B24E-C701-101B70682C6D}.png
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> IOS编译 WeexDemo 的时候报
> ld: library not found for -lSDWebImage
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
>
> 我已经使用pod 安装了依赖库
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WEEX-533) Animation Memory leak
[ https://issues.apache.org/jira/browse/WEEX-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qz resolved WEEX-533. - Resolution: Fixed > Animation Memory leak > - > > Key: WEEX-533 > URL: https://issues.apache.org/jira/browse/WEEX-533 > Project: Weex > Issue Type: Bug >Reporter: YorkShen >Assignee: YorkShen >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581869#comment-16581869
]
ASF GitHub Bot commented on WEEX-566:
-
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210464939
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +268,23 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+Closeable w = null;
+try {
+ if(!versionFile.exists())
+versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
+ fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION));
Review comment:
If line 277 crashes, the file will still be open.
FileWriter x = null
try{
x= new FileWriter
}finally{
if(x != null) x.close()
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add jsb version file to make jsb can update
> ---
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
>Affects Versions: 0.19
>Reporter: Yayun Dong
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (WEEX-548) Weex devtool can not debug recycle list
[ https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] qz resolved WEEX-548. - Resolution: Fixed > Weex devtool can not debug recycle list > > > Key: WEEX-548 > URL: https://issues.apache.org/jira/browse/WEEX-548 > Project: Weex > Issue Type: Bug >Reporter: qz >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581868#comment-16581868
]
ASF GitHub Bot commented on WEEX-566:
-
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210464939
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +268,23 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+Closeable w = null;
+try {
+ if(!versionFile.exists())
+versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
+ fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION));
Review comment:
If line 277 crashes, the file still be open.
FileWriter x = null
try{
x= new FileWriter
}finally{
if(x != null) x.close()
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add jsb version file to make jsb can update
> ---
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
>Affects Versions: 0.19
>Reporter: Yayun Dong
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210464939
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +268,23 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+
+Closeable w = null;
+try {
+ if(!versionFile.exists())
+versionFile.createNewFile();
+ FileWriter fileWriter = new FileWriter(versionFile);
+ fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION));
Review comment:
If line 277 crashes, the file still be open.
FileWriter x = null
try{
x= new FileWriter
}finally{
if(x != null) x.close()
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] YorkShen closed pull request #1438: Fix js process crash info can not report error:
YorkShen closed pull request #1438: Fix js process crash info can not report
error:
URL: https://github.com/apache/incubator-weex/pull/1438
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/android/sdk/libs/armeabi-v7a/libJavaScriptCore.so
b/android/sdk/libs/armeabi-v7a/libJavaScriptCore.so
new file mode 100755
index 00..904fdc7782
Binary files /dev/null and b/android/sdk/libs/armeabi-v7a/libJavaScriptCore.so
differ
diff --git a/android/sdk/libs/armeabi-v7a/libweexjsb.so
b/android/sdk/libs/armeabi-v7a/libweexjsb.so
index 8e3a8554a7..afa1dcaab5 100755
Binary files a/android/sdk/libs/armeabi-v7a/libweexjsb.so and
b/android/sdk/libs/armeabi-v7a/libweexjsb.so differ
diff --git a/android/sdk/libs/armeabi-v7a/libweexjss.so
b/android/sdk/libs/armeabi-v7a/libweexjss.so
index b9f61f6898..5880ebd75f 100755
Binary files a/android/sdk/libs/armeabi-v7a/libweexjss.so and
b/android/sdk/libs/armeabi-v7a/libweexjss.so differ
diff --git a/android/sdk/libs/armeabi/libJavaScriptCore.so
b/android/sdk/libs/armeabi/libJavaScriptCore.so
new file mode 100755
index 00..904fdc7782
Binary files /dev/null and b/android/sdk/libs/armeabi/libJavaScriptCore.so
differ
diff --git a/android/sdk/libs/armeabi/libweexjsb.so
b/android/sdk/libs/armeabi/libweexjsb.so
index 8e3a8554a7..afa1dcaab5 100755
Binary files a/android/sdk/libs/armeabi/libweexjsb.so and
b/android/sdk/libs/armeabi/libweexjsb.so differ
diff --git a/android/sdk/libs/armeabi/libweexjss.so
b/android/sdk/libs/armeabi/libweexjss.so
index b9f61f6898..5880ebd75f 100755
Binary files a/android/sdk/libs/armeabi/libweexjss.so and
b/android/sdk/libs/armeabi/libweexjss.so differ
diff --git a/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
b/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
index cdb3aebb15..1a2d949423 100644
--- a/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
+++ b/android/sdk/src/main/java/com/taobao/weex/WXEnvironment.java
@@ -312,6 +312,20 @@ public static String getFilesDir(Context context) {
return path;
}
+ public static String getCrashFilePath(Context context) {
+if (context == null) {
+return "";
+}
+
+File dir = context.getDir("crash", Context.MODE_PRIVATE);
+if (dir == null)
+return "";
+
+String crashDir = dir.getAbsolutePath();
+
+return crashDir;
+ }
+
public static String getGlobalFontFamilyName() {
return sGlobalFontFamily;
}
diff --git
a/android/sdk/src/main/java/com/taobao/weex/appfram/navigator/INavigator.java
b/android/sdk/src/main/java/com/taobao/weex/appfram/navigator/INavigator.java
index 4e6c0355f6..65c7193430 100644
---
a/android/sdk/src/main/java/com/taobao/weex/appfram/navigator/INavigator.java
+++
b/android/sdk/src/main/java/com/taobao/weex/appfram/navigator/INavigator.java
@@ -1,3 +1,21 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
package com.taobao.weex.appfram.navigator;
import android.app.Activity;
diff --git a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java
index ced83d30cb..e6292a6e68 100644
--- a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java
+++ b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridge.java
@@ -321,7 +321,7 @@ public int callRefreshFinish(String instanceId, byte[]
tasks, String callback) {
@Override
public void reportServerCrash(String instanceId, String crashFile) {
-WXLogUtils.e(TAG, "reportServerCrash instanceId:" + instanceId);
+WXLogUtils.e(TAG, "reportServerCrash instanceId:" + instanceId + "
crashFile: " + crashFile);
int errorCode = IWXBridge.INSTANCE_RENDERING;
try {
errorCode =
WXBridgeManager.getInstance().callReportCrashReloadPage(instanceId, crashFile);
diff --git
a/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
b/android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java
index
[jira] [Commented] (WEEX-548) Weex devtool can not debug recycle list
[
https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581853#comment-16581853
]
ASF GitHub Bot commented on WEEX-548:
-
cxfeng1 closed pull request #1395: [WEEX-548][iOS] Weex devtool can not debug
recycle list
URL: https://github.com/apache/incubator-weex/pull/1395
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/playground/Podfile b/ios/playground/Podfile
index 77accedfe0..5e4c34c129 100644
--- a/ios/playground/Podfile
+++ b/ios/playground/Podfile
@@ -4,7 +4,7 @@ platform :ios, '8.0'
def common
pod 'WeexSDK', :path=>'../../'
-pod 'WXDevtool', '0.15.3'
+pod 'WXDevtool','0.16.2'
pod 'SDWebImage', '3.7.5'
pod 'SocketRocket', '0.4.2'
pod 'ATSDK-Weex', '0.0.1',:configurations => ['Debug']
diff --git a/ios/playground/WeexDemo/Scanner/WXScannerVC.m
b/ios/playground/WeexDemo/Scanner/WXScannerVC.m
index 0f0f67846a..01b3262df0 100644
--- a/ios/playground/WeexDemo/Scanner/WXScannerVC.m
+++ b/ios/playground/WeexDemo/Scanner/WXScannerVC.m
@@ -23,8 +23,7 @@
#import "UIViewController+WXDemoNaviBar.h"
#import "WXDemoViewController.h"
#import "WXDebugTool.h"
-
-#import
+#import "WXDevTool.h"
#import
@interface WXScannerVC ()
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index cb4903ace0..e561730a60 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -797,7 +797,7 @@ - (void)executeJsMethod:(WXCallJSMethod *)method
[self performSelector:@selector(_sendQueueLoop) withObject:nil];
}
-- (void)callJSMethod:(NSString *)method args:(NSArray *)args
onContext:(id)bridge completion:(void (^)(JSValue *
value))complection
+- (void)callJSMethod:(NSString *)method args:(NSArray *)args
onContext:(id)bridge completion:(void (^)(JSValue *
value))completion
{
NSMutableArray *newArg = nil;
if (!bridge) {
@@ -805,22 +805,23 @@ - (void)callJSMethod:(NSString *)method args:(NSArray
*)args onContext:(id_virtualComponentId, newData] competion:^(JSValue *value) {
-[newData addEntriesFromDictionary:[value toDictionary][@"0"]];
+[newData addEntriesFromDictionary:[value toArray][0]];
[newData setObject:indexPath forKey:@"indexPath"];
[newData setObject:listRef forKey:@"recycleListComponentRef"];
[[recycleListComponent dataManager]
updateVirtualComponentData:self->_virtualComponentId data:newData];
diff --git a/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
b/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
index 91fdd90132..84a35bc1ce 100644
--- a/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
+++ b/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
@@ -356,17 +356,15 @@ + (void)connectDevToolServer:(NSString *)URL
+ (void)_originalRegisterComponents:(NSDictionary *)components {
NSMutableDictionary * mutableComponents = [components mutableCopy];
void (^componentBlock)(id, id, BOOL *) = ^(id mKey, id mObj, BOOL * mStop)
{
-
NSString *name = mObj[@"name"];
NSString *componentClass = mObj[@"clazz"];
NSDictionary *pros = nil;
if (mObj[@"pros"]) {
-pros = mObj[@""];
+pros = mObj[@"pros"];
}
[self registerComponent:name
withClass:NSClassFromString(componentClass) withProperties:pros];
};
[mutableComponents enumerateKeysAndObjectsUsingBlock:componentBlock];
-
}
+ (void)_originalRegisterModules:(NSDictionary *)modules {
diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
index 3a9e27e020..00d4f2dd37 100644
--- a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
+++ b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
@@ -355,7 +355,7 @@ - (void)fireEvent:(NSString *)instanceId ref:(NSString
*)ref type:(NSString *)ty
[self callJsMethod:method];
}
-- (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)componentId type:(NSString*)type
hook:(NSString*)hookPhase args:(NSArray*)args competion:(void (^)(JSValue *
value))complection
+- (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)componentId type:(NSString*)type
hook:(NSString*)hookPhase args:(NSArray*)args competion:(void (^)(JSValue *
value))completion
{
WXPerformBlockOnBridgeThread(^{
if (!type || !instanceId || !hookPhase) {
@@ -365,7 +365,7 @@ - (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)component
NSArray *newArgs = @[componentId, type, hookPhase, args?:@[]];
WXCallJSMethod * method =
[GitHub] cxfeng1 closed pull request #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list
cxfeng1 closed pull request #1395: [WEEX-548][iOS] Weex devtool can not debug
recycle list
URL: https://github.com/apache/incubator-weex/pull/1395
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/playground/Podfile b/ios/playground/Podfile
index 77accedfe0..5e4c34c129 100644
--- a/ios/playground/Podfile
+++ b/ios/playground/Podfile
@@ -4,7 +4,7 @@ platform :ios, '8.0'
def common
pod 'WeexSDK', :path=>'../../'
-pod 'WXDevtool', '0.15.3'
+pod 'WXDevtool','0.16.2'
pod 'SDWebImage', '3.7.5'
pod 'SocketRocket', '0.4.2'
pod 'ATSDK-Weex', '0.0.1',:configurations => ['Debug']
diff --git a/ios/playground/WeexDemo/Scanner/WXScannerVC.m
b/ios/playground/WeexDemo/Scanner/WXScannerVC.m
index 0f0f67846a..01b3262df0 100644
--- a/ios/playground/WeexDemo/Scanner/WXScannerVC.m
+++ b/ios/playground/WeexDemo/Scanner/WXScannerVC.m
@@ -23,8 +23,7 @@
#import "UIViewController+WXDemoNaviBar.h"
#import "WXDemoViewController.h"
#import "WXDebugTool.h"
-
-#import
+#import "WXDevTool.h"
#import
@interface WXScannerVC ()
diff --git a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
index cb4903ace0..e561730a60 100644
--- a/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
+++ b/ios/sdk/WeexSDK/Sources/Bridge/WXBridgeContext.m
@@ -797,7 +797,7 @@ - (void)executeJsMethod:(WXCallJSMethod *)method
[self performSelector:@selector(_sendQueueLoop) withObject:nil];
}
-- (void)callJSMethod:(NSString *)method args:(NSArray *)args
onContext:(id)bridge completion:(void (^)(JSValue *
value))complection
+- (void)callJSMethod:(NSString *)method args:(NSArray *)args
onContext:(id)bridge completion:(void (^)(JSValue *
value))completion
{
NSMutableArray *newArg = nil;
if (!bridge) {
@@ -805,22 +805,23 @@ - (void)callJSMethod:(NSString *)method args:(NSArray
*)args onContext:(id_virtualComponentId, newData] competion:^(JSValue *value) {
-[newData addEntriesFromDictionary:[value toDictionary][@"0"]];
+[newData addEntriesFromDictionary:[value toArray][0]];
[newData setObject:indexPath forKey:@"indexPath"];
[newData setObject:listRef forKey:@"recycleListComponentRef"];
[[recycleListComponent dataManager]
updateVirtualComponentData:self->_virtualComponentId data:newData];
diff --git a/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
b/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
index 91fdd90132..84a35bc1ce 100644
--- a/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
+++ b/ios/sdk/WeexSDK/Sources/Engine/WXSDKEngine.m
@@ -356,17 +356,15 @@ + (void)connectDevToolServer:(NSString *)URL
+ (void)_originalRegisterComponents:(NSDictionary *)components {
NSMutableDictionary * mutableComponents = [components mutableCopy];
void (^componentBlock)(id, id, BOOL *) = ^(id mKey, id mObj, BOOL * mStop)
{
-
NSString *name = mObj[@"name"];
NSString *componentClass = mObj[@"clazz"];
NSDictionary *pros = nil;
if (mObj[@"pros"]) {
-pros = mObj[@""];
+pros = mObj[@"pros"];
}
[self registerComponent:name
withClass:NSClassFromString(componentClass) withProperties:pros];
};
[mutableComponents enumerateKeysAndObjectsUsingBlock:componentBlock];
-
}
+ (void)_originalRegisterModules:(NSDictionary *)modules {
diff --git a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
index 3a9e27e020..00d4f2dd37 100644
--- a/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
+++ b/ios/sdk/WeexSDK/Sources/Manager/WXBridgeManager.m
@@ -355,7 +355,7 @@ - (void)fireEvent:(NSString *)instanceId ref:(NSString
*)ref type:(NSString *)ty
[self callJsMethod:method];
}
-- (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)componentId type:(NSString*)type
hook:(NSString*)hookPhase args:(NSArray*)args competion:(void (^)(JSValue *
value))complection
+- (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)componentId type:(NSString*)type
hook:(NSString*)hookPhase args:(NSArray*)args competion:(void (^)(JSValue *
value))completion
{
WXPerformBlockOnBridgeThread(^{
if (!type || !instanceId || !hookPhase) {
@@ -365,7 +365,7 @@ - (void)callComponentHook:(NSString*)instanceId
componentId:(NSString*)component
NSArray *newArgs = @[componentId, type, hookPhase, args?:@[]];
WXCallJSMethod * method = [[WXCallJSMethod alloc]
initWithModuleName:nil methodName:@"componentHook" arguments:newArgs
instance:[WXSDKManager instanceForID:instanceId]];
-[self.bridgeCtx callJSMethod:@"callJS" args:@[instanceId,
@[method.callJSTask]]
[jira] [Created] (WEEX-568) Add Scan Delay Interface For AutoScanConfigRegister
codefurture created WEEX-568: Summary: Add Scan Delay Interface For AutoScanConfigRegister Key: WEEX-568 URL: https://issues.apache.org/jira/browse/WEEX-568 Project: Weex Issue Type: Bug Reporter: codefurture Assignee: codefurture Add Scan Delay Interface For AutoScanConfigRegister -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1438: Fix js process crash info can not report error:
weex-bot edited a comment on issue #1438: Fix js process crash info can not report error: URL: https://github.com/apache/incubator-weex/pull/1438#issuecomment-413401061 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1438: Fix js process crash info can not report error:
weex-bot edited a comment on issue #1438: Fix js process crash info can not report error: URL: https://github.com/apache/incubator-weex/pull/1438#issuecomment-413401061 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot commented on issue #1438: Fix js process crash info can not report error:
weex-bot commented on issue #1438: Fix js process crash info can not report error: URL: https://github.com/apache/incubator-weex/pull/1438#issuecomment-413401061 Warnings :warning: No Changelog changes! :warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXParams.java without metion it in commit message. You'd better add '@notdanger' in your commit log. Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581485#comment-16581485 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581483#comment-16581483 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581482#comment-16581482 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581478#comment-16581478 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581473#comment-16581473 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581475#comment-16581475 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-548) Weex devtool can not debug recycle list
[ https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581057#comment-16581057 ] ASF GitHub Bot commented on WEEX-548: - weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Weex devtool can not debug recycle list > > > Key: WEEX-548 > URL: https://issues.apache.org/jira/browse/WEEX-548 > Project: Weex > Issue Type: Bug >Reporter: qz >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list
weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Messages :book: No android file has been changed. :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-548) Weex devtool can not debug recycle list
[ https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581053#comment-16581053 ] ASF GitHub Bot commented on WEEX-548: - weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Weex devtool can not debug recycle list > > > Key: WEEX-548 > URL: https://issues.apache.org/jira/browse/WEEX-548 > Project: Weex > Issue Type: Bug >Reporter: qz >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WEEX-548) Weex devtool can not debug recycle list
[ https://issues.apache.org/jira/browse/WEEX-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581052#comment-16581052 ] ASF GitHub Bot commented on WEEX-548: - weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Weex devtool can not debug recycle list > > > Key: WEEX-548 > URL: https://issues.apache.org/jira/browse/WEEX-548 > Project: Weex > Issue Type: Bug >Reporter: qz >Assignee: Adam Feng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list
weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list
weex-bot edited a comment on issue #1395: [WEEX-548][iOS] Weex devtool can not debug recycle list URL: https://github.com/apache/incubator-weex/pull/1395#issuecomment-410599535 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alwaysfight opened a new pull request #1438: Fix js process crash info can not report error:
alwaysfight opened a new pull request #1438: Fix js process crash info can not report error: URL: https://github.com/apache/incubator-weex/pull/1438 1.add java function to get crash file storage path and pass to child process 2.refine crash cpp code https://issues.apache.org/jira/browse/WEEX-567 First of all, thank you for your contribution! Please makes sure that these checkboxes are checked before submitting your PR, thank you! CheckList: **if** *isBugFix* **:** * [ ] Make sure that you add at least one unit test for the bug which you had fixed. **elif** *isNewFeature* **:** * [ ] Update API docs for the component. * [ ] Update/Add demo to demonstrate new feature. * [ ] Update test scripts for the feature. * [ ] Add unit tests for the feature. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-567) JS crash 不能上报
zhangxiao created WEEX-567: -- Summary: JS crash 不能上报 Key: WEEX-567 URL: https://issues.apache.org/jira/browse/WEEX-567 Project: Weex Issue Type: Bug Components: Android Reporter: zhangxiao Assignee: YorkShen 原因： crash文件存储目录写死在进程无权限的目录 修正： 通过java函数获取包数据存储目录，创建app_crash目录来存储crash文件 从新修正crash模块代码 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Hanks10100 closed pull request #1432: [devtool] Added beta-signoff.sh to automate the beta release process.
Hanks10100 closed pull request #1432: [devtool] Added beta-signoff.sh to
automate the beta release process.
URL: https://github.com/apache/incubator-weex/pull/1432
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/scripts/beta-branchoff.sh b/scripts/beta-branchoff.sh
index e211f01afb..a58f792896 100755
--- a/scripts/beta-branchoff.sh
+++ b/scripts/beta-branchoff.sh
@@ -3,94 +3,12 @@
dir_name=$(dirname $0)
source ${dir_name}/common.sh
-function isValidVersion () {
- echo "$1" | awk '/^[0-9]+\.[0-9]+(\.[0-9]+){0,2}(-rc[0-9]+|-beta[0-9]+)?$/
{print $0}'
-}
+prepareWorkingDir
-function isBetaVersion () {
- echo "$1" | awk '/^[0-9]+\.[0-9]+(\.[0-9]+){0,2}-beta[0-9]+$/ {print $0}'
-}
-
-function isRCVersion () {
- echo "$1" | awk '/^[0-9]+\.[0-9]+(\.[0-9]+){0,2}-rc[0-9]+$/ {print $0}'
-}
-
-function latestVersion () {
- git tag -l | awk '/^0\.[0-9]+(\.[0-9]+){0,2}(-rc[0-9]+|-beta[0-9]+)?$/ {
print $0 }' | sort -rV | head -n 1
-}
-
-function latestNotRCVersion () {
- git tag -l | awk '/^0\.[0-9]+(\.[0-9]+){0,2}(-beta[0-9]+)?$/ { print $0 }' |
sort -rV | head -n 1
-}
-
-function betaNumber () {
- echo "$1" | awk -F 'beta' '{print $2}'
-}
-
-function rcNumber () {
- echo "$1" | awk -F 'rc' '{print $2}'
-}
-
-function gitRepoModified () {
- git status --short | awk '/^[ M][ M] / { print $0 }'
-}
-
-function increaseBetaVersion () {
- if [ $(isRCVersion "$1") ]; then
-# Unable to increase beta version number on a RC version, exit.
-return 1
- fi
- if [ $(isBetaVersion "$1") ]; then
-echo "$1" | awk -F 'beta' '{printf("%sbeta%d\n", $1, $2+1)}'
- else
-echo "$1" | awk -F '.' '/^([0-9]+\.){1,3}([0-9]+)$/ {
- for(i=1;i<=NF;i++) {
-if (i==NF) {
- printf("%d-beta1\n", $i+1)
-} else {
- printf("%d.", $i)
-}
- }
-}'
- fi
-}
-
-function increaseRCVersion () {
- if [ $(isBetaVersion "$1") ]; then
-# Unable to increase rc version number on a beta version, exit.
-return 1
- fi
- if [ $(isRCVersion "$1") ]; then
-echo "$1" | awk -F 'rc' '{printf("%src%d\n", $1, $2+1)}'
- else
-echo "$1" | awk -F '.' '/^([0-9]+\.){1,3}([0-9]+)$/ {
- for(i=1;i<=NF;i++) {
-if (i==NF) {
- printf("%d-rc1\n", $i+1)
-} else {
- printf("%d.", $i)
-}
- }
-}'
- fi
-}
-
-read -e -p "Your upstream git remote is? [origin]"
-remote=${REPLY:="origin"}
-
-info "Fetching latest changes and prune ${LGREEN}$remote${RESTORE}..."
-git fetch -p -t "$remote"
-if [ $? ]; then
- error "It is not able to fetch codes from your $remote, check if there is
any issue."
- exit 1
-fi
-git remote prune "$remote"
-info "${GREEN}Done.${RESTORE}"
-
-latest_ver=$(latestNotRCVersion)
+latest_ver=$(latestNonRCVersion)
beta_ver="0.0.1-beta1"
if [ -z "$latest_ver" ]; then
- echo "Use ${YELLOW}$beta_ver${RESTORE} as the version number."
+ info "Use ${YELLOW}$beta_ver${RESTORE} as the version number."
else
beta_ver=$(increaseBetaVersion "$latest_ver")
fi
@@ -120,20 +38,13 @@ if [ ${shouldContinue,,} = n ]; then
exit 0
fi
-if [ "$(gitRepoModified)" ]; then
- read -e -p "Your working directory is modified, stash it? [Y/n]" -n 1
- shouldStash=${REPLY:=y}
- if [ ${shouldStash,,} = y ]; then
-git stash
- else
-info "Change ignored."
- fi
-fi
+stashLocalChanges
-echo -e "\nCreating local branch: ${YELLOW}$beta_branch${RESTORE}..."
+info "\nCreating local branch: ${YELLOW}$beta_branch${RESTORE}..."
git checkout -B "$beta_branch" "$latest_sha"
-echo -e "\nPushing ${YELLOW}$beta_branch${RESTORE} onto $remote..."
+info "\nPushing ${YELLOW}$beta_branch${RESTORE} onto $remote...\n"
git push "$remote" "$beta_branch":"$beta_branch"
git branch --set-upstream-to="$remote/$beta_branch"
-echo "${GREEN}Done.${RESTORE}"
+info "\n${GREEN}Done.${RESTORE}"
+info "\nNOTICE: Now you've started the release process for $beta_ver, please
work on the branch $beta_branch for bug fixes, no feature allowed submitting on
it. Keep it sync with $remote/$beta_branch before your release."
diff --git a/scripts/beta-signoff.sh b/scripts/beta-signoff.sh
new file mode 100755
index 00..d23aebb7e7
--- /dev/null
+++ b/scripts/beta-signoff.sh
@@ -0,0 +1,90 @@
+#!/usr/bin/env bash
+
+# This script publishes the latest beta version of the project, merge beta
changes to beta branch, and tags the beta release, then rebase the changes onto
master branch, and cleanup temporary release branches as well.
+
+dir_name=$(dirname $0)
+source ${dir_name}/common.sh
+
+command -v hub > /dev/null 2>&1 || { error "The signoff process needs command
'hub', Use 'brew install hub' to install it. exit."; exit 1; }
+
+prepareWorkingDir
+
+latest_ver=$(latestNonRCVersion)
+beta_ver="0.0.1-beta1"
+if [
[GitHub] Hanks10100 closed issue #1431: [devtool] Automate the beta version sign-off and publish process
Hanks10100 closed issue #1431: [devtool] Automate the beta version sign-off and publish process URL: https://github.com/apache/incubator-weex/issues/1431 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580866#comment-16580866
]
ASF GitHub Bot commented on WEEX-566:
-
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210210901
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -213,8 +217,23 @@ public static void copyStartUpSo() {
} else {
newfile = new File(cacheFile + STARTUPSO);
}
-if (newfile.exists()) {
- return;
+
+String jsbVersionFile = "jsb.version";
+
+File versionFile = new File(cacheFile,jsbVersionFile);
+if(newfile.exists() && versionFile.exists()) {
+ try {
+FileReader fileReader = new FileReader(versionFile);
+BufferedReader br = new BufferedReader(fileReader);
Review comment:
Invoke br.close when finishing reading file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add jsb version file to make jsb can update
> ---
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
>Affects Versions: 0.19
>Reporter: Yayun Dong
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[
https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580867#comment-16580867
]
ASF GitHub Bot commented on WEEX-566:
-
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210211315
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -242,6 +261,12 @@ public static void copyStartUpSo() {
} else {
WXEnvironment.extractSo();
}
+if(!versionFile.exists())
+ versionFile.createNewFile();
+FileWriter fileWriter = new FileWriter(versionFile);
+fileWriter.write(String.valueOf(WXEnvironment.CORE_JSB_SO_VERSION));
+fileWriter.flush();
Review comment:
Add a more try catch finally clause to close the writer as if there is a
exception in line 268, fileWriter would be still open.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add jsb version file to make jsb can update
> ---
>
> Key: WEEX-566
> URL: https://issues.apache.org/jira/browse/WEEX-566
> Project: Weex
> Issue Type: Improvement
> Components: Android
>Affects Versions: 0.19
>Reporter: Yayun Dong
>Assignee: YorkShen
>Priority: Major
> Fix For: 0.18
>
>
> add jsb version file to make jsb can update
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
YorkShen commented on a change in pull request #1437: [WEEX-566][Android] add
jsb version file to make jsb.so can update
URL: https://github.com/apache/incubator-weex/pull/1437#discussion_r210210901
##
File path:
android/sdk/src/main/java/com/taobao/weex/utils/WXSoInstallMgrSdk.java
##
@@ -213,8 +217,23 @@ public static void copyStartUpSo() {
} else {
newfile = new File(cacheFile + STARTUPSO);
}
-if (newfile.exists()) {
- return;
+
+String jsbVersionFile = "jsb.version";
+
+File versionFile = new File(cacheFile,jsbVersionFile);
+if(newfile.exists() && versionFile.exists()) {
+ try {
+FileReader fileReader = new FileReader(versionFile);
+BufferedReader br = new BufferedReader(fileReader);
Review comment:
Invoke br.close when finishing reading file
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] shinyjacklee commented on issue #1430: Weex failed to render in Fragment (Android)
shinyjacklee commented on issue #1430: Weex failed to render in Fragment (Android) URL: https://github.com/apache/incubator-weex/issues/1430#issuecomment-413132089 Dear Hanks,finally i make it to render weex page in Android Fragment. The **mistake** is i used wrong method to load the url ~~`mWXSDKInstance.render()`~~ instead of the correct ` mWXSDKInstance.renderByUrl()` And for the sample to render with Fragment try this[weex-start-kit](https://github.com/w11p/weex-start-kit). Thanks for you help :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shinyjacklee closed issue #1430: Weex failed to render in Fragment (Android)
shinyjacklee closed issue #1430: Weex failed to render in Fragment (Android) URL: https://github.com/apache/incubator-weex/issues/1430 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580815#comment-16580815 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Fails :no_entry_sign: Failed to run assembleDebug task for android. Messages :book: android build verification finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580813#comment-16580813 ] ASF GitHub Bot commented on WEEX-566: - weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot edited a comment on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Messages :book: has no jsfm file changed. :book: jsfm test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-566) add jsb version file to make jsb can update
[ https://issues.apache.org/jira/browse/WEEX-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580812#comment-16580812 ] ASF GitHub Bot commented on WEEX-566: - weex-bot commented on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > add jsb version file to make jsb can update > --- > > Key: WEEX-566 > URL: https://issues.apache.org/jira/browse/WEEX-566 > Project: Weex > Issue Type: Improvement > Components: Android >Affects Versions: 0.19 >Reporter: Yayun Dong >Assignee: YorkShen >Priority: Major > Fix For: 0.18 > > > add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] weex-bot commented on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
weex-bot commented on issue #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437#issuecomment-413122583 Warnings :warning: No Changelog changes! Messages :book: danger test finished. Generated by :no_entry_sign: http://github.com/danger/danger-js/;>dangerJS This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Darin726 opened a new pull request #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update
Darin726 opened a new pull request #1437: [WEEX-566][Android] add jsb version file to make jsb.so can update URL: https://github.com/apache/incubator-weex/pull/1437 https://issues.apache.org/jira/browse/WEEX-566 [WEEX-566][Android] add jsb version file to make jsb.so can update add jsb version file to make jsb.so can update Bug: WEEX-566 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (WEEX-566) add jsb version file to make jsb can update
Yayun Dong created WEEX-566: --- Summary: add jsb version file to make jsb can update Key: WEEX-566 URL: https://issues.apache.org/jira/browse/WEEX-566 Project: Weex Issue Type: Improvement Components: Android Affects Versions: 0.19 Reporter: Yayun Dong Assignee: YorkShen Fix For: 0.18 add jsb version file to make jsb can update -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] shinyjacklee removed a comment on issue #1430: Weex failed to render in Fragment (Android)
shinyjacklee removed a comment on issue #1430: Weex failed to render in Fragment (Android) URL: https://github.com/apache/incubator-weex/issues/1430#issuecomment-412786499 Hi Hanks,the problem is even the WXSDKInstance isn't created successfully, ` reportJSException instanceId:1, exception function:createInstance, exception:Exception: SyntaxError: Unexpected token '}'. Cannot parse statement. at (global function):8 Function@[native code] Function@[native code] (weex framework):1:148499 ei@(weex framework):1:148517 createInstance@(weex framework):1:151735 (weex framework):1:255299` Using the Weex playground app and Activity implementation to scan the same page QR Code can be rendered . Or can you please give me a sample to render in Fragment(Android) ,which can also close the [ISSUE](https://github.com/alibaba/weex/issues/2593) mentioned above. Thanks This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WEEX-563) ios platform linear-gradient problem
[
https://issues.apache.org/jira/browse/WEEX-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580767#comment-16580767
]
ASF GitHub Bot commented on WEEX-563:
-
cxfeng1 closed pull request #1434: [WEEX-563][iOS] fix the attribute of
linear-gradient on iOS
URL: https://github.com/apache/incubator-weex/pull/1434
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
b/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
index e063395844..d0350551b6 100644
--- a/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
+++ b/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
@@ -403,7 +403,11 @@ + (NSDictionary
*)linearGradientWithBackgroundImage:(NSString *)backgroundImage
if ([subStr hasPrefix:@"rgb"]) {
gradientType = [WXConvert gradientType:gradientTypeStr];
-range = [subStr rangeOfString:@")"];
+if ([subStr containsString:@"%"]) {
+range = [subStr rangeOfString:@"%"];
+} else {
+range = [subStr rangeOfString:@")"];
+}
NSString *startColorStr = [subStr
substringToIndex:range.location + 1];
NSString *endColorStr = [subStr
substringFromIndex:range.location + 2];
startColor = [WXConvert UIColor:startColorStr];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> ios platform linear-gradient problem
> -
>
> Key: WEEX-563
> URL: https://issues.apache.org/jira/browse/WEEX-563
> Project: Weex
> Issue Type: Bug
>Reporter: linghe
>Assignee: Adam Feng
>Priority: Critical
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] cxfeng1 closed pull request #1434: [WEEX-563][iOS] fix the attribute of linear-gradient on iOS
cxfeng1 closed pull request #1434: [WEEX-563][iOS] fix the attribute of
linear-gradient on iOS
URL: https://github.com/apache/incubator-weex/pull/1434
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
b/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
index e063395844..d0350551b6 100644
--- a/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
+++ b/ios/sdk/WeexSDK/Sources/Utility/WXUtility.m
@@ -403,7 +403,11 @@ + (NSDictionary
*)linearGradientWithBackgroundImage:(NSString *)backgroundImage
if ([subStr hasPrefix:@"rgb"]) {
gradientType = [WXConvert gradientType:gradientTypeStr];
-range = [subStr rangeOfString:@")"];
+if ([subStr containsString:@"%"]) {
+range = [subStr rangeOfString:@"%"];
+} else {
+range = [subStr rangeOfString:@")"];
+}
NSString *startColorStr = [subStr
substringToIndex:range.location + 1];
NSString *endColorStr = [subStr
substringFromIndex:range.location + 2];
startColor = [WXConvert UIColor:startColorStr];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
