Re: Igor did it!
Now there is time for RFEs ;) ? 2010/3/2 Matej Knopp matej.kn...@gmail.com: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: Igor did it!
Whoohooo finally i get rid of all the spam messages! On Tue, Mar 2, 2010 at 12:40, Matej Knopp matej.kn...@gmail.com wrote: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: [vote] release wicket 1.4.7
+1 On Mon, Mar 1, 2010 at 01:13, Igor Vaynberg igor.vaynb...@gmail.com wrote: this vote is to release wicket 1.4.7 this maintenance release brings over 30 bug fixes and improvements. branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.7/ artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.7/http://people.apache.org/%7Eivaynberg/wicket-1.4.7/ (currently uploading...) changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12314560 (and below) vote ends Wednesday 5pm gmt-8 cheers -igor Release Notes - Wicket - Version 1.4.7 ** Bug * [WICKET-2510] - Radio getMarkupId not working correctly * [WICKET-2615] - URL mismatch with RENDER_TO_BUFFER when URL rewriting features of container are used * [WICKET-2648] - DatePicker javascript uses 4 symbols for year although pattern contains just yy * [WICKET-2657] - Multipart forms fails on Chrome during Ajax submit * [WICKET-2660] - Wickettester executeAllTimerBehaviors executes stopped behaviors too * [WICKET-2663] - Modal Dialog cannot add AjaxLink when UploadWebRequest is in use * [WICKET-2688] - Versioned form with FileUploadField will expire page if you submit the form twice. * [WICKET-2702] - update PropertyColumn Javadoc * [WICKET-2704] - FormComponent.MessageSource.getMessage(String) and getValidatorKeyPrefix() * [WICKET-2714] - SharedResourceRequestTarget sets Status 404 when not found, ignoring any 404 settings * [WICKET-2715] - AuthenticatedWebSession in wicket-auth-roles does thread-unsafe access to signedIn boolean * [WICKET-2717] - bookmarkablepagelink broken on ajaxupdate * [WICKET-2718] - RedirectPage does not work in IE * [WICKET-2721] - IE does not display ExceptionErrorPage * [WICKET-2726] - CLONE -Ajax multipart broken on mounted pages * [WICKET-2734] - Form#anyComponentError change in 1.4 breaks validation * [WICKET-2738] - setResponsePage doesn't work with MixedParamUrlCodingStrategy * [WICKET-2740] - DynamicWizardModel: setActiveStep is called twice * [WICKET-2744] - AjaxFormChoiceComponentUpdatingBehavior cannot find the choice * [WICKET-2749] - multipart form does not call window.wicketGlobalPreCallHandler * [WICKET-2753] - Javascript in Form.registerJavascriptNamespaces() fails in Firefox 3.5.8 * [WICKET-2757] - MimeType/ContentType detection in ResourceStreamRequestTarget unreliable * [WICKET-2759] - libxml2 splits large CData section. this breaks the processing of components ** Improvement * [WICKET-2661] - Palette does not allow tracking the AbstractChoices components via Ajax * [WICKET-2698] - Page Parameters needs to implement equals * [WICKET-2706] - French translations for missing properties * [WICKET-2708] - Extend SwitchProtocolRequestTarget so it's possible to customize the redirect url * [WICKET-2709] - EmptySrcAttributeCheckFilter should check for src=# * [WICKET-2719] - Extract lazy AbstractListDataProvider out of ListDataProvider. * [WICKET-2720] - Panel throws MarkupException without passing MarkupStream * [WICKET-2731] - provide hook to enforce fqn's leaking out from shared resources * [WICKET-2737] - reduce number of SpringBeanLocator#getBeanNameOfClass calls. * [WICKET-2748] - IE6 sometimes fails when using wicket ajax * [WICKET-2750] - Better error handling in modal window setContent() when a repeater is used
Re: [vote] release wicket 1.4.7
+1 On Mon, Mar 1, 2010 at 1:13 AM, Igor Vaynberg igor.vaynb...@gmail.com wrote: this vote is to release wicket 1.4.7 this maintenance release brings over 30 bug fixes and improvements. branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.7/ artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.7/ (currently uploading...) changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12314560 (and below) vote ends Wednesday 5pm gmt-8 cheers -igor Release Notes - Wicket - Version 1.4.7 ** Bug * [WICKET-2510] - Radio getMarkupId not working correctly * [WICKET-2615] - URL mismatch with RENDER_TO_BUFFER when URL rewriting features of container are used * [WICKET-2648] - DatePicker javascript uses 4 symbols for year although pattern contains just yy * [WICKET-2657] - Multipart forms fails on Chrome during Ajax submit * [WICKET-2660] - Wickettester executeAllTimerBehaviors executes stopped behaviors too * [WICKET-2663] - Modal Dialog cannot add AjaxLink when UploadWebRequest is in use * [WICKET-2688] - Versioned form with FileUploadField will expire page if you submit the form twice. * [WICKET-2702] - update PropertyColumn Javadoc * [WICKET-2704] - FormComponent.MessageSource.getMessage(String) and getValidatorKeyPrefix() * [WICKET-2714] - SharedResourceRequestTarget sets Status 404 when not found, ignoring any 404 settings * [WICKET-2715] - AuthenticatedWebSession in wicket-auth-roles does thread-unsafe access to signedIn boolean * [WICKET-2717] - bookmarkablepagelink broken on ajaxupdate * [WICKET-2718] - RedirectPage does not work in IE * [WICKET-2721] - IE does not display ExceptionErrorPage * [WICKET-2726] - CLONE -Ajax multipart broken on mounted pages * [WICKET-2734] - Form#anyComponentError change in 1.4 breaks validation * [WICKET-2738] - setResponsePage doesn't work with MixedParamUrlCodingStrategy * [WICKET-2740] - DynamicWizardModel: setActiveStep is called twice * [WICKET-2744] - AjaxFormChoiceComponentUpdatingBehavior cannot find the choice * [WICKET-2749] - multipart form does not call window.wicketGlobalPreCallHandler * [WICKET-2753] - Javascript in Form.registerJavascriptNamespaces() fails in Firefox 3.5.8 * [WICKET-2757] - MimeType/ContentType detection in ResourceStreamRequestTarget unreliable * [WICKET-2759] - libxml2 splits large CData section. this breaks the processing of components ** Improvement * [WICKET-2661] - Palette does not allow tracking the AbstractChoices components via Ajax * [WICKET-2698] - Page Parameters needs to implement equals * [WICKET-2706] - French translations for missing properties * [WICKET-2708] - Extend SwitchProtocolRequestTarget so it's possible to customize the redirect url * [WICKET-2709] - EmptySrcAttributeCheckFilter should check for src=# * [WICKET-2719] - Extract lazy AbstractListDataProvider out of ListDataProvider. * [WICKET-2720] - Panel throws MarkupException without passing MarkupStream * [WICKET-2731] - provide hook to enforce fqn's leaking out from shared resources * [WICKET-2737] - reduce number of SpringBeanLocator#getBeanNameOfClass calls. * [WICKET-2748] - IE6 sometimes fails when using wicket ajax * [WICKET-2750] - Better error handling in modal window setContent() when a repeater is used -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.4 increases type safety for web applications Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.4
Re: Igor did it!
Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! On Tue, 2010-03-02 at 13:44 +0200, Martin Makundi wrote: Now there is time for RFEs ;) ? Now is time to migrate apps and see what are the benefits and what is still missing related to URL mounting/manipulation. 2010/3/2 Matej Knopp matej.kn...@gmail.com: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: [vote] release wicket 1.4.7
Any reason why this vote is only at dev@ mailing list ? If my memory serves me well users@ were involved in testing/voting before. On Sun, 2010-02-28 at 16:13 -0800, Igor Vaynberg wrote: this vote is to release wicket 1.4.7 this maintenance release brings over 30 bug fixes and improvements. branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.7/ artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.7/ (currently uploading...) changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12314560 (and below) vote ends Wednesday 5pm gmt-8 cheers -igor Release Notes - Wicket - Version 1.4.7 ** Bug * [WICKET-2510] - Radio getMarkupId not working correctly * [WICKET-2615] - URL mismatch with RENDER_TO_BUFFER when URL rewriting features of container are used * [WICKET-2648] - DatePicker javascript uses 4 symbols for year although pattern contains just yy * [WICKET-2657] - Multipart forms fails on Chrome during Ajax submit * [WICKET-2660] - Wickettester executeAllTimerBehaviors executes stopped behaviors too * [WICKET-2663] - Modal Dialog cannot add AjaxLink when UploadWebRequest is in use * [WICKET-2688] - Versioned form with FileUploadField will expire page if you submit the form twice. * [WICKET-2702] - update PropertyColumn Javadoc * [WICKET-2704] - FormComponent.MessageSource.getMessage(String) and getValidatorKeyPrefix() * [WICKET-2714] - SharedResourceRequestTarget sets Status 404 when not found, ignoring any 404 settings * [WICKET-2715] - AuthenticatedWebSession in wicket-auth-roles does thread-unsafe access to signedIn boolean * [WICKET-2717] - bookmarkablepagelink broken on ajaxupdate * [WICKET-2718] - RedirectPage does not work in IE * [WICKET-2721] - IE does not display ExceptionErrorPage * [WICKET-2726] - CLONE -Ajax multipart broken on mounted pages * [WICKET-2734] - Form#anyComponentError change in 1.4 breaks validation * [WICKET-2738] - setResponsePage doesn't work with MixedParamUrlCodingStrategy * [WICKET-2740] - DynamicWizardModel: setActiveStep is called twice * [WICKET-2744] - AjaxFormChoiceComponentUpdatingBehavior cannot find the choice * [WICKET-2749] - multipart form does not call window.wicketGlobalPreCallHandler * [WICKET-2753] - Javascript in Form.registerJavascriptNamespaces() fails in Firefox 3.5.8 * [WICKET-2757] - MimeType/ContentType detection in ResourceStreamRequestTarget unreliable * [WICKET-2759] - libxml2 splits large CData section. this breaks the processing of components ** Improvement * [WICKET-2661] - Palette does not allow tracking the AbstractChoices components via Ajax * [WICKET-2698] - Page Parameters needs to implement equals * [WICKET-2706] - French translations for missing properties * [WICKET-2708] - Extend SwitchProtocolRequestTarget so it's possible to customize the redirect url * [WICKET-2709] - EmptySrcAttributeCheckFilter should check for src=# * [WICKET-2719] - Extract lazy AbstractListDataProvider out of ListDataProvider. * [WICKET-2720] - Panel throws MarkupException without passing MarkupStream * [WICKET-2731] - provide hook to enforce fqn's leaking out from shared resources * [WICKET-2737] - reduce number of SpringBeanLocator#getBeanNameOfClass calls. * [WICKET-2748] - IE6 sometimes fails when using wicket ajax * [WICKET-2750] - Better error handling in modal window setContent() when a repeater is used
Re: [vote] release wicket 1.4.7
testing/release votes are dev@ only. Only committers have binding votes, and (pre/test/beta) releases are not for grander public consumption. This is typical for Wicket and any other Apache project. Martijn On Tue, Mar 2, 2010 at 2:43 PM, Martin Grigorov mcgreg...@e-card.bg wrote: Any reason why this vote is only at dev@ mailing list ? If my memory serves me well users@ were involved in testing/voting before. On Sun, 2010-02-28 at 16:13 -0800, Igor Vaynberg wrote: this vote is to release wicket 1.4.7 this maintenance release brings over 30 bug fixes and improvements. branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.7/ artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.7/ (currently uploading...) changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12314560 (and below) vote ends Wednesday 5pm gmt-8 cheers -igor Release Notes - Wicket - Version 1.4.7 ** Bug * [WICKET-2510] - Radio getMarkupId not working correctly * [WICKET-2615] - URL mismatch with RENDER_TO_BUFFER when URL rewriting features of container are used * [WICKET-2648] - DatePicker javascript uses 4 symbols for year although pattern contains just yy * [WICKET-2657] - Multipart forms fails on Chrome during Ajax submit * [WICKET-2660] - Wickettester executeAllTimerBehaviors executes stopped behaviors too * [WICKET-2663] - Modal Dialog cannot add AjaxLink when UploadWebRequest is in use * [WICKET-2688] - Versioned form with FileUploadField will expire page if you submit the form twice. * [WICKET-2702] - update PropertyColumn Javadoc * [WICKET-2704] - FormComponent.MessageSource.getMessage(String) and getValidatorKeyPrefix() * [WICKET-2714] - SharedResourceRequestTarget sets Status 404 when not found, ignoring any 404 settings * [WICKET-2715] - AuthenticatedWebSession in wicket-auth-roles does thread-unsafe access to signedIn boolean * [WICKET-2717] - bookmarkablepagelink broken on ajaxupdate * [WICKET-2718] - RedirectPage does not work in IE * [WICKET-2721] - IE does not display ExceptionErrorPage * [WICKET-2726] - CLONE -Ajax multipart broken on mounted pages * [WICKET-2734] - Form#anyComponentError change in 1.4 breaks validation * [WICKET-2738] - setResponsePage doesn't work with MixedParamUrlCodingStrategy * [WICKET-2740] - DynamicWizardModel: setActiveStep is called twice * [WICKET-2744] - AjaxFormChoiceComponentUpdatingBehavior cannot find the choice * [WICKET-2749] - multipart form does not call window.wicketGlobalPreCallHandler * [WICKET-2753] - Javascript in Form.registerJavascriptNamespaces() fails in Firefox 3.5.8 * [WICKET-2757] - MimeType/ContentType detection in ResourceStreamRequestTarget unreliable * [WICKET-2759] - libxml2 splits large CData section. this breaks the processing of components ** Improvement * [WICKET-2661] - Palette does not allow tracking the AbstractChoices components via Ajax * [WICKET-2698] - Page Parameters needs to implement equals * [WICKET-2706] - French translations for missing properties * [WICKET-2708] - Extend SwitchProtocolRequestTarget so it's possible to customize the redirect url * [WICKET-2709] - EmptySrcAttributeCheckFilter should check for src=# * [WICKET-2719] - Extract lazy AbstractListDataProvider out of ListDataProvider. * [WICKET-2720] - Panel throws MarkupException without passing MarkupStream * [WICKET-2731] - provide hook to enforce fqn's leaking out from shared resources * [WICKET-2737] - reduce number of SpringBeanLocator#getBeanNameOfClass calls. * [WICKET-2748] - IE6 sometimes fails when using wicket ajax * [WICKET-2750] - Better error handling in modal window setContent() when a repeater is used -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.4 increases type safety for web applications Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.4
Re: [vote] release wicket 1.4.7
While only committers have binding votes, all votes from the community should be (and certainly are) considered. That isn't to say that these VOTE threads should be on the users@ list. If a user is interested enough in the development of the Wicket project, they should subscribe to the dev@ list also. We don't want to spam the users@ list with stuff most users don't care about. On Tue, Mar 2, 2010 at 8:46 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: testing/release votes are dev@ only. Only committers have binding votes, and (pre/test/beta) releases are not for grander public consumption. This is typical for Wicket and any other Apache project. Martijn On Tue, Mar 2, 2010 at 2:43 PM, Martin Grigorov mcgreg...@e-card.bg wrote: Any reason why this vote is only at dev@ mailing list ? If my memory serves me well users@ were involved in testing/voting before. On Sun, 2010-02-28 at 16:13 -0800, Igor Vaynberg wrote: this vote is to release wicket 1.4.7 this maintenance release brings over 30 bug fixes and improvements. branch: https://svn.apache.org/repos/asf/wicket/branches/wicket-1.4.7/ artifacts: http://people.apache.org/~ivaynberg/wicket-1.4.7/ (currently uploading...) changelog: https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=truepid=12310561fixfor=12314560 (and below) vote ends Wednesday 5pm gmt-8 cheers -igor Release Notes - Wicket - Version 1.4.7 ** Bug * [WICKET-2510] - Radio getMarkupId not working correctly * [WICKET-2615] - URL mismatch with RENDER_TO_BUFFER when URL rewriting features of container are used * [WICKET-2648] - DatePicker javascript uses 4 symbols for year although pattern contains just yy * [WICKET-2657] - Multipart forms fails on Chrome during Ajax submit * [WICKET-2660] - Wickettester executeAllTimerBehaviors executes stopped behaviors too * [WICKET-2663] - Modal Dialog cannot add AjaxLink when UploadWebRequest is in use * [WICKET-2688] - Versioned form with FileUploadField will expire page if you submit the form twice. * [WICKET-2702] - update PropertyColumn Javadoc * [WICKET-2704] - FormComponent.MessageSource.getMessage(String) and getValidatorKeyPrefix() * [WICKET-2714] - SharedResourceRequestTarget sets Status 404 when not found, ignoring any 404 settings * [WICKET-2715] - AuthenticatedWebSession in wicket-auth-roles does thread-unsafe access to signedIn boolean * [WICKET-2717] - bookmarkablepagelink broken on ajaxupdate * [WICKET-2718] - RedirectPage does not work in IE * [WICKET-2721] - IE does not display ExceptionErrorPage * [WICKET-2726] - CLONE -Ajax multipart broken on mounted pages * [WICKET-2734] - Form#anyComponentError change in 1.4 breaks validation * [WICKET-2738] - setResponsePage doesn't work with MixedParamUrlCodingStrategy * [WICKET-2740] - DynamicWizardModel: setActiveStep is called twice * [WICKET-2744] - AjaxFormChoiceComponentUpdatingBehavior cannot find the choice * [WICKET-2749] - multipart form does not call window.wicketGlobalPreCallHandler * [WICKET-2753] - Javascript in Form.registerJavascriptNamespaces() fails in Firefox 3.5.8 * [WICKET-2757] - MimeType/ContentType detection in ResourceStreamRequestTarget unreliable * [WICKET-2759] - libxml2 splits large CData section. this breaks the processing of components ** Improvement * [WICKET-2661] - Palette does not allow tracking the AbstractChoices components via Ajax * [WICKET-2698] - Page Parameters needs to implement equals * [WICKET-2706] - French translations for missing properties * [WICKET-2708] - Extend SwitchProtocolRequestTarget so it's possible to customize the redirect url * [WICKET-2709] - EmptySrcAttributeCheckFilter should check for src=# * [WICKET-2719] - Extract lazy AbstractListDataProvider out of ListDataProvider. * [WICKET-2720] - Panel throws MarkupException without passing MarkupStream * [WICKET-2731] - provide hook to enforce fqn's leaking out from shared resources * [WICKET-2737] - reduce number of SpringBeanLocator#getBeanNameOfClass calls. * [WICKET-2748] - IE6 sometimes fails when using wicket ajax * [WICKET-2750] - Better error handling in modal window setContent() when a repeater is used -- Become a Wicket expert, learn from the best: http://wicketinaction.com Apache Wicket 1.4 increases type safety for web applications Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.4
Re: Igor did it!
This is looking so good that your next biggest challenge will most likely be placating the pioneers eager to get 1.5 into production! Keep up the wonderful work gentlemen ... I reckon many people would argue that there's not a great deal missing (or, importantly, superfluous!) or that could be better in core Wicket, but it looks like 1.5 is managing to simplify, and even improve, the underlying architecture. Thank you! Regards - Cemal jWeekend OO Java Technologies, Wicket Consulting, Development, Training http://jWeekend.com On 2 March 2010 13:29, Martin Grigorov mcgreg...@e-card.bg wrote: Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! On Tue, 2010-03-02 at 13:44 +0200, Martin Makundi wrote: Now there is time for RFEs ;) ? Now is time to migrate apps and see what are the benefits and what is still missing related to URL mounting/manipulation. 2010/3/2 Matej Knopp matej.kn...@gmail.com: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: [vote] release wicket 1.4.7
On Tue, Mar 2, 2010 at 2:51 PM, James Carman jcar...@carmanconsulting.com wrote: While only committers have binding votes, all votes from the community should be (and certainly are) considered. True. Though I value folks that actually test the release higher than a +1 that arrives within 2 hours of the start of a vote. I encourage anyone to vote when they have actually tested the release (download/checkout the sources, run a maven build, click through the examples or test it with your own application). A +1 just because you want a new version only muddies the result and is not as helpful. That isn't to say that these VOTE threads should be on the users@ list. If a user is interested enough in the development of the Wicket project, they should subscribe to the dev@ list also. We don't want to spam the users@ list with stuff most users don't care about. True. For important issues, such as major API breaks (like generics, or constructor change) we always consult the community at large instead of just d...@. Martijn
Re: [vote] release wicket 1.4.7
On Tue, Mar 2, 2010 at 9:11 AM, Martijn Dashorst martijn.dasho...@gmail.com wrote: True. Though I value folks that actually test the release higher than a +1 that arrives within 2 hours of the start of a vote. I encourage anyone to vote when they have actually tested the release (download/checkout the sources, run a maven build, click through the examples or test it with your own application). A +1 just because you want a new version only muddies the result and is not as helpful. Good point! Release votes need to be informed decisions. +1 (non-binding ;) True. For important issues, such as major API breaks (like generics, or constructor change) we always consult the community at large instead of just d...@. Yes, the Wicket development community is pretty good about keeping folks informed. Keep up the good work, folks. Very exciting news about the 1.5 branch today!
Re: Igor did it!
On Tue, Mar 2, 2010 at 7:52 AM, Matej Knopp matej.kn...@gmail.com wrote: On Tue, Mar 2, 2010 at 2:29 PM, Martin Grigorov mcgreg...@e-card.bg wrote: Igor did the tests but big part of the main code was your work, Matej. Big ¡Bravo! for both of you! Nah, I've done the fun stuff and Igor've done the hard work :) damn right :) -igor On Tue, 2010-03-02 at 13:44 +0200, Martin Makundi wrote: Now there is time for RFEs ;) ? Now is time to migrate apps and see what are the benefits and what is still missing related to URL mounting/manipulation. There are still some important thing missing, tests or no, it's still pre-alpha. -Matej 2010/3/2 Matej Knopp matej.kn...@gmail.com: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: Igor did it!
Hi, Just for fun, I checked what's the last test, which fails (testSimpleStaticTimeFrame). After some debugging I found out, that when you creates timeFormat in org.apache.wicket.util.time.AbstractTime, then you don't specify the Locale, so when you call setCalendar with Locale.ENGLISH and parse in the testcase, then the formatter is still running under the OS locale (in my case HU), and it tries to parse the 'h.mma' format in it, but it fails, because this is not a valid format in my locale. So this is the source of the problem, now you need to only fix it. :) (Or maybe remove the testcase if it's too specific?) Regards, Peter 2010-03-02 12:40 keltezéssel, Matej Knopp írta: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
Re: [vote] release wicket 1.4.7
Since you were referring to me Martijn, since my vote was the only one that came within 2 hours, I did test it and have been running the version that will be 1.4.7 for some time. thanks, Steve On 03/03/2010, at 1:11 AM, Martijn Dashorst wrote: On Tue, Mar 2, 2010 at 2:51 PM, James Carman jcar...@carmanconsulting.com wrote: While only committers have binding votes, all votes from the community should be (and certainly are) considered. True. Though I value folks that actually test the release higher than a +1 that arrives within 2 hours of the start of a vote. I encourage anyone to vote when they have actually tested the release (download/checkout the sources, run a maven build, click through the examples or test it with your own application). A +1 just because you want a new version only muddies the result and is not as helpful. That isn't to say that these VOTE threads should be on the users@ list. If a user is interested enough in the development of the Wicket project, they should subscribe to the dev@ list also. We don't want to spam the users@ list with stuff most users don't care about. True. For important issues, such as major API breaks (like generics, or constructor change) we always consult the community at large instead of just d...@. Martijn
Re: Igor did it!
Yeah.. someone went and localized the h:mm(a---) in java some time ago whose results are surprising. I am not completely convinced it (a) should be locale-specific (am/pm). In my opinnion the expected is wrong here, but on the other hand I am not a linguist: http://bugs.sun.com/view_bug.do?bug_id=6610748 ** Martin 2010/3/2 Major Péter majorpe...@sch.bme.hu: Hi, Just for fun, I checked what's the last test, which fails (testSimpleStaticTimeFrame). After some debugging I found out, that when you creates timeFormat in org.apache.wicket.util.time.AbstractTime, then you don't specify the Locale, so when you call setCalendar with Locale.ENGLISH and parse in the testcase, then the formatter is still running under the OS locale (in my case HU), and it tries to parse the 'h.mma' format in it, but it fails, because this is not a valid format in my locale. So this is the source of the problem, now you need to only fix it. :) (Or maybe remove the testcase if it's too specific?) Regards, Peter 2010-03-02 12:40 keltezéssel, Matej Knopp írta: All tests in Wicket Trunk pass (except that one ignored, whatever that is). Kudos to Igor! -Matej
