Re: JQuery 1.10.1 dependency also breaks many applications
I changed my mind: It's fairly easy to replace the jquery reference for
those who need an older version.
We should have added a hint to the release notes, but regretfully I
wasn't aware of the implications of the jQuery version jump.
So I don't think we need a 6.9.1 (for the jquery problem at least), but
I don't mind a rollback either.
Sven
On 07/03/2013 11:25 AM, Sven Meier wrote:
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins)) }
Problem is when you're using libraries which are using
JQueryResourceReference.get() hard coded in #getDependencies() :/.
Sven
On 07/03/2013 11:20 AM, Martin Grigorov wrote:
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
While I typically agree that using the latest stable versions of
things is a good thing™, in this case the almighty gods that maintain
jquery have decided to move deprecated APIs from versions prior to 1.9
into a migration plugin. In my opinion they did a major booboo to say
the least, and more accurately they fucked up majorly–YOU DON'T REMOVE
PUBLIC API IN A MINOR RELEASE!
Upgrading to wicket 6.9 breaks all our applications that use any
jquery plugin that was developed in the last decade. I think we should
not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've
caught that though), unless... we forcefully include the jquery
migration plugin [1] as well in 6.9 (also available for jquery 2.x).
We can make it so that the migration plugin is enabled by default for
wicket 6.x applications, and in 7.x by default disabled.
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
WDYT?
Martijn
[1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
JQuery 1.10.1 dependency also breaks many applications
While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more accurately they fucked up majorly–YOU DON'T REMOVE PUBLIC API IN A MINOR RELEASE! Upgrading to wicket 6.9 breaks all our applications that use any jquery plugin that was developed in the last decade. I think we should not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've caught that though), unless... we forcefully include the jquery migration plugin [1] as well in 6.9 (also available for jquery 2.x). We can make it so that the migration plugin is enabled by default for wicket 6.x applications, and in 7.x by default disabled. As we are already considering 6.9.1, I think we should fix this issue as well in 6.9.1. [ ] Release 6.9.1 with downgrade to jquery 1.8.3 [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin [ ] Don't fix jquery issues WDYT? Martijn [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin -- Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: JQuery 1.10.1 dependency also breaks many applications
[X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin IMHO fixes in patch releases should be as small as possible and as clean as possible. Reverting a change that broke things should fix those things again. Using a different strategy (the migration plugin) might break in other ways we do not yet know and we do not have the time to look for these breakages. For 6.10 we have plenty of time to test and the migration plugin should be fine. Best regards, Emond On Wednesday 03 July 2013 11:12:50 Martijn Dashorst wrote: While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more accurately they fucked up majorly–YOU DON'T REMOVE PUBLIC API IN A MINOR RELEASE! Upgrading to wicket 6.9 breaks all our applications that use any jquery plugin that was developed in the last decade. I think we should not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've caught that though), unless... we forcefully include the jquery migration plugin [1] as well in 6.9 (also available for jquery 2.x). We can make it so that the migration plugin is enabled by default for wicket 6.x applications, and in 7.x by default disabled. As we are already considering 6.9.1, I think we should fix this issue as well in 6.9.1. [ ] Release 6.9.1 with downgrade to jquery 1.8.3 [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin [ ] Don't fix jquery issues WDYT? Martijn [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
Re: JQuery 1.10.1 dependency also breaks many applications
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
While I typically agree that using the latest stable versions of
things is a good thing™, in this case the almighty gods that maintain
jquery have decided to move deprecated APIs from versions prior to 1.9
into a migration plugin. In my opinion they did a major booboo to say
the least, and more accurately they fucked up majorly–YOU DON'T REMOVE
PUBLIC API IN A MINOR RELEASE!
Upgrading to wicket 6.9 breaks all our applications that use any
jquery plugin that was developed in the last decade. I think we should
not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've
caught that though), unless... we forcefully include the jquery
migration plugin [1] as well in 6.9 (also available for jquery 2.x).
We can make it so that the migration plugin is enabled by default for
wicket 6.x applications, and in 7.x by default disabled.
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
WDYT?
Martijn
[1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: JQuery 1.10.1 dependency also breaks many applications
i would propose to upgrade jquery with wicket7, not before. [X] Release 6.9.1 with downgrade to jquery 1.8.3, 7.0.0 with jquery 1.10.1 and migration plugin cheers, Michael Am 03.07.2013 um 11:12 schrieb Martijn Dashorst martijn.dasho...@gmail.com : [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin
Re: JQuery 1.10.1 dependency also breaks many applications
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
How can the user know what version of jquery API wicket is compatible with?
Re: JQuery 1.10.1 dependency also breaks many applications
Upgrading to wicket 6.9 breaks all our applications Same here :/. With the removal of methods jQuery 1.9.x was a major change! [X] Release 6.9.1 with downgrade to jquery 1.8.3 Sven On 07/03/2013 11:12 AM, Martijn Dashorst wrote: While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more accurately they fucked up majorly–YOU DON'T REMOVE PUBLIC API IN A MINOR RELEASE! Upgrading to wicket 6.9 breaks all our applications that use any jquery plugin that was developed in the last decade. I think we should not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've caught that though), unless... we forcefully include the jquery migration plugin [1] as well in 6.9 (also available for jquery 2.x). We can make it so that the migration plugin is enabled by default for wicket 6.x applications, and in 7.x by default disabled. As we are already considering 6.9.1, I think we should fix this issue as well in 6.9.1. [ ] Release 6.9.1 with downgrade to jquery 1.8.3 [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin [ ] Don't fix jquery issues WDYT? Martijn [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
Re: JQuery 1.10.1 dependency also breaks many applications
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins)) }
Problem is when you're using libraries which are using
JQueryResourceReference.get() hard coded in #getDependencies() :/.
Sven
On 07/03/2013 11:20 AM, Martin Grigorov wrote:
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
While I typically agree that using the latest stable versions of
things is a good thing™, in this case the almighty gods that maintain
jquery have decided to move deprecated APIs from versions prior to 1.9
into a migration plugin. In my opinion they did a major booboo to say
the least, and more accurately they fucked up majorly–YOU DON'T REMOVE
PUBLIC API IN A MINOR RELEASE!
Upgrading to wicket 6.9 breaks all our applications that use any
jquery plugin that was developed in the last decade. I think we should
not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've
caught that though), unless... we forcefully include the jquery
migration plugin [1] as well in 6.9 (also available for jquery 2.x).
We can make it so that the migration plugin is enabled by default for
wicket 6.x applications, and in 7.x by default disabled.
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
WDYT?
Martijn
[1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: JQuery 1.10.1 dependency also breaks many applications
On Wed, Jul 3, 2013 at 12:23 PM, Thomas Matthijs li...@selckin.be wrote:
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
How can the user know what version of jquery API wicket is compatible with?
The best is to run the JS unit
testshttps://github.com/apache/wicket/tree/master/wicket-core/src/test/js
with
the version of jQuery you'd like to use.
I have ran them with 1.7.2, 1.8.2/3, 1.9.1, 1.10.0, 2.0.1
Re: JQuery 1.10.1 dependency also breaks many applications
On Wed, Jul 3, 2013 at 12:25 PM, Sven Meier s...@meiers.net wrote:
MyApp#init() {
getJavaScriptLibrarySettings()**.setJQueryReference(new
JavaScriptResourceReference(..**.,
**anyVersionThatWorksForMeUntilI**UpgradeMyAppAndPlugins))
}
Problem is when you're using libraries which are using
JQueryResourceReference.get() hard coded in #getDependencies() :/.
Time to improve - use the settings.
This is the main reason why DynamicJQueryRR has no static members ...
Sven
On 07/03/2013 11:20 AM, Martin Grigorov wrote:
On Wed, Jul 3, 2013 at 12:12 PM, Martijn Dashorst
martijn.dasho...@gmail.com wrote:
While I typically agree that using the latest stable versions of
things is a good thing™, in this case the almighty gods that maintain
jquery have decided to move deprecated APIs from versions prior to 1.9
into a migration plugin. In my opinion they did a major booboo to say
the least, and more accurately they fucked up majorly–YOU DON'T REMOVE
PUBLIC API IN A MINOR RELEASE!
Upgrading to wicket 6.9 breaks all our applications that use any
jquery plugin that was developed in the last decade. I think we should
not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've
caught that though), unless... we forcefully include the jquery
migration plugin [1] as well in 6.9 (also available for jquery 2.x).
We can make it so that the migration plugin is enabled by default for
wicket 6.x applications, and in 7.x by default disabled.
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings()**.setJQueryReference(new
JavaScriptResourceReference(..**.,
anyVersionThatWorksForMeUntilI**UpgradeMyAppAndPlugins))
}
WDYT?
Martijn
[1]
http://jquery.com/upgrade-**guide/1.9/#jquery-migrate-**pluginhttp://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: JQuery 1.10.1 dependency also breaks many applications
[X] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
We should use the time we have to check if the migration plugin does what
is expected before releasing 6.10.0. 6.9.0 is a bad release for heavy
JavaScript user.
__
Cedric Gatay (@Cedric_Gatay http://twitter.com/Cedric_Gatay)
http://code-troopers.com | http://www.bloggure.info | http://cedric.gatay.fr
On Wed, Jul 3, 2013 at 11:27 AM, Martin Grigorov mgrigo...@apache.orgwrote:
On Wed, Jul 3, 2013 at 12:23 PM, Thomas Matthijs li...@selckin.be wrote:
As we are already considering 6.9.1, I think we should fix this issue
as well in 6.9.1.
[ ] Release 6.9.1 with downgrade to jquery 1.8.3
[ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin
[ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery
1.10.1 and migration plugin
[X] Don't fix jquery issues
MyApp#init() {
getJavaScriptLibrarySettings().setJQueryReference(new
JavaScriptResourceReference(...,
anyVersionThatWorksForMeUntilIUpgradeMyAppAndPlugins))
}
How can the user know what version of jquery API wicket is compatible
with?
The best is to run the JS unit
testshttps://github.com/apache/wicket/tree/master/wicket-core/src/test/js
with
the version of jQuery you'd like to use.
I have ran them with 1.7.2, 1.8.2/3, 1.9.1, 1.10.0, 2.0.1
Re: JQuery 1.10.1 dependency also breaks many applications
[x ] Release 6.9.1 with downgrade to jquery 1.8.3: and stay stick to 1.8.3 also for future versions of Wicket 6.x While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more accurately they fucked up majorly–YOU DON'T REMOVE PUBLIC API IN A MINOR RELEASE! Upgrading to wicket 6.9 breaks all our applications that use any jquery plugin that was developed in the last decade. I think we should not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've caught that though), unless... we forcefully include the jquery migration plugin [1] as well in 6.9 (also available for jquery 2.x). We can make it so that the migration plugin is enabled by default for wicket 6.x applications, and in 7.x by default disabled. As we are already considering 6.9.1, I think we should fix this issue as well in 6.9.1. [ ] Release 6.9.1 with downgrade to jquery 1.8.3 [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin [ ] Don't fix jquery issues WDYT? Martijn [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin
Re: JQuery 1.10.1 dependency also breaks many applications
Ah we are taking here about the removal of the deprecated api not the code for other browsers. That was 2.0 yes. Couldn't look it up that easy on vacation.. But then I guess we need to stick to 1.8.x On 3 Jul 2013 12:05, Martijn Dashorst martijn.dasho...@gmail.com wrote: On Wed, Jul 3, 2013 at 11:47 AM, Johan Compagner jcompag...@gmail.com wrote: Why not just go to the latest 1.9.x? I thought that was .10 but without all the removed api? 1.9 has removed the api. Martijn On 3 Jul 2013 11:13, Martijn Dashorst martijn.dasho...@gmail.com wrote: While I typically agree that using the latest stable versions of things is a good thing™, in this case the almighty gods that maintain jquery have decided to move deprecated APIs from versions prior to 1.9 into a migration plugin. In my opinion they did a major booboo to say the least, and more accurately they fucked up majorly–YOU DON'T REMOVE PUBLIC API IN A MINOR RELEASE! Upgrading to wicket 6.9 breaks all our applications that use any jquery plugin that was developed in the last decade. I think we should not have forcefully upgraded jquery to 1.10.1 in 6.9 (we should've caught that though), unless... we forcefully include the jquery migration plugin [1] as well in 6.9 (also available for jquery 2.x). We can make it so that the migration plugin is enabled by default for wicket 6.x applications, and in 7.x by default disabled. As we are already considering 6.9.1, I think we should fix this issue as well in 6.9.1. [ ] Release 6.9.1 with downgrade to jquery 1.8.3 [ ] Release 6.9.1 with jquery 1.10.1 and jquery migration plugin [ ] Release 6.9.1 with downgrade to jquery 1.8.3, 6.10.0 with jquery 1.10.1 and migration plugin [ ] Don't fix jquery issues WDYT? Martijn [1] http://jquery.com/upgrade-guide/1.9/#jquery-migrate-plugin -- Become a Wicket expert, learn from the best: http://wicketinaction.com -- Become a Wicket expert, learn from the best: http://wicketinaction.com
