date:20170510

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
And what I meant ux is about supporting spark's native yarn-cluster mode in 
Zeppelin :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
I mean 'not in case of spark'. And this implementation satisfies your 
needs. You can launches some interpreters like md in local mode and some 
interpreters in yarn.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2336: [MINOR] Change `case` indent

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2336
  
This is minor issue and CI failure isn't related to this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
> it's improve users' experiences
Sorry, I don't understand how it improve users' experience compared the 
native spark yarn-cluster support. And does this approach mean all the 
interpreter must use the same ClusterManager ? If so, this also doesn't make 
sense to me. Because we may want to run md in local mode and spark in 
yarn-cluster mode. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2336: [MINOR] Change `case` indent

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/2336

[MINOR] Change `case` indent

### What is this PR for?
Changing style in case of 'case'. Zeppelin has two spaces as default 
indentation but checkstyle has different style of 'case'.


### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Change style and adopt it

### What is the Jira issue?
N/A

### How should this be tested?
N/A

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin minor/change-case-indent

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2336


commit 7d404a175b2fc98e21b6da109940765bfaf1d1e5
Author: Jongyoul Lee 
Date:   2017-05-10T03:27:22Z

Reformatted xml

commit f95418f7c1fc50c18d110c025da5d87d3fcea475
Author: Jongyoul Lee 
Date:   2017-05-10T03:28:07Z

Changed case indentation to 2

commit 26788c5f827157c94be62086e0d92cec526b9c34
Author: Jongyoul Lee 
Date:   2017-05-10T06:22:57Z

Adopted new style




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
It makes our logic much difficult, but it's improve users' experiences.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
In case of Spark, it has two yarn apps. I agree that it's a bit weird for 
users. Otherwise, all other interpreters like python get better to launch it in 
yarn cluster. I think it would be better to support yarn-cluster mode in case 
of Spark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
Do you mean there would be 2 yarn apps for launching one spark interpreter 
? That looks a little weird to me. In this approach, we still launch remote 
interpreter process in the zeppelin host, that doesn't solve much memory issue 
of zeppelin host. And besides it would waste yarn resources as it require to 
launch 2 yarn apps. Why not leverage spark-submit to support yarn-cluster mode 
? And I look at all the interpreters of zeppelin. Most of them are just client 
role. That means the computation happens in the backend not in the interpreter 
side. so I think it would be fine to launch these interpreters in shared/scoped 
mode for all users. Spark Interpreter would be a special case, we could use its 
native yarn-cluster support. That would be the simplest way I think. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread guptarajat

Github user guptarajat commented on the issue:

https://github.com/apache/zeppelin/pull/2323
  
"all these things are persisted and synchronized among web socket clients"
What does this mean?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread tinkoff-dwh

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
@Leemoonsoo 
the separation discussed above in the comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
@zjffdu Thanks for quick review. I know spark already have yarn-cluster by 
itself. In case of Zeppelin, SparkInterpreter will run yarn-client mode which 
means driver is still in a process zeppelin launches. at the same time, 
SparkInterpreter will run in a yarn cluster as one of application masters and 
will launch Spark's application master as a new application master in yarn 
cluster. It's fully same as spark-summit does except one thing to spark driver 
is also in yarn cluster. If you test it in a cluster, you will see like this:

![pasted image at 2017_05_04 
01_07](https://cloud.githubusercontent.com/assets/3612566/25930293/72d7c2f2-3640-11e7-9647-87985173e5b5.png)

It's launched as yarn-client mode. The application type of `ZEPPELIN 
INTERPRETER` is a driver and one of `SPARK` is a application master spark 
launches. 

BTW, I searched how livy has been supporting yarn-cluster mode and it's 
adoptable for Zeppelin, too. I'll add that feature sooner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2335
  
CI failed but irrelevant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2333
  
I don't think it's good idea to include some interpreters as dependencies 
onto zeppelin-zengine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: What is the user case for remote of interpreter option is false

2017-05-10 Thread Jeff Zhang

ClassloaderInterpreter could also be removed.


Jeff Zhang 于2017年5月10日周三 下午3:39写道：

>
> Hi moon
>
> Considering we use remote=true for interpreters now, and seems no user
> complain about that. So I think we could remove it completely. Agree with
> you that It could make code simpler, e.g. We don't need to check to use
> RemoteAngularObjectRegistry or AngularObjectRegistry.
>
>
> https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L1458
>
>
>
> Jeff Zhang 于2017年5月8日周一 下午6:15写道：
>
>> Although it can bring some benefits, but there are 2 disadvantages for
>> remote=false as I can think of
>>
>> 1. The interpreter log would mix with zeppelin server log. This may cause
>> diagnosing difficult, markdown might be OK, but I am afraid it would be a
>> problem for jdbc interpreter.
>> 2. Extra memory consumption. This might be a problem for jdbc interpreter
>> when it gets large amount of data from database.
>>
>>
>>
>> moon soo Lee 于2017年5月8日周一 下午5:27写道：
>>
>>> The option is legacy and being used in few unit tests as far as i
>>> remember.
>>>
>>> I think we can either try completely remove this code (to keep code base
>>> simple) or we can try re-introduce this feature (to optimize resource
>>> usage, less restriction on data sharing between interpreters).
>>>
>>> I think interpreters like markdown, jdbc will have no big problem with
>>> remote=false while Spark interpreter require separate JVM and remote=true
>>> is required.
>>>
>>> remote=false will provide some chances to save some system resource
>>> because
>>> it does not run separate JVM process for interpreter.
>>>
>>> Also communication between interpreter (through ResourcePool) can be much
>>> faster and have less restricted on object serialization.
>>>
>>> So remote=false option definitely provides some advantages.
>>> However, keeping code base for remote=false and remote=true introduces
>>> more
>>> work.
>>>
>>> What do you think?
>>>
>>> Thanks,
>>> moon
>>>
>>> On Mon, May 8, 2017 at 8:13 PM Jeff Zhang  wrote:
>>>
>>> > I see all the interpreter setting set remote of interpreter option as
>>> true,
>>> > and didn't find any false case in interpreter-setting.json, does anyone
>>> > know what is the use case of remote of interpreter option is false. Is
>>> this
>>> > a legacy mode that should be removed ?
>>> >
>>> >
>>> >
>>> https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java#L183
>>> >
>>>
>>

Re: What is the user case for remote of interpreter option is false

2017-05-10 Thread Jeff Zhang

Hi moon

Considering we use remote=true for interpreters now, and seems no user
complain about that. So I think we could remove it completely. Agree with
you that It could make code simpler, e.g. We don't need to check to use
RemoteAngularObjectRegistry or AngularObjectRegistry.

https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L1458



Jeff Zhang 于2017年5月8日周一 下午6:15写道：

> Although it can bring some benefits, but there are 2 disadvantages for
> remote=false as I can think of
>
> 1. The interpreter log would mix with zeppelin server log. This may cause
> diagnosing difficult, markdown might be OK, but I am afraid it would be a
> problem for jdbc interpreter.
> 2. Extra memory consumption. This might be a problem for jdbc interpreter
> when it gets large amount of data from database.
>
>
>
> moon soo Lee 于2017年5月8日周一 下午5:27写道：
>
>> The option is legacy and being used in few unit tests as far as i
>> remember.
>>
>> I think we can either try completely remove this code (to keep code base
>> simple) or we can try re-introduce this feature (to optimize resource
>> usage, less restriction on data sharing between interpreters).
>>
>> I think interpreters like markdown, jdbc will have no big problem with
>> remote=false while Spark interpreter require separate JVM and remote=true
>> is required.
>>
>> remote=false will provide some chances to save some system resource
>> because
>> it does not run separate JVM process for interpreter.
>>
>> Also communication between interpreter (through ResourcePool) can be much
>> faster and have less restricted on object serialization.
>>
>> So remote=false option definitely provides some advantages.
>> However, keeping code base for remote=false and remote=true introduces
>> more
>> work.
>>
>> What do you think?
>>
>> Thanks,
>> moon
>>
>> On Mon, May 8, 2017 at 8:13 PM Jeff Zhang  wrote:
>>
>> > I see all the interpreter setting set remote of interpreter option as
>> true,
>> > and didn't find any false case in interpreter-setting.json, does anyone
>> > know what is the use case of remote of interpreter option is false. Is
>> this
>> > a legacy mode that should be removed ?
>> >
>> >
>> >
>> https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/InterpreterSettingManager.java#L183
>> >
>>
>

[GitHub] zeppelin issue #2272: ZEPPELIN-2397. Add toJson and fromJson method for seri...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2272
  
@felixcheung toJson and fromJson is used in both zeppelin-interpreter and 
zeppelin-zengine. I didn't find a proper place to put the common interface. And 
actually the interface doesn't not eliminate the code, the sub classes still 
need to implement `toJson` as not every classes share the same Gson (some class 
need custom Gson). So I didn't add a common interface. Please help review it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2334
  
@FireArrow Could you help check the failed test ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2335
  
CI script can't parse `=` in the branch name. 

- https://travis-ci.org/1ambda/zeppelin/builds/230940304


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2335: [ZEPPELIN-2426] Improve graph setting DOMs

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/2335

[ZEPPELIN-2426] Improve graph setting DOMs

### What is this PR for?

Improve graph setting DOMs. Refer the attached screenshots.

### What type of PR is it?
[Improvement]

### Todos

* [x] - columnselector setting
* [x] - pivot setting

### What is the Jira issue?

[ZEPPELIN-2426](https://issues.apache.org/jira/browse/ZEPPELIN-2426)

### How should this be tested?

1. Display a table.
2. Click charts including scatter chart. (written with columnselector 
transformation)

### Screenshots (if appropriate)

 Before: Pivot


![image](https://cloud.githubusercontent.com/assets/4968473/25922442/34abce1e-3614-11e7-96d6-614b16d832d8.png)

 After: Pivot


![image](https://cloud.githubusercontent.com/assets/4968473/25922438/2f2243d8-3614-11e7-9ca8-cce61d338371.png)

 Before: Columnselector


![image](https://cloud.githubusercontent.com/assets/4968473/25922404/1607ccba-3614-11e7-9aa5-5861f7cdecd8.png)

 After: Columnselector


![image](https://cloud.githubusercontent.com/assets/4968473/25922411/1c1029c2-3614-11e7-9006-f9ebc1f43d08.png)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2426/improve-graph-setting=dom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2335


commit d70b379226fe08f1e3c60d0aa52167c79105e8de
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-10T04:51:50Z

fix: Remove invalid ng-if

commit 1b7c1245c439e9f73705365a1533008193db5cbb
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-10T21:32:50Z

feat: Prettify columnselector setting

commit 48b72b757e3acb5f198f382183741a3bfff561cd
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-10T21:32:58Z

feat: Prettify pivot setting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
This PR adds two new field 'widget' and 'type' to each properties.

'widget' : input, checkbox, textarea, password
'type' : number, string, boolean, url, password

How about just add single field 'type' with possible values 
"string"(input), "number", "url", "password", "checkbox", "text"(textarea) ?

@1ambda mentioned about backward compatibility. It'll help users who 
upgrade Zeppelin, if this PR reads `conf/interpreter.json` generated by 
previous version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2529) Create Base class for spark interpreter

2017-05-10 Thread Jeff Zhang (JIRA)

Jeff Zhang created ZEPPELIN-2529:


 Summary: Create Base class for spark interpreter
 Key: ZEPPELIN-2529
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2529
 Project: Zeppelin
  Issue Type: Improvement
Affects Versions: 0.7.1
Reporter: Jeff Zhang


There's many common things could be shared between spark/pyspark/sparkr 
interpreter. We could put them in a base class. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2323
  
Here's few feedbacks.

1. Table does not refreshed after height / width of paragraph change.

TBD

2. How about remove 'type' in column table option?

- Removed
- While adding tooltip for each option


![image](https://cloud.githubusercontent.com/assets/4968473/25916322/2ee4f696-35ff-11e7-806f-b31870e99fb3.png)

3. showColumnFilter

It's used to display aggregated values. I changed the name to 
`showAggregationFooter` which easier to understand than before.


![image](https://cloud.githubusercontent.com/assets/4968473/25916251/f50ef58e-35fe-11e7-84b0-d784307b1f09.png)

4. pagination

- Removed pagination related settings.


![image](https://cloud.githubusercontent.com/assets/4968473/25916292/168b7bc4-35ff-11e7-8d3f-d58dedad5aae.png)

5. Header bar in the option

- Removed the `save` button.
- Updated icon for reset and added tooltip for it.


![image](https://cloud.githubusercontent.com/assets/4968473/25916335/38401202-35ff-11e7-8712-218145675832.png)





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
As far as I Know, Zeppelin supports backward compatibility even for 
interpreter settings.

- I think we need some migration code w/ documentation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2330: [minor] Remove incorrect configuration and fix descrip...

2017-05-10 Thread VipinRathor

Github user VipinRathor commented on the issue:

https://github.com/apache/zeppelin/pull/2330
  
@prabhjyotsingh 
Thanks for reviewing this.

> any specific reason for chaning ldapRealm = 
org.apache.zeppelin.realm.LdapRealm to 
ldapRealm=org.apache.zeppelin.realm.LdapRealm in all the lines ?

Earlier there were lines with mixed spacing, I just wanted to keep it 
uniform. We can choose any one style that you want.

> I notice you have removed these two;
>
>ldapRealm.contextFactory=$ldapGroupContextFactory
>ldapRealm.contextFactory.systemAuthenticationMechanism=simple
>
> any specific reason?

Yes, if you keep the first one, Shiro will throw error that 
ldapGroupContextFactory is not defined anywhere so can't be used. And in fact, 
the sample configuration is actually not defining any such 
ldapGroupContextFactory. Instead `LdapRealm` is using `JndiLdapContextFactory` 
, so no need to override a contextFactory.

For `systemAuthenticationMechanism`, there is neither such configuration 
available in `JndiLdapContextFactory` nor `LdapRealm` introduced any. Looks 
like a left over from earlier configuration set, hence removed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2528) Add a password text input to the ZeppelinContext

2017-05-10 Thread Benjamin Vogan (JIRA)

Benjamin Vogan created ZEPPELIN-2528:


 Summary: Add a password text input to the ZeppelinContext
 Key: ZEPPELIN-2528
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2528
 Project: Zeppelin
  Issue Type: New Feature
Reporter: Benjamin Vogan
Priority: Minor


Right now it is possible to create text inputs with the ZeppelinContext 
z.input, but you cannot specify that the input should contain a password (i.e. 
a text input that should mask the input).  This would be extremely useful for 
not having to hardcode a password into a shared note.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ZEPPELIN-2527) Cursor in editor is too thick

2017-05-10 Thread Jeff Zhang (JIRA)

Jeff Zhang created ZEPPELIN-2527:


 Summary: Cursor in editor is too thick
 Key: ZEPPELIN-2527
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2527
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang


The cursor should be thin in an editor just like it is in other notebooks or IDE



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2334
  
Right, we could do it in another PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2329: [WIP][PoC] ZEPPELIN-2040 ClusterManager to support lau...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
@jongyoul Thanks for the POC. One question about the cluster mode for spark 
interpreter. It looks like you are creating a general yarn app support for all 
the interpreters. But for spark, it has already supported yarn-cluster, we 
could deploy spark interpreter as yarn-cluster mode via spark-submit. Although 
your approach may work, but I am afraid it may lose some features compared to 
the native yarn support of spark and add extra overhead of maintenance of 
feature parity between native yarn-cluster of spark and zeppelin yarn-cluster. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-10 Thread tinkoff-dwh

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
@1ambda 
i wrote about migration in upgrade.md. I'll see Notebook.java if the 
documentation is not enough


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

2017-05-10 Thread FireArrow

Github user FireArrow commented on the issue:

https://github.com/apache/zeppelin/pull/2334
  
@zjffdu I agree. A also noticed there are plenty of sketchy 
`synchrnoized`-blocks that doesn't really work as intended. But that's a 
refactor for another PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2334: [HOTFIX] Set interpreter context in zeppelin context f...

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2334
  
LGTM, BTW for a long term solution, I think we should initialize 
`ZeppelinContext` properly (including set `InterpreterContext`) in some base 
class instead of initialize in each interpreter manually. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2334: [HOTFIX] Set interpreter context in zeppelin co...

2017-05-10 Thread FireArrow

GitHub user FireArrow opened a pull request:

https://github.com/apache/zeppelin/pull/2334

[HOTFIX] Set interpreter context in zeppelin context from 
SparkSqlInterpreter

### What is this PR for?
When running %sql paragraphs the query is dispatched to the cluster, but 
when it's time to present the result a NullPointer is thrown.

This was traced back to 
`sparkInterpreter.getZeppelinContext().setInterpreterContext(context);` not 
being called as expected from SparkSqlInterpreter. Since the SparkInterpreter 
is used from the SparkSqlInterpreter, if a `%spark` paragraph is executed 
before a `%sql` paragraph it works as expected (as SparkInterpreter sets the 
interpreter context in the zeppelin context).

### What type of PR is it?
[Hot Fix]

### Todos

### What is the Jira issue?
Hotfix

### How should this be tested?
Start the spark context by executing
```
%sql
select 1
```
Expected result is a table with 1 in.
Before this patch a NullPointer will be thrown.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/FireArrow/zeppelin sqlinterpreter_hotfix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2334






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook

2017-05-10 Thread aspen01

Github user aspen01 commented on the issue:

https://github.com/apache/zeppelin/pull/1600
  
@EronWright  Thank you for your feedback. When I first developed the 
feature, I assumed that HDFS would not be used as default storage because 
remote FS failure could affect zeppelin usage. So extended VFSNotebookRepo to 
keep the default storage space on local FS and HDFS as backup storage for 
failover. This makes the implementation is simple, but it may have created 
complexity.
I'm using this feature, but I am also considering using a third-party 
storage such as HBase, because the latency of HDFS affects the latency of 
zeppelin notebooks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2323: [ZEPPELIN-2411] Improve Table

2017-05-10 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2323

Tested and overall it's great improvement!

Here's few feedbacks.

1. Table does not refreshed after height / width of paragraph change.
2. How about remove 'type' in column table option?

![image](https://cloud.githubusercontent.com/assets/1540981/25900186/94b065a4-3560-11e7-9491-4700e4228f77.png)
I guess user will be okay without knowing it.
3. showColumnFilter
Following is screenshot with 'showColumnFilter' on. I don't know what this
option supposed to do except for adding empty sticky row in the bottom.

![image](https://cloud.githubusercontent.com/assets/1540981/25900262/de274108-3560-11e7-96fb-b5a25a1298ef.png)

4. pagenation
`defaultPaginationSize ` size can be only changed after the Table is
displayed with `defaultPaginationSize ` applied. So changing default does not
mean too much in this case. Isn't it?

`availablePaginationSizes` - It's minor opinion, I think it is okay with
hardcoded value and not make user configurable.

5. Header bar in the option

![image](https://cloud.githubusercontent.com/assets/1540981/25900541/c5bd7d16-3561-11e7-9011-ae61378d39c5.png)

Two buttons - 'Save', 'Delete' icon - on right little bit confuses me. It
was difficult to guess what those button supposed to do. And figured out

'save' - apply option to the table.
'delete' - restore to default options

While option change applies immediately, how about hide 'Save' button? And
change 'delete' icon to something more appropriate? For example "Restore the
default values" text would be more intuitive.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1479: Notebook: HDFS as a backend storage (Read & Wri...

Github user hayssams closed the pull request at:

https://github.com/apache/zeppelin/pull/1479


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1479: Notebook: HDFS as a backend storage (Read & Write Mode...

Github user hayssams commented on the issue:

https://github.com/apache/zeppelin/pull/1479
  
Replaced by PR #2333 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2333: Notebook: (Web) HDFS as a backend storage (Read...

GitHub user hayssams opened a pull request:

https://github.com/apache/zeppelin/pull/2333

Notebook: (Web) HDFS as a backend storage (Read & Write Mode)

### What is this PR for ?
This PR replaces the PR-1479 by removing any hadoop dependency using 
WEBHDFS as a communication protocol (code borrowed from PR1600)
Zeppelin currently supports many backends for storing notes through Apache 
Commons VFS.
Apache Commons VFS supports HDFS in readonly mode.
This PR makes HDFS a first class citizen by allowing users to load notes 
from / save notes to HDFS.

### What type of PR is it?

### Improvement

### Todos

### Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1515

### How should this be tested?

Update zeppelin.notebook.dir property to a value like 
hdfs://localhost:9000/tmp/notebook and the property zeppelin.notebook.storage 
to the value org.apache.zeppelin.notebook.repo.HdfsNotebookRepo

check that your notes are loaded from and stored to HDFS by listing notes 
using the command :
hdfs dfs -ls /tmp/notebook

### Screenshots (if appropriate)

### Questions:

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes




You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ebiznext/zeppelin WEBHDFS

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2333.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2333


commit ebb0d7e5d62b2b9fec70756c7cd065262ae0301c
Author: Hayssam Saleh 
Date:   2017-05-10T12:02:28Z

WebHDFS Support




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2332: WebHDFS Support

Github user hayssams closed the pull request at:

https://github.com/apache/zeppelin/pull/2332


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2526) NotebookSecurityRestApiTest fails with http 302 response

2017-05-10 Thread Pravin Dsilva (JIRA)

Pravin Dsilva created ZEPPELIN-2526:
---

 Summary: NotebookSecurityRestApiTest fails with http 302 response
 Key: ZEPPELIN-2526
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2526
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Affects Versions: 0.8.0
 Environment: # cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS"
# uname -a
Linux 9efcdb4d8880 3.19.0-37-generic #42-Ubuntu SMP Fri Nov 20 18:22:05 UTC 
2015 x86_64 x86_64 x86_64 GNU/Linux

Reporter: Pravin Dsilva


5 Failed tests:
  
NotebookSecurityRestApiTest.testThatOtherUserCannotAccessNoteIfPermissionSet:81->createNoteForUser:155
 test note create method:
Expected: HTTP response <200> from /api/notebook/
 but: got <302> Found
  
NotebookSecurityRestApiTest.testThatUserCanSearchNote:115->createNoteForUser:155
 test note create method:
Expected: HTTP response <200> from /api/notebook/
 but: got <302> Found
  
NotebookSecurityRestApiTest.testThatWriterCannotRemoveNote:98->createNoteForUser:155
 test note create method:
Expected: HTTP response <200> from /api/notebook/
 but: got <302> Found
  
NotebookSecurityRestApiTest.testThatOtherUserCanAccessNoteIfPermissionNotSet:72->createNoteForUser:155
 test note create method:
Expected: HTTP response <200> from /api/notebook/
 but: got <302> Found
  
NotebookSecurityRestApiTest.testThatUserCanCreateAndRemoveNote:63->createNoteForUser:155
 test note create method:
Expected: HTTP response <200> from /api/notebook/
 but: got <302> Found




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin pull request #2332: WebHDFS Support

GitHub user hayssams opened a pull request:

https://github.com/apache/zeppelin/pull/2332

WebHDFS Support



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ebiznext/incubator-zeppelin WEBHDFS

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2332.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2332






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
Sorry for the late review. 

seems that it doesn't work with existing settings. Even can't start 
Zeppelin instance.

```
Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to 
com.google.gson.internal.StringMap
at 
org.apache.zeppelin.interpreter.InterpreterSettingManager.loadFromFile(InterpreterSettingManager.java:174)
at 
org.apache.zeppelin.interpreter.InterpreterSettingManager.init(InterpreterSettingManager.java:345)
at 
org.apache.zeppelin.interpreter.InterpreterSettingManager.(InterpreterSettingManager.java:150)
at 
org.apache.zeppelin.server.ZeppelinServer.(ZeppelinServer.java:149)
... 29 more
```

- It would be nicer to provide migration function like 
https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java#L418
- or use the default type / widget if a field doens't have (e.g `string`, 
`input`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...