[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-05 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I just checked again, but there is still a same problem. could you check 
this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2732) Flaky test - testSingleDynamicFormSelectForm

2017-07-05 Thread Lee moon soo (JIRA)
Lee moon soo created ZEPPELIN-2732:
--

 Summary: Flaky test - testSingleDynamicFormSelectForm
 Key: ZEPPELIN-2732
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2732
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Lee moon soo


Flaky test 

log - https://api.travis-ci.org/jobs/250622951/log.txt?deansi=true

{code}
Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 342.77 sec <<< 
FAILURE! - in org.apache.zeppelin.integration.ParagraphActionsIT
testSingleDynamicFormSelectForm(org.apache.zeppelin.integration.ParagraphActionsIT)
  Time elapsed: 16.79 sec  <<< FAILURE!
java.lang.AssertionError: After 'Run on selection change' checkbox is 
unchecked, the paragraph should not run if selecting a different option
Expected: "Howdy 1"
 but: was "Howdy 2"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.rules.ErrorCollector$1.call(ErrorCollector.java:65)
at org.junit.rules.ErrorCollector.checkSucceeds(ErrorCollector.java:78)
at org.junit.rules.ErrorCollector.checkThat(ErrorCollector.java:63)
at 
org.apache.zeppelin.integration.ParagraphActionsIT.testSingleDynamicFormSelectForm(ParagraphActionsIT.java:634)
{code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2466: [ZEPPELIN-2731] GetUserList with JDBCRealm should read...

2017-07-05 Thread reminia
Github user reminia commented on the issue:

https://github.com/apache/zeppelin/pull/2466
  
@Leemoonsoo plz help review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2467: [ZEPPELIN-2730] compare with maxLength after ge...

2017-07-05 Thread gaoyang143
GitHub user gaoyang143 opened a pull request:

https://github.com/apache/zeppelin/pull/2467

[ZEPPELIN-2730]  compare with maxLength after getting all file status

### What is this PR for?
when set hdfs.maxLength to a lower value like 10, get result no such file 
or directory


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* https://issues.apache.org/jira/browse/ZEPPELIN-2730

### How should this be tested?
set hdfs.maxLength to 10, if it can get right result

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaoyang143/zeppelin zeppelin-2730

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2467.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2467


commit dcb8648895c2ecd1dd20077ef66a0f0ea5a1e12f
Author: gaoyang 
Date:   2017-07-06T03:22:31Z

compare with maxLength after getting all file status

commit dd266dea657a281339e8bdbaf71822950379ad71
Author: gaoyang 
Date:   2017-07-06T04:34:20Z

delete useless code




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2466: [ZEPPELIN-2731] GetUserList with JDBCRealm shou...

2017-07-05 Thread reminia
GitHub user reminia opened a pull request:

https://github.com/apache/zeppelin/pull/2466

[ZEPPELIN-2731] GetUserList with JDBCRealm should read field authenti…

…cationQuery

### What is this PR for?
GetUserList with JDBCRealm should read field authenticationQuery but not 
DEFAULT_AUTHENTICATION_QUERY,
or it will assume that the query must be "select password from users where 
username = ?"

### What type of PR is it?
[Bug Fix]

### Todos
None

### What is the Jira issue?
* https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-2731

### How should this be tested?
1. In shiro.ini config the JDBCRealm like:

ds = org.apache.commons.dbcp2.BasicDataSource
ds.driverClassName = com.mysql.jdbc.Driver
ds.url= jdbc:mysql://localhost:3306/shiro
ds.username = root
ds.password = 123456

jdbcRealm = org.apache.shiro.realm.jdbc.JdbcRealm
jdbcRealm.dataSource = $ds
jdbcRealm.permissionsLookupEnabled = false
jdbcRealm.authenticationQuery = SELECT password FROM user WHERE name = ?
jdbcRealm.userRolesQuery = SELECT role_name FROM user_roles WHERE name  = ?
jdbcRealm.permissionsQuery = SELECT permission FROM roles_permissions WHERE 
role_name = ?

2. login and request the rest
Get /security/userlist/youruser


### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/reminia/zeppelin zeppelin-2731

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2466.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2466


commit 84b3fded3ae95817c410b8ed1cdc061e853a6d02
Author: lichenyang 
Date:   2017-07-06T04:36:55Z

[ZEPPELIN-2731] GetUserList with JDBCRealm should read field 
authenticationQuery




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2465: [ZEPPELIN-2724] Move NotebookSocket.send() out ...

2017-07-05 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/2465

[ZEPPELIN-2724] Move NotebookSocket.send() out of synchronized block

### What is this PR for?
This PR tries to address 
https://issues.apache.org/jira/browse/ZEPPELIN-2724.

### What type of PR is it?
Bug Fix

### Todos
* [x] - Move NotebookSocket.send() out of synchronized block
* [ ] - Waits for verification this actually fixes the problem

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2724

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2724

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2465


commit c01246c24622f09f4ed2b574cf21eac865df8448
Author: Lee moon soo 
Date:   2017-07-06T04:22:01Z

Move NotebookSocket.send() out of synchronized block




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2731) GetUserList with JDBCRealm should read field authenticationQuery

2017-07-05 Thread slee (JIRA)
slee created ZEPPELIN-2731:
--

 Summary: GetUserList with JDBCRealm should read field 
authenticationQuery
 Key: ZEPPELIN-2731
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2731
 Project: Zeppelin
  Issue Type: Bug
Reporter: slee


GetUserList with JDBCRealm should read field authenticationQuery but  not 
DEFAULT_AUTHENTICATION_QUERY,

or it will assume that the query must be "select password from users where 
username = ?"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
Sounds good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2459: [ZEPPELIN-2716] Change the default value of zeppelin.l...

2017-07-05 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2459
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
Hm... let me check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
@jongyoul  I try to run shell interpreter in yarn mode.

```
 INFO [2017-07-06 10:32:28,538] ({qtp633070006-49} 
AbstractService.java[noteFailure]:272) - Service 
org.apache.hadoop.yarn.client.api.impl.YarnClientImpl failed in state STARTED; 
cause: org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed to load 
class: 
[org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl]
org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed to load 
class: 
[org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl]
at 
org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl.getClient(RpcClientFactoryPBImpl.java:67)
at 
org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.getProxy(HadoopYarnProtoRPC.java:48)
at org.apache.hadoop.yarn.client.RMProxy$1.run(RMProxy.java:140)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:360)
at 
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1608)
at org.apache.hadoop.yarn.client.RMProxy.getProxy(RMProxy.java:136)
at org.apache.hadoop.yarn.client.RMProxy.createRMProxy(RMProxy.java:99)
at 
org.apache.hadoop.yarn.client.ClientRMProxy.createRMProxy(ClientRMProxy.java:72)
at 
org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.serviceStart(YarnClientImpl.java:174)
at 
org.apache.hadoop.service.AbstractService.start(AbstractService.java:193)
at org.apache.zeppelin.cluster.yarn.Client.start(Client.java:76)
at 
org.apache.zeppelin.cluster.yarn.Client.createInterpreter(Client.java:106)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.getInterpreterProcess(RemoteInterpreter.java:196)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.getScheduler(RemoteInterpreter.java:527)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.getScheduler(LazyOpenInterpreter.java:129)
at org.apache.zeppelin.notebook.Note.run(Note.java:656)
at 
org.apache.zeppelin.socket.NotebookServer.persistAndExecuteSingleParagraph(NotebookServer.java:1800)
at 
org.apache.zeppelin.socket.NotebookServer.runParagraph(NotebookServer.java:1760)
at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:283)
at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at 
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at 
org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at 
org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at 
org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at 
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassNotFoundException: Class 
org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl 
not found
at 
org.apache.hadoop.conf.Configuration.getClassByName(Configuration.java:1980)
at 
org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl.getClient(RpcClientFactoryPBImpl.java:65)
... 35 more
ERROR [2017-07-06 10:32:28,539] ({qtp633070006-49} 
NotebookServer.java[persistAndExecuteSingleParagraph]:1802) - Exception from run
org.apache.hadoop.yarn.exceptions.YarnRuntimeException: Failed to load 
class: 
[org.apache.hadoop.yarn.api.impl.pb.client.ApplicationClientProtocolPBClientImpl]
at 
org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl.getClient(RpcClientFactoryPBImpl.java:67)
at 

[GitHub] zeppelin issue #2459: [ZEPPELIN-2716] Change the default value of zeppelin.l...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2459
  
Thanks @jerryshao LGTM will merge it if no more discussion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2730) when set hdfs.maxLength to a lower value like 10, get result of no such file or directory

2017-07-05 Thread gao yang (JIRA)
gao yang created ZEPPELIN-2730:
--

 Summary: when set hdfs.maxLength to a lower value like 10, get 
result of no such file or directory
 Key: ZEPPELIN-2730
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2730
 Project: Zeppelin
  Issue Type: Bug
Reporter: gao yang


set hdfs.maxLength = 10, command is "ls -l", output is "no  such file or 
directory". It may cause by wrong code of maxLength



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2418: [ZEPPELIN-2645] Adding way to register RemoteInterpret...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2418
  
@echarles Hi, at first, if we enable front-end to access to interpreter 
directly, we have to consider that each interpreter has to know whole ACL 
information and etc. I don't think it's good design. Second, netty has a 
benefit while making connections between server and interpreter. It can be 
handled one connection for bidirectional communication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2455: ZEPPELIN-1515. Notebook: HDFS as a backend storage (Us...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2455
  
@jongyoul Yeah, since your PR is also using the hadoop jar. I think we need 
to do 2 things:
* Use the same hadoop jar version
* Decide whether include it in distribution or not. For this, I personally 
prefer to include the hadoop jar in distribution. Several Reasons:
  - It is much easy to implement, we don't need to find the jars at runtime 
by ourselves.
  - Zeppelin might be installed in a gateway machine where hadoop is not 
installed, in this case, zeppelin would not work because if could not find the 
hadoop jars.  
  - Spark put hadoop jar in its distribution and approve it can work, so I 
think we can trust this approach. 

Let me know your concern, thanks. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
You refactoring PR is already huge. I think creating new PR would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
Thanks @Leemoonsoo , Agree to move them to spark interpreter instead of 
`RemoteInterpreter`, it is actually on my plan of interpreter refactoring.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2455: ZEPPELIN-1515. Notebook: HDFS as a backend storage (Us...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2455
  
@zjffdu Almost conflicts will be removed by extracting jars but how we 
guarantee those libraries are not related my features? I'm just curious.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2438: [ZEPPELIN-2693] Test: interpreter mode action t...

2017-07-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2438


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661]Test: personalized mode action

2017-07-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2415


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2456: [ZEPPELIN-2714] Soft-code Spark UI button visualizatio...

2017-07-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2456
  
Merge to master if no further comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2017-07-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
I agree on the direction of this PR. But on the implementation I wish we 
try keep `class RemoteInterpreter` interpreter independent as much as possible.

This PR adds spark specific code to 
`RemoteInterpreter.getEnvFromInterpreterProperty()`.
And we used to have spark specific code in `bin/interpreter.sh`.

In the future, it'll be better if we provide generic facility in both 
`bin/interpreter.sh` and `class RemoteInterpreter` and move all spark specific 
code into spark interpreter module.

What do you think @zjffdu? This doesn't need to be addressed in this PR but 
if you think it's right direction, i wish we at least create a issue for it, so 
we can keep track on it.

Other than that, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2463: Fix zeppelin-web development mode

2017-07-05 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2463


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1499: [ZEPPELIN-1528] Add progress information in add...

2017-07-05 Thread sadikovi
Github user sadikovi closed the pull request at:

https://github.com/apache/zeppelin/pull/1499


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2729) Paragraph numbering

2017-07-05 Thread Timo (JIRA)
Timo created ZEPPELIN-2729:
--

 Summary: Paragraph numbering
 Key: ZEPPELIN-2729
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2729
 Project: Zeppelin
  Issue Type: Improvement
  Components: front-end, GUI
Reporter: Timo
Priority: Minor


It would be very useful if paragraphs could be visibly numbered to make 
collaboration easier. This could be an option in the dropdown menu (show/hide 
paragraph numbers).

Jupyter also takes this approach.

Use case:
When collaborating over the telephone, it was awkward to explain which 
paragraph we are referring to "the paragraph after the second bar chart with 
the blue axes". It could be as easy as "Paragraph 12..."



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2329: [ZEPPELIN-2040] ClusterManager to support launching in...

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2329
  
Fixed all comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2728) [FRONT-BUILD] Use webpack for html files

2017-07-05 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2728:
---

 Summary: [FRONT-BUILD] Use webpack for html files
 Key: ZEPPELIN-2728
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2728
 Project: Zeppelin
  Issue Type: Sub-task
  Components: build, front-end
Reporter: Hoon Park


Currently, html is managed by grunt. So it's slow when refreshing, developing, 
...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
it was an honor to make more correct, concise documentation with your help. 

Merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2727) [FRONT-BUILD] Use proper directory structure not to copy all duplicated asset files

2017-07-05 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2727:
---

 Summary: [FRONT-BUILD] Use proper directory structure not to copy 
all duplicated asset files
 Key: ZEPPELIN-2727
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2727
 Project: Zeppelin
  Issue Type: Sub-task
  Components: build, front-end
Reporter: Hoon Park


Currently, we are copying assets when building frontend project. 

But if we set up proper directory structure, we don't need to do that and it 
will reduce build time as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ZEPPELIN-2726) [FRONT-BUILD] Use npm packages instead of bower packages

2017-07-05 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2726:
---

 Summary: [FRONT-BUILD] Use npm packages instead of bower packages
 Key: ZEPPELIN-2726
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2726
 Project: Zeppelin
  Issue Type: Sub-task
  Components: build, front-end
Reporter: Hoon Park


bower is still maintained, but it's not developed anymore. They are 
recommending to use yarn or npm, so we need to use replace bower.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-05 Thread cacti77
Github user cacti77 commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
@1ambda And it looks good to me too; thanks for being patient and making 
all those changes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2725) [Umbrella] Improve front-end (zeppelin-web) build system

2017-07-05 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2725:
---

 Summary: [Umbrella] Improve front-end (zeppelin-web) build system
 Key: ZEPPELIN-2725
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2725
 Project: Zeppelin
  Issue Type: Improvement
  Components: build, front-end
Reporter: Hoon Park


We have improved frontend build tools a lot. But it's still quite outdated. I 
suggest that get more recent tech stack and build tools so that more frontend 
developers get involved. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@1ambda on 1. yes, we would need to implement renaming for other repos and 
i was planning to do it for S3, Azure right after this PR. As an alternative to 
adding this method to interface, could be having another interface, say 
`Renamable` and any storage that wants to support extension, naming, folder 
structure would implement it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@1ambda good point, we can make both possible. i'll modify it to support 
both config then through dropdown


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2724) Zeppelin gets stuck with java.lang.Thread.State: BLOCKED (on object monitor)

2017-07-05 Thread Sergey Mazin (JIRA)
Sergey Mazin created ZEPPELIN-2724:
--

 Summary: Zeppelin gets stuck with java.lang.Thread.State: BLOCKED 
(on object monitor)
 Key: ZEPPELIN-2724
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2724
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Affects Versions: 0.7.2, 0.8.0
Reporter: Sergey Mazin


We are using Zeppelin in 10+ active users environment. At least 2-3 times per 
day Zeppelin hangs with no errors in log files.

I checked Jstack and looks like Zeppelin is waiting for lock on some resource, 
which is locked by other thread.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2429: [ZEPPELIN-2675] Distributing Jars when using an extern...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2429
  
Hi! Thanks for the contribution. @marcotagliabue.

It looks like useful! 

1. Please fix the failed CI
2. Would be nice to rebase to update the outdated base branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
Please let me know if we need to add / improve / modify something. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2440
  
@herval 

1. Could you rebase? base branch is quite old
2. We need to pass CI. Please the failed tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2440: [ZEPPELIN-2587] allow logging in if you're anonymous

2017-07-05 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2440
  
@1ambda can you check this issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2460
  
@soralee Thanks for quick update

Title and logo are placed outside of navbar


![image](https://user-images.githubusercontent.com/4968473/27860619-525c15c0-61b8-11e7-8068-cf6230cb44f5.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2723) [gh-pages] fix hover event in technologies section on mobile

2017-07-05 Thread Sora Lee (JIRA)
Sora Lee created ZEPPELIN-2723:
--

 Summary: [gh-pages] fix hover event in technologies section on 
mobile
 Key: ZEPPELIN-2723
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2723
 Project: Zeppelin
  Issue Type: Bug
Reporter: Sora Lee
Assignee: Sora Lee


A hover doesn't work in mobile properly when you touch whatever spark or sql or 
python.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode

2017-07-05 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2463
  
Thanks @tinkoff-dwh  @prabhjyotsingh @1ambda @soralee  for review.

Merge to master 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2464: [ZEPPELIN-2722]. Use Note.toJson and fromJson in Zeppe...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2464
  
Straightforward change, please help review, @jongyoul 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2464: [ZEPPELIN-2722]. Use Note.toJson and fromJson i...

2017-07-05 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2464

[ZEPPELIN-2722]. Use Note.toJson and fromJson in ZeppelinHubRepo

### What is this PR for?
It's a following up of ZEPPELIN-2397. Otherwise ZeppelinHubRepo can not 
load/save note properly



### What type of PR is it?
[Bug Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2722

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2722

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2464


commit 39c8b5d3838a10b9e99bd8e6e17c1b7fc43836e5
Author: Jeff Zhang 
Date:   2017-07-05T09:18:42Z

ZEPPELIN-2722. Use Note.toJson and fromJson in ZeppelinHubRepo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2722) Use Note.toJson and fromJson in ZeppelinHubRepo

2017-07-05 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2722:


 Summary: Use Note.toJson and fromJson in ZeppelinHubRepo
 Key: ZEPPELIN-2722
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2722
 Project: Zeppelin
  Issue Type: Bug
Reporter: Jeff Zhang


It's a following up of ZEPPELIN-2397. Otherwise ZeppelinHubRepo can not 
load/save note properly



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-07-05 Thread andreaTP
Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
I think this issue is addressed 
https://github.com/apache/zeppelin/pull/2463 I'm not sure if having a switch 
for prod and dev is good BTW 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-05 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Could you remove the `{{ $root.pageTitle }}` word when loading page like 
this?

![title](https://user-images.githubusercontent.com/8110458/27855590-fdc1a76c-61a5-11e7-9940-028ae2c60597.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2721) A notebook to be black box

2017-07-05 Thread ono keiji (JIRA)
ono keiji created ZEPPELIN-2721:
---

 Summary: A notebook to be black box
 Key: ZEPPELIN-2721
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2721
 Project: Zeppelin
  Issue Type: New Feature
Reporter: ono keiji



For example i set strict roles  into my notebook, and share it with someone who 
has their zeppelin. After they download and import my strict auth notebook into 
their zeppelin, they can arrange my roles setting by themselves. In this case, 
they can see my hided code on their zeppelin.
To prevent this issue, may need another authenticate/management feature on 
Zeppelin.

What for it, imagine such a case.
In the case of selling my big data analyze application through zeppelin 
eco-system, i write and test my code on my zeppelin. Then export it and upload 
to sharing site.
May someone see my sharing notebook on the site, then they download and import 
it into their zeppelin, and execute it,
But i would like to get some revenue from my code if someone go down my 
analyzing, hopefully.
In this case, i just want to provide the result of analyzing, not my algorithm. 
Even my client share my notebook on his zeppelin, my code is protected by 
independent authentication, encryption and so on.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode

2017-07-05 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2463
  
Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1446: ZEPPELIN-1263. Should specify zeppelin's spark configu...

2017-07-05 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1446
  
@jongyoul @Leemoonsoo @felixcheung Would you mind to take a look at this PR 
? This issue blocks 
[ZEPPELIN-2715](https://issues.apache.org/jira/browse/ZEPPELIN-2715), 
[ZEPPELIN-2720](https://issues.apache.org/jira/browse/ZEPPELIN-2720) which I 
think is very critical. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2720) spark.driver.memory won't take effect for zeppelin spark interpreter

2017-07-05 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2720:


 Summary: spark.driver.memory won't take effect for zeppelin spark 
interpreter
 Key: ZEPPELIN-2720
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2720
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.2
Reporter: Jeff Zhang
Priority: Critical






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2446
  
@necosta I installed 2 visualization packages but failed to get the order 
of them.


![image](https://user-images.githubusercontent.com/4968473/27852165-05847144-6199-11e7-9081-ad0ad1d2a5a7.png)

![image](https://user-images.githubusercontent.com/4968473/27852180-0c4ab5ba-6199-11e7-9630-4630d110ae1e.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
> persist on run is also another idea that could work, and would be nice to 
know opinion of more people on that. generally in that case save would be 
dependent on run, and commit would stay as before. @1ambda @Leemoonsoo what do 
you think about that?

One suggestion. Can we provide a dropdown for this option? 

- persist on running
- persist on commit 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
Tested locally and works 3 in 2 cases (creating, renaming)

I have a question. Subclasses of the`NotebookRepo` have auto-generated 
method `rename`. That  means, If we want to rename for that repos, should we 
implement those methods later?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
resolved @zjffdu's comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode

2017-07-05 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2463
  
Tested locally, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---