[GitHub] zeppelin issue #2925: ZEPPELIN-3404. Fail to run cronjob when user doesn't r...

[mebelousov]

Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2925
  
@weand Thank you!
Some addition to 2.
Over time user may not belong to group.
At first we could store cronExecutingRoles and in future it's to be good to 
check groups on the fly.


---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2905
  
@jongyoul I tried this PR and download the pig interpreter, and found 
several issues.
1. The helium.json still use plugin of 0.7.2, but my zeppelin server is on 
0.9 (master). Zeppelin should display the valid interpreter plugins.
2. I enable zeppelin-pig plugin, and it is downloaded to my local folder 
interpreter/zeppelin-pig, but I don't think it is correct, because it should be 
interpreter/pig 


---

[GitHub] zeppelin issue #2905: ZEPPELIN-3382 Installing interpreter from UI

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2905
  
@zjffdu Can you check it again?


---

[jira] [Created] (ZEPPELIN-3422) Add JMX support

[Jongyoul Lee (JIRA)]

Jongyoul Lee created ZEPPELIN-3422:
--

 Summary: Add JMX support
 Key: ZEPPELIN-3422
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3422
 Project: Zeppelin
  Issue Type: New Feature
Reporter: Jongyoul Lee
Assignee: Jongyoul Lee


It would be better to add some properties and state supported by JMX



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2903
  
looks good!
merging if no more comment


---

[jira] [Created] (ZEPPELIN-3421) Skip running unit test when hitting failed test.

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3421:


 Summary: Skip running unit test when hitting failed test. 
 Key: ZEPPELIN-3421
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3421
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [DISCUSS] Adjust test logs for CI

[Jongyoul Lee]

I like this idea!!

On Mon, Apr 23, 2018 at 12:14 PM, Jeff Zhang  wrote:

> Another thing we can do is to skip the remaining test when we hit test
> failure. Currently, zeppelin wont't stop run testing code even hit failed
> test.
>
> http://maven.apache.org/surefire/maven-surefire-
> plugin/examples/skip-after-failure.html
>
>
> Jeff Zhang 于2018年4月23日周一 上午11:00写道：
>
> >
> > Regarding selenium test, I agree with you that the log in selenium is
> > almost useless. It is hard to figure out what's wrong when selenium test
> > fails. Maybe other frontend expert can help on that.
> >
> >
> >
> > Jongyoul Lee 于2018年4月23日周一 上午10:55写道：
> >
> >> @felix,
> >> We can enforce to set different log level like ERROR or WARN but I don't
> >> think it's a proper solution.
> >>
> >> @Jeff,
> >> I found current master might have a problem with Integration test of
> using
> >> Selenium but It's hard to see all logs from that tests because there are
> >> so
> >> many unrelated logs like "sleep...". I can fix this issue, but
> generally,
> >> I
> >> think every contributor doesn't want to see unrelated logs except my
> >> tests.
> >> When developing a new feature, it would be helpful to see debugger/test
> >> logs but after it's implemented, I think it's a bit less-useful and
> it's a
> >> bit bothersome for another developer.
> >>
> >> So it would be better to have a consensus to do our best to reduce my
> >> logs,
> >> especially made by test cases.
> >>
> >> How do you think of it?
> >>
> >> JL
> >>
> >> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang  wrote:
> >>
> >> > Jongyoul,
> >> >
> >> > What kind of problem do you have ? Each module has log4j.properties
> >> under
> >> > its test folder that we can change the log level.
> >> >
> >> >
> >> >
> >> > Felix Cheung 于2018年4月23日周一 上午3:52写道：
> >> >
> >> > > Is there a way to do this via enable/disable component for logging
> in
> >> > > log4j?
> >> > >
> >> > > 
> >> > > From: Jongyoul Lee 
> >> > > Sent: Sunday, April 22, 2018 7:01:54 AM
> >> > > To: dev
> >> > > Subject: [DISCUSS] Adjust test logs for CI
> >> > >
> >> > > Hello contributors,
> >> > >
> >> > > I wonder how you guys think of reducing test logs to help to debug
> >> with
> >> > CI.
> >> > > Recently, Zeppelin's Travis log is too big to read anything.
> >> > >
> >> > > So I suggest these kinds of step:
> >> > > 1. leave test logs as much as you want to test your code passed in
> CI
> >> > > 2. If passed, please remove all of your test's logs
> >> > >
> >> > > How do you think of your guys? I know and understand our CI is not
> >> good
> >> > for
> >> > > running multiple times with same code because of lack of resources.
> >> > >
> >> > > Best regards,
> >> > > Jongyoul Lee
> >> > >
> >> > > --
> >> > > 이종열, Jongyoul Lee, 李宗烈
> >> > > http://madeng.net
> >> > >
> >> >
> >>
> >>
> >>
> >> --
> >> 이종열, Jongyoul Lee, 李宗烈
> >> http://madeng.net
> >>
> >
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin pull request #2934: [ZEPPELIN-3417] fix dependency in zeppelin-web/...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2934


---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2936
  
Will merge it without any issues


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2937
  
It is just used in 2 places, synchronized should be fine. ReadWriteLock is 
more suitable for the scenario of many reads & a few write


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2937
  
It is just used in 2 places, synchronized should be fine. ReadWriteLock is 
more suitable for the scenario of many reads & a few write


---

[GitHub] zeppelin pull request #:

[prabhjyotsingh]

Github user prabhjyotsingh commented on the pull request:


https://github.com/apache/zeppelin/commit/f4a798b6230b4f2389ad7ea9b41818b15d9ab5a7#commitcomment-28690929
  
@bern80 do you mind creating an issue for the same if it is not working? 
will try to look into it.


---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2936
  
Test passed. https://travis-ci.org/jongyoul/zeppelin/builds/369747157


---

[GitHub] zeppelin pull request #2923: ZEPPELIN-3312 Add option to convert username to...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2923


---

[GitHub] zeppelin pull request #2932: [ZEPPELIN-3415] Fix export notebook functionali...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2932


---

[GitHub] zeppelin issue #2933: [ZEPPELIN-3416] Bump up the version of xercesImpl to 2...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2933
  
Merging this if no more discussion.


---

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2937
  
IMHO, it would be better to use 
[ReentrantReadWriteLock](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/locks/ReentrantReadWriteLock.html).
 What do you think of it?


---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2935
  

![image](https://user-images.githubusercontent.com/3612566/39105199-8439d0ce-46ef-11e8-8885-1666dbf47a09.png)


![image](https://user-images.githubusercontent.com/3612566/39105205-9077f078-46ef-11e8-97fe-9d4fd53a1b64.png)


![image](https://user-images.githubusercontent.com/3612566/39105291-ff54b166-46ef-11e8-9168-60df1998cb25.png)

@zjffdu I've received this issue report from one of my colleagues that he 
ran a wrong code to read all of the data from a large directory and it took for 
20mins with a spark job and he tried to stop a spark interpreter. and Then he 
tried to create a new note, but he couldn't see an interpreter lists from 
creating note page and a list-interpreter when clicking a button on a note.

BUT I've tried to make it with current master into my local but it fails 
because 'restart' always work fine. It looks only until 0.7.3.

Generally, this code doesn't a problem anymore in current master and 
branch-0.8, but this kind of synchronized blocks don't look good. I prefer to 
change it but it's not a bug now. What do you think of it?


---

Re: [DISCUSS] Adjust test logs for CI

[Jeff Zhang]

Another thing we can do is to skip the remaining test when we hit test
failure. Currently, zeppelin wont't stop run testing code even hit failed
test.

http://maven.apache.org/surefire/maven-surefire-plugin/examples/skip-after-failure.html


Jeff Zhang 于2018年4月23日周一 上午11:00写道：

>
> Regarding selenium test, I agree with you that the log in selenium is
> almost useless. It is hard to figure out what's wrong when selenium test
> fails. Maybe other frontend expert can help on that.
>
>
>
> Jongyoul Lee 于2018年4月23日周一 上午10:55写道：
>
>> @felix,
>> We can enforce to set different log level like ERROR or WARN but I don't
>> think it's a proper solution.
>>
>> @Jeff,
>> I found current master might have a problem with Integration test of using
>> Selenium but It's hard to see all logs from that tests because there are
>> so
>> many unrelated logs like "sleep...". I can fix this issue, but generally,
>> I
>> think every contributor doesn't want to see unrelated logs except my
>> tests.
>> When developing a new feature, it would be helpful to see debugger/test
>> logs but after it's implemented, I think it's a bit less-useful and it's a
>> bit bothersome for another developer.
>>
>> So it would be better to have a consensus to do our best to reduce my
>> logs,
>> especially made by test cases.
>>
>> How do you think of it?
>>
>> JL
>>
>> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang  wrote:
>>
>> > Jongyoul,
>> >
>> > What kind of problem do you have ? Each module has log4j.properties
>> under
>> > its test folder that we can change the log level.
>> >
>> >
>> >
>> > Felix Cheung 于2018年4月23日周一 上午3:52写道：
>> >
>> > > Is there a way to do this via enable/disable component for logging in
>> > > log4j?
>> > >
>> > > 
>> > > From: Jongyoul Lee 
>> > > Sent: Sunday, April 22, 2018 7:01:54 AM
>> > > To: dev
>> > > Subject: [DISCUSS] Adjust test logs for CI
>> > >
>> > > Hello contributors,
>> > >
>> > > I wonder how you guys think of reducing test logs to help to debug
>> with
>> > CI.
>> > > Recently, Zeppelin's Travis log is too big to read anything.
>> > >
>> > > So I suggest these kinds of step:
>> > > 1. leave test logs as much as you want to test your code passed in CI
>> > > 2. If passed, please remove all of your test's logs
>> > >
>> > > How do you think of your guys? I know and understand our CI is not
>> good
>> > for
>> > > running multiple times with same code because of lack of resources.
>> > >
>> > > Best regards,
>> > > Jongyoul Lee
>> > >
>> > > --
>> > > 이종열, Jongyoul Lee, 李宗烈
>> > > http://madeng.net
>> > >
>> >
>>
>>
>>
>> --
>> 이종열, Jongyoul Lee, 李宗烈
>> http://madeng.net
>>
>

Re: [DISCUSS] Adjust test logs for CI

[Jeff Zhang]

Regarding selenium test, I agree with you that the log in selenium is
almost useless. It is hard to figure out what's wrong when selenium test
fails. Maybe other frontend expert can help on that.



Jongyoul Lee 于2018年4月23日周一 上午10:55写道：

> @felix,
> We can enforce to set different log level like ERROR or WARN but I don't
> think it's a proper solution.
>
> @Jeff,
> I found current master might have a problem with Integration test of using
> Selenium but It's hard to see all logs from that tests because there are so
> many unrelated logs like "sleep...". I can fix this issue, but generally, I
> think every contributor doesn't want to see unrelated logs except my tests.
> When developing a new feature, it would be helpful to see debugger/test
> logs but after it's implemented, I think it's a bit less-useful and it's a
> bit bothersome for another developer.
>
> So it would be better to have a consensus to do our best to reduce my logs,
> especially made by test cases.
>
> How do you think of it?
>
> JL
>
> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang  wrote:
>
> > Jongyoul,
> >
> > What kind of problem do you have ? Each module has log4j.properties under
> > its test folder that we can change the log level.
> >
> >
> >
> > Felix Cheung 于2018年4月23日周一 上午3:52写道：
> >
> > > Is there a way to do this via enable/disable component for logging in
> > > log4j?
> > >
> > > 
> > > From: Jongyoul Lee 
> > > Sent: Sunday, April 22, 2018 7:01:54 AM
> > > To: dev
> > > Subject: [DISCUSS] Adjust test logs for CI
> > >
> > > Hello contributors,
> > >
> > > I wonder how you guys think of reducing test logs to help to debug with
> > CI.
> > > Recently, Zeppelin's Travis log is too big to read anything.
> > >
> > > So I suggest these kinds of step:
> > > 1. leave test logs as much as you want to test your code passed in CI
> > > 2. If passed, please remove all of your test's logs
> > >
> > > How do you think of your guys? I know and understand our CI is not good
> > for
> > > running multiple times with same code because of lack of resources.
> > >
> > > Best regards,
> > > Jongyoul Lee
> > >
> > > --
> > > 이종열, Jongyoul Lee, 李宗烈
> > > http://madeng.net
> > >
> >
>
>
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>

Re: [DISCUSS] Adjust test logs for CI

[Jongyoul Lee]

@felix,
We can enforce to set different log level like ERROR or WARN but I don't
think it's a proper solution.

@Jeff,
I found current master might have a problem with Integration test of using
Selenium but It's hard to see all logs from that tests because there are so
many unrelated logs like "sleep...". I can fix this issue, but generally, I
think every contributor doesn't want to see unrelated logs except my tests.
When developing a new feature, it would be helpful to see debugger/test
logs but after it's implemented, I think it's a bit less-useful and it's a
bit bothersome for another developer.

So it would be better to have a consensus to do our best to reduce my logs,
especially made by test cases.

How do you think of it?

JL

On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang  wrote:

> Jongyoul,
>
> What kind of problem do you have ? Each module has log4j.properties under
> its test folder that we can change the log level.
>
>
>
> Felix Cheung 于2018年4月23日周一 上午3:52写道：
>
> > Is there a way to do this via enable/disable component for logging in
> > log4j?
> >
> > 
> > From: Jongyoul Lee 
> > Sent: Sunday, April 22, 2018 7:01:54 AM
> > To: dev
> > Subject: [DISCUSS] Adjust test logs for CI
> >
> > Hello contributors,
> >
> > I wonder how you guys think of reducing test logs to help to debug with
> CI.
> > Recently, Zeppelin's Travis log is too big to read anything.
> >
> > So I suggest these kinds of step:
> > 1. leave test logs as much as you want to test your code passed in CI
> > 2. If passed, please remove all of your test's logs
> >
> > How do you think of your guys? I know and understand our CI is not good
> for
> > running multiple times with same code because of lack of resources.
> >
> > Best regards,
> > Jongyoul Lee
> >
> > --
> > 이종열, Jongyoul Lee, 李宗烈
> > http://madeng.net
> >
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

Re: [DISCUSS] Adjust test logs for CI

[Jeff Zhang]

Jongyoul,

What kind of problem do you have ? Each module has log4j.properties under
its test folder that we can change the log level.



Felix Cheung 于2018年4月23日周一 上午3:52写道：

> Is there a way to do this via enable/disable component for logging in
> log4j?
>
> 
> From: Jongyoul Lee 
> Sent: Sunday, April 22, 2018 7:01:54 AM
> To: dev
> Subject: [DISCUSS] Adjust test logs for CI
>
> Hello contributors,
>
> I wonder how you guys think of reducing test logs to help to debug with CI.
> Recently, Zeppelin's Travis log is too big to read anything.
>
> So I suggest these kinds of step:
> 1. leave test logs as much as you want to test your code passed in CI
> 2. If passed, please remove all of your test's logs
>
> How do you think of your guys? I know and understand our CI is not good for
> running multiple times with same code because of lack of resources.
>
> Best regards,
> Jongyoul Lee
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>

[GitHub] zeppelin issue #2937: ZEPPELIN-3401. Deadlock while restarting interpreter

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2937
  
\cc @weand 


---

[GitHub] zeppelin pull request #2937: ZEPPELIN-3401. Deadlock while restarting interp...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2937

ZEPPELIN-3401. Deadlock while restarting interpreter

### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3401

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2937.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2937


commit 5ffcc11a4bce8f69d911fb700c90d2aeddbad8e7
Author: Jeff Zhang 
Date:   2018-04-22T03:46:53Z

ZEPPELIN-3401. Deadlock while restarting interpreter




---

Re: [DISCUSS] Adjust test logs for CI

[Felix Cheung]

Is there a way to do this via enable/disable component for logging in log4j?


From: Jongyoul Lee 
Sent: Sunday, April 22, 2018 7:01:54 AM
To: dev
Subject: [DISCUSS] Adjust test logs for CI

Hello contributors,

I wonder how you guys think of reducing test logs to help to debug with CI.
Recently, Zeppelin's Travis log is too big to read anything.

So I suggest these kinds of step:
1. leave test logs as much as you want to test your code passed in CI
2. If passed, please remove all of your test's logs

How do you think of your guys? I know and understand our CI is not good for
running multiple times with same code because of lack of resources.

Best regards,
Jongyoul Lee

--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2903
  
Hi @felixcheung please let me know if any additional changes or adjustments 
are needed.

The two failing tests are unrelated to the code in in this PR

Thanks. 


---

[GitHub] zeppelin issue #2929: ZEPPELIN-3412 Enable query prefix syntax in bigquery i...

[iijima-satoshi]

Github user iijima-satoshi commented on the issue:

https://github.com/apache/zeppelin/pull/2929
  
@felixcheung I addressed your comments. Case sensitive, and furthermore 
exact match are not required. thanks.


---

[DISCUSS] Adjust test logs for CI

[Jongyoul Lee]

Hello contributors,

I wonder how you guys think of reducing test logs to help to debug with CI.
Recently, Zeppelin's Travis log is too big to read anything.

So I suggest these kinds of step:
1. leave test logs as much as you want to test your code passed in CI
2. If passed, please remove all of your test's logs

How do you think of your guys? I know and understand our CI is not good for
running multiple times with same code because of lack of resources.

Best regards,
Jongyoul Lee

-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2935
  
@zjffdu Let me make it


---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2935
  
Do you have jstack so that I can understand what the exact problem is 


---

[GitHub] zeppelin issue #2936: MINOR Remove tracing logs when testing

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2936
  
Review this PR. It's very trivial :-)


---

[GitHub] zeppelin pull request #2936: MINOR Remove tracing logs when testing

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/2936

MINOR Remove tracing logs when testing

### What is this PR for?
Removing redundant code when testing integration tests. It's hard to debug 
because of that kind of less-useful messages of waiting something.


### What type of PR is it?
[Improvement]

### Todos
* [x] - Changed logging option to false

### What is the Jira issue?
N/A

### How should this be tested?
N/A

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
minor-remove-redundent-test-logs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2936.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2936


commit 7d90bda322981a6a33aa7a55b697a2fcccbb1deb
Author: Jongyoul Lee 
Date:   2018-04-22T13:29:06Z

Changed all of trace logs disabled
Removed an unused Util class




---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2935
  
This is not a critial issue when running normally. But in case of 
problemistic situation like restarting forcibly to stop long running job of 
SparkInterpreter, some logic hangs inside synchronized block.


---

[GitHub] zeppelin issue #2935: ZEPPELIN-3411 Long running logic inside synchronized b...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2935
  
Test passed. https://travis-ci.org/jongyoul/zeppelin/builds/367566398


---

[GitHub] zeppelin pull request #2935: ZEPPELIN-3411 Long running logic inside synchro...

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/2935

ZEPPELIN-3411 Long running logic inside synchronized block in 
InterpreterSettingManager

### What is this PR for?
Removing redundant synchronized code to avoid blocking other logics.


### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Change synchronized block to read/write lock

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3411

### How should this be tested?
* Current tests should be passed

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3411

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2935.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2935


commit 24be69298c8a3ca514b478a0ca95e9ac0f151178
Author: Jongyoul Lee 
Date:   2018-04-17T09:38:56Z

Removed all synchronized blocks and replace them to read/write lock




---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

[sanjaydasgupta]

GitHub user sanjaydasgupta reopened a pull request:

https://github.com/apache/zeppelin/pull/2903

[ZEPPELIN-3377] Passing Z variables to JDBC interpreter

### What is this PR for?
This PR enables the interpolation of ZeppelinContext objects into the 
paragraph text of JDBC cells. It also introduces a new interpreter-level 
configuration parameter named _zeppelin.jdbc.interpolation_. This new parameter 
is _false_ by default, and must be set to _true_ to enable object 
interpolation. The default value of _false_ guarantees backward compatibility 
for users who are not aware of the new feature.

The implementation takes the same approach that was followed in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898).

I have also taken the liberty to correct a preexisting error in the 
description of the use of Dynamic Forms in the associated documentation 
(_jdbc.md_).

### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3377

### How should this be tested?
CI Pass. 

The code in this PR merely causes the JDBC interpreter to "opt-in" to the 
implementation already existing in the `Interpreter` base class - described in 
[PR-2898](https://github.com/apache/zeppelin/pull/2898). The unit tests 
necessary are already present in PR-2898

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, documentation has been added to the 
file _jdbc.md_. I have also taken the liberty to correct a preexisting error in 
the description of the use of Dynamic Forms in the associated documentation.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sanjaydasgupta/zeppelin zeppelin-3342-jdbc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2903.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2903


commit 28688256f3b11e696c08ed10875e0596db8c0463
Author: Sanjay Dasgupta 
Date:   2018-03-04T07:36:48Z

ZEPPELIN-1967: Initial updates

commit b461c82569e86436239c9d14a8ae38230bc4f357
Author: Sanjay Dasgupta 
Date:   2018-03-05T02:00:10Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit ced295cb8b27f499b739758b1b17460ab6d67e58
Author: Sanjay Dasgupta 
Date:   2018-03-06T03:47:32Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit a3215fca058398ecbed840a69b4dbf57a2167447
Author: Sanjay Dasgupta 
Date:   2018-03-07T05:15:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit f43fd9987b7a10ae41879c52096fdb99f8a28f34
Author: Sanjay Dasgupta 
Date:   2018-03-11T05:40:21Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3beebce5b5fbb45b295fd5b4bf4b28f9bef8350f
Author: Sanjay Dasgupta 
Date:   2018-03-13T11:33:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 3b30ea2143813dfbc48970b1ac094fea30d7d775
Author: Sanjay Dasgupta 
Date:   2018-03-15T10:43:53Z

Reversing previous incorrect update

commit 1718e79646b8de4682cb1c76eb6d4a24e83b3184
Author: Sanjay Dasgupta 
Date:   2018-03-15T14:17:49Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 526880301877125501ea0b1b06c61fcfdc19fe60
Author: Sanjay Dasgupta 
Date:   2018-03-18T04:41:52Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit b7ddf6ba202c2624a289aff67cfad669510ca80d
Author: Sanjay Dasgupta 
Date:   2018-03-18T09:54:23Z

Implementing configuration (global enable/disable interpolation) following 
https://github.com/apache/zeppelin/pull/2834#issuecomment-373948398

commit a1703b820e42e3956f45edf3c02aec8fc3475739
Author: Sanjay Dasgupta 
Date:   2018-03-18T21:05:42Z

Changes suggested in Felix Cheung's review 
https://github.com/apache/zeppelin/pull/2834#pullrequestreview-104805661

commit 3dd3dd879187e20a80cb202df7869c923da8a690
Author: Sanjay Dasgupta 
Date:   2018-03-20T03:47:11Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 1e2c87dd36dc091ca898baf8e9f178d6d1a5e600
Author: Sanjay Dasgupta 
Date:   2018-03-21T01:18:09Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
ZEPPELIN-1967

commit 

[GitHub] zeppelin issue #2903: [ZEPPELIN-3377] Passing Z variables to JDBC interprete...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2903
  
Closing and reopening to trigger tests.


---

[GitHub] zeppelin pull request #2903: [ZEPPELIN-3377] Passing Z variables to JDBC int...

[sanjaydasgupta]

Github user sanjaydasgupta closed the pull request at:

https://github.com/apache/zeppelin/pull/2903


---