[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2192 thanks for the clarification @AhyoungRyu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2192 @astroshim: why? does that mean I also need to do https://github.com/apache/zeppelin/pull/2099 based on branch-0.7 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2192: [ZEPPELIN-2320] fixing test + modifying map browsing
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2192 @astroshim Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2151 @AhyoungRyu sorry for the late answer, I have updated the doc accordingly to your advice, and changed the wording of the UI command. It is now "Run with successors", but if a native English speaker has a better wording, any help is appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2186 @soralee , @AhyoungRyu , @anthonycorbacho : proposal of workaround here, https://github.com/apache/zeppelin/pull/2194 . Feedbacks welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2194: [ZEPPELIN-2229] Providing workaround for nvd3 v...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2194 [ZEPPELIN-2229] Providing workaround for nvd3 voronoi ### What is this PR for? After bumping nvd3 to 1.8.5, an error was spotted due to a bug in nvd3. This PR provides a workaround until the proper nvd3 fix is released. * create a jitter and deduplicate data * adapt axis tick format to hide the jitter * add y label for non-numeric value * this code can be safely removed after nvd3 [#1934](https://github.com/novus/nvd3/pull/1934) is released ( > 1.8.5) and bumped in zeppelin project ### What type of PR is it? Bug Fix ### Todos * [ ] - When bumping nvd3 to a version > 1.8.5, remove the code marked with TODO ### What is the Jira issue? [ZEPPELIN-2229](https://issues.apache.org/jira/browse/ZEPPELIN-2229) ### How should this be tested? See [#2186](https://github.com/apache/zeppelin/pull/2186). Switch between any chart and scatter chart with a large number of rows. ### Screenshots (if appropriate) See [#2186](https://github.com/apache/zeppelin/pull/2186). ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2229 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2194.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2194 commit 017ab390a6a7a07055f6bd6209104d52a4144c74 Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-27T16:27:39Z [ZEPPELIN-2229] Providing workaround for nvd3 voronoi * create a jitter and deduplicate data * adapt axis tick format to hide the jitter * add y label for non-numeric value * this code can be safely removed after nvd3 #1934 is released ( > 1.8.5) and bumped in zeppelin project --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2192: [ZEPPELIN-2320] fixing test + modifying map bro...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2192 [ZEPPELIN-2320] fixing test + modifying map browsing ### What is this PR for? fixing String comparison and improving map browsing ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-2320](https://issues.apache.org/jira/browse/ZEPPELIN-2320) ### How should this be tested? build with tests. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2192 commit 9ad16bc73add8de8b4dff9eabe5d5bb95dce077e Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-27T08:43:26Z [ZEPPELIN-2320] fixing test + modifying map browsing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2186: [ZEPPELIN-2229] revert ndv3 version from 1.8.5 to 1.7....
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2186 My 2 cts here: Yep the scatter chart bug in 1.8.5 is annoying, and unfortunately nvd3 does not seem to release very frequently ( 2-3 times a year or so). However I am not sure reverting the lib from 1.8.5 to 1.7.1 is the right move, keep in mind that **a lot of bugs** were fixed between those two releases. Reverting to 1.7.1 is very likely to reintroduce (or maintain) a lot of others bugs. I wonder if we could do something directly in Zeppelin's visualization code to workaround the voronoi issue you spotted until 1.8.6 is released. Your thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
GitHub user Remilito reopened a pull request: https://github.com/apache/zeppelin/pull/2151 [ZEPPELIN-465] Be able to run paragraph and the following ones ### What is this PR for? Allow to run a paragraph **and** the ones following. This is useful for instance if you are generating a dataset in a paragraph and then have others subsequent paragraphs relying on this dataset. In a nutshell this PR contains: * UI: added a command in paragraph dropdown menu * REST: added an boolean option to runparagraph (sync & async) * updated rest doc * z-engine: added relevant function to Note * also refacto some duplicated code here and there. ### What type of PR is it? Feature ### Todos * [ ] - Once committers agree on the visual impact, update relevant documentation. ### What is the Jira issue? [ZEPPELIN-465](https://issues.apache.org/jira/browse/ZEPPELIN-465) ### How should this be tested? * UI: click on the "run and next ones" in the dropdown menu and verify subsequent paragraphs are also run, and not precedent ones. * REST: post request to /api/notebook/[job|run]/$noteId/$paragraphId?subsequent=true ### Screenshots (if appropriate)    ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-465 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2151 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2151: [ZEPPELIN-465] Be able to run paragraph and the follow...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2151 @AhyoungRyu : updated (and now building and passing tests :sweat_smile: ). @jongyoul : I am not sure to fully understand what you mean. If you are talking "UI" IMO the need to run or not a sequence of paragraphs depends mostly on the paragraphs' contents (i.e. generation of a dataset used by following paragraphs), so I find it more convenient to trigger this directly in the paragraph view rather than putting it in the job view. WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2111: [ZEPPELIN-2230] clear bower_contents if bower.json cha...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2111 @jongyoul : https://github.com/apache/zeppelin/pull/2167 should help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo : updated! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2167: [ZEPPELIN-2230] .travis.yml protecting against ...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2167 [ZEPPELIN-2230] .travis.yml protecting against ambiguous commit range ### What is this PR for? Following the revert of [](https://github.com/apache/zeppelin/pull/2111 ) I added some protection in case TRAVIS_COMMIT_RANGE is "ambiguous" i.e. some paths or commits are not found within the range. (can happen on some push --force). ### What type of PR is it? Bug Fix ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-2230](https://issues.apache.org/jira/browse/ZEPPELIN-2230) ### How should this be tested? Re-do a twisted git push --force. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2230b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2167.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2167 commit cb9647f10dc2879ec6a2e0ae338067bd1e919958 Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-07T17:32:12Z [ZEPPELIN-2230] clear bower_contents if bower.json changed or bower clear provided in commit message commit 97968f915b27dfe51163c1181aa8a13c87f560d1 Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-20T10:32:59Z Protecting against ambiguous TRAVIS_COMMIT_RANGE. E.g.: when push force, some commits might be missing from the origin branch, therefore causing an unsusable COMMIT_RANGE. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo thanks for the feedback, I think we should keep only B. I'll update the PR in a couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2151: [ZEPPELIN-465] Be able to run paragraph and the...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2151 [ZEPPELIN-465] Be able to run paragraph and the following ones ### What is this PR for? Allow to run a paragraph **and** the ones following. This is useful for instance if you are generating a dataset in a paragraph and then have others subsequent paragraphs relying on this dataset. In a nutshell this PR contains: * UI: added a button to paragraph * REST: added an boolean option to runparagraph (sync & async) * updated rest doc * z-engine: added relevant function to Note * also refacto some duplicated code here and there. ### What type of PR is it? Feature ### Todos * [ ] - Once committers agree on the visual impact (currently a new button on paragraph commands but can be discussed), update relevant documentation. ### What is the Jira issue? [ZEPPELIN-465](https://issues.apache.org/jira/browse/ZEPPELIN-465) ### How should this be tested? * UI: click on the button and verify subsequent paragraphs are also run, and precedent ones. * REST: post request to /api/notebook/[job|run]/$noteId/$paragraphId?subsequent=true ### Screenshots (if appropriate)    ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-465 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2151.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2151 commit 9ba0d38b93a5bf27eacdb579af7256ac0d18 Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-16T14:10:40Z [ZEPPELIN-465] Be able to run paragraph and the following ones * UI: added a button to paragraph * REST: added an boolean option to runparagraph (sync & async) * updated rest doc * z-engine: added relevant function to Note * also refacto some duplicated code here and there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue:
https://github.com/apache/zeppelin/pull/2099
@Leemoonsoo : the most common usages would be to set visual paramaters,
i.e. graph options, paragraph width and paragraph title show, so the idea was
to provide a more direct way to configure those rather than having to provide
the whole config:{results:[{} to do so. Anyway, this is open to discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2111: [ZEPPELIN-2230] clear bower_contents if bower.j...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2111 [ZEPPELIN-2230] clear bower_contents if bower.json changed ### What is this PR for? Before travis build: * check if any bower.json file is part of the commit range * check if any commit message of the commit range contains "bower clear" or "clear bower" * If one of the above, clear bower_components, npm cache clear This should prevent breaking the build when upgrading a js lib. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? [ZEPPELIN-2230](https://issues.apache.org/jira/browse/ZEPPELIN-2230) ### How should this be tested? 1. Using this version of .travis.yml, build the project once. (e.g. with nvd3 1.7.1) 2. then modify a version of js lib (e.g. nvd3), rebuild. 3. Verify the build goes through, check the build log for the message "Clearing bower_components cache". 4. Rebuild, without changing a version, but putting "bower clean" in a commit message. 5. Same as 3. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Maybe for the "bower clear" trigger. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2230b Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2111.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2111 commit cb9647f10dc2879ec6a2e0ae338067bd1e919958 Author: Remilito <remy.ga...@gmail.com> Date: 2017-03-07T17:32:12Z [ZEPPELIN-2230] clear bower_contents if bower.json changed or bower clear provided in commit message --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2042 FYI: https://issues.apache.org/jira/browse/ZEPPELIN-2230, comments appreciated. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2042 @AhyoungRyu : I have just checked, those "axis-boxes" seemed to have disappeared from nvd3 after 1.7.1. However the new tooltip provides both x and y values. WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2043: [ZEPPELIN-2114] adding reload endpoint
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2043 @AhyoungRyu: let me know if need me to enrich the new notebook-repositories doc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2043: [ZEPPELIN-2114] adding reload endpoint
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2043 [ZEPPELIN-2114] adding reload endpoint ### What is this PR for? Adding endpoint in NotebookRepoRestApi to trigger reload and broadcast of the note list. Sending a GET request to /api/notebook-repositories/reload will trigger a reload of the note list, just like the reload button does on the homepage. Q: If you think this endpoint belongs to another API (NotebookRestApi?), let me know. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? <https://issues.apache.org/jira/browse/ZEPPELIN-2114> ### How should this be tested? 0. add (or remove) a note in the notebook repository 1. curl -X GET http://HOST:PORT/api/notebook-repository/reload 2. verify that you the note list in Zeppelin's home page now contains (or does not contain anymore) the note. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NotebookRepoRestApi does not have documentation yet. Could add it in another PR if needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2114 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2043.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2043 commit cf66c2b7f180a952c2b7fef8ac901bf1da484a57 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-20T14:43:25Z [ZEPPELIN-2114] adding reload endpoint * ability to reload note list from repo by API --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2023: [ZEPPELIN-2114]: adding reload endpoint + fixin...
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2042 [ZEPPELIN-1588]: bumping nvd3 to 1.8.5 ### What is this PR for? * bump nvd3 to 1.8.5 (and remove depecrated functions) * display percentage in pie chart [solve ZEPPELIN-1891] NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion. ### What type of PR is it? Improvement ### Todos * [ ] - ### What is the Jira issue? * <https://issues.apache.org/jira/browse/ZEPPELIN-1588> * <https://issues.apache.org/jira/browse/ZEPPELIN-1891> ### How should this be tested? Visual testing of the builtin visualization. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1588 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2042.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2042 commit f0b3961547706f18b4b30fa36b93aeda7f24cc58 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-20T13:26:45Z [ZEPPELIN-1588]: bumping nvd3 to 1.8.5 * remove deprecated calls * solve pie display pct * better tooltip for scatterchart --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
GitHub user Remilito reopened a pull request: https://github.com/apache/zeppelin/pull/2040 [ZEPPELIN-1588]: bumping nvd3 ### What is this PR for? * bump nvd3 to 1.8.5 (and remove depecrated functions) * display percentage in pie chart [solve [ZEPPELIN-1891]] NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion. ### What type of PR is it? Improvement ### Todos * [ ] - ### What is the Jira issue? * <https://issues.apache.org/jira/browse/ZEPPELIN-1588> * <https://issues.apache.org/jira/browse/ZEPPELIN-1891> ### How should this be tested? Visual testing of the builtin visualization. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2040 commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-20T10:22:22Z [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3 nvd3 bumped to 1.8.5 benefits from default piechart display which includes pct replacing deprecated nvd3 calls scatterchart tooltip is adapted but commented as nvd3 default one seems more elegant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2040 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588]: bumping nvd3
GitHub user Remilito reopened a pull request: https://github.com/apache/zeppelin/pull/2040 [ZEPPELIN-1588]: bumping nvd3 ### What is this PR for? * bump nvd3 to 1.8.5 (and remove depecrated functions) * display percentage in pie chart [solve [ZEPPELIN-1891]] NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion. ### What type of PR is it? Improvement ### Todos * [ ] - ### What is the Jira issue? * <https://issues.apache.org/jira/browse/ZEPPELIN-1588> * <https://issues.apache.org/jira/browse/ZEPPELIN-1891> ### How should this be tested? Visual testing of the builtin visualization. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2040 commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-20T10:22:22Z [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3 nvd3 bumped to 1.8.5 benefits from default piechart display which includes pct replacing deprecated nvd3 calls scatterchart tooltip is adapted but commented as nvd3 default one seems more elegant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2040: [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2040 [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3 ### What is this PR for? * bump nvd3 to 1.8.5 (and remove depecrated functions) * display percentage in pie chart NB: visualization-scatterchart.js's tooltip content generator has been updated to stop using depecrated tooltip property and use tooltip.contentGenerator instead. However I have commented the code as I think nvd3 scatterchart's default tooltip is far more elegant, open to discussion. ### What type of PR is it? Improvement ### Todos * [ ] - ### What is the Jira issue? * <https://issues.apache.org/jira/browse/ZEPPELIN-1588> * <https://issues.apache.org/jira/browse/ZEPPELIN-1891> ### How should this be tested? Visual testing of the builtin visualization. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-1891 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2040.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2040 commit 1f9aecc1adc0daa395b84f2e5f4ee1fa10860ba3 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-20T10:22:22Z [ZEPPELIN-1588][ZEPPELIN-1891]: bumping nvd3 nvd3 bumped to 1.8.5 benefits from default piechart display which includes pct replacing deprecated nvd3 calls scatterchart tooltip is adapted but commented as nvd3 default one seems more elegant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2023: [ZEPPELIN-2114]: adding reload endpoint + fixing test
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2023 I don't think the failing build has anything to do with this PR. Please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2023: [ZEPPELIN-2114]: adding reload endpoint + fixin...
GitHub user Remilito reopened a pull request: https://github.com/apache/zeppelin/pull/2023 [ZEPPELIN-2114]: adding reload endpoint + fixing test ### What is this PR for? Adding endpoint in NotebookRepoRestApi to trigger reload and broadcast of the note list. Sending a GET request to /api/notebook-repositories/reload will trigger a reload of the note list, just like the reload button does on the homepage. Q: If you think this endpoint belongs to another API (NotebookRestApi?), let me know. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? <https://issues.apache.org/jira/browse/ZEPPELIN-2114> ### How should this be tested? 0. add (or remove) a note in the notebook repository 1. curl -x GET http://HOST:PORT/api/notebook-repository/reload 2. verify that you the note list in Zeppelin's home page now contains (or does not contain anymore) the note. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NotebookRepoRestApi does not have documentation yet. Could add it in another PR if needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2114 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2023.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2023 commit e380fe4c75827e7f17c0d8e9a9909bf4de25d6f4 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-15T16:49:00Z [ZEPPELIN-2114]: adding reload endpoint + fixing test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2023: [ZEPPELIN-2114]: adding reload endpoint + fixin...
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2023 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2023: [ZEPPELIN-2114]: adding reload endpoint + fixin...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2023 [ZEPPELIN-2114]: adding reload endpoint + fixing test ### What is this PR for? Adding endpoint in NotebookRepoRestApi to trigger reload and broadcast of the note list. Sending a GET request to /api/notebook-repositories/reload will trigger a reload of the note list, just like the reload button does on the homepage. Q: If you think this endpoint belongs to another API (NotebookRestApi?), let me know. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? <https://issues.apache.org/jira/browse/ZEPPELIN-2114> ### How should this be tested? 0. add (or remove) a note in the notebook repository 1. curl -x GET http://HOST:PORT/api/notebook-repository/reload 2. verify that you the note list in Zeppelin's home page now contains (or does not contain anymore) the note. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NotebookRepoRestApi does not have documentation yet. Could add it in another PR if needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin ZEPPELIN-2114 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2023.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2023 commit e380fe4c75827e7f17c0d8e9a9909bf4de25d6f4 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-15T16:49:00Z [ZEPPELIN-2114]: adding reload endpoint + fixing test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2018: [ZEPPELIN-2114]: Adding an endpoint in Notebook...
Github user Remilito closed the pull request at: https://github.com/apache/zeppelin/pull/2018 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2018: [ZEPPELIN-2114]: Adding an endpoint in Notebook...
GitHub user Remilito opened a pull request: https://github.com/apache/zeppelin/pull/2018 [ZEPPELIN-2114]: Adding an endpoint in NotebookRepoRestApi to reload note list ### What is this PR for? Adding endpoint in NotebookRepoRestApi to trigger reload and broadcast of the note list. Sending a GET request to /api/notebook-repositories/reload will trigger a reload of the note list, just like the reload button does on the homepage. Q: If you think this endpoint belongs to another API (NotebookRestApi?), let me know. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? <https://issues.apache.org/jira/browse/ZEPPELIN-2114> ### How should this be tested? 0. add (or remove) a note in the notebook repository 1. curl -x GET http://HOST:PORT/api/notebook-repository/reload 2. verify that you the note list in Zeppelin's home page now contains (or does not contain anymore) the note. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? NO * Is there breaking changes for older versions? NO * Does this needs documentation? NotebookRepoRestApi does not have documentation yet. Could add it in another PR if needed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Remilito/zeppelin develop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2018.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2018 commit 064eee83a8e11d37178b9454791069cc979f2419 Author: Remilito <remy.ga...@gmail.com> Date: 2017-02-14T13:46:49Z [ZEPPELIN-2114]: Adding a call in NotebookRepoRestApi to reload note list --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
