from:"khalidhuseynov"

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2499


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2499

[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin 
note converter

### What is this PR for?
Fixes the issue of having doubled new lines between lines when converting 
Jupyter notes into Zeppelin note.

### What type of PR is it?
Bug Fix

### Todos
* [x] - remove unnecessary `\n` line separator

### What is the Jira issue?
[ZEPPELIN-2801](https://issues.apache.org/jira/browse/ZEPPELIN-2801)

### How should this be tested?
1. prepare sample jupyter note
2. run `java -cp 
zeppelin-jupyter/target/zeppelin-jupyter-0.8.0-SNAPSHOT.jar 
org.apache.zeppelin.jupyter.JupyterUtil -i path/To/*.ipynb`, should produce 
`note.json`
3. import `note.json` into Zeppelin, shouldn't have doubled spaces

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2801

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2499


commit 9af49593056144c4de5d324c05ee1c6a1e5e
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-20T17:07:43Z

change lineseparator to empty string




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2499: [ZEPPELIN-2801] fix adding unnecessary new lines in Ju...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2499
  
/cc @jongyoul to help review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2499: [ZEPPELIN-2801] fix adding unnecessary new line...

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2499

[ZEPPELIN-2801] fix adding unnecessary new lines in Jupyter to Zeppelin 
note converter

### What is this PR for?
Fixes the issue of having doubled new lines between lines when converting 
Jupyter notes into Zeppelin note.

### What type of PR is it?
Bug Fix

### Todos
* [x] - remove unnecessary `\n` line separator

### What is the Jira issue?
[ZEPPELIN-2801](https://issues.apache.org/jira/browse/ZEPPELIN-2801)

### How should this be tested?
1. prepare sample jupyter note
2. run `java -cp 
zeppelin-jupyter/target/zeppelin-jupyter-0.8.0-SNAPSHOT.jar 
org.apache.zeppelin.jupyter.JupyterUtil -i path/To/*.ipynb`, should produce 
`note.json`
3. import `note.json` into Zeppelin, shouldn't have doubled spaces

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2801

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2499.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2499


commit 9af49593056144c4de5d324c05ee1c6a1e5e
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-20T17:07:43Z

change lineseparator to empty string




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

2017-07-13 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@felixcheung actually that means to persist in default way, since Zeppelin 
persists on most of user activities so it seems to be "continuously". another 
way would be to call it "default" i guess


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-13 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@1ambda actually it would rename on first save, it can be run, edit 
paragraph, or rename. Regarding renaming for all notes in the beginning it was 
discussed actually above and I think we can give an option for user to do that 
(e.g. through config). I believe it could be handled separately though, 
possibly together with documentation. WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

2017-07-12 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@1ambda 
1. separate tab with `Global Settings` contains the settings which are 
applied to all storages, so that we don't duplicate in each storage setting.
2. note persisted when user executes, also it's persisted when user makes 
commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-12 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@zjffdu @1ambda addressed the feedback to convert in save, w/o additional 
interface. probably will need to separate base class with each storage after 
this pr to handle more logic in there. this one is ready to verify


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-12 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
thanks for the improvement, this scenario needs to be fixed indeed. after 
trying the pr, i noticed couple of things
 * when following scenario and going into note as user2, my browser got 
stuck with the continuous requests to the helium endpoint, anyone experienced 
it?
 * the note opens in report mode, although it say in the top-right corner 
`default` mode. that seems a bit inconsistent
  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-11 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@zjffdu yeah, the renaming would be done probably on saving which would 
apply if user enters note, and does some action so that save->conversion 
(rename) is initiated. This would work further everytime to rename from 
`title1.zpln` -> `title2.zpln`. But I was concerned more about scenario when 
user has 100 notes, and if he wants to convert them into new format (rename), 
he would need to enter every note and do something to initiate conversion. That 
would be little troublesome for user, so i thought maybe to initiate it during 
initial load for all notes as well. For now i'll change to save, and we can 
discuss further about loading part.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-11 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@Leemoonsoo @1ambda @zjffdu I wanted to have opinion on the note conversion 
strategy. lazy strategy - converting when note is renamed, vs aggressive - 
converting all notes when starting zeppelin. currently it's implemented here 
with lazy strategy, however the more i think, the more aggressive way seems 
more relevant. One of the problems with lazy strategy is that, if user has many 
notes, it would be burdensome to convert notes to new format by manually 
renaming each one. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-07-09 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2374

[ZEPPELIN-2593] Add storage settings to persist on run and commit

### What is this PR for?
adding settings to storage layer to let user choose to persist continuously 
or only on commits


### What type of PR is it?
Improvement | Feature

### Todos
* [x] - add notebook repo setting
* [x] - add persist on run & commit (checkpoint)
* [x] - add persist on commit (checkpoint) only
* [x] - add tests

### What is the Jira issue?
[ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)

### How should this be tested?
1. go to notebook repo menu and click on edit `Global settings` or do 
through env var `ZEPPELIN_NOTEBOOK_PERSISTENCE`
2. change value of `Note persistence` item to `Persist on note run and 
commits` or change value of `ZEPPELIN_NOTEBOOK_PERSISTENCE` into "run"
3. go change any note, although it will be changed in memory, it won't be 
persisted
4. to check above can reload notes in note list view -> will see original 
note
5. can save note either by `Run` or clicking `Commit` button in version 
control menu of note

### Screenshots (if appropriate)
https://user-images.githubusercontent.com/1642088/27996389-fd0a4a26-651b-11e7-91ed-ea22d135f875.png;>



## Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2374


commit 856fceed1b39e49461e68b1d97f1f736b1101f3a
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

initial flow

commit ea82c9919f84252e7f4c0fce8d4a6d1cfe9a2bff
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T07:14:07Z

add temp test

commit 1fd869a27e31ecadf271b483b951623801b312fd
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T10:39:02Z

rework settings into global

commit dec53aeb44c7f1a97133511730b71ba24a8a94fe
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:10Z

change checkpoint signature with recent note

commit 6b2ce75009bdb19b5df9e8c4ba46c1fcf3637076
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:55Z

improve test

commit 298edf07b18501325a00c980ed9b5e97547270d8
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T06:42:01Z

add large test for global setting change

commit 1be654a3d4c3ccdc32ed7020a5a4aa2bc8ea4ce8
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T08:52:02Z

add save & commit from note action bar

commit c283c00a207786d595d217ec3893c2ccab8527b5
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T12:31:32Z

fix test, set property back

commit 5f24004096b0fa043173238a0ed9f976adf75cfb
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T13:34:01Z

move setting from global to per repo and apply to remote s3 and zh

commit a6f572be272d458217858937a3ef4ecdfcfd96cc
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-26T18:22:20Z

add conditional save in s3

commit d04452a214709e3e5dbe40b19030369adc1e2a99
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T08:11:28Z

fix spelling

commit fca6d4a570c8f1f1a146be6afde3a25277c9395d
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T09:29:04Z

make option as non-actionable, don't broadcast

commit f912f83db174359df1cbd450e1f0b597321dd949
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T10:47:10Z

send note inside checkpoint payload

commit 5d1b66ca9afede6801046ee5c390a2372020d93b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T11:37:49Z

fix test

commit 6ab2e1e434a3326f22c938a7e7ebdddb6d3234f4
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-06T14:06:21Z

separate persist for run and update actions in notebook

commit a44caa85ff27887ea0cc200c3f4db36f8a75a013
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-06T17:34:49Z

change env var name with 3 default values

commit 3d1ea5393bfce9ea8ef31a77932974aef13a9809
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-07T01:48:44Z

move settings to base class

commit 0c3d97099f4e4f0a5d207815cdb341531c351846
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-07T05:51:13Z

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-07-09 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-09 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@1ambda @zjffdu addressed the feedback and added persist on `run` as well. 
Also moved the logic out of storage classes. Please help further review and 
test this one to move on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-05 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@1ambda on 1. yes, we would need to implement renaming for other repos and 
i was planning to do it for S3, Azure right after this PR. As an alternative to 
adding this method to interface, could be having another interface, say 
`Renamable` and any storage that wants to support extension, naming, folder 
structure would implement it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-05 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@1ambda good point, we can make both possible. i'll modify it to support 
both config then through dropdown


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-04 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
rebased from master, /cc @1ambda @Leemoonsoo please help review and test as 
well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2448: [ZEPPELIN-2702] save notes in reader-friendly f...

2017-07-03 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2448

[ZEPPELIN-2702] save notes in reader-friendly format with zpln extension 
for VFS and Git repo

### What is this PR for?
first task in converting note files into human readable and Zeppelin own 
format

### What type of PR is it?
Improvement | Feature

### Todos
* [x] - initial flow
* [x] - add rename tests

### What is the Jira issue?
[ZEPPELIN-2702](https://issues.apache.org/jira/browse/ZEPPELIN-2702)

### How should this be tested?
1. go create new notes or rename title of old ones
2. see the notebook directory, under [NOTE_ID]/title.zpln

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/zpln-extension

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2448


commit 60b3d8bc31872d05818d28d476c83d3a3b1d775b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-27T12:36:27Z

read note from zpln and json files

commit 4d02c8f24fae27bfa01c330d34e0371be9d57855
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T15:05:53Z

add file conversion routine

commit b469cc4003524a446488670153017c5b4f29985d
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T18:14:14Z

fix create note

commit e14889c7f7446b2e4b4bf1c5f9a6fb3447bbae02
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T18:14:48Z

add convert util test

commit d7ce2b38ae4b6ec27d332266822ee1e4e40bab6b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-02T04:20:46Z

remove version info

commit 9785855b76c702b2227afbe9c729bec1de5c6b07
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-02T04:21:28Z

change filename max length to 100

commit 74ad5fa49b1d04dc06ba1c355c9714a5bc6db08f
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-03T01:54:20Z

add rename method to notebook repo

commit c4d471e6f24f01d803c69f80902783654f98a645
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-03T17:42:42Z

add rename test

commit fca6c70309cf5d425316e7aca1a61976955fabd8
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-03T20:32:03Z

fix createNote case

commit 98918c20d9da2a6dd6836be00b1d1a283ae1fd81
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-07-03T20:32:58Z

add create note-> rename test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2448: [ZEPPELIN-2702] save notes in reader-friendly f...

2017-07-03 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2448


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-03 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
@zjffdu addressed the feedback on adding new `rename` method and having 
only one fileInfo, please help review 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-07-02 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
this is ready for more review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-30 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2374

[ZEPPELIN-2593] Add storage settings to persist on commit

### What is this PR for?
adding settings to storage layer to let user choose to persist continuously 
or only on commits


### What type of PR is it?
Improvement | Feature

### Todos
* [x] - add notebook repo setting
* [x] - add save & commit 
* [x] - add tests

### What is the Jira issue?
[ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)

### How should this be tested?
1. go to notebook repo menu and click on edit `Global settings`
2. change value of `Note persistence` item to `Persist on note commits`
3. go change any note, although it will be changed in memory, it won't be 
persisted
4. to check above can reload notes in note list view -> will see original 
note
5. can save note by `Save & Commit` in version control menu of note

### Screenshots (if appropriate)
notebook repo menu
https://user-images.githubusercontent.com/1642088/27026300-41860ea4-4f98-11e7-8e5a-a36cb64b98fc.png;>


version control menu
https://user-images.githubusercontent.com/1642088/27026217-fb43c152-4f97-11e7-86f1-627dea1fe3ce.png;>


## Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2374


commit 2fb70ae2c365f5a02e8da182324db6847e4f5dfa
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

initial flow

commit 0a007f55d73e24ad9610861399b44c0a83dede09
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T07:14:07Z

add temp test

commit 43d6cf6d18a4d4c5cdd58096e476a27f6a0d9e33
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T10:39:02Z

rework settings into global

commit 7b7bedcdf8fd21bed4f617550c0197b49d7e3843
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:10Z

change checkpoint signature with recent note

commit 4d93f482808719b8768c2ae5c1579d8921530ae0
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:55Z

improve test

commit 5d7573dd6baa0e35bbb17eca569e8da7910ab713
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T06:42:01Z

add large test for global setting change

commit e8aeb9660e869c5a0a791344086ea861ceb3c0d6
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T08:52:02Z

add save & commit from note action bar

commit 0c035582964df6d85091635a39f208452e663edd
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T12:31:32Z

fix test, set property back

commit 6ab4b597834b3e376f59e034f7ce1c967de3596c
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T13:34:01Z

move setting from global to per repo and apply to remote s3 and zh

commit 5681d49055da94a527e39efc5faa910a53aa2b19
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-26T18:22:20Z

add conditional save in s3

commit 64c15137978df3136699d8219b3ad40adf497d95
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T08:11:28Z

fix spelling

commit 7ec21738d60104228d939fe08c7893d133790a20
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T09:29:04Z

make option as non-actionable, don't broadcast

commit 50c88524fd8471dd34d2cb30f4d49df9e3b07a1a
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T10:47:10Z

send note inside checkpoint payload

commit df78d4d154126225c4f5ce05ded9acbe5135073f
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-30T11:37:49Z

fix test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-30 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-06-30 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374

@zjffdu the persistence policy is saving on run and almost on any note
action. originally i introduced this feature globally on base class, however
after some discussion above, introducing it for certain classes seems to be
more reasonable since remote saves are costlier than local ones. regarding the
questions:
* when it's set to false there's only `Commit` button as before (make
revision) instead of `Save & Commit` (save and make revision) as below
![save
commit1](https://user-images.githubusercontent.com/1642088/27741887-8187b3ba-5df1-11e7-9598-1f7e0a01a1c8.gif)
* yeah i agree that `commit` itself implies save. currently it's used in
Zeppelin to denote creation of revision/checkpoint. So the idea was that in
normal mode everything is saved automatically and you can `commit` current
version whenever you want and with this feature enabled (only in S3 and
ZHubRepo for now) you can `Save & Commit`.
* persist on run is also another idea that could work, and would be nice to
know opinion of more people on that. generally in that case save would be
dependent on run, and `commit` would stay as before. @1ambda @Leemoonsoo what
do you think about that?
* i'll add documentation for it, regarding losing data since i changed
local storage not to have this feature, it'll alway be saved locally and only
for remote storages it could be mentioned in docs.

let me know what you think on these points, thanks

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2448: [ZEPPELIN-2702] save notes in reader-friendly f...

2017-06-28 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2448

[ZEPPELIN-2702] save notes in reader-friendly format with zpln extension 
for VFS and Git repo

### What is this PR for?
first task in converting note files into human readable and Zeppelin own 
format

### What type of PR is it?
Improvement | Feature

### Todos
* [x] - initial flow
* [ ] - add rename tests

### What is the Jira issue?
[ZEPPELIN-2702](https://issues.apache.org/jira/browse/ZEPPELIN-2702)

### How should this be tested?
go create new notes or rename title of old ones

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? maybe


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/zpln-extension

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2448.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2448


commit 60b3d8bc31872d05818d28d476c83d3a3b1d775b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-27T12:36:27Z

read note from zpln and json files

commit 4d02c8f24fae27bfa01c330d34e0371be9d57855
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T15:05:53Z

add file conversion routine

commit b469cc4003524a446488670153017c5b4f29985d
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T18:14:14Z

fix create note

commit e14889c7f7446b2e4b4bf1c5f9a6fb3447bbae02
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-28T18:14:48Z

add convert util test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-26 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2374

[ZEPPELIN-2593] Add storage settings to persist on commit

### What is this PR for?
adding settings to storage layer to let user choose to persist continuously 
or only on commits


### What type of PR is it?
Improvement | Feature

### Todos
* [x] - add notebook repo setting
* [x] - add save & commit 
* [x] - add tests

### What is the Jira issue?
[ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)

### How should this be tested?
1. go to notebook repo menu and click on edit `Global settings`
2. change value of `Note persistence` item to `Persist on note commits`
3. go change any note, although it will be changed in memory, it won't be 
persisted
4. to check above can reload notes in note list view -> will see original 
note
5. can save note by `Save & Commit` in version control menu of note

### Screenshots (if appropriate)
notebook repo menu
https://user-images.githubusercontent.com/1642088/27026300-41860ea4-4f98-11e7-8e5a-a36cb64b98fc.png;>


version control menu
https://user-images.githubusercontent.com/1642088/27026217-fb43c152-4f97-11e7-86f1-627dea1fe3ce.png;>


## Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2374


commit 2fb70ae2c365f5a02e8da182324db6847e4f5dfa
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

initial flow

commit 0a007f55d73e24ad9610861399b44c0a83dede09
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T07:14:07Z

add temp test

commit 43d6cf6d18a4d4c5cdd58096e476a27f6a0d9e33
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-09T10:39:02Z

rework settings into global

commit 7b7bedcdf8fd21bed4f617550c0197b49d7e3843
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:10Z

change checkpoint signature with recent note

commit 4d93f482808719b8768c2ae5c1579d8921530ae0
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T05:16:55Z

improve test

commit 5d7573dd6baa0e35bbb17eca569e8da7910ab713
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T06:42:01Z

add large test for global setting change

commit e8aeb9660e869c5a0a791344086ea861ceb3c0d6
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T08:52:02Z

add save & commit from note action bar

commit 0c035582964df6d85091635a39f208452e663edd
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T12:31:32Z

fix test, set property back

commit 6ab4b597834b3e376f59e034f7ce1c967de3596c
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-12T13:34:01Z

move setting from global to per repo and apply to remote s3 and zh

commit 5681d49055da94a527e39efc5faa910a53aa2b19
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-26T18:22:20Z

add conditional save in s3




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-26 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro

2017-06-25 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2239
  
Merging into master if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page

2017-06-23 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2371
  
@1ambda thanks, will merge into master then


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page

2017-06-21 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2371
  
@1ambda could you plz resolved conflicts here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page

2017-06-20 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2371
  
merging if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

2017-06-20 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2391
  
merging if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-06-14 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
yes that's true, i'll look into saving when stopping zeppelin


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-06-14 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
@1ambda thanks for testing. yes that's the purpose of `save & commit`, the 
changes are applied in memory only unless it's explicitly saved and commit 
(persisted into file)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2391: [ZEPPELIN-2501] Better Job Navigation Experience

2017-06-13 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2391
  
@1ambda thanks for contribution, tested and looks much better! When 
searching for note and clicking on it (e.g. redirect to /#/notebook/2CBFCSS6X) 
i can see below stacktrace in console

```
TypeError: Cannot read property 'create' of undefined
at Object.link 
(http://localhost:8080/app.6e54de3d53176984dde0.js:11:1236)
at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:5609
at qa 
(http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:41840)
at n (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:34290)
at g (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:30249)
at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:29780
at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:32385
at d (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:30743)
at m (http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:32827)
at http://localhost:8080/scripts/vendor.51ccc0a5e9a88265.js:34:159637 

```

not sure if it's related to this PR or not,  maybe we could check that. 
except that look good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on com...

2017-06-12 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
this is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

2017-06-06 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
will be merging into master if no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-05 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2374

[ZEPPELIN-2593] Add storage settings to persist on commit

### What is this PR for?
adding settings to storage layer to let user choose to persist continuously 
or only on commits


### What type of PR is it?
Improvement | Feature

### Todos
* [x] - add initial flow
* [x] - address for each storage class

### What is the Jira issue?
[ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)

### How should this be tested?
TBD

### Screenshots (if appropriate)
TBD

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2374


commit 93ba59cf9d7122661f066ba0a0dd0b253dc584d8
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

initial impl through env

commit 6e7401beda06d3be86edfe7680bee9c77e0ed71c
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T16:45:52Z

add setting from UI initial

commit 96421be5a64ea56529eaa499c18f1cc3cd92e378
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-05T06:47:29Z

refactor settings into separate package

commit 7fb1adf423896c04e0b600f1fc52d9cbf4bef7f5
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-05T08:54:54Z

check if permitted for all repos

commit d163e318c04e8e7736883d92231e16b3b98e3e26
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-06-05T12:42:41Z

add note to checkpoint signature




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-06-05 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2374


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-06-01 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2354
  
@sohaibiftikhar i guess we can rebase it from master now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-06-01 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
i've just tried to login using the config info from online demo for 
oidc-client in https://demo.c2id.com/oidc-client using modified config below
```
oidcConfig = org.pac4j.oidc.config.OidcConfiguration
oidcConfig.discoveryURI = https://demo.c2id.com/oidc-client/cb
oidcConfig.clientId = 000123
oidcConfig.secret = 7wKJNYFaKKg4FxUdi8_R75GGYsiWezvAbcdN1uSumE4
oidcConfig.clientAuthenticationMethodAsString = client_secret_basic
oidcClient = org.pac4j.oidc.client.OidcClient
oidcClient.configuration = $oidcConfig
clients = org.pac4j.core.client.Clients
clients.callbackUrl = http://localhost:8080/api/callback
clients.clients = $oidcClient
requireRoleAdmin = 
org.pac4j.core.authorization.authorizer.RequireAnyRoleAuthorizer
#requireRoleAdmin.elements = 
config = org.pac4j.core.config.Config
config.clients = $clients
#config.authorizers = admin:$requireRoleAdmin
pac4jRealm = io.buji.pac4j.realm.Pac4jRealm
pac4jSubjectFactory = io.buji.pac4j.subject.Pac4jSubjectFactory
securityManager.subjectFactory = $pac4jSubjectFactory
oidcSecurityFilter = io.buji.pac4j.filter.SecurityFilter
oidcSecurityFilter.config = $config
oidcSecurityFilter.clients = oidcClient
callbackFilter = io.buji.pac4j.filter.CallbackFilter
callbackFilter.defaultUrl = http://localhost:8080
callbackFilter.config = $config
securityManager.realms = $pac4jRealm

...

/api/callback = callbackFilter
#/** = anon
/** = authc
```
but getting exception
```
ERROR [2017-06-01 14:49:39,711] ({qtp764577347-20} 
LoginRestApi.java[postLogin]:111) - Exception in login: 
org.apache.shiro.authc.pam.UnsupportedTokenException: Realm 
[io.buji.pac4j.realm.Pac4jRealm@734cf9ff] does not support authentication token 
[org.apache.shiro.authc.UsernamePasswordToken - alice, rememberMe=false].  
Please ensure that the appropriate Realm implementation is configured correctly 
or that the realm accepts AuthenticationTokens of this type.
at 
org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:178)
at 
org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267)
at 
org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198)
at 
org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106)
at 
org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270)
at 
org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256)
at org.apache.zeppelin.rest.LoginRestApi.postLogin(LoginRestApi.java:80)
```
please let me know if you can see any apparent misconfiguration 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-29 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2354
  
Hi @FRosner, I think best way would be to help review and test #932 first. 
i was going to do it as well, but didn't get much time recently. thanks for 
help, and i'll check it this week too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2374: [ZEPPELIN-2593] Add storage settings to persist...

2017-05-29 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2374

[ZEPPELIN-2593] Add storage settings to persist on commit

### What is this PR for?
adding settings to storage layer to let user choose to persist continuously 
or only on commits


### What type of PR is it?
Improvement | Feature

### Todos
* [x] - add initial flow
* [ ] - address for each storage class

### What is the Jira issue?
[ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593)

### How should this be tested?
TBD

### Screenshots (if appropriate)
TBD

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2374


commit a8cccf6e6cf5b92d8d7e142bd4909b5a15e087a5
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T07:48:06Z

initial impl through env

commit fa6a60f40929b3682d3e790545e07220c3a1acbf
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-29T16:45:52Z

add setting from UI initial




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-20 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2354
  
thanks for clarification, then i may look into #932 as well, and after 
finalising that we can rebase this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...

2017-05-20 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2354
  
@sohaibiftikhar thanks for adding option for authentication with role 
check, I was wondering if these changes are related to the issue in #932, from 
first look seems a bit unrelated and i would assume it should work from master 
as well, WDYT?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2321: [ZEPPELIN-2498] add more info and config for Ld...

2017-05-07 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2321


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2321: [ZEPPELIN-2498] add more info and config for Ld...

2017-05-07 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2321

[ZEPPELIN-2498] add more info and config for Ldap authentication 

### What is this PR for?
This is to add some necessary configs for ldap authentication.


### What type of PR is it?
Improvement |Documentation

### Todos
* [x] - add system user and security manager info
* [ ] - address feedback

### What is the Jira issue?
[ZEPPELIN-2498](https://issues.apache.org/jira/browse/ZEPPELIN-2498)

### How should this be tested?
1. copy `conf/shiro.ini.template` into `conf/shiro.ini`
2. fill out the fields for `LdapGroupRealm` in `shiro.ini` with info from 
your ldap server
3. login with your own ldap credentials

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2498

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2321


commit 15c22cd5f456e3ef817bcdf0e982b4a87672d599
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-04T14:44:17Z

add system user info to LdapGroupRealm




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2288: [ZEPPELIN-2452] block update paragraph event on revisi...

2017-05-04 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2288
  
I think this and #2289 are required in `branch-0.7` as well, isn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2321: [ZEPPELIN-2498] add more info and config for Ld...

2017-05-04 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2321

[ZEPPELIN-2498] add more info and config for Ldap authentication 

### What is this PR for?
This is to add some necessary configs for ldap authentication.


### What type of PR is it?
Improvement |Documentation

### Todos
* [x] - add system user and security manager info
* [ ] - address feedback

### What is the Jira issue?
[ZEPPELIN-2498](https://issues.apache.org/jira/browse/ZEPPELIN-2498)

### How should this be tested?
1. copy `conf/shiro.ini.template` into `conf/shiro.ini`
2. fill out the fields for `LdapGroupRealm` in `shiro.ini` with info from 
your ldap server
3. login with your own ldap credentials

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2498

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2321.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2321






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2306: [ZEPPELIN-2479] Fix incorrect tooltip view insi...

2017-05-03 Thread khalidhuseynov

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2306

[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu

### What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu

### What type of PR is it?
Improvement

### Todos
* [x] - fix/remove tooltip

### What is the Jira issue?
[ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479)

### How should this be tested?
go to `version control` menu in notebook action bar of note

### Screenshots (if appropriate)
before: 
https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png;>


after:
![screen shot 2017-05-02 at 6 55 24 
pm](https://cloud.githubusercontent.com/assets/1642088/25613839/aac216a4-2f6a-11e7-8cab-a77ddb48382b.png)



### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2479

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2306


commit ac4e651c6a3fc37c01df860a7efe504fa72f7904
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-02T09:45:11Z

add css class




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2306: [ZEPPELIN-2479] Fix incorrect tooltip view insi...

2017-05-03 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2306


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2306: [ZEPPELIN-2479] Fix incorrect tooltip view inside of v...

2017-05-02 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2306
  
@1ambda yeah that's better idea, I just pushed the changes and updated image


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2306: [ZEPPELIN-2479] Fix incorrect tooltip view insi...

2017-05-02 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2306

[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu

### What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu

### What type of PR is it?
Improvement

### Todos
* [x] - fix/remove tooltip

### What is the Jira issue?
[ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479)

### How should this be tested?
go to `version control` menu in notebook action bar of note

### Screenshots (if appropriate)
before: 
https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png;>


after:
https://cloud.githubusercontent.com/assets/1642088/25606425/23bedafc-2f4c-11e7-9afc-d0db98210ddd.png;>


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2479

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2306


commit 6982ba499308d54d111549b066e8b6ff76959c49
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-05-02T06:20:04Z

remove tooltip




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2289: [ZEPPELIN-2452] Can not handle message in revision mod...

2017-04-27 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2289
  
i'm getting below error in web part during build here as well
```
[INFO] 
/Users../zeppelin/zeppelin-myrepo/incubator-zeppelin/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
[INFO]   846:13  error  Expected indentation of 10 spaces but found 12  
indent
[INFO]   849:11  error  Expected indentation of 8 spaces but found 10   
indent
```
could you check it as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro

2017-04-25 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2239
  
@soralee it's disappearance is based on multi-user logic and it's correct 
since if note have `owners`, `readers`, `writers` as `user1` it doesn't have 
anything to do in `admin`'s list. That's why I was telling that not sure that 
this PR makes sense, because of intervening into that flow. From another point 
when creating note, it's `owner` is automatically assigned as current user 
without asking as well, so I think having already existing logic and assigning 
current user as owner (unless having admin feature) is fine, and we don't need 
much changes on it for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro

2017-04-25 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2239
  
@soralee yeah the steps are correct. so if you follow those steps and click 
`Save`, say for `Note A`, then `Note A` will disappear from the list of your 
notes, and then you will not have permissions to view `Note A`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-04-24 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2274
  
very nice! LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2278: [ZEPPELIN-2431] Corrected deletion of notes by incorre...

2017-04-24 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2278
  
Thanks for looking into this, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2247: [ZEPPELIN-2318][branch-0.7] Fix proxy configura...

2017-04-20 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2247


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2247: [ZEPPELIN-2318][branch-0.7] Fix proxy configuration fo...

2017-04-18 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2247
  
will be merging into `branch-0.7` if no comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2247: [ZEPPELIN-2318][branch-0.7] Fix proxy configuration fo...

2017-04-13 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2247
  
@felixcheung please help to quickly go over this, since already the 
original PR for master was reviewed in #2198 and this is mostly cherry-picked 
and resolved conflict in pom.xml for `branch-0.7`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2247: [ZEPPELIN-2318][branch-0.7] Fix proxy configura...

2017-04-12 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2247

[ZEPPELIN-2318][branch-0.7] Fix proxy configuration for http client of 
zeppelinhub storage layer

### What is this PR for?
this is to resolve this issue for `branch-0.7` since original PR #2198 had 
conflicts with the branch. for more details check the original pr

### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - Task

### What is the Jira issue?
[ZEPPELIN-2318](https://issues.apache.org/jira/browse/ZEPPELIN-2318)

### How should this be tested?
check in #2198 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin 
fix/branch-0.7-ZEPPELIN-2318

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2247.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2247


commit 6add668ff50528fc3ef92beca51c3842c7679171
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-04-13T04:36:37Z

add dependency in pom, resolve coflict

commit a65f735566d644c1d0d3b6a8f4ab93423bc2560b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T12:58:59Z

add proxy client with asynclient library

commit 7f3cd5040f5b8dca85c14eb5141692c081efd68a
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T13:00:21Z

jetty client relay to asyncclient when proxy on

commit 8f8109eaaa6420d3c0ff3281cab01d2f00d1fa4f
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T13:01:01Z

add close routine

commit e6622398d1dcf8ae9f9f491b2d56da1dd137ea66
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T15:40:03Z

add ssl setup

commit d8efb462faf6066767b21fe69ed1179921b8bac0
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T16:13:09Z

fix websocket timing

commit e4db79ca0608e6e2f86b2598b8440770fd7006fc
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T16:36:21Z

fix log

commit ec23c958a03a6ada958f263b19db18f98a120cdf
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-29T07:54:38Z

edge case logs from error -> warn




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2198: [ZEPPELIN-2318] Fix proxy configuration for http clien...

2017-04-11 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2198
  
merge into master and branch-0.7 if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2243: [ZEPPELIN-2393] fix 403 error on http client ZeppelinH...

2017-04-11 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2243
  
Closing for now since can be solved by changing security policy without 
changing headers


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2243: [ZEPPELIN-2393] fix 403 error on http client Ze...

2017-04-11 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2243


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
CI is green. i linked some of related issue in 
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2216

[ZEPPELIN-2336] Fix note reload on another note create/rename/remove

### What is this PR for?
This is to fix the issue with repeated note reload when some other note is 
created/renamed/removed


### What type of PR is it?
Bug Fix

### Todos
* [x] - don't initialise controller on note list update

### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)

### How should this be tested?
Described in 
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from 
[ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be 
nice

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2216


commit e53edc0db1b3314dc1cd606f2ab7d1d597836e53
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-04-03T08:27:42Z

remove init controller on note_info

commit 74543368768ae6f30bb8d8e3769fff5ffe3e4e26
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-04-04T07:09:19Z

fix js test




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
@Leemoonsoo i found some js tests failing in second profile, let me take a 
look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
@Leemoonsoo actually I couldn't reproduce ZEPPELIN-1145, but we can reopen 
it to make sure. maybe also /cc @r-kamath as original author


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...

GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/2216

[ZEPPELIN-2336] Fix note reload on another note create/rename/remove

### What is this PR for?
This is to fix the issue with repeated note reload when some other note is 
created/renamed/removed


### What type of PR is it?
Bug Fix

### Todos
* [x] - don't initialise controller on note list update

### What is the Jira issue?
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336)

### How should this be tested?
Described in 
[ZEPPELIN-2336](https://issues.apache.org/jira/browse/ZEPPELIN-2336),
also additional test from 
[ZEPPELIN-1145](https://issues.apache.org/jira/browse/ZEPPELIN-1145) would be 
nice

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2336

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2216


commit b568a6c80faf5d4441b16de75214acddc55abed4
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-04-03T08:27:42Z

remove init controller on note_info




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...

2017-04-03 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2216: [ZEPPELIN-2336] Fix note reload on another note...

2017-04-03 Thread khalidhuseynov

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2216


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2216: [ZEPPELIN-2336] Fix note reload on another note create...

2017-04-03 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2216
  
second profile keeps failing 
[here](https://travis-ci.org/khalidhuseynov/zeppelin/jobs/217983115). as i 
tried locally, getting following error 
```
[ERROR] Failed to execute goal on project zeppelin-spark_2.10: Could not 
resolve dependencies for project 
org.apache.zeppelin:zeppelin-spark_2.10:jar:0.8.0-SNAPSHOT: Could not find 
artifact org.apache.zeppelin:zeppelin-display_2.11:jar:0.8.0-SNAPSHOT in 
apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
```
and as i checked in 
https://repository.apache.org/content/groups/snapshots/org/apache/zeppelin/zeppelin-display_2.11/,
 indeed there's no `0.8.0-SNAPSHOT`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2198: [ZEPPELIN-2318] Fix proxy configuration for http clien...

2017-03-29 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2198
  
@felixcheung right `warning` level makes more sense in those cases, 
addressed in 8ea7d5d9652fa00d00cb6d749f0e1e718beb8c95


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2198: [ZEPPELIN-2318] Fix proxy configuration for htt...

2017-03-28 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2198

[ZEPPELIN-2318] Fix proxy configuration for http client of zeppelinhub 
storage layer

### What is this PR for?
it fixes proxy configuration for http client of zeppelinhub storage layer. 
currently used jetty-client have issue with `https` over proxy 
([1](https://github.com/eclipse/jetty.project/issues/408), 
[2](https://github.com/eclipse/jetty.project/issues/827)), so new 
`httpcomponents` library have been used. 

### What type of PR is it?
Bug Fix | Improvement

### Todos
* [x] - implement whole client with proxy

### What is the Jira issue?
[ZEPPELIN-2318](https://issues.apache.org/jira/browse/ZEPPELIN-2318)

### How should this be tested?
1. setup proxy and make system point to it (e.g. env should contain 
`https_proxy`)
2. setup storage (e.g. 
[here](https://zeppelin.apache.org/docs/0.7.0/storage/storage.html#storage-in-zeppelinhub))

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2318

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2198


commit d2dab6c9654ec2604fae661bdaa7337136e9474a
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T12:57:48Z

add dependency on asyncclient

commit 16ccbb46169ca8ac546d389100d83da7597fb4f5
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T12:58:59Z

add proxy client with asynclient library

commit a5711bc1dd47531b661183e02319490c8927e887
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T13:00:21Z

jetty client relay to asyncclient when proxy on

commit 8cb94006c7e5ab99767fcc214a5eeba6cec2750b
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T13:01:01Z

add close routine

commit db07f5b569608b9a008a8798e10c63a23df12ccf
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T15:40:03Z

add ssl setup

commit 72fa4f12d98e983da1233e94609e0a57683561d5
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T15:40:37Z

fix trans dependency problem

commit 409993a8ee9f15192af105499f989a94961a92aa
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-28T16:13:09Z

fix websocket timing




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2187: [ZEPPELIN-2314] Fix watcher websocket origin header

2017-03-24 Thread khalidhuseynov

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2187
  
/cc @anthonycorbacho  @cloverhearts @Leemoonsoo  plz help review this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2187: [ZEPPELIN-2314] Fix watcher websocket origin he...

2017-03-24 Thread khalidhuseynov

GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/2187

[ZEPPELIN-2314] Fix watcher websocket origin header

### What is this PR for?
this is to add `Origin` header to ws client, and fix ws connection error 
after merging ZEPPELIN-2288, breaking ZEPPELIN-1697. more details in issue. 
also since breaking some changes in 0.7.0 branch, better include in `0.7.1`


### What type of PR is it?
Bug Fix

### Todos
* [x] - add header

### What is the Jira issue?
[ZEPPELIN-2314](https://issues.apache.org/jira/browse/ZEPPELIN-2314)

### How should this be tested?
same as in #2161 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/zeppelin fix/ZEPPELIN-2314

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2187


commit 05fced208fc0f71974702a1de026628a074f6086
Author: Khalid Huseynov <khalid...@gmail.com>
Date:   2017-03-24T11:18:45Z

add origin header to ws connect




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2161
  
@anthonycorbacho thanks for the feedback, addressed them above. Let me know 
if there's something else and if it works fine for you. 

Also would be nice if other members could review and test it, so that can 
include it in `0.7.1`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2161
  
/cc @anthonycorbacho @Leemoonsoo @AhyoungRyu plz help to review and test 
this one


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2161: [ZEPPELIN-1697] Fix multiuser ws connection for second...

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2161
  
yes, i think my fork was integrated with travis since i have the build here 
https://travis-ci.org/khalidhuseynov/incubator-zeppelin/builds/212981024 . also 
the branch was rebased today and based on commit 
4a9377db9446587aa6f76c10e581493b808dd503. So should i rebase once again or 
there's some other issue?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2161: [ZEPPELIN-1697] Fix multiuser ws connection for...

Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/2161


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2161: [ZEPPELIN-1697] Fix multiuser ws connection for...