[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2017-01-04 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2017-01-02 Thread khalidhuseynov 
GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1775

[ZEPPELIN-1745] View revisions in non-editable mode

### What is this PR for?
This is to make view of revisions non-editable

### What type of PR is it?
Improvement

### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys

### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)

### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to 
modify note

### Screenshots (if appropriate)

![revision_view](https://cloud.githubusercontent.com/assets/1642088/21340828/53131054-c6cc-11e6-960b-abf5db905194.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/revision-view

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 4c838954d38f13a6714fe9c460687e66bf92f16c
Author: Khalid Huseynov 
Date:   2016-12-16T04:20:22Z

change var name revisionDisabled -> revisionView

commit fa1397df6d0fcc469d09bb86c223e7b2bd1d007a
Author: Khalid Huseynov 
Date:   2016-12-16T08:10:26Z

disable run all

commit 8e978005f99ac1120db08abfe759f3654c3bf846
Author: Khalid Huseynov 
Date:   2016-12-16T08:12:09Z

disable clear output

commit 46238e8395ed93c4db5de575223319f4a604f6c3
Author: Khalid Huseynov 
Date:   2016-12-16T08:18:02Z

disable clone note

commit 50d40ad2af176e029ba31426065e230c41048c25
Author: Khalid Huseynov 
Date:   2016-12-16T08:19:21Z

disable export note

commit 5d9f877722211fcf96482f36c909855bef6936e6
Author: Khalid Huseynov 
Date:   2016-12-16T08:22:14Z

disable revision commit

commit ab8ab4db37d6d374b18bc9590f13f96bd1c58bf8
Author: Khalid Huseynov 
Date:   2016-12-16T08:24:16Z

disable remove note

commit 711c0b325d07f36ece5ed1ab78d086b975bdcbc4
Author: Khalid Huseynov 
Date:   2016-12-16T08:25:42Z

disable scheduler

commit 7d115b821f0734dfb361d1018c0e60b0e7d6d157
Author: Khalid Huseynov 
Date:   2016-12-19T04:21:51Z

disable + new paragraph

commit 19cacbd6116342dd5e11f63eac419b557554df9e
Author: Khalid Huseynov 
Date:   2016-12-19T04:26:37Z

don't show paragraph settings menu

commit c55de951ad0ee97d16530465e3dae1651679
Author: Khalid Huseynov 
Date:   2016-12-19T05:09:27Z

don't show run/cancel on paragraph

commit 00fb556059d561d986b4c4d2ef054f7f79e7d6b7
Author: Khalid Huseynov 
Date:   2016-12-19T08:00:39Z

make paragraph title non-editable

commit 9b85e05e0ffc03653d64984d6e27f283b7b0e4fc
Author: Khalid Huseynov 
Date:   2016-12-20T05:20:07Z

disable editor editing

normally it should be done on change of .revisionView however at that time 
editor isn't loaded yet

commit 7751b69f28d5113226fb36caff6becdb985cfb22
Author: Khalid Huseynov 
Date:   2016-12-20T06:11:50Z

disable hotkeys

commit 81346e9313b2e5c7d5b1bd205df3d2000ffe9dfb
Author: Khalid Huseynov 
Date:   2016-12-20T06:32:15Z

disable editing note name

commit 0946377d72f2dd2bdcec63b425396d2b2c965701
Author: Khalid Huseynov 
Date:   2016-12-20T06:41:34Z

disable show/hide code in note action-bar

commit 46d67af60eab15099a22950e6e191995f92fcc34
Author: Khalid Huseynov 
Date:   2016-12-20T06:43:20Z

disable show/hide output in note action bar

commit 1eea8ce1437e9d8232991c8a236ed911bdfe6cbe
Author: Khalid Huseynov 
Date:   2016-12-20T06:47:25Z

don't show paragraph level hide editor button

commit aff02b95e1b42a9d5031e6f20e28a95e0adebab8
Author: Khalid Huseynov 
Date:   2016-12-20T06:48:13Z

don't show paragraph level hide output buttton

commit e9d3ceb59136e7d51b1bb17b8574e18faa507c9d
Author: Khalid Huseynov 
Date:   2016-12-27T07:07:11Z

disable edit on db click md interpreter

commit

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2017-01-02 Thread khalidhuseynov 
Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2016-12-22 Thread khalidhuseynov 
GitHub user khalidhuseynov reopened a pull request:

https://github.com/apache/zeppelin/pull/1775

[ZEPPELIN-1745] View revisions in non-editable mode

### What is this PR for?
This is to make view of revisions non-editable

### What type of PR is it?
Improvement

### Todos
* [x] - disable action bar buttons
* [x] - disable per paragraph editing actions
* [x] - disable hotkeys

### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)

### How should this be tested?
1. initialize `GitNotebookRepo` by adding
```
export 
ZEPPELIN_NOTEBOOK_STORAGE="org.apache.zeppelin.notebook.repo.GitNotebookRepo"
```
in your `conf/zeppelin-env.sh`
2. go to any note and create few revisions using commit menu
3. then switch between revisions, during which you shouldn't be able to 
modify note

### Screenshots (if appropriate)

![revision_view](https://cloud.githubusercontent.com/assets/1642088/21340828/53131054-c6cc-11e6-960b-abf5db905194.gif)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/revision-view

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov 
Date:   2016-12-16T04:20:22Z

change var name revisionDisabled -> revisionView

commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov 
Date:   2016-12-16T08:10:26Z

disable run all

commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov 
Date:   2016-12-16T08:12:09Z

disable clear output

commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov 
Date:   2016-12-16T08:18:02Z

disable clone note

commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov 
Date:   2016-12-16T08:19:21Z

disable export note

commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov 
Date:   2016-12-16T08:22:14Z

disable revision commit

commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov 
Date:   2016-12-16T08:24:16Z

disable remove note

commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov 
Date:   2016-12-16T08:25:42Z

disable scheduler

commit ee87a53805f9af9c657db24938e47ea409cfa258
Author: Khalid Huseynov 
Date:   2016-12-19T04:21:51Z

disable + new paragraph

commit 9d73be4f8447596600b6f9723922d521f66d337f
Author: Khalid Huseynov 
Date:   2016-12-19T04:26:37Z

don't show paragraph settings menu

commit 2cf28dce40b14bed547fe5727850093ef490a258
Author: Khalid Huseynov 
Date:   2016-12-19T05:09:27Z

don't show run/cancel on paragraph

commit 45a11cf45e0531e3159eb399e0b3d07a305ccbc4
Author: Khalid Huseynov 
Date:   2016-12-19T08:00:39Z

make paragraph title non-editable

commit e61e049efdf53b8c386f60f6a11be3e43518
Author: Khalid Huseynov 
Date:   2016-12-20T05:20:07Z

disable editor editing

normally it should be done on change of .revisionView however at that time 
editor isn't loaded yet

commit e78599cc82fc22e253ba4f52dcdd7482133bf6f1
Author: Khalid Huseynov 
Date:   2016-12-20T06:11:50Z

disable hotkeys

commit 464d19f3b3cef37def095f8dd30e35c208041e6e
Author: Khalid Huseynov 
Date:   2016-12-20T06:32:15Z

disable editing note name

commit 4c71b6def9164f0675b2f9483a88fa01a7a26483
Author: Khalid Huseynov 
Date:   2016-12-20T06:41:34Z

disable show/hide code in note action-bar

commit ebf2d2fd55a2042d65579ae0149a98a6de07b944
Author: Khalid Huseynov 
Date:   2016-12-20T06:43:20Z

disable show/hide output in note action bar

commit 9b42e0ef9a503e8eebb3ca0fa9673ea10097e61e
Author: Khalid Huseynov 
Date:   2016-12-20T06:47:25Z

don't show paragraph level hide editor button

commit 6963abae404e4aadae6445c8990e23ba52d44183
Author: Khalid Huseynov 
Date:   2016-12-20T06:48:13Z

don't show paragraph level hide output buttton




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2016-12-22 Thread khalidhuseynov 
Github user khalidhuseynov closed the pull request at:

https://github.com/apache/zeppelin/pull/1775


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1775: [ZEPPELIN-1745] View revisions in non-editable ...

2016-12-16 Thread khalidhuseynov 
GitHub user khalidhuseynov opened a pull request:

https://github.com/apache/zeppelin/pull/1775

[ZEPPELIN-1745] View revisions in non-editable mode

### What is this PR for?
This is to make view of revisions non-editable

### What type of PR is it?
Improvement

### Todos
* [x] - disable action bar buttons
* [ ] - disable per paragraph editing
* [ ] - hotkeys?

### What is the Jira issue?
[ZEPPELIN-1745](https://issues.apache.org/jira/browse/ZEPPELIN-1745)

### How should this be tested?
TBD

### Screenshots (if appropriate)
TBD

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? possibly


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/revision-view

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 9db56ce63910d9738b2f7a874cab8e6570f16b49
Author: Khalid Huseynov 
Date:   2016-12-16T04:20:22Z

change var name revisionDisabled -> revisionView

commit cd4e37072c8e154d551ed0c3361fff719a8d55ae
Author: Khalid Huseynov 
Date:   2016-12-16T08:10:26Z

disable run all

commit 4f12a5bff226e7f871e810a254daeaea58f3b395
Author: Khalid Huseynov 
Date:   2016-12-16T08:12:09Z

disable clear output

commit 5c9dd80a94ed990a41251c105a9c7b697bf3221c
Author: Khalid Huseynov 
Date:   2016-12-16T08:18:02Z

disable clone note

commit 49f0e15ff215e925657b2972ec7f239b64c2e104
Author: Khalid Huseynov 
Date:   2016-12-16T08:19:21Z

disable export note

commit a05f355a96feb1cf7a424cda6775862439b974b0
Author: Khalid Huseynov 
Date:   2016-12-16T08:22:14Z

disable revision commit

commit dbb680cda6df168030bda2eebcbcba1ca32c0b62
Author: Khalid Huseynov 
Date:   2016-12-16T08:24:16Z

disable remove note

commit 00a0a247162791f2d332c0049ea469008b0e2177
Author: Khalid Huseynov 
Date:   2016-12-16T08:25:42Z

disable scheduler




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---