[jira] [Commented] (ZOOKEEPER-1242) Repeat add watcher, memory leak
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133842#comment-13133842 ] Mahadev konar commented on ZOOKEEPER-1242: -- @Peng, The jira seems to be resolved? The patch doesnt seem to be committed, any reason you marked this resolved? Repeat add watcher, memory leak - Key: ZOOKEEPER-1242 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1242 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Redhat linux Reporter: Peng Futian Labels: patch Fix For: 3.3.4 Attachments: ZOOKEEPER-1242.patch Original Estimate: 1h Remaining Estimate: 1h When I repeat add watcher , there are a memory leak. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1241) Typo in ZooKeeper Recipes and Solutions documentation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-1241: Assignee: Jingguo Yao Typo in ZooKeeper Recipes and Solutions documentation - Key: ZOOKEEPER-1241 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1241 Project: ZooKeeper Issue Type: Bug Components: documentation Affects Versions: 3.3.3 Reporter: Jingguo Yao Assignee: Jingguo Yao Priority: Minor Attachments: ZOOKEEPER-1241.patch Original Estimate: 5m Remaining Estimate: 5m In if p is the lowest process node in L, wait on highest process node in P, P should be L. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1240) Compiler issue with redhat linux
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133847#comment-13133847 ] Mahadev konar commented on ZOOKEEPER-1240: -- Peng, You seem to have closed the jira again? Take a look at how to contribute, on the https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute for guidance on how to upload/review/get it committed. Compiler issue with redhat linux Key: ZOOKEEPER-1240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1240 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Linux phy 2.6.18-53.el5 #1 SMP Wed Oct 10 16:34:19 EDT 2007 x86_64 x86_64 x86_64 GNU/Linux gcc version 4.1.2 20070626 (Red Hat 4.1.2-14) Reporter: Peng Futian Priority: Minor Labels: patch Fix For: 3.3.4 Attachments: ZOOKEEPER-1240.patch Original Estimate: 1h Remaining Estimate: 1h When I compile zookeeper c client in my project, there are some error: ../../../include/zookeeper/recordio.h:70: error：expected unqualified-id before '__extension__' ../../../include/zookeeper/recordio.h:70: error：expected `)' before '__extension__' ../../.. /include/zookeeper/recordio.h:70: error：expected unqualified-id before ')' token -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-602 PreCommit Build #642
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/642/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 84 lines...] [exec] 1 out of 2 hunks FAILED -- saving rejects to file src/java/main/org/apache/zookeeper/server/quorum/Leader.java.rej [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java [exec] patching file src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java [exec] patching file src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java [exec] patching file src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java [exec] patching file src/java/main/org/apache/zookeeper/server/ZooKeeperThread.java [exec] patching file src/java/test/org/apache/zookeeper/server/TestZooKeeperThread.java [exec] PATCH APPLICATION FAILED [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch [exec] against trunk revision 1188033. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] -1 patch. The patch command could not apply the patch. [exec] [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/642//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9McJigkimf logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1576: exec returned: 1 Total time: 40 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-602 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[ https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133873#comment-13133873 ] Hadoop QA commented on ZOOKEEPER-602: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496990/ZOOKEEPER-602.patch against trunk revision 1188033. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/642//console This message is automatically generated. log all exceptions not caught by ZK threads --- Key: ZOOKEEPER-602 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602 Project: ZooKeeper Issue Type: Bug Components: java client, server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Laxman Priority: Critical Fix For: 3.5.0 Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch the java code should add a ThreadGroup exception handler that logs at ERROR level any uncaught exceptions thrown by Thread run methods. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133915#comment-13133915 ] Daniel Gómez Ferro commented on ZOOKEEPER-442: -- How should we deal with the asynchronous version of the call? I see three options: * Don't provide an async version. * Remove the Watcher parameter, effectively removing all watches on the given znode. * Find a way to trigger the callback directly from the client (could also help ZOOKEEPER-847, where we want to throw an exception and invoke the callback) need a way to remove watches that are no longer of interest --- Key: ZOOKEEPER-442 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442 Project: ZooKeeper Issue Type: Improvement Reporter: Benjamin Reed Priority: Critical Attachments: ZOOKEEPER-442.patch currently the only way a watch cleared is to trigger it. we need a way to enumerate the outstanding watch objects, find watch events the objects are watching for, and remove interests in an event. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Gómez Ferro reassigned ZOOKEEPER-442: Assignee: Daniel Gómez Ferro need a way to remove watches that are no longer of interest --- Key: ZOOKEEPER-442 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442 Project: ZooKeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Daniel Gómez Ferro Priority: Critical Attachments: ZOOKEEPER-442.patch currently the only way a watch cleared is to trigger it. we need a way to enumerate the outstanding watch objects, find watch events the objects are watching for, and remove interests in an event. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133928#comment-13133928 ] Gunnar Wagenknecht commented on ZOOKEEPER-442: -- From my point of view I need the following: * Remove all local references to watcher object together with all coressponsing watcher objects in server (if connection is available). The second part should/can be done asynchronous. Especially because I'm not interested in the result (other clients actually may be interested). need a way to remove watches that are no longer of interest --- Key: ZOOKEEPER-442 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442 Project: ZooKeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Daniel Gómez Ferro Priority: Critical Attachments: ZOOKEEPER-442.patch currently the only way a watch cleared is to trigger it. we need a way to enumerate the outstanding watch objects, find watch events the objects are watching for, and remove interests in an event. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-602) log all exceptions not caught by ZK threads
[
https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133926#comment-13133926
]
Laxman commented on ZOOKEEPER-602:
--
Thanks for the interest Pat.
I will refresh the patch on latest trunk.
{quote}also some findbugs issues{quote}
One System.exit is introduced which is part of the fix.
Can you please take a look at my previous comments about criticality of threads.
https://issues.apache.org/jira/browse/ZOOKEEPER-602?focusedCommentId=13117887page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13117887
log all exceptions not caught by ZK threads
---
Key: ZOOKEEPER-602
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
Project: ZooKeeper
Issue Type: Bug
Components: java client, server
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Laxman
Priority: Critical
Fix For: 3.5.0
Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch
the java code should add a ThreadGroup exception handler that logs at ERROR
level any uncaught exceptions thrown by Thread run methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-88) derby doesn't like - in the topic names
[ https://issues.apache.org/jira/browse/BOOKKEEPER-88?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133929#comment-13133929 ] Ivan Kelly commented on BOOKKEEPER-88: -- Committed at r1188059. Thanks Ben. derby doesn't like - in the topic names --- Key: BOOKKEEPER-88 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-88 Project: Bookkeeper Issue Type: Bug Reporter: Benjamin Reed Priority: Minor Attachments: BOOKKEEPER-88.patch it's just a benchmark, but it is convenient to be able to use derby as a backend for the hedwig benchmark. derby does not support - in topic names. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-442) need a way to remove watches that are no longer of interest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133945#comment-13133945 ] Vitalii Tymchyshyn commented on ZOOKEEPER-442: -- OK, as for me: * On client each watcher group (grouping watchers on path) should have watcher state - e.g. normal/deleting/creating * Delete watcher message to server must be acked * If last watcher from group is removed, delete message is sent to server and watcher goes to deleting state * As soon as deletion is acked (and group is still in deletion), watcher group is removed on client * If new watcher to group is added and watcher group is new or in deleting state, watch message to server is sent and group goes to creating state * As soon as creation is acked ( and group is still in creating), watcher group goes to normal. need a way to remove watches that are no longer of interest --- Key: ZOOKEEPER-442 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442 Project: ZooKeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Daniel Gómez Ferro Priority: Critical Attachments: ZOOKEEPER-442.patch currently the only way a watch cleared is to trigger it. we need a way to enumerate the outstanding watch objects, find watch events the objects are watching for, and remove interests in an event. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1181) Fix problems with Kerberos TGT renewal
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13133974#comment-13133974 ] Hudson commented on ZOOKEEPER-1181: --- Integrated in ZooKeeper-trunk #1342 (See [https://builds.apache.org/job/ZooKeeper-trunk/1342/]) ZOOKEEPER-1181. Fix problems with Kerberos TGT renewal. (Eugene Koontz via mahadev) mahadev : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1188033 Files : * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/Login.java Fix problems with Kerberos TGT renewal -- Key: ZOOKEEPER-1181 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1181 Project: ZooKeeper Issue Type: Bug Components: java client, server Affects Versions: 3.4.0 Reporter: Eugene Koontz Assignee: Eugene Koontz Labels: kerberos, security Fix For: 3.4.0, 3.5.0 Attachments: ZOOKEEPER-1181.patch, ZOOKEEPER-1181.patch, ZOOKEEPER-1181.patch Currently, in Zookeeper trunk, there are two problems with Kerberos TGT renewal: 1. TGTs obtained from a keytab are not refreshed periodically. They should be, just as those from ticket cache are refreshed. 2. Ticket renewal should be retried if it fails. Ticket renewal might fail if two or more separate processes (different JVMs) running as the same user try to renew Kerberos credentials at the same time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1199: --- Attachment: ZOOKEEPER-1199.patch Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1199: --- Attachment: (was: ZOOKEEPER-1199.patch) Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1199 PreCommit Build #643
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 142918 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500448/ZOOKEEPER-1199.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] QkYq1cov1l logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1576: exec returned: 2 Total time: 19 minutes 31 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1199 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 2 tests failed. REGRESSION: org.apache.zookeeper.test.ReadOnlyModeTest.testSessionEstablishment Error Message: Did not connect Stack Trace: java.util.concurrent.TimeoutException: Did not connect at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:124) at org.apache.zookeeper.test.ReadOnlyModeTest.testSessionEstablishment(ReadOnlyModeTest.java:160) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.test.ReadOnlyModeTest.testSeekForRwServer Error Message: Did not connect Stack Trace: java.util.concurrent.TimeoutException: Did not connect at org.apache.zookeeper.test.ClientBase$CountdownWatcher.waitForConnected(ClientBase.java:124) at org.apache.zookeeper.test.ReadOnlyModeTest.testSeekForRwServer(ReadOnlyModeTest.java:201) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134085#comment-13134085 ] Hadoop QA commented on ZOOKEEPER-1199: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500448/ZOOKEEPER-1199.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/643//console This message is automatically generated. Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1216: --- Attachment: ZOOKEEPER-1216.patch * removed accidentally introduced tab characters * removed three other warnings that leaked in in the meanwhile Fix more eclipse compiler warnings, also in Tests - Key: ZOOKEEPER-1216 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine. Warnings are now down to 5! So no excuses to introduce new ones! Fixed warnings: - removed unused imports - removed unused variables / methods - added missing generics - added ignore warnings for calls to deprecated code in tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier updated ZOOKEEPER-1243: Attachment: ZOOKEEPER-1243.patch New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-89: - Attachment: BOOKKEEPER-89.diff Fixed the hedwig server compile. I hadn't cleaned, before testing last time. Bookkeeper API changes for initial Bookkeeper release - Key: BOOKKEEPER-89 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-89.diff, BOOKKEEPER-89.diff Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134118#comment-13134118 ] jirapos...@reviews.apache.org commented on BOOKKEEPER-89: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2543/ --- (Updated 2011-10-24 14:53:25.740238) Review request for bookkeeper. Summary --- Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public This addresses bug BOOKKEEPER-89. https://issues.apache.org/jira/browse/BOOKKEEPER-89 Diffs (updated) - bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java 6421460 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 6af43ae bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperTools.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java d4af3fa bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java 78aaa15 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 959df73 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MacDigestManager.java 1131652 bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java 94e444c bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java dfc63d7 bookkeeper-server/src/test/java/org/apache/bookkeeper/client/LedgerCacheTest.java PRE-CREATION bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 224c796 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java 82483f3 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 56331ef bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieRecoveryTest.java f933ba1 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerCacheTest.java 3a78507 hedwig-server/src/main/java/org/apache/hedwig/server/benchmark/BookkeeperBenchmark.java a934985 hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 726341d hedwig-server/src/test/java/org/apache/hedwig/server/persistence/BookKeeperTestBase.java b918d97 pom.xml 2392db5 Diff: https://reviews.apache.org/r/2543/diff Testing --- Thanks, Ivan Bookkeeper API changes for initial Bookkeeper release - Key: BOOKKEEPER-89 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-89.diff, BOOKKEEPER-89.diff Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public -- This
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134115#comment-13134115 ] Hadoop QA commented on ZOOKEEPER-1243: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500455/ZOOKEEPER-1243.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/645//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/645//console This message is automatically generated. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier updated ZOOKEEPER-1243: Attachment: ZOOKEEPER-1243-2 New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1216 PreCommit Build #644
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 140231 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500452/ZOOKEEPER-1216.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 91 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 53gGfEZkdH logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 22 minutes 10 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1216 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER-1243 PreCommit Build #645
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/645/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 603 lines...] [exec] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500455/ZOOKEEPER-1243.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/645//testReport/ [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/645//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] c05Yy5Q3no logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1576: exec returned: 3 Total time: 1 minute 10 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1243 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## No tests ran.
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134125#comment-13134125 ] Hadoop QA commented on ZOOKEEPER-1216: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500452/ZOOKEEPER-1216.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 91 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/644//console This message is automatically generated. Fix more eclipse compiler warnings, also in Tests - Key: ZOOKEEPER-1216 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine. Warnings are now down to 5! So no excuses to introduce new ones! Fixed warnings: - removed unused imports - removed unused variables / methods - added missing generics - added ignore warnings for calls to deprecated code in tests -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1199: --- Attachment: ZOOKEEPER-1199.patch Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1243 PreCommit Build #646
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 143199 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500457/ZOOKEEPER-1243-2 [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] m9p9CmCC4A logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 22 minutes 12 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1243 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134136#comment-13134136 ] Hadoop QA commented on ZOOKEEPER-1243: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500457/ZOOKEEPER-1243-2 against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/646//console This message is automatically generated. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Failed: ZOOKEEPER-1199 PreCommit Build #647
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/647/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 143942 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500458/ZOOKEEPER-1199.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/647//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/647//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/647//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 3ZL188Qv1P logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1576: exec returned: 1 Total time: 22 minutes 19 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1199 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Updated] (BOOKKEEPER-90) Hedwig API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-90: - Attachment: BOOKKEEPER-90.diff Hedwig API changes for initial Bookkeeper release - Key: BOOKKEEPER-90 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-90 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-90.diff HedwigClient#getSslFactory shouldn't be public HedwigClient#getConsumeCallback shouldn't be public HedwigClient#doConnect shouldn't be public HedwigClient#getHostFromChannel shouldn't be public HedwigClient#getResponseHandlerFromChannel shouldn't be public HedwigClient#getHostForTopic shouldn't be public HedwigClient#clearAllTopicsForHost shouldn't be public HedwigClient#getClientTimer shoulnd't be public HedwigClient#stop should throw some sort of Exception in the case of errors HedwigPublisher#publish shouldn't use protobuf ByteString, as it requires the user to import protobufs HedwigPublisher#getChannelForHost shouldn't be public HedwigSubscriber#HedwigSubscriber shouldn't be public HedwigSubscriber#doConsume shouldn't be public HedwigSubscriber#hasSubscription probably shouldn't be public HedwigSubscriber#getSubscriptionList shoulnd't exist HedwigSubscriber#getChannelForTopic shouldn't be public HedwigSubscriber#setChannelforTopic shouldn't be public HedwigSubscriber#removeChannelForTopic shound't be public MessageHandler#consume should be called 'deliver' The hedwig client is under a netty package. There's nothing netty specific about the api, so it should be in the org.apache.hedwig.client package. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-90) Hedwig API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134159#comment-13134159 ] Ivan Kelly commented on BOOKKEEPER-90: -- I've attached the first part of the hedwig changes. I still need to decide on ByteString and HedwigClient#stop(). Hedwig API changes for initial Bookkeeper release - Key: BOOKKEEPER-90 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-90 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-90.diff HedwigClient#getSslFactory shouldn't be public HedwigClient#getConsumeCallback shouldn't be public HedwigClient#doConnect shouldn't be public HedwigClient#getHostFromChannel shouldn't be public HedwigClient#getResponseHandlerFromChannel shouldn't be public HedwigClient#getHostForTopic shouldn't be public HedwigClient#clearAllTopicsForHost shouldn't be public HedwigClient#getClientTimer shoulnd't be public HedwigClient#stop should throw some sort of Exception in the case of errors HedwigPublisher#publish shouldn't use protobuf ByteString, as it requires the user to import protobufs HedwigPublisher#getChannelForHost shouldn't be public HedwigSubscriber#HedwigSubscriber shouldn't be public HedwigSubscriber#doConsume shouldn't be public HedwigSubscriber#hasSubscription probably shouldn't be public HedwigSubscriber#getSubscriptionList shoulnd't exist HedwigSubscriber#getChannelForTopic shouldn't be public HedwigSubscriber#setChannelforTopic shouldn't be public HedwigSubscriber#removeChannelForTopic shound't be public MessageHandler#consume should be called 'deliver' The hedwig client is under a netty package. There's nothing netty specific about the api, so it should be in the org.apache.hedwig.client package. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-90) Hedwig API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134195#comment-13134195 ] Ivan Kelly commented on BOOKKEEPER-90: -- Patch applies on top of BOOKKEEPER-89. Hedwig API changes for initial Bookkeeper release - Key: BOOKKEEPER-90 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-90 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-90.diff HedwigClient#getSslFactory shouldn't be public HedwigClient#getConsumeCallback shouldn't be public HedwigClient#doConnect shouldn't be public HedwigClient#getHostFromChannel shouldn't be public HedwigClient#getResponseHandlerFromChannel shouldn't be public HedwigClient#getHostForTopic shouldn't be public HedwigClient#clearAllTopicsForHost shouldn't be public HedwigClient#getClientTimer shoulnd't be public HedwigClient#stop should throw some sort of Exception in the case of errors HedwigPublisher#publish shouldn't use protobuf ByteString, as it requires the user to import protobufs HedwigPublisher#getChannelForHost shouldn't be public HedwigSubscriber#HedwigSubscriber shouldn't be public HedwigSubscriber#doConsume shouldn't be public HedwigSubscriber#hasSubscription probably shouldn't be public HedwigSubscriber#getSubscriptionList shoulnd't exist HedwigSubscriber#getChannelForTopic shouldn't be public HedwigSubscriber#setChannelforTopic shouldn't be public HedwigSubscriber#removeChannelForTopic shound't be public MessageHandler#consume should be called 'deliver' The hedwig client is under a netty package. There's nothing netty specific about the api, so it should be in the org.apache.hedwig.client package. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (BOOKKEEPER-91) Bookkeeper and hedwig clients should not use log4j directly
Bookkeeper and hedwig clients should not use log4j directly --- Key: BOOKKEEPER-91 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-91 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Using log4j directly requires that any application using bookkeeper or hedwig clients have to configure log4j. We should use something like commons logging[1] or slf4j[2]. [1] http://commons.apache.org/logging/index.html [2] http://www.slf4j.org/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-1199: --- Attachment: ZOOKEEPER-1199.patch Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2272/ --- (Updated 2011-10-24 16:59:05.682064) Review request for zookeeper. Summary --- ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine. Warnings are now down to 5! So no excuses to introduce new ones! Fixed warnings: removed unused imports removed unused variables / methods added missing generics added ignore warnings for calls to deprecated code in tests This addresses bug ZOOKEEPER-1216. https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Diffs (updated) - src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645 src/java/main/org/apache/zookeeper/Login.java 294801a src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1 src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95 src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278 src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792 src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8 src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743 src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9 src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java b22e078 src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 93c51b8 src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6 src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665 src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 31d32f4 src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0 src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826 src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82 src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70 src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 5a9c759 src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852 src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78 src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0 src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9 src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java 9d373fc src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33 src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004 src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54 src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3 Diff: https://reviews.apache.org/r/2272/diff Testing --- Thanks, Thomas
[jira] [Commented] (ZOOKEEPER-1216) Fix more eclipse compiler warnings, also in Tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134236#comment-13134236 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-1216: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2272/ --- (Updated 2011-10-24 16:59:05.682064) Review request for zookeeper. Summary --- ZOOKEEPER-1216 Fix more eclipse compiler warnings, also in Tests I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine. Warnings are now down to 5! So no excuses to introduce new ones! Fixed warnings: removed unused imports removed unused variables / methods added missing generics added ignore warnings for calls to deprecated code in tests This addresses bug ZOOKEEPER-1216. https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Diffs (updated) - src/java/main/org/apache/zookeeper/JLineZNodeCompletor.java 02b0645 src/java/main/org/apache/zookeeper/Login.java 294801a src/java/main/org/apache/zookeeper/ZooKeeperMain.java 98784d1 src/java/main/org/apache/zookeeper/server/ByteBufferOutputStream.java a2fcc95 src/java/main/org/apache/zookeeper/server/PurgeTxnLog.java 1511ddb src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java d1ce278 src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792 src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java e2e24aa src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 13541e8 src/java/systest/org/apache/zookeeper/test/system/BaseSysTest.java 575a743 src/java/systest/org/apache/zookeeper/test/system/GenerateLoad.java ce239f9 src/java/systest/org/apache/zookeeper/test/system/InstanceContainer.java b22e078 src/java/systest/org/apache/zookeeper/test/system/InstanceManager.java 93c51b8 src/java/systest/org/apache/zookeeper/test/system/SimpleClient.java 44f113a src/java/test/org/apache/zookeeper/TestableZooKeeper.java f8344b6 src/java/test/org/apache/zookeeper/ZKTestCase.java b721cfc src/java/test/org/apache/zookeeper/server/InvalidSnapshotTest.java 738f665 src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 31d32f4 src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java a6a86d0 src/java/test/org/apache/zookeeper/test/ACLRootTest.java 7307cbf src/java/test/org/apache/zookeeper/test/ClientTest.java e99d8df src/java/test/org/apache/zookeeper/test/CreateModeTest.java a3b838a src/java/test/org/apache/zookeeper/test/EventTypeTest.java e6a9826 src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 81ea12b src/java/test/org/apache/zookeeper/test/FLETest.java b1b8e82 src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1b6ab70 src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 5a9c759 src/java/test/org/apache/zookeeper/test/KeeperStateTest.java 55dc852 src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 21fed78 src/java/test/org/apache/zookeeper/test/LETest.java 78d68f0 src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java 2e0dcd9 src/java/test/org/apache/zookeeper/test/ObserverHierarchicalQuorumTest.java 9d373fc src/java/test/org/apache/zookeeper/test/QuorumQuotaTest.java bef1a33 src/java/test/org/apache/zookeeper/test/QuorumTest.java c9c3b9a src/java/test/org/apache/zookeeper/test/RepeatStartupTest.java 3421004 src/java/test/org/apache/zookeeper/test/SessionTest.java df9bd54 src/java/test/org/apache/zookeeper/test/WatcherTest.java fc3eccd src/java/test/org/apache/zookeeper/test/ZooKeeperQuotaTest.java fbf09b3 Diff: https://reviews.apache.org/r/2272/diff Testing --- Thanks, Thomas Fix more eclipse compiler warnings, also in Tests - Key: ZOOKEEPER-1216 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1216 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Priority: Minor Fix For: 3.5.0 Attachments: ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch, ZOOKEEPER-1216.patch I did set up a new work environment for a presentation of Eclipse+EGit+Gerrit+Jenkins and found more warnings that were ignored on my machine. Warnings are now down to 5! So no excuses to introduce new ones! Fixed warnings: - removed unused imports - removed unused variables / methods - added missing
[jira] [Commented] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134249#comment-13134249 ] Hadoop QA commented on ZOOKEEPER-1199: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500490/ZOOKEEPER-1199.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//console This message is automatically generated. Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1199 PreCommit Build #648
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141279 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500490/ZOOKEEPER-1199.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/648//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] O831rS7N9E logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 22 minutes 21 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1199 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
Failed: ZOOKEEPER-1198 PreCommit Build #649
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 140572 lines...] [exec] [exec] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500492/ZOOKEEPER-1198.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 119 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] -1 javac. The patch appears to cause tar ant target to fail. [exec] [exec] -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] -1 core tests. The patch failed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] OlfKYfIz76 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1576: exec returned: 3 Total time: 19 minutes 21 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1198 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 2 tests failed. REGRESSION: org.apache.zookeeper.test.ObserverTest.testObserver Error Message: KeeperErrorCode = ConnectionLoss for /obstest Stack Trace: org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /obstest at org.apache.zookeeper.KeeperException.create(KeeperException.java:101) at org.apache.zookeeper.KeeperException.create(KeeperException.java:53) at org.apache.zookeeper.ZooKeeper.setData(ZooKeeper.java:1229) at org.apache.zookeeper.test.ObserverTest.testObserver(ObserverTest.java:109) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) REGRESSION: org.apache.zookeeper.test.QuorumTest.testSessionMoved Error Message: null Stack Trace: junit.framework.AssertionFailedError at org.apache.zookeeper.test.QuorumTest.testSessionMoved(QuorumTest.java:224) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
[jira] [Commented] (ZOOKEEPER-1198) Refactorings and Cleanups
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134261#comment-13134261 ] Hadoop QA commented on ZOOKEEPER-1198: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500492/ZOOKEEPER-1198.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 119 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/649//console This message is automatically generated. Refactorings and Cleanups - Key: ZOOKEEPER-1198 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1198 Project: ZooKeeper Issue Type: Improvement Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1198.patch, ZOOKEEPER-1198.patch, ZOOKEEPER-1198.patch, ZOOKEEPER-1198.patch Umbrella issue for refactorings. I'll post individual refactoring steps as sub-issues. I'll also use this umbrella issue to submit previews of the full refactoring for testing by Jenkins or to ReviewBoard. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1200 PreCommit Build #650
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1200 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141317 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500494/ZOOKEEPER-1200.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] UMM0rHJ26K logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 22 minutes 36 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1200 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1200) Remove obsolete DataTreeBuilder
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134269#comment-13134269 ] Hadoop QA commented on ZOOKEEPER-1200: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500494/ZOOKEEPER-1200.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/650//console This message is automatically generated. Remove obsolete DataTreeBuilder --- Key: ZOOKEEPER-1200 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1200 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Fix For: 3.5.0 Attachments: ZOOKEEPER-1200.patch, ZOOKEEPER-1200.patch There's a DataTreeBuilder thing in the whole type hierarchy of ZooKeeperServer classes, which is never used. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Review Request: ZOOKEEPER-1199: Make OpCode an enum
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2015/ --- (Updated 2011-10-24 17:44:19.879262) Review request for zookeeper. Summary --- There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in? I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there? This addresses bug ZOOKEEPER-1199. https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Diffs (updated) - src/contrib/loggraph/src/java/org/apache/zookeeper/graph/TxnLogSource.java 809c455 src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 9216751 src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d src/java/main/org/apache/zookeeper/Op.java 3c3db2e src/java/main/org/apache/zookeeper/OpResult.java 514318f src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20 src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0 src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e src/java/main/org/apache/zookeeper/server/DataTree.java 757a572 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 336827a src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3 src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e44c65e src/java/main/org/apache/zookeeper/server/Request.java c6a2249 src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7 src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 938cf19 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 2f77e9d src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java a1c8ce2 src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 27bf496 src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543 src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792 src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java bfbc9a8 src/java/main/org/apache/zookeeper/server/quorum/Observer.java 8e77ac8 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java e94414f src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 82d1468 src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4 src/java/test/org/apache/zookeeper/common/OpCodeTest.java PRE-CREATION src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210 Diff: https://reviews.apache.org/r/2015/diff Testing --- Thanks, Thomas
[jira] [Commented] (ZOOKEEPER-1199) Make OpCode an enum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134281#comment-13134281 ] jirapos...@reviews.apache.org commented on ZOOKEEPER-1199: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2015/ --- (Updated 2011-10-24 17:44:19.879262) Review request for zookeeper. Summary --- There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in? I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there? This addresses bug ZOOKEEPER-1199. https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Diffs (updated) - src/contrib/loggraph/src/java/org/apache/zookeeper/graph/TxnLogSource.java 809c455 src/java/main/org/apache/zookeeper/ClientCnxn.java 6c25e40 src/java/main/org/apache/zookeeper/ClientCnxnSocketNIO.java 9216751 src/java/main/org/apache/zookeeper/MultiResponse.java 97d4c7d src/java/main/org/apache/zookeeper/MultiTransactionRecord.java af3b58d src/java/main/org/apache/zookeeper/Op.java 3c3db2e src/java/main/org/apache/zookeeper/OpResult.java 514318f src/java/main/org/apache/zookeeper/ZooDefs.java c7f1b20 src/java/main/org/apache/zookeeper/ZooKeeper.java e82eaa0 src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java 722538e src/java/main/org/apache/zookeeper/server/DataTree.java 757a572 src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 336827a src/java/main/org/apache/zookeeper/server/LogFormatter.java 9be3fe3 src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java e44c65e src/java/main/org/apache/zookeeper/server/Request.java c6a2249 src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b src/java/main/org/apache/zookeeper/server/TraceFormatter.java 60d1cc7 src/java/main/org/apache/zookeeper/server/ZKDatabase.java 2842803 src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 9ccaa0e src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 938cf19 src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 2f77e9d src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java a1c8ce2 src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 27bf496 src/java/main/org/apache/zookeeper/server/quorum/Learner.java a97a543 src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java c518792 src/java/main/org/apache/zookeeper/server/quorum/LearnerSyncRequest.java bfbc9a8 src/java/main/org/apache/zookeeper/server/quorum/Observer.java 8e77ac8 src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java e94414f src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 82d1468 src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java f9647c4 src/java/test/org/apache/zookeeper/common/OpCodeTest.java PRE-CREATION src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java e37cbec src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 7a5a75b src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java a134210 Diff: https://reviews.apache.org/r/2015/diff Testing --- Thanks, Thomas Make OpCode an enum --- Key: ZOOKEEPER-1199 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1199 Project: ZooKeeper Issue Type: Sub-task Reporter: Thomas Koch Assignee: Thomas Koch Attachments: ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch, ZOOKEEPER-1199.patch ZooDefs.OpCode is an interface with integer constants. Changing this to an enum provides safety. See Item 30: Use enums instead of int constants in Effective Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Why does multi-op check operation increment zxid?
Benjamin Reed: i was thinking mostly in terms of the code itself. enums are great for structures that aren't serialized, but when you do serialize it, you end up having to force specific values into the enum and converting back and forth during the serialization and deserialization. i find that the enums, in this case, just shift the ugliness around. i'm also not sure about the performance implication, it should just be the cost of autoboxing, but to be honest it's more about the code readability to me. ben Hi Ben, I've updated the patch for ZK-1199 (make OpCode an enum). Please see yourself, whether you consider the resulting code to be uglier or not. Especially in the following classes I could remove a couple of lines and complexity: PrepRequestProcessor, CommitProcessor, FollowerRequestProcessor, ObserverRequestProcessor, ReadOnlyRequestProcessor If you're concerned about readability, we should trust Joshua Bloch. One of the advantages pointed out by him is type safety. The Request class has long zxid, long sessionId, long cxid, and int type. During refactoring I've had a hard time to not mix positions of the constructor parameters. The IDE can not help me to distinguish between different number types. Best regards, Thomas Koch, http://www.koch.ro
Zookeeper sync timeout issues
Hi All, It looks like one of our ZK quorum servers cannot sync with the leader anymore. The leader logs show Read timed out errors and the follower is showing a Broken pipe at the same time. Follower logs 2011-10-24 11:53:23,110 - INFO [QuorumPeer:/0.0.0.0:2181:FileSnap@82] - Reading snapshot /var/zookeeper/version-2/snapshot.1de07 2011-10-24 11:53:32,792 - WARN [QuorumPeer:/0.0.0.0:2181:QuorumPeer@497] - Unable to load database java.io.IOException: Transaction log: /var/zookeeper/version-2/log.1de08 has invalid magic number 0 != 1514884167 at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:510) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:527) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:493) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:475) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:454) at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:325) at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:126) at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222) at org.apache.zookeeper.server.quorum.QuorumPeer.getLastLoggedZxid(QuorumPeer.java:493) at org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:69) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:645) 2011-10-24 11:53:32,793 - INFO [QuorumPeer:/0.0.0.0:2181:Learner@294] - Getting a snapshot from leader 2011-10-24 11:54:19,716 - INFO [QuorumPeer:/0.0.0.0:2181:Learner@325] - Setting leader epoch 1 2011-10-24 11:54:19,717 - INFO [QuorumPeer:/0.0.0.0:2181:FileTxnSnapLog@208] - Snapshotting: 1de0d 2011-10-24 11:54:44,412 - WARN [QuorumPeer:/0.0.0.0:2181:Follower@82] - Exception when following the leader java.net.SocketException: Broken pipe at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(Unknown Source) at java.net.SocketOutputStream.write(Unknown Source) at java.io.BufferedOutputStream.flushBuffer(Unknown Source) at java.io.BufferedOutputStream.flush(Unknown Source) at org.apache.zookeeper.server.quorum.Learner.writePacket(Learner.java:134) at org.apache.zookeeper.server.quorum.Learner.ping(Learner.java:418) at org.apache.zookeeper.server.quorum.Follower.processPacket(Follower.java:108) at org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:79) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:645) 2011-10-24 11:54:45,784 - INFO [QuorumPeer:/0.0.0.0:2181:Follower@165] - shutdown called java.lang.Exception: shutdown Follower at org.apache.zookeeper.server.quorum.Follower.shutdown(Follower.java:165) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:649) 2011-10-24 11:54:45,785 - INFO [QuorumPeer:/0.0.0.0:2181 :FinalRequestProcessor@378] - shutdown of request processor complete Leader Logs 2011-10-24 11:53:13,626 - INFO [WorkerReceiver Thread:FastLeaderElection@496] - Notification: 3 (n.leader), -1 (n.zxid), 2 (n.round), LOOKING (n.state), 3 (n.sid), LEADING (my state) 2011-10-24 11:53:23,109 - INFO [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@249] - Follower sid: 3 : info : org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer@783c342b 2011-10-24 11:53:23,109 - INFO [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@319] - Sending snapshot last zxid of peer is 0x zxid of leader is 0x1de0dsent zxid of db as 0x1de0d 2011-10-24 11:54:29,713 - ERROR [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@461] - Unexpected exception causing shutdown while sock still open java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(Unknown Source) at java.io.BufferedInputStream.fill(Unknown Source) at java.io.BufferedInputStream.read(Unknown Source) at java.io.DataInputStream.readInt(Unknown Source) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:84) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:108) at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:357) 2011-10-24 11:54:29,714 - WARN [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@474] - *** GOODBYE /10.3.4.156:41450 2011-10-24 11:54:49,634 - INFO [NIOServerCxn.Factory: 0.0.0.0/0.0.0.0:2181:NIOServerCnxn$Factory@251] - Accepted socket connection from /10.2.16.131:41048
[jira] [Commented] (ZOOKEEPER-1239) add logging/stats to identify fsync stalls
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134319#comment-13134319 ] Patrick Hunt commented on ZOOKEEPER-1239: - Todd pointed me at this commit in hbase which does similar (sync time tracking) --- HBase does a log message when any sync() call takes longer than a second or so. commit 96621d010f9a924e2af338a10b584b7f07caf17d Author: Michael Stack st...@apache.org Date: Mon May 11 17:32:24 2009 + HBASE-1404 minor edit of regionserver logging messages add logging/stats to identify fsync stalls -- Key: ZOOKEEPER-1239 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1239 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt We don't have any logging to identify fsync stalls. It's a somewhat common occurrence (after gc/swap issues) when trying to diagnose pipeline stalls - where outstanding requests start piling up and operational latency increases. We should have some sort of logging around this. e.g. if the fsync time exceeds some limit then log a warning, something like that. It would also be useful to publish stat information related to this. min/avg/max latency for fsync. This should also be exposed through JMX. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Zookeeper sync timeout issues
Jon, Whats the size of the snapshot? And what are the configs for: 1) initLimit 2) syncLimit 3) tickTime ? thanks mahadev On Mon, Oct 24, 2011 at 11:09 AM, Jon King jk...@photobucket.com wrote: Hi All, It looks like one of our ZK quorum servers cannot sync with the leader anymore. The leader logs show Read timed out errors and the follower is showing a Broken pipe at the same time. Follower logs 2011-10-24 11:53:23,110 - INFO [QuorumPeer:/0.0.0.0:2181:FileSnap@82] - Reading snapshot /var/zookeeper/version-2/snapshot.1de07 2011-10-24 11:53:32,792 - WARN [QuorumPeer:/0.0.0.0:2181:QuorumPeer@497] - Unable to load database java.io.IOException: Transaction log: /var/zookeeper/version-2/log.1de08 has invalid magic number 0 != 1514884167 at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:510) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:527) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:493) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:475) at org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:454) at org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:325) at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:126) at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:222) at org.apache.zookeeper.server.quorum.QuorumPeer.getLastLoggedZxid(QuorumPeer.java:493) at org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:69) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:645) 2011-10-24 11:53:32,793 - INFO [QuorumPeer:/0.0.0.0:2181:Learner@294] - Getting a snapshot from leader 2011-10-24 11:54:19,716 - INFO [QuorumPeer:/0.0.0.0:2181:Learner@325] - Setting leader epoch 1 2011-10-24 11:54:19,717 - INFO [QuorumPeer:/0.0.0.0:2181 :FileTxnSnapLog@208] - Snapshotting: 1de0d 2011-10-24 11:54:44,412 - WARN [QuorumPeer:/0.0.0.0:2181:Follower@82] - Exception when following the leader java.net.SocketException: Broken pipe at java.net.SocketOutputStream.socketWrite0(Native Method) at java.net.SocketOutputStream.socketWrite(Unknown Source) at java.net.SocketOutputStream.write(Unknown Source) at java.io.BufferedOutputStream.flushBuffer(Unknown Source) at java.io.BufferedOutputStream.flush(Unknown Source) at org.apache.zookeeper.server.quorum.Learner.writePacket(Learner.java:134) at org.apache.zookeeper.server.quorum.Learner.ping(Learner.java:418) at org.apache.zookeeper.server.quorum.Follower.processPacket(Follower.java:108) at org.apache.zookeeper.server.quorum.Follower.followLeader(Follower.java:79) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:645) 2011-10-24 11:54:45,784 - INFO [QuorumPeer:/0.0.0.0:2181:Follower@165] - shutdown called java.lang.Exception: shutdown Follower at org.apache.zookeeper.server.quorum.Follower.shutdown(Follower.java:165) at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:649) 2011-10-24 11:54:45,785 - INFO [QuorumPeer:/0.0.0.0:2181 :FinalRequestProcessor@378] - shutdown of request processor complete Leader Logs 2011-10-24 11:53:13,626 - INFO [WorkerReceiver Thread:FastLeaderElection@496] - Notification: 3 (n.leader), -1 (n.zxid), 2 (n.round), LOOKING (n.state), 3 (n.sid), LEADING (my state) 2011-10-24 11:53:23,109 - INFO [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@249] - Follower sid: 3 : info : org.apache.zookeeper.server.quorum.QuorumPeer$QuorumServer@783c342b 2011-10-24 11:53:23,109 - INFO [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@319] - Sending snapshot last zxid of peer is 0x zxid of leader is 0x1de0dsent zxid of db as 0x1de0d 2011-10-24 11:54:29,713 - ERROR [LearnerHandler-/10.3.4.156:41450 :LearnerHandler@461] - Unexpected exception causing shutdown while sock still open java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(Unknown Source) at java.io.BufferedInputStream.fill(Unknown Source) at java.io.BufferedInputStream.read(Unknown Source) at java.io.DataInputStream.readInt(Unknown Source) at org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63) at org.apache.zookeeper.server.quorum.QuorumPacket.deserialize(QuorumPacket.java:84) at org.apache.jute.BinaryInputArchive.readRecord(BinaryInputArchive.java:108) at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:357)
[jira] [Updated] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier updated ZOOKEEPER-1243: Attachment: ZOOKEEPER-1243-4.patch New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134493#comment-13134493 ] Camille Fournier commented on ZOOKEEPER-1243: - Added html docs, removed println in test. Can someone please review this? We've been suffering heavily from ZOOKEEPER-1197 and I would really appreciate it if we could get this in to 3.4 New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Success: ZOOKEEPER-1243 PreCommit Build #651
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 141873 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12500544/ZOOKEEPER-1243-4.patch [exec] against trunk revision 1188039. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] yFssYMojP4 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 22 minutes 10 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1243 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134535#comment-13134535 ] Hadoop QA commented on ZOOKEEPER-1243: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500544/ZOOKEEPER-1243-4.patch against trunk revision 1188039. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/651//console This message is automatically generated. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134558#comment-13134558 ] Camille Fournier commented on ZOOKEEPER-1243: - Oh, you are right, I thought it was weird we didn't have this. Why we chose to put the srvr command in the same command thread as stat with the only differentiator be a guarding if statement... Ok I will close this, thanks. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Assignee: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Camille Fournier resolved ZOOKEEPER-1243. - Resolution: Won't Fix Release Note: Srvr command duplicates. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Assignee: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134561#comment-13134561 ] Patrick Hunt commented on ZOOKEEPER-1243: - Thomas also expressed issues with the way the 4lw code is structured. It's certainly ripe for refactoring (hint hint ;-) ) esp given the duplication btw NIO/Netty and taking into account the problems you've been finding. Regards. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Assignee: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1243) New 4lw for short simple monitoring ldck
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134564#comment-13134564 ] Camille Fournier commented on ZOOKEEPER-1243: - Indeed... put it on the todo list. New 4lw for short simple monitoring ldck Key: ZOOKEEPER-1243 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1243 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3, 3.4.0 Reporter: Camille Fournier Assignee: Camille Fournier Priority: Blocker Fix For: 3.3.4, 3.4.0 Attachments: ZOOKEEPER-1243-2, ZOOKEEPER-1243-4.patch, ZOOKEEPER-1243.patch The existing monitoring fails so often due to https://issues.apache.org/jira/browse/ZOOKEEPER-1197 that we need a workaround. This introduces a short 4lw called ldck that just runs ServerStats.toString to get information about the sever's leadership status. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1177) Enabling a large number of watches for a large number of clients
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134579#comment-13134579 ] Vikas Mehta commented on ZOOKEEPER-1177: Hi Patrick, Sorry for the late response. Let me know if you were looking for something different than what I answered: 1) in your testing what is the impact of triggering a large number of watches on overall operation latency? [vikas] Without this change, with large number of watches, zookeeper would run out of memory storing all the watches. With this change, it is now bound by the network bandwidth. One difference between the current and the old implementation is that now triggerWatch() loops through all the watchers to find that watches it needs to trigger compared to using the reverse map in the previous version to prevent this scan for slight benefit in cases when number of watches per path is much smaller compared to number of watchers. 2) Say I delete a znode in your example, that will trigger 10k notifications to be sent (one to each session) - what is the impact on the latency of this request (the delete), both with and without this patch? [vikas] Without the patch, as mentioned above we are not able to run zookeeper with so many watches. If we do not have too many watchers (or overall watches), impact with this change would be linear scan of the watchers to identify the watches that need to be triggered for the update/delete node operation. 3) Subsequent to the investigations you've been doing, should we have concerns on overall service availability due to large numbers of watches being triggered concurrently? [vikas] We are thinking of implementing some throttling on the server (and later may be client-side as well) to prevent deterioration in the Zookeeper performance or availability. Thanks, Vikas Enabling a large number of watches for a large number of clients Key: ZOOKEEPER-1177 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1177 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.3.3 Reporter: Vishal Kathuria Assignee: Vishal Kathuria Fix For: 3.5.0 Attachments: ZooKeeper.patch In my ZooKeeper, I see watch manager consuming several GB of memory and I dug a bit deeper. In the scenario I am testing, I have 10K clients connected to an observer. There are about 20K znodes in ZooKeeper, each is about 1K - so about 20M data in total. Each client fetches and puts watches on all the znodes. That is 200 million watches. It seems a single watch takes about 100 bytes. I am currently at 14528037 watches and according to the yourkit profiler, WatchManager has 1.2 G already. This is not going to work as it might end up needing 20G of RAM just for the watches. So we need a more compact way of storing watches. Here are the possible solutions. 1. Use a bitmap instead of the current hashmap. In this approach, each znode would get a unique id when its gets created. For every session, we can keep track of a bitmap that indicates the set of znodes this session is watching. A bitmap, assuming a 100K znodes, would be 12K. For 10K sessions, we can keep track of watches using 120M instead of 20G. 2. This second idea is based on the observation that clients watch znodes in sets (for example all znodes under a folder). Multiple clients watch the same set and the total number of sets is a couple of orders of magnitude smaller than the total number of znodes. In my scenario, there are about 100 sets. So instead of keeping track of watches at the znode level, keep track of it at the set level. It may mean that get may also need to be implemented at the set level. With this, we can save the watches in 100M. Are there any other suggestions of solutions? Thanks -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ZOOKEEPER-1242) Repeat add watcher, memory leak
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Futian reopened ZOOKEEPER-1242: Assignee: Mahadev konar Please help me finished this issue. thank you. Repeat add watcher, memory leak - Key: ZOOKEEPER-1242 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1242 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Redhat linux Reporter: Peng Futian Assignee: Mahadev konar Labels: patch Fix For: 3.3.4 Attachments: ZOOKEEPER-1242.patch Original Estimate: 1h Remaining Estimate: 1h When I repeat add watcher , there are a memory leak. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (ZOOKEEPER-1240) Compiler issue with redhat linux
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peng Futian reopened ZOOKEEPER-1240: Assignee: Mahadev konar @Mahadev konar, I am sorry,Can you help me finished this issue?Thank you very much. I just want you know there are a issue. Compiler issue with redhat linux Key: ZOOKEEPER-1240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1240 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Linux phy 2.6.18-53.el5 #1 SMP Wed Oct 10 16:34:19 EDT 2007 x86_64 x86_64 x86_64 GNU/Linux gcc version 4.1.2 20070626 (Red Hat 4.1.2-14) Reporter: Peng Futian Assignee: Mahadev konar Priority: Minor Labels: patch Fix For: 3.3.4 Attachments: ZOOKEEPER-1240.patch Original Estimate: 1h Remaining Estimate: 1h When I compile zookeeper c client in my project, there are some error: ../../../include/zookeeper/recordio.h:70: error：expected unqualified-id before '__extension__' ../../../include/zookeeper/recordio.h:70: error：expected `)' before '__extension__' ../../.. /include/zookeeper/recordio.h:70: error：expected unqualified-id before ')' token -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1242) Repeat add watcher, memory leak
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1242: Fix Version/s: 3.4.1 3.5.0 Repeat add watcher, memory leak - Key: ZOOKEEPER-1242 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1242 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Redhat linux Reporter: Peng Futian Assignee: Mahadev konar Labels: patch Fix For: 3.3.4, 3.5.0, 3.4.1 Attachments: ZOOKEEPER-1242.patch Original Estimate: 1h Remaining Estimate: 1h When I repeat add watcher , there are a memory leak. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ZOOKEEPER-1242) Repeat add watcher, memory leak
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-1242: --- Assignee: Peng Futian (was: Mahadev konar) Repeat add watcher, memory leak - Key: ZOOKEEPER-1242 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1242 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Redhat linux Reporter: Peng Futian Assignee: Peng Futian Labels: patch Fix For: 3.3.4, 3.5.0, 3.4.1 Attachments: ZOOKEEPER-1242.patch Original Estimate: 1h Remaining Estimate: 1h When I repeat add watcher , there are a memory leak. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1240) Compiler issue with redhat linux
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-1240: Fix Version/s: 3.4.1 3.5.0 Assignee: Peng Futian (was: Mahadev konar) Compiler issue with redhat linux Key: ZOOKEEPER-1240 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1240 Project: ZooKeeper Issue Type: Bug Components: c client Affects Versions: 3.3.3 Environment: Linux phy 2.6.18-53.el5 #1 SMP Wed Oct 10 16:34:19 EDT 2007 x86_64 x86_64 x86_64 GNU/Linux gcc version 4.1.2 20070626 (Red Hat 4.1.2-14) Reporter: Peng Futian Assignee: Peng Futian Priority: Minor Labels: patch Fix For: 3.3.4, 3.5.0, 3.4.1 Attachments: ZOOKEEPER-1240.patch Original Estimate: 1h Remaining Estimate: 1h When I compile zookeeper c client in my project, there are some error: ../../../include/zookeeper/recordio.h:70: error：expected unqualified-id before '__extension__' ../../../include/zookeeper/recordio.h:70: error：expected `)' before '__extension__' ../../.. /include/zookeeper/recordio.h:70: error：expected unqualified-id before ')' token -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly updated BOOKKEEPER-89: - Attachment: BOOKKEEPER-89.diff Implemented changes as in description. RecoveryCallback is still public as BookKeeperTools needs it. BookKeeperTools has been moved in to the client package. Bookkeeper API changes for initial Bookkeeper release - Key: BOOKKEEPER-89 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Assignee: Ivan Kelly Attachments: BOOKKEEPER-89.diff Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (BOOKKEEPER-89) Bookkeeper API changes for initial Bookkeeper release
[ https://issues.apache.org/jira/browse/BOOKKEEPER-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13134043#comment-13134043 ] jirapos...@reviews.apache.org commented on BOOKKEEPER-89: - --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2543/ --- Review request for bookkeeper. Summary --- Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public This addresses bug BOOKKEEPER-89. https://issues.apache.org/jira/browse/BOOKKEEPER-89 Diffs - bookkeeper-server/src/main/java/org/apache/bookkeeper/client/AsyncCallback.java 6421460 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 6af43ae bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperTools.java PRE-CREATION bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DigestManager.java d4af3fa bookkeeper-server/src/main/java/org/apache/bookkeeper/client/DistributionSchedule.java 78aaa15 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java 959df73 bookkeeper-server/src/main/java/org/apache/bookkeeper/client/MacDigestManager.java 1131652 bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/BookKeeperTools.java 94e444c bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookKeeperTestClient.java dfc63d7 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 224c796 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieFailureTest.java 82483f3 bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieReadWriteTest.java 56331ef bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieRecoveryTest.java f933ba1 pom.xml 2392db5 Diff: https://reviews.apache.org/r/2543/diff Testing --- Thanks, Ivan Bookkeeper API changes for initial Bookkeeper release - Key: BOOKKEEPER-89 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-89 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Assignee: Ivan Kelly Fix For: 4.0.0 Attachments: BOOKKEEPER-89.diff Changes are as follows. BookKeeper#createLedger, parameter is named passwd, Key used in LedgerHandle api BookKeeper#getBookieClient shouldn't be public BookKeeper#createComplete shouldn't be public BookKeeper#openComplete shouldn't be public BookKeeper#deleteComplete shouldn't be public BookKeeper#halt could be changed to close(), should throw a BKException LedgerHandle#getLedgerKey passwd is used in BookKeeper, should possibly be private LedgerHandle#getLedgerMetadata shouldn't be public LedgerHandle#getDigestManager shouldn't be public LedgerHandle#getDistributionSchedule shouldn't be public LedgerHandle#writeLedgerConfig shouldn't be public LedgerHandle#addEntry should return void, errors should go in an Exception LedgerHandle#readComplete should not be public LedgerHandle#addComplete should not be public LedgerHandle#readLastConfirmedCompelte should not be public LedgerHandle#closeComplete should not be public ASyncCallback#RecoverCallback shouldn't be public -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (BOOKKEEPER-90) Hedwig API changes for initial Bookkeeper release
Hedwig API changes for initial Bookkeeper release - Key: BOOKKEEPER-90 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-90 Project: Bookkeeper Issue Type: Improvement Reporter: Ivan Kelly Fix For: 4.0.0 HedwigClient#getSslFactory shouldn't be public HedwigClient#getConsumeCallback shouldn't be public HedwigClient#doConnect shouldn't be public HedwigClient#getHostFromChannel shouldn't be public HedwigClient#getResponseHandlerFromChannel shouldn't be public HedwigClient#getHostForTopic shouldn't be public HedwigClient#clearAllTopicsForHost shouldn't be public HedwigClient#getClientTimer shoulnd't be public HedwigClient#stop should throw some sort of Exception in the case of errors HedwigPublisher#publish shouldn't use protobuf ByteString, as it requires the user to import protobufs HedwigPublisher#getChannelForHost shouldn't be public HedwigSubscriber#HedwigSubscriber shouldn't be public HedwigSubscriber#doConsume shouldn't be public HedwigSubscriber#hasSubscription probably shouldn't be public HedwigSubscriber#getSubscriptionList shoulnd't exist HedwigSubscriber#getChannelForTopic shouldn't be public HedwigSubscriber#setChannelforTopic shouldn't be public HedwigSubscriber#removeChannelForTopic shound't be public MessageHandler#consume should be called 'deliver' The hedwig client is under a netty package. There's nothing netty specific about the api, so it should be in the org.apache.hedwig.client package. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
