[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847257#comment-13847257
]
Daniel Peon commented on ZOOKEEPER-1814:
Thanks for the comments. I'm generating a new patch file with the suggested
changes. The only issue is:
{quote}
Nit:
- * should not be taken into account in the comparison
- * (electionEpoch and zxid).
+ * should not be taken into account in the comparison
+ * (electionEpoch and zxid).
those lines didn't really change, you just introduced a trailing space.
{quote}
When I download the trunk version of the code, those spaces at the end of those
2 lines appear. Thus, Review Board complains if I do not delete them when I
created the diff file.
Reduction of waiting time during Fast Leader Election
-
Key: ZOOKEEPER-1814
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814
Project: ZooKeeper
Issue Type: Bug
Components: leaderElection
Affects Versions: 3.4.5, 3.5.0
Reporter: Daniel Peon
Assignee: Daniel Peon
Fix For: 3.5.0
Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch,
ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch
Original Estimate: 24h
Remaining Estimate: 24h
FastLeader election takes long time because of the exponential backoff.
Currently the time is 60 seconds.
It would be interesting to give the possibility to configure this parameter,
like for example for a Server shutdown.
Otherwise, it sometimes takes so long and it has been detected a test failure
when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.
This test case waits until 30 seconds and this is smaller than the 60 seconds
where the leader election can be waiting for at the moment of shutting down.
Considering the failure during the test case, this issue was considered a
possible bug.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
ZooKeeper-trunk-solaris - Build # 759 - Still Failing
See https://builds.apache.org/job/ZooKeeper-trunk-solaris/759/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 210563 lines...] [junit] 2013-12-13 09:02:02,482 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2013-12-13 09:02:02,483 [myid:] - INFO [main:ZooKeeperServer@428] - shutting down [junit] 2013-12-13 09:02:02,483 [myid:] - INFO [main:SessionTrackerImpl@183] - Shutting down [junit] 2013-12-13 09:02:02,483 [myid:] - INFO [main:PrepRequestProcessor@972] - Shutting down [junit] 2013-12-13 09:02:02,483 [myid:] - INFO [main:SyncRequestProcessor@190] - Shutting down [junit] 2013-12-13 09:02:02,483 [myid:] - INFO [ProcessThread(sid:0 cport:-1)::PrepRequestProcessor@156] - PrepRequestProcessor exited loop! [junit] 2013-12-13 09:02:02,484 [myid:] - INFO [SyncThread:0:SyncRequestProcessor@168] - SyncRequestProcessor exited! [junit] 2013-12-13 09:02:02,484 [myid:] - INFO [main:FinalRequestProcessor@442] - shutdown of request processor complete [junit] 2013-12-13 09:02:02,484 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-13 09:02:02,485 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[] [junit] 2013-12-13 09:02:02,486 [myid:] - INFO [main:ClientBase@414] - STARTING server [junit] 2013-12-13 09:02:02,486 [myid:] - INFO [main:ZooKeeperServer@149] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1251313054196300032.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1251313054196300032.junit.dir/version-2 [junit] 2013-12-13 09:02:02,487 [myid:] - INFO [main:NIOServerCnxnFactory@670] - Configuring NIO connection handler with 10s sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 kB direct buffers. [junit] 2013-12-13 09:02:02,487 [myid:] - INFO [main:NIOServerCnxnFactory@683] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-13 09:02:02,488 [myid:] - INFO [main:FileSnap@83] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1251313054196300032.junit.dir/version-2/snapshot.b [junit] 2013-12-13 09:02:02,490 [myid:] - INFO [main:FileTxnSnapLog@297] - Snapshotting: 0xb to /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test1251313054196300032.junit.dir/version-2/snapshot.b [junit] 2013-12-13 09:02:02,492 [myid:] - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-13 09:02:02,492 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory$AcceptThread@296] - Accepted socket connection from /127.0.0.1:37622 [junit] 2013-12-13 09:02:02,493 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@835] - Processing stat command from /127.0.0.1:37622 [junit] 2013-12-13 09:02:02,493 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn$StatCommand@684] - Stat command output [junit] 2013-12-13 09:02:02,494 [myid:] - INFO [NIOWorkerThread-1:NIOServerCnxn@1006] - Closed socket connection for client /127.0.0.1:37622 (no session established for client) [junit] 2013-12-13 09:02:02,494 [myid:] - INFO [main:JMXEnv@133] - ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2013-12-13 09:02:02,495 [myid:] - INFO [main:JMXEnv@105] - expect:InMemoryDataTree [junit] 2013-12-13 09:02:02,495 [myid:] - INFO [main:JMXEnv@108] - found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] 2013-12-13 09:02:02,496 [myid:] - INFO [main:JMXEnv@105] - expect:StandaloneServer_port [junit] 2013-12-13 09:02:02,496 [myid:] - INFO [main:JMXEnv@108] - found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-13 09:02:02,496 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@57] - FINISHED TEST METHOD testQuota [junit] 2013-12-13 09:02:02,496 [myid:] - INFO [main:ClientBase@451] - tearDown starting [junit] 2013-12-13 09:02:02,568 [myid:] - INFO [main:ZooKeeper@777] - Session: 0x142eb30f03d closed [junit] 2013-12-13 09:02:02,568 [myid:] - INFO [main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down [junit] 2013-12-13 09:02:02,569 [myid:] - INFO [main:ClientBase@421] - STOPPING server [junit] 2013-12-13 09:02:02,569 [myid:] - INFO
Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 13, 2013, 9:11 a.m.) Review request for zookeeper, German Blanco and fpj. Changes --- Suggested changes applied. Bugs: ZOOKEEPER-1814 https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Repository: zookeeper Description --- See Zookeeper-1814. Diffs (updated) - ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1550368 ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1550368 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/15753/diff/ Testing --- New test case checking that the parameter maxNotificationInterval can be configurable. The test case overwrites the receiveConnection method in QuorumCnxManager class in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to retry increasing exponentially the notifications interval. This interval is measured and the test case stops when 3 consecutive measures are equal. The test case will be OK if the measure is the configured in the cfg file. File Attachments ZOOKEEPER-1814.patch https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch Thanks, Daniel Peon
Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 13, 2013, 9:13 a.m.) Review request for zookeeper, German Blanco and fpj. Changes --- New spaces introduced by text editor have been corrected. Bugs: ZOOKEEPER-1814 https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Repository: zookeeper Description --- See Zookeeper-1814. Diffs (updated) - ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1550368 ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1550368 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/15753/diff/ Testing --- New test case checking that the parameter maxNotificationInterval can be configurable. The test case overwrites the receiveConnection method in QuorumCnxManager class in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to retry increasing exponentially the notifications interval. This interval is measured and the test case stops when 3 consecutive measures are equal. The test case will be OK if the measure is the configured in the cfg file. File Attachments ZOOKEEPER-1814.patch https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch Thanks, Daniel Peon
[jira] [Updated] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Peon updated ZOOKEEPER-1814: --- Attachment: ZOOKEEPER-1814.patch Few changes applied from recent comments: -Docummentation has been corrected. -The way to get the value from properties has been simplified. -Corrections in test case: LOG and assert statements. Reduction of waiting time during Fast Leader Election - Key: ZOOKEEPER-1814 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Project: ZooKeeper Issue Type: Bug Components: leaderElection Affects Versions: 3.4.5, 3.5.0 Reporter: Daniel Peon Assignee: Daniel Peon Fix For: 3.5.0 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch Original Estimate: 24h Remaining Estimate: 24h FastLeader election takes long time because of the exponential backoff. Currently the time is 60 seconds. It would be interesting to give the possibility to configure this parameter, like for example for a Server shutdown. Otherwise, it sometimes takes so long and it has been detected a test failure when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest. This test case waits until 30 seconds and this is smaller than the 60 seconds where the leader election can be waiting for at the moment of shutting down. Considering the failure during the test case, this issue was considered a possible bug. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1814) Reduction of waiting time during Fast Leader Election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847344#comment-13847344 ] Hadoop QA commented on ZOOKEEPER-1814: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618561/ZOOKEEPER-1814.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1833//console This message is automatically generated. Reduction of waiting time during Fast Leader Election - Key: ZOOKEEPER-1814 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Project: ZooKeeper Issue Type: Bug Components: leaderElection Affects Versions: 3.4.5, 3.5.0 Reporter: Daniel Peon Assignee: Daniel Peon Fix For: 3.5.0 Attachments: ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch, ZOOKEEPER-1814.patch Original Estimate: 24h Remaining Estimate: 24h FastLeader election takes long time because of the exponential backoff. Currently the time is 60 seconds. It would be interesting to give the possibility to configure this parameter, like for example for a Server shutdown. Otherwise, it sometimes takes so long and it has been detected a test failure when executing: org.apache.zookeeper.server.quorum.QuorumPeerMainTest. This test case waits until 30 seconds and this is smaller than the 60 seconds where the leader election can be waiting for at the moment of shutting down. Considering the failure during the test case, this issue was considered a possible bug. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1837: - Attachment: ZOOKEEPER-1837.patch This change is to: - only verify that a session is added if the session is not closed - after a shutdown, if the server is still there, then wait a bit and try to check again. Fix JMXEnv checks (potential race conditions) - Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper Issue Type: Sub-task Components: tests Affects Versions: 3.4.5, 3.5.0 Environment: Windows 8 Reporter: Germán Blanco Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1837.patch The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing: [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) [ junit.framework.AssertionFailedError: expected [0x142e5f027b50001] expected:1 but was:0 at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149) at org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
Rakesh R created ZOOKEEPER-1838:
---
Summary: ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated ZOOKEEPER-1838:
Attachment: ZOOKEEPER-1838.patch
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847441#comment-13847441
]
Flavio Junqueira commented on ZOOKEEPER-1838:
-
Do you know why bumping the netty version up solves the problem?
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847447#comment-13847447 ] Flavio Junqueira commented on ZOOKEEPER-1837: - The ensureAll changes seems fine to me, but the ensureOnly is a bit odd. It is always tricky to insert sleep delays because we never know how much time is enough. What if we instead check in a loop and exit the loop once there is not leftover? If we can't get the check to succeed after a number of attempts, then we fail. Fix JMXEnv checks (potential race conditions) - Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper Issue Type: Sub-task Components: tests Affects Versions: 3.4.5, 3.5.0 Environment: Windows 8 Reporter: Germán Blanco Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1837.patch The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing: [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) [ junit.framework.AssertionFailedError: expected [0x142e5f027b50001] expected:1 but was:0 at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149) at org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1833) fix windows build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847449#comment-13847449
]
Flavio Junqueira commented on ZOOKEEPER-1833:
-
It works for me, but I wonder if this change is problematic to anyone:
{noformat}
sysproperty key=java.net.preferIPv4Stack value=true /
{noformat}
fix windows build
-
Key: ZOOKEEPER-1833
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1833
Project: ZooKeeper
Issue Type: Bug
Affects Versions: 3.4.5
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Priority: Blocker
Fix For: 3.4.6
Attachments: ZOOKEEPER-1833.patch
A bunch of 3.4 tests are failing on windows.
{noformat}
[junit] 2013-12-06 08:40:59,692 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testEarlyLeaderAbandonment
[junit] 2013-12-06 08:41:10,472 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHighestZxidJoinLate
[junit] 2013-12-06 08:45:31,085 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testUpdatingEpoch
[junit] 2013-12-06 08:55:34,630 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testObserversHammer
[junit] 2013-12-06 08:55:59,889 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncExistsFailure_NoNode
[junit] 2013-12-06 08:56:00,571 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetACL
[junit] 2013-12-06 08:56:02,626 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenEmpty
[junit] 2013-12-06 08:56:03,491 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenSingle
[junit] 2013-12-06 08:56:11,276 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenTwo
[junit] 2013-12-06 08:56:13,878 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildrenFailure_NoNode
[junit] 2013-12-06 08:56:16,294 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Empty
[junit] 2013-12-06 08:56:18,622 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Single
[junit] 2013-12-06 08:56:21,224 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Two
[junit] 2013-12-06 08:56:23,738 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetChildren2Failure_NoNode
[junit] 2013-12-06 08:56:26,058 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetData
[junit] 2013-12-06 08:56:28,482 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testAsyncGetDataFailure_NoNode
[junit] 2013-12-06 08:57:35,527 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureCreate
[junit] 2013-12-06 08:57:38,645 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureSet
[junit] 2013-12-06 08:57:41,261 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testStartupFailureSnapshot
[junit] 2013-12-06 08:59:22,222 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientWithWatcherObj
[junit] 2013-12-06 09:00:05,592 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientCleanup
[junit] 2013-12-06 09:01:24,113 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testBindByAddress
[junit] 2013-12-06 09:02:14,123 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientwithoutWatcherObj
[junit] 2013-12-06 09:05:56,461 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testZeroWeightQuorum
[junit] 2013-12-06 09:08:18,747 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testResyncByDiffAfterFollowerCrashes
[junit] 2013-12-06 09:09:42,271 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testFourLetterWords
[junit] 2013-12-06 09:14:03,770 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testLE
[junit] 2013-12-06 09:46:30,002 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHierarchicalQuorum
[junit] 2013-12-06 09:50:26,912 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testHammerBasic
[junit] 2013-12-06 09:51:07,604 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testQuotaWithQuorum
[junit] 2013-12-06 09:52:41,515 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testNull
[junit] 2013-12-06 09:53:22,648 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testDeleteWithChildren
[junit] 2013-12-06 09:56:49,061 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testClientwithoutWatcherObj
[junit] 2013-12-06 09:58:27,705 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testGetView
[junit] 2013-12-06 09:59:07,856 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testViewContains
[junit] 2013-12-06 10:01:31,418 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testSessionMoved
[junit] 2013-12-06 10:04:50,542 [myid:] - INFO [main:ZKTestCase$1@65] -
FAILED testMultiToFollower
[junit] 2013-12-06 10:07:55,361
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847451#comment-13847451
]
Flavio Junqueira commented on ZOOKEEPER-1838:
-
Could you send a message to the dev list and ask if anyone has a problem with
us bumping up the netty version? This message will go to the same list, but I
don't think folks pay close attention to what's going on in random jiras.
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847452#comment-13847452 ] Hadoop QA commented on ZOOKEEPER-1837: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618583/ZOOKEEPER-1837.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//console This message is automatically generated. Fix JMXEnv checks (potential race conditions) - Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper Issue Type: Sub-task Components: tests Affects Versions: 3.4.5, 3.5.0 Environment: Windows 8 Reporter: Germán Blanco Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1837.patch The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing: [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at
Success: ZOOKEEPER-1837 PreCommit Build #1834
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 298500 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12618583/ZOOKEEPER-1837.patch [exec] against trunk revision 1550213. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1834//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 55e0885cecf09b38eb490153d2025ee2f6881ff1 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 33 minutes 28 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1837 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
Bumping Netty version upgrade - from 3.2.2 to 3.2.9
Hi folks, Recently when analyzing the build failures in windows machine, I had hit few issues with netty external resource management. I've raised jira to discuss more on this, please have a look at the JIRA ZOOKEEPER-1838. The issue has been resolved in my environment after upgrading the netty version to 3.2.9. Presently zookeeper is using very old version of netty-3.2.2. In netty there are many potential issues resolved after this release. IMHO, it would be good to discuss about upgrading the netty to the latest version. I'd like to know any different thoughts or concerns(compatibility) in upgrading the netty version? Thanks, Rakesh
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847475#comment-13847475
]
Rakesh R commented on ZOOKEEPER-1838:
-
Thanks Flavio for the comment. I've sent mail to dev@zookeeper.apache.org list,
this will really help to know more about the compatibilty issues and feedback.
Also I have attached the threaddump to the jira.
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch,
zk_threaddump-netty-external-resource.txt
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Created] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
Rakesh R created ZOOKEEPER-1839: --- Summary: Deadlock in NettyServerCnxn Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Attachments: zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1839: Attachment: zk_threaddump-cnxn-closure.txt Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Attachments: zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847519#comment-13847519 ] Rakesh R commented on ZOOKEEPER-1839: - From threaddump, it seems the deadlock is occuring in following way: NettyServerCnxn - sendCloseSession When closing it got an exception and invokes CnxnChannelHandler#exceptionCaught, this will acquire 'factory.cnxns' and call NioWorker#close. Now closure will try to acquire 'channels lock' NioWorker - writeFromTaskLoop Here NioWorker has acquired 'channels lock' and fireExceptionCaught. Now, exceptionCaught will be calling NettyServerCnxn#close() and try to acquire lock on 'factory.cnxns' Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Attachments: zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rakesh R updated ZOOKEEPER-1839: Attachment: ZOOKEEPER-1839.patch Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Attachments: ZOOKEEPER-1839.patch, zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847527#comment-13847527 ] Rakesh R commented on ZOOKEEPER-1839: - I have attached an initial draft patch. In the proposed fix, it will close the connection channel outside the 'ServerConnectionFactory.cnxns' lock. Please help me to review the changes. Thanks Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Attachments: ZOOKEEPER-1839.patch, zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847569#comment-13847569
]
Flavio Junqueira commented on ZOOKEEPER-1838:
-
I had the impression we had talked about upgrading the netty version at some
point, so I searched and found it: ZOOKEEPER-1715
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch,
zk_threaddump-netty-external-resource.txt
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
Re: Review Request 15753: Reduction of waiting time during Fast Leader Election (ZOOKEEPER-1814)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30347 --- ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58077 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58078 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58075 nit: close implies flush, see http://docs.oracle.com/javase/7/docs/api/java/io/OutputStreamWriter.html#close%28%29 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58076 ditto, flush is not needed. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58079 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58080 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58081 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58082 nit: extra newline ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58087 nit: i don't think the LOG statement needs a comment, you can probably drop it and it would still be clear. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58084 nit: make these lines 80 cols. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58085 nit: make these lines 80 cols. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java https://reviews.apache.org/r/15753/#comment58083 nit: you can use String.format instead of concatenating strings. [1] http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29 - Raul Gutierrez Segales On Dec. 13, 2013, 9:13 a.m., Daniel Peon wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/ --- (Updated Dec. 13, 2013, 9:13 a.m.) Review request for zookeeper, German Blanco and fpj. Bugs: ZOOKEEPER-1814 https://issues.apache.org/jira/browse/ZOOKEEPER-1814 Repository: zookeeper Description --- See Zookeeper-1814. Diffs - ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1550368 ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1550368 ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/15753/diff/ Testing --- New test case checking that the parameter maxNotificationInterval can be configurable. The test case overwrites the receiveConnection method in QuorumCnxManager class in order to avoid any answer to Fast Leader Election. Thus, FLE is forced to retry increasing exponentially the notifications interval. This interval is measured and the test case stops when 3 consecutive measures are equal. The test case will be OK if the measure is the configured in the cfg file. File Attachments ZOOKEEPER-1814.patch https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch Thanks, Daniel Peon
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847803#comment-13847803
]
Michi Mutsuzaki commented on ZOOKEEPER-1838:
Ok, so let's backport ZOOKEEPER-1715 to 3.4. I'll close this ticket and reopen
ZOOKEEPER-1715.
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch,
zk_threaddump-netty-external-resource.txt
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Resolved] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki resolved ZOOKEEPER-1838.
Resolution: Duplicate
This is a dup of ZOOKEEPER-1715.
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch,
zk_threaddump-netty-external-resource.txt
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1715) Upgrade netty version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki updated ZOOKEEPER-1715: --- Fix Version/s: 3.4.6 Upgrade netty version - Key: ZOOKEEPER-1715 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1715 Project: ZooKeeper Issue Type: Improvement Affects Versions: 3.4.5 Environment: zookeeper 3.4.5 uses netty 3.2.2, which was released in August 2010. The latest version of netty is 3.6.6 released May 2013. Zookeeper should consider upgrading. Reporter: Sean Bridges Assignee: Sean Bridges Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch, ZOOKEEPER-1715.patch, zookeeper-1715.patch Upgrade netty version -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Reopened] (ZOOKEEPER-1715) Upgrade netty version
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michi Mutsuzaki reopened ZOOKEEPER-1715: I'd like to backport this to 3.4.6. https://issues.apache.org/jira/browse/ZOOKEEPER-1838 Upgrade netty version - Key: ZOOKEEPER-1715 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1715 Project: ZooKeeper Issue Type: Improvement Affects Versions: 3.4.5 Environment: zookeeper 3.4.5 uses netty 3.2.2, which was released in August 2010. The latest version of netty is 3.6.6 released May 2013. Zookeeper should consider upgrading. Reporter: Sean Bridges Assignee: Sean Bridges Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch, ZOOKEEPER-1715.patch, zookeeper-1715.patch Upgrade netty version -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: Bumping Netty version upgrade - from 3.2.2 to 3.2.9
Flavio pointed out that this has been fixed in trunk in ZOOKEEPER-1715. I'll backport the patch to 3.4 after verifying that it fixes the timeout issue. Thank you for root-causing the problem, Rakesh! On Fri, Dec 13, 2013 at 5:06 AM, Rakesh R rake...@huawei.com wrote: Hi folks, Recently when analyzing the build failures in windows machine, I had hit few issues with netty external resource management. I've raised jira to discuss more on this, please have a look at the JIRA ZOOKEEPER-1838. The issue has been resolved in my environment after upgrading the netty version to 3.2.9. Presently zookeeper is using very old version of netty-3.2.2. In netty there are many potential issues resolved after this release. IMHO, it would be good to discuss about upgrading the netty to the latest version. I'd like to know any different thoughts or concerns(compatibility) in upgrading the netty version? Thanks, Rakesh
Re: Review Request 12983: ZOOKEEPER-1691
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12983/ --- (Updated Dec. 14, 2013, midnight) Review request for zookeeper and Alexander Shraer. Changes --- All tests work without FLE hack. Repository: zookeeper Description --- Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server. Diffs - http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1516310 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1516310 Diff: https://reviews.apache.org/r/12983/diff/ Testing --- File Attachments (updated) Update_12_13 https://reviews.apache.org/media/uploaded/files/2013/12/13/2f39656b-dac3-4ef5-83cf-0425d913bcda__ZOOKEEPER-1691.patch Thanks, Helen Hastings
Re: Review Request 12983: ZOOKEEPER-1691
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12983/ --- (Updated Dec. 14, 2013, 12:02 a.m.) Review request for zookeeper and Alexander Shraer. Changes --- All tests work without FLE hack. Repository: zookeeper Description --- Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server. Diffs (updated) - http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java PRE-CREATION http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java 1545749 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1545749 Diff: https://reviews.apache.org/r/12983/diff/ Testing --- Thanks, Helen Hastings
[jira] [Commented] (ZOOKEEPER-1691) Add a flag to disable standalone mode
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848089#comment-13848089 ] Helen Hastings commented on ZOOKEEPER-1691: --- Uploaded patch to reviewboard. Alex, in my debugging over the summer I also came across similar stack traces that suggested a server was trying to connect to itself. Add a flag to disable standalone mode - Key: ZOOKEEPER-1691 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1691 Project: ZooKeeper Issue Type: Improvement Components: quorum Reporter: Michi Mutsuzaki Assignee: Helen Hastings Fix For: 3.5.0 Attachments: ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, ZOOKEEPER-1691.patch, test scenario.txt Currently you cannot use dynamic reconfiguration to bootstrap zookeeper cluster because the server goes into standalone mode when there is only one server in the cluster. --Michi -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: Bumping Netty version upgrade - from 3.2.2 to 3.2.9
I tried the patch from ZOOKEEPER-1715. The timeout issue is fixed, but I get some failures. The patch works fine on ubuntu 12.04. Should I check this in anyways and fixed these failures separately? https://issues.apache.org/jira/browse/ZOOKEEPER-1715 On Fri, Dec 13, 2013 at 1:29 PM, Michi Mutsuzaki mi...@cs.stanford.edu wrote: Flavio pointed out that this has been fixed in trunk in ZOOKEEPER-1715. I'll backport the patch to 3.4 after verifying that it fixes the timeout issue. Thank you for root-causing the problem, Rakesh! On Fri, Dec 13, 2013 at 5:06 AM, Rakesh R rake...@huawei.com wrote: Hi folks, Recently when analyzing the build failures in windows machine, I had hit few issues with netty external resource management. I've raised jira to discuss more on this, please have a look at the JIRA ZOOKEEPER-1838. The issue has been resolved in my environment after upgrading the netty version to 3.2.9. Presently zookeeper is using very old version of netty-3.2.2. In netty there are many potential issues resolved after this release. IMHO, it would be good to discuss about upgrading the netty to the latest version. I'd like to know any different thoughts or concerns(compatibility) in upgrading the netty version? Thanks, Rakesh
[jira] [Commented] (ZOOKEEPER-1838) ZooKeeper shutdown hangs indefinitely at NioServerSocketChannelFactory.releaseExternalResources
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848161#comment-13848161
]
Rakesh R commented on ZOOKEEPER-1838:
-
Thanks Flavio, Michi for looking at this and nice to hear about the netty
upgradation plans in 3.4 branch.
ZooKeeper shutdown hangs indefinitely at
NioServerSocketChannelFactory.releaseExternalResources
---
Key: ZOOKEEPER-1838
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1838
Project: ZooKeeper
Issue Type: Sub-task
Components: server
Reporter: Rakesh R
Assignee: Rakesh R
Fix For: 3.4.6
Attachments: ZOOKEEPER-1838.patch,
zk_threaddump-netty-external-resource.txt
Zookeeper shutdown hangs when releasing external resources. This has been
observed when executing NioNettySuiteTest.
{code}
main prio=6 tid=0x01498400 nid=0x2328 waiting on condition
[0x0158e000..0x0158fe28]
java.lang.Thread.State: TIMED_WAITING (parking)
at sun.misc.Unsafe.park(Native Method)
- parking to wait for 0x22f58918 (a
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
at
java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:198)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:1963)
at
java.util.concurrent.ThreadPoolExecutor.awaitTermination(ThreadPoolExecutor.java:1244)
at
org.jboss.netty.util.internal.ExecutorUtil.terminate(ExecutorUtil.java:87)
at
org.jboss.netty.channel.socket.nio.NioServerSocketChannelFactory.releaseExternalResources(NioServerSocketChannelFactory.java:146)
at
org.jboss.netty.bootstrap.Bootstrap.releaseExternalResources(Bootstrap.java:324)
at
org.apache.zookeeper.server.NettyServerCnxnFactory.shutdown(NettyServerCnxnFactory.java:345)
at
org.apache.zookeeper.test.ClientBase.shutdownServerInstance(ClientBase.java:355)
at org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:422)
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848232#comment-13848232 ] Rakesh R commented on ZOOKEEPER-1839: - Marked the issue for 3.4 release, please feel free to change the version if anyone has different opinion. Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Fix For: 3.4.6 Attachments: ZOOKEEPER-1839.patch, zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (ZOOKEEPER-1839) Deadlock in NettyServerCnxn
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848242#comment-13848242 ] Hadoop QA commented on ZOOKEEPER-1839: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618597/ZOOKEEPER-1839.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//console This message is automatically generated. Deadlock in NettyServerCnxn --- Key: ZOOKEEPER-1839 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.4.5 Reporter: Rakesh R Assignee: Rakesh R Priority: Critical Fix For: 3.4.6 Attachments: ZOOKEEPER-1839.patch, zk_threaddump-cnxn-closure.txt Deadlock found during NettyServerCnxn closure. Please see the attached threaddump. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Failed: ZOOKEEPER-1839 PreCommit Build #1835
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1839 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 303729 lines...] [exec] [exec] -1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12618597/ZOOKEEPER-1839.patch [exec] against trunk revision 1550213. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1835//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] d01b6ca12d00f63d73ba7d38e9698726c0f7fe1b logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1623: exec returned: 1 Total time: 32 minutes 35 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Recording test results Description set: ZOOKEEPER-1839 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
Re: [jira] [Commented] (ZOOKEEPER-1715) Upgrade netty version
The JMXEnv.ensureOnly assertions are covered in ZOOKEEPER-1837.
Still investigating the issue though.
On Sat, Dec 14, 2013 at 12:47 AM, Michi Mutsuzaki (JIRA) j...@apache.orgwrote:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848070#comment-13848070]
Michi Mutsuzaki commented on ZOOKEEPER-1715:
The timeout issue is fixed with this patch, but I got some failures:
{noformat}
Testcase: testDisconnectedAddAuth took 121.339 sec
FAILED
waiting for server being up
junit.framework.AssertionFailedError: waiting for server being up
at
org.apache.zookeeper.test.ACLTest.testDisconnectedAddAuth(ACLTest.java:63)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
Testcase: testSessionTimeout took 134.221 sec
FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
at org.apache.zookeeper.test.SessionTest.setUp(SessionTest.java:80)
at
org.apache.zookeeper.test.SessionTest.testSessionTimeout(SessionTest.java:293)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
Testcase: testWatcherAutoResetWithLocal took 123.392 sec
FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
at
org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
at
org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
at
org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:341)
at
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithLocal(WatcherTest.java:242)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
FAILED
expected:0 but was:2
junit.framework.AssertionFailedError: expected:0 but was:2
at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
at
org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
at
org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
Testcase: testWatcherAutoResetDisabledWithGlobal took 3.16 sec
FAILED
expected:0 but was:2
junit.framework.AssertionFailedError: expected:0 but was:2
at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
at
org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
at
org.apache.zookeeper.test.WatcherTest.testWatcherAutoReset(WatcherTest.java:278)
at
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetWithGlobal(WatcherTest.java:233)
at
org.apache.zookeeper.test.WatcherTest.testWatcherAutoResetDisabledWithGlobal(WatcherTest.java:249)
at
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
FAILED
expected:0 but was:2
junit.framework.AssertionFailedError: expected:0 but was:2
at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
at
org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
at
org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
Testcase: testWatcherAutoResetDisabledWithLocal took 120.027 sec
FAILED
waiting for server up
junit.framework.AssertionFailedError: waiting for server up
at
org.apache.zookeeper.test.ClientBase.createNewServerInstance(ClientBase.java:338)
at
org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:415)
at org.apache.zookeeper.test.ClientBase.setUp(ClientBase.java:408)
at org.apache.zookeeper.test.WatcherTest.setUp(WatcherTest.java:74)
FAILED
expected:0 but was:2
junit.framework.AssertionFailedError: expected:0 but was:2
at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138)
at
org.apache.zookeeper.test.ClientBase.stopServer(ClientBase.java:425)
at
org.apache.zookeeper.test.ClientBase.tearDown(ClientBase.java:455)
{noformat}
Upgrade netty version
-
Key: ZOOKEEPER-1715
URL:
https://issues.apache.org/jira/browse/ZOOKEEPER-1715
Project: ZooKeeper
Issue Type: Improvement
Affects Versions: 3.4.5
Environment: zookeeper 3.4.5 uses netty 3.2.2, which was
released in August 2010. The latest version of netty is 3.6.6 released May
2013. Zookeeper should consider upgrading.
Reporter: Sean Bridges
Assignee: Sean Bridges
Fix For: 3.4.6, 3.5.0
Attachments: ZOOKEEPER-1715-2.patch, ZOOKEEPER-1715-v3.patch,
ZOOKEEPER-1715.patch, zookeeper-1715.patch
Upgrade netty version
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Germán Blanco updated ZOOKEEPER-1837: - Attachment: ZOOKEEPER-1837.patch With a loop as suggested. Fix JMXEnv checks (potential race conditions) - Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper Issue Type: Sub-task Components: tests Affects Versions: 3.4.5, 3.5.0 Environment: Windows 8 Reporter: Germán Blanco Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing: [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) [ junit.framework.AssertionFailedError: expected [0x142e5f027b50001] expected:1 but was:0 at org.apache.zookeeper.test.JMXEnv.ensureAll(JMXEnv.java:115) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:197) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:171) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:156) at org.apache.zookeeper.test.ClientBase.createClient(ClientBase.java:149) at org.apache.zookeeper.ZooKeeperTest.testDeleteRecursive(ZooKeeperTest.java:45) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52) -- This message was sent by Atlassian JIRA (v6.1.4#6159)
ZooKeeper_branch33_solaris - Build # 736 - Still Failing
See https://builds.apache.org/job/ZooKeeper_branch33_solaris/736/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 101447 lines...] [junit] 2013-12-14 07:05:10,457 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2 [junit] 2013-12-14 07:05:10,458 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-14 07:05:10,460 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2/snapshot.0 [junit] 2013-12-14 07:05:10,464 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-12-14 07:05:10,466 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-14 07:05:10,467 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:47443 [junit] 2013-12-14 07:05:10,468 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:47443 [junit] 2013-12-14 07:05:10,469 - INFO [Thread-4:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-12-14 07:05:10,469 - INFO [Thread-4:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:47443 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-14 07:05:10,472 - INFO [main:ClientBase@408] - STOPPING server [junit] 2013-12-14 07:05:10,480 - INFO [ProcessThread:-1:PrepRequestProcessor@128] - PrepRequestProcessor exited loop! [junit] 2013-12-14 07:05:10,480 - INFO [SyncThread:0:SyncRequestProcessor@151] - SyncRequestProcessor exited! [junit] 2013-12-14 07:05:10,480 - INFO [main:FinalRequestProcessor@370] - shutdown of request processor complete [junit] 2013-12-14 07:05:10,482 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] ensureOnly:[] [junit] 2013-12-14 07:05:10,483 - INFO [main:ClientBase@401] - STARTING server [junit] 2013-12-14 07:05:10,484 - INFO [main:ZooKeeperServer@154] - Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 6 datadir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2 snapdir /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2 [junit] 2013-12-14 07:05:10,485 - INFO [main:NIOServerCnxn$Factory@143] - binding to port 0.0.0.0/0.0.0.0:11221 [junit] 2013-12-14 07:05:10,486 - INFO [main:FileSnap@82] - Reading snapshot /zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch33_solaris/trunk/build/test/tmp/test7974098318120559592.junit.dir/version-2/snapshot.b [junit] 2013-12-14 07:05:10,489 - INFO [main:FileTxnSnapLog@256] - Snapshotting: b [junit] 2013-12-14 07:05:10,491 - INFO [main:FourLetterWordMain@43] - connecting to 127.0.0.1 11221 [junit] 2013-12-14 07:05:10,492 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn$Factory@251] - Accepted socket connection from /127.0.0.1:47445 [junit] 2013-12-14 07:05:10,492 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@1237] - Processing stat command from /127.0.0.1:47445 [junit] 2013-12-14 07:05:10,493 - INFO [Thread-5:NIOServerCnxn$StatCommand@1153] - Stat command output [junit] 2013-12-14 07:05:10,494 - INFO [Thread-5:NIOServerCnxn@1435] - Closed socket connection for client /127.0.0.1:47445 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2013-12-14 07:05:10,496 - INFO
Success: ZOOKEEPER-1837 PreCommit Build #1836
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 306234 lines...] [exec] BUILD SUCCESSFUL [exec] Total time: 0 seconds [exec] [exec] [exec] [exec] [exec] +1 overall. Here are the results of testing the latest attachment [exec] http://issues.apache.org/jira/secure/attachment/12618758/ZOOKEEPER-1837.patch [exec] against trunk revision 1550213. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 894c38a76c7fb533328e8eb19b9e90996af0c33b logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD SUCCESSFUL Total time: 32 minutes 51 seconds Archiving artifacts Recording test results Description set: ZOOKEEPER-1837 Email was triggered for: Success Sending email for trigger: Success ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-1837) Fix JMXEnv checks (potential race conditions)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848268#comment-13848268 ] Hadoop QA commented on ZOOKEEPER-1837: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12618758/ZOOKEEPER-1837.patch against trunk revision 1550213. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1836//console This message is automatically generated. Fix JMXEnv checks (potential race conditions) - Key: ZOOKEEPER-1837 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1837 Project: ZooKeeper Issue Type: Sub-task Components: tests Affects Versions: 3.4.5, 3.5.0 Environment: Windows 8 Reporter: Germán Blanco Assignee: Germán Blanco Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1837.patch, ZOOKEEPER-1837.patch The following failures in ZooKeeper-3.4-WinVS2008_java and ZooKeeper-trunk-WinVS2008_java require fixing: [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] junit.framework.AssertionFailedError: expected:0 but was:1 [junit] at junit.framework.Assert.fail(Assert.java:47) [junit] at junit.framework.Assert.failNotEquals(Assert.java:283) [junit] at junit.framework.Assert.assertEquals(Assert.java:64) [junit] at junit.framework.Assert.assertEquals(Assert.java:195) [junit] at junit.framework.Assert.assertEquals(Assert.java:201) [junit] at org.apache.zookeeper.test.JMXEnv.ensureOnly(JMXEnv.java:138) [junit] at org.apache.zookeeper.test.ClientBase.startServer(ClientBase.java:417) [junit] at org.apache.zookeeper.test.ZooKeeperQuotaTest.testQuota(ZooKeeperQuotaTest.java:80) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) [junit] at java.lang.reflect.Method.invoke(Method.java:597) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at
