[jira] [Updated] (ZOOKEEPER-2210) clock_gettime is not available in os x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michi Mutsuzaki updated ZOOKEEPER-2210:
---
Attachment: ZOOKEEPER-2210.patch
clock_gettime is not available in os x
--
Key: ZOOKEEPER-2210
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210
Project: ZooKeeper
Issue Type: Bug
Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2210.patch
{noformat}
src/zookeeper.c:286:9: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
ret = clock_gettime(CLOCK_MONOTONIC, ts);
^
src/zookeeper.c:286:23: error: use of undeclared identifier 'CLOCK_MONOTONIC'
ret = clock_gettime(CLOCK_MONOTONIC, ts);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] zookeeper pull request: Branch 3.5
GitHub user leoricxu opened a pull request: https://github.com/apache/zookeeper/pull/35 Branch 3.5 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1684112 13f79535-47bb-0310-9956-ffa450edef68 You can merge this pull request into a Git repository by running: $ git pull https://github.com/leoricxu/zookeeper branch-3.5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 47d8b90c64f7634ab6bb69ef239538943f328fc6 Author: Patrick D. Hunt ph...@apache.org Date: 2014-08-01T21:42:37Z Branching for 3.5 releases git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1615238 13f79535-47bb-0310-9956-ffa450edef68 commit ecd7b9f8854b5c60dff6beacae606d2c609c2641 Author: Patrick D. Hunt ph...@apache.org Date: 2014-08-01T22:08:24Z Preparing for release 3.5.0 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1615247 13f79535-47bb-0310-9956-ffa450edef68 commit ee81cff7c752f5a0891ddd7d89ec4f64ee70db67 Author: Patrick D. Hunt ph...@apache.org Date: 2014-08-01T22:14:48Z Preparing for release 3.5.0 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1615252 13f79535-47bb-0310-9956-ffa450edef68 commit a7c2baa5d67b075fbe83c024d0f620a3a732216a Author: Patrick D. Hunt ph...@apache.org Date: 2014-08-06T04:29:48Z Setup for 3.5.1 development activities git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1616091 13f79535-47bb-0310-9956-ffa450edef68 commit efe070308e8fbdb9fdad915ba1b687f27dbea122 Author: Alexander Shraer shra...@apache.org Date: 2014-08-14T06:14:38Z ZOOKEEPER-1994. Auto-backup configuration files; config version becomes part of filename (Hongchao Deng via shralex) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1617887 13f79535-47bb-0310-9956-ffa450edef68 commit 1775bbc78eb6f8402ed458b4a250316838e57adf Author: Alexander Shraer shra...@apache.org Date: 2014-08-14T07:33:58Z ZOOKEEPER-2008. Missing leader election port in system test. (Kfir Lev-Ari via Alex Shraer). git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1617893 13f79535-47bb-0310-9956-ffa450edef68 commit 8ad913d543ca78e385f3e6da9932e155f5c532bb Author: Alexander Shraer shra...@apache.org Date: 2014-08-14T12:34:23Z ZOOKEEPER-2008-Fix. Correcting small issue in committed 2008 patch. git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1617922 13f79535-47bb-0310-9956-ffa450edef68 commit 67967b24fae8dbc93f40fc8b7501dc7c4cc78e37 Author: Alexander Shraer shra...@apache.org Date: 2014-08-19T20:52:11Z ZOOKEEPER-2006. Standalone mode won't take client port from dynamic config. (Hongchao Deng via Alex Shraer) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1618978 13f79535-47bb-0310-9956-ffa450edef68 commit 6277c4bbc28eedfbb39ef84cc89a32d79c6cfad1 Author: Alexander Shraer shra...@apache.org Date: 2014-08-20T17:19:38Z ZOOKEEPER-2013. Typos in programmer guide. (Tim Chambers via Alex Shraer) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1619167 13f79535-47bb-0310-9956-ffa450edef68 commit ca42b061cf50115baf6e7ae9581d222e4e56990e Author: Michi Mutsuzaki mic...@apache.org Date: 2014-08-21T01:36:47Z ZOOKEEPER-2000. Fix ReconfigTest.testPortChange (Alexander Shraer via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1619278 13f79535-47bb-0310-9956-ffa450edef68 commit 19d0c875cfaaf7032a5fb3cbc5525f25df0a76a4 Author: Michi Mutsuzaki mic...@apache.org Date: 2014-08-24T05:44:25Z ZOOKEEPER-2017 New tests for reconfig failure cases (Alexander Shraer and Hongchao Deng via michim) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1620112 13f79535-47bb-0310-9956-ffa450edef68 commit 1b56170b439647f39eb25eb85fc6b7035aef082a Author: Alexander Shraer shra...@apache.org Date: 2014-08-29T14:36:46Z ZOOKEEPER-1660 Documentation for Dynamic Reconfiguration (Reed Wanderman-Milne via shralex) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1621314 13f79535-47bb-0310-9956-ffa450edef68 commit 3a067661c9f73681743d284dc59b3f0ecf311b24 Author: Alexander Shraer shra...@apache.org Date: 2014-09-10T07:03:01Z ZOOKEEPER-2032. Cleaning up resources in ReconfigBackupTest (Hongchao Deng via shralex) git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1623918 13f79535-47bb-0310-9956-ffa450edef68 commit 5aac8accd10701064ea2d3d9a633dff62902e166
Failed: ZOOKEEPER-2210 PreCommit Build #2768
Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2210 Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 372331 lines...] [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 core tests. The patch passed core unit tests. [exec] [exec] +1 contrib tests. The patch passed contrib unit tests. [exec] [exec] Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//testReport/ [exec] Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html [exec] Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//console [exec] [exec] This message is automatically generated. [exec] [exec] [exec] == [exec] == [exec] Adding comment to Jira. [exec] == [exec] == [exec] [exec] [exec] Comment added. [exec] 9b5ef5cbbcac033aa31841a786583388ce464c42 logged out [exec] [exec] [exec] == [exec] == [exec] Finished build. [exec] == [exec] == [exec] [exec] BUILD FAILED /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/build.xml:1782: exec returned: 1 Total time: 13 minutes 19 seconds Build step 'Execute shell' marked build as failure Archiving artifacts Sending artifact delta relative to PreCommit-ZOOKEEPER-Build #2752 Archived 24 artifacts Archive block size is 32768 Received 5 blocks and 33970799 bytes Compression is 0.5% Took 10 sec Recording test results Description set: ZOOKEEPER-2210 Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## All tests passed
[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584473#comment-14584473
]
Hadoop QA commented on ZOOKEEPER-2210:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12739402/ZOOKEEPER-2210.patch
against trunk revision 1685200.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2768//console
This message is automatically generated.
clock_gettime is not available in os x
--
Key: ZOOKEEPER-2210
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210
Project: ZooKeeper
Issue Type: Bug
Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2210.patch
{noformat}
src/zookeeper.c:286:9: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
ret = clock_gettime(CLOCK_MONOTONIC, ts);
^
src/zookeeper.c:286:23: error: use of undeclared identifier 'CLOCK_MONOTONIC'
ret = clock_gettime(CLOCK_MONOTONIC, ts);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Why 1K filesize limit in ZKfuse
Ping .. On Wed, Jun 10, 2015 at 5:01 PM, Bharat Singh bharatsingh.mnni...@gmail.com wrote: Hi, I am trying to use zookeeper with zkfuse interface. I have some doubts regarding max file size supported. Zookeeper max file size: (1MB) http://zookeeper.apache.org/doc/r3.1.2/api/org/apache/zookeeper/ZooKeeper.htm The maximum allowable size of the data array is 1 MB ZKfuse max file size: (1KB) http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc *static* *const* *unsigned* maxDataFileSize http://code.metager.de/source/s?refs=maxDataFileSizeproject=apache = MAX_DATA_SIZE http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc#MAX_DATA_SIZE ; Why ZKfuse reduces the size further since we already have a cap at zookeeper. Is there any explanation behind this check in ZKfuse. Please point me to appropriate forum if this is not the one. Suggestions are appreciated. Thanks, Bharat
ZooKeeper_branch35_jdk7 - Build # 326 - Failure
See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/326/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 368113 lines...] [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2015-06-13 10:00:25,426 [myid:] - WARN [LearnerHandler-/127.0.0.1:50869:LearnerHandler@619] - *** GOODBYE /127.0.0.1:50869 [junit] 2015-06-13 10:00:25,426 [myid:] - INFO [ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - ConnnectionExpirerThread interrupted [junit] 2015-06-13 10:00:25,426 [myid:] - WARN [LearnerHandler-/127.0.0.1:50869:LearnerHandler@903] - Ignoring unexpected exception [junit] java.lang.InterruptedException [junit] at java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireInterruptibly(AbstractQueuedSynchronizer.java:1219) [junit] at java.util.concurrent.locks.ReentrantLock.lockInterruptibly(ReentrantLock.java:340) [junit] at java.util.concurrent.LinkedBlockingQueue.put(LinkedBlockingQueue.java:338) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.shutdown(LearnerHandler.java:901) [junit] at org.apache.zookeeper.server.quorum.LearnerHandler.run(LearnerHandler.java:622) [junit] 2015-06-13 10:00:25,427 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-06-13 10:00:25,427 [myid:] - INFO [NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:27518:NIOServerCnxnFactory$AcceptThread@219] - accept thread exitted run method [junit] 2015-06-13 10:00:25,428 [myid:] - INFO [NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] - selector thread exitted run method [junit] 2015-06-13 10:00:25,428 [myid:] - INFO [/127.0.0.1:27520:QuorumCnxManager$Listener@659] - Leaving listener [junit] 2015-06-13 10:00:25,428 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3,name2=Leader] [junit] 2015-06-13 10:00:25,429 [myid:] - INFO [main:QuorumUtil@254] - Shutting down leader election QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled) [junit] 2015-06-13 10:00:25,429 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):QuorumPeer@1039] - Unexpected exception [junit] java.lang.InterruptedException [junit] at java.lang.Object.wait(Native Method) [junit] at org.apache.zookeeper.server.quorum.Leader.lead(Leader.java:559) [junit] at org.apache.zookeeper.server.quorum.QuorumPeer.run(QuorumPeer.java:1036) [junit] 2015-06-13 10:00:25,429 [myid:] - INFO [main:QuorumUtil@259] - Waiting for QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled) to exit thread [junit] 2015-06-13 10:00:25,429 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):Leader@613] - Shutting down [junit] 2015-06-13 10:00:25,430 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):QuorumPeer@1070] - PeerState set to LOOKING [junit] 2015-06-13 10:00:25,430 [myid:] - WARN [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):QuorumPeer@1052] - QuorumPeer main thread exited [junit] 2015-06-13 10:00:25,430 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3] [junit] 2015-06-13 10:00:25,430 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.3] [junit] 2015-06-13 10:00:25,430 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.1] [junit] 2015-06-13 10:00:25,430 [myid:] - INFO [QuorumPeer[myid=3](plain=/0:0:0:0:0:0:0:0:27518)(secure=disabled):MBeanRegistry@119] - Unregister MBean [org.apache.ZooKeeperService:name0=ReplicatedServer_id3,name1=replica.2] [junit] 2015-06-13 10:00:25,431 [myid:] - INFO [main:FourLetterWordMain@63] - connecting to 127.0.0.1 27512 [junit] 2015-06-13 10:00:25,431 [myid:] - INFO [main:QuorumUtil@243] - 127.0.0.1:27512 is no longer accepting client connections [junit] 2015-06-13 10:00:25,431 [myid:] - INFO [main:FourLetterWordMain@63] - connecting to 127.0.0.1 27515 [junit] 2015-06-13 10:00:25,432 [myid:] - INFO
ZooKeeper-trunk - Build # 2725 - Failure
See https://builds.apache.org/job/ZooKeeper-trunk/2725/ ### ## LAST 60 LINES OF THE CONSOLE ### [...truncated 377568 lines...] [junit] at org.apache.zookeeper.test.ReconfigTest.testNormalOperation(ReconfigTest.java:150) [junit] at org.apache.zookeeper.test.ReconfigTest.testPortChange(ReconfigTest.java:598) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) [junit] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) [junit] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) [junit] at java.lang.reflect.Method.invoke(Method.java:601) [junit] at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44) [junit] at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) [junit] at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41) [junit] at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) [junit] at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55) [junit] at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31) [junit] at org.junit.rules.TestWatchman$1.evaluate(TestWatchman.java:52) [junit] at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:69) [junit] at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:48) [junit] at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) [junit] at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) [junit] at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) [junit] at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) [junit] at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) [junit] at org.junit.runners.ParentRunner.run(ParentRunner.java:292) [junit] at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:39) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:532) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:1179) [junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1030) [junit] 2015-06-13 10:37:47,215 [myid:] - INFO [main:ZKTestCase$1@60] - FINISHED testPortChange [junit] Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 116.363 sec, Thread: 8, Class: org.apache.zookeeper.test.ReconfigTest [junit] 2015-06-13 10:37:47,378 [myid:] - INFO [main-SendThread(127.0.0.1:30206):ClientCnxn$SendThread@1138] - Opening socket connection to server 127.0.0.1/127.0.0.1:30206. Will not attempt to authenticate using SASL (unknown error) [junit] 2015-06-13 10:37:47,379 [myid:] - WARN [main-SendThread(127.0.0.1:30206):ClientCnxn$SendThread@1257] - Session 0x2011b22f2e0 for server 127.0.0.1/127.0.0.1:30206, unexpected error, closing socket connection and attempting reconnect [junit] java.net.ConnectException: Connection refused [junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method) [junit] at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:701) [junit] at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:355) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1236) [junit] Test org.apache.zookeeper.test.ReconfigTest FAILED BUILD FAILED /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1489: The following error occurred while executing this line: /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1374: Tests failed! Total time: 5 minutes 48 seconds Build step 'Execute shell' marked build as failure [FINDBUGS] Skipping publisher since build result is FAILURE [WARNINGS] Skipping publisher since build result is FAILURE Archiving artifacts Sending artifact delta relative to ZooKeeper-trunk #2724 Archived 3 artifacts Archive block size is 32768 Received 1 blocks and 18231012 bytes Compression is 0.2% Took 7 sec Recording fingerprints Updating ZOOKEEPER-2214 Updating ZOOKEEPER-706 Recording test results Publishing Javadoc Email was triggered for: Failure Sending email for trigger: Failure ### ## FAILED TESTS (if any) ## 1 tests failed. REGRESSION:
[jira] [Commented] (ZOOKEEPER-706) large numbers of watches can cause session re-establishment to fail
[ https://issues.apache.org/jira/browse/ZOOKEEPER-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584554#comment-14584554 ] Hudson commented on ZOOKEEPER-706: -- FAILURE: Integrated in ZooKeeper-trunk #2725 (See [https://builds.apache.org/job/ZooKeeper-trunk/2725/]) ZOOKEEPER-706: Large numbers of watches can cause session re-establishment to fail (Chris Thunes via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1685200) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/DisconnectedWatcherTest.java large numbers of watches can cause session re-establishment to fail --- Key: ZOOKEEPER-706 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-706 Project: ZooKeeper Issue Type: Bug Components: c client, java client Affects Versions: 3.1.2, 3.2.2, 3.3.0 Reporter: Patrick Hunt Priority: Critical Fix For: 3.4.7, 3.5.2, 3.6.0 Attachments: ZOOKEEPER-706-branch-34.patch, ZOOKEEPER-706-branch-34.patch, ZOOKEEPER-706.patch, ZOOKEEPER-706.patch, ZOOKEEPER-706.patch If a client sets a large number of watches the set watches operation during session re-establishment can fail. for example: WARN [NIOServerCxn.Factory:22801:NIOServerCnxn@417] - Exception causing close of session 0xe727001201a4ee7c due to java.io.IOException: Len error 4348380 in this case the client was a web monitoring app and had set both data and child watches on 32k znodes. there are two issues I see here we need to fix: 1) handle this case properly (split up the set watches into multiple calls I guess...) 2) the session should have expired after the timeout. however we seem to consider any message from the client as re-setting the expiration on the server side. Probably we should only consider messages from the client that are sent during an established session, otherwise we can see this situation where the session is not established however the session is not expired either. Perhaps we should create another JIRA for this particular issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2214) Findbugs warning: LearnerHandler.packetToString Dead store to local variable
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584553#comment-14584553 ] Hudson commented on ZOOKEEPER-2214: --- FAILURE: Integrated in ZooKeeper-trunk #2725 (See [https://builds.apache.org/job/ZooKeeper-trunk/2725/]) ZOOKEEPER-2214: Findbugs warning: LearnerHandler.packetToString Dead store to local variable (Hongchao Deng via rgs) (rgs: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1685167) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java Findbugs warning: LearnerHandler.packetToString Dead store to local variable Key: ZOOKEEPER-2214 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2214 Project: ZooKeeper Issue Type: Improvement Reporter: Hongchao Deng Assignee: Hongchao Deng Priority: Minor Fix For: 3.5.1, 3.6.0 Attachments: ZOOKEEPER-2214.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Why 1K filesize limit in ZKfuse
I'm not sure that there is a reason for it honestly. Possibly no one ever used it for anything larger than 1k. I don't know the package well myself but assuming it's storing this data inside of zk nodes having large files in there will fill up the zk memory fast and may be risky, but other than that I can't think of a reason. Best C On Jun 13, 2015 1:52 PM, Bharat Singh bharatsingh.mnni...@gmail.com wrote: Ping .. On Wed, Jun 10, 2015 at 5:01 PM, Bharat Singh bharatsingh.mnni...@gmail.com wrote: Hi, I am trying to use zookeeper with zkfuse interface. I have some doubts regarding max file size supported. Zookeeper max file size: (1MB) http://zookeeper.apache.org/doc/r3.1.2/api/org/apache/zookeeper/ZooKeeper.htm The maximum allowable size of the data array is 1 MB ZKfuse max file size: (1KB) http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc *static* *const* *unsigned* maxDataFileSize http://code.metager.de/source/s?refs=maxDataFileSizeproject=apache = MAX_DATA_SIZE http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc#MAX_DATA_SIZE ; Why ZKfuse reduces the size further since we already have a cap at zookeeper. Is there any explanation behind this check in ZKfuse. Please point me to appropriate forum if this is not the one. Suggestions are appreciated. Thanks, Bharat
[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584781#comment-14584781
]
Chris Nauroth commented on ZOOKEEPER-2210:
--
Hi [~michim]. Thank you for the patch. I built locally on a Mac and tested
{{cli_mt}} manually. It looks good overall. I have a few comments on edge
case error handling.
# It looks like {{host_get_clock_service}} can return an error code. If there
is an error returned, then it might not be valid to use the {{cclock}} in the
next call to {{clock_get_time}}.
# Similarly, if there is an error, then I don't know if it's still OK to call
{{mach_port_deallocate}}.
clock_gettime is not available in os x
--
Key: ZOOKEEPER-2210
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210
Project: ZooKeeper
Issue Type: Bug
Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2210.patch
{noformat}
src/zookeeper.c:286:9: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
ret = clock_gettime(CLOCK_MONOTONIC, ts);
^
src/zookeeper.c:286:23: error: use of undeclared identifier 'CLOCK_MONOTONIC'
ret = clock_gettime(CLOCK_MONOTONIC, ts);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Why 1K filesize limit in ZKfuse
Thanks Camille. Yes I agree, It will take more memory and replication time might increase. I am more interested if there are any possible issues if we operate with the max allowed file size or as we increase the no of files. Do we have any benchmarking/performance stats for this ? How do i decide a safe limit. On Sat, Jun 13, 2015 at 11:02 AM, Camille Fournier cami...@apache.org wrote: I'm not sure that there is a reason for it honestly. Possibly no one ever used it for anything larger than 1k. I don't know the package well myself but assuming it's storing this data inside of zk nodes having large files in there will fill up the zk memory fast and may be risky, but other than that I can't think of a reason. Best C On Jun 13, 2015 1:52 PM, Bharat Singh bharatsingh.mnni...@gmail.com wrote: Ping .. On Wed, Jun 10, 2015 at 5:01 PM, Bharat Singh bharatsingh.mnni...@gmail.com wrote: Hi, I am trying to use zookeeper with zkfuse interface. I have some doubts regarding max file size supported. Zookeeper max file size: (1MB) http://zookeeper.apache.org/doc/r3.1.2/api/org/apache/zookeeper/ZooKeeper.htm The maximum allowable size of the data array is 1 MB ZKfuse max file size: (1KB) http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc *static* *const* *unsigned* maxDataFileSize http://code.metager.de/source/s?refs=maxDataFileSizeproject=apache = MAX_DATA_SIZE http://code.metager.de/source/xref/apache/zookeeper/src/contrib/zkfuse/src/zkfuse.cc#MAX_DATA_SIZE ; Why ZKfuse reduces the size further since we already have a cap at zookeeper. Is there any explanation behind this check in ZKfuse. Please point me to appropriate forum if this is not the one. Suggestions are appreciated. Thanks, Bharat
[jira] [Commented] (ZOOKEEPER-2210) clock_gettime is not available in os x
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584832#comment-14584832
]
Raul Gutierrez Segales commented on ZOOKEEPER-2210:
---
+1, it does not break Linux :-) I'll merge it after Chris' comments are
addressed. Thanks [~michim]!
clock_gettime is not available in os x
--
Key: ZOOKEEPER-2210
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2210
Project: ZooKeeper
Issue Type: Bug
Components: c client
Reporter: Michi Mutsuzaki
Assignee: Michi Mutsuzaki
Fix For: 3.5.1, 3.6.0
Attachments: ZOOKEEPER-2210.patch
{noformat}
src/zookeeper.c:286:9: warning: implicit declaration of function
'clock_gettime' is invalid in C99 [-Wimplicit-function-declaration]
ret = clock_gettime(CLOCK_MONOTONIC, ts);
^
src/zookeeper.c:286:23: error: use of undeclared identifier 'CLOCK_MONOTONIC'
ret = clock_gettime(CLOCK_MONOTONIC, ts);
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
