[jira] [Commented] (ZOOKEEPER-2526) Add config flag to prohibit connections from clients that don't do Sasl auth

[Irfan Hamid (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436309#comment-15436309
 ] 

Irfan Hamid commented on ZOOKEEPER-2526:


Both jiras are similar to my proposal, in fact ZOOKEEPER-1634 has a patch that 
is very similarly coded to what I have.

However, ZOOKEEPER-1634 doesn't differentiate between Sasl auth at the start of 
a session and ZooKeeper#addAuthInfo() which can be added at any time during the 
session I believe.

ZOOKEEPER-2462 proposes additionally to allow an option to remove all ACLs on 
znodes, which isn't necessary or useful in my opinion.

My proposal is a bit more tightly scoped: stipulate that all clients _must_ 
auth via Sasl before any other op, or they will be disconnected from session.

A follow up jira would be to provide in the zoo.cfg a list of auth IDs that are 
allowed to log in to ZK if allowAnonLogin == false. In fact I initially coded 
my patch with those options but then decided to break things up into smaller 
chunks, being a newbie.

> Add config flag to prohibit connections from clients that don't do Sasl auth
> 
>
> Key: ZOOKEEPER-2526
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2526
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: kerberos, security, server
>Affects Versions: 3.4.6
>Reporter: Irfan Hamid
>Priority: Minor
>  Labels: newbie, security
> Fix For: 3.4.6
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> According to ZOOKEEPER-1736 the flag allowSaslFailedClient will allow clients 
> whose Sasl auth has failed the same privileges as a client that does not 
> attempt Sasl, i.e., anonymous login.
> It would be nice to have a second property "allowAnonLogin" that defaults to 
> true and allows current behavior. But if it is set to false it disconnects 
> any clients that do not attempt Sasl auth or do not complete it successfully.
> The motivation would be to protect a shared ZooKeeper ensemble in a 
> datacenter and reduce the surface area of vulnerability by protecting the 
> service from a resiliency/availability perspective by limiting interaction by 
> anonymous clients. This would also protect against rogue clients that could 
> otherwise deny service by filling up the znode storage in non-ACLed locations.
> I'm working off of 3.4.6 source code (that's the one we have deployed 
> internally). This functionality could be implemented by adding a flag 
> ServerCnxn#isAuthenticated that is set to true iff 
> ZooKeeperServer#processSasl() succeeds and which is inspected at every 
> incoming request and the session is closed if auth isn't done and opcode is 
> other than Sasl or Auth:
> --- src/java/main/org/apache/zookeeper/server/ServerCnxn.java (revision 
> 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ServerCnxn.java (working copy)
> @@ -55,6 +55,8 @@
>   */
>  boolean isOldClient = true;
>  
> +boolean isAuthenticated = false;
> +
>  abstract int getSessionTimeout();
>  
>  abstract void close();
> --- src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (revision 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (working copy)
> @@ -884,11 +892,26 @@
>  BinaryInputArchive bia = BinaryInputArchive.getArchive(bais);
>  RequestHeader h = new RequestHeader();
>  h.deserialize(bia, "header");
>  // Through the magic of byte buffers, txn will not be
>  // pointing
>  // to the start of the txn
>  incomingBuffer = incomingBuffer.slice();
> -if (h.getType() == OpCode.auth) {
> +if (allowAnonLogin == false && cnxn.isAuthenticated == false) {
> +if (!(h.getType() == OpCode.auth ||
> +  h.getType() == OpCode.ping ||
> +  h.getType() == OpCode.sasl)) {
> +LOG.warn(String.format("Closing client connection %s. OpCode 
> %d received before Sasl authentication was complete and allowAnonLogin=false",
> +cnxn.getRemoteSocketAddress().toString(), 
> h.getType()));
> +ReplyHeader rh = new ReplyHeader(h.getXid(), 0,
> +KeeperException.Code.AUTHFAILED.intValue());
> +cnxn.sendResponse(rh, null, null);
> +cnxn.sendBuffer(ServerCnxnFactory.closeConn);
> +cnxn.disableRecv();
> +}
> +}
> @@ -963,6 +986,7 @@
>  String authorizationID = saslServer.getAuthorizationID();
>  LOG.info("adding SASL authorization for authorizationID: 
> " + authorizationID);
>  cnxn.addAuthInfo(new Id("sasl",authorizationID));
> +cnxn.isAuthenticated 

Re: [VOTE] Apache ZooKeeper release 3.4.9 candidate 2

[Abraham Fine]

+1 (non-binding)

shasum and md5sum are valid. PGP signature is valid.

Java unit tests pass and was able to successfully test against a 3 server 
ensemble.

Abe

> On Aug 23, 2016, at 4:20 PM, Patrick Hunt  wrote:
> 
> +1 xsum/sig are valid. RAT ran clean. I was able to compile the code and
> successfully put a few ensemble sizes through their paces.
> 
> fwiw I also did a "diff" btw 3.4.8 release artifact and this rc. There were
> a number of changed files, obviously. However I did not notice any missing
> files, as we've seen with the previous rcs in this release candidate line.
> afaict this artifact has all the right contents - i.e. similar to previous
> releases.
> 
> Patrick
> 
> On Tue, Aug 23, 2016 at 2:24 AM, Rakesh Radhakrishnan 
> wrote:
> 
>> This is the third release candidate for 3.4.9. This candidate removes the
>> extra *.asc files found in the
>> second candidate.
>> 
>> This is a bugfix release candidate for 3.4.9. It fixes 21 issues, including
>> issues that affect ACL cache
>> in DataTree never removes entries, prevent multiple init of login object in
>> each ZKSaslClient instance,
>> ZK service becomes unavailable when leader fails to write transaction log,
>> upgrade netty version due
>> to security vulnerability (CVE-2014-3488) and others.
>> 
>> The full release notes are available at:
>> 
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> projectId=12310801=12334700
>> 
>> *** Please download, test and vote by August 30th 2016, 23:59 UTC+0. ***
>> 
>> Source files:
>> http://people.apache.org/~rakeshr/zookeeper-3.4.9-candidate-2
>> 
>> Maven staging repo:
>> https://repository.apache.org/content/groups/staging/org/
>> apache/zookeeper/zookeeper/3.4.9
>> 
>> The tag to be voted upon:
>> https://svn.apache.org/repos/asf/zookeeper/tags/release-3.4.9-rc2
>> 
>> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
>> http://www.apache.org/dist/zookeeper/KEYS
>> 
>> Should we release this candidate?
>> 
>> Thanks,
>> Rakesh
>> 

ZooKeeper-trunk-solaris - Build # 1284 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1284/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 435269 lines...]
[junit] 2016-08-25 02:23:02,992 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-25 02:23:02,992 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-25 02:23:02,993 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-25 02:23:02,994 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-25 02:23:02,994 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-25 02:23:02,994 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-25 02:23:02,994 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test9178992581432197754.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test9178992581432197754.junit.dir/version-2
[junit] 2016-08-25 02:23:02,995 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test9178992581432197754.junit.dir/version-2/snapshot.b
[junit] 2016-08-25 02:23:02,997 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test9178992581432197754.junit.dir/version-2/snapshot.b
[junit] 2016-08-25 02:23:02,998 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-25 02:23:02,998 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-25 02:23:02,999 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:51220
[junit] 2016-08-25 02:23:03,000 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:51220
[junit] 2016-08-25 02:23:03,000 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-25 02:23:03,000 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:51220 (no session established for client)
[junit] 2016-08-25 02:23:03,000 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-25 02:23:03,002 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-25 02:23:03,002 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-25 02:23:03,002 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-25 02:23:03,003 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-25 02:23:03,003 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17859
[junit] 2016-08-25 02:23:03,003 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-25 02:23:03,003 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-25 02:23:03,003 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-25 02:23:03,082 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1233c7dacad closed
[junit] 2016-08-25 02:23:03,082 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1233c7dacad
[junit] 2016-08-25 02:23:03,082 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-25 02:23:03,082 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-25 02:23:03,083 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-08-25 02:23:03,083 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2489) Upgrade Jetty dependency to a recent stable release version.

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436089#comment-15436089
 ] 

Hudson commented on ZOOKEEPER-2489:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3051 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3051/])
ZOOKEEPER-2489: Upgrade Jetty dependency to a recent stable release version. 
(Edward Ribeiro via phunt) (phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1757584])
* (edit) trunk/CHANGES.txt
* (edit) trunk/docs/index.pdf
* (edit) trunk/docs/javaExample.pdf
* (edit) trunk/docs/linkmap.pdf
* (edit) trunk/docs/recipes.pdf
* (edit) trunk/docs/zookeeperAdmin.html
* (edit) trunk/docs/zookeeperAdmin.pdf
* (edit) trunk/docs/zookeeperHierarchicalQuorums.pdf
* (edit) trunk/docs/zookeeperInternals.pdf
* (edit) trunk/docs/zookeeperJMX.pdf
* (edit) trunk/docs/zookeeperObservers.pdf
* (edit) trunk/docs/zookeeperOver.pdf
* (edit) trunk/docs/zookeeperProgrammers.pdf
* (edit) trunk/docs/zookeeperQuotas.pdf
* (edit) trunk/docs/zookeeperReconfig.pdf
* (edit) trunk/docs/zookeeperStarted.pdf
* (edit) trunk/docs/zookeeperTutorial.pdf
* (edit) trunk/ivy.xml
* (edit) trunk/src/contrib/loggraph/ivy.xml
* (edit) trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml
* (edit) 
trunk/src/java/main/org/apache/zookeeper/server/admin/JettyAdminServer.java


> Upgrade Jetty dependency to a recent stable release version.
> 
>
> Key: ZOOKEEPER-2489
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2489
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.8, 3.5.2
>Reporter: Michael Han
>Assignee: Edward Ribeiro
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2489.2.patch, ZOOKEEPER-2489.3.patch, 
> ZOOKEEPER-2489.patch
>
>
> Jetty was added as one of dependencies in ZOOKEEPER-1346 in 2011, and have 
> not been updated since then. The version we are using in trunk is 6.1.26 
> which was released in 2010. We should consider upgrade Jetty to a recent 
> stable release version (probably one of the 9.x.).
> Note: this JIRA issue is recreated from 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2427, which was deleted a 
> couple of weeks ago as part of Apache Infrastructure spam fighting effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 3051 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3051/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 452560 lines...]
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-25 01:26:58,110 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14159,name1=Connections,name2=127.0.0.1,name3=0x102177a5457]
[junit] 2016-08-25 01:26:58,210 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x102177a5457 closed
[junit] 2016-08-25 01:26:58,210 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 188532
[junit] 2016-08-25 01:26:58,210 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2016-08-25 01:26:58,211 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-25 01:26:58,211 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-25 01:26:58,211 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-25 01:26:58,211 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:14159
[junit] 2016-08-25 01:26:58,210 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x102177a5457
[junit] 2016-08-25 01:26:58,217 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-25 01:26:58,217 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-25 01:26:58,217 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-25 01:26:58,217 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-25 01:26:58,217 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-25 01:26:58,217 [myid:] - INFO  [ProcessThread(sid:0 
cport:14159)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-25 01:26:58,218 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-25 01:26:58,218 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-25 01:26:58,218 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14159,name1=InMemoryDataTree]
[junit] 2016-08-25 01:26:58,218 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14159]
[junit] 2016-08-25 01:26:58,218 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 14159
[junit] 2016-08-25 01:26:58,219 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-25 01:26:58,225 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4826 at start it was 4826
[junit] 2016-08-25 01:26:58,226 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-25 01:26:58,226 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
414.087 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-08-25 01:26:58,490 [myid:127.0.0.1:14036] - INFO  
[main-SendThread(127.0.0.1:14036):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14036. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-25 01:26:58,490 [myid:127.0.0.1:14036] - WARN  
[main-SendThread(127.0.0.1:14036):ClientCnxn$SendThread@1235] - Session 
0x1021b93 for server 127.0.0.1/127.0.0.1:14036, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1322: The 
following error occurred while executing this line:

ZooKeeper-trunk-jdk8 - Build # 721 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/721/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 492217 lines...]
[junit] 2016-08-25 01:18:25,112 [myid:] - WARN  [New I/O boss 
#9438:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x8bd4cd49] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:11343
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:11343
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-25 01:18:25,112 [myid:] - INFO  [New I/O boss 
#9438:ClientCnxnSocketNetty@208] - channel is told closing
[junit] 2016-08-25 01:18:25,112 [myid:127.0.0.1:11343] - INFO  
[main-SendThread(127.0.0.1:11343):ClientCnxn$SendThread@1231] - channel for 
sessionid 0x1006912aa18 is lost, closing socket connection and attempting 
reconnect
[junit] 2016-08-25 01:18:25,232 [myid:127.0.0.1:11373] - INFO  
[main-SendThread(127.0.0.1:11373):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:11373. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-25 01:18:25,233 [myid:] - INFO  [New I/O worker 
#10278:ClientCnxn$SendThread@948] - Socket connection established, initiating 
session, client: /127.0.0.1:37034, server: 127.0.0.1/127.0.0.1:11373
[junit] 2016-08-25 01:18:25,233 [myid:] - INFO  [New I/O worker 
#10278:ClientCnxnSocketNetty$1@153] - channel is connected: [id: 0x63eef29a, 
/127.0.0.1:37034 => 127.0.0.1/127.0.0.1:11373]
[junit] 2016-08-25 01:18:25,233 [myid:] - WARN  [New I/O worker 
#10114:NettyServerCnxn@399] - Closing connection to /127.0.0.1:37034
[junit] java.io.IOException: ZK down
[junit] at 
org.apache.zookeeper.server.NettyServerCnxn.receiveMessage(NettyServerCnxn.java:336)
[junit] at 
org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.processMessage(NettyServerCnxnFactory.java:244)
[junit] at 
org.apache.zookeeper.server.NettyServerCnxnFactory$CnxnChannelHandler.messageReceived(NettyServerCnxnFactory.java:166)
[junit] at 
org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88)
[junit] at 
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)
[junit] at 
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559)
[junit] at 
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268)
[junit] at 
org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89)
[junit] at 
org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-25 01:18:25,234 [myid:] - INFO  [New I/O worker 
#10278:ClientCnxnSocketNetty$ZKClientHandler@384] - channel is disconnected: 
[id: 0x63eef29a, /127.0.0.1:37034 :> 

[jira] [Commented] (ZOOKEEPER-2509) Secure mode leaks memory

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436018#comment-15436018
 ] 

Patrick Hunt commented on ZOOKEEPER-2509:
-

Ted - our qabot is still oldschool, it expects svn formatted patches - 
"--no-prefix" when using git to generate the diff. That's why the patch is 
failing to apply (well, at least one reason)
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

> Secure mode leaks memory
> 
>
> Key: ZOOKEEPER-2509
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2509
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Fix For: 3.5.3
>
> Attachments: 
> 0001-Updated-patch-for-Netty-leak-testing-to-trunk.patch, leak-patch.patch
>
>
> The Netty connection handling logic fails to clean up watches on connection 
> close. This causes memory to leak.
> I will have a repro script available soon and a fix. I am not sure how to 
> build a unit test since we would need to build an entire server and generate 
> keys and such. Advice on that appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2509) Secure mode leaks memory

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2509:

Assignee: Ted Dunning

> Secure mode leaks memory
> 
>
> Key: ZOOKEEPER-2509
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2509
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Fix For: 3.5.3
>
> Attachments: 
> 0001-Updated-patch-for-Netty-leak-testing-to-trunk.patch, leak-patch.patch
>
>
> The Netty connection handling logic fails to clean up watches on connection 
> close. This causes memory to leak.
> I will have a repro script available soon and a fix. I am not sure how to 
> build a unit test since we would need to build an entire server and generate 
> keys and such. Advice on that appreciated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2510) org.apache.zookeeper.server.NettyServerCnxnTest uses wrong import for junit

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436014#comment-15436014
 ] 

Patrick Hunt commented on ZOOKEEPER-2510:
-

Ted - the patch didn't apply because the codebase no longer has that line, 
afaict. Not trunk at least. Can you confirm wrt the current 3.5 branch and 
trunk? (I grepped and didn't see that package in use...)

> org.apache.zookeeper.server.NettyServerCnxnTest uses wrong import for junit
> ---
>
> Key: ZOOKEEPER-2510
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2510
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Fix For: 3.5.3
>
> Attachments: fix-import.patch
>
>
> junit.framework.Assert is deprecated. The code should use org.junit.Assert 
> instead.
> Patch coming shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2510) org.apache.zookeeper.server.NettyServerCnxnTest uses wrong import for junit

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2510:

Assignee: Ted Dunning

> org.apache.zookeeper.server.NettyServerCnxnTest uses wrong import for junit
> ---
>
> Key: ZOOKEEPER-2510
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2510
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1, 3.5.2
>Reporter: Ted Dunning
>Assignee: Ted Dunning
> Fix For: 3.5.3
>
> Attachments: fix-import.patch
>
>
> junit.framework.Assert is deprecated. The code should use org.junit.Assert 
> instead.
> Patch coming shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2489) Upgrade Jetty dependency to a recent stable release version.

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2489:

Fix Version/s: 3.6.0

> Upgrade Jetty dependency to a recent stable release version.
> 
>
> Key: ZOOKEEPER-2489
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2489
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.8, 3.5.2
>Reporter: Michael Han
>Assignee: Edward Ribeiro
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2489.2.patch, ZOOKEEPER-2489.3.patch, 
> ZOOKEEPER-2489.patch
>
>
> Jetty was added as one of dependencies in ZOOKEEPER-1346 in 2011, and have 
> not been updated since then. The version we are using in trunk is 6.1.26 
> which was released in 2010. We should consider upgrade Jetty to a recent 
> stable release version (probably one of the 9.x.).
> Note: this JIRA issue is recreated from 
> https://issues.apache.org/jira/browse/ZOOKEEPER-2427, which was deleted a 
> couple of weeks ago as part of Apache Infrastructure spam fighting effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZOOKEEPER-2529) Flaky Test: org.apache.zookeeper.test.NonRecoverableErrorTest.testZooKeeperServiceAvailableOnLeader

[Michael Han (JIRA)]

Michael Han created ZOOKEEPER-2529:
--

 Summary: Flaky Test: 
org.apache.zookeeper.test.NonRecoverableErrorTest.testZooKeeperServiceAvailableOnLeader
 Key: ZOOKEEPER-2529
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2529
 Project: ZooKeeper
  Issue Type: Bug
Affects Versions: 3.4.9, 3.5.3
Reporter: Michael Han


This flaky is introduced by ZOOKEEPER-2247 recently.

{noformat}
Error Message

IOException is expected due to error injected to transaction log commit
Stacktrace

junit.framework.AssertionFailedError: IOException is expected due to error 
injected to transaction log commit
at 
org.apache.zookeeper.test.NonRecoverableErrorTest.testZooKeeperServiceAvailableOnLeader(NonRecoverableErrorTest.java:115)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at java.lang.Thread.run(Thread.java:745)
Standard Output

2016-08-24 19:20:17,000 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
test.method specified. using default methods.
2016-08-24 19:20:17,142 [myid:] - INFO  [main:JUnit4ZKTestRunner@47] - No 
test.method specified. using default methods.
2016-08-24 19:20:17,215 [myid:] - INFO  [main:ZKTestCase$1@55] - STARTING 
testZooKeeperServiceAvailableOnLeader
2016-08-24 19:20:17,222 [myid:] - INFO  [Time-limited 
test:JUnit4ZKTestRunner$LoggedInvokeMethod@77] - RUNNING TEST METHOD 
testZooKeeperServiceAvailableOnLeader
2016-08-24 19:20:17,228 [myid:] - INFO  [Time-limited test:PortAssignment@151] 
- Test process 1/8 using ports from 11221 - 13913.
2016-08-24 19:20:17,230 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11222 from range 11221 - 13913.
2016-08-24 19:20:17,231 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11223 from range 11221 - 13913.
2016-08-24 19:20:17,231 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11224 from range 11221 - 13913.
2016-08-24 19:20:17,232 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11225 from range 11221 - 13913.
2016-08-24 19:20:17,232 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11226 from range 11221 - 13913.
2016-08-24 19:20:17,232 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11227 from range 11221 - 13913.
2016-08-24 19:20:17,233 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11228 from range 11221 - 13913.
2016-08-24 19:20:17,233 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11229 from range 11221 - 13913.
2016-08-24 19:20:17,234 [myid:] - INFO  [Time-limited test:PortAssignment@85] - 
Assigned port 11230 from range 11221 - 13913.
2016-08-24 19:20:17,256 [myid:] - INFO  [Time-limited 
test:QuorumPeerTestBase$MainThread@131] - id = 0 tmpDir = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test7330020881446886387.junit.dir
 clientPort = 11222 adminServerPort = 8080
2016-08-24 19:20:17,262 [myid:] - INFO  [Time-limited 
test:QuorumPeerTestBase$MainThread@131] - id = 1 tmpDir = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test7260737707555606353.junit.dir
 clientPort = 11225 adminServerPort = 8080
2016-08-24 19:20:17,267 [myid:] - INFO  [Time-limited 
test:QuorumPeerTestBase$MainThread@131] - id = 2 tmpDir = 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test1038022970424066351.junit.dir
 clientPort = 11228 adminServerPort = 8080
2016-08-24 19:20:17,268 [myid:] - INFO  [Thread-1:QuorumPeerConfig@116] - 
Reading configuration from: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test7260737707555606353.junit.dir/zoo.cfg
2016-08-24 19:20:17,268 [myid:] - INFO  [Thread-0:QuorumPeerConfig@116] - 
Reading configuration from: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test7330020881446886387.junit.dir/zoo.cfg
2016-08-24 19:20:17,269 [myid:] - INFO  [Thread-2:QuorumPeerConfig@116] - 
Reading configuration from: 
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build/test/tmp/test1038022970424066351.junit.dir/zoo.cfg
2016-08-24 19:20:17,270 [myid:] - INFO  [Thread-1:QuorumPeerConfig@318] - 
clientPortAddress is 0.0.0.0/0.0.0.0:11225
2016-08-24 19:20:17,270 [myid:] - INFO  [Thread-0:QuorumPeerConfig@318] - 
clientPortAddress is 0.0.0.0/0.0.0.0:11222
2016-08-24 19:20:17,271 [myid:] - INFO  [Thread-0:QuorumPeerConfig@322] - 
secureClientPort is not set
2016-08-24 19:20:17,270 [myid:] - INFO  [Thread-1:QuorumPeerConfig@322] - 
secureClientPort is not set
2016-08-24 19:20:17,270 [myid:] - INFO  [Thread-2:QuorumPeerConfig@318] - 
clientPortAddress is 0.0.0.0/0.0.0.0:11228
2016-08-24 19:20:17,271 [myid:] - INFO  [Thread-2:QuorumPeerConfig@322] - 
secureClientPort is 

[jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435989#comment-15435989
 ] 

Patrick Hunt commented on ZOOKEEPER-2491:
-

bq. better approach to get into the license issue

I think either is fine as long as we follow the license, if we go that way.

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: spooky000
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435974#comment-15435974
 ] 

Michael Han commented on ZOOKEEPER-2491:


I think we can possibly review and commit the version 2 patch (timestamp 
28/Jul/16). This JIRA is essentially fix a regression caused by new version of 
MSVC and simulating snprintf is not a regression as the problem was there 
before... so we can probably use another JIRA to track that issue? On that 
topic, instead of making a complete copy of code from libUV we could write our 
own safer version of snprintf for lower version of MSVC.. would that be a 
better approach to get into the license issue?

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: spooky000
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch34_jdk8 - Build # 680 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/680/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 243995 lines...]
[junit] 2016-08-24 23:38:06,135 [myid:] - INFO  
[main:PrepRequestProcessor@765] - Shutting down
[junit] 2016-08-24 23:38:06,135 [myid:] - INFO  
[main:SyncRequestProcessor@208] - Shutting down
[junit] 2016-08-24 23:38:06,135 [myid:] - INFO  [ProcessThread(sid:0 
cport:11221)::PrepRequestProcessor@143] - PrepRequestProcessor exited loop!
[junit] 2016-08-24 23:38:06,136 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@186] - SyncRequestProcessor exited!
[junit] 2016-08-24 23:38:06,136 [myid:] - INFO  
[main:FinalRequestProcessor@402] - shutdown of request processor complete
[junit] 2016-08-24 23:38:06,136 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-08-24 23:38:06,137 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-24 23:38:06,138 [myid:] - INFO  [main:ClientBase@445] - 
STARTING server
[junit] 2016-08-24 23:38:06,138 [myid:] - INFO  [main:ClientBase@366] - 
CREATING server instance 127.0.0.1:11221
[junit] 2016-08-24 23:38:06,139 [myid:] - INFO  
[main:NIOServerCnxnFactory@89] - binding to port 0.0.0.0/0.0.0.0:11221
[junit] 2016-08-24 23:38:06,139 [myid:] - INFO  [main:ClientBase@341] - 
STARTING server instance 127.0.0.1:11221
[junit] 2016-08-24 23:38:06,139 [myid:] - INFO  [main:ZooKeeperServer@173] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test3907414176032919401.junit.dir/version-2
 snapdir 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/branch-3.4/build/test/tmp/test3907414176032919401.junit.dir/version-2
[junit] 2016-08-24 23:38:06,141 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 23:38:06,142 [myid:] - INFO  
[main:FourLetterWordMain@62] - connecting to 127.0.0.1 11221
[junit] 2016-08-24 23:38:06,142 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@192] - 
Accepted socket connection from /127.0.0.1:37857
[junit] 2016-08-24 23:38:06,142 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxn@827] - Processing 
stat command from /127.0.0.1:37857
[junit] 2016-08-24 23:38:06,143 [myid:] - INFO  
[Thread-4:NIOServerCnxn$StatCommand@663] - Stat command output
[junit] 2016-08-24 23:38:06,143 [myid:] - INFO  
[Thread-4:NIOServerCnxn@1008] - Closed socket connection for client 
/127.0.0.1:37857 (no session established for client)
[junit] 2016-08-24 23:38:06,143 [myid:] - INFO  [main:JMXEnv@229] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-24 23:38:06,145 [myid:] - INFO  [main:JMXEnv@246] - 
expect:InMemoryDataTree
[junit] 2016-08-24 23:38:06,145 [myid:] - INFO  [main:JMXEnv@250] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221,name1=InMemoryDataTree
[junit] 2016-08-24 23:38:06,145 [myid:] - INFO  [main:JMXEnv@246] - 
expect:StandaloneServer_port
[junit] 2016-08-24 23:38:06,145 [myid:] - INFO  [main:JMXEnv@250] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11221
[junit] 2016-08-24 23:38:06,145 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@58] - Memory used 33586
[junit] 2016-08-24 23:38:06,146 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@63] - Number of threads 20
[junit] 2016-08-24 23:38:06,146 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@78] - FINISHED TEST METHOD testQuota
[junit] 2016-08-24 23:38:06,146 [myid:] - INFO  [main:ClientBase@522] - 
tearDown starting
[junit] 2016-08-24 23:38:06,221 [myid:] - INFO  [main:ZooKeeper@684] - 
Session: 0x156beeaf8a2 closed
[junit] 2016-08-24 23:38:06,221 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@519] - EventThread shut down for 
session: 0x156beeaf8a2
[junit] 2016-08-24 23:38:06,222 [myid:] - INFO  [main:ClientBase@492] - 
STOPPING server
[junit] 2016-08-24 23:38:06,222 [myid:] - INFO  
[NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11221:NIOServerCnxnFactory@219] - 
NIOServerCnxn factory exited run method
[junit] 2016-08-24 23:38:06,223 [myid:] - INFO  [main:ZooKeeperServer@497] 
- shutting down
[junit] 2016-08-24 23:38:06,223 [myid:] - ERROR [main:ZooKeeperServer@472] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 23:38:06,223 [myid:] - INFO  
[main:SessionTrackerImpl@225] - Shutting down
[junit] 

[jira] [Comment Edited] (ZOOKEEPER-2491) C client build error in vs 2015

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435889#comment-15435889
 ] 

Patrick Hunt edited comment on ZOOKEEPER-2491 at 8/24/16 10:58 PM:
---

[~cnauroth] - lubuv is not an apache license. From what I read in the linked 
file

"The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

perhaps we can just have a separate source file (.h) that includes that comment 
section in it's entirety?

fwiw also says "substantial portions of the Software", does a single utility 
method meet that bar? (regardless I'm hoping we can use the approach I suggest 
earlier in this comment)


was (Author: phunt):
[~cnauroth] - lubuv is not an apache license. From what I read in the linked 
file

"The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

perhaps we can just have a separate source file (.h) that includes that comment 
section in it's entirety?

fwiw also says "substantial portions of the Software", does a single utility 
method meet that bar? (regardless I'm hoping we can use the approach I suggest 
earlier in this comment?

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: spooky000
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2491) C client build error in vs 2015

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435889#comment-15435889
 ] 

Patrick Hunt commented on ZOOKEEPER-2491:
-

[~cnauroth] - lubuv is not an apache license. From what I read in the linked 
file

"The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software."

perhaps we can just have a separate source file (.h) that includes that comment 
section in it's entirety?

fwiw also says "substantial portions of the Software", does a single utility 
method meet that bar? (regardless I'm hoping we can use the approach I suggest 
earlier in this comment?

> C client build error in vs 2015 
> 
>
> Key: ZOOKEEPER-2491
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2491
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.5.2
> Environment: windows vs 2015
>Reporter: spooky000
>Assignee: spooky000
>Priority: Minor
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2491.patch, ZOOKEEPER-2491.patch, 
> ZOOKEEPER-2491.patch
>
>
> Visual Studio 2015  supports snprintf.
> #define snprintf _snprintf throw error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435858#comment-15435858
 ] 

Patrick Hunt edited comment on ZOOKEEPER-2528 at 8/24/16 10:35 PM:
---

Hm, very interesting. Thanks [~ramanala]. Please take a look at ZOOKEEPER-1621 
- iiuc based on the stack trace you just provided a patch is pending. Note it's 
slated for 3.5+ and not 3.4 branch.


was (Author: phunt):
Hm, very interesting. Thanks [~ramanala]. Please take a look at ZOOKEEPER-1621 
- iiuc based on the stack trace you just provided it's been fixed, but in 3.5+ 
and not 3.4 branch.

> ZooKeeper cluster can become unavailable due to power failures
> --
>
> Key: ZOOKEEPER-2528
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.8
> Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
> machines. 
>Reporter: Ramnatthan Alagappan
>Assignee: Abraham Fine
>Priority: Critical
>
> ZooKeeper cluster can become unavailable if power failures happen at certain 
> specific points in time. 
> Details:
> I am running a three-node ZooKeeper cluster. I perform a simple update from a 
> client machine. 
> When I try to update a value, ZooKeeper creates a new log file (for example, 
> when the current log is fully utilized). First, it creates the file and 
> appends some header information to the newly created log. The system call 
> sequence looks like below:
> creat(log.20001)
> append(log.20001, offset=0,  count=16)
> Now, if a power failure happens just after the creat of the log file but 
> before the append of the header information, the node simply crashes with an 
> EOF exception. If the same problem occurs at two or more nodes in my 
> three-node cluster, the entire cluster becomes unavailable as the majority of 
> servers have crashed because of the above problem.  
> A power failure at the same time across multiple nodes may be possible in 
> single data center or single rack deployment scenarios. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435858#comment-15435858
 ] 

Patrick Hunt commented on ZOOKEEPER-2528:
-

Hm, very interesting. Thanks [~ramanala]. Please take a look at ZOOKEEPER-1621 
- iiuc based on the stack trace you just provided it's been fixed, but in 3.5+ 
and not 3.4 branch.

> ZooKeeper cluster can become unavailable due to power failures
> --
>
> Key: ZOOKEEPER-2528
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.8
> Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
> machines. 
>Reporter: Ramnatthan Alagappan
>Assignee: Abraham Fine
>Priority: Critical
>
> ZooKeeper cluster can become unavailable if power failures happen at certain 
> specific points in time. 
> Details:
> I am running a three-node ZooKeeper cluster. I perform a simple update from a 
> client machine. 
> When I try to update a value, ZooKeeper creates a new log file (for example, 
> when the current log is fully utilized). First, it creates the file and 
> appends some header information to the newly created log. The system call 
> sequence looks like below:
> creat(log.20001)
> append(log.20001, offset=0,  count=16)
> Now, if a power failure happens just after the creat of the log file but 
> before the append of the header information, the node simply crashes with an 
> EOF exception. If the same problem occurs at two or more nodes in my 
> three-node cluster, the entire cluster becomes unavailable as the majority of 
> servers have crashed because of the above problem.  
> A power failure at the same time across multiple nodes may be possible in 
> single data center or single rack deployment scenarios. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-1884) zkCli silently ignores commands with missing parameters

[Abraham Fine (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435852#comment-15435852
 ] 

Abraham Fine commented on ZOOKEEPER-1884:
-

Hey [~rgs], would you mind if I picked this one up?

> zkCli silently ignores commands with missing parameters
> ---
>
> Key: ZOOKEEPER-1884
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1884
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.6
>Reporter: Flavio Junqueira
>Assignee: Raul Gutierrez Segales
>Priority: Minor
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-1884.patch
>
>
> Apparently, we have fixed this in trunk, but not in the 3.4 branch. When we 
> pass only the path to create, the command is not executed because it expects 
> an additional parameter and there is no error message because the create 
> command exists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Ramnatthan Alagappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435844#comment-15435844
 ] 

Ramnatthan Alagappan commented on ZOOKEEPER-2528:
-

Hi Patrick,
Here is the log of one server when it restarts from the crash I have mentioned 
in the initial description. I have slightly anonymized the actual directory 
names and actual server ips. 

2016-04-14 20:30:10,350 [myid:] - INFO  [main:QuorumPeerConfig@103] - Reading 
configuration from: /tmp/zoo2.cfg
2016-04-14 20:30:10,364 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: ip1 to address: /ip1
2016-04-14 20:30:10,364 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: ip3 to address: /ip3
2016-04-14 20:30:10,364 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
Resolved hostname: ip2 to address: /ip2
2016-04-14 20:30:10,364 [myid:] - INFO  [main:QuorumPeerConfig@331] - 
Defaulting to majority quorums
2016-04-14 20:30:10,367 [myid:1] - INFO  [main:DatadirCleanupManager@78] - 
autopurge.snapRetainCount set to 3
2016-04-14 20:30:10,367 [myid:1] - INFO  [main:DatadirCleanupManager@79] - 
autopurge.purgeInterval set to 0
2016-04-14 20:30:10,367 [myid:1] - INFO  [main:DatadirCleanupManager@101] - 
Purge task is not scheduled.
2016-04-14 20:30:10,376 [myid:1] - INFO  [main:QuorumPeerMain@127] - Starting 
quorum peer
2016-04-14 20:30:10,384 [myid:1] - INFO  [main:NIOServerCnxnFactory@89] - 
binding to port 0.0.0.0/0.0.0.0:2182
2016-04-14 20:30:10,389 [myid:1] - INFO  [main:QuorumPeer@1019] - tickTime set 
to 2000
2016-04-14 20:30:10,389 [myid:1] - INFO  [main:QuorumPeer@1039] - 
minSessionTimeout set to -1
2016-04-14 20:30:10,389 [myid:1] - INFO  [main:QuorumPeer@1050] - 
maxSessionTimeout set to -1
2016-04-14 20:30:10,389 [myid:1] - INFO  [main:QuorumPeer@1065] - initLimit set 
to 5
2016-04-14 20:30:10,398 [myid:1] - INFO  [main:FileSnap@83] - Reading snapshot 
data_dir/version-2/snapshot.10002
2016-04-14 20:30:10,404 [myid:1] - ERROR [main:QuorumPeer@557] - Unable to load 
database on disk
java.io.EOFException
at java.io.DataInputStream.readInt(DataInputStream.java:392)
at 
org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63)
at 
org.apache.zookeeper.server.persistence.FileHeader.deserialize(FileHeader.java:64)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:581)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:600)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.goToNextLog(FileTxnLog.java:566)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.next(FileTxnLog.java:648)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.init(FileTxnLog.java:552)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.(FileTxnLog.java:527)
at 
org.apache.zookeeper.server.persistence.FileTxnLog.read(FileTxnLog.java:354)
at 
org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:132)
at 
org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:223)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:510)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
2016-04-14 20:30:10,406 [myid:1] - ERROR [main:QuorumPeerMain@89] - Unexpected 
exception, exiting abnormally
java.lang.RuntimeException: Unable to run quorum server 
at 
org.apache.zookeeper.server.quorum.QuorumPeer.loadDataBase(QuorumPeer.java:558)
at 
org.apache.zookeeper.server.quorum.QuorumPeer.start(QuorumPeer.java:500)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.runFromConfig(QuorumPeerMain.java:153)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:111)
at 
org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:78)
Caused by: java.io.EOFException
at java.io.DataInputStream.readInt(DataInputStream.java:392)
at 
org.apache.jute.BinaryInputArchive.readInt(BinaryInputArchive.java:63)
at 
org.apache.zookeeper.server.persistence.FileHeader.deserialize(FileHeader.java:64)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.inStreamCreated(FileTxnLog.java:581)
at 
org.apache.zookeeper.server.persistence.FileTxnLog$FileTxnIterator.createInputArchive(FileTxnLog.java:600)
at 

[jira] [Commented] (ZOOKEEPER-2516) C client calculates invalid time interval for pings et al

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435846#comment-15435846
 ] 

Patrick Hunt commented on ZOOKEEPER-2516:
-

Also see ZOOKEEPER-1626 - there seems to be quite a bit of discussion on that 
JIRA wrt this type of change.

> C client calculates invalid time interval for pings et al
> -
>
> Key: ZOOKEEPER-2516
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2516
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.0, 3.4.8, 3.5.0, 3.5.1, 3.6.0
>Reporter: Hadriel Kaplan
>Priority: Minor
>
> The C-client has a function called {{calculate_interval()}} in 
> {{zookeeper.c}}, whose purpose is to determine the number of milliseconds 
> difference between a start and end time. 
> Unfortunately its logic is invalid, if the number of microseconds of the end 
> time happens to be less than the number of microseconds of the start time - 
> which it will be about half the time, since the end time could be in the next 
> second interval. Such a case would yield a very big negative number, making 
> the function return an invalid value.
> Instead of re-creating the wheel, the {{calculate_interval()}} should use the 
> {{timersub()}} function from {{time.h}} if it's available - if it's not 
> #define'd, then #define it. (it's a macro, and the source code for it is 
> readily available)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2516) C client calculates invalid time interval for pings et al

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435841#comment-15435841
 ] 

Patrick Hunt commented on ZOOKEEPER-2516:
-

Thanks for the report [~Hadriel] - if you believe there is something there to 
address please do submit a patch. Regards.

> C client calculates invalid time interval for pings et al
> -
>
> Key: ZOOKEEPER-2516
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2516
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: c client
>Affects Versions: 3.4.0, 3.4.8, 3.5.0, 3.5.1, 3.6.0
>Reporter: Hadriel Kaplan
>Priority: Minor
>
> The C-client has a function called {{calculate_interval()}} in 
> {{zookeeper.c}}, whose purpose is to determine the number of milliseconds 
> difference between a start and end time. 
> Unfortunately its logic is invalid, if the number of microseconds of the end 
> time happens to be less than the number of microseconds of the start time - 
> which it will be about half the time, since the end time could be in the next 
> second interval. Such a case would yield a very big negative number, making 
> the function return an invalid value.
> Instead of re-creating the wheel, the {{calculate_interval()}} should use the 
> {{timersub()}} function from {{time.h}} if it's available - if it's not 
> #define'd, then #define it. (it's a macro, and the source code for it is 
> readily available)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2526) Add config flag to prohibit connections from clients that don't do Sasl auth

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435805#comment-15435805
 ] 

Patrick Hunt commented on ZOOKEEPER-2526:
-

There is also: ZOOKEEPER-2462

> Add config flag to prohibit connections from clients that don't do Sasl auth
> 
>
> Key: ZOOKEEPER-2526
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2526
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: kerberos, security, server
>Affects Versions: 3.4.6
>Reporter: Irfan Hamid
>Priority: Minor
>  Labels: newbie, security
> Fix For: 3.4.6
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> According to ZOOKEEPER-1736 the flag allowSaslFailedClient will allow clients 
> whose Sasl auth has failed the same privileges as a client that does not 
> attempt Sasl, i.e., anonymous login.
> It would be nice to have a second property "allowAnonLogin" that defaults to 
> true and allows current behavior. But if it is set to false it disconnects 
> any clients that do not attempt Sasl auth or do not complete it successfully.
> The motivation would be to protect a shared ZooKeeper ensemble in a 
> datacenter and reduce the surface area of vulnerability by protecting the 
> service from a resiliency/availability perspective by limiting interaction by 
> anonymous clients. This would also protect against rogue clients that could 
> otherwise deny service by filling up the znode storage in non-ACLed locations.
> I'm working off of 3.4.6 source code (that's the one we have deployed 
> internally). This functionality could be implemented by adding a flag 
> ServerCnxn#isAuthenticated that is set to true iff 
> ZooKeeperServer#processSasl() succeeds and which is inspected at every 
> incoming request and the session is closed if auth isn't done and opcode is 
> other than Sasl or Auth:
> --- src/java/main/org/apache/zookeeper/server/ServerCnxn.java (revision 
> 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ServerCnxn.java (working copy)
> @@ -55,6 +55,8 @@
>   */
>  boolean isOldClient = true;
>  
> +boolean isAuthenticated = false;
> +
>  abstract int getSessionTimeout();
>  
>  abstract void close();
> --- src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (revision 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (working copy)
> @@ -884,11 +892,26 @@
>  BinaryInputArchive bia = BinaryInputArchive.getArchive(bais);
>  RequestHeader h = new RequestHeader();
>  h.deserialize(bia, "header");
>  // Through the magic of byte buffers, txn will not be
>  // pointing
>  // to the start of the txn
>  incomingBuffer = incomingBuffer.slice();
> -if (h.getType() == OpCode.auth) {
> +if (allowAnonLogin == false && cnxn.isAuthenticated == false) {
> +if (!(h.getType() == OpCode.auth ||
> +  h.getType() == OpCode.ping ||
> +  h.getType() == OpCode.sasl)) {
> +LOG.warn(String.format("Closing client connection %s. OpCode 
> %d received before Sasl authentication was complete and allowAnonLogin=false",
> +cnxn.getRemoteSocketAddress().toString(), 
> h.getType()));
> +ReplyHeader rh = new ReplyHeader(h.getXid(), 0,
> +KeeperException.Code.AUTHFAILED.intValue());
> +cnxn.sendResponse(rh, null, null);
> +cnxn.sendBuffer(ServerCnxnFactory.closeConn);
> +cnxn.disableRecv();
> +}
> +}
> @@ -963,6 +986,7 @@
>  String authorizationID = saslServer.getAuthorizationID();
>  LOG.info("adding SASL authorization for authorizationID: 
> " + authorizationID);
>  cnxn.addAuthInfo(new Id("sasl",authorizationID));
> +cnxn.isAuthenticated = true;
>  }
>  }
>  catch (SaslException e) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Abraham Fine (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Abraham Fine reassigned ZOOKEEPER-2528:
---

Assignee: Abraham Fine

> ZooKeeper cluster can become unavailable due to power failures
> --
>
> Key: ZOOKEEPER-2528
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.8
> Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
> machines. 
>Reporter: Ramnatthan Alagappan
>Assignee: Abraham Fine
>Priority: Critical
>
> ZooKeeper cluster can become unavailable if power failures happen at certain 
> specific points in time. 
> Details:
> I am running a three-node ZooKeeper cluster. I perform a simple update from a 
> client machine. 
> When I try to update a value, ZooKeeper creates a new log file (for example, 
> when the current log is fully utilized). First, it creates the file and 
> appends some header information to the newly created log. The system call 
> sequence looks like below:
> creat(log.20001)
> append(log.20001, offset=0,  count=16)
> Now, if a power failure happens just after the creat of the log file but 
> before the append of the header information, the node simply crashes with an 
> EOF exception. If the same problem occurs at two or more nodes in my 
> three-node cluster, the entire cluster becomes unavailable as the majority of 
> servers have crashed because of the above problem.  
> A power failure at the same time across multiple nodes may be possible in 
> single data center or single rack deployment scenarios. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435785#comment-15435785
 ] 

Patrick Hunt commented on ZOOKEEPER-2528:
-

Thanks for the report - do you have the stack trace from the EOF? That would 
simplify tracking this one down.

> ZooKeeper cluster can become unavailable due to power failures
> --
>
> Key: ZOOKEEPER-2528
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.8
> Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
> machines. 
>Reporter: Ramnatthan Alagappan
>
> ZooKeeper cluster can become unavailable if power failures happen at certain 
> specific points in time. 
> Details:
> I am running a three-node ZooKeeper cluster. I perform a simple update from a 
> client machine. 
> When I try to update a value, ZooKeeper creates a new log file (for example, 
> when the current log is fully utilized). First, it creates the file and 
> appends some header information to the newly created log. The system call 
> sequence looks like below:
> creat(log.20001)
> append(log.20001, offset=0,  count=16)
> Now, if a power failure happens just after the creat of the log file but 
> before the append of the header information, the node simply crashes with an 
> EOF exception. If the same problem occurs at two or more nodes in my 
> three-node cluster, the entire cluster becomes unavailable as the majority of 
> servers have crashed because of the above problem.  
> A power failure at the same time across multiple nodes may be possible in 
> single data center or single rack deployment scenarios. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-2528:

Priority: Critical  (was: Major)

> ZooKeeper cluster can become unavailable due to power failures
> --
>
> Key: ZOOKEEPER-2528
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.8
> Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
> machines. 
>Reporter: Ramnatthan Alagappan
>Priority: Critical
>
> ZooKeeper cluster can become unavailable if power failures happen at certain 
> specific points in time. 
> Details:
> I am running a three-node ZooKeeper cluster. I perform a simple update from a 
> client machine. 
> When I try to update a value, ZooKeeper creates a new log file (for example, 
> when the current log is fully utilized). First, it creates the file and 
> appends some header information to the newly created log. The system call 
> sequence looks like below:
> creat(log.20001)
> append(log.20001, offset=0,  count=16)
> Now, if a power failure happens just after the creat of the log file but 
> before the append of the header information, the node simply crashes with an 
> EOF exception. If the same problem occurs at two or more nodes in my 
> three-node cluster, the entire cluster becomes unavailable as the majority of 
> servers have crashed because of the above problem.  
> A power failure at the same time across multiple nodes may be possible in 
> single data center or single rack deployment scenarios. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 222 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/222/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 440562 lines...]
[junit] 2016-08-24 21:49:23,510 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-24 21:49:23,510 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-24 21:49:23,511 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-24 21:49:23,511 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-24 21:49:23,512 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-24 21:49:23,512 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-24 21:49:23,512 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8469794341780952165.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8469794341780952165.junit.dir/version-2
[junit] 2016-08-24 21:49:23,513 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8469794341780952165.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 21:49:23,514 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test8469794341780952165.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 21:49:23,516 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 21:49:23,516 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-24 21:49:23,516 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:33575
[junit] 2016-08-24 21:49:23,517 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:33575
[junit] 2016-08-24 21:49:23,517 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-24 21:49:23,518 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:33575 (no session established for client)
[junit] 2016-08-24 21:49:23,518 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-24 21:49:23,519 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-24 21:49:23,519 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-24 21:49:23,519 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-24 21:49:23,520 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-24 21:49:23,520 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 18067
[junit] 2016-08-24 21:49:23,520 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-24 21:49:23,520 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-24 21:49:23,520 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-24 21:49:23,602 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1233b8321b4 closed
[junit] 2016-08-24 21:49:23,602 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1233b8321b4
[junit] 2016-08-24 21:49:23,602 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-24 21:49:23,603 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-24 21:49:23,603 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-0:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-08-24 21:49:23,603 [myid:] - INFO  

[jira] [Created] (ZOOKEEPER-2528) ZooKeeper cluster can become unavailable due to power failures

[Ramnatthan Alagappan (JIRA)]

Ramnatthan Alagappan created ZOOKEEPER-2528:
---

 Summary: ZooKeeper cluster can become unavailable due to power 
failures
 Key: ZOOKEEPER-2528
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2528
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.4.8
 Environment: A normal ZooKeeper cluster of 3 nodes running on 3 Linux 
machines. 
Reporter: Ramnatthan Alagappan


ZooKeeper cluster can become unavailable if power failures happen at certain 
specific points in time. 

Details:

I am running a three-node ZooKeeper cluster. I perform a simple update from a 
client machine. 

When I try to update a value, ZooKeeper creates a new log file (for example, 
when the current log is fully utilized). First, it creates the file and appends 
some header information to the newly created log. The system call sequence 
looks like below:

creat(log.20001)
append(log.20001, offset=0,  count=16)

Now, if a power failure happens just after the creat of the log file but before 
the append of the header information, the node simply crashes with an EOF 
exception. If the same problem occurs at two or more nodes in my three-node 
cluster, the entire cluster becomes unavailable as the majority of servers have 
crashed because of the above problem.  

A power failure at the same time across multiple nodes may be possible in 
single data center or single rack deployment scenarios. 








--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk-solaris - Build # 1283 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1283/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 447385 lines...]
[junit] 2016-08-24 20:31:47,744 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-24 20:31:47,744 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-24 20:31:47,746 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-24 20:31:47,747 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-24 20:31:47,747 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-24 20:31:47,747 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-24 20:31:47,747 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test788651350298040.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test788651350298040.junit.dir/version-2
[junit] 2016-08-24 20:31:47,748 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test788651350298040.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 20:31:47,750 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/tmp/test788651350298040.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 20:31:47,752 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 20:31:47,752 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-24 20:31:47,752 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:48432
[junit] 2016-08-24 20:31:47,753 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:48432
[junit] 2016-08-24 20:31:47,753 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-24 20:31:47,753 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:48432 (no session established for client)
[junit] 2016-08-24 20:31:47,754 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-24 20:31:47,755 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-24 20:31:47,755 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-24 20:31:47,755 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-24 20:31:47,755 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-24 20:31:47,756 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 17783
[junit] 2016-08-24 20:31:47,756 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-24 20:31:47,756 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-24 20:31:47,756 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-24 20:31:47,832 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1233b3c16ac closed
[junit] 2016-08-24 20:31:47,832 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1233b3c16ac
[junit] 2016-08-24 20:31:47,832 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-24 20:31:47,832 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@219]
 - accept thread exitted run method
[junit] 2016-08-24 20:31:47,833 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-24 20:31:47,833 [myid:] - INFO  

ZooKeeper-trunk-openjdk7 - Build # 1140 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-openjdk7/1140/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 517 lines...]
at 
org.tmatesoft.svn.core.internal.io.dav.DAVRepository.runReport(DAVRepository.java:1340)
at 
org.tmatesoft.svn.core.internal.io.dav.DAVRepository.update(DAVRepository.java:868)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgAbstractUpdate.updateInternal(SvnNgAbstractUpdate.java:247)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgAbstractUpdate.update(SvnNgAbstractUpdate.java:111)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgUpdate.run(SvnNgUpdate.java:38)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgUpdate.run(SvnNgUpdate.java:18)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgOperationRunner.run(SvnNgOperationRunner.java:20)
at 
org.tmatesoft.svn.core.internal.wc2.SvnOperationRunner.run(SvnOperationRunner.java:21)
at 
org.tmatesoft.svn.core.wc2.SvnOperationFactory.run(SvnOperationFactory.java:1235)
at org.tmatesoft.svn.core.wc2.SvnOperation.run(SvnOperation.java:294)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:311)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:291)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:387)
at 
hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:158)
... 13 more
Caused by: org.tmatesoft.sqljet.core.SqlJetException: FULL: error code is FULL
at 
org.tmatesoft.sqljet.core.internal.pager.SqlJetPager.openJournal(SqlJetPager.java:3051)
at 
org.tmatesoft.sqljet.core.internal.pager.SqlJetPager.begin(SqlJetPager.java:2782)
at 
org.tmatesoft.sqljet.core.internal.btree.SqlJetBtree.beginTrans(SqlJetBtree.java:931)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.doBeginTransaction(SqlJetEngine.java:561)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.access$100(SqlJetEngine.java:55)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine$12.runSynchronized(SqlJetEngine.java:535)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.runSynchronized(SqlJetEngine.java:217)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.runEngineTransaction(SqlJetEngine.java:529)
at 
org.tmatesoft.sqljet.core.table.SqlJetDb.runTransaction(SqlJetDb.java:238)
at 
org.tmatesoft.sqljet.core.table.SqlJetDb.runWriteTransaction(SqlJetDb.java:211)
at 
org.tmatesoft.svn.core.internal.wc17.db.statement.SVNWCDbCreateSchema.exec(SVNWCDbCreateSchema.java:225)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetStatement.done(SVNSqlJetStatement.java:420)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb$BumpRevisionPostUpdate.bumpMovedAway(SVNWCDb.java:5215)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb$BumpRevisionPostUpdate.transaction(SVNWCDb.java:5208)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetDb.runTransaction(SVNSqlJetDb.java:258)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetDb.runTransaction(SVNSqlJetDb.java:252)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb.opBumpRevisionPostUpdate(SVNWCDb.java:5160)
at 
org.tmatesoft.svn.core.internal.wc17.SVNUpdateEditor17.closeEdit(SVNUpdateEditor17.java:1728)
at 
org.tmatesoft.svn.core.internal.wc.SVNCancellableEditor.closeEdit(SVNCancellableEditor.java:148)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.DAVEditorHandler.endElement(DAVEditorHandler.java:492)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.BasicDAVHandler.endElement(BasicDAVHandler.java:103)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:609)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEndElement(XMLDocumentFragmentScannerImpl.java:1781)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2957)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
at 
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at 

ZooKeeper_branch35_openjdk7 - Build # 202 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_openjdk7/202/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 518 lines...]
at 
org.tmatesoft.svn.core.internal.io.dav.DAVRepository.update(DAVRepository.java:868)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgAbstractUpdate.updateInternal(SvnNgAbstractUpdate.java:247)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgAbstractUpdate.update(SvnNgAbstractUpdate.java:111)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgUpdate.run(SvnNgUpdate.java:38)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgUpdate.run(SvnNgUpdate.java:18)
at 
org.tmatesoft.svn.core.internal.wc2.ng.SvnNgOperationRunner.run(SvnNgOperationRunner.java:20)
at 
org.tmatesoft.svn.core.internal.wc2.SvnOperationRunner.run(SvnOperationRunner.java:21)
at 
org.tmatesoft.svn.core.wc2.SvnOperationFactory.run(SvnOperationFactory.java:1235)
at org.tmatesoft.svn.core.wc2.SvnOperation.run(SvnOperation.java:294)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:311)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:291)
at 
org.tmatesoft.svn.core.wc.SVNUpdateClient.doUpdate(SVNUpdateClient.java:387)
at 
hudson.scm.subversion.UpdateUpdater$TaskImpl.perform(UpdateUpdater.java:158)
... 13 more
Caused by: org.tmatesoft.sqljet.core.SqlJetException: FULL: error code is FULL
at 
org.tmatesoft.sqljet.core.internal.pager.SqlJetPager.openJournal(SqlJetPager.java:3051)
at 
org.tmatesoft.sqljet.core.internal.pager.SqlJetPager.begin(SqlJetPager.java:2782)
at 
org.tmatesoft.sqljet.core.internal.btree.SqlJetBtree.beginTrans(SqlJetBtree.java:931)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.doBeginTransaction(SqlJetEngine.java:561)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.access$100(SqlJetEngine.java:55)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine$12.runSynchronized(SqlJetEngine.java:535)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.runSynchronized(SqlJetEngine.java:217)
at 
org.tmatesoft.sqljet.core.table.engine.SqlJetEngine.runEngineTransaction(SqlJetEngine.java:529)
at 
org.tmatesoft.sqljet.core.table.SqlJetDb.runTransaction(SqlJetDb.java:238)
at 
org.tmatesoft.sqljet.core.table.SqlJetDb.runWriteTransaction(SqlJetDb.java:211)
at 
org.tmatesoft.svn.core.internal.wc17.db.statement.SVNWCDbCreateSchema.exec(SVNWCDbCreateSchema.java:225)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetStatement.done(SVNSqlJetStatement.java:420)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb$BumpRevisionPostUpdate.bumpMovedAway(SVNWCDb.java:5215)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb$BumpRevisionPostUpdate.transaction(SVNWCDb.java:5208)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetDb.runTransaction(SVNSqlJetDb.java:258)
at 
org.tmatesoft.svn.core.internal.db.SVNSqlJetDb.runTransaction(SVNSqlJetDb.java:252)
at 
org.tmatesoft.svn.core.internal.wc17.db.SVNWCDb.opBumpRevisionPostUpdate(SVNWCDb.java:5160)
at 
org.tmatesoft.svn.core.internal.wc17.SVNUpdateEditor17.closeEdit(SVNUpdateEditor17.java:1728)
at 
org.tmatesoft.svn.core.internal.wc.SVNCancellableEditor.closeEdit(SVNCancellableEditor.java:148)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.DAVEditorHandler.endElement(DAVEditorHandler.java:492)
at 
org.tmatesoft.svn.core.internal.io.dav.handlers.BasicDAVHandler.endElement(BasicDAVHandler.java:103)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endElement(AbstractSAXParser.java:609)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanEndElement(XMLDocumentFragmentScannerImpl.java:1781)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:2957)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:606)
at 
com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:117)
at 
com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:510)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:848)
at 
com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:777)
at 
com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
at 
com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1213)
at 

[jira] [Commented] (ZOOKEEPER-2152) Intermittent failure in TestReconfig.cc

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435514#comment-15435514
 ] 

Hudson commented on ZOOKEEPER-2152:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3049 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3049/])
ZOOKEEPER-2152: Intermittent failure in TestReconfig.cc (Michael Han via phunt) 
(phunt: 
[http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN=rev=1757564])
* (edit) trunk/CHANGES.txt
* (edit) trunk/src/c/src/zk_adaptor.h
* (edit) trunk/src/c/src/zookeeper.c
* (edit) trunk/src/c/tests/TestReconfig.cc


> Intermittent failure in TestReconfig.cc
> ---
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michael Han
>  Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch, 
> ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec] 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
>  Assertion: assertion failed [Expression: found != string::npos, 
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper-trunk - Build # 3049 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/3049/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 450313 lines...]
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-24 19:27:04,450 [myid:127.0.0.1:16729] - INFO  
[main-SendThread(127.0.0.1:16729):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16729. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-24 19:27:04,450 [myid:127.0.0.1:16729] - WARN  
[main-SendThread(127.0.0.1:16729):ClientCnxn$SendThread@1235] - Session 
0x102162e092d for server 127.0.0.1/127.0.0.1:16729, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:744)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-24 19:27:04,506 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1021630d863 closed
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1021630d863
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 153829
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 1643
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-24 19:27:04,507 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-24 19:27:04,511 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-24 19:27:04,511 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 19:27:04,511 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-24 19:27:04,512 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=InMemoryDataTree]
[junit] 2016-08-24 19:27:04,513 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16852]
[junit] 2016-08-24 19:27:04,513 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16852
[junit] 2016-08-24 19:27:04,513 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-24 19:27:04,519 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 4822 at start it was 4822
[junit] 2016-08-24 19:27:04,519 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-24 19:27:04,519 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
409.859 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1322: The 
following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/build.xml:1207: 
Tests failed!

Total time: 9 minutes 54 seconds
Build step 'Execute shell' marked build as failure
[FINDBUGS] 

[jira] [Commented] (ZOOKEEPER-2152) Intermittent failure in TestReconfig.cc

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435510#comment-15435510
 ] 

Michael Han commented on ZOOKEEPER-2152:


Thanks Pat for review and commit!

> Intermittent failure in TestReconfig.cc
> ---
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michael Han
>  Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch, 
> ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec] 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
>  Assertion: assertion failed [Expression: found != string::npos, 
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2526) Add config flag to prohibit connections from clients that don't do Sasl auth

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435482#comment-15435482
 ] 

Patrick Hunt commented on ZOOKEEPER-2526:
-

Thanks for the submission Irfan - could you describe how your request compares 
to ZOOKEEPER-1634 ? Are both jiras requesting/implementing the same feature, if 
not how do they differ?

> Add config flag to prohibit connections from clients that don't do Sasl auth
> 
>
> Key: ZOOKEEPER-2526
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2526
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: kerberos, security, server
>Affects Versions: 3.4.6
>Reporter: Irfan Hamid
>Priority: Minor
>  Labels: newbie, security
> Fix For: 3.4.6
>
>   Original Estimate: 120h
>  Remaining Estimate: 120h
>
> According to ZOOKEEPER-1736 the flag allowSaslFailedClient will allow clients 
> whose Sasl auth has failed the same privileges as a client that does not 
> attempt Sasl, i.e., anonymous login.
> It would be nice to have a second property "allowAnonLogin" that defaults to 
> true and allows current behavior. But if it is set to false it disconnects 
> any clients that do not attempt Sasl auth or do not complete it successfully.
> The motivation would be to protect a shared ZooKeeper ensemble in a 
> datacenter and reduce the surface area of vulnerability by protecting the 
> service from a resiliency/availability perspective by limiting interaction by 
> anonymous clients. This would also protect against rogue clients that could 
> otherwise deny service by filling up the znode storage in non-ACLed locations.
> I'm working off of 3.4.6 source code (that's the one we have deployed 
> internally). This functionality could be implemented by adding a flag 
> ServerCnxn#isAuthenticated that is set to true iff 
> ZooKeeperServer#processSasl() succeeds and which is inspected at every 
> incoming request and the session is closed if auth isn't done and opcode is 
> other than Sasl or Auth:
> --- src/java/main/org/apache/zookeeper/server/ServerCnxn.java (revision 
> 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ServerCnxn.java (working copy)
> @@ -55,6 +55,8 @@
>   */
>  boolean isOldClient = true;
>  
> +boolean isAuthenticated = false;
> +
>  abstract int getSessionTimeout();
>  
>  abstract void close();
> --- src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (revision 1757035)
> +++ src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
> (working copy)
> @@ -884,11 +892,26 @@
>  BinaryInputArchive bia = BinaryInputArchive.getArchive(bais);
>  RequestHeader h = new RequestHeader();
>  h.deserialize(bia, "header");
>  // Through the magic of byte buffers, txn will not be
>  // pointing
>  // to the start of the txn
>  incomingBuffer = incomingBuffer.slice();
> -if (h.getType() == OpCode.auth) {
> +if (allowAnonLogin == false && cnxn.isAuthenticated == false) {
> +if (!(h.getType() == OpCode.auth ||
> +  h.getType() == OpCode.ping ||
> +  h.getType() == OpCode.sasl)) {
> +LOG.warn(String.format("Closing client connection %s. OpCode 
> %d received before Sasl authentication was complete and allowAnonLogin=false",
> +cnxn.getRemoteSocketAddress().toString(), 
> h.getType()));
> +ReplyHeader rh = new ReplyHeader(h.getXid(), 0,
> +KeeperException.Code.AUTHFAILED.intValue());
> +cnxn.sendResponse(rh, null, null);
> +cnxn.sendBuffer(ServerCnxnFactory.closeConn);
> +cnxn.disableRecv();
> +}
> +}
> @@ -963,6 +986,7 @@
>  String authorizationID = saslServer.getAuthorizationID();
>  LOG.info("adding SASL authorization for authorizationID: 
> " + authorizationID);
>  cnxn.addAuthInfo(new Id("sasl",authorizationID));
> +cnxn.isAuthenticated = true;
>  }
>  }
>  catch (SaslException e) {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Procedure for adding a new feature

[Patrick Hunt]

The "how to contribute" page is also a good resource for new folks
interested in participating:

https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

Patrick

On Tue, Aug 23, 2016 at 5:27 PM, Camille Fournier 
wrote:

> We are generally open to new features if they seem useful to the wider
> community. The process would be to open a jira with as much information as
> possible including the drivers behind your use case, so that we understand
> the motivation and the applicability to the wider community.
>
> Best,
> Camille
>
> On Tue, Aug 23, 2016 at 6:57 PM, Irfan Hamid 
> wrote:
>
> > Hi,
> >
> > At our company we have a requirement for a small feature to be added to
> > ZooKeeper. I have gone through the code (excellently written and easy to
> > understand, yay) and I think I have a handle on how to write it (actually
> > have the changes but need to test them and add unit tests).
> >
> > My question is, how would I know if the community is even interested in
> > this feature? Should I directly open a JIRA and assign it to myself to
> > initiate discussion and then add the patch to it when it's ready for
> being
> > reviewed? Or should I start the discussion here, and if you are
> interested,
> > create a JIRA and go on from there?
> >
> > Thanks,
> > Irfan.
> >
> > PS: The feature (V1) in question is to add a flag "allowAnonLogin" to
> > QuorumPeerConfig that defaults to true. If set to false, it requires that
> > all clients establishing a session perform Sasl authentication before any
> > other action, otherwise the session is closed.
> >
>

[jira] [Commented] (ZOOKEEPER-2080) ReconfigRecoveryTest fails intermittently

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435457#comment-15435457
 ] 

Patrick Hunt commented on ZOOKEEPER-2080:
-

[~fpj] can you take a look at this one as it's changing FLE code, which you're 
probably the most familiar with.

> ReconfigRecoveryTest fails intermittently
> -
>
> Key: ZOOKEEPER-2080
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2080
> Project: ZooKeeper
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Michael Han
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> ZOOKEEPER-2080.patch, ZOOKEEPER-2080.patch, 
> jacoco-ZOOKEEPER-2080.unzip-grows-to-70MB.7z, repro-20150816.log, 
> threaddump.log
>
>
> I got the following test failure on MacBook with trunk code:
> {code}
> Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
>   FAILED
> waiting for server 2 being up
> junit.framework.AssertionFailedError: waiting for server 2 being up
>   at 
> org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2502) Flaky Test: org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435448#comment-15435448
 ] 

Patrick Hunt commented on ZOOKEEPER-2502:
-

+1, this looks fine but we need to wait to commit until 3.4.9 is finalized.

> Flaky Test: 
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion
> --
>
> Key: ZOOKEEPER-2502
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2502
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 3.4.9
>Reporter: Michael Han
>Assignee: Michael Han
>  Labels: flaky, flaky-test
> Fix For: 3.4.10
>
> Attachments: ZOOKEEPER-2502.patch, ZOOKEEPER-2502.patch
>
>
> {noformat}
> Error Message
> Broken pipe
> Stacktrace
> java.io.IOException: Broken pipe
>   at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
>   at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
>   at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
>   at sun.nio.ch.IOUtil.write(IOUtil.java:65)
>   at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466)
>   at java.nio.channels.Channels.writeFullyImpl(Channels.java:78)
>   at java.nio.channels.Channels.writeFully(Channels.java:98)
>   at java.nio.channels.Channels.access$000(Channels.java:61)
>   at java.nio.channels.Channels$1.write(Channels.java:174)
>   at java.io.OutputStream.write(OutputStream.java:75)
>   at java.nio.channels.Channels$1.write(Channels.java:155)
>   at java.io.DataOutputStream.writeInt(DataOutputStream.java:198)
>   at 
> org.apache.zookeeper.server.quorum.CnxManagerTest.testCnxFromFutureVersion(CnxManagerTest.java:318)
>   at 
> org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)
> Standard Output
> 2016-07-12 22:34:46,623 [myid:] - INFO  [main:ZKTestCase$1@50] - STARTING 
> testCnxFromFutureVersion
> 2016-07-12 22:34:46,627 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11221
> 2016-07-12 22:34:46,630 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11222
> 2016-07-12 22:34:46,631 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11223
> 2016-07-12 22:34:46,643 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2016-07-12 22:34:46,658 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11224
> 2016-07-12 22:34:46,658 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11225
> 2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11226
> 2016-07-12 22:34:46,659 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11227
> 2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11228
> 2016-07-12 22:34:46,659 [myid:] - INFO  [main:PortAssignment@32] - assigning 
> port 11229
> 2016-07-12 22:34:46,660 [myid:] - INFO  [main:QuorumPeer$QuorumServer@149] - 
> Resolved hostname: 0.0.0.0 to address: /0.0.0.0
> 2016-07-12 22:34:46,660 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@53] - RUNNING TEST METHOD 
> testCnxFromFutureVersion
> 2016-07-12 22:34:46,672 [myid:] - INFO  [main:NIOServerCnxnFactory@89] - 
> binding to port 0.0.0.0/0.0.0.0:11225
> 2016-07-12 22:34:46,692 [myid:] - INFO  [main:CnxManagerTest@301] - Election 
> port: 11226
> 2016-07-12 22:34:46,692 [myid:] - INFO  
> [ListenerThread:QuorumCnxManager$Listener@534] - My election bind port: 
> /0.0.0.0:11226
> 2016-07-12 22:34:47,696 [myid:] - INFO  
> [/0.0.0.0:11226:QuorumCnxManager$Listener@541] - Received connection request 
> /140.211.11.27:48724
> 2016-07-12 22:34:49,700 [myid:] - WARN  [/0.0.0.0:11226:QuorumCnxManager@274] 
> - Exception reading or writing challenge: java.net.SocketTimeoutException: 
> Read timed out
> 2016-07-12 22:34:52,700 [myid:] - INFO  
> [main:JUnit4ZKTestRunner$LoggedInvokeMethod@74] - TEST METHOD FAILED 
> testCnxFromFutureVersion
> java.io.IOException: Broken pipe
>   at sun.nio.ch.FileDispatcherImpl.write0(Native Method)
>   at sun.nio.ch.SocketDispatcher.write(SocketDispatcher.java:47)
>   at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:93)
>   at sun.nio.ch.IOUtil.write(IOUtil.java:65)
>   at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:466)
>   at java.nio.channels.Channels.writeFullyImpl(Channels.java:78)
>   at java.nio.channels.Channels.writeFully(Channels.java:98)
>   at java.nio.channels.Channels.access$000(Channels.java:61)
>   at java.nio.channels.Channels$1.write(Channels.java:174)
>  

[jira] [Commented] (ZOOKEEPER-2152) Intermittent failure in TestReconfig.cc

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435386#comment-15435386
 ] 

Hadoop QA commented on ZOOKEEPER-2152:
--

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12825299/ZOOKEEPER-2152.patch
  against trunk revision 1757452.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//console

This message is automatically generated.

> Intermittent failure in TestReconfig.cc
> ---
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michael Han
>  Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch, 
> ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec] 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
>  Assertion: assertion failed [Expression: found != string::npos, 
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Success: ZOOKEEPER-2152 PreCommit Build #3374

[Apache Jenkins Server]

Jira: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 453294 lines...]
 [exec]   against trunk revision 1757452.
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 3 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 2.0.3) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3374//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 09984cfe027835791e588e27c2abb2bd8483f227 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 

BUILD SUCCESSFUL
Total time: 17 minutes 43 seconds
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-2152
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Updated] (ZOOKEEPER-2152) Intermittent failure in TestReconfig.cc

[Michael Han (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Han updated ZOOKEEPER-2152:
---
Attachment: ZOOKEEPER-2152.patch

Fix tab issue - this time seriously.

> Intermittent failure in TestReconfig.cc
> ---
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michael Han
>  Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch, 
> ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec] 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
>  Assertion: assertion failed [Expression: found != string::npos, 
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_solaris - Build # 221 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_solaris/221/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 437073 lines...]
[junit] 2016-08-24 17:20:45,499 [myid:] - INFO  [main:ClientBase@386] - 
CREATING server instance 127.0.0.1:11222
[junit] 2016-08-24 17:20:45,500 [myid:] - INFO  
[main:NIOServerCnxnFactory@673] - Configuring NIO connection handler with 10s 
sessionless connection timeout, 2 selector thread(s), 16 worker threads, and 64 
kB direct buffers.
[junit] 2016-08-24 17:20:45,500 [myid:] - INFO  
[main:NIOServerCnxnFactory@686] - binding to port 0.0.0.0/0.0.0.0:11222
[junit] 2016-08-24 17:20:45,501 [myid:] - INFO  [main:ClientBase@361] - 
STARTING server instance 127.0.0.1:11222
[junit] 2016-08-24 17:20:45,501 [myid:] - INFO  [main:ZooKeeperServer@889] 
- minSessionTimeout set to 6000
[junit] 2016-08-24 17:20:45,502 [myid:] - INFO  [main:ZooKeeperServer@898] 
- maxSessionTimeout set to 6
[junit] 2016-08-24 17:20:45,502 [myid:] - INFO  [main:ZooKeeperServer@159] 
- Created server with tickTime 3000 minSessionTimeout 6000 maxSessionTimeout 
6 datadir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5832146599598065347.junit.dir/version-2
 snapdir 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5832146599598065347.junit.dir/version-2
[junit] 2016-08-24 17:20:45,502 [myid:] - INFO  [main:FileSnap@83] - 
Reading snapshot 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5832146599598065347.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 17:20:45,504 [myid:] - INFO  [main:FileTxnSnapLog@298] - 
Snapshotting: 0xb to 
/zonestorage/hudson_solaris/home/hudson/hudson-slave/workspace/ZooKeeper_branch35_solaris/branch-3.5/build/test/tmp/test5832146599598065347.junit.dir/version-2/snapshot.b
[junit] 2016-08-24 17:20:45,506 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 17:20:45,506 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 11222
[junit] 2016-08-24 17:20:45,506 [myid:] - INFO  
[NIOServerCxnFactory.AcceptThread:0.0.0.0/0.0.0.0:11222:NIOServerCnxnFactory$AcceptThread@296]
 - Accepted socket connection from /127.0.0.1:62938
[junit] 2016-08-24 17:20:45,507 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@485] - Processing stat command from 
/127.0.0.1:62938
[junit] 2016-08-24 17:20:45,507 [myid:] - INFO  
[NIOWorkerThread-1:StatCommand@49] - Stat command output
[junit] 2016-08-24 17:20:45,508 [myid:] - INFO  
[NIOWorkerThread-1:NIOServerCnxn@607] - Closed socket connection for client 
/127.0.0.1:62938 (no session established for client)
[junit] 2016-08-24 17:20:45,508 [myid:] - INFO  [main:JMXEnv@228] - 
ensureParent:[InMemoryDataTree, StandaloneServer_port]
[junit] 2016-08-24 17:20:45,509 [myid:] - INFO  [main:JMXEnv@245] - 
expect:InMemoryDataTree
[junit] 2016-08-24 17:20:45,509 [myid:] - INFO  [main:JMXEnv@249] - 
found:InMemoryDataTree 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222,name1=InMemoryDataTree
[junit] 2016-08-24 17:20:45,509 [myid:] - INFO  [main:JMXEnv@245] - 
expect:StandaloneServer_port
[junit] 2016-08-24 17:20:45,509 [myid:] - INFO  [main:JMXEnv@249] - 
found:StandaloneServer_port 
org.apache.ZooKeeperService:name0=StandaloneServer_port11222
[junit] 2016-08-24 17:20:45,510 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 18068
[junit] 2016-08-24 17:20:45,510 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 24
[junit] 2016-08-24 17:20:45,510 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testQuota
[junit] 2016-08-24 17:20:45,510 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-24 17:20:45,592 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x1233a8d2fc9 closed
[junit] 2016-08-24 17:20:45,592 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-24 17:20:45,592 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x1233a8d2fc9
[junit] 2016-08-24 17:20:45,593 [myid:] - INFO  
[ConnnectionExpirer:NIOServerCnxnFactory$ConnectionExpirerThread@583] - 
ConnnectionExpirerThread interrupted
[junit] 2016-08-24 17:20:45,593 [myid:] - INFO  
[NIOServerCxnFactory.SelectorThread-1:NIOServerCnxnFactory$SelectorThread@420] 
- selector thread exitted run method
[junit] 2016-08-24 17:20:45,593 [myid:] - INFO  

[jira] [Commented] (ZOOKEEPER-2152) Intermittent failure in TestReconfig.cc

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435193#comment-15435193
 ] 

Patrick Hunt commented on ZOOKEEPER-2152:
-

I'm afraid the test code still has the formatting issue.

> Intermittent failure in TestReconfig.cc
> ---
>
> Key: ZOOKEEPER-2152
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2152
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: c client
>Reporter: Michi Mutsuzaki
>Assignee: Michael Han
>  Labels: reconfiguration
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2152.patch, ZOOKEEPER-2152.patch, 
> ZOOKEEPER-2152.patch
>
>
> I'm seeing this failure in the c client test once in a while:
> {noformat}
> [exec] 
> /home/jenkins/jenkins-slave/workspace/ZooKeeper-trunk/trunk/src/c/tests/TestReconfig.cc:474:
>  Assertion: assertion failed [Expression: found != string::npos, 
> 10.10.10.4:2004 not in newComing list]
> {noformat}
> https://builds.apache.org/job/ZooKeeper-trunk/2640/console



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2508) Many ZooKeeper tests are flaky because they proceed with zk operation without connecting to ZooKeeper server.

[Arshad Mohammad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435000#comment-15435000
 ] 

Arshad Mohammad commented on ZOOKEEPER-2508:


Thanks [~phunt] for committing the patch
Thanks [~hanm], [~eribeiro] and [~rgs] for reviewing the patch.

> Many ZooKeeper tests are flaky because they proceed with zk operation without 
> connecting to ZooKeeper server.
> -
>
> Key: ZOOKEEPER-2508
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2508
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: tests
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
> Fix For: 3.5.3, 3.6.0
>
> Attachments: ZOOKEEPER-2508-01.patch, ZOOKEEPER-2508-02.patch, 
> ZOOKEEPER-2508-03.patch, ZOOKEEPER-2508-04.patch, ZOOKEEPER-2508-05.patch, 
> ZOOKEEPER-2508-06.patch
>
>
> Many ZooKeeper tests are flaky because they proceed with zk operation without 
> connecting to ZooKeeper server.
> Recently in our build 
> {{org.apache.zookeeper.server.ZooKeeperServerMainTest.testStandalone()}} 
> failed.
> After analyzing we found that it is failed because it is not waiting for 
> ZooKeeper client get connected to server. In this case normally zookeeper 
> client gets connected immediately but if not connected immediately the test 
> case is bound to fail.
> Not only ZooKeeperServerMainTest but there are many other classes which have 
> such test cases. This jira is to address all those test cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (ZOOKEEPER-2517) jute.maxbuffer is ignored

[Arshad Mohammad (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434993#comment-15434993
 ] 

Arshad Mohammad commented on ZOOKEEPER-2517:


sorry [~benjamin.jaton], I assigned the issue without asking you. Please feel 
free to unassign form your or assign me if you don't have cycle to work on it.

> jute.maxbuffer is ignored
> -
>
> Key: ZOOKEEPER-2517
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2517
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Benjamin Jaton
>Assignee: Benjamin Jaton
>Priority: Critical
> Attachments: ZOOKEEPER-2517.patch
>
>
> In ClientCnxnSocket.java the parsing of the system property is erroneous:
> {code}packetLen = Integer.getInteger(
>   clientConfig.getProperty(ZKConfig.JUTE_MAXBUFFER),
>   ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT
> );{code}
> Javadoc of Integer.getInteger states "The first argument is treated as the 
> name of a system property", whereas here the value of the property is passed.
> Instead I believe the author meant to write something like:
> {code}packetLen = Integer.parseInt(
>   clientConfig.getProperty(
> ZKConfig.JUTE_MAXBUFFER,
> String.valueOf(ZKClientConfig.CLIENT_MAX_PACKET_LENGTH_DEFAULT)
>   )
> );{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_jdk8 - Build # 203 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/203/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 477905 lines...]
[junit] 2016-08-24 12:10:44,997 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-24 12:10:45,001 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-24 12:10:45,001 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-24 12:10:45,002 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=InMemoryDataTree]
[junit] 2016-08-24 12:10:45,002 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16852]
[junit] 2016-08-24 12:10:45,002 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16852
[junit] 2016-08-24 12:10:45,002 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-24 12:10:45,007 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 5206 at start it was 5206
[junit] 2016-08-24 12:10:45,007 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-24 12:10:45,007 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
504.699 sec, Thread: 3, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] 2016-08-24 12:10:45,502 [myid:127.0.0.1:16729] - INFO  
[main-SendThread(127.0.0.1:16729):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16729. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-24 12:10:45,503 [myid:] - INFO  [New I/O boss 
#9438:ClientCnxnSocketNetty$1@127] - future isn't success, cause: {}
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:16729
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.run(NioClientBoss.java:42)
[junit] at 
org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108)
[junit] at 
org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42)
[junit] at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[junit] at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[junit] at java.lang.Thread.run(Thread.java:745)
[junit] 2016-08-24 12:10:45,503 [myid:] - WARN  [New I/O boss 
#9438:ClientCnxnSocketNetty$ZKClientHandler@439] - Exception caught: [id: 
0x6839deb5] EXCEPTION: java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:16729
[junit] java.net.ConnectException: Connection refused: 
127.0.0.1/127.0.0.1:16729
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.connect(NioClientBoss.java:152)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.processSelectedKeys(NioClientBoss.java:105)
[junit] at 
org.jboss.netty.channel.socket.nio.NioClientBoss.process(NioClientBoss.java:79)
[junit] at 
org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337)
 

ZooKeeper-trunk-jdk8 - Build # 719 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/719/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 439534 lines...]
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2016-08-24 11:57:28,640 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@647] - Processed session termination for 
sessionid: 0x114b021
[junit] 2016-08-24 11:57:28,641 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=Connections,name2=127.0.0.1,name3=0x114b021]
[junit] 2016-08-24 11:57:28,641 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x114b021
[junit] 2016-08-24 11:57:28,641 [myid:] - INFO  [main:ZooKeeper@1313] - 
Session: 0x114b021 closed
[junit] 2016-08-24 11:57:28,641 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 55464
[junit] 2016-08-24 11:57:28,641 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 468
[junit] 2016-08-24 11:57:28,642 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2016-08-24 11:57:28,642 [myid:] - INFO  [main:ClientBase@543] - 
tearDown starting
[junit] 2016-08-24 11:57:28,642 [myid:] - INFO  [main:ClientBase@513] - 
STOPPING server
[junit] 2016-08-24 11:57:28,642 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:16852
[junit] 2016-08-24 11:57:28,643 [myid:] - INFO  [main:ZooKeeperServer@529] 
- shutting down
[junit] 2016-08-24 11:57:28,644 [myid:] - ERROR [main:ZooKeeperServer@501] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  
[main:PrepRequestProcessor@965] - Shutting down
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  [ProcessThread(sid:0 
cport:16852)::PrepRequestProcessor@154] - PrepRequestProcessor exited loop!
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  
[main:FinalRequestProcessor@479] - shutdown of request processor complete
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port16852,name1=InMemoryDataTree]
[junit] 2016-08-24 11:57:28,644 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port16852]
[junit] 2016-08-24 11:57:28,645 [myid:] - INFO  
[main:FourLetterWordMain@85] - connecting to 127.0.0.1 16852
[junit] 2016-08-24 11:57:28,645 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2016-08-24 11:57:28,648 [myid:] - INFO  [main:ClientBase@568] - 
fdcount after test is: 1375 at start it was 1369
[junit] 2016-08-24 11:57:28,648 [myid:] - INFO  [main:ClientBase@570] - 
sleeping for 20 secs
[junit] 2016-08-24 11:57:28,648 [myid:] - INFO  [main:ZKTestCase$1@65] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2016-08-24 11:57:28,648 [myid:] - INFO  [main:ZKTestCase$1@60] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 101, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
447.227 sec, Thread: 3, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2016-08-24 11:57:28,873 [myid:127.0.0.1:16732] - INFO  
[main-SendThread(127.0.0.1:16732):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:16732. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2016-08-24 11:57:28,874 [myid:127.0.0.1:16732] - WARN  
[main-SendThread(127.0.0.1:16732):ClientCnxn$SendThread@1235] - Session 
0x211e5cc for server 127.0.0.1/127.0.0.1:16732, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 

[jira] [Created] (ZOOKEEPER-2527) Connection watch is not getting cleared when watch is created as part of get and it is fired as part of set and client is closed

[Rakesh Kumar Singh (JIRA)]

Rakesh Kumar Singh created ZOOKEEPER-2527:
-

 Summary: Connection watch is not getting cleared when watch is 
created as part of get and it is fired as part of set and client is closed
 Key: ZOOKEEPER-2527
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2527
 Project: ZooKeeper
  Issue Type: Bug
  Components: server
Affects Versions: 3.5.1
Reporter: Rakesh Kumar Singh


Connection watch is not getting cleared when watch is created as part of get 
and it is fired as part of set and client is closed
Steps to reproduce:-

Configure the Zookeeper in ssl mode and start the same
connect to zookeeper using ./zkCli.sh
Check the watch status as zero.
set watch as below :-
get -w /test
Check the watch it is like below:-
BLR107042:/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/bin # echo 
wchs | netcat 10.18.101.80 2181
1 connections watching 1 paths
Total watches:1
let the watch fire as part of below-
set /test hello
Here watch is fired when set is done
Close the client
Check for the watch. It is not zero but 1
BLR107042:/home/Rakesh/Zookeeper/18_Aug/zookeeper-3.5.1-alpha/bin # echo 
wchs | netcat 10.18.101.80 2181
1 connections watching 0 paths
Total watches:0
If we repeat again and again it will keep increasing.
Tried without SSL mode and it is working fine in that mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

ZooKeeper_branch35_jdk7 - Build # 635 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk7/635/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 450384 lines...]
 [exec] Zookeeper_simpleSystem::testLogCallbackClearLog Message Received: 
[2016-08-24 09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1027: Client 
environment:zookeeper.version=zookeeper C client 3.5.2]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1031: Client 
environment:host.name=jenkins-test-886]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1038: Client 
environment:os.name=Linux]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1039: Client 
environment:os.arch=3.13.0-30-generic]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1040: Client 
environment:os.version=#54-Ubuntu SMP Mon Jun 9 22:45:01 UTC 2014]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1048: Client 
environment:user.name=jenkins]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1056: Client 
environment:user.home=/home/jenkins]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@log_env@1068: Client 
environment:user.dir=/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/test-cppunit]
 [exec] Log Message Received: [2016-08-24 
09:25:08,738:30038(0x2b65814bf540):ZOO_INFO@zookeeper_init_internal@: 
Initiating client connection, host=127.0.0.1:22181 sessionTimeout=1 
watcher=0x45d2a0 sessionId=0 sessionPasswd= context=0x7fffd0ac87c0 
flags=0]
 [exec] Log Message Received: [2016-08-24 
09:25:08,739:30038(0x2b6583b4d700):ZOO_INFO@check_events@2357: initiated 
connection to server [127.0.0.1:22181]]
 [exec] Log Message Received: [2016-08-24 
09:25:08,742:30038(0x2b6583b4d700):ZOO_INFO@check_events@2409: session 
establishment complete on server [127.0.0.1:22181], 
sessionId=0x179dbeb000f, negotiated timeout=1 ]
 [exec]  : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset ZooKeeper server 
started : elapsed 10699 : OK
 [exec] Zookeeper_simpleSystem::testDeserializeString : elapsed 0 : OK
 [exec] Zookeeper_simpleSystem::testFirstServerDown : elapsed 1001 : OK
 [exec] Zookeeper_simpleSystem::testNullData : elapsed 1018 : OK
 [exec] Zookeeper_simpleSystem::testIPV6 : elapsed 1004 : OK
 [exec] Zookeeper_simpleSystem::testCreate : elapsed 1008 : OK
 [exec] Zookeeper_simpleSystem::testPath : elapsed 1011 : OK
 [exec] Zookeeper_simpleSystem::testPathValidation : elapsed 1032 : OK
 [exec] Zookeeper_simpleSystem::testPing : elapsed 17158 : OK
 [exec] Zookeeper_simpleSystem::testAcl : elapsed 1012 : OK
 [exec] Zookeeper_simpleSystem::testChroot : elapsed 3028 : OK
 [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started ZooKeeper 
server started : elapsed 31426 : OK
 [exec] Zookeeper_simpleSystem::testHangingClient : elapsed 1025 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithGlobal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
16145 : OK
 [exec] Zookeeper_simpleSystem::testWatcherAutoResetWithLocal ZooKeeper 
server started ZooKeeper server started ZooKeeper server started : elapsed 
16075 : OK
 [exec] Zookeeper_simpleSystem::testGetChildren2 : elapsed 1024 : OK
 [exec] Zookeeper_simpleSystem::testLastZxid : elapsed 4511 : OK
 [exec] Zookeeper_simpleSystem::testRemoveWatchers ZooKeeper server started 
: elapsed 4884 : OK
 [exec] Zookeeper_readOnly::testReadOnly : elapsed 4308 : OK
 [exec] 
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/src/c/tests/TestReconfig.cc:183:
 Assertion: equality assertion failed [Expected: 1, Actual  : 0]
 [exec] Failures !!!
 [exec] Run: 72   Failure total: 1   Failures: 1   Errors: 0
 [exec] FAIL: zktest-mt
 [exec] ==
 [exec] 1 of 2 tests failed
 [exec] Please report to u...@zookeeper.apache.org
 [exec] ==
 [exec] make[1]: Leaving directory 
`/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build/test/test-cppunit'
 [exec] make[1]: *** [check-TESTS] Error 1
 [exec] make: *** [check-am] Error 2

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1322:
 The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch35_jdk7/branch-3.5/build.xml:1282:
 The following error occurred while executing this line:

ZooKeeper-trunk-solaris - Build # 1282 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk-solaris/1282/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
Building remotely on solaris1 (Solaris) in workspace 
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris
Updating http://svn.apache.org/repos/asf/zookeeper/trunk at revision 
'2016-08-24T07:12:33.109 +'
At revision 1757466

Updating http://svn.apache.org/repos/asf/hadoop/nightly at revision 
'2016-08-24T07:12:33.109 +'
At revision 1757466

No changes for http://svn.apache.org/repos/asf/zookeeper/trunk since the 
previous build
No changes for http://svn.apache.org/repos/asf/hadoop/nightly since the 
previous build
No emails were triggered.
[locks-and-latches] Checking to see if we really have the locks
[locks-and-latches] Have all the locks, build can start
[ZooKeeper-trunk-solaris] $ /bin/bash /var/tmp/hudson6694160148663201093.sh
[trunk] $ /home/jenkins/tools/ant/latest/bin/ant 
"-DBUILD_FLAGS=-Dtest.junit.output.format=xml -Dtest.output=yes " 
-DBUILD_TARGETS=hudson-test-trunk -DANALYSIS_TARGETS=test 
"-DBUILD_ARGS=-Dfindbugs.home=${FINDBUGS_HOME} -Dforrest.home=${FORREST_HOME} 
-Djava5.home=${JAVA5_HOME}" -Dtest.output=yes -Dtest.junit.threads=8 
-Dtest.junit.output.format=xml clean test-core-java
[locks-and-latches] Releasing all the locks
[locks-and-latches] All the locks released
ERROR: command execution failed.
Recording test results
ERROR: Step ?Publish JUnit test result report? failed: Test reports were found 
but none of them are new. Did tests run? 
For example, 
/export/home/hudson/hudson-slave/workspace/ZooKeeper-trunk-solaris/trunk/build/test/logs/TEST-org.apache.jute.BinaryInputArchiveTest.xml
 is 6 hr 56 min old

Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.