Regarding stable release plan from 3.5 branch

2017-09-04 Thread bhupendra jain
Hi Guys

As I read the below link, Its great to know that community already working 
towards the stable version from 3.5 branch.  Last beta release was  on 17 
April, 2017: release 3.5.3-beta version.
https://whimsy.apache.org/board/minutes/ZooKeeper.html
## Activity:
We have completed two releases since March and the community is now working
towards the first stable release of the 3.5 branch.

So If community already have some plan / milestone for stable release from 3.5 
branch, Please share.

Thanks
Bhupendra



This e-mail and its attachments contain confidential information from HUAWEI, 
which is intended only for the person or entity whose address is listed above. 
Any use of the information contained herein in any way (including, but not 
limited to, total or partial disclosure, reproduction, or dissemination) by 
persons other than the intended recipient(s) is prohibited. If you receive this 
e-mail in error, please notify the sender by phone or email immediately and 
delete it!




ZooKeeper_branch34_jdk7 - Build # 1642 - Still Failing

2017-09-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1642/

###
## LAST 60 LINES OF THE CONSOLE 
###
Started by timer
[EnvInject] - Loading node environment variables.
ERROR: SEVERE ERROR occurs
org.jenkinsci.lib.envinject.EnvInjectException: java.io.IOException: Remote 
call on H5 failed
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:86)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.setUpEnvironment(EnvInjectListener.java:43)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.createLauncher(AbstractBuild.java:528)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:448)
at hudson.model.Run.execute(Run.java:1735)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:405)
Caused by: java.io.IOException: Remote call on H5 failed
at hudson.remoting.Channel.call(Channel.java:838)
at hudson.FilePath.act(FilePath.java:1081)
at 
org.jenkinsci.plugins.envinject.service.EnvInjectActionSetter.addEnvVarsToRun(EnvInjectActionSetter.java:59)
at 
org.jenkinsci.plugins.envinject.EnvInjectListener.loadEnvironmentVariablesNode(EnvInjectListener.java:83)
... 7 more
Caused by: java.lang.OutOfMemoryError: Java heap space
ERROR: Step ?Publish JUnit test result report? failed: no workspace for 
ZooKeeper_branch34_jdk7 #1642
[EnvInject] - [ERROR] - SEVERE ERROR occurs: Remote call on H5 failed
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2017-09-04 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152910#comment-16152910
 ] 

Hadoop QA commented on ZOOKEEPER-1260:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//console

This message is automatically generated.

> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Failed: ZOOKEEPER- PreCommit Build #992

2017-09-04 Thread Apache Jenkins Server
Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 67.24 MB...]
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/992//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment added.
 [exec] 480e8baf0d36cef530203edf633bb20a7d8cd3a5 logged out
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1649:
 exec returned: 1

Total time: 13 minutes 34 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Recording test results
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
[description-setter] Description set: ZOOKEEPER-1260
Putting comment on the pull request
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7
Setting JDK_1_7_LATEST__HOME=/home/jenkins/tools/java/latest1.7



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  org.apache.zookeeper.test.AsyncHammerTest.testHammer

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:185)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2017-09-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152907#comment-16152907
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user arshadmohammad commented on the issue:

https://github.com/apache/zookeeper/pull/338
  
Thanks @hanm @afine  for reviewing this feature. I have addressed all the 
comments, Please have a look.


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zookeeper issue #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

2017-09-04 Thread arshadmohammad
Github user arshadmohammad commented on the issue:

https://github.com/apache/zookeeper/pull/338
  
Thanks @hanm @afine  for reviewing this feature. I have addressed all the 
comments, Please have a look.


---


[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2017-09-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152904#comment-16152904
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136866016
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml 
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook/xml/simple/1.0/sdocbook.dtd";>
+
+  ZooKeeper Audit Logging
+  
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License. You 
may
+  obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0";>http://www.apache.org/licenses/LICENSE-2.0.
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an "AS IS"
+  BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or
+  implied. See the License for the specific language governing 
permissions
+  and limitations under the License.
+
+
+
+This document contains information about Audit Logs in 
ZooKeeper.
+
+  
+  
+ZooKeeper Audit Logs
+Apache ZooKeeper supports audit logs form version 3.5.4. By 
default audit logs are disabled. To enable audit
+logs configure audit.enable=true in conf/zoo.cfg. Audit logs are not 
logged on all the ZooKeeper servers, but logged
+only on the servers where client is connected as depicted in bellow 
figure.
--- End diff --

corrected.


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2017-09-04 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136866016
  
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAuditLogs.xml 
---
@@ -0,0 +1,205 @@
+
+
+http://www.oasis-open.org/docbook/xml/simple/1.0/sdocbook.dtd";>
+
+  ZooKeeper Audit Logging
+  
+
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License. You 
may
+  obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0";>http://www.apache.org/licenses/LICENSE-2.0.
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an "AS IS"
+  BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express 
or
+  implied. See the License for the specific language governing 
permissions
+  and limitations under the License.
+
+
+
+This document contains information about Audit Logs in 
ZooKeeper.
+
+  
+  
+ZooKeeper Audit Logs
+Apache ZooKeeper supports audit logs form version 3.5.4. By 
default audit logs are disabled. To enable audit
+logs configure audit.enable=true in conf/zoo.cfg. Audit logs are not 
logged on all the ZooKeeper servers, but logged
+only on the servers where client is connected as depicted in bellow 
figure.
--- End diff --

corrected.


---


[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2017-09-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152903#comment-16152903
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136865979
  
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+public class AuditConstants {
+public static final String SUCCESS = "success";
+public static final String FAILURE = "failure";
+// operation is performed, result is not known yet
+public static final String INVOKED = "invoked";
+public static final String KEY_VAL_SEPARATOR = "=";
+public static final char PAIR_SEPARATOR = '\t';
+
+public static final String OP_START = "serverStart";
--- End diff --

- Operation names are something internal to ZooKeeper server. Shall we 
expose this end user through API?  I am not sure. I have tried to segregate 
operation names though a different class. Please have a look. 

- org.apache.zookeeper.ZooDefs.opNames is exposing operation names, this 
operation name list is not complete. Also it  has operation names which do not 
exist like getMaxChildren and setMaxChildren. I have no idea why operation name 
should be exposed and how it is used.  Any idea on this ?


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2017-09-04 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136865979
  
--- Diff: src/java/main/org/apache/zookeeper/audit/AuditConstants.java ---
@@ -0,0 +1,37 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.zookeeper.audit;
+
+public class AuditConstants {
+public static final String SUCCESS = "success";
+public static final String FAILURE = "failure";
+// operation is performed, result is not known yet
+public static final String INVOKED = "invoked";
+public static final String KEY_VAL_SEPARATOR = "=";
+public static final char PAIR_SEPARATOR = '\t';
+
+public static final String OP_START = "serverStart";
--- End diff --

- Operation names are something internal to ZooKeeper server. Shall we 
expose this end user through API?  I am not sure. I have tried to segregate 
operation names though a different class. Please have a look. 

- org.apache.zookeeper.ZooDefs.opNames is exposing operation names, this 
operation name list is not complete. Also it  has operation names which do not 
exist like getMaxChildren and setMaxChildren. I have no idea why operation name 
should be exposed and how it is used.  Any idea on this ?


---


[jira] [Commented] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

2017-09-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152900#comment-16152900
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
---

Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136865485
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 
---
@@ -54,6 +54,7 @@
  */
 static final ByteBuffer closeConn = ByteBuffer.allocate(0);
 
+private static String loginUser = System.getProperty("user.name", 
"");
--- End diff --

changed to serverUser


> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zookeeper pull request #338: ZOOKEEPER-1260:Audit logging in ZooKeeper serve...

2017-09-04 Thread arshadmohammad
Github user arshadmohammad commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/338#discussion_r136865485
  
--- Diff: src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 
---
@@ -54,6 +54,7 @@
  */
 static final ByteBuffer closeConn = ByteBuffer.allocate(0);
 
+private static String loginUser = System.getProperty("user.name", 
"");
--- End diff --

changed to serverUser


---


Re: [GitHub] zookeeper issue #356: ZOOKEEPER-2572: Fix potential resource leak in FileTxn...

2017-09-04 Thread Divya pt
On Mon, Sep 4, 2017 at 5:37 AM bitgaoshu  wrote:

> Github user bitgaoshu commented on the issue:
>
> https://github.com/apache/zookeeper/pull/356
>
> Test Again
>
>
> ---
>


[jira] [Commented] (ZOOKEEPER-2572) Potential resource leak in FileTxnLog.truncate

2017-09-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152567#comment-16152567
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2572:
---

Github user bitgaoshu commented on the issue:

https://github.com/apache/zookeeper/pull/356
  
Test Again


> Potential resource leak in FileTxnLog.truncate
> --
>
> Key: ZOOKEEPER-2572
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2572
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.9, 3.5.2
>Reporter: Michael Han
>Assignee: gaoshu
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> In FileTxnLog.truncate, we have:
> {code}
> public boolean truncate(long zxid) throws IOException {
> FileTxnIterator itr = null;
> try {
> itr = new FileTxnIterator(this.logDir, zxid);
> PositionInputStream input = itr.inputStream;
> if(input == null) {
> throw new IOException("No log files found to truncate! This 
> could " +
> "happen if you still have snapshots from an old setup 
> or " +
> "log files were deleted accidentally or dataLogDir 
> was changed in zoo.cfg.");
> }
> long pos = input.getPosition();
> // now, truncate at the current position
> RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
> raf.setLength(pos);
> raf.close();
> while(itr.goToNextLog()) {
> if (!itr.logFile.delete()) {
> LOG.warn("Unable to truncate {}", itr.logFile);
> }
> }
> } finally {
> close(itr);
> }
> return true;
> }
> {code}
> {{raf}} here can be potentially in a state of not closed after leaving the 
> method, if there is an (IO) exception thrown from setLength.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zookeeper issue #356: ZOOKEEPER-2572: Fix potential resource leak in FileTxn...

2017-09-04 Thread bitgaoshu
Github user bitgaoshu commented on the issue:

https://github.com/apache/zookeeper/pull/356
  
Test Again


---


ZooKeeper-trunk-jdk8 - Build # 1190 - Still Failing

2017-09-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/ZooKeeper-trunk-jdk8/1190/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 65.55 MB...]
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-09-04 11:55:41,523 [myid:] - INFO  [ProcessThread(sid:0 
cport:14161)::PrepRequestProcessor@614] - Processed session termination for 
sessionid: 0x105c6307bf5
[junit] 2017-09-04 11:55:41,526 [myid:] - INFO  
[SyncThread:0:MBeanRegistry@128] - Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=Connections,name2=127.0.0.1,name3=0x105c6307bf5]
[junit] 2017-09-04 11:55:41,526 [myid:] - INFO  
[main-EventThread:ClientCnxn$EventThread@513] - EventThread shut down for 
session: 0x105c6307bf5
[junit] 2017-09-04 11:55:41,526 [myid:] - INFO  [main:ZooKeeper@1332] - 
Session: 0x105c6307bf5 closed
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@82] - Memory used 149334
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@87] - Number of threads 863
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  
[main:JUnit4ZKTestRunner$LoggedInvokeMethod@102] - FINISHED TEST METHOD 
testWatcherAutoResetWithLocal
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  [main:ClientBase@601] - 
tearDown starting
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  [main:ClientBase@571] - 
STOPPING server
[junit] 2017-09-04 11:55:41,527 [myid:] - INFO  
[main:NettyServerCnxnFactory@464] - shutdown called 0.0.0.0/0.0.0.0:14161
[junit] 2017-09-04 11:55:41,529 [myid:] - INFO  [main:ZooKeeperServer@545] 
- shutting down
[junit] 2017-09-04 11:55:41,529 [myid:] - ERROR [main:ZooKeeperServer@509] 
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any 
action on ERROR or SHUTDOWN server state changes
[junit] 2017-09-04 11:55:41,529 [myid:] - INFO  
[main:SessionTrackerImpl@232] - Shutting down
[junit] 2017-09-04 11:55:41,529 [myid:] - INFO  
[main:PrepRequestProcessor@1010] - Shutting down
[junit] 2017-09-04 11:55:41,529 [myid:] - INFO  
[main:SyncRequestProcessor@191] - Shutting down
[junit] 2017-09-04 11:55:41,530 [myid:] - INFO  
[SyncThread:0:SyncRequestProcessor@169] - SyncRequestProcessor exited!
[junit] 2017-09-04 11:55:41,530 [myid:] - INFO  [ProcessThread(sid:0 
cport:14161)::PrepRequestProcessor@155] - PrepRequestProcessor exited loop!
[junit] 2017-09-04 11:55:41,530 [myid:] - INFO  
[main:FinalRequestProcessor@481] - shutdown of request processor complete
[junit] 2017-09-04 11:55:41,530 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean 
[org.apache.ZooKeeperService:name0=StandaloneServer_port14161,name1=InMemoryDataTree]
[junit] 2017-09-04 11:55:41,530 [myid:] - INFO  [main:MBeanRegistry@128] - 
Unregister MBean [org.apache.ZooKeeperService:name0=StandaloneServer_port14161]
[junit] 2017-09-04 11:55:41,531 [myid:] - INFO  
[main:FourLetterWordMain@87] - connecting to 127.0.0.1 14161
[junit] 2017-09-04 11:55:41,531 [myid:] - INFO  [main:JMXEnv@146] - 
ensureOnly:[]
[junit] 2017-09-04 11:55:41,535 [myid:] - INFO  [main:ClientBase@626] - 
fdcount after test is: 2549 at start it was 2549
[junit] 2017-09-04 11:55:41,536 [myid:] - INFO  [main:ZKTestCase$1@68] - 
SUCCEEDED testWatcherAutoResetWithLocal
[junit] 2017-09-04 11:55:41,536 [myid:] - INFO  [main:ZKTestCase$1@63] - 
FINISHED testWatcherAutoResetWithLocal
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
423.125 sec, Thread: 2, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] 2017-09-04 11:55:41,799 [myid:127.0.0.1:14044] - INFO  
[main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1113] - Opening socket 
connection to server 127.0.0.1/127.0.0.1:14044. Will not attempt to 
authenticate using SASL (unknown error)
[junit] 2017-09-04 11:55:41,800 [myid:127.0.0.1:14044] - WARN  
[main-SendThread(127.0.0.1:14044):ClientCnxn$SendThread@1235] - Session 
0x305c62d345f for server 127.0.0.1/127.0.0.1:14044, unexpected error, 
closing socket connection and attempting reconnect
[junit] java.net.ConnectException: Connection refused
[junit] at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
[junit] at 
sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
[junit] at 
org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:357)
[junit] at 
org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1214)
[junit] 2017-09-04 11:55:41,925 [myid:127.0.0.1:13964] - IN