[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523313#comment-16523313
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523314#comment-16523314
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1871

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 35.29 KB...]
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1871//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16523314 added to ZOOKEEPER-3066.
 [exec] Session logged out.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806:
 exec returned: 1

Total time: 2 minutes 58 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1870

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.44 KB...]
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1870//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh:
 line 441: 11533 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
-Dtest.junit.threads=8 -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME 
-Djava5.home=$JAVA5_HOME test-core
 [exec] /bin/kill -9 11582 
 [exec] /bin/kill -9 11584 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh:
 line 471: 11620 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
test-contrib
 [exec] Comment with id 16523313 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=405A8EB43D41F8CD54FE64ED7B8F0D40.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 2

Total time: 2 minutes 54 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] Compressed 600.68 KB of artifacts by 37.3% relative to #1867
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ‘Publish JUnit test result report’ failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523311#comment-16523311
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 12 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to cause Findbugs (version 3.0.1) to fail.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16523310#comment-16523310
 ] 

Hadoop QA commented on ZOOKEEPER-3068:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//console

This message is automatically generated.

> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is 
> visually confusing when the host is an IPv6 address (see the below). In that 
> case, it would be preferable to cleanly separate the IPv6 from the port. 
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server 
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1869

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.57 KB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] -1 findbugs.  The patch appears to cause Findbugs (version 
3.0.1) to fail.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//testReport/
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1869//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16523311 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=16CA8AD598C863643DCD1D1020215F69.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806:
 exec returned: 2

Total time: 2 minutes 14 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1868

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 2.05 MB...]
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1868//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh:
 line 441: 18255 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
-Dtest.junit.threads=8 -Dcompile.c++=yes -Dforrest.home=$FORREST_HOME 
-Djava5.home=$JAVA5_HOME test-core
 [exec] /bin/kill -9 24067 
 [exec] /bin/kill -9 24101 
 [exec] 
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/src/java/test/bin/test-github-pr.sh:
 line 471: 24143 Killed  $ANT_HOME/bin/ant 
-DZookeeperPatchProcess= -Dtest.junit.output.format=xml -Dtest.output=yes 
test-contrib
 [exec] Comment with id 16523310 added to ZOOKEEPER-3068.
 [exec] Session logged out. Session was 
JSESSIONID=38F6A15EA9730704A13E441FA3622522.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 2

Total time: 2 minutes 45 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3068
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar 

This round:
- Explicit unit test for LocalPeerBean, which is using a mock QuorumPeer
- Explicit unit test for QuorumPeer
all the code changes are now covered.




---

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

[Michael Han]

Since pkg-config has been available for a long time, what's the drawback in
terms of compatibilities if we choose only support pkg-config moving
forward?

For cmake, if we choose only to support cmake, then that's another
dependency users that consumes release tarball have to install on their OS
distribution (comparing to autotools / config script approach where users
just grab the release tarball and build)... so probably not very user
friendly?

On Mon, Jun 25, 2018 at 5:52 AM, Andor Molnar 
wrote:

> Does anybody else has strong or not that strong opinion?
>
> Andor
>
>
>
> On Wed, Jun 20, 2018 at 8:30 PM, Andor Molnar  wrote:
>
> > What do you think @andschwa?
> > You did some contribution on CMake recently.
> >
> > Andor
> >
> >
> >
> > On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt  wrote:
> >
> >> Hm. Not directly on point but related - should we move off auto* tools
> at
> >> some point and just use cmake? (which is already in the codebase) Or
> some
> >> other option?
> >>
> >> Patrick
> >>
> >> On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar
>  >> >
> >> wrote:
> >>
> >> > "When is pkg-config needed?"
> >> >
> >> > Both. You need the macro to generate ./configure and you need
> pkg-config
> >> > and cppunit.pc (part of cppunit package) to compile the tests.
> >> >
> >> > "Do we already do something special like generate the configure script
> >> and
> >> > ship that as part of the release?"
> >> >
> >> > That's correct. We ship the generated ./configure script and
> >> Makefile.in in
> >> > the release artifact.
> >> >
> >> > Andor
> >> >
> >> >
> >> >
> >> >
> >> > On Wed, Jun 20, 2018 at 7:38 PM, Patrick Hunt 
> wrote:
> >> >
> >> > > When is pkg-config needed? If you want to compile from source or if
> >> you
> >> > > want to compile from the release artifact? Do we already do
> something
> >> > > special like generate the configure script and ship that as part of
> >> the
> >> > > release?
> >> > >
> >> > > Patrick
> >> > >
> >> > > On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar 
> >> wrote:
> >> > >
> >> > > > This PR is also related:
> >> > > >
> >> > > > https://github.com/apache/zookeeper/pull/362
> >> > > >
> >> > > > Andor
> >> > > >
> >> > > >
> >> > > >
> >> > > > On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar 
> >> > wrote:
> >> > > >
> >> > > > > Hi devs,
> >> > > > >
> >> > > > > I'm having problems resolving the issue mentioned in this Jira
> and
> >> > need
> >> > > > > some feedback from you:
> >> > > > >
> >> > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3034
> >> > > > >
> >> > > > > In a nutshell the situation with *cppunit* is as follows:
> >> > > > > LibreOffice team confirmed that from version *1.14.0* they will
> no
> >> > > longer
> >> > > > > ship m4 macro definitions in cppunit releases. They encourage
> >> > everybody
> >> > > > to
> >> > > > > use *pkg-config* instead in order to generate configure script
> and
> >> > > > > Makefile. By the way, this is not a new thing, it was supported
> >> even
> >> > > > before
> >> > > > > 1.14.0.  So basically, they no longer support both tools, only
> >> > > > pkg-config.
> >> > > > >
> >> > > > > So, in order to support building and running C++ tests on recent
> >> > > > > distributions with cppunit-1.14.0 like Ubuntu 18.04, Fedora,
> >> etc., we
> >> > > > have
> >> > > > > to switch to *pkg-config*.
> >> > > > >
> >> > > > > *Backward compatibility*
> >> > > > > pkg-config is going to be a new dependency of the C client which
> >> we
> >> > > need
> >> > > > > to add to the documentation near to autoconf 2.59 requirement.
> On
> >> the
> >> > > > > flipside we can remove the requirement of cppunit.m4.
> >> > > > >
> >> > > > > Another thing we can do is to maintain two different
> configure.ac
> >> > > > scripts
> >> > > > > from now on: one for cppunit.m4 and another one for pkg-config
> >> which
> >> > is
> >> > > > > going to be the default. We also have to describe in the
> >> > documentation
> >> > > > why
> >> > > > > we made that change and how to revert to the m4 version if
> needed.
> >> > > > >
> >> > > > > The way it's currently implemented in the following pull request
> >> has
> >> > > been
> >> > > > > tested and works on Ubuntu 14.04, 18.04 and CentOS 7 as long as
> >> > > > pkg-config
> >> > > > > is installed.
> >> > > > >
> >> > > > > https://github.com/apache/zookeeper/pull/528
> >> > > > >
> >> > > > > Please share your thoughts and review the changes.
> >> > > > >
> >> > > > > Thanks,
> >> > > > > Andor
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
> >
>

[jira] [Commented] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522961#comment-16522961
 ] 

Hadoop QA commented on ZOOKEEPER-2886:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//console

This message is automatically generated.

> Permanent session moved error in multi-op only connections
> --
>
> Key: ZOOKEEPER-2886
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2886
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> If there are slow followers, it's possible that the leader and the client 
> disagree on where the client is connecting to, therefore the client keeps 
> getting "Session Moved" error. Partial of the issue fixed in Jira: 
> ZOOKEEPER-710, but leaves the issue in multi-op only connection. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Success: ZOOKEEPER- PreCommit Build #1867

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 88.02 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1867//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522961 added to ZOOKEEPER-2886.
 [exec] Session logged out. Session was 
JSESSIONID=0279B53A0AA831F569BC79F1A13CE338.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 22 minutes 58 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-2886
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[mjeelanimsft]

Github user mjeelanimsft commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197976612
  
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org.apache.zookeeper.common.NetUtils;
+import org.apache.zookeeper.ZKTestCase;
+import org.hamcrest.core.AnyOf;
+import org.hamcrest.core.IsEqual;
+import org.junit.Assert;
+import org.junit.Test;
+import java.net.InetSocketAddress;
+
+public class NetUtilsTest extends ZKTestCase {
+
+private Integer port = 1234;
+private String v4addr = "127.0.0.1";
+private String v6addr = "[0:0:0:0:0:0:0:1]";
+private String v4local = v4addr + ":" + port.toString();
+private String v6local = v6addr + ":" + port.toString();
+
+@Test
+public void testformatInetAddrGoodIpv4() {
+InetSocketAddress isa = new InetSocketAddress(v4addr, port);
+Assert.assertEquals("127.0.0.1:1234", 
NetUtils.formatInetAddr(isa));
+}
+
+@Test
+public void testFormatInetAddrGoodIpv6() {
--- End diff --

Thanks @anmolnar - I'll add the additional tests


---

[jira] [Updated] (ZOOKEEPER-2886) Permanent session moved error in multi-op only connections

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-2886:
--
Labels: pull-request-available  (was: )

> Permanent session moved error in multi-op only connections
> --
>
> Key: ZOOKEEPER-2886
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2886
> Project: ZooKeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.4.10, 3.5.3, 3.6.0
>Reporter: Fangmin Lv
>Assignee: Fangmin Lv
>Priority: Major
>  Labels: pull-request-available
>
> If there are slow followers, it's possible that the leader and the client 
> disagree on where the client is connecting to, therefore the client keeps 
> getting "Session Moved" error. Partial of the issue fixed in Jira: 
> ZOOKEEPER-710, but leaves the issue in multi-op only connection. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...

[lvfangmin]

Github user lvfangmin commented on the issue:

https://github.com/apache/zookeeper/pull/353
  
@anmolnar thanks for reviewing, the testNoLogBeforeLeaderEstablishment was 
introduced by mistake during rebase, and for the confusion. I've fixed the 
other test to catch the issue I'm trying to reproduce by removing the 
zk.dontReconnect() statement.

Here is the problem I'm trying to address in this diff:

1. client trying to renew session A on server S1
2. S1 is slow (like full GC, or high network delay due to packet lost) on 
sending the revalidate request to leader
3. client timed out on renew session A on server S1, and tried to connect 
to S2
4. S2 is faster than S1, and it revalidated the session on leader and owns 
the session
5. S1's revalidate finally reached leader, and leader updated the owner to 
S1
6. from now on, the requests from this client will always get session moved 
error, although S2 is the right one which owns the session

The server need to close session in this case to allow the client to 
reconnect and address this corner case.

Jira ZOOKEEPER-710 solved the non multi-op cases, but if the client only 
sends multi-op it can hit this problem again, which is addressed in this diff.


---

ZooKeeper_branch34_jdk8 - Build # 1441 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch34_jdk8/1441/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 40.01 KB...]
[junit] Running org.apache.zookeeper.test.RepeatStartupTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.259 sec
[junit] Running org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
23.07 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedClientTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.848 sec
[junit] Running org.apache.zookeeper.test.SaslAuthDesignatedServerTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.693 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailDesignatedClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.962 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailNotifyTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.653 sec
[junit] Running org.apache.zookeeper.test.SaslAuthFailTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.779 sec
[junit] Running org.apache.zookeeper.test.SaslAuthMissingClientConfigTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.661 sec
[junit] Running org.apache.zookeeper.test.SaslClientTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.076 sec
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.857 sec
[junit] Running org.apache.zookeeper.test.SessionTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
11.243 sec
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.945 sec
[junit] Running org.apache.zookeeper.test.StandaloneTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.985 sec
[junit] Running org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.069 sec
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.74 sec
[junit] Running org.apache.zookeeper.test.SyncCallTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.691 sec
[junit] Running org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
10.591 sec
[junit] Running org.apache.zookeeper.test.UpgradeTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.885 sec
[junit] Running org.apache.zookeeper.test.WatchedEventTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.084 sec
[junit] Running org.apache.zookeeper.test.WatcherFuncTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.57 sec
[junit] Running org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
27.907 sec
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
17.518 sec
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.763 sec

fail.build.on.test.failure:

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1393: 
The following error occurred while executing this line:
/home/jenkins/jenkins-slave/workspace/ZooKeeper_branch34_jdk8/build.xml:1396: 
Tests failed!

Total time: 42 minutes 46 seconds
Build step 'Invoke Ant' marked build as failure
Archiving artifacts
Recording test results
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss

Error Message:
expected:<1> but was:<2>

Stack Trace:
junit.framework.AssertionFailedError: expected:<1> but was:<2>
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss(QuorumPeerMainTest.java:1202)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:55)

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[mjeelanimsft]

Github user mjeelanimsft commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197950541
  
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff --

Thanks @maoling @breed - working on fixing this


---

Re: rerunning jenkins test

[Patrick Hunt]

Yes, "build now" button on the job (sometimes "build with parameters",
depending on the config).

Patrick

On Mon, Jun 25, 2018 at 1:59 PM Benjamin Reed  wrote:

> is there a button on jenkins somewhere that we can push to rerun a test?
>
> thanx
> ben
>

rerunning jenkins test

[Benjamin Reed]

is there a button on jenkins somewhere that we can push to rerun a test?

thanx
ben

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[breed]

Github user breed commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197933819
  
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
--- End diff --

@mjeelanimsft i think this is why the tests are failing. can you fix this 
package name? (good catch @maoling !)


---

Failed: ZOOKEEPER- PreCommit Build #1866

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 84.75 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522771 added to ZOOKEEPER-3068.
 [exec] Session logged out. Session was 
JSESSIONID=E58C0B112C9142B0EC56C5A9E5DE3703.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 1

Total time: 15 minutes 7 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3068
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView

Error Message:
null

Stack Trace:
junit.framework.AssertionFailedError
at 
org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testLeaderOutOfView(QuorumPeerMainTest.java:1072)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-3068) Improve C client logging of IPv6 hosts

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522771#comment-16522771
 ] 

Hadoop QA commented on ZOOKEEPER-3068:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1866//console

This message is automatically generated.

> Improve C client logging of IPv6 hosts
> --
>
> Key: ZOOKEEPER-3068
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3068
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: c client
>Affects Versions: 3.6.0
>Reporter: Brian Nixon
>Assignee: Brian Nixon
>Priority: Trivial
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> The C client formats host-port pairings as [host:port] when logging. This is 
> visually confusing when the host is an IPv6 address (see the below). In that 
> case, it would be preferable to cleanly separate the IPv6 from the port. 
> {code:java}
> ZOO_INFO@check_events@2736: initiated connection to server 
> [2401:db00:1020:40bf:face:0:5:0:2181]{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #547: ZOOKEEPER-3068: Improve C client logging of IPv...

[enixon]

Github user enixon commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/547#discussion_r197925813
  
--- Diff: src/c/src/zookeeper.c ---
@@ -4358,7 +4358,9 @@ static const char* format_endpoint_info(const struct 
sockaddr_storage* ep)
 {
 static char buf[128] = { 0 };
 char addrstr[128] = { 0 };
+const char *fmtstring;
 void *inaddr;
+int inet6 = 0;  // poor man's boolean
--- End diff --

Sounds good to me, I'll rework that variable.


---

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[enixon]

Github user enixon commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
+1 from me when anmolnar is satisfied  :)


---

Success: ZOOKEEPER- PreCommit Build #1865

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.51 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522640 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=E7A8DF4E1EF3186AE1950A3CF969A5BD.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD SUCCESSFUL
Total time: 17 minutes 50 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522640#comment-16522640
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1865//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4.5h
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
Almost. :)
Sorry for still complaining: don't use `LocalPeerBean` in the QuorumPeer 
tests, it could interfere the result. Test `QuorumPeer.isLeader()` directly.


---

Failed: ZOOKEEPER- PreCommit Build #1863

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 34.90 KB...]
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] -1 contrib tests.  The patch failed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522610 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=62ED79D40692C58ACFB98429F9EBE95B.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 2

Total time: 2 minutes 26 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] Compressed 578.57 KB of artifacts by 60.8% relative to #1862
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

Failed: ZOOKEEPER- PreCommit Build #1864

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 35.30 KB...]
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522611 added to ZOOKEEPER-3066.
 [exec] Session logged out.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build@2/build.xml:1806:
 exec returned: 1

Total time: 2 minutes 23 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[Fast Archiver] Compressed 328.11 KB of artifacts by 39.0% relative to #1862
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
ERROR: Step ?Publish JUnit test result report? failed: No test report files 
were found. Configuration error?
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
No tests ran.

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522610#comment-16522610
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1863//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522611#comment-16522611
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1864//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar ready to go now 


---

[jira] [Created] (ZOOKEEPER-3069) document: is mutual auth with DIGEST-MD5 insecure?

[Jan Zerebecki (JIRA)]

Jan Zerebecki created ZOOKEEPER-3069:


 Summary: document: is mutual auth with DIGEST-MD5 insecure?
 Key: ZOOKEEPER-3069
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3069
 Project: ZooKeeper
  Issue Type: Bug
  Components: documentation
Reporter: Jan Zerebecki


The [documentation regarding mutual ZooKeeper server to server authentication 
with 
DIGEST-MD5|https://cwiki.apache.org/confluence/display/ZOOKEEPER/Server-Server+mutual+authentication#Server-Servermutualauthentication-DIGEST-MD5basedauthentication]
 currently doesn't mention whether this is insecure. [DIGEST-MD5 was declared 
obsolete in 2011 due to security problems.|https://tools.ietf.org/html/rfc6331]

This is in relation to whether this is an effective mitigation for 
CVE-2018-8012 AKA ZOOKEEPER-1045, as mentioned in 
[https://lists.apache.org/thread.html/c75147028c1c79bdebd4f8fa5db2b77da85de2b05ecc0d54d708b393@%3Cdev.zookeeper.apache.org%3E].

Would the following be a fitting addition to the documentation?:

DIGEST-MD5 based authentication should not be relied on for authentication as 
it is insecure, it is only provided for test purposes.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #338: ZOOKEEPER-1260:Audit logging in ZooKeeper servers.

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/338
  
@arshadmohammad Can we move on with this great new feature?


---

[jira] [Updated] (ZOOKEEPER-1260) Audit logging in ZooKeeper servers.

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated ZOOKEEPER-1260:
--
Labels: pull-request-available  (was: )

> Audit logging in ZooKeeper servers.
> ---
>
> Key: ZOOKEEPER-1260
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: server
>Reporter: Mahadev konar
>Assignee: Mohammad Arshad
>Priority: Major
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197833005
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/LocalPeerBeanTest.java ---
@@ -79,4 +80,27 @@ public void testClientAddress() throws Exception {
 cnxnFactory.shutdown();
 }
 
+@Test
+@SuppressWarnings("unchecked")
+public void testIsLeader() throws Exception {
--- End diff --

- This is a `QuorumPeer` test, move it to `QuorumPeerTest` class please.
- These are actually 3 tests together, split them into 3 methods please.


---

Success: ZOOKEEPER- PreCommit Build #1862

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 85.11 MB...]
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 9 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 core tests.  The patch passed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522357 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=49EF98EF1AC3C388FC896788F0667E00.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 and 
‘/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess’
 are the same file

BUILD SUCCESSFUL
Total time: 20 minutes 21 seconds
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Success
Sending email for trigger: Success
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
All tests passed

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522357#comment-16522357
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1862//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Failed: ZOOKEEPER- PreCommit Build #1861

[Apache Jenkins Server]

Build: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 83.43 MB...]
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
(version 3.0.1) warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] -1 core tests.  The patch failed core unit tests.
 [exec] 
 [exec] +1 contrib tests.  The patch passed contrib unit tests.
 [exec] 
 [exec] Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//testReport/
 [exec] Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
 [exec] Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//console
 [exec] 
 [exec] This message is automatically generated.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Adding comment to Jira.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] Comment with id 16522347 added to ZOOKEEPER-3066.
 [exec] Session logged out. Session was 
JSESSIONID=ED5B01A3EC2F06DB682304A2A188CDA8.
 [exec] 
 [exec] 
 [exec] 
==
 [exec] 
==
 [exec] Finished build.
 [exec] 
==
 [exec] 
==
 [exec] 
 [exec] 
 [exec] mv: 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 and 
'/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/patchprocess'
 are the same file

BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-github-pr-build/build.xml:1806:
 exec returned: 1

Total time: 12 minutes 28 seconds
Build step 'Execute shell' marked build as failure
Archiving artifacts
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Recording test results
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
[description-setter] Description set: ZOOKEEPER-3066
Putting comment on the pull request
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8
Setting JDK_1_8_LATEST__HOME=/home/jenkins/tools/java/latest1.8



###
## FAILED TESTS (if any) 
##
1 tests failed.
FAILED:  
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig

Error Message:
waiting for server 4 being up

Stack Trace:
junit.framework.AssertionFailedError: waiting for server 4 being up
at 
org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentServersAreObserversInNextConfig(ReconfigRecoveryTest.java:224)
at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79)

[jira] [Commented] (ZOOKEEPER-3066) Expose on JMX of Followers the id of the current leader

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522347#comment-16522347
 ] 

Hadoop QA commented on ZOOKEEPER-3066:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 9 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1861//console

This message is automatically generated.

> Expose on JMX of Followers the id of the current leader
> ---
>
> Key: ZOOKEEPER-3066
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3066
> Project: ZooKeeper
>  Issue Type: New Feature
>  Components: jmx, leaderElection, quorum
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 4h
>  Remaining Estimate: 0h
>
> It will be useful to add to JMX beans published on Follower Peers to have an 
> information about the current "leader".
> This information is only available using 4 letter words



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar tests added as you requested. Now it looks better.
I have understood what you meant, I did not use Mockito, I cannot mock the 
class I am testing


---

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

[Andor Molnar]

Does anybody else has strong or not that strong opinion?

Andor



On Wed, Jun 20, 2018 at 8:30 PM, Andor Molnar  wrote:

> What do you think @andschwa?
> You did some contribution on CMake recently.
>
> Andor
>
>
>
> On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt  wrote:
>
>> Hm. Not directly on point but related - should we move off auto* tools at
>> some point and just use cmake? (which is already in the codebase) Or some
>> other option?
>>
>> Patrick
>>
>> On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar > >
>> wrote:
>>
>> > "When is pkg-config needed?"
>> >
>> > Both. You need the macro to generate ./configure and you need pkg-config
>> > and cppunit.pc (part of cppunit package) to compile the tests.
>> >
>> > "Do we already do something special like generate the configure script
>> and
>> > ship that as part of the release?"
>> >
>> > That's correct. We ship the generated ./configure script and
>> Makefile.in in
>> > the release artifact.
>> >
>> > Andor
>> >
>> >
>> >
>> >
>> > On Wed, Jun 20, 2018 at 7:38 PM, Patrick Hunt  wrote:
>> >
>> > > When is pkg-config needed? If you want to compile from source or if
>> you
>> > > want to compile from the release artifact? Do we already do something
>> > > special like generate the configure script and ship that as part of
>> the
>> > > release?
>> > >
>> > > Patrick
>> > >
>> > > On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar 
>> wrote:
>> > >
>> > > > This PR is also related:
>> > > >
>> > > > https://github.com/apache/zookeeper/pull/362
>> > > >
>> > > > Andor
>> > > >
>> > > >
>> > > >
>> > > > On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar 
>> > wrote:
>> > > >
>> > > > > Hi devs,
>> > > > >
>> > > > > I'm having problems resolving the issue mentioned in this Jira and
>> > need
>> > > > > some feedback from you:
>> > > > >
>> > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3034
>> > > > >
>> > > > > In a nutshell the situation with *cppunit* is as follows:
>> > > > > LibreOffice team confirmed that from version *1.14.0* they will no
>> > > longer
>> > > > > ship m4 macro definitions in cppunit releases. They encourage
>> > everybody
>> > > > to
>> > > > > use *pkg-config* instead in order to generate configure script and
>> > > > > Makefile. By the way, this is not a new thing, it was supported
>> even
>> > > > before
>> > > > > 1.14.0.  So basically, they no longer support both tools, only
>> > > > pkg-config.
>> > > > >
>> > > > > So, in order to support building and running C++ tests on recent
>> > > > > distributions with cppunit-1.14.0 like Ubuntu 18.04, Fedora,
>> etc., we
>> > > > have
>> > > > > to switch to *pkg-config*.
>> > > > >
>> > > > > *Backward compatibility*
>> > > > > pkg-config is going to be a new dependency of the C client which
>> we
>> > > need
>> > > > > to add to the documentation near to autoconf 2.59 requirement. On
>> the
>> > > > > flipside we can remove the requirement of cppunit.m4.
>> > > > >
>> > > > > Another thing we can do is to maintain two different configure.ac
>> > > > scripts
>> > > > > from now on: one for cppunit.m4 and another one for pkg-config
>> which
>> > is
>> > > > > going to be the default. We also have to describe in the
>> > documentation
>> > > > why
>> > > > > we made that change and how to revert to the m4 version if needed.
>> > > > >
>> > > > > The way it's currently implemented in the following pull request
>> has
>> > > been
>> > > > > tested and works on Ubuntu 14.04, 18.04 and CentOS 7 as long as
>> > > > pkg-config
>> > > > > is installed.
>> > > > >
>> > > > > https://github.com/apache/zookeeper/pull/528
>> > > > >
>> > > > > Please share your thoughts and review the changes.
>> > > > >
>> > > > > Thanks,
>> > > > > Andor
>> > > > >
>> > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
>

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197781125
  
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org.apache.zookeeper.common.NetUtils;
+import org.apache.zookeeper.ZKTestCase;
+import org.hamcrest.core.AnyOf;
+import org.hamcrest.core.IsEqual;
+import org.junit.Assert;
+import org.junit.Test;
+import java.net.InetSocketAddress;
+
+public class NetUtilsTest extends ZKTestCase {
+
+private Integer port = 1234;
+private String v4addr = "127.0.0.1";
+private String v6addr = "[0:0:0:0:0:0:0:1]";
+private String v4local = v4addr + ":" + port.toString();
+private String v6local = v6addr + ":" + port.toString();
+
+@Test
+public void testformatInetAddrGoodIpv4() {
+InetSocketAddress isa = new InetSocketAddress(v4addr, port);
+Assert.assertEquals("127.0.0.1:1234", 
NetUtils.formatInetAddr(isa));
+}
+
+@Test
+public void testFormatInetAddrGoodIpv6() {
--- End diff --

I think it'd be great to add more IPv6 formatting tests other than the 
localhost case.


---

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197780621
  
--- Diff: src/java/test/org/apache/zookeeper/common/NetUtilsTest.java ---
@@ -0,0 +1,46 @@
+package apache.zookeeper.common;
+
+import org.apache.zookeeper.common.NetUtils;
+import org.apache.zookeeper.ZKTestCase;
+import org.hamcrest.core.AnyOf;
+import org.hamcrest.core.IsEqual;
+import org.junit.Assert;
+import org.junit.Test;
+import java.net.InetSocketAddress;
+
+public class NetUtilsTest extends ZKTestCase {
+
+private Integer port = 1234;
+private String v4addr = "127.0.0.1";
+private String v6addr = "[0:0:0:0:0:0:0:1]";
+private String v4local = v4addr + ":" + port.toString();
+private String v6local = v6addr + ":" + port.toString();
+
+@Test
+public void testformatInetAddrGoodIpv4() {
--- End diff --

Typo: capital `F`


---

[GitHub] zookeeper pull request #548: [ZOOKEEPER-3057] Fix IPv6 literal usage

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/548#discussion_r197779656
  
--- Diff: src/java/main/org/apache/zookeeper/client/FourLetterWordMain.java 
---
@@ -86,7 +86,7 @@ public static String send4LetterWord(String host, int 
port, String cmd, boolean
 throws IOException, SSLContextException {
 LOG.info("connecting to {} {}", host, port);
 Socket sock;
-InetSocketAddress hostaddress= host != null ? new 
InetSocketAddress(host, port) :
+InetSocketAddress hostaddress = host != null ? new 
InetSocketAddress(host, port) :
--- End diff --

Agreed, it's not ideal, but size of the patch makes it easy to deal with I 
would say.


---

[jira] [Assigned] (ZOOKEEPER-2873) print error and/or abort on invalid server definition

[Norbert Kalmar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Norbert Kalmar reassigned ZOOKEEPER-2873:
-

Assignee: Norbert Kalmar  (was: Mark Fenes)

> print error and/or abort on invalid server definition
> -
>
> Key: ZOOKEEPER-2873
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2873
> Project: ZooKeeper
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.4.10
>Reporter: Christopher Smith
>Assignee: Norbert Kalmar
>Priority: Minor
>
> While bringing up a new cluster, I managed to fat-finger a sed script and put 
> some lines like this into my config file:
> {code}
> server.1=zookeeper1:2888:2888
> {code}
> This led to a predictable spew of error messages when the client and election 
> components fought over the single port. Since a configuration of this case is 
> *always* an error, I suggest that it would be sensible to abort the server 
> startup if an entry is found with the same port for both client and election. 
> (Logging the error explicitly without shutting down is less helpful because 
> of how fast the logs pile up.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

ZooKeeper-trunk - Build # 74 - Failure

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper-trunk/74/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 142.95 KB...]
[junit] Running org.apache.zookeeper.test.SessionTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.504 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.438 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.085 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
73.086 sec, Thread: 6, Class: org.apache.zookeeper.test.QuorumZxidSyncTest
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
12.127 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 1
[junit] Running org.apache.zookeeper.test.StatTest in thread 6
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.1 
sec, Thread: 6, Class: org.apache.zookeeper.test.StatTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.661 sec, Thread: 1, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 6
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.069 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.007 sec, Thread: 6, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.087 sec, Thread: 1, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 6
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 1
[junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
85.722 sec, Thread: 4, Class: org.apache.zookeeper.test.QuorumTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.08 sec, Thread: 4, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.026 sec, Thread: 6, Class: org.apache.zookeeper.test.TruncateTest
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.183 sec, Thread: 4, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 6
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 4
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.088 sec, Thread: 4, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 4
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
20.704 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.852 sec, Thread: 2, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
8.852 sec, Thread: 4, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
18.722 sec, Thread: 1, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
28.185 sec, Thread: 6, Class: org.apache.zookeeper.test.WatcherTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
342.3 sec, Thread: 3, Class: org.apache.zookeeper.test.NettyNettySuiteTest
[junit] Tests run: 105, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
356.76 sec, Thread: 7, Class: org.apache.zookeeper.test.NioNettySuiteTest
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
269.729 sec, Thread: 5, Class: org.apache.zookeeper.test.ReconfigTest
[junit] Tests run: 2, Fa

[jira] [Commented] (ZOOKEEPER-3059) EventThread leak in case of Sasl AuthFailed

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522219#comment-16522219
 ] 

Hudson commented on ZOOKEEPER-3059:
---

FAILURE: Integrated in Jenkins build ZooKeeper-trunk #74 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/74/])
ZOOKEEPER-3059: EventThread leak in case of Sasl AuthFailed (andor: rev 
1fb644662b8e0530dec2c5668a3e49b3f614e9de)
* (edit) src/java/main/org/apache/zookeeper/ClientCnxn.java
* (edit) src/java/test/org/apache/zookeeper/SaslAuthTest.java


> EventThread leak in case of Sasl AuthFailed
> ---
>
> Key: ZOOKEEPER-3059
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3059
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.12
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Attachments: stack_dump
>
>  Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> In case of an authFailed sasl event we shutdown the send thread however we 
> never close the event thread. Even if the client tries to close the 
> connection it results in a no-op since we check for cnxn.getState().isAlive() 
> which results in negative for auth failed state and we return without 
> cleaning up. For applications that retry in case of auth failed by closing 
> the existing connection and then trying to reconnect(eg. hbase replication) 
> this eventually ends up exhausting the system resources.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@anmolnar sure, thanks.
I will add tests. I prefer using Mockito in this case, it makes it clear 
that we are testing only a part of the class


---

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@eolivelli Sorry, my fault. I missed that your method is used from 
RemotePeerBeen too with the remote peer id. Which is fine.

Regarding unit testing.
- validate currentVote == null case
- validate id == getId() and id != getId() cases
Not sure if you have to use Moquito, because `QuorumPeer` has default 
constructor.


---

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[eolivelli]

Github user eolivelli commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197768825
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void 
testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
 InetSocketAddress peerCommunicationAddress = null;
 // Here peerCommunicationAddress is null, also clientAddr is null
 QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
-RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
+RemotePeerBean remotePeerBean = new RemotePeerBean(null 
/*QuorumPeer*/, peer);
--- End diff --

@ivankelly  @anmolnar I will be happy to follow the guidelines on ZK 
codebase, just tell me


---

[GitHub] zookeeper pull request #546: ZOOKEEPER-3066 Expose on JMX of Followers the i...

[ivankelly]

Github user ivankelly commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/546#discussion_r197768450
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void 
testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
 InetSocketAddress peerCommunicationAddress = null;
 // Here peerCommunicationAddress is null, also clientAddr is null
 QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
-RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
+RemotePeerBean remotePeerBean = new RemotePeerBean(null 
/*QuorumPeer*/, peer);
--- End diff --

Not everyone uses an IDE, and code review happens on github which doesn't 
give hints about this stuff.


---

ZooKeeper_branch35_jdk8 - Build # 1016 - Still Failing

[Apache Jenkins Server]

See https://builds.apache.org/job/ZooKeeper_branch35_jdk8/1016/

###
## LAST 60 LINES OF THE CONSOLE 
###
[...truncated 62.35 KB...]
[junit] Running org.apache.zookeeper.test.ServerCnxnTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.08 sec, Thread: 1, Class: org.apache.zookeeper.test.SaslSuperUserTest
[junit] Running org.apache.zookeeper.test.SessionInvalidationTest in thread 
1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.499 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionInvalidationTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
3.509 sec, Thread: 2, Class: org.apache.zookeeper.test.ServerCnxnTest
[junit] Running org.apache.zookeeper.test.SessionTest in thread 1
[junit] Running org.apache.zookeeper.test.SessionTimeoutTest in thread 2
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.475 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTimeoutTest
[junit] Running org.apache.zookeeper.test.SessionTrackerCheckTest in thread 
2
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.171 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionTrackerCheckTest
[junit] Running org.apache.zookeeper.test.SessionUpgradeTest in thread 2
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
131.97 sec, Thread: 3, Class: org.apache.zookeeper.test.RecoveryTest
[junit] Running org.apache.zookeeper.test.StandaloneTest in thread 3
[junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
13.814 sec, Thread: 1, Class: org.apache.zookeeper.test.SessionTest
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.789 sec, Thread: 3, Class: org.apache.zookeeper.test.StandaloneTest
[junit] Running org.apache.zookeeper.test.StatTest in thread 1
[junit] Running org.apache.zookeeper.test.StaticHostProviderTest in thread 3
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.267 sec, Thread: 1, Class: org.apache.zookeeper.test.StatTest
[junit] Running org.apache.zookeeper.test.StringUtilTest in thread 1
[junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
2.145 sec, Thread: 3, Class: org.apache.zookeeper.test.StaticHostProviderTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.073 sec, Thread: 1, Class: org.apache.zookeeper.test.StringUtilTest
[junit] Running org.apache.zookeeper.test.SyncCallTest in thread 3
[junit] Running org.apache.zookeeper.test.TruncateTest in thread 1
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.201 sec, Thread: 3, Class: org.apache.zookeeper.test.SyncCallTest
[junit] Running org.apache.zookeeper.test.WatchEventWhenAutoResetTest in 
thread 3
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
86.898 sec, Thread: 8, Class: org.apache.zookeeper.test.RestoreCommittedLogTest
[junit] Running org.apache.zookeeper.test.WatchedEventTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.179 sec, Thread: 8, Class: org.apache.zookeeper.test.WatchedEventTest
[junit] Running org.apache.zookeeper.test.WatcherFuncTest in thread 8
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
24.438 sec, Thread: 2, Class: org.apache.zookeeper.test.SessionUpgradeTest
[junit] Running org.apache.zookeeper.test.WatcherTest in thread 2
[junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
5.642 sec, Thread: 8, Class: org.apache.zookeeper.test.WatcherFuncTest
[junit] Running org.apache.zookeeper.test.X509AuthTest in thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
0.142 sec, Thread: 8, Class: org.apache.zookeeper.test.X509AuthTest
[junit] Running org.apache.zookeeper.test.ZkDatabaseCorruptionTest in 
thread 8
[junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.996 sec, Thread: 1, Class: org.apache.zookeeper.test.TruncateTest
[junit] Running org.apache.zookeeper.test.ZooKeeperQuotaTest in thread 1
[junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.33 sec, Thread: 3, Class: 
org.apache.zookeeper.test.WatchEventWhenAutoResetTest
[junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
1.174 sec, Thread: 1, Class: org.apache.zookeeper.test.ZooKeeperQuotaTest
[junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
21.994 sec, Thread: 8, Class: org.apache.zookeeper.test.ZkDatabaseCorruptionTest
[junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 
34.809 sec, Thread: 2, Class: org.apache.zookeeper.test.WatcherTest
   

[GitHub] zookeeper issue #546: ZOOKEEPER-3066 Expose on JMX of Followers the id of th...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/zookeeper/pull/546
  
@enixon @anmolnar
IMHO I answered to all of your questions



---

[jira] [Commented] (ZOOKEEPER-2407) EventThread in ClientCnxn can't be closed when SendThread exits because of auth failed during reconnection

[Andor Molnar (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16522131#comment-16522131
 ] 

Andor Molnar commented on ZOOKEEPER-2407:
-

Hi [~haitao-tony]

Do you think we can close this Jira, since the linked (which potentially 
duplicates this) has already been resolved?

> EventThread in ClientCnxn can't be closed when SendThread exits because of 
> auth failed during reconnection
> --
>
> Key: ZOOKEEPER-2407
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2407
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: sunhaitao
>Assignee: sunhaitao
>Priority: Major
> Fix For: 3.6.0, 3.5.5
>
> Attachments: zookeeper-2407.patch
>
>
> EventThread in ClientCnxn can't be closed when SendThread exits because of 
> auth failed during reconnection.
> for send thread if it is in authfailed state, the send thread exits,but the 
> event thread is still running.
> observation:
> use jstack tho check the thread running they find the send thread no longer 
> exists but event thread is still threre
> even when we call zookeeper.close(),the eventthread is still there.
> Stack trace: 
> sun.misc.Unsafe.park(Native Method)
> java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2039)
> java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:442)
> org.apache.zookeeper.ClientCnxn$EventThread.run(ClientCnxn.java:514)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

[anmolnar]

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/541
  
Committed to master and 3.5 branches. Thanks @abhishek-chouhan 



---

[jira] [Resolved] (ZOOKEEPER-3059) EventThread leak in case of Sasl AuthFailed

[Andor Molnar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andor Molnar resolved ZOOKEEPER-3059.
-
   Resolution: Fixed
Fix Version/s: 3.5.5
   3.6.0

Issue resolved by pull request 541
[https://github.com/apache/zookeeper/pull/541]

> EventThread leak in case of Sasl AuthFailed
> ---
>
> Key: ZOOKEEPER-3059
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3059
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.12
>Reporter: Abhishek Singh Chouhan
>Assignee: Abhishek Singh Chouhan
>Priority: Critical
>  Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Attachments: stack_dump
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> In case of an authFailed sasl event we shutdown the send thread however we 
> never close the event thread. Even if the client tries to close the 
> connection it results in a no-op since we check for cnxn.getState().isAlive() 
> which results in negative for auth failed state and we return without 
> cleaning up. For applications that retry in case of auth failed by closing 
> the existing connection and then trying to reconnect(eg. hbase replication) 
> this eventually ends up exhausting the system resources.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zookeeper pull request #541: ZOOKEEPER-3059 EventThread leak in case of Sasl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/541


---

Re: [VOTE] Apache ZooKeeper release 3.4.13 candidate 0

[Enrico Olivelli]

Il giorno sab 23 giu 2018 alle ore 00:31 Michael Han  ha
scritto:

> This is a bugfix release candidate for 3.4.13. It fixes 17 issues,
> including issues such as ZOOKEEPER-2959
>  that could cause
> data loss when observer is used, and ZOOKEEPER-2184
>  that prevents
> ZooKeeper Java clients working in dynamic IP (container / cloud)
> environment.
>
> The full release notes is available at:
>
> *
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12342973
> <
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12342973
> >*
>
> *** Please download, test and vote by June 27th 2018, 23:59 UTC+0. ***
>
> Source files:
> http://people.apache.org/~hanm/zookeeper/zookeeper-3.4.13-rc0/
>
> Maven staging repo:
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.4.13/
>
> The release candidate tag in git to be voted upon: release-3.4.13-rc0
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> http://www.apache.org/dist/zookeeper/KEYS
>
> Should we release this candidate?
>

+1 (non binding)
checked md5/sha1/signatures
built from source, run tests on Fedora 27 + Oracle JDK8

got a flaky test org.apache.zookeeper.server.quorum.QuorumPeerMainTest,
okay at second run

(I did not find how to run RAT)

Enrico



>
>
> Cheers
> Michael
>

[GitHub] zookeeper pull request #547: ZOOKEEPER-3068: Improve C client logging of IPv...

[nkalmar]

Github user nkalmar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/547#discussion_r197724069
  
--- Diff: src/c/src/zookeeper.c ---
@@ -4358,7 +4358,9 @@ static const char* format_endpoint_info(const struct 
sockaddr_storage* ep)
 {
 static char buf[128] = { 0 };
 char addrstr[128] = { 0 };
+const char *fmtstring;
 void *inaddr;
+int inet6 = 0;  // poor man's boolean
--- End diff --

Just a nitpick for future readability - Maybe just java speaking from me, 
but why not use some more clear name like is_inet6? 
(Or include stdbool) 


---

[GitHub] zookeeper issue #547: ZOOKEEPER-3068: Improve C client logging of IPv6 hosts

[nkalmar]

Github user nkalmar commented on the issue:

https://github.com/apache/zookeeper/pull/547
  
Tests timed out, probably Jenkins server were busy (and tests are flaky 
and/or integration tests rather then unit tests). 
Please re-run the jenkins build (an empty git commit --amend will do)


---

[GitHub] zookeeper issue #541: ZOOKEEPER-3059 EventThread leak in case of Sasl AuthFa...

[abhishek-chouhan]

Github user abhishek-chouhan commented on the issue:

https://github.com/apache/zookeeper/pull/541
  
Finally got a green build :)


---