Thank you guys
I have found another problem about fatjar.
There is a problem with apache rat check
This is the patch.
We are excluding one file from fatjar at the root pom, but it looks like
maven is going to execute rat even in fatjar module and this makes the
build fail.
I should also note that currently master branch is broken regarding all the
fatjar stuff, but there is a pending patch for it.
https://github.com/apache/zookeeper/pull/1325
use
git clean -xdf
mvn apache-rat:check -Pfull-build
in order to validate the repository (on master branch you will see that
fatjar is not taken into consideration)
I have also tried to enable rat on Jenkins but it looks like ASF jenkins
adds a '.repository" directory that makes rat fail.
We had "rat" check on Travis but is looks like Travis is not working, this
deserves investigation as well
Enrico
Il giorno sab 18 apr 2020 alle ore 19:17 Patrick Hunt ha
scritto:
> sg. Merged onto both. Thanks all!
>
> Patrick
>
> On Sat, Apr 18, 2020 at 10:08 AM Enrico Olivelli
> wrote:
>
> > Patrick,
> > Yes only to be merged to branch3.6 and release-3.6.1
> >
> > Thanks
> > Enrico
> >
> > Il Sab 18 Apr 2020, 18:25 Christopher ha scritto:
> >
> > > 3.6.1 and the 3.6 branch. PR #1314 has been updated to address the same
> > > issues and more for master/3.7
> > >
> > > On Sat, Apr 18, 2020, 11:47 Patrick Hunt wrote:
> > >
> > > > I can take a look. Does this need to go into just 3.6.1 or other
> > branches
> > > > as well? The JIRA says just 3.6.1,is that right?
> > > >
> > > > Patrick
> > > >
> > > > On Sat, Apr 18, 2020 at 6:02 AM Enrico Olivelli >
> > > > wrote:
> > > >
> > > > > PR is finally ready
> > > > > https://github.com/apache/zookeeper/pull/1323
> > > > >
> > > > > Looking for some committer to help me merge that patch
> > > > >
> > > > > Enrico
> > > > >
> > > > > Il giorno sab 18 apr 2020 alle ore 12:42 Enrico Olivelli <
> > > > > eolive...@gmail.com> ha scritto:
> > > > >
> > > > > > Thank you Christopher
> > > > > >
> > > > > > We are iterating over #1323.
> > > > > > I think we can finish the work today
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > > Il giorno sab 18 apr 2020 alle ore 09:39 Christopher <
> > > > > ctubb...@apache.org>
> > > > > > ha scritto:
> > > > > >
> > > > > >> +1 to that approach. I reviewed and made a suggestion on the PR
> at
> > > > > >> https://github.com/apache/zookeeper/pull/1323
> > > > > >>
> > > > > >> On Sat, Apr 18, 2020 at 3:16 AM Enrico Olivelli <
> > > eolive...@gmail.com>
> > > > > >> wrote:
> > > > > >> >
> > > > > >> > This is my patch.
> > > > > >> > Basically it adds back the fatjar module to the full-build
> > profile
> > > > > >> > this way we have only one profile that actually does the "full
> > > > build"
> > > > > =
> > > > > >> all
> > > > > >> > maven modules
> > > > > >> >
> > > > > >> > I feel this is a very clear way for users,
> > > > > >> > mvn clean package -Pfull-build
> > > > > >> > this builds the whole repository
> > > > > >> >
> > > > > >> > Enrico
> > > > > >> >
> > > > > >> > Il giorno sab 18 apr 2020 alle ore 08:28 Enrico Olivelli <
> > > > > >> > eolive...@gmail.com> ha scritto:
> > > > > >> >
> > > > > >> > > Hi,
> > > > > >> > > Branch-3.6 is broken due to the fatjat stuff
> > > > > >> > >
> > > > > >> > > [eolivelli@localhost zookeeper]$ mvn clean
> > -Pfull-build,fatjar
> > > > > >> > > [INFO] Scanning for projects...
> > > > > >> > > [ERROR] [ERROR] Project
> > > > > >> > >
> 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT'
> > > is
> > > > > >> > > duplicated in the reactor @
> > > > > >> > > [ERROR] Project
> > > > > >> > >
> 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT'
> > > is
> > > > > >> > > duplicated in the reactor -> [Help 1]
> > > > > >> > > [ERROR]
> > > > > >> > >
> > > > > >> > >
> > > > > >> > > I am preparing a fix
> > > > > >> > >
> > > > > >> > > Enrico
> > > > > >> > >
> > > > > >> > > Il giorno sab 18 apr 2020 alle ore 07:08 Enrico Olivelli <
> > > > > >> > > eolive...@gmail.com> ha scritto:
> > > > > >> > >
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >> Il Ven 17 Apr 2020, 08:50 Enrico Olivelli <
> > eolive...@gmail.com
> > > >
> > > > ha
> > > > > >> > >> scritto:
> > > > > >> > >>
> > > > > >> > >>> Thank you Christopher !
> > > > > >> > >>>
> > > > > >> > >>> I have manually fixed the pom.xml files in branch-3.6 and
> > > > > >> release-3.6.1
> > > > > >> > >>> branches.
> > > > > >> > >>>
> > > > > >> > >>> I would like to port ZOOKEEPER-3791 to branch-3.6 (that is
> > now
> > > > > >> > >>> 3.6.2-SNAPSHOT) and to 3.6.1 (that is now 3.6.1-SNAPSHOT)
> > > > > >> > >>>
> > > > > >> > >>
> > > > > >> > >> I will try to perform the release without ZOOKEEPER-3791
> > > > > >> > >>
> > > > > >> > >> Enrico
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>
> > > > > >> > >>> We need another binding +1 on ZOOKEEPER-3791, Benjamin
> Reed
> > > > > already
> > > > > >> > >>> started a review.
> > > > > >> > >>>
> > > > >
