[jira] [Created] (ZOOKEEPER-4775) Add a version of check_zookeeper that works with Python 3
Enrico Olivelli created ZOOKEEPER-4775: -- Summary: Add a version of check_zookeeper that works with Python 3 Key: ZOOKEEPER-4775 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4775 Project: ZooKeeper Issue Type: Improvement Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4735) set the RMI port to address issues with monitoring Zookeeper running in containers
Enrico Olivelli created ZOOKEEPER-4735: -- Summary: set the RMI port to address issues with monitoring Zookeeper running in containers Key: ZOOKEEPER-4735 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4735 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Enrico Olivelli Fix For: 3.10.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4676) ReadOnlyModeTest doesn't not compile on JDK20 (Thread.suspend has been removed)
Enrico Olivelli created ZOOKEEPER-4676: -- Summary: ReadOnlyModeTest doesn't not compile on JDK20 (Thread.suspend has been removed) Key: ZOOKEEPER-4676 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4676 Project: ZooKeeper Issue Type: Test Components: tests Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4675) Tests don't pass on JDK20: Thread.suspend is no more supported
Enrico Olivelli created ZOOKEEPER-4675: -- Summary: Tests don't pass on JDK20: Thread.suspend is no more supported Key: ZOOKEEPER-4675 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4675 Project: ZooKeeper Issue Type: Test Components: tests Reporter: Enrico Olivelli Fix For: 3.9.0, 3.8.2 This test doesn't pass on JDK20 [ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 86.683 s <<< FAILURE! - in org.apache.zookeeper.test.ReadOnlyModeTest [ERROR] testSeekForRwServer Time elapsed: 3.323 s <<< ERROR! java.lang.UnsupportedOperationException at java.base/java.lang.Thread.suspend(Thread.java:1865) at org.apache.zookeeper.test.ReadOnlyModeTest.testSeekForRwServer(ReadOnlyModeTest.java:303) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4674) C client tests don't pass on CI
Enrico Olivelli created ZOOKEEPER-4674: -- Summary: C client tests don't pass on CI Key: ZOOKEEPER-4674 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4674 Project: ZooKeeper Issue Type: Test Components: c client, tests Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4672) Code cleanup - apply JDK7 Diamond operator consistently
Enrico Olivelli created ZOOKEEPER-4672: -- Summary: Code cleanup - apply JDK7 Diamond operator consistently Key: ZOOKEEPER-4672 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4672 Project: ZooKeeper Issue Type: Task Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4669) Upgrade snappy-java to 1.1.9.1 (in order to support M1 macs)
Enrico Olivelli created ZOOKEEPER-4669: -- Summary: Upgrade snappy-java to 1.1.9.1 (in order to support M1 macs) Key: ZOOKEEPER-4669 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4669 Project: ZooKeeper Issue Type: Task Components: java client Reporter: Enrico Olivelli Fix For: 3.9.0, 3.7.2, 3.8.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4666) Fix license files for Netty: some files are for 4.1.76 and some other files are for 4.1.86
Enrico Olivelli created ZOOKEEPER-4666: -- Summary: Fix license files for Netty: some files are for 4.1.76 and some other files are for 4.1.86 Key: ZOOKEEPER-4666 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4666 Project: ZooKeeper Issue Type: Task Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4665) OWASP is failing on zooinspector due to some third party dependencies
Enrico Olivelli created ZOOKEEPER-4665:
--
Summary: OWASP is failing on zooinspector due to some third party
dependencies
Key: ZOOKEEPER-4665
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4665
Project: ZooKeeper
Issue Type: Task
Reporter: Enrico Olivelli
{code:java}
[ERROR] One or more dependencies were identified with vulnerabilities that have
a CVSS score greater than or equal to '0.0':
[ERROR]
[ERROR] apache-rat-tasks-0.6.jar: CVE-2020-22475(6.8), CVE-2022-39349(5.5)
[ERROR] commons-collections-3.2.jar: CVE-2015-6420(7.5)
[ERROR] guava-18.0.jar: CVE-2020-8908(3.3), CVE-2018-10237(5.9)
[ERROR]
[ERROR] See the dependency-check report for more details.
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4664) OWASP is failing on zookeeper zookeeper-contrib-rest due to some third party deopendencies
Enrico Olivelli created ZOOKEEPER-4664:
--
Summary: OWASP is failing on zookeeper zookeeper-contrib-rest due
to some third party deopendencies
Key: ZOOKEEPER-4664
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4664
Project: ZooKeeper
Issue Type: Task
Reporter: Enrico Olivelli
{code:java}
[ERROR] One or more dependencies were identified with vulnerabilities that have
a CVSS score greater than or equal to '0.0':
[ERROR]
[ERROR] grizzly-utils-1.9.8.jar: CVE-2014-0099(4.3), CVE-2021-4277(5.3)
[ERROR] jersey-core-1.1.5.1.jar: CVE-2014-3643(7.5)
[ERROR] jettison-1.1.jar: CVE-2022-40149(7.5), CVE-2022-45693(7.5),
CVE-2022-40150(7.5), CVE-2022-45685(7.5)
[ERROR]
[ERROR] See the dependency-check report for more details.
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4663) OWASP is failing on loggraph due to yui-min.js: CVE-2013-4940, CVE-2013-4939
Enrico Olivelli created ZOOKEEPER-4663: -- Summary: OWASP is failing on loggraph due to yui-min.js: CVE-2013-4940, CVE-2013-4939 Key: ZOOKEEPER-4663 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4663 Project: ZooKeeper Issue Type: Task Components: contrib Reporter: Enrico Olivelli https://nvd.nist.gov/vuln/detail/CVE-2013-4939 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4662) OWASP is failing on the zookeeper-it module due to JUnit CVEs
Enrico Olivelli created ZOOKEEPER-4662:
--
Summary: OWASP is failing on the zookeeper-it module due to JUnit
CVEs
Key: ZOOKEEPER-4662
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4662
Project: ZooKeeper
Issue Type: Test
Components: tests
Affects Versions: 3.8.0
Reporter: Enrico Olivelli
Fix For: 3.9.0, 3.8.1, 3.7.2
{code:java}
[ERROR] One or more dependencies were identified with vulnerabilities that have
a CVSS score greater than or equal to '0.0':
[ERROR]
[ERROR] junit-4.13.jar: CVE-2020-15250(5.5)
[ERROR] junit-platform-engine-1.6.2.jar: CVE-2022-31514(9.3)
[ERROR]
[ERROR] See the dependency-check report for more details.
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4661) Upgrade Jackson Databind to 2.13.4.2 for CVE-2022-42003 CVE-2022-42004
Enrico Olivelli created ZOOKEEPER-4661: -- Summary: Upgrade Jackson Databind to 2.13.4.2 for CVE-2022-42003 CVE-2022-42004 Key: ZOOKEEPER-4661 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4661 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4660) Suppress false positive OWASP failure for CVE-2021-37533
Enrico Olivelli created ZOOKEEPER-4660: -- Summary: Suppress false positive OWASP failure for CVE-2021-37533 Key: ZOOKEEPER-4660 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4660 Project: ZooKeeper Issue Type: Improvement Reporter: Enrico Olivelli OWAPS reports a failure against CVE-2021-37533 for apache commons-io-2.11.0. The CVE is for commons-net, not used by ZooKeeper -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4659) Upgrade Commons CLI to 1.5.0 due to OWASP failing on 1.4 CVE-2021-37533
Enrico Olivelli created ZOOKEEPER-4659: -- Summary: Upgrade Commons CLI to 1.5.0 due to OWASP failing on 1.4 CVE-2021-37533 Key: ZOOKEEPER-4659 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4659 Project: ZooKeeper Issue Type: Improvement Components: tools Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4656) Allow ZooKeeperAdmin creation with custom HostProvider
Enrico Olivelli created ZOOKEEPER-4656: -- Summary: Allow ZooKeeperAdmin creation with custom HostProvider Key: ZOOKEEPER-4656 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4656 Project: ZooKeeper Issue Type: New Feature Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4655) Communicate the Zxid that triggered a WatchEvent to fire
Enrico Olivelli created ZOOKEEPER-4655: -- Summary: Communicate the Zxid that triggered a WatchEvent to fire Key: ZOOKEEPER-4655 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4655 Project: ZooKeeper Issue Type: New Feature Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4647) Tests don't pass on JDK20 because we try to mock InetAddress
Enrico Olivelli created ZOOKEEPER-4647: -- Summary: Tests don't pass on JDK20 because we try to mock InetAddress Key: ZOOKEEPER-4647 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4647 Project: ZooKeeper Issue Type: Test Reporter: Enrico Olivelli This test fails on JDK20-Ea org.apache.zookeeper.test.StaticHostProviderTest.testEmptyResolution Mockito cannot mock this class: class java.net.InetAddress. Mockito can only mock non-private & non-final classes. If you're not sure why you're getting this error, please report to the mailing list. if I try to upgrade Mockito to 4.9.0 the error is org.mockito.exceptions.base.MockitoException: Cannot mock/spy class java.net.InetAddress Mockito cannot mock/spy because : - sealed class at org.apache.zookeeper.test.StaticHostProviderTest.testReResolvingSingle(StaticHostProviderTest.jav -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4642) Remove Travis CI
Enrico Olivelli created ZOOKEEPER-4642: -- Summary: Remove Travis CI Key: ZOOKEEPER-4642 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4642 Project: ZooKeeper Issue Type: Task Components: build-infrastructure Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.9.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4641) GH CI fails with 'error: implicit declaration of function ‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Enrico Olivelli created ZOOKEEPER-4641:
--
Summary: GH CI fails with 'error: implicit declaration of function
‘FIPS_mode’ [-Werror=implicit-function-declaration]'
Key: ZOOKEEPER-4641
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4641
Project: ZooKeeper
Issue Type: Task
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
CI is failing with this error
{code:java}
[exec]
/home/runner/work/zookeeper/zookeeper/zookeeper-client/zookeeper-client-c/src/zookeeper.c:
In function ‘init_ssl_for_socket’:1243 [exec]
/home/runner/work/zookeeper/zookeeper/zookeeper-client/zookeeper-client-c/src/zookeeper.c:2754:13:
error: implicit declaration of function ‘FIPS_mode’
[-Werror=implicit-function-declaration]1244 [exec] 2754 | if (FIPS_mode()
== 0) {1245 [exec] | ^1246 [exec] cc1: all warnings being
treated as errors {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4640) C client: change the filename from `libzookeeper_mt.so.2` to `libzookeeper_mt-3.8.0.so.2
Enrico Olivelli created ZOOKEEPER-4640: -- Summary: C client: change the filename from `libzookeeper_mt.so.2` to `libzookeeper_mt-3.8.0.so.2 Key: ZOOKEEPER-4640 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4640 Project: ZooKeeper Issue Type: Improvement Components: c client Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4636) Fix zkServer.sh for AIX
Enrico Olivelli created ZOOKEEPER-4636: -- Summary: Fix zkServer.sh for AIX Key: ZOOKEEPER-4636 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4636 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.9.0, 3.8.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (ZOOKEEPER-4551) Do not log spammy stacktrace when a client closes its connection
Enrico Olivelli created ZOOKEEPER-4551:
--
Summary: Do not log spammy stacktrace when a client closes its
connection
Key: ZOOKEEPER-4551
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4551
Project: ZooKeeper
Issue Type: Improvement
Components: server
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Currently (3.8, but this has always been happening IIRC), the server logs a
scary stacktrace when a client closes its connection.
This is not something the administrator should be afraid of, so we should not
write the stacktrace on the logs.
{code:java}
2022-05-31T08:55:22,205+ [NIOWorkerThread-1] WARN
org.apache.zookeeper.server.NIOServerCnxn - Unexpected exception
│
│ org.apache.zookeeper.server.ServerCnxn$EndOfStreamException: Unable to read
additional data from client, it probably closed the socket: address =
/10.44.1.5:43468, session = 0x12ec7a30032 │
│ at
org.apache.zookeeper.server.NIOServerCnxn.handleFailedRead(NIOServerCnxn.java:170)
~[org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]
│
│ at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:333)
[org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]
│
│ at
org.apache.zookeeper.server.NIOServerCnxnFactory$IOWorkRequest.doWork(NIOServerCnxnFactory.java:508)
[org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]
│
│ at
org.apache.zookeeper.server.WorkerService$ScheduledWorkRequest.run(WorkerService.java:153)
[org.apache.zookeeper-zookeeper-3.8.0.jar:3.8.0]
{code}
│
│ at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
[?:?]
│
│ at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
[?:?]
│
│ at java.lang.Thread.run(Thread.java:829) [?:?]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (ZOOKEEPER-4483) C Client: Document dependencies needed on Ubuntu
Enrico Olivelli created ZOOKEEPER-4483:
--
Summary: C Client: Document dependencies needed on Ubuntu
Key: ZOOKEEPER-4483
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4483
Project: ZooKeeper
Issue Type: Task
Components: c client
Reporter: Enrico Olivelli
Every time I try to build the C client on a fresh new Ubuntu machine I waste
lot of time in figuring out the list of dependencies.
This is the command that allows me to run correctly the C Client build and
tests:
{code:java}
sudo apt-get install libcppunit-dev libsasl2-dev automake autoconf
pkg-config{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4482) Fix name of commons-io LICENSE file
Enrico Olivelli created ZOOKEEPER-4482: -- Summary: Fix name of commons-io LICENSE file Key: ZOOKEEPER-4482 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4482 Project: ZooKeeper Issue Type: Task Components: license Reporter: Enrico Olivelli Fix For: 3.8.1, 3.7.1, 3.6.4 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4479) Tests: C client test TestOperations.cc is very flaky on CI
Enrico Olivelli created ZOOKEEPER-4479: -- Summary: Tests: C client test TestOperations.cc is very flaky on CI Key: ZOOKEEPER-4479 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4479 Project: ZooKeeper Issue Type: Task Components: c client, tests Reporter: Enrico Olivelli This test is very annoying on CI. it is not using the real Java server and it fails very often [exec] /home/runner/work/zookeeper/zookeeper/zookeeper-client/zookeeper-client-c/tests/TestOperations.cc:296: Assertion: equality assertion failed [Expected: 1, Actual : 0] -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4478) Suppress OWASP false positives zookeeper-jute-3.8.0-SNAPSHOT.jar: CVE-2021-29425, CVE-2021-28164, CVE-2021-34429
Enrico Olivelli created ZOOKEEPER-4478:
--
Summary: Suppress OWASP false positives
zookeeper-jute-3.8.0-SNAPSHOT.jar: CVE-2021-29425, CVE-2021-28164,
CVE-2021-34429
Key: ZOOKEEPER-4478
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4478
Project: ZooKeeper
Issue Type: Task
Reporter: Enrico Olivelli
Fix For: 3.8.0, 3.7.1, 3.6.4
While preparing a new RC for 3.8.0 today the OWASP checker started to report
locally (not on jenkins) these errors:
{code:java}
[ERROR] One or more dependencies were identified with vulnerabilities that have
a CVSS score greater than or equal to '0.0':
[ERROR]
[ERROR] zookeeper-jute-3.8.0-SNAPSHOT.jar: CVE-2021-29425, CVE-2021-28164,
CVE-2021-34429
[ERROR]
[ERROR] See the dependency-check report for more details.
[ERROR]
{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4469) Suppress OWASP false positives related to Netty TCNative
Enrico Olivelli created ZOOKEEPER-4469:
--
Summary: Suppress OWASP false positives related to Netty TCNative
Key: ZOOKEEPER-4469
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4469
Project: ZooKeeper
Issue Type: Task
Components: build
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.8.0, 3.7.1, 3.6.4
OWASP check is reporting this CVEs against netty-tcnative-2.0.48.Final
Those are not problems that affect ZooKeeper, we can exclude them
{code:java}
[ERROR] One or more dependencies were identified with vulnerabilities that have
a CVSS score greater than or equal to '0.0':
[ERROR]
[ERROR] netty-tcnative-2.0.48.Final.jar: CVE-2021-43797, CVE-2019-16869,
CVE-2015-2156, CVE-2021-37136, CVE-2014-3488, CVE-2021-37137, CVE-2019-20445,
CVE-2019-20444, CVE-2021-21295, CVE-2021-21409, CVE-2021-21290
{code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4462) Upgrade Netty TCNative to 2.0.48
Enrico Olivelli created ZOOKEEPER-4462:
--
Summary: Upgrade Netty TCNative to 2.0.48
Key: ZOOKEEPER-4462
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4462
Project: ZooKeeper
Issue Type: Improvement
Reporter: Enrico Olivelli
The OWASP checker fails m we should upgrade to the latest version
[|https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-multi-branch-owasp/detail/master/162/pipeline#step-35-log-562]
{code:java}
[2022-01-28T09:07:39.858Z] One or more dependencies were identified with known
vulnerabilities in Apache ZooKeeper - Server:
[2022-01-28T09:07:39.859Z] netty-tcnative-classes-2.0.46.Final.jar
(pkg:maven/io.netty/netty-tcnative-classes@2.0.46.Final,
cpe:2.3:a:netty:netty:2.0.46:*:*:*:*:*:*:*) : CVE-2014-3488, CVE-2015-2156,
CVE-2019-16869, CVE-2019-20444, CVE-2019-20445, CVE-2021-21290, CVE-2021-21295,
CVE-2021-21409, CVE-2021-37136, CVE-2021-37137, CVE-2021-43797{code}
[|https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-multi-branch-owasp/detail/master/162/pipeline#step-35-log-565][2022-01-28T09:07:39.859Z]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4455) Move to https://reload4j.qos.ch/ (remove log4j1)
Enrico Olivelli created ZOOKEEPER-4455: -- Summary: Move to https://reload4j.qos.ch/ (remove log4j1) Key: ZOOKEEPER-4455 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4455 Project: ZooKeeper Issue Type: Improvement Components: server Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.7.1, 3.6.4 [https://reload4j.qos.ch/] is a 100% compatible replacement for log4j1 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4454) Upgrade Netty to 4.1.73
Enrico Olivelli created ZOOKEEPER-4454: -- Summary: Upgrade Netty to 4.1.73 Key: ZOOKEEPER-4454 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4454 Project: ZooKeeper Issue Type: Improvement Components: java client, server Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.8.0, 3.7.1, 3.6.4 Update Netty to get rid of CVEs -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4453) NettyServerCnxcFactory: allow to configure the early TLS connection drop feature
Enrico Olivelli created ZOOKEEPER-4453: -- Summary: NettyServerCnxcFactory: allow to configure the early TLS connection drop feature Key: ZOOKEEPER-4453 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4453 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.6.3 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.8.0, 3.7.1, 3.6.4 Follow up of ZOOKEEPER-3988. We should introduce a flag to disable the feature introduced by ZOOKEEPER-3682. *Implementation* * Add new flag netty.server.earlyDropSecureConnectionHandshakes to control the ZOOKEEPER-3682 feature. * Disable ZOOKEEPER-3682 by default, it is advanced feature, for very large clusters * Add docs * Add tests (also ZOOKEEPER-3682 missed tests, now we will have some) -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (ZOOKEEPER-4382) Update Maven Bundle Plugin in order to allow builds on JDK18
Enrico Olivelli created ZOOKEEPER-4382: -- Summary: Update Maven Bundle Plugin in order to allow builds on JDK18 Key: ZOOKEEPER-4382 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4382 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.8.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.8.0 On JDK8 zookeeper build fails with a ConcurrentModificationException. The fix is to update the plugin to the latest version [ERROR] Failed to execute goal org.apache.felix:maven-bundle-plugin:4.1.0:bundle (build bundle) on project zookeeper-jute: Execution build bundle of goal org.apache.felix:maven-bundle-plugin:4.1.0:bundle failed.: ConcurrentModificationException -> [Help 1]org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.felix:maven-bundle-plugin:4.1.0:bundle (build bundle) on project zookeeper-jute: Execution build bundle of goal org.apache.felix:maven-bundle-plugin:4.1.0:bundle failed. at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117) at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81) at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305) at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105) at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957) at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289) at org.apache.maven.cli.MavenCli.main (MavenCli.java:193) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method) at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77) at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke (Method.java:568) at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282) at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225) at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406) at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347) Caused by: org.apache.maven.plugin.PluginExecutionException: Execution build bundle of goal org.apache.felix:maven-bundle-plugin:4.1.0:bundle failed. at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:148) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:210) at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4333) QuorumSSLTest - testOCSP fails on JDK17
Enrico Olivelli created ZOOKEEPER-4333: -- Summary: QuorumSSLTest - testOCSP fails on JDK17 Key: ZOOKEEPER-4333 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4333 Project: ZooKeeper Issue Type: Test Components: security, tests Affects Versions: 3.6.2 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.8.0, 3.7.1 On JDK17 (early access) QuorumSSLTest#tetOCSP fails because with JDK17 the TLS client is sending a OCSP request as GET on the URI. Previously the OCSP request was send inside the BODY of the HTTP request. In order to fix the test we have to fix our mock HTTP OCSP server (that is part of the test suite, it is not zookeeper server code) in order to handle this case. For reference: https://it.wikipedia.org/wiki/Online_Certificate_Status_Protocol -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4315) Fix NOTICE file in the source distribution
Enrico Olivelli created ZOOKEEPER-4315: -- Summary: Fix NOTICE file in the source distribution Key: ZOOKEEPER-4315 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4315 Project: ZooKeeper Issue Type: Improvement Components: license Affects Versions: 3.6.2 Reporter: Enrico Olivelli Fix For: 3.8.0, 3.7.1, 3.6.4 [~jmclean] kindly reported on the dev@ mailing lit that we should cite this files in the NOTICE file we distribute with the Source distribution These BSD licensed files: ./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable.c ./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable.h ./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable_itr.c ./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable_itr.h ./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable_private.h This MIT licensed file: ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/date.format.js This MIT licensed files: ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/g.bar.js ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/g.dot.js ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/g.line.js ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/g.pie.js ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/g.raphael.js This MIT licensed file ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/raphael.js This BSD licensed file: ./zookeeper-contrib/zookeeper-contrib-loggraph/src/main/resources/webapp/org/apache/zookeeper/graph/resources/yui-min.js This Apache 2.0 licensed file: ./zookeeper-contrib/zookeeper-contrib-zooinspector/src/main/java/com/nitido/utils/toaster/Toaster.java This MIT licensed file: ./zookeeper-docs/src/main/resources/markdown/skin/prototype.js Please note that I may not have found all the 3rd party files in the source release. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4312) ZooKeeperServerEmbedded: enhance server start/stop for testability
Enrico Olivelli created ZOOKEEPER-4312: -- Summary: ZooKeeperServerEmbedded: enhance server start/stop for testability Key: ZOOKEEPER-4312 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4312 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.7.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli ZooKeeperServerEmbedded works well for running ZooKeeper but it lacks support for a few little features in order to use it for tests. I saw these problems while working on the port of Curator Testing Server to ZooKeeperServerEmbedded. * There is no wait to wait for the server to be up-and-running * When you "close()" the server, it does not wait for the ports to be closed * There is no wait to have the ConnectString for the server -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4228) ZooKeeper Server/Client Add option to not display system environment
Enrico Olivelli created ZOOKEEPER-4228: -- Summary: ZooKeeper Server/Client Add option to not display system environment Key: ZOOKEEPER-4228 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4228 Project: ZooKeeper Issue Type: Wish Components: java client, server Reporter: Enrico Olivelli Assignee: Enrico Olivelli Sometimes, especially while running tests of downstream applications, but also in command line tools, it is pretty annoying to see the ZooKeeper that prints out system information. In order to turn it off you have to make explicit configuration of the logging system. It would be nice to have a system property to hide this log -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-4048) Upgrade Mockito to 3.6.28 - allow builds on JDK16
Enrico Olivelli created ZOOKEEPER-4048: -- Summary: Upgrade Mockito to 3.6.28 - allow builds on JDK16 Key: ZOOKEEPER-4048 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4048 Project: ZooKeeper Issue Type: Improvement Components: tests Affects Versions: 3.7.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.7.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3980) Fix Jenkinsfiles with new tool names
Enrico Olivelli created ZOOKEEPER-3980: -- Summary: Fix Jenkinsfiles with new tool names Key: ZOOKEEPER-3980 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3980 Project: ZooKeeper Issue Type: Task Components: build-infrastructure Affects Versions: 3.7.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.7.0 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3931) "zkServer.sh version" returns a trailing dash
Enrico Olivelli created ZOOKEEPER-3931:
--
Summary: "zkServer.sh version" returns a trailing dash
Key: ZOOKEEPER-3931
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3931
Project: ZooKeeper
Issue Type: Bug
Reporter: Enrico Olivelli
When you run zkServer.sh version the result includes a few spam lines and the
version reports a trailing dash
{noformat}
bin/zkServer.sh version
ZooKeeper JMX enabled by default
Using config: /xxx/bin/../conf/zoo.cfg
Apache ZooKeeper, version 3.6.2- 09/04/2020 12:44 GMT
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3925) Update Netty to 4.1.50Final on 3.5 branch
Enrico Olivelli created ZOOKEEPER-3925: -- Summary: Update Netty to 4.1.50Final on 3.5 branch Key: ZOOKEEPER-3925 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3925 Project: ZooKeeper Issue Type: Task Components: license Affects Versions: 3.6.2 Reporter: Patrick D. Hunt Assignee: Enrico Olivelli Fix For: 3.6.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3924) Netty and JLine Licenses are inconsistent with jars in the binary tarball in 3.6.2 rc0
Enrico Olivelli created ZOOKEEPER-3924: -- Summary: Netty and JLine Licenses are inconsistent with jars in the binary tarball in 3.6.2 rc0 Key: ZOOKEEPER-3924 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3924 Project: ZooKeeper Issue Type: Task Components: license Affects Versions: 3.6.2 Reporter: Patrick D. Hunt Assignee: Enrico Olivelli Fix For: 3.6.2 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3895) Client side NullPointerException in case of empty Multi operation
Enrico Olivelli created ZOOKEEPER-3895:
--
Summary: Client side NullPointerException in case of empty Multi
operation
Key: ZOOKEEPER-3895
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3895
Project: ZooKeeper
Issue Type: Improvement
Components: java client
Affects Versions: 3.6.1
Reporter: Enrico Olivelli
I saw this error in an application that uses Apache BookKeeper DistributedLog
library.
The bug is in ZooKeeper Java Client.
{code:java}
Caused by: java.lang.NullPointerExceptionCaused by:
java.lang.NullPointerException at
org.apache.zookeeper.ZooKeeper.multiInternal(ZooKeeper.java:2105) at
org.apache.zookeeper.ZooKeeper.multi(ZooKeeper.java:2050) at
org.apache.bookkeeper.zookeeper.ZooKeeperClient.access$1101(ZooKeeperClient.java:70)
at
org.apache.bookkeeper.zookeeper.ZooKeeperClient$3.zkRun(ZooKeeperClient.java:498)
at
org.apache.bookkeeper.zookeeper.ZooKeeperClient$ZkRetryRunnable.run(ZooKeeperClient.java:389)
at
org.apache.bookkeeper.zookeeper.ZooKeeperClient.multi(ZooKeeperClient.java:510)
at org.apache.distributedlog.zk.ZKTransaction.execute(ZKTransaction.java:67) at
org.apache.distributedlog.BKLogWriteHandler.setLogSegmentTruncationStatus(BKLogWriteHandler.java:1223)
at
org.apache.distributedlog.BKLogWriteHandler.setLogSegmentsOlderThanDLSNTruncated(BKLogWriteHandler.java:1117)
at
org.apache.distributedlog.BKLogWriteHandler.lambda$setLogSegmentsOlderThanDLSNTruncated$0(BKLogWriteHandler.java:1083)
at
java.base/java.util.concurrent.CompletableFuture.uniComposeStage(CompletableFuture.java:1183)
at
java.base/java.util.concurrent.CompletableFuture.thenCompose(CompletableFuture.java:2299)
at
org.apache.distributedlog.BKLogWriteHandler.setLogSegmentsOlderThanDLSNTruncated(BKLogWriteHandler.java:1082)
at
org.apache.distributedlog.BKAsyncLogWriter.truncate(BKAsyncLogWriter.java:449){code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3874) Official API to start ZooKeeper server from Java
Enrico Olivelli created ZOOKEEPER-3874: -- Summary: Official API to start ZooKeeper server from Java Key: ZOOKEEPER-3874 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3874 Project: ZooKeeper Issue Type: New Feature Components: server Affects Versions: 3.6.1 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.7.0 We want to introduce a new API to boot a ZooKeeper server node from Java. Currently (up to 3.6.1) we are distributing a tarball that contains binaries and bash scripts to launch the server. We are also deploying to Maven central the zookeeper-server jar that contains the server side code together with the java client code. People are used to use that Jar to start the ZooKeeper server inside a Java process. Two use cases: * run tests of applications based on ZooKeeper (like Curator TestingServer) * launch ZooKeeper with some Java based process management system Currently such applications that want to run ZooKeeper server use internal code, in the most fancy ways, in order to setup something that 'works'. This is very error prone because ZooKeeper server internals change from version to version, because the only contracts are the configuration file format and the wire protocols (client-server and server-server). With this new feature we want to define a stable API that allows: * to configure and start a ZooKeeper server (standalone or cluster) * stop it gracefully (even if the suggested way to stop ZooKeeper is to use "kill -9") * check that the server is alive * configure the MetricsProvider instance to use (in order to integrate better with the metrics system provided by the runtime environment) The configuration will be passed as a java.util.Properties object or a Java File (or Path) object. In is out of scope to support Java applications that embed ZooKeeper server and use the ZooKeeper client, this is not a good idea and it must not be suggested. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3802) RAT check fails on fatjar module
Enrico Olivelli created ZOOKEEPER-3802: -- Summary: RAT check fails on fatjar module Key: ZOOKEEPER-3802 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3802 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.1 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3797) Conflict between fatjar and full-build Maven profiles in branch-3.6
Enrico Olivelli created ZOOKEEPER-3797:
--
Summary: Conflict between fatjar and full-build Maven profiles in
branch-3.6
Key: ZOOKEEPER-3797
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3797
Project: ZooKeeper
Issue Type: Bug
Components: build
Affects Versions: 3.6.1
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.1
fatjat and full-build profiles conflict, because both enable the fatjar module.
but with full-build the fatjar is not actually built.
This is an example of error
{code:java}
[eolivelli@localhost zookeeper]$ mvn clean -Pfull-build,fatjar
[INFO] Scanning for projects...
[ERROR] [ERROR] Project
'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT' is duplicated in
the reactor @
[ERROR] Project 'org.apache.zookeeper:zookeeper-contrib-fatjar:3.6.1-SNAPSHOT'
is duplicated in the reactor -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, pl
{code}
The minimal fix is to enable fatjar even with full-build profile.
The full-build profile is meant to build all of the modules, and it is used
during the release process as well
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3785) Make sources buildable with JDK14
Enrico Olivelli created ZOOKEEPER-3785: -- Summary: Make sources buildable with JDK14 Key: ZOOKEEPER-3785 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3785 Project: ZooKeeper Issue Type: Improvement Components: build Affects Versions: 3.5.7 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.7.0, 3.6.1, 3.5.8 JDK14 adds java.lang.Record and so Jute generated files need an explicit import of Jute Record class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3763) Restore ZKUtil.deleteRecursive in order to help compatibility of applications with 3.5 and 3.6
Enrico Olivelli created ZOOKEEPER-3763: -- Summary: Restore ZKUtil.deleteRecursive in order to help compatibility of applications with 3.5 and 3.6 Key: ZOOKEEPER-3763 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3763 Project: ZooKeeper Issue Type: Wish Components: java client Affects Versions: 3.6.0 Reporter: Enrico Olivelli In HerdDB project (https://github.com/diennea/herddb) we are using BookKeeper that in turn uses ZKUtil.deleteRecursive. This is the issue on BookKeeper https://github.com/apache/bookkeeper/issues/2292 This is the error: java.lang.NoSuchMethodError: org.apache.zookeeper.ZKUtil.deleteRecursive(Lorg/apache/zookeeper/ZooKeeper;Ljava/lang/String;)V Apart from trying to fix BookKeeper, we should take into consideration to restore that signature (adding some dummy method that calls the new one) in order to ease adoption of ZooKeeper 3.6.x In fact it is very common that an application uses multiple ZooKeeper based libraries, like HBase, BookKeeper, Pulsar, Kafka...and the user cannot upgrade to 3.6 until every other dependency is able to work with 3.6.0. If the fix is easy, like in this case, it is worth to help the community -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3733) Fix issues reported in 3.6.0rc3
Enrico Olivelli created ZOOKEEPER-3733: -- Summary: Fix issues reported in 3.6.0rc3 Key: ZOOKEEPER-3733 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3733 Project: ZooKeeper Issue Type: Task Reporter: Enrico Olivelli -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3695) Source release tarball does not match repository in 3.6.0
Enrico Olivelli created ZOOKEEPER-3695: -- Summary: Source release tarball does not match repository in 3.6.0 Key: ZOOKEEPER-3695 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3695 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 During the release of 3.6.0, rc0, I noticed that the source tarball differs from the repository: - there is no "dev/docker" directory (so we are missing a part of the codebase, even this is not so important) - there is no "zookeeper-metrics-providers" directory (so the project is not buildable) - the c client directory contains temporary files (so we are including 'binaries') - -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3668) Clean up release package for 3.6.0
Enrico Olivelli created ZOOKEEPER-3668: -- Summary: Clean up release package for 3.6.0 Key: ZOOKEEPER-3668 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3668 Project: ZooKeeper Issue Type: Task Components: license, build Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 At git sha 034bcda589ae9d64ab3467b254179ed37f9b1635 we have the following issues regarding packaging and licensing. - there is no "LICENSE" file for snappy and for metrics-core - we need to update the copyright year in NOTICE files - we need to copy the Airlift reference from NOTICE in the source root to the NOTICE file reported in the binary package -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3635) Use Docker and Maven Release Plugin to prepare ZooKeeper releases
Enrico Olivelli created ZOOKEEPER-3635: -- Summary: Use Docker and Maven Release Plugin to prepare ZooKeeper releases Key: ZOOKEEPER-3635 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3635 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 In 3.5.5 and 3.5.6 we followed a new release procedure based on Maven: [https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease+using+maven] That procedure needed some "manual" parts to change the project version inside pom files and also inside the sources of the C Client. We can automate more and more in order to make the release procedure mostly automatic. We should also use 'docker' in order to have a reproducible build environment, expectially for the 'convenience binaries': * Java version (we want to build the project with Java 8 in 3.6.0) * C client (tools, system headers and openssl version) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3620) Do not use System.exit in server side code
Enrico Olivelli created ZOOKEEPER-3620: -- Summary: Do not use System.exit in server side code Key: ZOOKEEPER-3620 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3620 Project: ZooKeeper Issue Type: Improvement Components: server, tests Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 Using System.exit crashed the JVM and this is very annoying for: * ZooKeeper own server side tests * Tests of downstream applications -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3552) Source tarbal for branch-3.5 does not set execution permissions to "configure" file
Enrico Olivelli created ZOOKEEPER-3552: -- Summary: Source tarbal for branch-3.5 does not set execution permissions to "configure" file Key: ZOOKEEPER-3552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3552 Project: ZooKeeper Issue Type: Bug Components: build, c client Affects Versions: 3.5.6 Reporter: Enrico Olivelli Fix For: 3.5.6 During the Rc0 VOTE of 3.5.6 we found that the 'configure' file inside the source tarball does not have the right permissions. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZOOKEEPER-3545) Fix LICENSE files for netty dependency
Enrico Olivelli created ZOOKEEPER-3545: -- Summary: Fix LICENSE files for netty dependency Key: ZOOKEEPER-3545 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3545 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.0, 3.5.6 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0, 3.5.6 We have to fix LICENSE files because in 3.5.5 we have netty-all in 3.5.6 we have multiple netty files. Our current LICENSE files layout is to have one file per each JAR in "lib" -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (ZOOKEEPER-3542) X509UtilTest#testClientRenegotiationFails is flay on JDK8 + linux on machines with 2 cores
Enrico Olivelli created ZOOKEEPER-3542: -- Summary: X509UtilTest#testClientRenegotiationFails is flay on JDK8 + linux on machines with 2 cores Key: ZOOKEEPER-3542 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3542 Project: ZooKeeper Issue Type: Test Components: build, tests Affects Versions: 3.5.5 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.5.6 On this Fedora machine: [eolivelli@localhost zookeeper-server]$ uname -a Linux localhost.localdomain 5.2.9-200.fc30.x86_64 #1 SMP Fri Aug 16 21:37:45 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux [eolivelli@localhost zookeeper-server]$ mvn -v Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T17:06:16+02:00) Maven home: /home/eolivelli/Scaricati/maven Java version: 1.8.0_222, vendor: AdoptOpenJDK, runtime: /home/eolivelli/dev/jdk8u222-b10/jre Default locale: it_IT, platform encoding: UTF-8 OS name: "linux", version: "5.2.9-200.fc30.x86_64", arch: "amd64", family: "unix" [eolivelli@localhost zookeeper-server]$ cat /proc/cpuinfo processor : 0 vendor_id : AuthenticAMD cpu family : 21 model : 112 model name : AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G stepping: 0 microcode : 0x6006704 cpu MHz : 1444.800 cache size : 1024 KB physical id : 0 siblings: 2 core id : 0 cpu cores : 2 apicid : 16 initial apicid : 0 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm perfctr_core perfctr_nb bpext ptsc mwaitx cpb hw_pstate ssbd vmmcall fsgsbase bmi1 avx2 smep bmi2 xsaveopt arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif overflow_recov bugs: fxsave_leak sysret_ss_attrs null_seg spectre_v1 spectre_v2 spec_store_bypass bogomips: 5789.50 TLB size: 1536 4K pages clflush size: 64 cache_alignment : 64 address sizes : 48 bits physical, 48 bits virtual power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro acc_power [13] processor : 1 vendor_id : AuthenticAMD cpu family : 21 model : 112 model name : AMD A9-9410 RADEON R5, 5 COMPUTE CORES 2C+3G stepping: 0 microcode : 0x6006704 cpu MHz : 1483.889 cache size : 1024 KB physical id : 0 siblings: 2 core id : 1 cpu cores : 2 apicid : 17 initial apicid : 1 fpu : yes fpu_exception : yes cpuid level : 13 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good acc_power nopl nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs xop skinit wdt lwp fma4 tce nodeid_msr tbm perfctr_core perfctr_nb bpext ptsc mwaitx cpb hw_pstate ssbd vmmcall fsgsbase bmi1 avx2 smep bmi2 xsaveopt arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif overflow_recov bugs: fxsave_leak sysret_ss_attrs null_seg spectre_v1 spectre_v2 spec_store_bypass bogomips: 5789.50 TLB size: 1536 4K pages clflush size: 64 cache_alignment : 64 address sizes : 48 bits physical, 48 bits virtual power management: ts ttp tm 100mhzsteps hwpstate cpb eff_freq_ro acc_power [13] [INFO] Running org.apache.zookeeper.common.X509UtilTest [ERROR] Tests run: 336, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 12.382 s <<< FAILURE! - in org.apache.zookeeper.common.X509UtilTest [ERROR] testClientRenegotiationFails[1](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.103 s <<< ERROR! java.lang.Exception: Unexpected exception, expected but was at org.apache.zookeeper.common.X509UtilTest.testClientRenegotiationFails(X509UtilTest.java:575) [ERROR] testClientRenegotiationFails[4](org.apache.zookeeper.common.X509UtilTest) Time elapsed: 0.064 s <<< ERROR! java.lang.Exception: Unexpected exception, expected but was at
[jira] [Created] (ZOOKEEPER-3539) Fix branch-3.5 after upgrade on ASF CI
Enrico Olivelli created ZOOKEEPER-3539: -- Summary: Fix branch-3.5 after upgrade on ASF CI Key: ZOOKEEPER-3539 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3539 Project: ZooKeeper Issue Type: Task Components: build, build-infrastructure Affects Versions: 3.5.5 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.5.6 ASF CI now lacks "findbugs" tool. ASF CI upgraded gcc and now there are some errors related to the usage of NULL in calls of fprintf. We should: - disable findbugs on CI tasks - use LOG_INFO consistently with the rest of code in C client -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (ZOOKEEPER-3532) Provide a docker-based environment to work on a known OS
Enrico Olivelli created ZOOKEEPER-3532: -- Summary: Provide a docker-based environment to work on a known OS Key: ZOOKEEPER-3532 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3532 Project: ZooKeeper Issue Type: Improvement Components: build Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 We can have a docker based environment to launch a container with a know version of Linux, Java, Maven, gcc and all of the other libraries. This way it is easier to work on MacOS and in the future we could have a known environment to build releases and have reproducible builds even for native code. The idea is take from Apache BookKeeper project -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Created] (ZOOKEEPER-3441) OWASP is flagging jackson-databind-2.9.9.jar for CVE-2019-12814
Enrico Olivelli created ZOOKEEPER-3441: -- Summary: OWASP is flagging jackson-databind-2.9.9.jar for CVE-2019-12814 Key: ZOOKEEPER-3441 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3441 Project: ZooKeeper Issue Type: Bug Components: build, security Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 OWASP dependency checker is flagging jackson-databind-2.9.9.jar for CVE-2019-12814 We should upgrade the library or add a suppression. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3440) Fix Apache RAT check by excluding image binary files of docs
Enrico Olivelli created ZOOKEEPER-3440:
--
Summary: Fix Apache RAT check by excluding image binary files of
docs
Key: ZOOKEEPER-3440
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3440
Project: ZooKeeper
Issue Type: Bug
Components: build, documentation
Affects Versions: 3.6.0
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.0
I see this error on Jenkins as we are missing the exclusion for the images of
the docs.
{code:java}
Unapproved licenses:
/home/jenkins/jenkins-slave/workspace/zookeeper-master-maven/zookeeper-docs/src/main/resources/markdown/images/state_dia.dia
{code}
We should also add this check to the precommit job on Travis (this will be part
of the commit) and on CI (this is a manual configuration, to be done after
fixing this issue)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3436) Enhance Mavenized Make C client
Enrico Olivelli created ZOOKEEPER-3436:
--
Summary: Enhance Mavenized Make C client
Key: ZOOKEEPER-3436
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3436
Project: ZooKeeper
Issue Type: Improvement
Components: c client
Affects Versions: 3.5.5, 3.6.0
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.0
we want to be able to build the c-client with maven using these commands:
Jump to the directory
{code}
cd zookeeper-client/zookeeper-c-client
{code}
Build without running tests
{code}
mvn clean install -DskipTests
{code}
Build and run tests
{code}
mvn clean install
{code}
from the root directory we will have:
{code}
mvn clean install -Pfull-build -DskipTests
{code}
and (with tests)
{code}
mvn clean install -Pfull-build {code}
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790978#comment-16790978
]
Enrico Olivelli edited comment on ZOOKEEPER-3303 at 6/2/19 10:20 PM:
-
Okay.
Now it is clear to me.
I wonder why this part of the build is not regularly tests.
I am on fedora as you and I got into the other problem
Honestly I wasn't aware of the perl module, it is not compiled using neither
ant nor the new maven build.
We should definitely and automatic build and tests for the perl module.
Do you have time to try to fix the warnings reported by gcc?
I am not a C expert but the warnings seem simple to fix at a first glance
was (Author: eolivelli):
Okay.
Now it is clear to me.
I wonder why this part of the build is not regularly tests.
I am on fedora as you and I got into the other problem
Honestly I was aware of the perl module, it is not compiled using neither ant
nor the new maven build.
We should definitely and automatic build and tests for the perl module.
Do you have time to try to fix the warnings reported by gcc?
I am not a C expert but the warnings seem simple to fix at a first glance
> ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
> -
>
> Key: ZOOKEEPER-3303
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib
>Affects Versions: 3.4.8, 3.4.12, 3.4.13
> Environment: Fedora 29 in docker
>Reporter: Hari Sekhon
>Priority: Blocker
>
> ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok on
> CentOS 7 though). I cannot build the project to get the zkperl dependencies
> to run on Fedora as it is. This happens on various versions of ZooKeeper 3.4.x
> {code:java}
> # perl Makefile.PL --zookeeper-include=/usr/local/include
> --zookeeper-lib=/usr/local/lib
> Generating a Unix-style Makefile
> Writing Makefile for Net::ZooKeeper
> Writing MYMETA.yml and MYMETA.json
> # make
> Skip blib/lib/Net/ZooKeeper.pm (unchanged)
> Running Mkbootstrap for ZooKeeper ()
> chmod 644 "ZooKeeper.bs"
> "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs
> blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644
> gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
> -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv
> -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -g -DVERSION=\"0.36\" -DXS_VERSION=\"0.36\" -fPIC
> "-I/usr/lib64/perl5/CORE" ZooKeeper.c
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_acl_constant’:
> ZooKeeper.c:784:7: warning: unused variable ‘RETVAL’ [-Wunused-variable]
> AV * RETVAL;
>^~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE’:
> ZooKeeper.c:1089:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE_SKIP’:
> ZooKeeper.c:1109:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_TIEHASH’:
> ZooKeeper.c:1129:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_UNTIE’:
> ZooKeeper.c:1151:5: warning: unused variable ‘ref_count’ [-Wunused-variable]
> IV ref_count = (IV)SvIV(ST(1))
> ^
> ZooKeeper.c:1150:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_SCALAR’:
> ZooKeeper.c:1281:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_DELETE’:
> ZooKeeper.c:1528:7: warning: unused variable ‘attr_key’ [-Wunused-variable]
> SV * attr_key = ST(1)
>^~~~
> ZooKeeper.c:1527:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLEAR’:
> ZooKeeper.c:1561:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.xs: In
[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854128#comment-16854128
]
Enrico Olivelli commented on ZOOKEEPER-3303:
[~harisekhon] do you have time to try to fix this problem ?
The C client builds cleanly on current master.
We should fix the perl module as well
> ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
> -
>
> Key: ZOOKEEPER-3303
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib
>Affects Versions: 3.4.8, 3.4.12, 3.4.13
> Environment: Fedora 29 in docker
>Reporter: Hari Sekhon
>Priority: Blocker
>
> ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok on
> CentOS 7 though). I cannot build the project to get the zkperl dependencies
> to run on Fedora as it is. This happens on various versions of ZooKeeper 3.4.x
> {code:java}
> # perl Makefile.PL --zookeeper-include=/usr/local/include
> --zookeeper-lib=/usr/local/lib
> Generating a Unix-style Makefile
> Writing Makefile for Net::ZooKeeper
> Writing MYMETA.yml and MYMETA.json
> # make
> Skip blib/lib/Net/ZooKeeper.pm (unchanged)
> Running Mkbootstrap for ZooKeeper ()
> chmod 644 "ZooKeeper.bs"
> "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs
> blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644
> gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
> -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv
> -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -g -DVERSION=\"0.36\" -DXS_VERSION=\"0.36\" -fPIC
> "-I/usr/lib64/perl5/CORE" ZooKeeper.c
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_acl_constant’:
> ZooKeeper.c:784:7: warning: unused variable ‘RETVAL’ [-Wunused-variable]
> AV * RETVAL;
>^~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE’:
> ZooKeeper.c:1089:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE_SKIP’:
> ZooKeeper.c:1109:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_TIEHASH’:
> ZooKeeper.c:1129:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_UNTIE’:
> ZooKeeper.c:1151:5: warning: unused variable ‘ref_count’ [-Wunused-variable]
> IV ref_count = (IV)SvIV(ST(1))
> ^
> ZooKeeper.c:1150:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_SCALAR’:
> ZooKeeper.c:1281:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_DELETE’:
> ZooKeeper.c:1528:7: warning: unused variable ‘attr_key’ [-Wunused-variable]
> SV * attr_key = ST(1)
>^~~~
> ZooKeeper.c:1527:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLEAR’:
> ZooKeeper.c:1561:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_add_auth’:
> ZooKeeper.xs:1206:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid certificate length: %u", cert_len);
> ^~~~
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_create’:
> ZooKeeper.xs:1286:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid data length: %u", buf_len);
> ^ ~~~
> ZooKeeper.xs:1321:21: error: format not a string literal and no format
> arguments [-Werror=format-security]
> Perl_croak(aTHX_ err);
[jira] [Created] (ZOOKEEPER-3409) Compile Java code with -Xdoclint
Enrico Olivelli created ZOOKEEPER-3409: -- Summary: Compile Java code with -Xdoclint Key: ZOOKEEPER-3409 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3409 Project: ZooKeeper Issue Type: Sub-task Components: build Affects Versions: 3.6.0 Reporter: Enrico Olivelli Fix For: 3.6.0, 3.5.6 In order to drop ANT build script we have to compile with -Xdoclint option. parent issue ZOOKEEPER-3351 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848259#comment-16848259
]
Enrico Olivelli commented on ZOOKEEPER-3399:
{quote}
Recently we have moved some of our production clusters to the top of the trunk
{quote}
This is encouraging !
I think it is time to think to cut a release for 3.6.0
> Remove logging in getGlobalOutstandingLimit for optimal performance.
>
>
> Key: ZOOKEEPER-3399
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
>Affects Versions: 3.6.0
>Reporter: Michael Han
>Assignee: Michael Han
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Recently we have moved some of our production clusters to the top of the
> trunk. One issue we found is a performance regression on read and write
> latency on the clusters where the quorum is also serving traffic. The average
> read latency increased by 50x, p99 read latency increased by 300x.
> The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where
> we added a LOG.info statement in getGlobalOutstandingLimit.
> getGlobalOutstandingLimit is on the critical code path for request processing
> and for each request, it will be called twice (one at processing the packet,
> one at finalizing the request response). This not only degrades performance
> of the server, but also bloated the log file, when the QPS of a server is
> high.
> This only impacts clusters when the quorum (leader + follower) is serving
> traffic. For clusters where only observers are serving traffic no impact is
> observed.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3399: --- Fix Version/s: 3.6.0 > Remove logging in getGlobalOutstandingLimit for optimal performance. > > > Key: ZOOKEEPER-3399 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Recently we have moved some of our production clusters to the top of the > trunk. One issue we found is a performance regression on read and write > latency on the clusters where the quorum is also serving traffic. The average > read latency increased by 50x, p99 read latency increased by 300x. > The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where > we added a LOG.info statement in getGlobalOutstandingLimit. > getGlobalOutstandingLimit is on the critical code path for request processing > and for each request, it will be called twice (one at processing the packet, > one at finalizing the request response). This not only degrades performance > of the server, but also bloated the log file, when the QPS of a server is > high. > This only impacts clusters when the quorum (leader + follower) is serving > traffic. For clusters where only observers are serving traffic no impact is > observed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3399) Remove logging in getGlobalOutstandingLimit for optimal performance.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-3399. Resolution: Fixed > Remove logging in getGlobalOutstandingLimit for optimal performance. > > > Key: ZOOKEEPER-3399 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3399 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.6.0 >Reporter: Michael Han >Assignee: Michael Han >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Recently we have moved some of our production clusters to the top of the > trunk. One issue we found is a performance regression on read and write > latency on the clusters where the quorum is also serving traffic. The average > read latency increased by 50x, p99 read latency increased by 300x. > The root cause is a log statement introduced in ZOOKEEPER-3177 (PR711), where > we added a LOG.info statement in getGlobalOutstandingLimit. > getGlobalOutstandingLimit is on the critical code path for request processing > and for each request, it will be called twice (one at processing the packet, > one at finalizing the request response). This not only degrades performance > of the server, but also bloated the log file, when the QPS of a server is > high. > This only impacts clusters when the quorum (leader + follower) is serving > traffic. For clusters where only observers are serving traffic no impact is > observed. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3311) Allow a delay to the transaction log flush
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-3311. Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 851 [https://github.com/apache/zookeeper/pull/851] > Allow a delay to the transaction log flush > --- > > Key: ZOOKEEPER-3311 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3311 > Project: ZooKeeper > Issue Type: New Feature > Components: server >Affects Versions: 3.6.0 >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The SyncRequestProcessor flushes writes to disk either when 1000 writes are > pending to be flushed or when the processor fails to retrieve another write > from its incoming queue. The "flush when queue empty" condition operates > poorly under many workloads as it can quickly degrade into flushing after > every write -- losing all benefits of batching and leading to a continuous > stream of flushes + fsyncs which overwhelm the underlying disk. > > A configurable flush delay would ensure flushes do not happen more frequently > than once every X milliseconds. This can be used in-place of or jointly with > batch size triggered flushes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3378) Set the quorum cnxn timeout independently from syncLimit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-3378. Resolution: Fixed Fix Version/s: 3.6.0 > Set the quorum cnxn timeout independently from syncLimit > > > Key: ZOOKEEPER-3378 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3378 > Project: ZooKeeper > Issue Type: Improvement > Components: quorum >Reporter: Brian Nixon >Assignee: Brian Nixon >Priority: Minor > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > If an ensemble requires a high sync limit to support a large data tree or > transaction rate, it can cause the QuorumCxnManager to hang over-long in > response to quorum events. Using the sync limit for this timeout is a > convenience in terms of keeping all failure detection mechanisms in sync but > it is not strictly required for correct behavior. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-1425) add version command to the zookeeper client shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved ZOOKEEPER-1425. Resolution: Fixed Fix Version/s: 3.6.0 Issue resolved by pull request 930 [https://github.com/apache/zookeeper/pull/930] > add version command to the zookeeper client shell > - > > Key: ZOOKEEPER-1425 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1425 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, scripts >Reporter: Patrick Hunt >Assignee: maoling >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Attachments: ZOOKEEPER-1425.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > the client shell is missing a version command. Should return the version e.g. > "3.5.0" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (ZOOKEEPER-3263) Illegal reflective access in zookeer's kerberosUtil
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Enrico Olivelli resolved ZOOKEEPER-3263.
Resolution: Fixed
Fix Version/s: 3.6.0
Issue resolved by pull request 950
[https://github.com/apache/zookeeper/pull/950]
> Illegal reflective access in zookeer's kerberosUtil
> ---
>
> Key: ZOOKEEPER-3263
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3263
> Project: ZooKeeper
> Issue Type: Improvement
>Affects Versions: 3.4.13
>Reporter: Pradeep Bansal
>Assignee: Andor Molnar
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> I am using kafka 2.11-2.1.0 with Java 11. Kafka is using zookeeper-3.4.13.jar
> and when am running kafka-acl script to maange ACLs, I am getting below
> warning. Is there a way to resolve this?
> {{WARNING: An illegal reflective access operation has occurred WARNING:
> Illegal reflective access by org.apache.zookeeper.server.util.KerberosUtil
> (file://apache/kafka/kafka_2.11-2.1.0/libs/zookeeper-3.4.13.jar) to method
> sun.security.krb5.Config.getInstance() WARNING: Please consider reporting
> this to the maintainers of org.apache.zookeeper.server.util.KerberosUtil
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations WARNING: All illegal access operations will be
> denied in a future release}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3091) Prometheus.io integration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3091: --- Summary: Prometheus.io integration (was: Prometheus /metrics http endpoint for monitoring integration) > Prometheus.io integration > - > > Key: ZOOKEEPER-3091 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3091 > Project: ZooKeeper > Issue Type: New Feature > Components: jmx, metric system >Affects Versions: 3.4.6 >Reporter: Hari Sekhon >Priority: Major > > Feature Request to add Prometheus /metrics http endpoint for monitoring > integration: > [https://prometheus.io/docs/prometheus/latest/configuration/configuration/#%3Cscrape_config%3E] > Prometheus metrics format for that endpoint: > [https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3376) Create a Maven module for Metrics Providers API
Enrico Olivelli created ZOOKEEPER-3376: -- Summary: Create a Maven module for Metrics Providers API Key: ZOOKEEPER-3376 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3376 Project: ZooKeeper Issue Type: Sub-task Components: build, metric system Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 Once we get rid of Ant build we can package the Metrics Provider APIs in a separate module. This way Providers won't need to depend on ZooKeper Server module and we will have a better structure -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3372) Cleanup pom.xml in order to let Maven clients import as few dependencies as possible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827765#comment-16827765 ] Enrico Olivelli commented on ZOOKEEPER-3372: This is the result after my patch: \- org.apache.zookeeper:zookeeper:jar:3.6.0-SNAPSHOT:compile +- commons-lang:commons-lang:jar:2.6:compile +- org.apache.zookeeper:zookeeper-jute:jar:3.6.0-SNAPSHOT:compile +- org.apache.yetus:audience-annotations:jar:0.5.0:compile +- io.netty:netty-all:jar:4.1.29.Final:compile +- org.slf4j:slf4j-api:jar:1.7.25:compile +- org.slf4j:slf4j-log4j12:jar:1.7.25:compile \- log4j:log4j:jar:1.2.17:compile > Cleanup pom.xml in order to let Maven clients import as few dependencies as > possible > > > Key: ZOOKEEPER-3372 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3372 > Project: ZooKeeper > Issue Type: Improvement > Components: java client >Affects Versions: 3.6.0, 3.5.5 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > ZooKeeper client application imports a lot of third party dependencies that > are automatically applied to maven client applications, that is applications > that are using the 'client'. > This task is to clean up the final resulting pom of the main artifact > consumed by "clients" as much as possible. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3372) Cleanup pom.xml in order to let Maven clients import as few dependencies as possible
Enrico Olivelli created ZOOKEEPER-3372: -- Summary: Cleanup pom.xml in order to let Maven clients import as few dependencies as possible Key: ZOOKEEPER-3372 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3372 Project: ZooKeeper Issue Type: Improvement Components: java client Affects Versions: 3.6.0, 3.5.5 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 ZooKeeper client application imports a lot of third party dependencies that are automatically applied to maven client applications, that is applications that are using the 'client'. This task is to clean up the final resulting pom of the main artifact consumed by "clients" as much as possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3366) Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3366: --- Summary: Pluggable metrics system for ZooKeeper - move remaining metrics to MetricsProvider (was: Pluggable metrics system for ZooKeeper - move remaining metrics to ServerMetrics) > Pluggable metrics system for ZooKeeper - move remaining metrics to > MetricsProvider > -- > > Key: ZOOKEEPER-3366 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3366 > Project: ZooKeeper > Issue Type: Sub-task > Components: metric system >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Fix For: 3.6.0 > > > There are a bunch of metrics exposed by the Monitor Command which are not > implemented using ServerMetrics, we have to move all of them to > ServerMetrics, or at least move it to the new metrics framework -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3366) Pluggable metrics system for ZooKeeper - move remaining metrics to ServerMetrics
Enrico Olivelli created ZOOKEEPER-3366: -- Summary: Pluggable metrics system for ZooKeeper - move remaining metrics to ServerMetrics Key: ZOOKEEPER-3366 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3366 Project: ZooKeeper Issue Type: Sub-task Components: metric system Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 There are a bunch of metrics exposed by the Monitor Command which are not implemented using ServerMetrics, we have to move all of them to ServerMetrics, or at least move it to the new metrics framework -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3364) Compile with strict options in order to check code quality
Enrico Olivelli created ZOOKEEPER-3364:
--
Summary: Compile with strict options in order to check code quality
Key: ZOOKEEPER-3364
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3364
Project: ZooKeeper
Issue Type: Improvement
Components: build
Affects Versions: 3.6.0
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.0
In order to dismiss old QA tests based on ant (ZOOKEEPER-3351) we have to
enforce code quality by activating some falgs on javac at build time, namely:
{code:java}
-Werror
-Xlint:deprecation
-Xlint:unchecked
-Xpkginfo:always
{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816873#comment-16816873
]
Enrico Olivelli commented on ZOOKEEPER-3351:
This is the issue about checkstyle:ZOOKEEPER-3362
spotbugs is already running on Travis, with ZOOKEEPER-3362 we will be running
checkstyle with a minimal configuration which looks for @author tags
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816871#comment-16816871
]
Enrico Olivelli commented on ZOOKEEPER-3351:
[~Tison] I have created the umbrella issue, thanks for the idea: ZOOKEEPER-3363
cc [~phunt] [~nkalmar] [~anmolnar]
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3363) Drop ant basedbuild umbrella issue
Enrico Olivelli created ZOOKEEPER-3363: -- Summary: Drop ant basedbuild umbrella issue Key: ZOOKEEPER-3363 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3363 Project: ZooKeeper Issue Type: Task Components: build Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 This is an umbrella issue to track activites related to dropping ant based build now that we have (since 3.5.5) Maven fully working. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check on @author tags. This is needed in order to drop old ANT based precommit job (see ZOOKEEPER-3351) We will not remove legacy checkstyle configuration file in zookeeper-server/src/test/resources/checkstyle.xml because it is referred by ANT build.xml files (even if we are not actually using that target). This task won't add a complete checkstyle configuration with usual checks because it would imply almost a change at every .java in the codebase. was: Create a basic checkstyle file, in order to cover the minimal check abount @author tags. This is needed in order to drop old ANT based precommit job (see ZOOKEEPER-3351) We will not remove legacy checkstyle configuration file in zookeeper-server/src/test/resources/checkstyle.xml because it is referred by ANT build.xml files (even if we are not actually using that target). This task won't add a complete checkstyle configuration with usual checks because it would imply almost a change at every .java in the codebase. > Create a simple checkstyle file > --- > > Key: ZOOKEEPER-3362 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Create a basic checkstyle file, in order to cover the minimal check on > @author tags. > This is needed in order to drop old ANT based precommit job (see > ZOOKEEPER-3351) > We will not remove legacy checkstyle configuration file in > zookeeper-server/src/test/resources/checkstyle.xml because it is referred by > ANT build.xml files (even if we are not actually using that target). > This task won't add a complete checkstyle configuration with usual checks > because it would imply almost a change at every .java in the codebase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3362) Create a simple checkstyle file
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated ZOOKEEPER-3362: --- Description: Create a basic checkstyle file, in order to cover the minimal check abount @author tags. This is needed in order to drop old ANT based precommit job (see ZOOKEEPER-3351) We will not remove legacy checkstyle configuration file in zookeeper-server/src/test/resources/checkstyle.xml because it is referred by ANT build.xml files (even if we are not actually using that target). This task won't add a complete checkstyle configuration with usual checks because it would imply almost a change at every .java in the codebase. was: Create a basic checkstyle file, in order to cover the minimal check abount @author tags. This is needed in order to drop old ant based precommit job (see ZOOKEEPER-3351) > Create a simple checkstyle file > --- > > Key: ZOOKEEPER-3362 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 > Project: ZooKeeper > Issue Type: Task > Components: build >Affects Versions: 3.6.0 >Reporter: Enrico Olivelli >Assignee: Enrico Olivelli >Priority: Major > Labels: pull-request-available > Fix For: 3.6.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Create a basic checkstyle file, in order to cover the minimal check abount > @author tags. > This is needed in order to drop old ANT based precommit job (see > ZOOKEEPER-3351) > We will not remove legacy checkstyle configuration file in > zookeeper-server/src/test/resources/checkstyle.xml because it is referred by > ANT build.xml files (even if we are not actually using that target). > This task won't add a complete checkstyle configuration with usual checks > because it would imply almost a change at every .java in the codebase. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3362) Create a simple checkstyle file
Enrico Olivelli created ZOOKEEPER-3362: -- Summary: Create a simple checkstyle file Key: ZOOKEEPER-3362 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3362 Project: ZooKeeper Issue Type: Task Components: build Affects Versions: 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0 Create a basic checkstyle file, in order to cover the minimal check abount @author tags. This is needed in order to drop old ant based precommit job (see ZOOKEEPER-3351) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3356) Request throttling in Netty is not working as expected and could cause direct buffer OOM issue
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814043#comment-16814043 ] Enrico Olivelli commented on ZOOKEEPER-3356: Can this be a blocker for 3.5.5?l as 'stable'? I think this affects 3.5.5 and not 3.5.4 > Request throttling in Netty is not working as expected and could cause direct > buffer OOM issue > --- > > Key: ZOOKEEPER-3356 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3356 > Project: ZooKeeper > Issue Type: Bug > Components: server >Affects Versions: 3.5.4, 3.6.0 >Reporter: Fangmin Lv >Assignee: Fangmin Lv >Priority: Major > Fix For: 3.6.0 > > > The current implementation of Netty enable/disable recv logic may cause the > direct buffer OOM because we may enable read a large chunk of packets and > disabled again after consuming a single ZK request. We have seen this problem > on prod occasionally. > > Need a more advanced flow control in Netty instead of using AUTO_READ. Have > improved it internally by enable/disable recv based on the queuedBuffer size, > will upstream this soon. > > With this implementation, the max Netty queued buffer size (direct memory > usage) will be 2 * recv_buffer size. It's not the per message size because in > epoll ET mode it will try to read until the socket is empty, and because of > SslHandler will trigger another read when it's not a full encrypt packet and > haven't issued any decrypt message. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812782#comment-16812782
]
Enrico Olivelli commented on ZOOKEEPER-3351:
My plan is to migrate all of the checks to Maven and then leave a minimal bash
file which does these the check using git command and checks for new tests.
This new file will be called from maven as well in the pull request validation
job (using the Maven 'exec' plugin)
-
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.6.0
>
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775
]
Enrico Olivelli edited comment on ZOOKEEPER-3351 at 4/8/19 8:45 PM:
most of the work of that script can be executed as part of normal Pull Request
validation using Maven plugins.
This is the complete list of checks:
* findbugs (superseded by spotbugs Maven plugin)
* checking javac warning (better to always compile with -Werrors flag, and
have 0 warnings)
* check for @autor tags (this is better to be checked with checkstyle,
[https://github.com/checkstyle/checkstyle/issues/5339])
* check javadoc warnings (it would be better to have 0 warnings)
* check for new tests in patch
* check Apache RAT (it is better to always have 0 warnings)
* run core java tests (to be run as usual)
* run contrib java tests (I am not sure it has some value, but we can run as
part of the full test suite on jenkins)
* add comment to Jira
was (Author: eolivelli):
most of the work of that script can be executed as part of normal Pull Request
validation.
This is the complete list of checks:
* findbugs (superseded by spotbugs Maven plugin)
* checking javac warning (better to always compile with -Werrors flag, and
have 0 warnings)
* check for @autor tags (this is better to be checked with checkstyle,
https://github.com/checkstyle/checkstyle/issues/5339)
* check javadoc warnings (it would be better to have 0 warnings)
* check for new tests in patch
* check Apache RAT (it is better to always have 0 warnings)
* run core java tests (to be run as usual)
* run contrib java tests (I am not sure it has some value, but we can run as
part of the full test suite on jenkins)
* add comment to Jira
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.6.0
>
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812775#comment-16812775
]
Enrico Olivelli commented on ZOOKEEPER-3351:
most of the work of that script can be executed as part of normal Pull Request
validation.
This is the complete list of checks:
* findbugs (superseded by spotbugs Maven plugin)
* checking javac warning (better to always compile with -Werrors flag, and
have 0 warnings)
* check for @autor tags (this is better to be checked with checkstyle,
https://github.com/checkstyle/checkstyle/issues/5339)
* check javadoc warnings (it would be better to have 0 warnings)
* check for new tests in patch
* check Apache RAT (it is better to always have 0 warnings)
* run core java tests (to be run as usual)
* run contrib java tests (I am not sure it has some value, but we can run as
part of the full test suite on jenkins)
* add comment to Jira
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.6.0
>
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812766#comment-16812766
]
Enrico Olivelli commented on ZOOKEEPER-3351:
that task is calling zookeeper-server/src/test/resources/test-github-pr.sh
> Migrate qa-test-pullrequest ant task to maven
> -
>
> Key: ZOOKEEPER-3351
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
> Project: ZooKeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.5.5
>Reporter: Enrico Olivelli
>Assignee: Enrico Olivelli
>Priority: Major
> Fix For: 3.6.0
>
>
> In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
> That task is currently called this way in ASF Jenkins:
> {code:java}
> #!/bin/bash
> set +x
> #export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
> export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
> #export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
> export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
> export PATCH_DIR=${WORKSPACE}/patchprocess
> if [ ! -e "$PATCH_DIR" ] ; then
> mkdir -p $PATCH_DIR
> fi
> pwd
> git status
> git rev-parse HEAD
> which java
> java -version
> ulimit -a
> env
> ${ANT_HOME}/bin/ant \
> -Dpatch.file=foobar \
> -Dscratch.dir=$PATCH_DIR \
> -Dps.cmd=/bin/ps \
> -Dwget.cmd=/usr/bin/wget \
> -Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
> -Dgit.cmd=/usr/bin/git \
> -Dgrep.cmd=/bin/grep \
> -Dpatch.cmd=/usr/bin/patch \
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
> -Dforrest.home=/home/jenkins/tools/forrest/latest/ \
> -Djira.passwd= \
> -Djava5.home=/home/jenkins/tools/java5/latest/ \
> -Dcurl.cmd=/usr/bin/curl \
> -Dtest.junit.maxmem=2g \
> qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3351) Migrate qa-test-pullrequest ant task to maven
Enrico Olivelli created ZOOKEEPER-3351:
--
Summary: Migrate qa-test-pullrequest ant task to maven
Key: ZOOKEEPER-3351
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3351
Project: ZooKeeper
Issue Type: Improvement
Components: build
Affects Versions: 3.5.5
Reporter: Enrico Olivelli
Assignee: Enrico Olivelli
Fix For: 3.6.0
In order to drop ANT we have to migrate task qa-test-pullrequest to Maven.
That task is currently called this way in ASF Jenkins:
{code:java}
#!/bin/bash
set +x
#export JAVA_HOME=/home/jenkins/tools/java/jdk1.7.0-64
export ANT_HOME=/home/jenkins/tools/ant/apache-ant-1.9.9
#export PATH=$PATH:$JAVA_HOME/bin:$ANT_HOME/bin:
export PATH=$PATH:$LATEST1_8_HOME/bin:$ANT_HOME/bin:
export PATCH_DIR=${WORKSPACE}/patchprocess
if [ ! -e "$PATCH_DIR" ] ; then
mkdir -p $PATCH_DIR
fi
pwd
git status
git rev-parse HEAD
which java
java -version
ulimit -a
env
${ANT_HOME}/bin/ant \
-Dpatch.file=foobar \
-Dscratch.dir=$PATCH_DIR \
-Dps.cmd=/bin/ps \
-Dwget.cmd=/usr/bin/wget \
-Djiracli.cmd=/home/jenkins/tools/jiracli/latest/jira.sh \
-Dgit.cmd=/usr/bin/git \
-Dgrep.cmd=/bin/grep \
-Dpatch.cmd=/usr/bin/patch \
-Dfindbugs.home=/home/jenkins/tools/findbugs/latest/ \
-Dforrest.home=/home/jenkins/tools/forrest/latest/ \
-Djira.passwd= \
-Djava5.home=/home/jenkins/tools/java5/latest/ \
-Dcurl.cmd=/usr/bin/curl \
-Dtest.junit.maxmem=2g \
qa-test-pullrequest{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809825#comment-16809825
]
Enrico Olivelli commented on ZOOKEEPER-3337:
This is my comment
https://github.com/apache/zookeeper/pull/828#discussion_r259123093
> Maven build failed with user or group id is too big
>
>
> Key: ZOOKEEPER-3337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3337
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.13
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments: ZOOKEEPER-3337-branch-3.4.patch
>
>
> Maven assembly plugin configuration must specify tarLongFileMode of "posix",
> not "gnu".
> Otherwise if the user or group id is too large the build will fail. For
> example:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single
> (source-package) on project zookeeper: Execution source-package of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single failed: user id
> '1754762210'
> is too big ( > 2097151 ). -> [Help 1]
> {noformat}
> A very common problem, many other projects here have had to fix this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3337) Maven build failed with user or group id is too big
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809824#comment-16809824
]
Enrico Olivelli commented on ZOOKEEPER-3337:
I have an huge userid on my work laptop and in order to handle it the fix
usually is to use posix.
> Maven build failed with user or group id is too big
>
>
> Key: ZOOKEEPER-3337
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3337
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.4.13
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
>Priority: Major
> Attachments: ZOOKEEPER-3337-branch-3.4.patch
>
>
> Maven assembly plugin configuration must specify tarLongFileMode of "posix",
> not "gnu".
> Otherwise if the user or group id is too large the build will fail. For
> example:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single
> (source-package) on project zookeeper: Execution source-package of goal
> org.apache.maven.plugins:maven-assembly-plugin:3.1.0:single failed: user id
> '1754762210'
> is too big ( > 2097151 ). -> [Help 1]
> {noformat}
> A very common problem, many other projects here have had to fix this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794778#comment-16794778 ] Enrico Olivelli commented on ZOOKEEPER-3317: Yes. I will assign this issue to myself as soon as I have cycles, it is not a priority for me currently. > dynamic file for reconfig should support the relative path > -- > > Key: ZOOKEEPER-3317 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3317 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: maoling >Priority: Minor > > dynamic file for reconfig should support the relative path,just like this: > *dynamicConfigFile=../zoo_replicated5.cfg.dynamic* > follow an example of *dataDir*:if use the relative path,log the warning info. > 2019-03-14 11:02:39,028 [myid:] - INFO [main:QuorumPeerConfig@141] - Reading > configuration from: > /data/software/zookeeper/zookeeper-test2/bin/../conf/zoo.cfg > 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - > ../../zkdata2 is relative. Prepend ./ to indicate that you're sure! > 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - > ../../zkdataLog2 is relative. Prepend ./ to indicate that you're sure! > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@406] - > clientPortAddress is 0.0.0.0:22181 > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@410] - > secureClientPort is not set > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@427] - > observerMasterPort is not set > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@445] - > metricsProvider.className is > org.apache.zookeeper.metrics.impl.NullMetricsProvider > 2019-03-14 11:02:39,048 [myid:] - ERROR [main:QuorumPeerMain@94] - Invalid > config, exiting abnormally > org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error > processing ../zoo_replicated2.cfg.dynamic > at > org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:187) > at > org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:118) > at > org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:87) > Caused by: java.io.FileNotFoundException: ../zoo_replicated2.cfg.dynamic (No > such file or directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at java.io.FileInputStream.(FileInputStream.java:93) > at > org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:168) > ... 2 more > Invalid config, exiting abnormally -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2621) ZooKeeper doesn't start on MINGW32 (Windows)
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794531#comment-16794531
]
Enrico Olivelli commented on ZOOKEEPER-2621:
Can you send a PR on github? I know it is trivial, but this will ease the
process.
Thanks
> ZooKeeper doesn't start on MINGW32 (Windows)
>
>
> Key: ZOOKEEPER-2621
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2621
> Project: ZooKeeper
> Issue Type: Bug
> Components: scripts
>Affects Versions: 3.4.9
> Environment: MINGW32_NT-6.1 on Windows 7 (e.g. git bash)
>Reporter: Amichai Rothman
>Assignee: Amichai Rothman
>Priority: Major
> Attachments: ZOOKEEPER-2621.patch
>
>
> The ZooKeeper scripts fail due to missing cygpath path conversion in a
> MINGW32 environment, such as when running from git bash (installed by default
> when installing Git for Windows).
> The fix is to add the line
> {quote}
> MINGW*) cygwin=true ;;
> {quote}
> near the bottom of the zkEnv.sh script, in the case statement that checks for
> a cygwin environment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3317) dynamic file for reconfig should support the relative path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-3317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794238#comment-16794238 ] Enrico Olivelli commented on ZOOKEEPER-3317: Yes I would like this feature. Are you working on it? If we go for a relative path, we must state the base directory. > dynamic file for reconfig should support the relative path > -- > > Key: ZOOKEEPER-3317 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3317 > Project: ZooKeeper > Issue Type: Improvement > Components: server >Reporter: maoling >Priority: Minor > > dynamic file for reconfig should support the relative path,just like this: > *dynamicConfigFile=../zoo_replicated5.cfg.dynamic* > follow an example of *dataDir*:if use the relative path,log the warning info. > 2019-03-14 11:02:39,028 [myid:] - INFO [main:QuorumPeerConfig@141] - Reading > configuration from: > /data/software/zookeeper/zookeeper-test2/bin/../conf/zoo.cfg > 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - > ../../zkdata2 is relative. Prepend ./ to indicate that you're sure! > 2019-03-14 11:02:39,037 [myid:] - WARN [main:VerifyingFileFactory@59] - > ../../zkdataLog2 is relative. Prepend ./ to indicate that you're sure! > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@406] - > clientPortAddress is 0.0.0.0:22181 > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@410] - > secureClientPort is not set > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@427] - > observerMasterPort is not set > 2019-03-14 11:02:39,048 [myid:] - INFO [main:QuorumPeerConfig@445] - > metricsProvider.className is > org.apache.zookeeper.metrics.impl.NullMetricsProvider > 2019-03-14 11:02:39,048 [myid:] - ERROR [main:QuorumPeerMain@94] - Invalid > config, exiting abnormally > org.apache.zookeeper.server.quorum.QuorumPeerConfig$ConfigException: Error > processing ../zoo_replicated2.cfg.dynamic > at > org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:187) > at > org.apache.zookeeper.server.quorum.QuorumPeerMain.initializeAndRun(QuorumPeerMain.java:118) > at > org.apache.zookeeper.server.quorum.QuorumPeerMain.main(QuorumPeerMain.java:87) > Caused by: java.io.FileNotFoundException: ../zoo_replicated2.cfg.dynamic (No > such file or directory) > at java.io.FileInputStream.open0(Native Method) > at java.io.FileInputStream.open(FileInputStream.java:195) > at java.io.FileInputStream.(FileInputStream.java:138) > at java.io.FileInputStream.(FileInputStream.java:93) > at > org.apache.zookeeper.server.quorum.QuorumPeerConfig.parse(QuorumPeerConfig.java:168) > ... 2 more > Invalid config, exiting abnormally -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ZOOKEEPER-3312) Upgrade Jetty to 9.4.15.v20190215
Enrico Olivelli created ZOOKEEPER-3312: -- Summary: Upgrade Jetty to 9.4.15.v20190215 Key: ZOOKEEPER-3312 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3312 Project: ZooKeeper Issue Type: Improvement Components: security, server Affects Versions: 3.5.4, 3.6.0 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.6.0, 3.5.5 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16790978#comment-16790978
]
Enrico Olivelli commented on ZOOKEEPER-3303:
Okay.
Now it is clear to me.
I wonder why this part of the build is not regularly tests.
I am on fedora as you and I got into the other problem
Honestly I was aware of the perl module, it is not compiled using neither ant
nor the new maven build.
We should definitely and automatic build and tests for the perl module.
Do you have time to try to fix the warnings reported by gcc?
I am not a C expert but the warnings seem simple to fix at a first glance
> ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
> -
>
> Key: ZOOKEEPER-3303
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib
>Affects Versions: 3.4.8, 3.4.12, 3.4.13
> Environment: Fedora 29 in docker
>Reporter: Hari Sekhon
>Priority: Blocker
>
> ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok on
> CentOS 7 though). I cannot build the project to get the zkperl dependencies
> to run on Fedora as it is. This happens on various versions of ZooKeeper 3.4.x
> {code:java}
> # perl Makefile.PL --zookeeper-include=/usr/local/include
> --zookeeper-lib=/usr/local/lib
> Generating a Unix-style Makefile
> Writing Makefile for Net::ZooKeeper
> Writing MYMETA.yml and MYMETA.json
> # make
> Skip blib/lib/Net/ZooKeeper.pm (unchanged)
> Running Mkbootstrap for ZooKeeper ()
> chmod 644 "ZooKeeper.bs"
> "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs
> blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644
> gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
> -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv
> -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -g -DVERSION=\"0.36\" -DXS_VERSION=\"0.36\" -fPIC
> "-I/usr/lib64/perl5/CORE" ZooKeeper.c
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_acl_constant’:
> ZooKeeper.c:784:7: warning: unused variable ‘RETVAL’ [-Wunused-variable]
> AV * RETVAL;
>^~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE’:
> ZooKeeper.c:1089:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE_SKIP’:
> ZooKeeper.c:1109:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_TIEHASH’:
> ZooKeeper.c:1129:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_UNTIE’:
> ZooKeeper.c:1151:5: warning: unused variable ‘ref_count’ [-Wunused-variable]
> IV ref_count = (IV)SvIV(ST(1))
> ^
> ZooKeeper.c:1150:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_SCALAR’:
> ZooKeeper.c:1281:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_DELETE’:
> ZooKeeper.c:1528:7: warning: unused variable ‘attr_key’ [-Wunused-variable]
> SV * attr_key = ST(1)
>^~~~
> ZooKeeper.c:1527:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLEAR’:
> ZooKeeper.c:1561:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_add_auth’:
> ZooKeeper.xs:1206:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid certificate length: %u", cert_len);
> ^~~~
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_create’:
> ZooKeeper.xs:1286:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long
[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789535#comment-16789535
]
Enrico Olivelli commented on ZOOKEEPER-3303:
Is it something we have to fix in ZooKeeper build ?
>From your fix is seems to me that libraries are not in the place that they are
>supposed to be
> ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
> -
>
> Key: ZOOKEEPER-3303
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib
>Affects Versions: 3.4.8, 3.4.12, 3.4.13
> Environment: Fedora 29 in docker
>Reporter: Hari Sekhon
>Priority: Blocker
>
> ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok on
> CentOS 7 though). I cannot build the project to get the zkperl dependencies
> to run on Fedora as it is. This happens on various versions of ZooKeeper 3.4.x
> {code:java}
> # perl Makefile.PL --zookeeper-include=/usr/local/include
> --zookeeper-lib=/usr/local/lib
> Generating a Unix-style Makefile
> Writing Makefile for Net::ZooKeeper
> Writing MYMETA.yml and MYMETA.json
> # make
> Skip blib/lib/Net/ZooKeeper.pm (unchanged)
> Running Mkbootstrap for ZooKeeper ()
> chmod 644 "ZooKeeper.bs"
> "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs
> blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644
> gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
> -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv
> -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -g -DVERSION=\"0.36\" -DXS_VERSION=\"0.36\" -fPIC
> "-I/usr/lib64/perl5/CORE" ZooKeeper.c
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_acl_constant’:
> ZooKeeper.c:784:7: warning: unused variable ‘RETVAL’ [-Wunused-variable]
> AV * RETVAL;
>^~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE’:
> ZooKeeper.c:1089:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE_SKIP’:
> ZooKeeper.c:1109:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_TIEHASH’:
> ZooKeeper.c:1129:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_UNTIE’:
> ZooKeeper.c:1151:5: warning: unused variable ‘ref_count’ [-Wunused-variable]
> IV ref_count = (IV)SvIV(ST(1))
> ^
> ZooKeeper.c:1150:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_SCALAR’:
> ZooKeeper.c:1281:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_DELETE’:
> ZooKeeper.c:1528:7: warning: unused variable ‘attr_key’ [-Wunused-variable]
> SV * attr_key = ST(1)
>^~~~
> ZooKeeper.c:1527:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLEAR’:
> ZooKeeper.c:1561:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_add_auth’:
> ZooKeeper.xs:1206:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid certificate length: %u", cert_len);
> ^~~~
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_create’:
> ZooKeeper.xs:1286:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid data length: %u", buf_len);
> ^ ~~~
> ZooKeeper.xs:1321:21: error: format not a string literal and no format
> arguments [-Werror=format-security]
> Perl_croak(aTHX_
[jira] [Created] (ZOOKEEPER-3304) Maven build of "loggraph" is broken on branch-3.4
Enrico Olivelli created ZOOKEEPER-3304: -- Summary: Maven build of "loggraph" is broken on branch-3.4 Key: ZOOKEEPER-3304 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3304 Project: ZooKeeper Issue Type: Bug Components: build, contrib Affects Versions: 3.4.13 Reporter: Enrico Olivelli Assignee: Enrico Olivelli Fix For: 3.4.15 Loggraph uses Jetty and dependency is missing in branch-3.4. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3303) ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788715#comment-16788715
]
Enrico Olivelli commented on ZOOKEEPER-3303:
Can you please reproduce your failure on current master?
Our policy is to fix master and then backport
I am not and user of perl client
Which is the command line to reproduce the issue.
It seems to me that it is only a matter of fixing code quality issues
> ZooKeeper Perl client zkperl doesn't compile on newer RHEL systems ie. Fedora
> -
>
> Key: ZOOKEEPER-3303
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3303
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client, contrib
>Affects Versions: 3.4.8, 3.4.12, 3.4.13
> Environment: Fedora 29 in docker
>Reporter: Hari Sekhon
>Priority: Blocker
>
> ZooKeeper Perl client zkperl fails to compile on Fedora 29 (compiles ok on
> CentOS 7 though). I cannot build the project to get the zkperl dependencies
> to run on Fedora as it is. This happens on various versions of ZooKeeper 3.4.x
> {code:java}
> # perl Makefile.PL --zookeeper-include=/usr/local/include
> --zookeeper-lib=/usr/local/lib
> Generating a Unix-style Makefile
> Writing Makefile for Net::ZooKeeper
> Writing MYMETA.yml and MYMETA.json
> # make
> Skip blib/lib/Net/ZooKeeper.pm (unchanged)
> Running Mkbootstrap for ZooKeeper ()
> chmod 644 "ZooKeeper.bs"
> "/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- ZooKeeper.bs
> blib/arch/auto/Net/ZooKeeper/ZooKeeper.bs 644
> gcc -c -I/usr/local/include -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe
> -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
> -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong
> -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic
> -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fwrapv
> -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE
> -D_FILE_OFFSET_BITS=64 -g -DVERSION=\"0.36\" -DXS_VERSION=\"0.36\" -fPIC
> "-I/usr/lib64/perl5/CORE" ZooKeeper.c
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_acl_constant’:
> ZooKeeper.c:784:7: warning: unused variable ‘RETVAL’ [-Wunused-variable]
> AV * RETVAL;
>^~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE’:
> ZooKeeper.c:1089:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLONE_SKIP’:
> ZooKeeper.c:1109:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_TIEHASH’:
> ZooKeeper.c:1129:9: warning: unused variable ‘package’ [-Wunused-variable]
> char * package = (char *)SvPV_nolen(ST(0))
> ^~~
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_UNTIE’:
> ZooKeeper.c:1151:5: warning: unused variable ‘ref_count’ [-Wunused-variable]
> IV ref_count = (IV)SvIV(ST(1))
> ^
> ZooKeeper.c:1150:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_SCALAR’:
> ZooKeeper.c:1281:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_DELETE’:
> ZooKeeper.c:1528:7: warning: unused variable ‘attr_key’ [-Wunused-variable]
> SV * attr_key = ST(1)
>^~~~
> ZooKeeper.c:1527:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.c: In function ‘XS_Net__ZooKeeper_CLEAR’:
> ZooKeeper.c:1561:17: warning: variable ‘attr_hash’ set but not used
> [-Wunused-but-set-variable]
> Net__ZooKeeper attr_hash;
> ^
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_add_auth’:
> ZooKeeper.xs:1206:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid certificate length: %u", cert_len);
> ^~~~
> ZooKeeper.xs: In function ‘XS_Net__ZooKeeper_create’:
> ZooKeeper.xs:1286:30: warning: format ‘%u’ expects argument of type ‘unsigned
> int’, but argument 3 has type ‘STRLEN’ {aka ‘long unsigned int’} [-Wformat=]
> Perl_croak(aTHX_ "invalid data length: %u", buf_len);
> ^ ~~~
> ZooKeeper.xs:1321:21: error: format not a
