[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853456#comment-16853456 ] Hudson commented on ZOOKEEPER-1426: --- SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #383 (See [https://builds.apache.org/job/Zookeeper-trunk-single-thread/383/]) ZOOKEEPER-1426: add version command to the zookeeper server (andor: rev d3dbe787f37eb9e17402e4a3d55a441ca43b2160) * (edit) bin/zkServer.sh * (edit) zookeeper-server/src/test/resources/findbugsExcludeFile.xml * (edit) zookeeper-server/src/test/resources/test-scripts.sh * (edit) bin/zkServer-initialize.sh * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java > add version command to the zookeeper server > --- > > Key: ZOOKEEPER-1426 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 > Project: ZooKeeper > Issue Type: Improvement > Components: scripts, server >Affects Versions: 3.3.5 >Reporter: Patrick Hunt >Assignee: Eli Reisman >Priority: Major > Labels: newbie, patch, pull-request-available > Fix For: 3.6.0 > > Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, > ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Add a version command to the zkServer.sh. > Hadoop does this by having a special main class: > org.apache.hadoop.util.VersionInfo > We could do something similar, hook it into our current version information > class (perhaps add main to that class). > Would also need to add a new "version" command to zkServer.sh that calls this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853413#comment-16853413 ] Hudson commented on ZOOKEEPER-1426: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #548 (See [https://builds.apache.org/job/ZooKeeper-trunk/548/]) ZOOKEEPER-1426: add version command to the zookeeper server (andor: rev d3dbe787f37eb9e17402e4a3d55a441ca43b2160) * (edit) bin/zkServer.sh * (edit) zookeeper-server/src/main/java/org/apache/zookeeper/version/util/VerGen.java * (edit) zookeeper-server/src/test/resources/findbugsExcludeFile.xml * (edit) zookeeper-server/src/test/resources/test-scripts.sh * (edit) bin/zkServer-initialize.sh > add version command to the zookeeper server > --- > > Key: ZOOKEEPER-1426 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 > Project: ZooKeeper > Issue Type: Improvement > Components: scripts, server >Affects Versions: 3.3.5 >Reporter: Patrick Hunt >Assignee: Eli Reisman >Priority: Major > Labels: newbie, patch, pull-request-available > Fix For: 3.6.0 > > Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, > ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Add a version command to the zkServer.sh. > Hadoop does this by having a special main class: > org.apache.hadoop.util.VersionInfo > We could do something similar, hook it into our current version information > class (perhaps add main to that class). > Would also need to add a new "version" command to zkServer.sh that calls this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430713#comment-13430713 ] Jakob Homan commented on ZOOKEEPER-1426: Hey Eli. Looks like the new patch picked up some changes from the changelog. Also, can you look into the [new findbugs warning|https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html]? Thanks. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430788#comment-13430788 ] Hadoop QA commented on ZOOKEEPER-1426: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12539752/ZOOKEEPER-1426-3.patch against trunk revision 1368737. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1158//console This message is automatically generated. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch, ZOOKEEPER-1426-3.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426733#comment-13426733 ] Eli Reisman commented on ZOOKEEPER-1426: If you mean the ASF license at the top in comments, its in there, gets generated also. Did you mean something else? I will add a test today. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426768#comment-13426768 ] Hadoop QA commented on ZOOKEEPER-1426: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538805/MAPREDUCE-4282-2.patch against trunk revision 1368072. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 19 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1150//console This message is automatically generated. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426799#comment-13426799 ] Eli Reisman commented on ZOOKEEPER-1426: I saw this Hadoop QA notice, so I pulled fresh trunk and applied the patch. it worked fine. It is a git --no-prefix patch, and I used patch -p0 ... is that the problem? anyway I don't know what its talking about so I can't fix it yet. Still passes ant compile-test as well. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426809#comment-13426809 ] Patrick Hunt commented on ZOOKEEPER-1426: - for some reason you attached a MAPREDUCE patch? the patch QA bot pulls the most recent attachment to try as the patch (against trunk). add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426843#comment-13426843 ] Eli Reisman commented on ZOOKEEPER-1426: sorry wrong patch, will upload the right one now! add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426927#comment-13426927 ] Hadoop QA commented on ZOOKEEPER-1426: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538829/ZOOKEEPER-1426-2.patch against trunk revision 1368203. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1154//console This message is automatically generated. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: MAPREDUCE-4282-2.patch, ZOOKEEPER-1426-1.patch, ZOOKEEPER-1426-2.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426099#comment-13426099 ] Jakob Homan commented on ZOOKEEPER-1426: Is the ASF header required on generated files? add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13426123#comment-13426123 ] Patrick Hunt commented on ZOOKEEPER-1426: - Good catch Jakob. It's good to add it whenever possible, esp for source files. Eli please add the header as well. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Assignee: Eli Reisman Labels: newbie, patch Attachments: ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1426) add version command to the zookeeper server
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13419391#comment-13419391 ] Hadoop QA commented on ZOOKEEPER-1426: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12537373/ZOOKEEPER-1426-1.patch against trunk revision 1362660. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1139//console This message is automatically generated. add version command to the zookeeper server --- Key: ZOOKEEPER-1426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1426 Project: ZooKeeper Issue Type: Improvement Components: scripts, server Affects Versions: 3.3.5 Reporter: Patrick Hunt Labels: newbie, patch Attachments: ZOOKEEPER-1426-1.patch Add a version command to the zkServer.sh. Hadoop does this by having a special main class: org.apache.hadoop.util.VersionInfo We could do something similar, hook it into our current version information class (perhaps add main to that class). Would also need to add a new version command to zkServer.sh that calls this. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
