[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782820#comment-13782820 ] Hudson commented on ZOOKEEPER-1552: --- SUCCESS: Integrated in ZooKeeper-trunk #2075 (See [https://builds.apache.org/job/ZooKeeper-trunk/2075/]) ZOOKEEPER-1552. Enable sync request processor in Observer (thawan, fpj) (thawan: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1527760) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.4.6, 3.5.0 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552-trunk.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782168#comment-13782168 ] Thawan Kooburat commented on ZOOKEEPER-1552: +1 Thanks a lot Flavio Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552-trunk.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13779312#comment-13779312 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12605339/ZOOKEEPER-1552-trunk.patch against trunk revision 1526454. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1601//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1601//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1601//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552-trunk.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13778175#comment-13778175 ] Thawan Kooburat commented on ZOOKEEPER-1552: LTGM +1 Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13775737#comment-13775737 ] Flavio Junqueira commented on ZOOKEEPER-1552: - [~thawan], could you please comment on the last patch for the 3.4 branch I have uploaded when you have a chance? If you can +1 it, even better. :-) Note that there are two patches I have uploaded on Sep. 21, it should be the one uploaded later in the day. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13773690#comment-13773690 ] Thawan Kooburat commented on ZOOKEEPER-1552: Is it possible that we also keep the JVM flag? All of the patch from our internal branch have a coding convention of introducing a JVM flag into a file that it affect the functionality. I can debate why it has some merit but I do agree that configuration file is easier to use for user. If this coding convention is not accept by upstream, I will have to change our internal coding convention as well because all pending/future patch has this style. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Flavio Junqueira Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552-b3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13769573#comment-13769573 ] Flavio Junqueira commented on ZOOKEEPER-1552: - Is it ok with you if I modify your patch to have this parameter set as part of configuration files? I was thinking of simply adding a parameter to QuorumPeerConfig. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768591#comment-13768591 ] Thawan Kooburat commented on ZOOKEEPER-1552: [~fpj] If this looks good to you, I can commit the patch (and the documentation patch ZOOKEEPER-1758), so I can continue to work on ZOOKEEPER-1551 Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768775#comment-13768775 ] Flavio Junqueira commented on ZOOKEEPER-1552: - QA picks the last file uploaded. I'll review it shortly. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768845#comment-13768845 ] Flavio Junqueira commented on ZOOKEEPER-1552: - One clarification question. In one of your comments, you talk about a separate patch to expose configuration through the configuration file. Is the plan to have that patch for 3.4.6 as well? I'm asking because in another jira, the preference was for parameters set through the configuration file. I think it would be good to have this one through the configuration file as well, if it is not a big deal. There is a typo in the last comment of ObserverZooKeeperServer. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768988#comment-13768988 ] Thawan Kooburat commented on ZOOKEEPER-1552: I haven't start working on it and has no plan to work on that in a near future. If we really need a config file, we can just modify the start up script to read a file and set up JVM property on start up. This is essentially what we do on our internal branch. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767240#comment-13767240 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch against trunk revision 1522079. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1579//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767251#comment-13767251 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch against trunk revision 1522079. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1580//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767260#comment-13767260 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12603168/ZOOKEEPER-1552-3.4.patch against trunk revision 1522079. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1581//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767286#comment-13767286 ] Thawan Kooburat commented on ZOOKEEPER-1552: Not sure how to tell Hadoop QA to pickup a certain file to run. Also upload a documentation patch Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552-3.4.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755766#comment-13755766 ] Camille Fournier commented on ZOOKEEPER-1552: - Do we have any movement on this? Looks like it is a dependency for ZOOKEEPER-1551, which is listed as a blocker for 3.4.6, and it would be great to get this done so we can do a release. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755787#comment-13755787 ] Flavio Junqueira commented on ZOOKEEPER-1552: - Good catch, [~fournc], thanks for pointing it out. It was not marked for 3.4.6, I just marked it. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0, 3.4.6 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660188#comment-13660188 ] Flavio Junqueira commented on ZOOKEEPER-1552: - My take is that we do not have to be strict and classify this jira as a bug just so that we have it in the 3.4 branch. I see this patch as an improvement because the way the code currently is is correct, but perhaps not as efficient as you'd like. I'd like to have a last look at the patch, since I haven't looked at this issue in a while. In any case, this is the next patch to get in in the description you added to ZOOKEEPER-1551, right? Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660226#comment-13660226 ] Thawan Kooburat commented on ZOOKEEPER-1552: Yes, we should get this patch in. Not sure how this patch will affect reconfig functionality though, since Alex mentioned that it is possible to promote an observer to a participant (or the leader). Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13650431#comment-13650431 ] Thawan Kooburat commented on ZOOKEEPER-1552: I would say that we can also classify this jira as a bug as well in order to put this into 3.4 branch. This is because many people assumed that the observer is already writing to txnlog. Currently, it only writes a snapshot to disk after the synchronization phase. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628877#comment-13628877 ] Jacky007 commented on ZOOKEEPER-1552: - HI [~thawan], we commit proposal to SyncRequestprocessor, but SyncRequestprocessor may not flush it immediately. Does we really expect that, throuth it's not a big deal to lose some txns here. If we should make sure of that, we can make a new processor as the next processor of SyncRequestprocessor to execute commitProcessor.commit(request). Or some comments are help to clarify. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628966#comment-13628966 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571755/ZOOKEEPER-1552.patch against trunk revision 1463329. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1454//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1454//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1454//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629747#comment-13629747 ] Thawan Kooburat commented on ZOOKEEPER-1552: I think it is ok for the observer not to flush the txns to disk. All of these txns are already committed by the participants. In the observer, writing these txns to disk is just an optimization to make it synchronize quicker with the leader. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591454#comment-13591454 ] Raul Gutierrez Segales commented on ZOOKEEPER-1552: --- Small nit: typo in patch (recieved as INFORM packet). Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591516#comment-13591516 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571755/ZOOKEEPER-1552.patch against trunk revision 1448007. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1417//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1417//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1417//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591250#comment-13591250 ] Thawan Kooburat commented on ZOOKEEPER-1552: I can change list this a bug instead of an improvement, so that it is eligible for 3.4 branch. When we use the observer, we expected that it will also write to txnlog but it actually don't. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: quorum, server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13534181#comment-13534181 ] Thawan Kooburat commented on ZOOKEEPER-1552: I thinks there is a benefit of putting system property with the code. Since most of the property affect only a specific component. I agree that this is not a user-friendly way of exposing the config. However, I think we need a better facility for managing zookeeper config since the current one require so many code changes for each new config parameter. Anyway, I can do a separate patch to expose config parameters. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533676#comment-13533676 ] Mahadev konar commented on ZOOKEEPER-1552: -- Thawan, This is a good idea. As for the patch, I think we have too many system properties spread around in the source code. Its best if we can use the ZooKeeper config file for this. What do others think? Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484694#comment-13484694 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12550917/ZOOKEEPER-1552.patch against trunk revision 1391526. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1240//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1240//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1240//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch, ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471686#comment-13471686 ] Thawan Kooburat commented on ZOOKEEPER-1552: Observer doesn't participant in the voting, so this should not affect the correctness of the operation. This patch is mainly for optimization for observer restart and reusing existing facility minimize the code changes. Let me know if you want me to modify the patch in anyway. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471025#comment-13471025 ] Flavio Junqueira commented on ZOOKEEPER-1552: - One issue I have with this proposal is that the semantics of the transaction log change form follower to observer. Followers log proposals they accepted but that are not necessarily committed. With this patch, an observer logs committed proposals coming in the form of inform messages. Otherwise, I don't see any other problem with this patch. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1552) Enable sync request processor in Observer
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466614#comment-13466614 ] Hadoop QA commented on ZOOKEEPER-1552: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547188/ZOOKEEPER-1552.patch against trunk revision 1391526. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1199//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1199//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1199//console This message is automatically generated. Enable sync request processor in Observer - Key: ZOOKEEPER-1552 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1552 Project: ZooKeeper Issue Type: Improvement Components: server Affects Versions: 3.4.3 Reporter: Thawan Kooburat Assignee: Thawan Kooburat Fix For: 3.5.0 Attachments: ZOOKEEPER-1552.patch Observer doesn't forward its txns to SyncRequestProcessor. So it never persists the txns onto disk or periodically creates snapshots. This increases the start-up time since it will get the entire snapshot if the observer has be running for a long time. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
