[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799846#comment-13799846 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609263/ZOOKEEPER-1558.patch against trunk revision 1533161. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1708//console This message is automatically generated. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799259#comment-13799259 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12609166/ZOOKEEPER-1558.patch against trunk revision 1533161. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1707//console This message is automatically generated. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799531#comment-13799531 ] Thawan Kooburat commented on ZOOKEEPER-1558: Thanks Flavio, the patch looks good to me Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797305#comment-13797305 ] Thawan Kooburat commented on ZOOKEEPER-1558: Minor style change request: please use private static int randRoll ... and move variable declaration to be on top of constructor (ideally below snapcount since it is a related variable) Other parts look good for me so +1 once style change is made Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13794598#comment-13794598 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608368/ZOOKEEPER-1558.patch against trunk revision 1531444. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1694//console This message is automatically generated. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793042#comment-13793042 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Ok, I'll produce a new patch for 3.4. I think it would be best to simply get ZOOKEEPER-1549 in. I've been ignoring it just because I'm focusing on the 3.4.6 release. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791843#comment-13791843 ] Thawan Kooburat commented on ZOOKEEPER-1558: Yeah, I think that should work as well. Seem like a new txnlog file is produced on a new epoch so that should be fine. I am wondering if we should apply this to 3.5 so at least the problem in 1549 is partially fixed in trunk as well before 1549 land and we also get more testing. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790929#comment-13790929 ] Flavio Junqueira commented on ZOOKEEPER-1558: - [~thawan], could you please chime in here? Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791169#comment-13791169 ] Thawan Kooburat commented on ZOOKEEPER-1558: Again, my concern is that the current solution would cause leader to be blocked taking the snapshot before starting to send ping to quorum members. If the snapshot taking time is larger than syncLimit, the quorum will tear down. You can simply simulate this situation by adding sleep which is longer that syncLimit into the new code where takeSnaphot() is called. If we agree that this is any issue, a simple fix is to create a method that take snapshot asynchronously (spin up a thread on demand similar to SyncRequestProcessor). Some refactoring and additional locking may be needed as well in order to do this cleanly. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Affects Versions: 3.4.6 Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13785581#comment-13785581 ] Flavio Junqueira commented on ZOOKEEPER-1558: - You may be thinking about a different jira. This is one is not about long transfers, but about taking a snapshot at the wrong time, which causes us to include uncommitted state in the snapshot. This solution is not complete, but takes care of the scenario described originally in ZOOKEEPER-1549, which is supposed to go into 3.5.0 only (see discussion above). I'd like to come to a resolution for this jira, so I'd appreciate if you could either propose a different plan or review the patch, [~thawan]. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782369#comment-13782369 ] Thawan Kooburat commented on ZOOKEEPER-1558: I think the patch need to be rebased in order to apply. With the recent issue of ZOOKEEPER-1697, I am wondering if we need to revisit the solution. If I understand correctly, this patch move the snapshot step from pre-leader election to after synchronization and before broadcast phase. I believe we already transition to use syncLimit by the time we take this snapshot. I believe we should be taking snapshot while using initLimit In any case, we should add more comment about timing consideration into the patch as well. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770096#comment-13770096 ] Flavio Junqueira commented on ZOOKEEPER-1558: - [~thawan], Could you please have a look at my comment right before this one? Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13747684#comment-13747684 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I'd really like to either get a +1 here to commit it to 3.4.6 or a confirmation that we will also get ZK-1549 committed to 3.4.6. To provide some context, the fix of 3.5.0 has BC issues, check this comment by [~thawan]: https://issues.apache.org/jira/browse/ZOOKEEPER-1549?focusedCommentId=13567348page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13567348 Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635863#comment-13635863 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Is there anyone opposed to having the patch here committed only to 3.4.6 and having the more comprehensive fix of ZOOKEEPER-1549 to 3.50? The other option is to drop this jira and have ZOOKEEPER-1549 also committed to 3.4.6. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574366#comment-13574366 ] Flavio Junqueira commented on ZOOKEEPER-1558: - I think this patch should go only to 3.4.6. We will have a more comprehensive patch for 3.5.0 (ZOOKEEPER-1549). Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Priority: Blocker Fix For: 3.4.6 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491344#comment-13491344 ] Flavio Junqueira commented on ZOOKEEPER-1558: - Great, this one has gone through fine. I would appreciate a review of this patch. I was also wondering if this should go to 3.4 branch too. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.5.0 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491706#comment-13491706 ] Thawan Kooburat commented on ZOOKEEPER-1558: - This is minor but you can make Zab1_0Test class extends ClientBase and use its createTmpDir() method instead of creating tmpDir manually. - Please update comments such as //Setup a database... and //Set the last.. to reflect what actually happen - Can we also test that the leader take snapshot when it have quorum of supported? Not sure if it is possible, but if we don't shutdown the leader at the end of the test and start a follower, then we should be able to test that code path. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.5.0 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491906#comment-13491906
]
Flavio Junqueira commented on ZOOKEEPER-1558:
-
Thanks for reviewing, Thawan.
bq. his is minor but you can make Zab1_0Test class extends ClientBase and use
its createTmpDir() method instead of creating tmpDir manually.
I'd rather do that in a separate jira, since it touches test cases that are
unrelated to this issue.
bq. Please update comments such as //Setup a database... and //Set the last..
to reflect what actually happen
Sure, will do.
bq. Can we also test that the leader take snapshot when it have quorum of
supported? Not sure if it is possible, but if we don't shutdown the leader at
the end of the test and start a follower, then we should be able to test that
code path.
I suppose you're talking about checking this:
{code}
+/*
+ * Take snapshot once it has a quorum of followers supporting
+ */
+zk.takeSnapshot();
+
{code}
This snapshot is not strictly necessary for correctness, but it is convenient
to do one at that point. I'd rather not extend the test case to verify it,
since its addition does not affect correctness.
Leader should not snapshot uncommitted state
Key: ZOOKEEPER-1558
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558
Project: ZooKeeper
Issue Type: Sub-task
Components: quorum
Reporter: Flavio Junqueira
Assignee: Flavio Junqueira
Fix For: 3.5.0
Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch,
ZOOKEEPER-1558.patch
Leader currently takes a snapshot when it calls loadData in the beginning of
the lead() method. The loaded data, however, may contain uncommitted state.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492079#comment-13492079 ] Thawan Kooburat commented on ZOOKEEPER-1558: I agree that the current patch fix the problem on the leader side. However, I would like to see how do we plan to fix the whole problem first so we know that we moving in the right direction. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.5.0 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491031#comment-13491031 ] Hadoop QA commented on ZOOKEEPER-1558: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12552174/ZOOKEEPER-1558.patch against trunk revision 1404288. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1248//console This message is automatically generated. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Fix For: 3.5.0 Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1558) Leader should not snapshot uncommitted state
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471028#comment-13471028 ] Hadoop QA commented on ZOOKEEPER-1558: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12548121/ZOOKEEPER-1558.patch against trunk revision 1391526. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1208//console This message is automatically generated. Leader should not snapshot uncommitted state Key: ZOOKEEPER-1558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1558 Project: ZooKeeper Issue Type: Sub-task Components: quorum Reporter: Flavio Junqueira Assignee: Flavio Junqueira Attachments: ZOOKEEPER-1558.patch, ZOOKEEPER-1558.patch Leader currently takes a snapshot when it calls loadData in the beginning of the lead() method. The loaded data, however, may contain uncommitted state. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
