[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989096#comment-15989096
 ] 

Michael Han commented on ZOOKEEPER-2662:


bq. ZOOKEEPER-261 that both of us reviewed, but it got only committed on master.

There is a closely related issue ZOOKEEPER-2325 and both combined solved an 
issue of inconsistent quorum in certain cases - since we have ZOOKEEPER-2325 
committed in br-3.5, 261 should be committed to br-3.5. I believe 261 fell out 
of radar when we did cherry picks for 3.5. If no objection I'll port 
ZOOKEEPER-261 in br-3.5.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989081#comment-15989081
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro closed the pull request at:

https://github.com/apache/zookeeper/pull/243


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989069#comment-15989069
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
merged, please close this pr @eribeiro .


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.5.4, 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989067#comment-15989067
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/243
  
lgtm, thanks for doing this. Merging.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988646#comment-15988646
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 5 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/659//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988638#comment-15988638
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/243

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662-branch-3.5

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #243


commit cfd12f86b0a244b6bd697af35e2b6d03c20e31fd
Author: Edward Ribeiro 
Date:   2017-04-27T00:21:18Z

ZOOKEEPER-2662: Export a metric for txn log sync times

Addressed review comments




> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988614#comment-15988614
 ] 

Edward Ribeiro commented on ZOOKEEPER-2662:
---

Sure [~hanm], gonna port it to branch-3.5! :)

By the way, I saw that {{FileTxnSnapLogTest}}, that this patch uses, doesn't 
exist on branch-3.5. It was created as part of ZOOKEEPER-261 that both of us 
reviewed, but it got only committed on master. It was that on purpose [~breed]?

Best regards!

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988245#comment-15988245
 ] 

Hudson commented on ZOOKEEPER-2662:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3370 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3370/])
ZOOKEEPER-2662: Export a metric for txn log sync times (hanm: rev 
425fdbb8fa64ea839072701187fa7a24bfe10bda)
* (edit) 
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java
* (edit) src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java
* (edit) src/java/main/org/apache/zookeeper/server/persistence/TxnLog.java
* (edit) src/java/test/org/apache/zookeeper/server/ZooKeeperServerBeanTest.java
* (edit) 
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
* (edit) src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Michael Han (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988225#comment-15988225
 ] 

Michael Han commented on ZOOKEEPER-2662:


[~eribeiro] Do you mind creating another PR for branch-3.5? I'll resolve this 
JIRA once this is merged to 3.5.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988220#comment-15988220
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/241


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15988219#comment-15988219
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on the issue:

https://github.com/apache/zookeeper/pull/241
  
lgtm, merging now.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987934#comment-15987934
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

+1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 6 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/653//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/653//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/653//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987879#comment-15987879
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113824039
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java 
---
@@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
 attemptAutoCreateDb(dataDir, snapDir, sessions, 
priorAutocreateDbValue, "false", 0L);
 }
 
+@Test
+public void testGetTxnLogSyncElapsedTime() throws IOException {
--- End diff --

Done. It looks like this one, so any suggestion to remove duplicate or 
improve it is welcome.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987850#comment-15987850
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113821590
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
  * @return secure client address
  */
 public String getSecureClientAddress();
+
--- End diff --

done.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987851#comment-15987851
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113821610
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -162,4 +162,12 @@ public String getSecureClientAddress() {
 }
 return "";
 }
+
+/**
+ * Returns the elapsed sync of time of transaction log in milliseconds.
+ */
--- End diff --

done.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987299#comment-15987299
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r11376
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
  * @return secure client address
  */
 public String getSecureClientAddress();
+
--- End diff --

:+1:


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987300#comment-15987300
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user eribeiro commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r11385
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
  * @return secure client address
  */
 public String getSecureClientAddress();
+
--- End diff --

:+1:


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987281#comment-15987281
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113776378
  
--- Diff: 
src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java 
---
@@ -113,6 +116,26 @@ public void testAutoCreateDb() throws IOException {
 attemptAutoCreateDb(dataDir, snapDir, sessions, 
priorAutocreateDbValue, "false", 0L);
 }
 
+@Test
+public void testGetTxnLogSyncElapsedTime() throws IOException {
--- End diff --

This tests the sync time, but not the bean. It is a good test case to have, 
but it would be also good to add server bean test for the methods added in this 
patch (see ZooKeeperServerBeanTest).


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987277#comment-15987277
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113776089
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
@@ -162,4 +162,12 @@ public String getSecureClientAddress() {
 }
 return "";
 }
+
+/**
+ * Returns the elapsed sync of time of transaction log in milliseconds.
+ */
--- End diff --

This comment can be moved to interface.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987275#comment-15987275
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

Github user hanm commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/241#discussion_r113775960
  
--- Diff: 
src/java/main/org/apache/zookeeper/server/ZooKeeperServerMXBean.java ---
@@ -125,4 +125,6 @@
  * @return secure client address
  */
 public String getSecureClientAddress();
+
--- End diff --

Missing interface comment here.


> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986960#comment-15986960
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/651//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/651//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/651//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986400#comment-15986400
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/646//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/646//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/646//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986399#comment-15986399
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

-1 contrib tests.  The patch failed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/647//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/647//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/647//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986361#comment-15986361
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/645//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986300#comment-15986300
 ] 

Hadoop QA commented on ZOOKEEPER-2662:
--

-1 overall.  GitHub Pull Request  Build
  

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/644//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/644//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/644//console

This message is automatically generated.

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985814#comment-15985814
 ] 

Edward Ribeiro commented on ZOOKEEPER-2662:
---

Hey [~ckulkarni], I didn't have any spare cycle to spend on ZK issues, but got 
to resume it now. Thanks for bringing this up. Yup, I think this unit test is 
enough, so thank you **very much** for the test case. :)

[~hanm], would you mind to take a look at this PR, please?

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Fix For: 3.6.0
>
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985788#comment-15985788
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2662:
---

GitHub user eribeiro opened a pull request:

https://github.com/apache/zookeeper/pull/241

ZOOKEEPER-2662: Export a metric for txn log sync times



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2662

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/241.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #241


commit 9349c6192a5832def17a35bb6f4769c6aa917a54
Author: Edward Ribeiro 
Date:   2017-04-27T00:21:18Z

ZOOKEEPER-2662: Export a metric for txn log sync times




> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985094#comment-15985094
 ] 

Andrew Purtell commented on ZOOKEEPER-2662:
---

The test looks good to me [~ckulkarni]. 

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Chinmay Kulkarni (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984012#comment-15984012
 ] 

Chinmay Kulkarni commented on ZOOKEEPER-2662:
-

[~eribeiro] are you still working on this JIRA? Your diff seems to solve the 
issue. I have added a test inside {{FileTxnSnapLogTest.java}} to check that 
{{syncElapsedTime}} is updated. The test is as follows:

{code:title=FileTxnSnapLogTest.java|borderStyle=solid} 
@Test
public void testGetTxnLogSyncElapsedTime() throws IOException {
File tmpDir = ClientBase.createEmptyTestDir();
FileTxnSnapLog fileTxnSnapLog = new FileTxnSnapLog(new File(tmpDir, 
"data"), 
new File(tmpDir, "data_txnlog"));

TxnHeader hdr = new TxnHeader(1, 1, 1, 1, ZooDefs.OpCode.setData);
Record txn = new SetDataTxn("/foo", new byte[0], 1);
Request req = new Request(0, 0, 0, hdr, txn, 0);
fileTxnSnapLog.append(req);
fileTxnSnapLog.commit();
long syncElapsedTime = fileTxnSnapLog.getTxnLogElapsedSyncTime();
Assert.assertNotEquals("Did not update syncElapsedTime!", -1L, 
syncElapsedTime);
}
{code}

[~apurtell] Is this sufficient to test the changes?

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Edward Ribeiro (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859285#comment-15859285
 ] 

Edward Ribeiro commented on ZOOKEEPER-2662:
---

Ops, sorry for delaying this issue, gonna resume asap. Any feedback is welcome. 
:) 

Thanks!

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2662) Export a metric for txn log sync times

[Andrew Purtell (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15858491#comment-15858491
 ] 

Andrew Purtell commented on ZOOKEEPER-2662:
---

[~sanjeevln]

> Export a metric for txn log sync times
> --
>
> Key: ZOOKEEPER-2662
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2662
> Project: ZooKeeper
>  Issue Type: Improvement
>Reporter: Andrew Purtell
>Assignee: Edward Ribeiro
> Attachments: ZOOKEEPER-2662.diff
>
>
> In FileTxnLog there is code that records the amount of time required to fsync 
> the txn log in order to warn if that time exceeds a configurable threshold. 
> This information should also be exported as a metric available by JMX so an 
> important aspect of quorum performance can be monitored. 
> ZooKeeperServerMXBean carries some global latency information for the server 
> process already, seems like a good place to put it if not an entirely new 
> bean for the TxnLog. After ZOOKEEPER-2310 might want to collect the same 
> information for snapshots. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)