[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870502#comment-15870502
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/178
  
You are correct @rakeshadr , that test fails. I will change the patch to 
just removing `transitive="false"`


> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870475#comment-15870475
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/178
  
>> I was able to run the unit tests within eclipse or idea (I used 
WatcherTest as my example) using just the dependencies I added in the patch.

@afine , Probably, you can run `QuorumKerberosAuthTest.java` test case, 
which needs all these libraries during execution.


> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868738#comment-15868738
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/178
  
Hi @rakeshadr 

I was able to run the unit tests within eclipse or idea (I used WatcherTest 
as my example) using just the dependencies I added in the patch.  

That being said I would be find removing `transitive="false"`. I would 
appreciate @phunt opinion on that as he added it originally. 




> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867641#comment-15867641
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

Github user rakeshadr commented on the issue:

https://github.com/apache/zookeeper/pull/178
  
Thanks @afine  for reporting this. With newly added dependencies, the 
compilation error will be resolved. But, I could see while running unit test 
case in eclipse, it needed all the transitive dependent libraries in classpath. 
AFAIK, the below set of libraries needed during test run time. Could you please 
confirm? If yes, then we can think of removing `transitive="false"` from 
build.xml in order to reduce the length of ivy.xml, right?

-  antlr-2.7.7.jar
-  mina-core-2.0.7.jar
-  mavibot-1.0.0-M1.jar
-  ehcache-core-2.4.4.jar
-  commons-pool-1.6.jar
-  apacheds-core-2.0.0-M15.jar
-  apacheds-core-api-2.0.0-M15.jar
-  apacheds-core-avl-2.0.0-M15.jar
-  apacheds-core-constants-2.0.0-M15.jar
-  apacheds-core-shared-2.0.0-M15.jar
-  apacheds-i18n-2.0.0-M15.jar
-  apacheds-interceptor-kerberos-2.0.0-M15.jar
-  apacheds-interceptors-admin-2.0.0-M15.jar
-  apacheds-interceptors-authn-2.0.0-M15.jar
-  apacheds-interceptors-authz-2.0.0-M15.jar
-  apacheds-interceptors-changelog-2.0.0-M15.jar
-  apacheds-interceptors-collective-2.0.0-M15.jar
-  apacheds-interceptors-event-2.0.0-M15.jar
-  apacheds-interceptors-exception-2.0.0-M15.jar
-  apacheds-interceptors-journal-2.0.0-M15.jar
-  apacheds-interceptors-normalization-2.0.0-M15.jar
-  apacheds-interceptors-operational-2.0.0-M15.jar
-  apacheds-interceptors-referral-2.0.0-M15.jar
-  apacheds-interceptors-schema-2.0.0-M15.jar
-  apacheds-interceptors-subtree-2.0.0-M15.jar
-  apacheds-interceptors-trigger-2.0.0-M15.jar
-  apacheds-jdbm1-2.0.0-M2.jar
-  apacheds-jdbm-partition-2.0.0-M15.jar
-  apacheds-kerberos-codec-2.0.0-M15.jar
-  apacheds-ldif-partition-2.0.0-M15.jar
-  apacheds-mavibot-partition-2.0.0-M15.jar
-  apacheds-protocol-kerberos-2.0.0-M15.jar
-  apacheds-protocol-ldap-2.0.0-M15.jar
-  apacheds-protocol-shared-2.0.0-M15.jar
-  apacheds-xdbm-partition-2.0.0-M15.jar
-  api-all-1.0.0-M20.jar
-  api-asn1-api-1.0.0-M20.jar
-  api-asn1-ber-1.0.0-M20.jar
-  api-i18n-1.0.0-M20.jar
-  api-ldap-client-api-1.0.0-M20.jar
-  api-ldap-codec-core-1.0.0-M20.jar
-  api-ldap-extras-aci-1.0.0-M20.jar
-  api-ldap-extras-codec-1.0.0-M20.jar
-  api-ldap-extras-codec-api-1.0.0-M20.jar
-  api-ldap-extras-sp-1.0.0-M20.jar
-  api-ldap-extras-trigger-1.0.0-M20.jar
-  api-ldap-extras-util-1.0.0-M20.jar
-  api-ldap-model-1.0.0-M20.jar
-  api-util-1.0.0-M20.jar
-  bcprov-jdk15-140.jar


> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866982#comment-15866982
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/178
  
Hoping you can take a look @rakeshadr 


> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ZOOKEEPER-2696) Eclipse ant ask no longer determines correct classpath for tests after ZOOKEEPER-2689

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866975#comment-15866975
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2696:
---

GitHub user afine opened a pull request:

https://github.com/apache/zookeeper/pull/178

ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath for 
tests after ZOOKEEPER-2689

After pulling branch-3.4 i noticed that I could no longer compile and run 
the tests within my IDE. 

The .classpath file generated by the eclipse ant task was missing necessary 
dependencies. These missing dependencies all appear to be transitive from 
dependencies brought in by ZOOKEEPER-2689 (which is why ant is able to run the 
tests). There were two possible ways to fix this, this patch explicitly lists 
the new transitive dependencies that are required by our test code. Another 
solution would be to remove `transitive="false"` from `` in the eclipse target 
of our `build.xml`. This solution would introduce even more transitive 
dependencies to the .classpath.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/afine/zookeeper ZOOKEEPER-2696

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #178


commit bc8d6c35594f24fbb7ebf13066a746f5b7246cd1
Author: Abraham Fine 
Date:   2017-02-15T00:03:35Z

ZOOKEEPER-2696: Eclipse ant ask no longer determines correct classpath 
after ZOOKEEPER-2689




> Eclipse ant ask no longer determines correct classpath for tests after 
> ZOOKEEPER-2689
> -
>
> Key: ZOOKEEPER-2696
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2696
> Project: ZooKeeper
>  Issue Type: Bug
>Affects Versions: 3.4.10
>Reporter: Abraham Fine
>Assignee: Abraham Fine
>
> Following the changes made in ZOOKEEPER-2689 IDE's using the .classpath file 
> generated by the eclipse ant task (I tested both idea and eclipse) cannot 
> compile the tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)