[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413408#comment-16413408
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/485
  
Thanks @hanm!


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1641#comment-1641
 ] 

Hudson commented on ZOOKEEPER-2997:
---

SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3778 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/3778/])
ZOOKEEPER-2997: CMake should not force static CRT linking (hanm: rev 
13c9f899ff62be6a2eacb28e522d06703f1dab08)
* (edit) src/c/CMakeLists.txt


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413285#comment-16413285
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user asfgit closed the pull request at:

https://github.com/apache/zookeeper/pull/485


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
> Fix For: 3.5.4, 3.6.0
>
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393643#comment-16393643
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/485
  
CI errors look spurious...


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393641#comment-16393641
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/485
  
[JIRA: ZOOKEEPER-2997](https://issues.apache.org/jira/browse/ZOOKEEPER-2997)


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393603#comment-16393603
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user andschwa commented on the issue:

https://github.com/apache/zookeeper/pull/485
  
I had to reopen this because I changed which branch it was from.


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393601#comment-16393601
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

Github user andschwa closed the pull request at:

https://github.com/apache/zookeeper/pull/483


> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393602#comment-16393602
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/485

ZOOKEEPER-2997: CMake should not force static CRT linking

By removing this code, CMake will use its own defaults for the CRT
flags (e.g., `/MDd` for debug configurations). With it removed, the
user can override this behavior by setting the `CMAKE_CXX_FLAGS`
manually when configuring ZooKeeper.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-2997

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/485.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #485


commit 45a997ad0e281d967460f4eb205a4b18e4219ecd
Author: Andrew Schwartzmeyer 
Date:   2018-03-09T21:00:48Z

ZOOKEEPER-2997: CMake should not force static CRT linking

By removing this code, CMake will use its own defaults for the CRT
flags (e.g., `/MDd` for debug configurations). With it removed, the
user can override this behavior by setting the `CMAKE_CXX_FLAGS`
manually when configuring ZooKeeper.




> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2997) CMake should not force static CRT linking

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16393568#comment-16393568
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2997:
---

GitHub user andschwa opened a pull request:

https://github.com/apache/zookeeper/pull/483

ZOOKEEPER-2997: CMake should not force static CRT linking

By removing this code, CMake will use its own defaults for the CRT
flags (e.g., `/MDd` for debug configurations). With it removed, the
user can override this behavior by setting the `CMAKE_CXX_FLAGS`
manually when configuring ZooKeeper.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/andschwa/zookeeper master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #483


commit 45a997ad0e281d967460f4eb205a4b18e4219ecd
Author: Andrew Schwartzmeyer 
Date:   2018-03-09T21:00:48Z

ZOOKEEPER-2997: CMake should not force static CRT linking

By removing this code, CMake will use its own defaults for the CRT
flags (e.g., `/MDd` for debug configurations). With it removed, the
user can override this behavior by setting the `CMAKE_CXX_FLAGS`
manually when configuring ZooKeeper.




> CMake should not force static CRT linking
> -
>
> Key: ZOOKEEPER-2997
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2997
> Project: ZooKeeper
>  Issue Type: Bug
> Environment: Windows
>Reporter: Andrew Schwartzmeyer
>Assignee: Andrew Schwartzmeyer
>Priority: Major
>
> When writing the CMake build, I erroneously forced ZooKeeper to link to the 
> Windows CRT statically. Instead of setting this, we should rely on CMake's 
> defaults, and let users override it if they choose to by configuring with  
> setting {{CMAKE_CXX_ARGS}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)