[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832856#comment-16832856
]
Hudson commented on ZOOKEEPER-3350:
---
SUCCESS: Integrated in Jenkins build Zookeeper-trunk-single-thread #340 (See
[https://builds.apache.org/job/Zookeeper-trunk-single-thread/340/])
ZOOKEEPER-3350: Remove CommonNames (andor: rev
bee2ef8da3c4a7a2a1925ac8fc5375a7dee702ae)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ObserverMasterTest.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/MBeanRegistry.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/JMXEnv.java
* (delete)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/CommonNames.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumMajorityTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/HierarchicalQuorumTest.java
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832793#comment-16832793
]
Hudson commented on ZOOKEEPER-3350:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #505 (See
[https://builds.apache.org/job/ZooKeeper-trunk/505/])
ZOOKEEPER-3350: Remove CommonNames (andor: rev
bee2ef8da3c4a7a2a1925ac8fc5375a7dee702ae)
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ObserverMasterTest.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/ReconfigTest.java
* (edit) zookeeper-server/src/test/java/org/apache/zookeeper/test/JMXEnv.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/QuorumMajorityTest.java
* (delete)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/CommonNames.java
* (edit)
zookeeper-server/src/main/java/org/apache/zookeeper/jmx/MBeanRegistry.java
* (edit)
zookeeper-server/src/test/java/org/apache/zookeeper/test/HierarchicalQuorumTest.java
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820762#comment-16820762
]
maoling commented on ZOOKEEPER-3350:
[~Tison]
1. git log|grep -C 20 f1dd874ed7ddd42f006600319dd5e896ed8ac349
commit f1dd874ed7ddd42f006600319dd5e896ed8ac349
Author: Benjamin Reed
Date: Tue Jun 3 15:51:18 2008 +
[ 1913998 ] JMX instrumentation
git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/trunk@670963
13f79535-47bb-0310-9956-ffa450edef68
[~breed] may give us more info about this.
2. I prefer the refactor one,JMXConstants will have a more augmentability for
placing more constants about JMX in the future.But moving it as
{{*MBeanRegistry.DOMAIN* is also a good option.}}
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.5.5
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820725#comment-16820725
]
TisonKun commented on ZOOKEEPER-3350:
-
Well, I can see the evolution. Now DataTreeKey has gone into
{{DataTreeBean#getName}} and similarly "StandaloneServer" has gone into
{{ZooKeeperServerBean#getName}}.
Regarding the DOMAIN field usage I'd like to move it as
{{MBeanRegistry.DOMAIN}} and remove CommonNames.
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Fix For: 3.5.5
>
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820721#comment-16820721
]
TisonKun commented on ZOOKEEPER-3350:
-
Technically I agree with [~maoling].
However, it confuses me the TODO comment says "will get rid of it eventually".
{{CommonNames.DOMAIN}} is a constance that used to be shown on JMX. I'd prefer
learn the evolution of JMX usage in ZK.
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Assignee: TisonKun
>Priority: Major
> Fix For: 3.5.5
>
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-3350) Get rid of CommonNames
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813212#comment-16813212
]
maoling commented on ZOOKEEPER-3350:
*DATA_TREE_KEY*,*STANDALONE_SERVER_KEY* was never used any more.
Maybe we can do a refactor for this class.
give her a better name: JMXConstants.
remove the useless fields.
WDYT? [~Tison]
> Get rid of CommonNames
> --
>
> Key: ZOOKEEPER-3350
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3350
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx
>Affects Versions: 3.5.4
>Reporter: TisonKun
>Priority: Major
> Fix For: 3.5.5
>
>
> Inside {{CommonNames}} it says {{TODO: will get rid of it eventually.}}.
> However, I don't see the reason of such removal and since it came from over
> ten years ago I'd like to know whether it is still valid.
> cc [~phunt] [~anmolnar]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
