Re: The War on Warnings
My patch introduces a new Warnings mechanism for JS. If this works
nicely, I'd like to extend this to C++.
Basically, whenever you encounter a situation that should never happen
in production but that is not quite fatal enough to warrant a crash, we
call (from the top of my head)
Warnings.warn(the module that triggered the warning,
`Hey, I still have ${n} splines to reticulate, I should have 0.`);
By default, this causes tests to fail. However, tests that are designed
to cause this kind of warning can whitelist the warning with
Assert.expect(the module that triggered the warning,
/Hey, I still have [0-9]* splines to reticulate, I should have 0./)
(note the regexp)
and tests that are known to cause this kind of warning can graylist it
until the warning has been fixed
Assert.FIXME(the module that triggered the warning
/Hey, I still have [0-9]* splines to reticulate, I should have 0./)
(also a regexp)
This API covers all the needs I have encountered for warnings so far in
JS code. I don't think it's terribly different in C++ code.
Cheers,
David
On 05/06/15 00:14, Ehsan Akhgari wrote:
Families of warnings? I don't really understand what you mean. Also,
looking at the patch in the bug, your changes seem to affect Assert.jsm
stuff, which is not related to NS_WARNING.
--
David Rajchenbach-Teller, PhD
Performance Team, Mozilla
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
Re: what is new in talos, what is coming up
can we keep the snarkfest version running please until this is resolved? My main concern was because I inferred from the previous post that deprecation of snarkfest was scheduled on a timeline basis. Can we instead schedule on a when-its-ready basis, please? yes- we are not doing this on a time basis- datazilla deprecation is on a time schedule- the rest is not. Most likely this is an August/September thing- ideally within the next 4-6 weeks you will be using Perfherder happily for everything! Thanks for bringing up suggestions and using the new tools. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: How to override Components.utils.import to inject predefined symbols for all.
What exactly are you trying to do? On 05/06/15 09:22, 罗勇刚(Yonggang Luo) wrote: -- David Rajchenbach-Teller, PhD Performance Team, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: Firefox still blocks the (fixed) Java Deployment Toolkit click-to-play popup displays wrong item repeatedly
Hi Dan, Thanks for the explanation. At this point, I really believe that Mozilla needs to provide a link pointing to this explanation as well as a link to a ticket with Oracle. The issue that makes makes me so frustrated (and I'm guessing others like me who've read this thread) is the lack of communication and transparency from Mozilla. Yours is the first explanation that I've seen that describes the problem. I still believe that a difficult for average users to implement work-around would be an additional benefit, but given this explanation, I can at least understand why one doesn't exist. I'm not a proponent of Oracle, but the way this appears to the techie outsiders is that Mozilla is the bad guy. The mere fact that some posters left Firefox for other browsers (even if they're exaggerating or bluffing), means that it hasn't been handled well from a PR perspective. The issue looks bigger than it is merely due the lack of transparency. Thanks for your time and understanding , Eric On Wed, Jun 3, 2015 at 10:53 AM, Daniel Veditz dved...@mozilla.com wrote: The Java Deployment Kit can be used to force the use of a down-rev vulnerable version of Java if it's installed and even prompt for its installation (which a large number of users will fall for, even if a small percent). It's an enterprise feature and an enterprise-managed deployment of Firefox can serve their own blocklist. On the consumer web applets should work in the latest security-fixed versions of Java. If they are so large that won't work then they are applications, not applets, and should have the user install them as they would any other executable. -Dan Veditz ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
Re: The War on Warnings
On 2015/06/04 21:38, Robert O'Callahan wrote: Usually I use NS_WARNING to mean something weird and unexpected is happening, e.g. a bug in Web page code, but not necessarily a browser bug. Sometimes I get useful hints from NS_WARNING spew leading up to a serious failure, but for those usages could probably be switched to PR_LOG without losing much. Rob After coping with voluminous messages in C-C TB |make mozmill| test suite log [much smaller volume than full FF logs], I think we should have NS_INFORMATION() macro that prints out an information for someone who is developing code and just wants to know how the code is doing. So many WARNING lines such as the ones below can be turned into INFORMATION messages and we can probably ignore these lines from NG/GO decisions of tests. Hmm. The particular log I picked from two months ago is not quite representative. I specifically excluded NS_ENSURE_TRUE summary from below, but for this particular log, the messages near the top of list (decreasing frequency order) seem too serious to be INFORMATION kind. WARNING: Allow one letter C/c as language code.: The above line below is from my own attempt to make C-C TB accpet C.UTF-8 as locale: I think cygwin's default locale is this. But mozilla code refuses to accept this claiming that the first part of the locale needs to be either two or three letters. And I used dreaded NS_WARNING() instead of something better: if NS_INFORMATION() is there, I will use it. --- begin quote --- Second without NS_ENSURE macros: Count/sum is modulo [without the first PID] 1576 [10262] WARNING: '!mMainThread', file /REF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThreadManager.cpp, line 395 868 [10262] WARNING: Failed to retarget HTML data delivery to the parser thread.: file /REF-COMM-CENTRAL/comm-central/mozilla/parser/html/nsHtml5StreamParser.cpp, line 951 693 [10262] WARNING: Subdocument container has no frame: file /REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsDocumentViewer.cpp, line 2511 100 [21074] WARNING: We should have hit the document element...: file /REF-COMM-CENTRAL/comm-central/mozilla/layout/xul/BoxObject.cpp, line 183 58 [10262] WARNING: unable to post continuation event: file /REF-COMM-CENTRAL/comm-central/mozilla/xpcom/io/nsStreamUtils.cpp, line 453 58 [10262] WARNING: An event was posted to a thread that will never run it (rejected): file /REF-COMM-CENTRAL/comm-central/mozilla/xpcom/threads/nsThread.cpp, line 505 45 [10553] WARNING: No inner window available!: file /REF-COMM-CENTRAL/comm-central/mozilla/dom/base/nsGlobalWindow.cpp, line 9658 36 [10262] WARNING: Re-registering a CID?: file /REF-COMM-CENTRAL/comm-central/mozilla/xpcom/components/nsComponentManager.cpp, line 531 36 [10262] WARNING: Hardware Vsync support not yet implemented. Falling back to software timers 36 [10262] WARNING: Failed to open external DTD: publicId -//W3C//DTD SVG 1.1//EN systemId http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd; base file:///REF-COMM-CENTRAL/comm-central/mail/themes/linux/mail/tabs/selected-start.svg URL resource://gre/res/dtd/svg11.dtd: file /REF-COMM-CENTRAL/comm-central/mozilla/parser/htmlparser/nsExpatDriver.cpp, line 703 36 [10262] WARNING: Failed to open external DTD: publicId -//W3C//DTD SVG 1.1//EN systemId http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd; base file:///REF-COMM-CENTRAL/comm-central/mail/themes/linux/mail/tabs/selected-end.svg URL resource://gre/res/dtd/svg11.dtd: file /REF-COMM-CENTRAL/comm-central/mozilla/parser/htmlparser/nsExpatDriver.cpp, line 703 36 [10262] WARNING: Allow one letter C/c as language code.: file /REF-COMM-CENTRAL/comm-central/mozilla/intl/locale/unix/nsPosixLocale.cpp, line 128 35 [10262] WARNING: unable to Flush() dirty datasource during XPCOM shutdown: file /REF-COMM-CENTRAL/comm-central/mozilla/rdf/base/nsRDFXMLDataSource.cpp, line 754 35 WARNING: YOU ARE LEAKING THE WORLD (at least one JSRuntime and everything alive inside it, that is) AT JS_ShutDown TIME. FIX THIS! 32 [21074] WARNING: Must complete empty transaction when compositing!: file /REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsPresShell.cpp, line 6257 30 [21074] WARNING: Someone passed native anonymous content directly into frame construction. Stop doing that!: file /REF-COMM-CENTRAL/comm-central/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 6550 28 [21074] WARNING: nsMsgProtocol::SetContentCharset() not implemented: file /REF-COMM-CENTRAL/comm-central/mailnews/base/util/nsMsgProtocol.cpp, line 580 20 [21074] WARNING: anonymous nodes should not be in child lists (bug 439258): file /REF-COMM-CENTRAL/comm-central/mozilla/layout/base/RestyleManager.cpp, line 1441 18 [8115] WARNING: There is no observer for invalidformsubmit. One should be implemented!: file /REF-COMM-CENTRAL/comm-central/mozilla/dom/html/HTMLFormElement.cpp, line
Re: mozglue.dll!jemalloc_crash
You need to look further up the stack. jemalloc_crash is not an interesting stack frame. - Kyle On Fri, Jun 5, 2015 at 8:05 AM, Meenakshi Shankar hifromme...@gmail.com wrote: Hi, We are using Firefox SDKS for our FF extension (libs generated after compiling Firefox 39 beta 2 source using start-shell-msvc2013). With our extension enabled in Firefox, we receive a mozglue.dll!jemalloc_crash(...) With reference to bugzilla 1168291 we used mozcrt.lib for replacing mozalloc.lib, but still we see the crash in mozglue.dll. Also similar crash reported in bugzilla 1130180 and 1114791. Can anyone kindly let us know if this crash is fixed. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
