Post-Holiday reviews and needinfo responses

[Ryan VanderMeulen]

Hi everyone, happy New Year! As you return to work, please be sure to look
through your open review (in Bugzilla and Phabricator) and needinfo
requests at your earliest convenience. We've got about 2 weeks remaining in
the Fx65 Beta cycle before we start creating RC builds, so time is short
for getting fixes targeting that release landed.

Thanks!

-Ryan
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Skipping changesets when viewing blame

[Dave Townsend]

This is wonderful! Thanks especially for back-filling the eslint work.

On Wed, Jan 2, 2019 at 8:58 AM Felipe G  wrote:

> If you ran `mach bootstrap` or `mach vcs-setup` in the last month, you
> should already have a new hg command alias called `smart-annotate`, which
> runs `hg annotate` while ignoring some predefined changesets.
>
> The primary use case is to ignore (semi-)automatic code-formatting changes.
> The list of changesets to ignore comes from two sources:
>  - any commit that contains the string "ignore-this-changeset" in the
> summary (commit message) will be ignored automatically
>  - other commits that doesn't contain that string can be added to the
> .hg-annotate-ignore-revs
> 
> file
>
> Besides the command itself, there's also the "ignored_changesets" revset
> alias that you can use as you wish in other commands (e.g., `hg log -r
> ignored_changesets` will show you all the csets to be ignored)
>
> Sylvestre has included the "ignore-this-changeset" string in the tree-wide
> C++ style change patch, and we've gone and back-filled the
> .hg-annotate-ignore-revs file with previous eslint and clang-format
> changes.
>
> Happy New Year!
> Felipe
>
> (This work was tracked on bugs 1508002
>  and 1508324
> )
> ___
> dev-platform mailing list
> dev-platform@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-platform
>
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Skipping changesets when viewing blame

[Felipe G]

If you ran `mach bootstrap` or `mach vcs-setup` in the last month, you
should already have a new hg command alias called `smart-annotate`, which
runs `hg annotate` while ignoring some predefined changesets.

The primary use case is to ignore (semi-)automatic code-formatting changes.
The list of changesets to ignore comes from two sources:
 - any commit that contains the string "ignore-this-changeset" in the
summary (commit message) will be ignored automatically
 - other commits that doesn't contain that string can be added to the
.hg-annotate-ignore-revs
 file

Besides the command itself, there's also the "ignored_changesets" revset
alias that you can use as you wish in other commands (e.g., `hg log -r
ignored_changesets` will show you all the csets to be ignored)

Sylvestre has included the "ignore-this-changeset" string in the tree-wide
C++ style change patch, and we've gone and back-filled the
.hg-annotate-ignore-revs file with previous eslint and clang-format changes.

Happy New Year!
Felipe

(This work was tracked on bugs 1508002
 and 1508324
)
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to implement and ship: Overflow media queries

[Emilio Cobos Álvarez]

On 1/2/19 5:18 PM, James Graham wrote:

On 23/12/2018 10:59, Emilio Cobos Álvarez wrote:

web-platform-tests: Minimal parsing tests are being added to:

   https://wpt.fyi/results/css/mediaqueries/test_media_queries.html

Unfortunately WPT has no way to test print preview or pagination right 
now so the rest of reftests are Gecko-only.


Mind filing an issue on the wpt repo about the inability to test these 
features? It seems like something we could at least investigate, 
although I don't think there's currently any cross-browser API 
(including via e.g. WebDriver) for getting paginated layout.


I think this is covered already by:

  https://github.com/web-platform-tests/wpt/issues/7760

We have reftest-paged for this and also a programatic (yet not ideal) 
way to test print preview:



https://searchfox.org/mozilla-central/rev/0ee0b63732d35d16ba22d5a1120622e2e8d58c29/layout/base/tests/chrome/printpreview_helper.xul#26

 -- Emilio
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to implement and ship: Overflow media queries

[James Graham]

On 23/12/2018 10:59, Emilio Cobos Álvarez wrote:

web-platform-tests: Minimal parsing tests are being added to:

   https://wpt.fyi/results/css/mediaqueries/test_media_queries.html

Unfortunately WPT has no way to test print preview or pagination right 
now so the rest of reftests are Gecko-only.


Mind filing an issue on the wpt repo about the inability to test these 
features? It seems like something we could at least investigate, 
although I don't think there's currently any cross-browser API 
(including via e.g. WebDriver) for getting paginated layout.

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform