Running source code analysis on Try

[Bastien Abadie]

TL;DR: We are leveraging the try infrastructure to perform source code
analysis (linters, static analyzers, etc). You can take advantage of this
to trigger other try jobs on Phabricator revisions.

For more than a year, the Release Management & Quality team has been
running the Code review bot
 using several
Mozilla in-house projects: Taskcluster  &
release-services .

Our process was simple at first: for every new patch on Mozreview, then
Phabricator, we would run a few analyzers in a Taskcluster task. It worked
well for some time, but did not provide the flexibility nor the performance
needed to support more analyzers (clang-format, Infer, Coverity, …)

So we decided to experiment with a more scalable architecture, using
Treeherder/Try to run all necessary analyzers for your patches, in parallel.

This move will give us a lot of benefits:

   -

   The analyzers themselves are well defined and exposed in
   mozilla-central, allowing us to use the exact same tools as our usual CI
   and the developers on their computers.
   -

   Better overall performance and stability (from mercurial clones to
   running analyzers safely in parallel)
   -

   A standard analyzer output in JSON will allow us to easily add new
   analyzers. These new implementations could even come from you!


Over the last few months, we have been building the different pieces needed
to move the bot on the Try infrastructure, and today, I’m glad to announce
it’s running in production, on your revisions!

Any new Diff on Phabricator should now have a build plan named Source Code
Analysis .
Phabricator triggers a code review as soon as the diff is published,
automatically creating a new try job. You’ll get a “Treeherder Jobs” link
next to the build plan when it’s created by the bot, allowing you to check
on the analysis progress, and dive into the issues.


You will also be able to use Treeherder to add new jobs, effectively making
it possible to run try tests for Phabricator revisions in just a few
clicks. On a Treeherder push, open its action menu on the right side (right
after the Pin button). The "Add new jobs" options shows all the available
jobs grouped by platform and test suite, and you can click to select and
then submit. "Add new jobs (Search)" allows you to search in the job names
like mach try fuzzy and add them.

If the patch contains any issues, they will be reported as before, through
inline comments. You can now restart a build if it fails (click on the
Build, there is a “Restart Build” link in the right sidebar). Please note
that secure revisions are not supported for now, but we are actively
working on that (a build failure will be shown for secure revisions for the
time being).

We would like to thank the different people and teams involved in this
effort: Andrew from the Automation team; Tom, Rail, Chris and Rok from
Release Engineering; Dustin and Peter from the Taskcluster team; Steven,
glob and David from the Engineering Workflow team.

If you have any questions regarding this move or the code review bot, feel
free to contact us by mail or on IRC #static-analyzers.

Bastien, on the behalf of the Release Management and Quality team.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

[desktop] Bugs logged by Desktop Release QA in the last 7 days

[Cristian Comorasu]

Hello,

Here's the list of new issues found and filed by the Desktop Release QA 
team in the last 7 days.
Additional details on the team's priorities last week, as well as the 
plans for the current week are available at: http://tinyurl.com/y2pmvyvy.

Bugs logged by Desktop Release QA in the last 7 days:

Core: Audio/Video: Playback
NEW - https://bugzil.la/1546064 - [macOS] Flaky or no sound on youtube 
on high usage


Firefox: Activity Streams: Newtab
NEW - https://bugzil.la/1546311 - Favicons are not displayed for 
bookmarked pages from the Top Stories section from about:newtab


Toolkit: Startup and Profile System
VERIFIED FIXED - https://bugzil.la/1546326  - 
[Dedicated Profiles] The about:profiles page does not display correct 
information if a profile folder is deleted


Firefox: Site Identity and Permission Panels
VERIFIED FIXED - https://bugzil.la/1546367 - Report Problems panel still 
displays the description after sending the report


Firefox: General
NEW - https://bugzil.la/1546372 - Twitch does not enter fullscreen when 
the browser is smaller than fullscreen.


Firefox: Firefox Accounts
NEW - https://bugzil.la/1546379 - Inconsistency for the FxA icon 
position after updating from different FF versions


Firefox: Firefox Accounts
RESOLVED FIXED - https://bugzil.la/1546599 - FxA Name is not switched to 
default state after the user has disconnected from the account


DevTools: Inspector: Rules
ASSIGNED - https://bugzil.la/1546621 - Pseudo-element properties are not 
marked as overwritten in the rules inspector


Toolkit: Application Update
NEW - https://bugzil.la/1546627 - Update downloads performed via BITS 
are not successfully installed if Firefox is closed during the update 
process


Toolkit: Application Update
RESOLVED WONTFIX - https://bugzil.la/1546642 - Disabling BITS service 
after finishing the update download process in the background while 
Firefox is closed triggers the update download to be restarted via 
nsIIncremental when opening Firefox again


Cloud Services: Server: Firefox Accounts
NEW - https://bugzil.la/1546648 - No clear user feedback when user 
doesn't allow camera access to set account picture


Firefox: Extension Compatibility
NEW - https://bugzil.la/1546652 - [about:preferences#search] Some search 
engine extensions are still installed even after they were removed


Toolkit: Application Update
RESOLVED WORKSFORME - https://bugzil.la/1546679 - Crash in [@ 
mozilla::dom::workerinternals::RuntimeService::CrashIfHanging] after 
toggling app.update.BITS.enabled to true and restarting Firefox during 
the update download



Core: Graphics: WebRender
NEW - https://bugzil.la/1546725 - Rotating complicated models on 
Sketchfab causes display errors.


Devtools: Inspector: Rules
NEW - https://bugzil.la/1546896 - Selection made by keyboard shortcuts 
is not cleared in Rule view when adding a New Rule


Cloud Services
NEW - https://bugzil.la/1546899 - Invalid error displayed when Display 
name is to long in Manage Account section


Firefox: Sync
NEW - https://bugzil.la/1546386 - Check you email doorhanger is not 
displayed if the browser is restarted before confirming the sync email



This is available as a Bugzilla bug list as well: 
https://tinyurl.com/y3cqoffz.


Regards,

Cristian Comorasu

--
Comorasu Cristian Iulian
QC Engineer, QA


The content of this communication is classified as Softvision 
Confidential and Proprietary Information.


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform