Re: Is there any reason not to shut down bonsai?

2013-11-26 Thread Gervase Markham
On 21/11/13 21:12, Laura Thomson wrote:
 bonsai is old code, and written in very old-fashioned perl. As such,
 security bugs are frequently filed against it, and it's very hard to
 find people who are willing and able to fix them. If you are willing
 and able, let me know: I can hook you up with bugs as they arise.

We do have Perl expertise in the Bugzilla team...

ducks and runs

Seriously: can we put it behind a Mozillians-powered Persona login to
reduce the attack surface somewhat? At least then it would be safe from
automated scans.

Gerv
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-25 Thread Phil Ringnalda
On 11/21/13, 11:43 AM, Laura Thomson wrote:
 If you don't know what that is--and few people do, which is even more
 reason to shut it off--it's a search engine for some of our CVS
 repositories, of which I think none are in active development.

Thanks for the reminder that it still exists - I just used it to
successfully figure out what to do in the heat of tree-bustage-battle
(and no, I wouldn't have liked to install git, clone an enormous git
repo, and look up some complicated git command to do approximately the
same thing instead).
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-23 Thread Philip Chee
On 22/11/2013 03:57, Ms2ger wrote:
 On 11/21/2013 08:43 PM, Laura Thomson wrote:
 I'll keep it short and to the point. Are there any objections to
 shutting down http://bonsai.mozilla.org/cvsqueryform.cgi ?
 
 If you don't know what that is--and few people do, which is even
 more reason to shut it off--it's a search engine for some of our
 CVS repositories, of which I think none are in active development.
 
 It's the source of truth for pre-mercurial Gecko history; I find
 myself having to use it surprisingly often.
 
 HTH Ms2ger

And you know, in this Mercurial era we still don't have a tool that is
as good as bonsai.

Phil

-- 
Philip Chee phi...@aleytys.pc.my, philip.c...@gmail.com
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-23 Thread Philip Chee
On 22/11/2013 03:43, Laura Thomson wrote:
 I'll keep it short and to the point. Are there any objections to
 shutting down http://bonsai.mozilla.org/cvsqueryform.cgi ?
 
 If you don't know what that is--and few people do, which is even more
 reason to shut it off--it's a search engine for some of our CVS
 repositories, of which I think none are in active development.
 
 Cheers
 
 Laura Thomson Mozilla Web Engineering

It's very useful for code archaeology. Especially for older Netscape era
code where there was a tendency for NS employees to toss a large chunk
of code over the wall with little indication of what the code was
supposed to do.

Phil

-- 
Philip Chee phi...@aleytys.pc.my, philip.c...@gmail.com
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-23 Thread Philip Chee
On 22/11/2013 04:15, Gavin Sharp wrote:
 It would be good to explore alternatives to Bonsai.
 https://github.com/mozilla/mozilla-central is supposed to have full
 CVS history, right?

I would be very leery of putting our CVS source of truth on a non
mozilla managed domain.

Phil

-- 
Philip Chee phi...@aleytys.pc.my, philip.c...@gmail.com
http://flashblock.mozdev.org/ http://xsidebar.mozdev.org
Guard us from the she-wolf and the wolf, and guard us from the thief,
oh Night, and so be good for us to pass.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Aki Sasaki
On 11/21/13 8:56 PM, Jed Davis wrote:
 On Thu, Nov 21, 2013 at 05:41:27PM -0500, Boris Zbarsky wrote:
 On 11/21/13 3:15 PM, Gavin Sharp wrote:
 It would be good to explore alternatives to Bonsai.
 https://github.com/mozilla/mozilla-central is supposed to have full
 CVS history, right?

We're planning on moving to https://github.com/mozilla/gecko-dev in this
quarter.

 Hmm.  Where in there is the equivalent of 
 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Flayout%2Fhtml%2Fforms%2Fsrc%2FAttic%2FnsGfxTextControlFrame2.cpprev=cvsroot=%2Fcvsroot
 ?

 Granted, getting there in bonsai is a pain too, but that's what you
 have to do to get blame across file moves/deletes in CVS...

 I had to cheat somewhat, because git doesn't have an Attic, and...
 um, are we sure our CVS-to-Git conversion is entirely correct?  I'm seeing
 nsGfxTextControlFrame2.{cpp,h} being deleted in commit 252470c83 (bug 129909),
 but also that they were replaced by empty files in commit ec1abf4d5 (bug 
 88049)
 which seems wrong given a quick glance through the bug.

I'm not seeing this in gecko-dev; can you find this same issue in that repo?

 Anyway, having cheated and used bonsai to see the commit message for
 the deletion to help find the commits mentioned above (am I missing
 something, or does git-rev-parse not let you search for touched this
 path?), I can do this:

git log --grep 129909
requires knowing the bug number (or some other part of the commit
message), but doesn't require knowing the file path, and a |git show
rev| then shows the diff with file paths.

git log -- layout/html/forms/src/nsGfxTextControlFrame2.cpp
requires knowing the original file path, but doesn't require knowing the
bug number / commit message.

The second command gives me revision
9b33dcc62e6dc53a80e12c3e3d9f911b72f4ddce for bug 88049 that you
mentioned above; a |git show 9b33dcc62e6dc53a80e12c3e3d9f911b72f4ddce|
doesn't replace them with empty files, as far as I can tell.

 
   git blame 'ec1abf4d5^' -- layout/html/forms/src/nsGfxTextControlFrame2.cpp

This is |git blame 9b33dcc62e6dc53a80e12c3e3d9f911b72f4ddce^ --
layout/html/forms/src/nsGfxTextControlFrame2.cpp| in gecko-dev.

 and there's the blame (as of the first parent of ec1abf4d5, which is the
 last revision where the file exists and is non-empty).  Or, on the web:
 
   
 https://github.com/mozilla/mozilla-central/blame/ec1abf4d5^/layout/html/forms/src/nsGfxTextControlFrame2.cpp

The equivalent here would be:
https://github.com/mozilla/gecko-dev/blame/9b33dcc62e6dc53a80e12c3e3d9f911b72f4ddce^/layout/html/forms/src/nsGfxTextControlFrame2.cpp

aki

 
 Which is... not the prettiest interface to the blame data.
 
 --Jed
 

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Boris Zbarsky

On 11/22/13 12:11 PM, Aki Sasaki wrote:

 I'm not seeing this in gecko-dev; can you find this same issue in
 that repo?

No, this one behaves sanely.  Going to the parent of the relevant 
changeset gets you to a changeset where 
layout/html/forms/src/nsGfxTextControlFrame2.cpp is present, and even 
sanely findable using 't' in the github UI.  Good!



git log --grep 129909


Can this be done from the web UI, by any chance?

-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-22 Thread Aki Sasaki
On 11/22/13 1:06 PM, Boris Zbarsky wrote:
 On 11/22/13 12:11 PM, Aki Sasaki wrote:
 
 I'm not seeing this in gecko-dev; can you find this same issue in
 that repo?
 
 No, this one behaves sanely.  Going to the parent of the relevant
 changeset gets you to a changeset where
 layout/html/forms/src/nsGfxTextControlFrame2.cpp is present, and even
 sanely findable using 't' in the github UI.  Good!

Awesome.

 git log --grep 129909
 
 Can this be done from the web UI, by any chance?

I tried figuring it out in http://developer.github.com/v3/ , but the
closest I can see is downloading the entire recursive tree history and
then doing the search through that.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Reed Loden
On Thu, 21 Nov 2013 12:15:48 -0800
Gavin Sharp ga...@gavinsharp.com wrote:

 It would be good to explore alternatives to Bonsai.
 https://github.com/mozilla/mozilla-central is supposed to have full
 CVS history, right?

For mozilla-central, maybe? ... but there are a ton of other projects
that used Bonsai as well, and those don't have full history in other
places. Plus, there are definitely other projects that still live in
CVS entirely, and Bonsai is the only non-CVS way of viewing the
history/blame/etc.

So, no, Bonsai can't be shutdown.

~reed
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Boris Zbarsky

On 11/21/13 3:15 PM, Gavin Sharp wrote:

It would be good to explore alternatives to Bonsai.
https://github.com/mozilla/mozilla-central is supposed to have full
CVS history, right?


Hmm.  Where in there is the equivalent of 
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Flayout%2Fhtml%2Fforms%2Fsrc%2FAttic%2FnsGfxTextControlFrame2.cpprev=cvsroot=%2Fcvsroot 
?


Granted, getting there in bonsai is a pain too, but that's what you have 
to do to get blame across file moves/deletes in CVS...


For reference, the changeset that did the move is 
https://github.com/mozilla/mozilla-central/commit/a49b4c2c3536e467cd77b67cb549191129ca81d0 
and if I look at its parent and browse code I can get to 
https://github.com/mozilla/mozilla-central/tree/1b915b10542f2dbd08973d75a023a3c4fe43bbdc 
but then it just has an empty file for nsGfxTextControlFrame2.cpp?



- there's a learning curve to using any new tools


And, quite frankly, going back past a revision to see what the line 
looked like before it in bonsai blame is trivial (quickly edit the 
revision number in the url bar and you're done) while doing it with the 
github UI is rocket science.  Just like the hgweb UI.


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread smaug

On 11/21/2013 09:43 PM, Laura Thomson wrote:

I'll keep it short and to the point. Are there any objections to shutting down 
http://bonsai.mozilla.org/cvsqueryform.cgi ?

If you don't know what that is--and few people do, which is even more reason to 
shut it off--it's a search engine for some of our CVS repositories, of which I 
think none are in active development.

Cheers

Laura Thomson
Mozilla Web Engineering




Don't even think about closing down bonsai. I could perhaps live without
http://bonsai.mozilla.org/cvsqueryform.cgi, but 
http://bonsai.mozilla.org/cvsblame.cgi and http://bonsai.mozilla.org/cvslog.cgi
are super useful.
(I use http://mxr.mozilla.org/seamonkey/ and http://mxr.mozilla.org/mozilla1.8/ 
all the time and they link to bonsai. )



-Olli

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Gavin Sharp
I'm in the same boat - I use it relatively frequently to look up history.

Part of this is a form of habit - there are alternatives ways to get
at (most of?) that history now.

But I would be interested to know more about what killing it gains us,
in order to better evaluate the tradeoff.

Gavin

On Thu, Nov 21, 2013 at 11:57 AM, Ms2ger ms2...@gmail.com wrote:
 On 11/21/2013 08:43 PM, Laura Thomson wrote:

 I'll keep it short and to the point. Are there any objections to shutting
 down http://bonsai.mozilla.org/cvsqueryform.cgi ?

 If you don't know what that is--and few people do, which is even more
 reason to shut it off--it's a search engine for some of our CVS
 repositories, of which I think none are in active development.


 It's the source of truth for pre-mercurial Gecko history; I find myself
 having to use it surprisingly often.

 HTH
 Ms2ger


 ___
 dev-platform mailing list
 dev-platform@lists.mozilla.org
 https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Joshua Cranmer 

On 11/21/2013 3:12 PM, Laura Thomson wrote:

I can explain a little more about the motivation.

bonsai is old code, and written in very old-fashioned perl. As such, security 
bugs are frequently filed against it, and it's very hard to find people who are 
willing and able to fix them. If you are willing and able, let me know: I can 
hook you up with bugs as they arise.

I'd like to explore other ways of getting at the same data. For example, the 
search parts of bonsai should be able to be replaced with DXR in the very near 
future - I understand multi-tree support is landing in DXR next week (although 
we won't turn it on for a few weeks after that since we're waiting for the new 
UI to land too).


Even with omniglot in DXR, DXR currently outsources all blame to 
external tools (hgweb, github, etc.).


--
Joshua Cranmer
Thunderbird and DXR developer
Source code archæologist

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Ms2ger

On 11/21/2013 08:43 PM, Laura Thomson wrote:

I'll keep it short and to the point. Are there any objections to shutting down 
http://bonsai.mozilla.org/cvsqueryform.cgi ?

If you don't know what that is--and few people do, which is even more reason to 
shut it off--it's a search engine for some of our CVS repositories, of which I 
think none are in active development.


It's the source of truth for pre-mercurial Gecko history; I find myself 
having to use it surprisingly often.


HTH
Ms2ger

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Laura Thomson
I can explain a little more about the motivation.

bonsai is old code, and written in very old-fashioned perl. As such, security 
bugs are frequently filed against it, and it's very hard to find people who are 
willing and able to fix them. If you are willing and able, let me know: I can 
hook you up with bugs as they arise.

I'd like to explore other ways of getting at the same data. For example, the 
search parts of bonsai should be able to be replaced with DXR in the very near 
future - I understand multi-tree support is landing in DXR next week (although 
we won't turn it on for a few weeks after that since we're waiting for the new 
UI to land too).

I'll dig further into possible options and report back. If you want to help, 
know of a great modern replacement for bonsai, or would like to own it, let me 
know.
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread smaug

On 11/21/2013 10:15 PM, Gavin Sharp wrote:

It would be good to explore alternatives to Bonsai.
https://github.com/mozilla/mozilla-central is supposed to have full
CVS history, right?

Some concerns with that alternative:
- I think that repo misses some history from some branches of CVS
- I'm not confident that we've audited that whatever history is there
is complete/correct, and so losing easy access to the canonical source
could be problematic
- I don't think Github has a replacement for e.g.
http://bonsai.mozilla.org/cvsguess.cgi?file=textbox.xml (find a file
in CVS history including since-removed/forked files)
- there's a learning curve to using any new tools



Usability of https://github.com/mozilla/mozilla-central is too far behind 
bonsai.





Any other concerns with using Github as the alternative?

Are there other potential alternative solutions?

Gavin

On Thu, Nov 21, 2013 at 12:09 PM, Boris Zbarsky bzbar...@mit.edu wrote:

On 11/21/13 2:43 PM, Laura Thomson wrote:


it's a search engine for some of our CVS repositories



It's not just a search engine.  It's also the only way to get CVS blame
sanely without doing a local pull of the CVS repository or trying to make
git do something useful for you.  And a lot of our code dates back to that
CVS repository.

-Boris

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Boris Zbarsky

On 11/21/13 2:43 PM, Laura Thomson wrote:

it's a search engine for some of our CVS repositories


It's not just a search engine.  It's also the only way to get CVS blame 
sanely without doing a local pull of the CVS repository or trying to 
make git do something useful for you.  And a lot of our code dates back 
to that CVS repository.


-Boris
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Gregory Szorc

On 11/21/13, 1:12 PM, Laura Thomson wrote:

I can explain a little more about the motivation.

bonsai is old code, and written in very old-fashioned perl. As such, security 
bugs are frequently filed against it, and it's very hard to find people who are 
willing and able to fix them. If you are willing and able, let me know: I can 
hook you up with bugs as they arise.

I'd like to explore other ways of getting at the same data. For example, the 
search parts of bonsai should be able to be replaced with DXR in the very near 
future - I understand multi-tree support is landing in DXR next week (although 
we won't turn it on for a few weeks after that since we're waiting for the new 
UI to land too).

I'll dig further into possible options and report back. If you want to help, 
know of a great modern replacement for bonsai, or would like to own it, let me 
know.


6 years ago at a previous job, I replaced Bonsai with ViewVC (which is 
written in Python). We were using CVS and Subversion at the time. We 
wrote a simple mod_perl handler that 301'd Bonsai URLs to ViewVC 
equivalents so old URLs (especially in Bugzilla) would continue to work. 
(Unfortunately, I doubt that code is public domain, but I'm sure 
*somebody* has written and open sourced a version.)


As with any change, people complained (ViewVC isn't Bonsai, etc). But 
people quickly realized ViewVC was superior to Bonsai and everyone 
except a few of the complain-about-any-change type were satisfied and 
thought it was a good decision.


I highly encourage you to look at replacing Bonsai with ViewVC. (It's 
quite possible there's something better out there now - I last looked at 
this 6 years ago.)

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Gavin Sharp
It would be good to explore alternatives to Bonsai.
https://github.com/mozilla/mozilla-central is supposed to have full
CVS history, right?

Some concerns with that alternative:
- I think that repo misses some history from some branches of CVS
- I'm not confident that we've audited that whatever history is there
is complete/correct, and so losing easy access to the canonical source
could be problematic
- I don't think Github has a replacement for e.g.
http://bonsai.mozilla.org/cvsguess.cgi?file=textbox.xml (find a file
in CVS history including since-removed/forked files)
- there's a learning curve to using any new tools

Any other concerns with using Github as the alternative?

Are there other potential alternative solutions?

Gavin

On Thu, Nov 21, 2013 at 12:09 PM, Boris Zbarsky bzbar...@mit.edu wrote:
 On 11/21/13 2:43 PM, Laura Thomson wrote:

 it's a search engine for some of our CVS repositories


 It's not just a search engine.  It's also the only way to get CVS blame
 sanely without doing a local pull of the CVS repository or trying to make
 git do something useful for you.  And a lot of our code dates back to that
 CVS repository.

 -Boris

 ___
 dev-platform mailing list
 dev-platform@lists.mozilla.org
 https://lists.mozilla.org/listinfo/dev-platform
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Is there any reason not to shut down bonsai?

2013-11-21 Thread Laura Thomson
I'll keep it short and to the point. Are there any objections to shutting down 
http://bonsai.mozilla.org/cvsqueryform.cgi ?

If you don't know what that is--and few people do, which is even more reason to 
shut it off--it's a search engine for some of our CVS repositories, of which I 
think none are in active development. 

Cheers

Laura Thomson
Mozilla Web Engineering
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Frédéric Buclin
Le 21. 11. 13 21:19, smaug a écrit :
 Don't even think about closing down bonsai. I could perhaps live without
 http://bonsai.mozilla.org/cvsqueryform.cgi, but
 http://bonsai.mozilla.org/cvsblame.cgi and
 http://bonsai.mozilla.org/cvslog.cgi
 are super useful.

I totally agree with smaug. You can add cvsgraph.cgi to the list of
invaluable tools.

I use Bonsai several times per day (probably 10-20 times per day) to
track regressions, to track why such or such code was implemented the
way it was, to track who committed what and when, etc... I couldn't do
my job correctly without Bonsai. So please don't shut it down.


LpSolit

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Kevin Brosnan
Have we checked with the NSS or NSPR teams?

Kevin
On Nov 21, 2013 11:45 AM, Laura Thomson laur...@gmail.com wrote:

 I'll keep it short and to the point. Are there any objections to shutting
 down http://bonsai.mozilla.org/cvsqueryform.cgi ?

 If you don't know what that is--and few people do, which is even more
 reason to shut it off--it's a search engine for some of our CVS
 repositories, of which I think none are in active development.

 Cheers

 Laura Thomson
 Mozilla Web Engineering
 ___
 dev-platform mailing list
 dev-platform@lists.mozilla.org
 https://lists.mozilla.org/listinfo/dev-platform

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Mike Hommey
On Thu, Nov 21, 2013 at 05:56:12PM -0800, Jed Davis wrote:
 On Thu, Nov 21, 2013 at 05:41:27PM -0500, Boris Zbarsky wrote:
  On 11/21/13 3:15 PM, Gavin Sharp wrote:
  It would be good to explore alternatives to Bonsai.
  https://github.com/mozilla/mozilla-central is supposed to have full
  CVS history, right?
  
  Hmm.  Where in there is the equivalent of 
  http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Flayout%2Fhtml%2Fforms%2Fsrc%2FAttic%2FnsGfxTextControlFrame2.cpprev=cvsroot=%2Fcvsroot
  ?
  
  Granted, getting there in bonsai is a pain too, but that's what you
  have to do to get blame across file moves/deletes in CVS...
 
 I had to cheat somewhat, because git doesn't have an Attic, and...
 um, are we sure our CVS-to-Git conversion is entirely correct?  I'm seeing
 nsGfxTextControlFrame2.{cpp,h} being deleted in commit 252470c83 (bug 129909),
 but also that they were replaced by empty files in commit ec1abf4d5 (bug 
 88049)
 which seems wrong given a quick glance through the bug.
 
 Anyway, having cheated and used bonsai to see the commit message for
 the deletion to help find the commits mentioned above (am I missing
 something, or does git-rev-parse not let you search for touched this
 path?), I can do this:

You can find the commit that deleted the file with:
  git rev-list --max-count=1 HEAD -- 
layout/html/forms/src/nsGfxTextControlFrame2.cpp

or replace rev-list with log.

Mike
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Jed Davis
On Thu, Nov 21, 2013 at 05:41:27PM -0500, Boris Zbarsky wrote:
 On 11/21/13 3:15 PM, Gavin Sharp wrote:
 It would be good to explore alternatives to Bonsai.
 https://github.com/mozilla/mozilla-central is supposed to have full
 CVS history, right?
 
 Hmm.  Where in there is the equivalent of 
 http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Flayout%2Fhtml%2Fforms%2Fsrc%2FAttic%2FnsGfxTextControlFrame2.cpprev=cvsroot=%2Fcvsroot
 ?
 
 Granted, getting there in bonsai is a pain too, but that's what you
 have to do to get blame across file moves/deletes in CVS...

I had to cheat somewhat, because git doesn't have an Attic, and...
um, are we sure our CVS-to-Git conversion is entirely correct?  I'm seeing
nsGfxTextControlFrame2.{cpp,h} being deleted in commit 252470c83 (bug 129909),
but also that they were replaced by empty files in commit ec1abf4d5 (bug 88049)
which seems wrong given a quick glance through the bug.

Anyway, having cheated and used bonsai to see the commit message for
the deletion to help find the commits mentioned above (am I missing
something, or does git-rev-parse not let you search for touched this
path?), I can do this:

  git blame 'ec1abf4d5^' -- layout/html/forms/src/nsGfxTextControlFrame2.cpp

and there's the blame (as of the first parent of ec1abf4d5, which is the
last revision where the file exists and is non-empty).  Or, on the web:

  
https://github.com/mozilla/mozilla-central/blame/ec1abf4d5^/layout/html/forms/src/nsGfxTextControlFrame2.cpp

Which is... not the prettiest interface to the blame data.

--Jed

___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform


Re: Is there any reason not to shut down bonsai?

2013-11-21 Thread Jesse Ruderman
If we had blame enabled on http://git.mozilla.org/ would you be able to 
get what you need easily?


Currently, if I replace 'history' with 'blame' in a gitweb url, I get 
403 - Blame view not allowed :(


http://git.mozilla.org/?p=integration/gecko-dev.git;a=history;f=README.txt;h=da882f56b14bd8d07319a37954e19906c2898ab7;hb=298c09657eef1d2f29b4919d66f3880e637a03d7
___
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform