Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Josh Bowman-Matthews 
Yes, if there are types that derive Copy right now that are being 
modified in ways that forbid that (such as adding a Vec member), feel 
free to remove the derivation.


Cheers,
Josh

On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote:

Hi,
I am trying to write an implementation for the PeriodicWaveOptions in the
oscillator node. The parameters for this - real and imaginary, do not have
fixed sizes at compile time since they depend on the user input options.
This requires the use of the Vec datatype. However, vectors do not derive
copy and this means that the constructor does not have the derive.
Correspondingly, the OscillatorNodeOptions also cannot derive copy. Does
this mean the "derive copy" can be removed wherever necessary? If not, what
other datatype can be used for declaring the size at runtime?

Thank you


___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

[dev-servo] Rustfmt now checked on CI

2018-11-07 Thread Pyfisch 

Hi Everyone,

Servo source code is now formatted with rustfmt [1]. Style checking is 
part of ./mach test-tidy and enforced on CI. To automatically format 
your code run ./mach fmt before commiting. Import order was changed but 
./mach fmt will fix

any issues. Please ask any questions you may have.

Regards
Pyfisch

[1]: https://github.com/servo/servo/pull/22126


___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Rustfmt now checked on CI

2018-11-07 Thread Josh Bowman-Matthews 
Thank you for all your help in formatting the existing code and enabling 
rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we 
now have consistent formatting with the rest of the Rust ecosystem.


Cheers,
Josh

On 11/7/18 1:51 PM, Pyfisch wrote:

Hi Everyone,

Servo source code is now formatted with rustfmt [1]. Style checking is 
part of ./mach test-tidy and enforced on CI. To automatically format 
your code run ./mach fmt before commiting. Import order was changed but 
./mach fmt will fix

any issues. Please ask any questions you may have.

Regards
Pyfisch

[1]: https://github.com/servo/servo/pull/22126




___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Rustfmt now checked on CI

2018-11-07 Thread Keith Yeung 
Woohoo! Great work everyone!
On Wed, Nov 7, 2018 at 11:22 AM Josh Bowman-Matthews
 wrote:
>
> Thank you for all your help in formatting the existing code and enabling
> rustfmt in CI! I'm very pleased that we've adopted rustfmt and that we
> now have consistent formatting with the rest of the Rust ecosystem.
>
> Cheers,
> Josh
>
> On 11/7/18 1:51 PM, Pyfisch wrote:
> > Hi Everyone,
> >
> > Servo source code is now formatted with rustfmt [1]. Style checking is
> > part of ./mach test-tidy and enforced on CI. To automatically format
> > your code run ./mach fmt before commiting. Import order was changed but
> > ./mach fmt will fix
> > any issues. Please ask any questions you may have.
> >
> > Regards
> > Pyfisch
> >
> > [1]: https://github.com/servo/servo/pull/22126
> >
> >
>
> ___
> dev-servo mailing list
> dev-servo@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-servo
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Avanthikaa Ravichandran 
Thank you for your response.
I was also wondering if the statement
inputs.blocks.push(Default::default());
in "oscillator_node.rs" is the one setting default values for the
oscillator node wave? What exactly does this statement push into the input
blocks? From my understanding, this needs to be rewritten in order to
implement all the possible oscillator types of the node (Sine, Sawtooth
etc). Is this correct?

Thank you

On Wed, Nov 7, 2018 at 8:11 AM Josh Bowman-Matthews 
wrote:

> Yes, if there are types that derive Copy right now that are being
> modified in ways that forbid that (such as adding a Vec member), feel
> free to remove the derivation.
>
> Cheers,
> Josh
>
> On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote:
> > Hi,
> > I am trying to write an implementation for the PeriodicWaveOptions in the
> > oscillator node. The parameters for this - real and imaginary, do not
> have
> > fixed sizes at compile time since they depend on the user input options.
> > This requires the use of the Vec datatype. However, vectors do not derive
> > copy and this means that the constructor does not have the derive.
> > Correspondingly, the OscillatorNodeOptions also cannot derive copy. Does
> > this mean the "derive copy" can be removed wherever necessary? If not,
> what
> > other datatype can be used for declaring the size at runtime?
> >
> > Thank you
> >
> ___
> dev-servo mailing list
> dev-servo@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-servo
>

[image: Mailtrack]

Sender
notified by
Mailtrack

11/07/18,
6:22:28 PM
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo

Re: [dev-servo] Query regarding WebAudio node API - Implementing periodic wave options

2018-11-07 Thread Manish Goregaokar 
No, that creates an empty (silent) buffer for the oscillator generation to
write to.

The code that needs rewriting is the code that calls sin().

-Manish Goregaokar


On Wed, Nov 7, 2018 at 3:27 PM Avanthikaa Ravichandran 
wrote:

> Thank you for your response.
> I was also wondering if the statement
> inputs.blocks.push(Default::default());
> in "oscillator_node.rs" is the one setting default values for the
> oscillator node wave? What exactly does this statement push into the input
> blocks? From my understanding, this needs to be rewritten in order to
> implement all the possible oscillator types of the node (Sine, Sawtooth
> etc). Is this correct?
>
> Thank you
>
> On Wed, Nov 7, 2018 at 8:11 AM Josh Bowman-Matthews  >
> wrote:
>
> > Yes, if there are types that derive Copy right now that are being
> > modified in ways that forbid that (such as adding a Vec member), feel
> > free to remove the derivation.
> >
> > Cheers,
> > Josh
> >
> > On 11/6/18 8:09 PM, Avanthikaa Ravichandran wrote:
> > > Hi,
> > > I am trying to write an implementation for the PeriodicWaveOptions in
> the
> > > oscillator node. The parameters for this - real and imaginary, do not
> > have
> > > fixed sizes at compile time since they depend on the user input
> options.
> > > This requires the use of the Vec datatype. However, vectors do not
> derive
> > > copy and this means that the constructor does not have the derive.
> > > Correspondingly, the OscillatorNodeOptions also cannot derive copy.
> Does
> > > this mean the "derive copy" can be removed wherever necessary? If not,
> > what
> > > other datatype can be used for declaring the size at runtime?
> > >
> > > Thank you
> > >
> > ___
> > dev-servo mailing list
> > dev-servo@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-servo
> >
>
> [image: Mailtrack]
> <
> https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&;
> >
> Sender
> notified by
> Mailtrack
> <
> https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&;
> >
> 11/07/18,
> 6:22:28 PM
> ___
> dev-servo mailing list
> dev-servo@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-servo
>
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo