Re: [edk2-devel] [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md

[Xing, Eric via groups.io]

[AMD Official Use Only - AMD Internal Distribution Only]

Thanks Abner for the up-stream.

Looks good to me.
Reviewed-by: Eric Xing 


> -Original Message-
> From: Chang, Abner 
> Sent: Thursday, May 23, 2024 12:12 PM
> To: devel@edk2.groups.io
> Cc: Grimes, Paul ; Attar, AbdulLateef (Abdul Lateef)
> ; Fu, Igniculus ; Yao,
> Ken ; Xing, Eric ; Zhai, MingXin
> (Duke) 
> Subject: [edk2-platforms][PATCH 2/3] Platform/AMD: Update Readme.md
>
> From: Abner Chang 
>
> Cc: Paul Grimes 
> Cc: Abdul Lateef Attar 
> Cc: Igniculus Fu 
> Cc: Ken Yao 
> Cc: Eric Xing 
> Cc: Duke Zhai 
> Signed-off-by: Abner Chang 
> ---
>  Platform/AMD/Readme.md | 64 
> --
>  1 file changed, 49 insertions(+), 15 deletions(-)
>
> diff --git a/Platform/AMD/Readme.md b/Platform/AMD/Readme.md index
> 99d2b990c7..3297c6ba59 100644
> --- a/Platform/AMD/Readme.md
> +++ b/Platform/AMD/Readme.md
> @@ -7,18 +7,25 @@ booting certain AMD platforms. The definition of sub-
> folders is described in bel
>
>  ## Term and Definitions
>
> +* **AGESA**
> +
> +  AMD Generic Encapsulated Software Architecture that are executed as
> + part of a  host platform BIOS.
> +
>  * **AMD Platform** (platform in short)
>
> -  AMD platform refers to a platform that supports the particular AMD SoC
> (processor), such as AMD EPYC Milan and Genoa processors.
> +  AMD platform refers to a platform that supports the particular AMD
> + SoC (processor), such as  AMD EPYC Milan and Genoa processors.
>
>  * **AMD Board** (board in short)
>
>AMD board is a generic terminology refers to a board that is designed based
> on a
>specific AMD SoC architecture (also referred as AMD platform). More than
> one boards
> -  are possibly designed to support an AMD platform with different
> configuration, such as 1-processor socket or 2-processor sockets board.
> +  are possibly designed to support an AMD platform with different
> + configuration, such as  1-processor socket or 2-processor sockets board.
>
>  * **AMD edk2 Platform Package** (platform package in short)
> -
> +
>The folder has the AMD edk2 platform common modules.
>
>  * **AMD edk2 Board Package** (board package in short) @@ -28,29 +35,52
> @@ booting certain AMD platforms. The definition of sub-folders is described
> in bel
>
>  ## Package Definition
>
> +* **AgesaModulePkg**
> +
> +  This package contains all of the private interfaces and build
> + configuration files for the  AGESA support.
> +
> +* **AgesaPkg**
> +
> +  This package contains all of the public interfaces and build
> + configuration files  for the AGESA support.
> +
> +* **AmdCbsPkg**
> +
> +  AMD Configurable BIOS Setting. Provides the edk2 formset following
> + the UEFI HII  spec to configure BIOS settings.
> +
> +* **AmdCpmPkg**
> +
> +  AMD Common Platform Module software is a BIOS procedure library
> + designed to aid  AMD customers to quickly implement AMD platform
> technology into their products.
> +
>  * **AmdPlatformPkg**
>
> -  AMD platform edk2 package under this folder provides the common edk2
> modules those
> -  are leverage by platforms. Usually those modules have no dependencies
> with
> -  particular platforms. The module under this scope can provides a common
> implementation
> -  for all platforms, or it may just provide a framework but the differences 
> of
> implementation could be configured through the PCDs declared in
> AmdPlatformPkg.dec, or
> -  the board level library provided in the \Pkg.
> +  AMD platform edk2 package under this folder provides the common edk2
> + modules that are leveraged by platforms. Usually those modules have no
> + dependencies with  particular platforms. Modules under this scope can
> + provide a common implementation  for all platforms, or may just
> + provide a framework but the differences of implementation  could be
> + configured through the PCDs declared in AmdPlatformPkg.dec, or the board
> level  library provided in the \Pkg.
>
>  * **AmdMinBoardPkg**
>
> -  This package provides the common edk2 modules those can be leverage
> across AMD boards those use MinPlatformPkg framework.
> +  This package provides the common edk2 modules that can be leveraged
> + across AMD boards using  the MinPlatform framework.
>
>  * **\Board**
>
> -  This is the folder named by SoC and accommodate one or multiple board
> packages those
> -  are designed base on the same SoC platform. Board folder may
> contain edk2
> -  package meta files directly or the sub-folders named by \Pkg
> for a
> -  variety configurations of a platform.
> +  This is the folder named by SoC and accommodates one or multiple
> + board packages  that are designed based on the same SoC platform.  + name>Board folder may  contain edk2 package meta files directly or the
> + sub-folders named by \Pkg for  a variety configurations of a
> platform.
>
>  * **Pkg**
>
> -  This is the folder that contains edk2 package meta files for a board which 
> is
> designed base on a platform. Besides 

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Ard,

Please let me merge VangoGh board code next time after we finished the review 
process and build/verification test since I am maintainer and responsible for 
Vangogh Board platform code.

I will discuss it inside AMD to how to resolve current 
Platform/AMD/VanGoghBoard platform code build fail issue and reduce customer 
impact.
I will also discuss with Abner and other AMD reviewers to make a solution we 
want to move on.


Thanks,
Eric

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 10:12 PM
> To: Chang, Abner 
> Cc: Xing, Eric ; devel@edk2.groups.io; Zhai, MingXin
> (Duke) ; Lendacky, Thomas
> ; Yao, Ken ; Roth,
> Michael ; Attar, AbdulLateef (Abdul Lateef)
> ; Ard Biesheuvel
> ; Gerd Hoffmann ; Min
> Xu ; Leif Lindholm 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 15:00, Chang, Abner  wrote:
> >
> > [AMD Official Use Only - General]
> >
> > I guess my RB misled contributors thought the patch is good to merge.
> However, I was thinking Eric's team should give the final RB after the
> validation as they are the maintainers for the subordinate VanGoghBoard
> platform. Suppose the impacted packages should be built successfully with
> the patches applied, as this is considered the base requirement of the code
> change. Nevertheless, the special build sauce for VanGoghBoard may be not
> easy for contributors to verify the build.
> >
> > Eric, I have few suggestions for this failure, for the short term, you can
> commit another change to remove this change, as the build failure has
> impacts on our customer support. You can decide to recover this or not
> depends on your business requirement.
>
> Keeping edk2-platforms synced with edk2 is already complicated enough.
> So I object to changes to retain compatibility with downstream forks of EDK2.
> Surely, you are not telling your customers to use EDK202208 with whatever
> the top-of-tree of edk2-platforms is at any given moment?
>
> In any case, if upstream edk2 is important to you, please fix the current
> situation in edk2 first. If it is not important to you, I don't see a reason 
> to
> revert anything, and you can fix it in your downstream.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118055): https://edk2.groups.io/g/devel/message/118055
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Ard,

Agree with you, reverting code looks not a good way now. We will think about 
new method to resolve this issue. Just need a bit more time and I will hold on 
checking in code to VanGoghBoard before it.
Thanks again for your suggestion and help us improve code in VanGoghBoard.

Thanks,
Eric


> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 5:25 PM
> To: Xing, Eric 
> Cc: devel@edk2.groups.io; Zhai, MingXin (Duke) ;
> Lendacky, Thomas ; Chang, Abner
> ; Yao, Ken ; Roth, Michael
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Ard Biesheuvel
> ; Gerd Hoffmann ; Min
> Xu ; Leif Lindholm 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 11:06, Xing, Eric  wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Ard,
> >
> > This checkin causes VanGoghBoard build fail now. Would you help revert it?
> > I will merge PATCH to VanGoghBoard after the code review process done
> and code changes are verified pass on real board.
> >
>
> Please provide a solution instead that makes upstream edk2 work with
> upstream edk2-platforms.
>
> For downstream builds, you can combine the old EDK2_202208 with an older
> checkout of edk2-platforms, right?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118019): https://edk2.groups.io/g/devel/message/118019
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Ard,

This checkin causes VanGoghBoard build fail now. Would you help revert it?
I will merge PATCH to VanGoghBoard after the code review process done and code 
changes are verified pass on real board.

Thanks,
Eric

> -Original Message-
> From: Ard Biesheuvel 
> Sent: Friday, April 19, 2024 4:27 PM
> To: devel@edk2.groups.io; Xing, Eric 
> Cc: Zhai, MingXin (Duke) ; Lendacky, Thomas
> ; Chang, Abner ;
> Yao, Ken ; Roth, Michael ;
> Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel ; Gerd Hoffmann
> ; Min Xu ; Leif Lindholm
> 
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to
> required DSC files
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Fri, 19 Apr 2024 at 10:10, Xing, Eric via groups.io
>  wrote:
> >
> > [AMD Official Use Only - General]
> >
> >
> > Thanks Duke.
> >
> >
> >
> > Hi Thomas,
> >
> >
> >
> > PATCH1/2 still cannot be checked in because today’s VanGoghBoard is
> based off EDK2_202208. Please hold on this PATCH check in.
> >
> >
>
> Apologies, but I already merged this patch two days ago.
>
> edk2-platforms should build in combination with edk2. If your platform has
> other dependencies that are not in edk2, edk2-platforms or edk2-non-osi,
> please host and maintain the platform elsewhere.
>
> I also noticed that
> Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh requires that the
> various repo checkouts are inside the workspace, but the BaseTools don't
> actually require this. Personally, I use
>
> $HOME/edk2-workspace for the builds
>
> $HOME/edk2
> $HOME/edk2-platforms
> $HOME/edk2-non-osi
>
> for the checkouts, which keeps things separate, and allow me to wipe the
> workspace entirely without touching the repos.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118014): https://edk2.groups.io/g/devel/message/118014
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[Xing, Eric via groups.io]

[AMD Official Use Only - General]


Thanks Duke.



Hi Thomas,



PATCH1/2 still cannot be checked in because today’s VanGoghBoard is based off 
EDK2_202208. Please hold on this PATCH check in.



Added my comments below.



Thanks,

Eric



> -Original Message-

> From: Zhai, MingXin (Duke) 

> Sent: Friday, April 19, 2024 3:06 PM

> To: Lendacky, Thomas ; Xing, Eric

> ; Chang, Abner ; Yao, Ken

> ; devel@edk2.groups.io

> Cc: Roth, Michael ; Attar, AbdulLateef (Abdul

> Lateef) ; Ard Biesheuvel

> ; Gerd Hoffmann ; Min

> Xu ; Leif Lindholm ; Leif

> Lindholm 

> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> files

>

> [AMD Official Use Only - General]

>

> Hi Thomas,

>

> Yes, I agree with your opinion,  edk2-platforms should be able to build

> against the latest edk2 repo. That is why we plan to update VanGoghBoard to

> support latest EDK2, In fact we are doing QA testing.

[Xing, Eric] It is incorrect for edk2-platforms board code. We will not verify 
edk2-platform build test with latest edk2. See my comments below.

> I think every change on VanGoghBoard need ensure system can works

> properly. But if I apply this patch and use the latest EDK2 version to build, 
> it

> will encounter error because it requires other code changes(Such as including

> new libraries).

> So my point is, Let me upload VanGoghBoard related changes after passing

> full QA testing.

>

>

> Thanks!

>

> -Original Message-

> From: Lendacky, Thomas 
> mailto:thomas.lenda...@amd.com>>

> Sent: Friday, April 19, 2024 12:03 AM

> To: Zhai, MingXin (Duke) mailto:duke.z...@amd.com>>; Xing, 
> Eric

> mailto:eric.x...@amd.com>>; Chang, Abner 
> mailto:abner.ch...@amd.com>>; Yao, Ken

> mailto:ken@amd.com>>

> Cc: Roth, Michael mailto:michael.r...@amd.com>>; Attar, 
> AbdulLateef (Abdul

> Lateef) mailto:abdullateef.at...@amd.com>>

> Subject: Re: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> files

>

> On 4/18/24 05:02, Zhai, MingXin (Duke) wrote:

> > [AMD Official Use Only - General]

> >

> > Hi Thomas,

> >

> > this patch looks like for newer EDK2 codebase, but VanGoghBoard is based

> on EDK2_202208 now, and will encounter build issues if this patch is applied.

> > We have plans to update the EDK2 codebase to EDK2_202402. So I thought

> > it would be better to add this change when we update the EDK2 code

> > base

>

> I thought the latest edk2-platforms repo was supposed to be able to build

> against the latest edk2 repo.

[Xing, Eric] No. It will easily impact edk2-platforms BIOS if we pull in the 
latest edk2 repo. So, edk2-platforms will pull in a stable edk2 tag instead of 
latest edk2 repo.

>If your VanGoghBoard is based on a particular

> edk2 tag, then you should probably have a tag in edk2-platforms so that you

> can have a version of the edk2-platform code that works with a version of

> the edk2 code, no?

[Xing, Eric] I don’t think we will create tag for VanGoghBoard. Instead, we 
will have user guide/readme to let user know which EDK2 tag is supported in 
current board code.

The board code owner can decide when to update edk2 kernel and which Tage. I 
think it is the same for ALL board code, not only VanGoghBoard.

>

> Why is this a private email? This discussion should be on the list so that the

> maintainer(s) can decide what to do based on the discussion.

>

> Thanks,

> Tom

>

> >

> >

> > Thanks!

> >

> > -Original Message-

> > From: Xing, Eric mailto:eric.x...@amd.com>>

> > Sent: Thursday, April 18, 2024 9:54 AM

> > To: Chang, Abner mailto:abner.ch...@amd.com>>; 
> > Lendacky, Thomas

> > mailto:thomas.lenda...@amd.com>>; 
> > devel@edk2.groups.io; Zhai, MingXin

> (Duke)

> > mailto:duke.z...@amd.com>>; Yao, Ken 
> > mailto:ken@amd.com>>

> > Cc: Ard Biesheuvel 
> > mailto:ardb+tianoc...@kernel.org>>; Gerd Hoffmann

> > mailto:kra...@redhat.com>>; Roth, Michael 
> > mailto:michael.r...@amd.com>>; Min Xu

> > mailto:min.m...@intel.com>>; Leif Lindholm 
> > mailto:quic_llind...@quicinc.com>>;

> > Michael D Kinney 
> > mailto:michael.d.kin...@intel.com>>; Attar, 
> > AbdulLateef

> > (Abdul Lateef) mailto:abdullateef.at...@amd.com>>

> > Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC

> > files

> >

> > [AMD Official Use Only - General]

> >

> > Thanks Thomas and Abner.

> > Reviewed-by: mailto:eric.x...@amd.com>>

> >

> > For up-stream, please let us verify it first:

> > @Zhai, MingXin (Duke), Duke, please help verify this change on Chachani

> Board and feedback.

> >

> > Thanks,

> > Eric

> >

> >> -Original Message-

> >> From: Chang, Abner mailto:abner.ch...@amd.com>>

> >> Sent: Thursday, April 18, 2024 8:59 AM

> >> To: Lendacky, Thomas 
> >> mailto:thomas.lenda...@amd.com>>;

> devel@edk2.groups.io

> >> Cc: Ard Biesheuvel 
> >> mailto:ardb+tianoc...@kernel.org>>; Gerd 
> >> Hoffmann

> >> 

Re: [edk2-devel] [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC files

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Thanks Thomas and Abner.
Reviewed-by: 

For up-stream, please let us verify it first:
@Zhai, MingXin (Duke), Duke, please help verify this change on Chachani Board 
and feedback.

Thanks,
Eric

> -Original Message-
> From: Chang, Abner 
> Sent: Thursday, April 18, 2024 8:59 AM
> To: Lendacky, Thomas ;
> devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Roth, Michael ; Min Xu
> ; Leif Lindholm ;
> Michael D Kinney ; Attar, AbdulLateef (Abdul
> Lateef) ; Xing, Eric 
> Subject: RE: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
> files
>
> [AMD Official Use Only - General]
>
> Reviewed-by: 
>
> Thanks
>
> > -Original Message-
> > From: Lendacky, Thomas 
> > Sent: Monday, April 15, 2024 11:01 PM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel ; Gerd Hoffmann
> > ; Roth, Michael ; Min Xu
> > ; Leif Lindholm ;
> > Michael D Kinney ; Chang, Abner
> > ; Attar, AbdulLateef (Abdul Lateef)
> > ; Xing, Eric 
> > Subject: [PATCH 1/2] Platform/AMD: Add AmdSvsmLib to required DSC
> > files
> >
> > Any DSC file that uses the UefiCpuPkg MpInitLib library now requires
> > the AmdSvsmLib library. Update the DSC files to include the AmdSvsmLib
> > NULL library implementation. Also, fix the specification of VmgExitLib
> > as it was renamed to CcExitLib.
> >
> > Cc: Abner Chang 
> > Cc: Abdul Lateef Attar 
> > Cc: Eric Xing 
> > Signed-off-by: Tom Lendacky 
> > ---
> >  Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > index 20f06dd851..e478e0b0c2 100644
> > --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> > @@ -371,7 +371,8 @@
> >
> >  [LibraryClasses.common]
> >
> > RegisterFilterLib|MdePkg/Library/RegisterFilterLibNull/RegisterFilterL
> > RegisterFilterLib|ibNull.inf
> > -  VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> > +  CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
> > +  AmdSvsmLib|UefiCpuPkg/Library/AmdSvsmLibNull/AmdSvsmLibNull.inf
> >
> >  [PcdsFixedAtBuild]
> >
> gEfiAmdAgesaPkgTokenSpaceGuid.PcdFchOemBeforePciRestoreSwSmi|0xEA
> > --
> > 2.43.2
>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117941): https://edk2.groups.io/g/devel/message/117941
Mute This Topic: https://groups.io/mt/105537744/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] AMD/AmdPlatformPkg: Update AMD Vangogh platform reference code

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Below changes are reviewed and verified.

Reviewed-by: Eric Xing 

> -Original Message-
> From: Zhai, MingXin (Duke) 
> Sent: Tuesday, March 12, 2024 11:06 AM
> To: devel@edk2.groups.io
> Cc: Yao, Ken ; Fu, Igniculus ;
> Chang, Abner ; Xing, Eric 
> Subject: [PATCH] AMD/AmdPlatformPkg: Update AMD Vangogh platform
> reference code
>
> From: Duke Zhai 
>
> BZ #:4728
>
> 1.Use HPET timer to replace 8254 timer
> 2.Fix Bug Microcode version cannot show correctly at BIOS setup 3.Enable
> capsule at linux build 4.Update FspWrapper UPD table for BIOS setup options
>
> Cc: Ken Yao 
> Cc: Igniculus Fu 
> Reviewed-by: Abner Chang 
> Reviewed-by: Eric Xing 
> Signed-off-by: Duke Zhai 
> ---
>  .../BIOSImageDirectory32M.xml |  2 +-
>  .../ChachaniBoardPkg/GenCapsule.bat   |  2 +-
>  .../VanGoghBoard/ChachaniBoardPkg/Project.dsc |  2 -
>   .../VanGoghBoard/ChachaniBoardPkg/Project.fdf |  3 +-
>  .../VanGoghBoard/ChachaniBoardPkg/build.sh| 22 +-
>  .../edk2/Fsp2WrapperPkg/Include/FspmUpd.h | 71 ++-
>  .../FspWrapperPlatformLibSample.c | 29 
>  7 files changed, 59 insertions(+), 72 deletions(-)
>
> diff --git
> a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/BIOSImageDirectory32
> M.xml
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/BIOSImageDirectory32
> M.xml
> index 22af6623e2..585e12d487 100644
> ---
> a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/BIOSImageDirectory32
> M.xml
> +++
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/BIOSImageDirectory32
> M.x
> +++ ml
> @@ -57,7 +57,7 @@
>   File="TypeId0x65D0.csbin" />
>   File="TypeId0x64L1.csbin" />
>   File="TypeId0x65D1.csbin" />
> -
> +
>  
>
>  
> diff --git
> a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/GenCapsule.bat
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/GenCapsule.bat
> index 7dca22a4e3..c55f561772 100644
> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/GenCapsule.bat
> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/GenCapsule.bat
> @@ -36,7 +36,7 @@ if not exist %WORKSPACE%\%BIOS_FILE_NAME% (
>goto ERROR
>  )
>
> - Setup OpenSSL Command Line Environment
> +echo Setup OpenSSL Command Line Environment
>  if not "%OPENSSL_PATH%" == "" (
>set OPENSSL_PATH_TEMP=%OPENSSL_PATH%
>  )
> diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> index 510ce10c0c..20f06dd851 100644
> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.dsc
> @@ -745,8 +745,6 @@
>MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf
>FatPkg/EnhancedFatDxe/Fat.inf
>PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
> -  OvmfPkg/8259InterruptControllerDxe/8259.inf
> -  OvmfPkg/8254TimerDxe/8254Timer.inf
>
> MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa
> rePerformanceDxe.inf
>
> MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/Firmw
> arePerformanceSmm.inf
>
> diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.fdf
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.fdf
> index 5194a8c10d..0d844689b3 100644
> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.fdf
> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/Project.fdf
> @@ -416,8 +416,7 @@ NumBlocks = 0x100
># Platform
>#
>INF  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> -  INF  OvmfPkg/8259InterruptControllerDxe/8259.inf
> -  INF  OvmfPkg/8254TimerDxe/8254Timer.inf
> +  INF  PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf
>
>#
># ACPI
> diff --git a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh
> b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh
> index f4652e91c6..0984876ef2 100644
> --- a/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh
> +++ b/Platform/AMD/VanGoghBoard/ChachaniBoardPkg/build.sh
> @@ -1,3 +1,4 @@
> +#!/bin/bash
>  ## @file
>  # Linux build script file to launch Chachani Board BIOS build  # @@ -22,6
> +23,7 @@ export OemBoard=Chachani  export PLATFORM_PATH=edk2-
> platforms/Platform/AMD/VanGoghBoard
>  export BUILD_TYPE=RELEASE
>  export TOOLCHAIN_TAG=CLANGPDB
> +export OTA_CAPSULE_NAME=OTACAPSULE # You need to keep this name
> sync
> +with PlatformCapsule.fdf
>  #TRUE / FALSE
>  export COMPRESS_FSP_REGION=TRUE
>  export KEY_MODE=TK
> @@ -35,16 +37,25 @@ export NASM_PREFIX=
>  export GCC5_BIN=
>  #CLANG_BIN shall end with a slash.
>  export CLANG_BIN=
> +#OPENSSL_PATH shall end with a slash.
> +export OPENSSL_PATH=
>
>  echo "Building for ${OemBoard} board, ${BUILD_TYPE} mode with
> ${TOOLCHAIN_TAG}."
> -echo "IASL: ${IASL_PREFIX}iasl, NASM: ${NASM_PREFIX}nasm, GCC:
> ${GCC5_BIN}gcc, CLANG:${CLANG_BIN}clang."
> +echo "IASL: ${IASL_PREFIX}iasl, NASM: ${NASM_PREFIX}nasm, GCC:
> ${GCC5_BIN}gcc, CLANG:${CLANG_BIN}clang,
> OPENSSL:${OPENSSL_PATH}openssl."
>  [[ ${COMPRESS_FSP_REGION} == "TRUE" ]] && echo "FSP will be built with
> 

Re: [edk2-devel] [PATCH] AMD/VanGogh: Update VanGogh firmware binaries to UCC4126.3B30 Update firmware binaries for VanGogh B0 processors to UCC4126.3B30

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Thanks Duke.
Reviewed by: Eric Xing 

> -Original Message-
> From: duke.z...@amd.com 
> Sent: Thursday, January 25, 2024 5:56 PM
> To: devel@edk2.groups.io
> Cc: Xing, Eric ; Yao, Ken ; Fu,
> Igniculus ; Chang, Abner 
> Subject: [PATCH] AMD/VanGogh: Update VanGogh firmware binaries to
> UCC4126.3B30 Update firmware binaries for VanGogh B0 processors to
> UCC4126.3B30
>
> From: Duke Zhai 
>
> Signed-off-by: Duke Zhai 
> Cc: Eric Xing 
> Cc: Ken Yao 
> Cc: Igniculus Fu 
> Cc: Abner Chang 
> ---
>  Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin | Bin 262656 -> 262656
> bytes  Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin | Bin 262656 ->
> 262656 bytes
>  .../AMD/VanGogh/Firmwares/TypeId0x30.csbin| Bin 440144 -> 441216
> bytes
>  Silicon/AMD/VanGogh/Firmwares/TypeId0x66.bin  | Bin 3200 -> 3200
> bytes  .../AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3.bin | Bin 10796 ->
> 10796 bytes
>  .../Apcb/ApcbSet1Ff3DefaultRecovery.bin   | Bin 10796 -> 10796 bytes
>  .../FspBlobs/Apcb/ApcbSet1Ff3Updatable.bin| Bin 488 -> 488 bytes
>  .../AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3.bin | Bin 10796 -> 10796
> bytes
>  .../Apcb/ApcbSet2Ff3DefaultRecovery.bin   | Bin 10796 -> 10796 bytes
>  .../FspBlobs/Apcb/ApcbSet2Ff3Updatable.bin| Bin 504 -> 504 bytes
>  .../Fsp/VangoghSet1ExternalReleaseM.fd| Bin 786432 -> 786432 bytes
>  .../Fsp/VangoghSet1ExternalReleaseS.fd| Bin 524288 -> 524288 bytes
>  .../Fsp/VangoghSet2ExternalReleaseM.fd| Bin 786432 -> 786432 bytes
>  .../Fsp/VangoghSet2ExternalReleaseS.fd| Bin 524288 -> 524288 bytes
>  Silicon/AMD/VanGogh/ReleaseNote.txt   |  13 +
>  15 files changed, 13 insertions(+)
>
> diff --git a/Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin
> index c35c0ca..0dc2605 100644
> Binary files a/Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin and
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x08.sbin differ diff --git
> a/Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin
> index 3332cac..a38714a 100644
> Binary files a/Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin and
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x12.sbin differ diff --git
> a/Silicon/AMD/VanGogh/Firmwares/TypeId0x30.csbin
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x30.csbin
> index 8c6fcfd..2c15c9c 100644
> Binary files a/Silicon/AMD/VanGogh/Firmwares/TypeId0x30.csbin and
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x30.csbin differ diff --git
> a/Silicon/AMD/VanGogh/Firmwares/TypeId0x66.bin
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x66.bin
> index 3119039..e59c3fe 100644
> Binary files a/Silicon/AMD/VanGogh/Firmwares/TypeId0x66.bin and
> b/Silicon/AMD/VanGogh/Firmwares/TypeId0x66.bin differ diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3.bin
> index b8b3f08..10a246e 100644
> Binary files a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3.bin and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3.bin differ diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3DefaultRecovery.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3DefaultRecovery.bin
> index b8b3f08..10a246e 100644
> Binary files
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3DefaultRecovery.bin
> and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3DefaultRecovery.bin
> differ diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3Updatable.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3Updatable.bin
> index 3570f9b..4c01863 100644
> Binary files
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3Updatable.bin and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet1Ff3Updatable.bin differ
> diff --git a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3.bin
> index d476d2d..ab2186f 100644
> Binary files a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3.bin and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3.bin differ diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3DefaultRecovery.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3DefaultRecovery.bin
> index d476d2d..ab2186f 100644
> Binary files
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3DefaultRecovery.bin
> and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3DefaultRecovery.bin
> differ diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3Updatable.bin
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3Updatable.bin
> index 819ebb2..678eba6 100644
> Binary files
> a/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3Updatable.bin and
> b/Silicon/AMD/VanGogh/FspBlobs/Apcb/ApcbSet2Ff3Updatable.bin differ
> diff --git
> a/Silicon/AMD/VanGogh/FspBlobs/Fsp/VangoghSet1ExternalReleaseM.fd
> b/Silicon/AMD/VanGogh/FspBlobs/Fsp/VangoghSet1ExternalReleaseM.fd
> index 3b09a23..b0d27f2 100644
> Binary files
> a/Silicon/AMD/VanGogh/FspBlobs/Fsp/VangoghSet1ExternalReleaseM.fd
> and
> 

Re: [edk2-devel] [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Abner,

Thanks for your review, we have V2 patch improved the coding style issue.
[PATCH V2 33/33] AMD/VanGoghBoard: Improvement coding style

Thanks,
Eric

> -Original Message-
> From: Chang, Abner 
> Sent: Tuesday, January 23, 2024 12:44 PM
> To: Zhai, MingXin (Duke) ; devel@edk2.groups.io
> Cc: Xing, Eric ; Yao, Ken ; Fu,
> Igniculus 
> Subject: RE: [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg
>
> [AMD Official Use Only - General]
>
> Please review all C header files in this patch set. Remove the leading
> underscore and use double underscore at trailing.
> For example,
> _AGESA_H_ -> AGESA_H__
>
> Thanks
> Abner
>
> > -Original Message-
> > From: duke.z...@amd.com 
> > Sent: Thursday, January 18, 2024 2:50 PM
> > To: devel@edk2.groups.io
> > Cc: Xing, Eric ; Yao, Ken ; Fu,
> > Igniculus ; Chang, Abner
> 
> > Subject: [PATCH 04/33] AMD/VanGoghBoard: Check in AgesaPublic pkg
> >
> > From: Duke Zhai 
> >
> >
> > BZ #:4640
> >
> > Chachani board platform code depends on some AGESA-related
> PCDs/GUIDs.
> >
> > Add AgesaPublicPkg for AGESA-related PCDs/GUIDs to support platfrom
> build.
> >
> >
> >
> > Signed-off-by: Duke Zhai 
> >
> > Cc: Eric Xing 
> >
> > Cc: Ken Yao 
> >
> > Cc: Igniculus Fu 
> >
> > Cc: Abner Chang 
> >
> > ---
> >
> >  .../VanGoghBoard/AgesaPublic/AgesaPublic.dec  |  61 +
> >
> >  .../VanGoghBoard/AgesaPublic/Include/AGESA.h  |  35 +++
> >
> >  .../VanGoghBoard/AgesaPublic/Include/AMD.h| 189 +
> >
> >  .../AgesaPublic/Include/AmdPspDirectory.h |  55 
> >
> >  .../AgesaPublic/Include/FchRegistersCommon.h  |  23 ++
> >
> >  .../Include/Guid/AmdMemoryInfoHob.h   |  51 
> >
> >  .../Include/Library/AmdPspBaseLibV2.h | 248 ++
> >
> >  .../Include/Library/AmdPspCommonLib.h |  29 ++
> >
> >  .../Include/Library/AmdPspFtpmLib.h   |  94 +++
> >
> >  .../AgesaPublic/Include/Ppi/AmdPspFtpmPpi.h   |  80 ++
> >
> >  .../Include/Protocol/AmdPspFtpmProtocol.h | 112 
> >
> >  11 files changed, 977 insertions(+)
> >
> >  create mode 100644
> > Platform/AMD/VanGoghBoard/AgesaPublic/AgesaPublic.dec
> >
> >  create mode 100644
> > Platform/AMD/VanGoghBoard/AgesaPublic/Include/AGESA.h
> >
> >  create mode 100644
> > Platform/AMD/VanGoghBoard/AgesaPublic/Include/AMD.h
> >
> >  create mode 100644
> > Platform/AMD/VanGoghBoard/AgesaPublic/Include/AmdPspDirectory.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/FchRegistersCommon.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/Guid/AmdMemoryInfo
> H
> > ob.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/Library/AmdPspBaseLib
> V
> > 2.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/Library/AmdPspCommo
> > nLib.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/Library/AmdPspFtpmLib.
> > h
> >
> >  create mode 100644
> > Platform/AMD/VanGoghBoard/AgesaPublic/Include/Ppi/AmdPspFtpmPpi.h
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/AgesaPublic/Include/Protocol/AmdPspFtpmP
> r
> > otocol.h
> >
> >
> >
> > diff --git a/Platform/AMD/VanGoghBoard/AgesaPublic/AgesaPublic.dec
> > b/Platform/AMD/VanGoghBoard/AgesaPublic/AgesaPublic.dec
> >
> > new file mode 100644
> >
> > index 00..e987b9b603
> >
> > --- /dev/null
> >
> > +++ b/Platform/AMD/VanGoghBoard/AgesaPublic/AgesaPublic.dec
> >
> > @@ -0,0 +1,61 @@
> >
> > +## @file
> >
> > +# EDK II AgesaPublic.dec file
> >
> > +#
> >
> > +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
> >
> > +# SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +##
> >
> > +
> >
> > +[Defines]
> >
> > +  DEC_SPECIFICATION  = 0x00010005
> >
> > +  PACKAGE_NAME   = AgesaPublic
> >
> > +  PACKAGE_GUID   = EA54B0FA-908C-43DE-95A5-5E821A893CA4
> >
> > +  PACKAGE_VERSION= 0.1
> >
> > +
> >
> > +[Includes]
> >
> > +  Include
> >
> > +
> >
> > +[Guids]
> >
> > +  gEfiAmdAgesaModulePkgTokenSpaceGuid  = { 0x7788adf0, 0x9788,
> > 0x4a3f, { 0x83, 0xfa, 0xcb, 0x51, 0x2e, 0x7c, 0xf8, 0xdd } }
> >
> > +  gEfiAmdAgesaPkgTokenSpaceGuid= { 0xd4d8435f, 0xfffb, 0x4acb,
> > { 0xa0, 0x4d, 0xff, 0x0f, 0xad, 0x67, 0x7f, 0xe9 } }
> >
> > +  gAmdCpmPkgTokenSpaceGuid = { 0x916e0ddd, 0x2bd2, 0x4704,
> > { 0x93, 0xb9, 0x59, 0x4b, 0x01, 0xa5, 0xfa, 0x9f } }
> >
> > +  gAmdResourceSizeForEachRbGuid= { 0x542b8f2f, 0xbd52, 0x4233,
> > { 0x8c, 0x3d, 0x66, 0x53, 0x0d, 0xe8, 0xa3, 0x69 } }
> >
> > +  gAmdPbsSystemConfigurationGuid   = { 0xa339d746, 0xf678, 0x49b3,
> > { 0x9f, 0xc7, 0x54, 0xce, 0x0f, 0x9d, 0xf2, 0x26 } }
> >
> > +  gAmdTotalNumberOfRootBridgesGuid = { 0xfb5703f5, 0xf8a7, 0xf401,
> > { 0x18, 0xb4, 0x3f, 0x10, 0x8d, 0xeb, 0x26, 0x12 } }
> >
> > +  

Re: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in SmramSaveState module.

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Abner and Abdul,
Thanks for the review, it is good catch.
Currently, our current override files are based on UDK202208 code base now. 
AmdMmSaveStateLib.inf  is not existed in UDK2208 code base, we will leverage 
latest EDK2 changes after we update to new EDK2 code base.

Thanks,
Eric

> -Original Message-
> From: Chang, Abner 
> Sent: Tuesday, January 23, 2024 1:16 PM
> To: Attar, AbdulLateef (Abdul Lateef) ;
> devel@edk2.groups.io; Zhai, MingXin (Duke) 
> Cc: Xing, Eric ; Fu, Igniculus 
> Subject: RE: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in
> SmramSaveState module.
>
> [AMD Official Use Only - General]
>
> Yeah, please check if AMD specific SaveStatelib library under
> UefiCpuPkg/Library/MmSaveStateLib can cover the change or not.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Attar, AbdulLateef (Abdul Lateef) 
> > Sent: Saturday, January 20, 2024 10:38 PM
> > To: devel@edk2.groups.io; Zhai, MingXin (Duke) 
> > Cc: Xing, Eric ; Fu, Igniculus
> > ; Chang, Abner 
> > Subject: RE: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in
> > SmramSaveState module.
> >
> > [AMD Official Use Only - General]
> >
> > Why overriding the PiSmmCpuDxeSmm driver?
> > UefiCpuPkg has AMD specific SaveStatelib library
> > "UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf".
> >
> > Thanks
> > AbduL
> >
> > -Original Message-
> > From: devel@edk2.groups.io  On Behalf Of
> > duke.zhai via groups.io
> > Sent: Thursday, January 18, 2024 12:21 PM
> > To: devel@edk2.groups.io
> > Cc: Xing, Eric ; Zhai, MingXin (Duke)
> > ; Fu, Igniculus ; Chang,
> > Abner 
> > Subject: [edk2-devel] [PATCH 29/33] AMD/VanGoghBoard: Check in
> > SmramSaveState module.
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > From: Duke Zhai 
> >
> >
> > BZ #:4640
> >
> > Initial SmramSaveState module.
> >
> > This module provides services to access SMRAM Save State Map.
> >
> >
> >
> > Signed-off-by: Ken Yao 
> >
> > Cc: Eric Xing 
> >
> > Cc: Duke Zhai 
> >
> > Cc: Igniculus Fu 
> >
> > Cc: Abner Chang 
> >
> > ---
> >
> >  .../PiSmmCpuDxeSmm/SmramSaveState.c   | 715
> > ++
> >
> >  1 file changed, 715 insertions(+)
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/PiSmmCpuDxeS
> m
> > m/SmramSaveState.c
> >
> >
> >
> > diff --git
> >
> a/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/PiSmmCpuDxe
> > Smm/SmramSaveState.c
> >
> b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/PiSmmCpuDxe
> > Smm/SmramSaveState.c
> >
> > new file mode 100644
> >
> > index 00..9e5a7d59fc
> >
> > --- /dev/null
> >
> > +++
> >
> b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/PiSmmCpuDxe
> > Smm/SmramSaveState.c
> >
> > @@ -0,0 +1,715 @@
> >
> > +/** @file
> >
> > +  Implements SmramSaveState.c
> >
> > +
> >
> > +  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights
> > + reserved.
> >
> > +  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +/* This file includes code originally published under the following
> > +license. */
> >
> > +
> >
> > +/** @file
> >
> > +Provides services to access SMRAM Save State Map
> >
> > +
> >
> > +Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > +reserved.
> >
> > +SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +#include 
> >
> > +
> >
> > +#include 
> >
> > +
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +
> >
> > +#include "PiSmmCpuDxeSmm.h"
> >
> > +
> >
> > +typedef struct {
> >
> > +  UINT64Signature;  // Offset 0x00
> >
> > +  UINT16Reserved1;  // Offset 0x08
> >
> > +  UINT16Reserved2;  // Offset 0x0A
> >
> > +  UINT16Reserved3;  // Offset 0x0C
> >
> > +  UINT16SmmCs;  // Offset 0x0E
> >
> > +  UINT16SmmDs;  // Offset 0x10
> >
> > +  UINT16SmmSs;  // Offset 0x12
> >
> > +  UINT16SmmOtherSegment;// Offset 0x14
> >
> > +  UINT16Reserved4;  // Offset 0x16
> >
> > +  UINT64Reserved5;  // Offset 0x18
> >
> > +  UINT64Reserved6;  // Offset 0x20
> >
> > +  UINT64Reserved7;  // Offset 0x28
> >
> > +  UINT64SmmGdtPtr;  // Offset 0x30
> >
> > +  UINT32SmmGdtSize; // Offset 0x38
> >
> > +  UINT32Reserved8;  // Offset 0x3C
> >
> > +  UINT64

Re: [edk2-devel] [PATCH 28/33] AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module.

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Abner,
Thanks for the review, it is good catch.
Currently, our current override files are based on UDK202208 code base now. We 
will leverage latest EDK2 changes after we update to new EDK2 code base.

Thanks,
Eric

> -Original Message-
> From: Chang, Abner 
> Sent: Tuesday, January 23, 2024 1:14 PM
> To: Zhai, MingXin (Duke) ; devel@edk2.groups.io
> Cc: Xing, Eric ; Yao, Ken ; Fu,
> Igniculus 
> Subject: RE: [PATCH 28/33] AMD/VanGoghBoard: Check in
> SmmCpuFeaturesLibCommon module.
>
> [AMD Official Use Only - General]
>
> Please confirm if the latest edk2 SmmCpuFeatureLibCommon.c and
> AmdSmmCpuFeatureLib.c under SmmCpuFeatureLib can cover your changes
> in this patch or not.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: duke.z...@amd.com 
> > Sent: Thursday, January 18, 2024 2:51 PM
> > To: devel@edk2.groups.io
> > Cc: Xing, Eric ; Yao, Ken ; Fu,
> > Igniculus ; Chang, Abner
> 
> > Subject: [PATCH 28/33] AMD/VanGoghBoard: Check in
> > SmmCpuFeaturesLibCommon module.
> >
> > From: Duke Zhai 
> >
> >
> > BZ #:4640
> >
> > Initial SmmCpuFeaturesLibCommon module. The CPU specific
> programming
> > for
> >
> > PiSmmCpuDxeSmm module when STM support is not included.
> >
> >
> >
> > Signed-off-by: Duke Zhai 
> >
> > Cc: Eric Xing 
> >
> > Cc: Ken Yao 
> >
> > Cc: Igniculus Fu 
> >
> > Cc: Abner Chang 
> >
> > ---
> >
> >  .../SmmCpuFeaturesLibCommon.c | 629 ++
> >
> >  1 file changed, 629 insertions(+)
> >
> >  create mode 100644
> >
> Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmCpu
> > FeaturesLib/SmmCpuFeaturesLibCommon.c
> >
> >
> >
> > diff --git
> >
> a/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmC
> p
> > uFeaturesLib/SmmCpuFeaturesLibCommon.c
> >
> b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmC
> > puFeaturesLib/SmmCpuFeaturesLibCommon.c
> >
> > new file mode 100644
> >
> > index 00..7b07425336
> >
> > --- /dev/null
> >
> > +++
> >
> b/Platform/AMD/VanGoghBoard/Override/edk2/UefiCpuPkg/Library/SmmC
> > puFeaturesLib/SmmCpuFeaturesLibCommon.c
> >
> > @@ -0,0 +1,629 @@
> >
> > +/** @file
> >
> > +  Implements AMD SmmCpuFeaturesLibCommon.c
> >
> > +
> >
> > +  Copyright (C) 2024 Advanced Micro Devices, Inc. All rights
> > + reserved.
> >
> > +  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +/* This file includes code originally published under the following
> > +license. */
> >
> > +/** @file
> >
> > +Implementation shared across all library instances.
> >
> > +
> >
> > +Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > +reserved.
> >
> > +Copyright (c) Microsoft Corporation.
> >
> > +SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > +
> >
> > +**/
> >
> > +
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include 
> >
> > +#include "CpuFeaturesLib.h"
> >
> > +
> >
> > +//
> >
> > +// Machine Specific Registers (MSRs)
> >
> > +//
> >
> > +#define  SMM_FEATURES_LIB_IA32_MTRR_CAP0x0FE
> >
> > +#define  SMM_FEATURES_LIB_IA32_FEATURE_CONTROL 0x03A
> >
> > +#define  SMM_FEATURES_LIB_IA32_SMRR_PHYSBASE   0x1F2
> >
> > +#define  SMM_FEATURES_LIB_IA32_SMRR_PHYSMASK   0x1F3
> >
> > +#define  SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSBASE  0x0A0
> >
> > +#define  SMM_FEATURES_LIB_IA32_CORE_SMRR_PHYSMASK  0x0A1
> >
> > +#defineEFI_MSR_SMRR_MASK   0xF000
> >
> > +#defineEFI_MSR_SMRR_PHYS_MASK_VALIDBIT11
> >
> > +#define  SMM_FEATURES_LIB_SMM_FEATURE_CONTROL  0x4E0
> >
> > +
> >
> > +//
> >
> > +// MSRs required for configuration of SMM Code Access Check
> >
> > +//
> >
> > +#define SMM_FEATURES_LIB_IA32_MCA_CAP  0x17D
> >
> > +#define   SMM_CODE_ACCESS_CHK_BIT  BIT58
> >
> > +
> >
> > +extern UINT8  mSmmSaveStateRegisterLma;
> >
> > +
> >
> > +//
> >
> > +// Set default value to assume SMRR is not supported
> >
> > +//
> >
> > +BOOLEAN  mSmrrSupported = FALSE;
> >
> > +
> >
> > +//
> >
> > +// Set default value to assume MSR_SMM_FEATURE_CONTROL is not
> > supported
> >
> > +//
> >
> > +BOOLEAN  mSmmFeatureControlSupported = FALSE;
> >
> > +
> >
> > +//
> >
> > +// Set default value to assume IA-32 Architectural MSRs are used
> >
> > +//
> >
> > +UINT32  mSmrrPhysBaseMsr =
> > SMM_FEATURES_LIB_IA32_SMRR_PHYSBASE;
> >
> > +UINT32  mSmrrPhysMaskMsr =
> > SMM_FEATURES_LIB_IA32_SMRR_PHYSMASK;
> >
> > +
> >
> > +//
> >
> > +// Set default value to assume MTRRs need to be configured on each
> > +SMI
> >
> > +//
> >
> > +BOOLEAN  mNeedConfigureMtrrs = TRUE;
> >
> > +
> >
> > +//
> >
> > +// Array for state of SMRR enable on all CPUs
> >
> > +//
> >
> > +BOOLEAN  *mSmrrEnabled;
> >
> > +
> >
> > +/**
> >
> > +  Performs library initialization.
> >
> > +
> >
> > +  This initialization function contains common functionality shared
> > + 

Re: [edk2-devel] [PATCH 00/33] Introduce AMD Vangogh platform reference code

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Hi Duke,

Looks fine to me all 33 patch sets, I'd like to invite Abner help reviewing 
initial Vangogh platform reference code up-stream this time.

Reviewed-by: Eric Xing 

Thanks,
Eric


> -Original Message-
> From: duke.z...@amd.com 
> Sent: Thursday, January 18, 2024 3:13 PM
> To: devel@edk2.groups.io
> Cc: Xing, Eric ; Yao, Ken ; Fu,
> Igniculus ; Chang, Abner 
> Subject: [PATCH 00/33] Introduce AMD Vangogh platform reference code
>
> From: Duke Zhai 
>
>
> This AMD reference platform BIOS supports AMD Vangogh B0 SOC and
> Chachani board.
>
>
>
> Signed-off-by: Duke Zhai 
>
> Cc: Eric Xing 
>
> Cc: Ken Yao 
>
> Cc: Igniculus Fu 
>
> Cc: Abner Chang 
>
>
>
> Duke Zhai (33):
>
>   AMD/AmdPlatformPkg: Check in AMD S3 logo
>
>   AMD/VanGoghBoard: Check in ACPI tables
>
>   AMD/VanGoghBoard: Check in Capsule update
>
>   AMD/VanGoghBoard: Check in AgesaPublic pkg
>
>   AMD/VanGoghBoard: Check in PlatformSecLib
>
>   AMD/VanGoghBoard: Check in AmdIdsExtLib
>
>   AMD/VanGoghBoard: Check in PciPlatform
>
>   AMD/VanGoghBoard: Check in UDKFlashUpdate
>
>   AMD/VanGoghBoard: Check in Flash_AB
>
>   AMD/VanGoghBoard: Check in FlashUpdate
>
>   AMD/VanGoghBoard: Check in FvbServices
>
>   AMD/VanGoghBoard: Check in AMD BaseSerialPortLib
>
>   AMD/VanGoghBoard: Check in PlatformFlashAccessLib
>
>   AMD/VanGoghBoard: Check in SmbiosLib
>
>   AMD/VanGoghBoard: Check in SpiFlashDeviceLib
>
>   AMD/VanGoghBoard: Check in BaseTscTimerLib
>
>   AMD/VanGoghBoard: Check in Smm access module.
>
>   AMD/VanGoghBoard: Check in PciHostBridge module.
>
>   AMD/VanGoghBoard: Check in PcatRealTimeClockRuntimeDxe module.
>
>   AMD/VanGoghBoard: Check in FTPM module.
>
>   AMD/VanGoghBoard: Check in SignedCapsule.
>
>   AMD/VanGoghBoard: Check in Vtf0.
>
>   AMD/VanGoghBoard: Check in AcpiPlatform.
>
>   AMD/VanGoghBoard: Check in FchSpi module.
>
>   AMD/VanGoghBoard: Check in PlatformInitPei module.
>
>   AMD/VanGoghBoard: Check in Smbios platform dxe drivers.
>
>   AMD/VanGoghBoard: Check in Fsp2WrapperPkg.
>
>   AMD/VanGoghBoard: Check in SmmCpuFeaturesLibCommon module.
>
>   AMD/VanGoghBoard: Check in SmramSaveState module.
>
>   AMD/VanGoghBoard: Check in EDK2 override files.
>
>   AMD/VanGoghBoard: Check in AMD SmmControlPei module
>
>   AMD/VanGoghBoard: Check in Chachani board project files and build
>
> script.
>
>   AMD/VanGoghBoard: Improvement coding style.
>
>
>
>  .../AmdPlatformPkg/Universal/LogoDxe/Logo.c   |  198 +
>
>  .../Universal/LogoDxe/S3Logo.bmp  |  Bin 0 -> 964114 bytes
>
>  .../Universal/LogoDxe/S3Logo.idf  |9 +
>
>  .../Universal/LogoDxe/S3LogoDxe.inf   |   55 +
>
>  .../VanGoghBoard/AgesaPublic/AgesaPublic.dec  |   61 +
>
>  .../VanGoghBoard/AgesaPublic/Include/AGESA.h  |   35 +
>
>  .../VanGoghBoard/AgesaPublic/Include/AMD.h|  189 +
>
>  .../AgesaPublic/Include/AmdPspDirectory.h |   55 +
>
>  .../AgesaPublic/Include/FchRegistersCommon.h  |   23 +
>
>  .../Include/Guid/AmdMemoryInfoHob.h   |   51 +
>
>  .../Include/Library/AmdPspBaseLibV2.h |  248 +
>
>  .../Include/Library/AmdPspCommonLib.h |   29 +
>
>  .../Include/Library/AmdPspFtpmLib.h   |   94 +
>
>  .../AgesaPublic/Include/Ppi/AmdPspFtpmPpi.h   |   80 +
>
>  .../Include/Protocol/AmdPspFtpmProtocol.h |  112 +
>
>  .../Acpi/AcpiTables/AcpiTables.inf|   33 +
>
>  .../Acpi/AcpiTables/Dsdt/CPU.asl  |   22 +
>
>  .../Acpi/AcpiTables/Dsdt/Dsdt.asl |   36 +
>
>  .../Acpi/AcpiTables/Dsdt/FchShang.asi |  927 ++
>
>  .../Acpi/AcpiTables/Dsdt/GloblNvs.asl |   17 +
>
>  .../Acpi/AcpiTables/Dsdt/HOST_BUS.ASL |  209 +
>
>  .../Acpi/AcpiTables/Dsdt/LINK.ASL |  481 ++
>
>  .../Acpi/AcpiTables/Dsdt/Lpc0.asl |  168 +
>
>  .../Acpi/AcpiTables/Dsdt/PciTree.asl  |  776 ++
>
>  .../Acpi/AcpiTables/Dsdt/Platform.asl |  135 +
>
>  .../Acpi/AcpiTables/Dsdt/_PR.asl  |   36 +
>
>  .../Acpi/AcpiTables/Facs/Facs.h   |   45 +
>
>  .../Acpi/AcpiTables/Facs/Facs50.aslc  |   68 +
>
>  .../Acpi/AcpiTables/Fadt/Fadt.h   |   64 +
>
>  .../Acpi/AcpiTables/Fadt/Fadt50.aslc  |  159 +
>
>  .../Acpi/AcpiTables/Hpet/Hpet.h   |   70 +
>
>  .../Acpi/AcpiTables/Hpet/Hpet50.aslc  |   58 +
>
>  .../Acpi/AcpiTables/Madt/Madt.h   |  136 +
>
>  .../Acpi/AcpiTables/Madt/Madt50.aslc  |  327 +
>
>  .../Acpi/AcpiTables/Mcfg/Mcfg.h   |   75 +
>
>  .../Acpi/AcpiTables/Mcfg/Mcfg50.aslc  |   61 +
>
>  .../BIOSImageDirectory32M.xml |   63 +
>
>  .../VanGoghBoard/ChachaniBoardPkg/Board.env   |   23 +
>
>  .../ChachaniBoardPkg/BuildPspImage.bat|  126 +
>
>  .../SystemFirmwareDescriptor.aslc |   99 +
>
>  .../SystemFirmwareDescriptor.inf  |   53 +
>
>  .../SystemFirmwareDescriptorPei.c |   78 +
>
>  

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Thanks Leif for your quick response and reminder. I added Abner as CC in PATCH 
v2.
Sorry troubling you, would you help review it again so I can get your approved 
with v2 patch? Thanks again.

Eric

-Original Message-
From: Leif Lindholm 
Sent: Friday, September 29, 2023 12:15 AM
To: Xing, Eric 
Cc: devel@edk2.groups.io; Michael D Kinney ; Attar, 
AbdulLateef (Abdul Lateef) 
Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization 
firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and 
Silicon/AMD/Vangogh

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


+Abner

Looks fine to me, but I'd like to have a Reviewed-by from Abner, Abdul, Duke.

Best Regards,

Leif

On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.x...@amd.com wrote:
> From: Eric Xing 
>
> Signed-off-by: Eric Xing 
> Cc: Michael D Kinney 
> Cc: Leif Lindholm 
> Cc: Abdul Lateef Attar 
> Signed-off-by: Eric Xing 
> ---
>  Maintainers.txt | 9 +
>  1 file changed, 9 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg
>  M: Kathappan Esakkithevar 
>  M: Sai Chaganty 
>
> +Silicon/AMD
> +M: Abner Chang 
> +M: Abdul Lateef Attar 
> +M: Eric Xing 
> +
> +Silicon/AMD/Vangogh
> +M: Duke Zhai 
> +M: Eric Xing 
> +
>  Silicon/Ampere/AmpereAltraBinPkg
>  M: Nhi Pham 
>  M: Vu Nguyen 
> --
> 2.17.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109171): https://edk2.groups.io/g/devel/message/109171
Mute This Topic: https://groups.io/mt/101638924/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH v2] 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[Xing, Eric via groups.io]

From: Eric Xing 

Cc: Michael D Kinney 
Cc: Abner Chang 
Cc: Leif Lindholm 
Cc: Abdul Lateef Attar 
Signed-off-by: Eric Xing 
---
 Maintainers.txt | 9 +
 1 file changed, 9 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index c42d135..1d5dacb 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg
 M: Kathappan Esakkithevar 
 M: Sai Chaganty 
 
+Silicon/AMD
+M: Abner Chang 
+M: Abdul Lateef Attar 
+M: Eric Xing 
+
+Silicon/AMD/Vangogh
+M: Duke Zhai 
+M: Eric Xing 
+
 Silicon/Ampere/AmpereAltraBinPkg
 M: Nhi Pham 
 M: Vu Nguyen 
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109169): https://edk2.groups.io/g/devel/message/109169
Mute This Topic: https://groups.io/mt/101641927/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Thanks Abner for the kindly reminder. Will correct it next time.

Eric

From: Chang, Abner via groups.io 
Sent: Thursday, September 28, 2023 11:19 PM
To: Xing, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon 
initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for 
Silicon/AMD and Silicon/AMD/Vangogh

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Hi Eric,
You don't need the description follow "PATCH" actually, this makes the commit 
subject too lone. It is better to keep the subject short. You can put the 
detail information in the commit message body.

Thanks
Abner


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109168): https://edk2.groups.io/g/devel/message/109168
Mute This Topic: https://groups.io/mt/101638924/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon initialization firmware binaries

[Xing, Eric via groups.io]

[AMD Official Use Only - General]

Thanks Abner for the prompt review. Will follow coding standard and correct the 
new files’ name in PATCH V2.

Eric.

From: Chang, Abner via groups.io 
Sent: Thursday, September 28, 2023 11:23 PM
To: Xing, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon 
initialization firmware binaries 2/2] Silicon/AMD: Add VanGogh Silicon 
initialization firmware binaries

Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Hi Eric,
As the file naming is defined in the edk2 C coding standard, the AMD 
terminology used in the file name should follow edk2 C coding standard. Such as 
APCB should be Acpb, ABSupportNvramPei should be AbSupportNvnamePei.
Could you please review all of the files in this patch?
Thanks
Abner




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109167): https://edk2.groups.io/g/devel/message/109167
Mute This Topic: https://groups.io/mt/101638925/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-