Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
On Wed, 28 Feb 2024 at 17:59, Sami Mujawar wrote: > > +Resending with email address for maintainers. > > > > Hi Ard, Leif, > > This patch adds macros that can be used to validate that the SPI ranges are > valid. > These have been define here so that we do not duplicate it at multiple places. > > Can you let me know if I can merge this patch, please? > I have no problems with that, please go ahead. Acked-by: Ard Biesheuvel I will note that we will have to clean this up in the future, though: the architected GIC pieces should not be part of a library header, but a separate IndustryStandard/ header that is separate from the GIC library code. But that can wait until later. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116259): https://edk2.groups.io/g/devel/message/116259 Mute This Topic: https://groups.io/mt/103518972/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
+Resending with email address for maintainers. Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami Mujawar IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116123): https://edk2.groups.io/g/devel/message/116123 Mute This Topic: https://groups.io/mt/103518972/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
Hi Ard, Leif, This patch adds macros that can be used to validate that the SPI ranges are valid. These have been define here so that we do not duplicate it at multiple places. Can you let me know if I can merge this patch, please? Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116118): https://edk2.groups.io/g/devel/message/116118 Mute This Topic: https://groups.io/mt/103518972/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
Hi Himanshu, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 04/01/2024 08:02 am, Himanshu Sharma wrote: Taking reference from Table 2-1 of the Arm Generic Interrupt Controller Architecture Specification, Issue H, January 2022, add macros for the SPI and extended SPI ranges with the purpose of reusability on including the ArmPkg. Signed-off-by: Himanshu Sharma --- ArmPkg/Include/Library/ArmGicArchLib.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h index 72ac17e13b5a..ed6fe6fecb09 100644 --- a/ArmPkg/Include/Library/ArmGicArchLib.h +++ b/ArmPkg/Include/Library/ArmGicArchLib.h @@ -1,9 +1,15 @@ /** @file * * Copyright (c) 2015, Linaro Ltd. All rights reserved. +* Copyright (c) 2024, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * +* @par Reference(s): +* - Arm Generic Interrupt Controller Architecture Specification, +*Issue H, January 2022. +*(https://developer.arm.com/documentation/ihi0069/) +* **/ #ifndef ARM_GIC_ARCH_LIB_H_ @@ -23,4 +29,12 @@ ArmGicGetSupportedArchRevision ( VOID ); +// +// GIC SPI and extended SPI ranges +// +#define ARM_GIC_ARCH_SPI_MIN 32 +#define ARM_GIC_ARCH_SPI_MAX 1019 +#define ARM_GIC_ARCH_EXT_SPI_MIN 4096 +#define ARM_GIC_ARCH_EXT_SPI_MAX 5119 + #endif // ARM_GIC_ARCH_LIB_H_ -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113185): https://edk2.groups.io/g/devel/message/113185 Mute This Topic: https://groups.io/mt/103518972/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [edk2][PATCH V2 1/2] ArmPkg/ArmGicArchLib: Add macros for SPI and extended SPI ranges
Taking reference from Table 2-1 of the Arm Generic Interrupt Controller Architecture Specification, Issue H, January 2022, add macros for the SPI and extended SPI ranges with the purpose of reusability on including the ArmPkg. Signed-off-by: Himanshu Sharma --- ArmPkg/Include/Library/ArmGicArchLib.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/ArmPkg/Include/Library/ArmGicArchLib.h b/ArmPkg/Include/Library/ArmGicArchLib.h index 72ac17e13b5a..ed6fe6fecb09 100644 --- a/ArmPkg/Include/Library/ArmGicArchLib.h +++ b/ArmPkg/Include/Library/ArmGicArchLib.h @@ -1,9 +1,15 @@ /** @file * * Copyright (c) 2015, Linaro Ltd. All rights reserved. +* Copyright (c) 2024, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * +* @par Reference(s): +* - Arm Generic Interrupt Controller Architecture Specification, +*Issue H, January 2022. +*(https://developer.arm.com/documentation/ihi0069/) +* **/ #ifndef ARM_GIC_ARCH_LIB_H_ @@ -23,4 +29,12 @@ ArmGicGetSupportedArchRevision ( VOID ); +// +// GIC SPI and extended SPI ranges +// +#define ARM_GIC_ARCH_SPI_MIN 32 +#define ARM_GIC_ARCH_SPI_MAX 1019 +#define ARM_GIC_ARCH_EXT_SPI_MIN 4096 +#define ARM_GIC_ARCH_EXT_SPI_MAX 5119 + #endif // ARM_GIC_ARCH_LIB_H_ -- 2.25.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113141): https://edk2.groups.io/g/devel/message/113141 Mute This Topic: https://groups.io/mt/103518972/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
